Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-04 Thread Wen Congyang
At 11/04/2011 10:48 AM, Zhi Yong Wu Write: On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang we...@cn.fujitsu.com wrote: We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It will cause that the guest can not be rebooted. Actually i also met this

Re: [Qemu-devel] The mainpage of QEMU.org is attacked?

2011-11-04 Thread Stefan Weil
Am 04.11.2011 03:56, schrieb Anthony Liguori: On 11/03/2011 09:43 PM, Zhi Yong Wu wrote: HI, Just now i found that the mainpage of QEMU.org is hacked, right? http://wiki.qemu.org/Main_Page Not hacked, it's a wiki, so it's vulnerable to spam. Folks have been doing a great job reverting the

Re: [Qemu-devel] [PATCH V3 05/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.

2011-11-04 Thread Isaku Yamahata
Good catch. This patch (and the next one 6/10) can be picked up independently through qemu-trivial or pci-tree. On Fri, Oct 28, 2011 at 04:07:31PM +0100, Anthony PERARD wrote: Value check in PCI Express Base Specification rev 1.1 Signed-off-by: Anthony PERARD anthony.per...@citrix.com ---

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 03:45 AM, Wen Congyang wrote: We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It will cause that the guest can not be rebooted. Signed-off-by: Wen Congyangwe...@cn.fujitsu.com --- cpus.c |1 + 1 files changed, 1

[Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in cow.c

2011-11-04 Thread Li Zhi Hui
Since common file operation functions lack of error detection, so change them to bdrv series functions. Signed-off-by: Li Zhi Hui zhihu...@linux.vnet.ibm.com --- block/cow.c | 63 +- 1 files changed, 36 insertions(+), 27 deletions(-)

Re: [Qemu-devel] qemu ARM host support likely to be broken in 1.0

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 02:52 AM, Peter Maydell wrote: * the fixed address we mmap the code gen buffer to in system mode tends to overlap the libc heap (at least on Ubuntu oneiric); when this happens you typically get a sysmalloc abort Let's change this to use the .bss code gen buffer. We can make it

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Stefan Hajnoczi
On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011 at 5:39 PM, Fabien Chouteau chout...@adacore.com wrote: On 29/10/2011 15:52, Alexander Graf wrote: I took a quick peak at the qemu-trace.[ch] from couverture

Re: [Qemu-devel] [RFC] block: convert block_stream command to QAPI

2011-11-04 Thread Stefan Hajnoczi
On Thu, Nov 03, 2011 at 01:51:54PM -0200, Luiz Capitulino wrote: On Tue, 1 Nov 2011 18:08:16 + Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Move from plain HMP/QMP command implementation to QAPI. The block_stream command takes arguments, returns nothing, may raise errors, and

Re: [Qemu-devel] [PATCH 3/8] block: add image streaming block job

2011-11-04 Thread Stefan Hajnoczi
On Thu, Nov 03, 2011 at 02:34:24PM -0200, Marcelo Tosatti wrote: On Wed, Nov 02, 2011 at 03:43:49PM +, Stefan Hajnoczi wrote: On Tue, Nov 1, 2011 at 6:06 PM, Marcelo Tosatti mtosa...@redhat.com wrote: On Thu, Oct 27, 2011 at 04:22:50PM +0100, Stefan Hajnoczi wrote: + +    for

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Thomas Schmitt
Hi i can prevent the EPERM failures of ioctl(SG_IO) by opening the device file /dev/sg1 with O_RDWR rather than O_RDONLY. In block/raw-posix.c:raw_open_common i implemented this hack: printf(block/raw-posix.c: raw_open_common(\%s\, %x)\n, filename, s-open_flags); if

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-04 Thread Fabien Chouteau
On 03/11/2011 12:50, Paolo Bonzini wrote: On 11/03/2011 11:29 AM, Avi Kivity wrote: It would ensure that two mutators wouldn't run concurrently. In some sense, signal-safe code could then be considered thread-safe too. How so? The scheduler can switch between the two threads on every

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 10:27 AM, Fabien Chouteau wrote: It's a huge assumption though, and I don't think it should be assumed anymore. What can we do to improve that? Remove the affinity change and see what breaks. :) With iothread the architecture of the QEMU main loop is anyway completely

[Qemu-devel] [PATCH] qxl: Slot sanity check in qxl_phys2virt() is off by one, fix

2011-11-04 Thread Markus Armbruster
Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 84ffd45..c97bebe 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1006,7 +1006,7 @@ void *qxl_phys2virt(PCIQXLDevice

[Qemu-devel] [PATCH] console: Fix rendering of VGA underline

2011-11-04 Thread Markus Armbruster
vga_putcharxy()'s underline code sets font_data to 0x instead of 0xff. vga_putcharxy() then reads dmask16[0x 4] and dmask4[0x 6]. In practice, these out-of-bounds subscripts only put a few crap bits into the display surface. For 32 bit pixels, there's no array access. font_data's

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 10:18 AM, Thomas Schmitt wrote: Paolo: May i ask for the favor that you try to add O_RDWR to the qemu_open() call of passthrough devices ? I think the problem is that you're passing media=cdrom: if (media == MEDIA_CDROM) { /* CDROM is fine for any interface, don't

Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in cow.c

2011-11-04 Thread Markus Armbruster
Li Zhi Hui zhihu...@linux.vnet.ibm.com writes: Since common file operation functions lack of error detection, so change them to bdrv series functions. Looks like a few indentation fixes crept in as well. Best to keep such style cleanups well separated from functional changes.

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-11-04 Thread Paolo Bonzini
On 10/28/2011 02:17 PM, Paolo Bonzini wrote: Yes, it would be better if we could have error output on stderr. Now, simple errors such as a missing image file (or wrong path to the image) are reported to syslog instead. It could be the source of some headaches... Is there a way we could have the

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Fabien Chouteau
On 04/11/2011 09:36, Stefan Hajnoczi wrote: On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011 at 5:39 PM, Fabien Chouteau chout...@adacore.com wrote: On 29/10/2011 15:52, Alexander Graf wrote: I took a quick peak

Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in cow.c

2011-11-04 Thread Stefan Hajnoczi
On Fri, Nov 04, 2011 at 03:43:04PM +0800, Li Zhi Hui wrote: Since common file operation functions lack of error detection, so change them to bdrv series functions. Signed-off-by: Li Zhi Hui zhihu...@linux.vnet.ibm.com --- block/cow.c | 63

Re: [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd block_set_hostcache for dynamic cache change

2011-11-04 Thread Kevin Wolf
Am 30.10.2011 11:34, schrieb Supriya Kannery: New command block_set_hostcache added for dynamically changing host pagecache setting of a block device. Usage: block_set_hostcache device option device = block device option = on/off Example: (qemu) block_set_hostcache ide0-hd0

Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-04 Thread Kevin Wolf
Am 30.10.2011 11:35, schrieb Supriya Kannery: Struct BDRVReopenState along with three reopen related functions introduced for handling reopen state of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya Kannery

[Qemu-devel] [PATCH] readline: Fix buffer overrun on re-add to history

2011-11-04 Thread Markus Armbruster
readline_hist_add() moves the history entry to the end of history. It uses memmove() to move rs-history[idx + 1..] to rs-history[idx..]. However, its size argument is off by two array elements, so it writes one element beyond rs-history[], and reads two. On my system, this clobbers rs-hist_entry

Re: [Qemu-devel] [v8 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-04 Thread Kevin Wolf
Am 30.10.2011 11:35, schrieb Supriya Kannery: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically, is handled here. Signed-off-by: Supriya Kannery supri...@linux.vnet.ibm.com Index:

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-11-04 Thread Kevin Wolf
Am 04.11.2011 10:46, schrieb Paolo Bonzini: On 10/28/2011 02:17 PM, Paolo Bonzini wrote: Yes, it would be better if we could have error output on stderr. Now, simple errors such as a missing image file (or wrong path to the image) are reported to syslog instead. It could be the source of some

[Qemu-devel] Windows 7 shutdown causes BSOD

2011-11-04 Thread Stefan Hajnoczi
Windows 7 32-bit guest blue screens when I shut it down properly with Start | Shut Down. The blue screen is only displayed for a split second before the guest reboots so I am not able to easily tell what it says. My guess is that Windows is triple-faulting or soft rebooting - note that I told

Re: [Qemu-devel] [0/7] Remove unnecessary casts introduced by PCI DMA stubs series

2011-11-04 Thread Andreas Färber
Am 04.11.2011 02:03, schrieb David Gibson: As a few people pointed out, my recent patch series introducing a new (stub) PCI DMA API added unnecessary casts in quite a few places. I think this was a hangover from early days of the patchese where the casts were necessary for some reason I've

Re: [Qemu-devel] [PATCH] qmp: report TRAY_STATE_CHANGED events

2011-11-04 Thread Paolo Bonzini
On 11/01/2011 06:03 AM, ShaoHe Feng wrote: after the guest startups, then I right click mouse in the UI of the guest, and select the Eject from the menu. there comes an event in the qmp-monitor. {timestamp: {seconds: 1320118137, microseconds: 420150}, event: TRAY_STATE_CHANGED, data: {device:

Re: [Qemu-devel] [v8 Patch 1/6]Qemu: Enhance info block to display host cache setting

2011-11-04 Thread Supriya Kannery
On 11/03/2011 07:25 PM, Luiz Capitulino wrote: On Sun, 30 Oct 2011 16:03:54 +0530 Supriya Kannerysupri...@linux.vnet.ibm.com wrote: +if (qdict_haskey(bs_dict, hostcache)) { +monitor_printf(mon, hostcache=%d, + qdict_get_bool(bs_dict, hostcache)); +}

Re: [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd block_set_hostcache for dynamic cache change

2011-11-04 Thread Supriya Kannery
On 11/04/2011 03:30 PM, Kevin Wolf wrote: Am 30.10.2011 11:34, schrieb Supriya Kannery: + +if (bdrv_is_inserted(bs)) { +/* Reopen file with changed set of flags */ +return bdrv_reopen(bs, bdrv_flags); +} else { +/* Save hostcache change for future use */ +

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Thomas Schmitt
Hi, i wrote: Paolo: May i ask for the favor that you try to add O_RDWR to the qemu_open() call of passthrough devices ? Paolo Bonzini wrote: I think the problem is that you're passing media=cdrom: Just do not do that when using scsi-generic. The result looks promising, indeed. I

Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely

2011-11-04 Thread Supriya Kannery
On 11/04/2011 03:35 PM, Kevin Wolf wrote: Am 30.10.2011 11:35, schrieb Supriya Kannery: +struct BDRVReopenState { +BlockDriverState *bs; +int reopen_flags; + +/* For raw-posix */ +int reopen_fd; +}; I think I commented the same on the previous version: BDRVReopenState

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 11:31 AM, Kevin Wolf wrote: I tried implementing this, but in general daemonization (which forks and leave only the children) breaks the threading. So we could either keep this series (which moves all errors to syslog, but doesn't otherwise change behavior), or I can

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-11-04 Thread Kevin Wolf
Am 04.11.2011 12:10, schrieb Paolo Bonzini: On 11/04/2011 11:31 AM, Kevin Wolf wrote: I tried implementing this, but in general daemonization (which forks and leave only the children) breaks the threading. So we could either keep this series (which moves all errors to syslog, but doesn't

Re: [Qemu-devel] Windows 7 shutdown causes BSOD

2011-11-04 Thread Stefan Hajnoczi
On Fri, Nov 4, 2011 at 10:48 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Windows 7 32-bit guest blue screens when I shut it down properly with Start | Shut Down.  The blue screen is only displayed for a split second before the guest reboots so I am not able to easily tell what it says.  My

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 12:22 PM, Kevin Wolf wrote: That's exactly what this series did. However, daemonization has also to be done before opening the image file. So the series has to support reporting errors to syslog, and also qemu-nbd will not give a nonzero exit status when errors occur.

Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus

2011-11-04 Thread Zhi Yong Wu
On Fri, Nov 4, 2011 at 2:26 PM, Wen Congyang we...@cn.fujitsu.com wrote: At 11/04/2011 10:48 AM, Zhi Yong Wu Write: On Fri, Nov 4, 2011 at 10:45 AM, Wen Congyang we...@cn.fujitsu.com wrote: We disable vm_clock when pausing all vcpus, but we forget to reenable it when resuming all vcpus. It

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 12:09 PM, Thomas Schmitt wrote: So there are still two show stoppers. DVD+RW gets stuck at SET STREAMING. (I will hack libburn to avoid this command and check whether writing is possible then. Chances are good, as writing an already formatted DVD+RW is quite artless.) CD SAO

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Stefan Hajnoczi
On Fri, Nov 4, 2011 at 9:53 AM, Fabien Chouteau chout...@adacore.com wrote: On 04/11/2011 09:36, Stefan Hajnoczi wrote: On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011 at 5:39 PM, Fabien Chouteau

Re: [Qemu-devel] [Xen-devel] [PATCH V3 10/13] libxl: libxl_qmp: Introduce libxl__qmp_pci_add.

2011-11-04 Thread Ian Jackson
Anthony PERARD writes ([Xen-devel] [PATCH V3 10/13] libxl: libxl_qmp: Introduce libxl__qmp_pci_add.): This function insert a PCI passthrough device in qemu. Thanks. I have applied 1-9 from this series. 13/13 had a conflict, and I wasn't 100% sure that it was right to apply it without

[Qemu-devel] [Bug 809912] Re: qemu-kvm -m bigger 4096 aborts with 'Bad ram offset'

2011-11-04 Thread Craig S
After updating from the QEMU that came with Ubuntu 11.04 to 070411-1ubuntu2 version, I am seeing the bad ram offset error, also. If I drop the memory for the guest (which is Windows 7 Pro 64-bit) from 4 GB to 3300MB, the error goes away. Host machine has an AMD Opteron 6128 with 32GB RAM and is

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Thomas Schmitt
Hi, i wrote: CD SAO gets stuck at SEND CUE SHEET. Paolo Bonzini wrote: I wouldn't be surprised if they are bugs in either scsi-generic or the LSI emulation code. They seem to occur when commands return less data than the guest driver has asked; with master I get a guest oops in the LSI

Re: [Qemu-devel] qemu ARM host support likely to be broken in 1.0

2011-11-04 Thread Peter Maydell
On 4 November 2011 07:53, Paolo Bonzini pbonz...@redhat.com wrote: On 11/04/2011 02:52 AM, Peter Maydell wrote:  * the fixed address we mmap the code gen buffer to in system mode tends to overlap the libc heap (at least on Ubuntu oneiric); when this happens you typically get a sysmalloc abort

Re: [Qemu-devel] [PATCH] xen_disk: remove dead code

2011-11-04 Thread Kevin Wolf
Am 28.10.2011 18:03, schrieb Paolo Bonzini: Xen_disk.c has support for using synchronous I/O instead of asynchronous, but it is compiled out by default. Remove it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Thanks, applied for the block branch (for 1.1) Kevin

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Andreas Färber
Hi Thomas, Am 03.11.2011 23:30, schrieb Thomas Schmitt: I tried to activate DPRINTF in hw/scsi-generic.c by removing the // before #define DEBUG_SCSI make yields: .../hw/scsi-generic.c: In function 'scsi_send_command': .../hw/scsi-generic.c:286: error: 'lun' undeclared (first use in

Re: [Qemu-devel] [RFC] docs: Add writing-qmp-commands.txt

2011-11-04 Thread Stefan Hajnoczi
On Thu, Nov 3, 2011 at 6:36 PM, Luiz Capitulino lcapitul...@redhat.com wrote: +Here's the implementation of the 'hello-world' HMP command: + +void hmp_hello_world(Monitor *mon, const QDict *qdict) +{ +    Error *errp = NULL; +    const char *message = qdict_get_str(qdict, message); Since

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Fabien Chouteau
On 04/11/2011 13:04, Stefan Hajnoczi wrote: On Fri, Nov 4, 2011 at 9:53 AM, Fabien Chouteau chout...@adacore.com wrote: On 04/11/2011 09:36, Stefan Hajnoczi wrote: On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011

[Qemu-devel] [Bug 886147] [NEW] Cannot make program Icon on my desktop with rightmouse key

2011-11-04 Thread Wim ter Haar
Public bug reported: Howdy Xubuntu users How can I make a starter program Icon on my desktop with the mouse command right key. I do not seen the commands when I hit the right key of my mouse. Hope to see some info in my pigeon-hole. Spidey-Westland ** Affects: qemu Importance: Undecided

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Thomas Schmitt
Hi, We're about to release QEMU 1.0(-rc1) and you've just spotted a compilation issue... Maybe one should consider to obtain the missing information rather than crippling the debug message, like i did. You've solved this issue 50%! What's missing now is for you to put this fix into a

Re: [Qemu-devel] [Xen-devel] [PATCH V3 11/13] libxl: Use QMP to insert a passthrough device when using upstream QEMU

2011-11-04 Thread Ian Jackson
Anthony PERARD writes ([Xen-devel] [PATCH V3 11/13] libxl: Use QMP to insert a passthrough device when using upstream QEMU): Also move the xenstore specific code to a new function and add a message if sscanf fails. Thanks, following discussion I've applied 10,11 and will wait with 12 for the

[Qemu-devel] How QEMU handle self-modifying code?

2011-11-04 Thread 陳韋任
Hi, all While studying how QEMU handle self-modifying code I took [1] as an example. Running QEMU under GDB I found tb_invalidate_phys_page is called in two different call sequences: 1. do_syscall (linux-user/syscall.c) - target_mprotect (linux-user/mmap.c) - page_set_flags (exec.c) -

[Qemu-devel] [PATCH 1/7] nbd: treat EPIPE from NBD_DO_IT as success

2011-11-04 Thread Paolo Bonzini
This can be seen with qemu-nbd -v -c, which returns 1 instead of 0 when you disconnect with qemu-nbd -d. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- I think this is a bug (because there would be no way to exit qemu-nbd with zero status!), but the patch can be left out

[Qemu-devel] [PATCH 2/7] qemu-nbd: trap SIGTERM

2011-11-04 Thread Paolo Bonzini
The client process right now uses SIGTERM to interrupt the server side. This does not affect the exit status of qemu-nbd -v -c because the server is a child process. This will change when both sides will be in the same process, and anyway cleaning up things nicely upon SIGTERM is good practice.

[Qemu-devel] [PATCH 4/7] qemu-nbd: move client to a thread

2011-11-04 Thread Paolo Bonzini
This avoids that qemu-nbd uses both forking and threads, which do not behave well together. qemu-nbd is already Unix only, and there is no qemu_thread_join, so for now use pthreads. Since the parent and child no longer have separate file descriptors, we can open the NBD device before

[Qemu-devel] [PATCH 7/7] qemu-nbd: open the block device after starting the client thread

2011-11-04 Thread Paolo Bonzini
This is cleaner, because we do not need to close the block device when there is an error opening /dev/nbdX. It was done this way only to print errors before daemonizing. At the same time, use atexit to ensure that the block device is closed whenever we exit. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 3/7] qemu-nbd: rename socket variable

2011-11-04 Thread Paolo Bonzini
It will be moved to a global variable by the next patch, and it would conflict with the socket function. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-nbd.c | 24 +++- 1 files changed, 11 insertions(+), 13 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index

[Qemu-devel] [PATCH] xen-platform: Fix IO port read/write functions

2011-11-04 Thread Anthony PERARD
Somehow, the read/write functions handle an offset that does not exist anymore. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen_platform.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index

[Qemu-devel] [PATCH 6/7] qemu-nbd: fix socket creation race

2011-11-04 Thread Paolo Bonzini
Now that the client and server are in the same process, there is no need to race on the creation of the socket. We can open the listening socket before starting the client thread. This avoids that qemu-nbd -v -c prints this once before connecting successfully to the socket:

[Qemu-devel] [PATCH 0/7] reorganize operation of qemu-nbd -c and fix it

2011-11-04 Thread Paolo Bonzini
This is another approach to fixing the breakage of qemu-nbd -c due to mixing fork with threads. It switches operation of qemu-nbd to threads completely, with the exception of daemonization which is moved as early as possible to avoid conflicts with threads. Patches 1 and 2 are bugfixes to

[Qemu-devel] [PATCH 5/7] qemu-nbd: print error messages from the daemon through a pipe

2011-11-04 Thread Paolo Bonzini
In order to get nice error messages, keep the qemu-nbd process running until before issuing NBD_DO_IT and connected to the daemon with a pipe. This lets the qemu-nbd process relay error messages from the daemon and exit with a nonzero status if appropriate. Suggested-by: Kevin Wolf

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Alexander Graf
On 03.11.2011, at 01:36, Andreas Färber wrote: Am 03.11.2011 08:46, schrieb Markus Armbruster: Anthony Liguori anth...@codemonkey.ws writes: For the record, I'm opposed to ever having a stable plugin API. We aren't a closed source product. If people [don't] want to have to keep up

Re: [Qemu-devel] State of KVM guest debugging support on Power

2011-11-04 Thread Stuart Yoder
On Thu, Nov 3, 2011 at 2:14 PM, Jan Kiszka jan.kis...@web.de wrote: On 2011-11-03 19:59, Stuart Yoder wrote: On Tue, Nov 1, 2011 at 9:22 AM, Jan Kiszka jan.kis...@web.de wrote: Hi there, I'm generating some slides on guest debugging via kvm. What's the current state for Book-E and Book-S?

[Qemu-devel] [Bug 885213] Re: Latest GIT version fails to compile on Linux cris-softmmu/pci-stub.c

2011-11-04 Thread Nigel Horne
I forgot to add that my configure flags are ./configure --enable-linux-aio --enable-kvm and that my CFLAGS are -O2 -W -Wformat=2 -Wswitch -Wshadow -Wwrite-strings -Wuninitialized -Wall -pipe -mtune=native -march=native -fomit-frame-pointer -msse2 -msse -mmmx -mfpmath=sse -pedantic

[Qemu-devel] [PATCH 6/6 v2] vvfat: reorganize computation of disk geometry

2011-11-04 Thread Paolo Bonzini
First determine FAT12/16/32, then compute geometry from that for both FDD and HDD. For 1.44MB floppies, and 2.88MB floppies using FAT16, change to 1 sector/cluster. The default remains 2.88MB with FAT12 and 2 sectors/cluster. Both DOS and mkdosfs by default format a 2.88MB floppy as FAT12.

Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes

2011-11-04 Thread Michael Roth
On Tue, 1 Nov 2011 17:20:19 -0200, Eduardo Habkost ehabk...@redhat.com wrote: Summary of the problem: - qemu_fclose() calls qemu_fflush() - Writes done by qemu_fflush() can fail - Those errors are lost after qemu_fclose() returns So, this series change qemu_fclose() to return last_error.

Re: [Qemu-devel] [PATCH 6/6 v2] vvfat: reorganize computation of disk geometry

2011-11-04 Thread Kevin Wolf
Am 04.11.2011 17:21, schrieb Paolo Bonzini: First determine FAT12/16/32, then compute geometry from that for both FDD and HDD. For 1.44MB floppies, and 2.88MB floppies using FAT16, change to 1 sector/cluster. The default remains 2.88MB with FAT12 and 2 sectors/cluster. Both DOS and mkdosfs

[Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Lucas Meneghel Rodrigues
Hi guys, As we understand that qemu is approaching 1.0, we think it's a good idea to share the issues we have been seeing on recent qemu.git sanity jobs: 1) Some condition is consistently making a RHEL 6.1 linux guest not able to bring up the network interface, causing login failures for all

Re: [Qemu-devel] [RFC] docs: Add writing-qmp-commands.txt

2011-11-04 Thread Luiz Capitulino
On Thu, 3 Nov 2011 22:50:29 +0200 Alon Levy al...@redhat.com wrote: On Thu, Nov 03, 2011 at 04:36:03PM -0200, Luiz Capitulino wrote: Explains how to write QMP commands using the QAPI. TODO: - write returning lists chapter - review it Signed-off-by: Luiz Capitulino

Re: [Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Kevin Wolf
Am 04.11.2011 17:40, schrieb Lucas Meneghel Rodrigues: 2) The floppy regression problem which was reported some days ago on this mailing list still happens, Kevin did post a patch that resolves it [...] But still wasn't integrated upstream. As I understand, there are doubts whether this

Re: [Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Lucas Meneghel Rodrigues
On Fri 04 Nov 2011 02:50:53 PM BRST, Kevin Wolf wrote: Am 04.11.2011 17:40, schrieb Lucas Meneghel Rodrigues: 2) The floppy regression problem which was reported some days ago on this mailing list still happens, Kevin did post a patch that resolves it [...] But still wasn't integrated

Re: [Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Anthony Liguori
On 11/04/2011 11:40 AM, Lucas Meneghel Rodrigues wrote: Hi guys, As we understand that qemu is approaching 1.0, we think it's a good idea to share the issues we have been seeing on recent qemu.git sanity jobs: 1) Some condition is consistently making a RHEL 6.1 linux guest not able to bring up

Re: [Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Lucas Meneghel Rodrigues
On Fri 04 Nov 2011 02:56:30 PM BRST, Anthony Liguori wrote: On 11/04/2011 11:40 AM, Lucas Meneghel Rodrigues wrote: Hi guys, As we understand that qemu is approaching 1.0, we think it's a good idea to share the issues we have been seeing on recent qemu.git sanity jobs: 1) Some condition is

Re: [Qemu-devel] [RFC] docs: Add writing-qmp-commands.txt

2011-11-04 Thread Luiz Capitulino
On Thu, 03 Nov 2011 16:25:58 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On 11/03/2011 01:36 PM, Luiz Capitulino wrote: Explains how to write QMP commands using the QAPI. TODO: - write returning lists chapter - review it Signed-off-by: Luiz

Re: [Qemu-devel] [RFC] docs: Add writing-qmp-commands.txt

2011-11-04 Thread Luiz Capitulino
On Fri, 4 Nov 2011 14:03:47 + Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Nov 3, 2011 at 6:36 PM, Luiz Capitulino lcapitul...@redhat.com wrote: +Here's the implementation of the 'hello-world' HMP command: + +void hmp_hello_world(Monitor *mon, const QDict *qdict) +{ +    

Re: [Qemu-devel] [PATCH] qmp: report TRAY_STATE_CHANGED events

2011-11-04 Thread Luiz Capitulino
On Fri, 04 Nov 2011 11:53:53 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 11/01/2011 06:03 AM, ShaoHe Feng wrote: after the guest startups, then I right click mouse in the UI of the guest, and select the Eject from the menu. there comes an event in the qmp-monitor. {timestamp:

[Qemu-devel] [Bug 885213] Re: Latest GIT version fails to compile on Linux cris-softmmu/pci-stub.c

2011-11-04 Thread Stefan Weil
Did you try compilation in a tree with old generated files from previous compilations? If there are several qmp-commands.h in subdirectories, you have such old files. There must be only one qmp-commands.h in the build root. The old files start with {, the new files start with comment lines. The

[Qemu-devel] [Bug 760060] Re: Open Solaris 2009 Assertion `size' failed

2011-11-04 Thread Stefan Weil
** Changed in: qemu Assignee: (unassigned) = Stefan Weil (ubuntu-weilnetz) ** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/760060

Re: [Qemu-devel] [Xen-devel] [PATCH V3 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-11-04 Thread Konrad Rzeszutek Wilk
+static unsigned long get_value(HostPCIDevice *d, const char *name) +{ +char path[PATH_MAX]; +FILE *f; +unsigned long value; + +path_to(d, name, path, sizeof (path)); +f = fopen(path, r); +if (!f) { +fprintf(stderr, Error: Can't open %s: %s\n, path,

Re: [Qemu-devel] [1.0 release work] Fix regressions found on recent KVM autotest qemu master 'sanity' jobs

2011-11-04 Thread Lucas Meneghel Rodrigues
On 11/04/2011 02:56 PM, Anthony Liguori wrote: On 11/04/2011 11:40 AM, Lucas Meneghel Rodrigues wrote: Hi guys, As we understand that qemu is approaching 1.0, we think it's a good idea to share the issues we have been seeing on recent qemu.git sanity jobs: 1) Some condition is consistently

[Qemu-devel] [Bug 886255] Re: Qemu master branch - RHEL 6.1 guest failing to start network

2011-11-04 Thread Lucas Meneghel Rodrigues
:57 INFO |kvm_vm:0790| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmonitor1-2004-003602-LPJY',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004-003602-LPJY',server,nowait -serial unix:'/tmp/serial

[Qemu-devel] [Bug 886255] [NEW] Qemu master branch - RHEL 6.1 guest failing to start network

2011-11-04 Thread Lucas Meneghel Rodrigues
-humanmonitor1-2004-003602-LPJY',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004-003602-LPJY',server,nowait -serial unix:'/tmp/serial-2004-003602-LPJY',server,nowait -drive file='/tmp/kvm_autotest_root/images/rhel6.1-64.qcow2',index=0,if=virtio,cache=none -device virtio-net-pci

[Qemu-devel] [PATCH RFC for-1.0] Update copyright info

2011-11-04 Thread Andreas Färber
Judging by -version output, one could get the impression that QEMU was last modified in 2008. Therefore extend the copyright statement to cover other contributors so that it can be updated to the current year. Signed-off-by: Andreas Färber afaer...@suse.de --- vl.c |2 +- 1 files changed, 1

Re: [Qemu-devel] [PATCH RFC for-1.0] Update copyright info

2011-11-04 Thread Peter Maydell
On 4 November 2011 17:56, Andreas Färber afaer...@suse.de wrote: --- a/vl.c +++ b/vl.c @@ -1484,7 +1484,7 @@ static void main_loop(void)  static void version(void)  { -    printf(QEMU emulator version QEMU_VERSION QEMU_PKGVERSION , Copyright (c) 2003-2008 Fabrice Bellard\n); +    

[Qemu-devel] [Bug 886255] Re: Qemu master branch - RHEL 6.1 guest failing to start network

2011-11-04 Thread Lucas Meneghel Rodrigues
' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmonitor1-2004-003602-LPJY',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004-003602-LPJY',server,nowait -serial unix:'/tmp/serial-2004-003602-LPJY',server,nowait -drive file='/tmp/kvm_autotest_root/images/rhel6.1-64.qcow2',index=0

[Qemu-devel] [Bug 886255] Re: Qemu master branch - RHEL 6.1 guest failing to start network

2011-11-04 Thread Anthony Liguori
command: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmonitor1-2004-003602-LPJY',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004-003602-LPJY',server,nowait -serial unix:'/tmp/serial-2004-003602-LPJY',server,nowait -drive file

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-04 Thread Lluís Vilanova
Stefan Hajnoczi writes: On Thu, Nov 03, 2011 at 10:35:28AM +0100, Fabien Chouteau wrote: On 03/11/2011 08:44, Stefan Hajnoczi wrote: On Wed, Nov 2, 2011 at 5:39 PM, Fabien Chouteau chout...@adacore.com wrote: On 29/10/2011 15:52, Alexander Graf wrote: I took a quick peak at the

Re: [Qemu-devel] [PATCH RFC for-1.0] Update copyright info

2011-11-04 Thread Andreas Färber
Am 04.11.2011 18:59, schrieb Peter Maydell: On 4 November 2011 17:56, Andreas Färber afaer...@suse.de wrote: --- a/vl.c +++ b/vl.c @@ -1484,7 +1484,7 @@ static void main_loop(void) static void version(void) { -printf(QEMU emulator version QEMU_VERSION QEMU_PKGVERSION , Copyright

Re: [Qemu-devel] QEMU 0.15.1 Linux

2011-11-04 Thread Gus Zernial
First of all, thanks to Jernej Simon for the response which pointed out my mistake regards qemu vs qemu-kvm, and the pointer to the correct version. This solved my  problem. I have another question regards graphics driver for the Win7 client. I would like to use the VMware SVGA 3D (WDDM)

[Qemu-devel] [Bug 886255] Re: Qemu master branch - RHEL 6.1 guest failing to start network

2011-11-04 Thread Lucas Meneghel Rodrigues
= virtio Commented excerpt of the test log: 11/04 00:44:57 INFO |kvm_vm:0790| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmonitor1-2004-003602-LPJY',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-04 Thread Thomas Schmitt
Hi, another showstopper appeared for DVD+RW. After i disabled SET STREAMING, i was able to write a thoroughly formatted DVD+RW. But when i inserted one that was never written up to its end, the attempt failed to (re-)start background formatting (Format Type = 26h): FORMAT UNIT 04 11 00 00

[Qemu-devel] [PATCH] arm: Fix CP15 FSR (C5) domain setting

2011-11-04 Thread Jean-Christophe DUBOIS
During Xvisor development, it was noted that qemu did not return the correct domain value in the Cp15 [Data] FSR register (C5). This patch is a proposal to fix it. Signed-off-by: Jean-Christophe DUBOIS j...@tribudubois.net --- --- qemu-0.15.1.org/target-arm/helper.c2011-10-12

Re: [Qemu-devel] [PATCH] arm: Fix CP15 FSR (C5) domain setting

2011-11-04 Thread Peter Maydell
On 4 November 2011 20:50, Jean-Christophe DUBOIS j...@tribudubois.net wrote: During Xvisor development, it was noted that qemu did not return the correct domain value in the Cp15 [Data] FSR register (C5). This patch is a proposal to fix it. --- qemu-0.15.1.org/target-arm/helper.c    

Re: [Qemu-devel] [spam] QEMU 0.15.1 Linux

2011-11-04 Thread Jernej Simončič
On Friday, November 4, 2011, 20:56:05, Gus Zernial wrote: Is this driver supported in QEMU 0.15.1, and if so how do I get it to work? If not, is there some alternative with the capability I mention? The VMWare SVGA driver is reverse-engineered from the Linux/X VMWare driver, and as such only

[Qemu-devel] [PATCH] Fix reset bit for realview platform.

2011-11-04 Thread Jean-Christophe DUBOIS
According to realview documentation [1], the bit used to reset the board is bit 2 and not bit 8. This is also in sync with Linux source code [2]. [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0417d/BBACIGAD.html [2]

Re: [Qemu-devel] [PATCH] Fix reset bit for realview platform.

2011-11-04 Thread Peter Maydell
On 4 November 2011 23:22, Jean-Christophe DUBOIS j...@tribudubois.net wrote: According to realview documentation [1], the bit used to reset the board is bit 2 and not bit 8. True for PBA8 and PBXA9, but not true for PB1176, PB926 (where it is bit 8) or Emulation Baseboard (which doesn't

[Qemu-devel] [Bug 886408] Re: Windows 64 bits install BSOD : UNSUPPORTED_PROCESSOR (only without kvm)

2011-11-04 Thread Rafaël Carré
I was using Windows 7 x86_64 DVD image: Ultimate N edition (french) b89f76c3a1f9a15f2f583ce38d9740ea fr_windows_7_ultimate_n_with_sp1_x64_dvd_u_677548.iso -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 886408] [NEW] Windows 64 bits install BSOD : UNSUPPORTED_PROCESSOR (only without kvm)

2011-11-04 Thread Rafaël Carré
Public bug reported: Windows DVD starts loading and then stops with error 0x5d MSDN tells us that 0x5d means unsupported_processor The guest CPU is 64 bits though, the DVD fails early if booted on a 32bits CPU Tested versions: 0.14.1, git (932eacc158) qemu-system-x86_64 -m 1024 -boot d -cdrom

[Qemu-devel] qemu-kvm crashes doing migration with disks + blkdebug files (does not happen with qemu)

2011-11-04 Thread Lucas Meneghel Rodrigues
(no tag found) How to reproduce: 1) create a origin vm like: /usr/local/autotest/tests/kvm/qemu -name 'vm1' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmonitor1-2004-200902-95j0',server,nowait -qmp unix:'/tmp/monitor-qmpmonitor1-2004-200902-95j0',server,nowait -serial unix:'/tmp