Re: [Qemu-devel] Coroutines and ucontext

2012-01-28 Thread Alex Barcelo
On Fri, Jan 27, 2012 at 15:39, Paolo Bonzini wrote: I have a patch that uses sigsetjmp and siglongjmp instead of makecontext and getcontext (and all the ucontext stuff), and it *seems* to work... but I'm not sure if it works by accident (not sure what I'm doing to the stack, not sure what I

Re: [Qemu-devel] [PATCH] sdl: Do not grab mouse on mode switch while in background

2012-01-28 Thread Jan Kiszka
On 2012-01-27 23:41, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com When the mouse mode changes to absolute while the SDL windows is not in focus, refrain from grabbing the input. It would steal from some other window. I'll send out a SDL series with fixes and will include this.

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe that's why the sdl_grab_start() is called so often. It seems that the

Re: [Qemu-devel] [PATCH V2] GRLIB UART: Add RX channel

2012-01-28 Thread Blue Swirl
On Thu, Jan 26, 2012 at 17:03, Fabien Chouteau chout...@adacore.com wrote: This patch implements the RX channel of GRLIB UART with a FIFO to improve data rate. Signed-off-by: Fabien Chouteau chout...@adacore.com ---  hw/grlib_apbuart.c |  106

Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-28 Thread Blue Swirl
On Fri, Jan 27, 2012 at 21:27, Stefan Berger stef...@linux.vnet.ibm.com wrote: On 01/27/2012 04:10 PM, Stefan Berger wrote: After bisecting the following commit seems to be the culprit for the suspend/resume problems that I am seeing with the current tip

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe that's why the sdl_grab_start() is called so often. It seems

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-28 13:39, Erik Rull wrote: Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe that's why the

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Erik Rull
Jan Kiszka wrote: On 2012-01-28 13:39, Erik Rull wrote: Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in windowed mode with the cursor. Maybe

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2012-01-28 Thread Blue Swirl
On Wed, Jan 25, 2012 at 15:27, Peter Maydell peter.mayd...@linaro.org wrote: Here's the latest target-arm pullreq. It includes Mark's fix for config_base_register, which is in turn a dependency of the arm-devs pullreq I'm about to send out, and which I'd like to get in before Anthony's QOM

Re: [Qemu-devel] git bisect results

2012-01-28 Thread Jan Kiszka
On 2012-01-28 14:01, Erik Rull wrote: Jan Kiszka wrote: On 2012-01-28 13:39, Erik Rull wrote: Jan Kiszka wrote: On 2012-01-27 23:52, Jan Kiszka wrote: On 2012-01-26 14:10, Erik Rull wrote: I assume from these results that the gui_grab is never set to 1 when having entered the window in

[Qemu-devel] [PATCH 0/4] malta: Code updates for BIOS memory (flash) and LED array

2012-01-28 Thread Stefan Weil
Here are some Malta patches from my local repository. The first three patches try to clean the code for the flash based BIOS memory. I wrote them because my local Malta test environment runs the Malta emulation with a -kernel parameter, and testing of flash code was not possible. Patch 4 is

[Qemu-devel] [PATCH 2/4] malta: Always allocate flash memory

2012-01-28 Thread Stefan Weil
There is no reason why there should not be a flash memory when the Malta emulation is started with a Linux kernel. When flash memory is always available, the code is simpler, and it can be better tested. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/mips_malta.c | 54

[Qemu-devel] [PATCH 4/4] malta: Fix display for LED array

2012-01-28 Thread Stefan Weil
The 8-LED array was already implemented in the first commit to Malta, but this implementation was incomplete. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/mips_malta.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index

[Qemu-devel] [PATCH 1/4] malta: Clean allocation of bios region alias

2012-01-28 Thread Stefan Weil
It is sufficient to define the region alias once for all code branches. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/mips_malta.c | 21 ++--- 1 files changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/mips_malta.c b/hw/mips_malta.c index 64603ce..7586971 100644

[Qemu-devel] [PATCH 3/4] malta: Use symbolic hardware addresses

2012-01-28 Thread Stefan Weil
The patch adds definitions of some hardware addresses and uses these definitions. It also replaces the type of all addresses from signed to unsigned values. This is only a cosmetic change because addresses are unsigned values, the functions called also expect unsigned values, and we need no sign

[Qemu-devel] [PATCH] qom: Fix object_class_foreach()

2012-01-28 Thread Andreas Färber
The TypeImpl was passed as ObjectClass and the ObjectClass as opaque, leading to segfault when dereferencing the caller-supplied opaque. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori aligu...@us.ibm.com --- qom/object.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH] qom: Introduce object_class_is_abstract()

2012-01-28 Thread Andreas Färber
Since struct TypeImpl is not public, this is useful for enumerating available types. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qemu/object.h |8 qom/object.c |5 + 2 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h

Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-28 Thread Blue Swirl
On Sat, Jan 28, 2012 at 12:23, Blue Swirl blauwir...@gmail.com wrote: On Fri, Jan 27, 2012 at 21:27, Stefan Berger stef...@linux.vnet.ibm.com wrote: On 01/27/2012 04:10 PM, Stefan Berger wrote: After bisecting the following commit seems to be the culprit for the suspend/resume problems that

[Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-28 Thread Blue Swirl
Fix suspend/resume broken by off-by-one error in 59abb06198ee9471e29c970f294eae80c0b39be1. Adjust the loop so that it handles correctly the case start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. Reported-by: Stefan Berger stef...@linux.vnet.ibm.com Signed-off-by: Blue Swirl

Re: [Qemu-devel] [PATCH] qom: Introduce object_class_is_abstract()

2012-01-28 Thread Andreas Färber
Am 28.01.2012 18:51, schrieb Andreas Färber: Since struct TypeImpl is not public, this is useful for enumerating available types. Signed-off-by: Andreas Färber afaer...@suse.de BTW Anthony, this cc-less patch shows that an entry is missing in MAINTAINERS. Could you please add an appropriate

[Qemu-devel] [Bug 524447] Re: virsh save is very slow

2012-01-28 Thread BenLake
@Serge @Chris - So it sounds like this _could_ make it into Lucid? Anyone I can bribe to make that happen? As an aside, I have been running LTS versions for 8 years and I must say it seems we need a different priority scale for LTS. This bug renders the use of kvm in 10.04 very painful and the

[Qemu-devel] Proper way to walk through all vpcus

2012-01-28 Thread Xin Tong
What is the proper way to iterate over all vcpus in qemu ? below is what i use in my code. Not sure whether it is the best way, also is a a macro is qemu to do this ? CPUState *curr_cpu = first_cpu; for(; curr_cpu != NULL; curr_cpu = curr_cpu-next_cpu) { ... }

[Qemu-devel] longjmp in qemu

2012-01-28 Thread Xin Tong
I am investigating what longjmp is used for in qemu. longjmp is used in a couple of places. 1. void cpu_loop_exit(void) { env-current_tb = NULL; longjmp(env-jmp_env, 1); } cpu_loop_exit is called when there is an interrupt_request or exit_request pending 2. void

Re: [Qemu-devel] [PATCH] arm: add device tree support

2012-01-28 Thread Grant Likely
On Fri, Jan 27, 2012 at 10:34:01PM +, Paul Brook wrote: If compiled with CONFIG_FDT, allow user to specify a device tree file using the -dtb argument. If the machine supports it then the dtb will be loaded into memory and passed to the kernel on boot. Adding annother machine feels

[Qemu-devel] [PATCH] target-xtensa: fetch 3rd opcode byte only when needed

2012-01-28 Thread Max Filippov
According to ISA, 3.5.4, third opcode byte should not be fetched for 2-byte instructions. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/translate.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c

[Qemu-devel] [RFC 0/9] target-xtensa: implement debug option

2012-01-28 Thread Max Filippov
This patch series implements Xtensa debug option: debug interrupt, breakpoint opcodes, instruction breakpoint SRs, instruction counting SR, data breakpoint SRs. This option enables native debugging, e.g. now guest linux GDB is functional. Three exec.c patches fixe watchpoints bits that nobody

[Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_write

2012-01-28 Thread Max Filippov
Signed-off-by: Max Filippov jcmvb...@gmail.com --- exec.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 5b9eb9a..0e93e0e 100644 --- a/exec.c +++ b/exec.c @@ -3279,9 +3279,15 @@ static void watch_mem_write(void *opaque,

[Qemu-devel] [RFC 9/9] target-xtensa: add breakpoint tests

2012-01-28 Thread Max Filippov
Signed-off-by: Max Filippov jcmvb...@gmail.com --- tests/tcg/xtensa/Makefile |1 + tests/tcg/xtensa/test_break.S | 223 + 2 files changed, 224 insertions(+), 0 deletions(-) create mode 100644 tests/tcg/xtensa/test_break.S diff --git

[Qemu-devel] [RFC 3/9] target-xtensa: add ICOUNT SR and debug exception

2012-01-28 Thread Max Filippov
ICOUNT SR gets incremented on every instruction completion provided that CINTLEVEL at the beginning of the instruction execution is lower than ICOUNTLEVEL. When ICOUNT would increment to 0 a debug exception is raised if CINTLEVEL is lower than DEBUGLEVEL. See ISA, 4.7.7.5 for more details.

[Qemu-devel] [RFC 1/9] target-xtensa: add DEBUGCAUSE SR and configuration

2012-01-28 Thread Max Filippov
DEBUGCAUSE SR holds information about the most recent debug exception. See ISA, 4.7.7 for more details. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/cpu.h | 15 +++ target-xtensa/translate.c |6 ++ 2 files changed, 21 insertions(+), 0 deletions(-)

[Qemu-devel] [RFC 6/9] exec: let cpu_watchpoint_insert accept larger watchpoints

2012-01-28 Thread Max Filippov
Make cpu_watchpoint_insert accept watchpoints of any power-of-two size up to the target page size. Signed-off-by: Max Filippov jcmvb...@gmail.com --- exec.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/exec.c b/exec.c index bc6c185..39a5497 100644 --- a/exec.c +++

[Qemu-devel] [RFC 8/9] target-xtensa: add DEBUG_SECTION to overlay tool

2012-01-28 Thread Max Filippov
Fill debug configuration from overlay definitions in the DEBUG_SECTION. Add DEBUG_SECTION to DC232B and FSF cores. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/core-dc232b.c |1 + target-xtensa/core-fsf.c |1 + target-xtensa/overlay_tool.h |5 + 3 files

[Qemu-devel] [RFC 7/9] target-xtensa: add DBREAK data breakpoints

2012-01-28 Thread Max Filippov
Add DBREAKA/DBREAKC SRs and implement DBREAK breakpoints as debug watchpoints. This implementation is not fully compliant to ISA: when a breakpoint is set to an unmapped/inaccessible memory address it generates TLB/memory protection exception instead of debug exception. See ISA, 4.7.7.3, 4.7.7.6

[Qemu-devel] [RFC 2/9] target-xtensa: implement instruction breakpoints

2012-01-28 Thread Max Filippov
Add IBREAKA/IBREAKENABLE SRs and implement debug exception, BREAK and BREAK.N instructions and IBREAK breakpoints. IBREAK breakpoint address is considered constant for TB lifetime. On IBREAKA/IBREAKENABLE change corresponding TBs are invalidated. Signed-off-by: Max Filippov jcmvb...@gmail.com

[Qemu-devel] [RFC 5/9] exec: fix check_watchpoint exiting cpu_loop

2012-01-28 Thread Max Filippov
In case of BP_STOP_BEFORE_ACCESS watchpoint check_watchpoint intends to signal EXCP_DEBUG exception on exit from cpu loop, but later overwrites exception code by the cpu_resume_from_signal call. Use cpu_loop_exit with BP_STOP_BEFORE_ACCESS watchpoints. Signed-off-by: Max Filippov

[Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2012-01-28 Thread Henrique Rodrigues
Hi guys, I'm having the same problem with a ubuntu 11.04 (natty) host. I tried to set the rate controllers using tc both at the host and inside the guest i.e.: tc qdisc add vnic0 root tbf rate 20mbit burst 20480 latency 50ms (host - to control the traffic going to the guest vm) and tc qdisc add

Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option

2012-01-28 Thread Peter Crosthwaite
Hi All, So on the topic of these command line arguments for initrd, dtb and friends, another related issue we have encountered (and have hacked around in our tree) is not being able to relocate the initrd or kernel. Currently these memory locations are hardcoded in arm_boot.c: #define

Re: [Qemu-devel] [PATCH v3 1/2] ./configure: request pkg-config to provide private libs when static linking

2012-01-28 Thread Sergei Trofimovich
On Mon, 23 Jan 2012 21:33:49 +0300 Sergei Trofimovich sly...@inbox.ru wrote: From: Sergei Trofimovich sly...@gentoo.org Added wrapper around pkg-config to allow: - safe options injection via ${QEMU_PKG_CONFIG_FLAGS} - spaces in path to pkg-config Signed-off-by: Sergei Trofimovich

Re: [Qemu-devel] [PATCH] arm: add device tree support

2012-01-28 Thread Peter Crosthwaite
Hi Grant, The patch series for dts driven machine creation we (myself and Edgar) use that you are referring to was rejected a few months ago on the grounds that it conflicted with QOM: http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg02953.html I am maintaining it our of tree, although I

Re: [Qemu-devel] [PATCH 2/2] ./configure: add link check for nss-smartcard

2012-01-28 Thread Sergei Trofimovich
On Mon, 23 Jan 2012 10:41:38 +0300 Sergei Trofimovich sly...@inbox.ru wrote: From: Sergei Trofimovich sly...@gentoo.org Current './configure --static make' fails for me: LINK qemu-nbd /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find

[Qemu-devel] [PATCH] hw/arm: Remove redundant arguments from set_kernel_args*

2012-01-28 Thread Stefan Weil
The parameters initrd_size and base are already included in the info parameter, so there is no need to pass them separately. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/arm_boot.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/arm_boot.c