Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-07 Thread Gleb Natapov
On Mon, Feb 06, 2012 at 07:09:42PM -0500, Kevin O'Connor wrote: On Mon, Feb 06, 2012 at 01:43:42PM -0200, Luiz Capitulino wrote: Kevin O'Connor ke...@koconnor.net wrote: On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: On Fri, 03 Feb 2012 11:23:05 -0600 Michael Roth

Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen and data sync failure

2012-02-07 Thread Stefan Hajnoczi
On Wed, Feb 01, 2012 at 08:36:28AM +0530, Supriya Kannery wrote: Index: qemu/qerror.c === --- qemu.orig/qerror.c +++ qemu/qerror.c @@ -108,6 +108,14 @@ static const QErrorStringTable qerror_ta .desc = Device

Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers

2012-02-07 Thread Paolo Bonzini
On 02/06/2012 03:16 PM, Anthony Liguori wrote: Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reluctantly-Reviewed-by: Anthony Liguori

Re: [Qemu-devel] [PATCH v2 08/27] qom: fix off-by-one

2012-02-07 Thread Paolo Bonzini
On 02/06/2012 03:19 PM, Anthony Liguori wrote: target_type = g_strdup(type[5]); -target_type[strlen(target_type) - 2] = 0; +*strchr(target_type, '') = 0; Should use an intermediate variable here and do a NULL check. My eyes can't handle dereferencing

Re: [Qemu-devel] Build failure in test-coroutine.c

2012-02-07 Thread Erik Rull
On February 6, 2012 at 9:29 AM Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 19, 2012 at 08:06:30PM +0100, Erik Rull wrote: test-coroutine.c:92: warning: implicit declaration of function 'g_assert_cmpint' ... erik@debian:~/qemu-test/qemu-kvm$ This must be an old Debian box.

Re: [Qemu-devel] Draft patch to permit use of Meta for SDL QEMU GUI

2012-02-07 Thread Michael Tokarev
Replying to an old message... On 06.08.2008 20:54, Drake Wilson wrote: Hello, qemu-devel! I use QEMU to run virtual machines on a Debian GNU/Linux machine with AMD64 PC-class hardware. My X keyboard configuration uses Meta instead of Alt; even though I have a PC-style keyboard whose keys

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 07:58, Michael Ellerman wrote: On Mon, 2012-02-06 at 13:46 -0600, Scott Wood wrote: On 02/03/2012 04:52 PM, Anthony Liguori wrote: On 02/03/2012 12:07 PM, Eric Northup wrote: On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivitya...@redhat.com wrote: [...] Moving to syscalls

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-07 Thread Stefan Hajnoczi
On Wed, Feb 01, 2012 at 08:36:58AM +0530, Supriya Kannery wrote: Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-07 Thread Stefan Hajnoczi
On Wed, Feb 01, 2012 at 08:37:12AM +0530, Supriya Kannery wrote: +/* stash state before reopen */ +raw_rs-stash_s = g_malloc0(sizeof(BDRVRawState)); +memcpy(raw_rs-stash_s, s, sizeof(BDRVRawState)); Copying a struct is fragile, Mike Roth pointed out the potential issue with

Re: [Qemu-devel] Build failure in test-coroutine.c

2012-02-07 Thread Stefan Hajnoczi
On Tue, Feb 7, 2012 at 9:23 AM, Erik Rull erik.r...@rdsoftware.de wrote: On February 6, 2012 at 9:29 AM Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 19, 2012 at 08:06:30PM +0100, Erik Rull wrote: test-coroutine.c:92: warning: implicit declaration of function 'g_assert_cmpint' ...

Re: [Qemu-devel] spawning and killing threads in qemu

2012-02-07 Thread Stefan Hajnoczi
2012/2/7 陳韋任 che...@iis.sinica.edu.tw: Hi Stefan,  Thanks for the explanation. :)   Qemu 1.0 enable IO thread by default, I think that's why you can see there are two threads. You can check block/raw-posix-aio.h, posix-aio-compat.c and linux-aio.c. --enable-io-thread is different

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-07 Thread Stefan Hajnoczi
On Mon, Feb 6, 2012 at 8:27 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 02/04/2012 03:29 AM, Stefan Weil wrote: Am 04.02.2012 00:43, schrieb Anthony Liguori: On 02/03/2012 06:11 PM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder

Re: [Qemu-devel] Coroutines and ucontext

2012-02-07 Thread Stefan Hajnoczi
On Sat, Jan 28, 2012 at 9:31 AM, Alex Barcelo abarc...@ac.upc.edu wrote: On Fri, Jan 27, 2012 at 15:39, Paolo Bonzini wrote: I have a patch that uses sigsetjmp and siglongjmp instead of makecontext and getcontext (and all the ucontext stuff), and it *seems* to work... but I'm not sure if it

Re: [Qemu-devel] [RFC PATCH v2 0/4]Zynq-7000 EPP platform model

2012-02-07 Thread Paul Brook
This is an RFC for a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform: http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm I don't see any documentation on that page. Are technical docs available? It's much easier to review

Re: [Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-07 Thread Paul Brook
Implemented cadence Triple Timer Counter (TCC) It looks like you're implementing a periodic timer as sequence of chained oneshot timers. This is a bad idea. In qemu interrupt latency may be high, so you're likely to suffer from significant time skew. Paul

[Qemu-devel] [Bug 928204] [NEW] build failure gentoo

2012-02-07 Thread Peter Johnson
Public bug reported: gcc 4.5.3, gentoo linux ./configure --prefix=/usr --sysconfdir=/etc --disable-strip --disable-werror --disable-kvm --disable-libiscsi --enable-nptl --enable-uuid --enable-linux-user --extra-ldflags=-Wl,-z,execheap --enable-linux-aio --enable-bluez --disable-brlapi

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/06/2012 07:41 PM, Rob Earhart wrote: I like the ioctl() interface. If the overhead matters in your hot path, I can't say that it's a pressing problem, but it's not negligible. I suspect you're doing it wrong; What am I doing wrong? You the vmm not you the KVM maintainer :-)

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/06/2012 09:11 PM, Anthony Liguori wrote: I'm not so sure. ioeventfds and a future mmio-over-socketpair have to put the kthread to sleep while it waits for the other end to process it. This is effectively equivalent to a heavy weight exit. The difference in cost is dropping to

[Qemu-devel] [Bug 601946] Re: [Feature request] qemu-img multi-threaded compressed image conversion

2012-02-07 Thread Mike Ashton
The compression in this case is certainly chunked already, otherwise you couldn't implement a pseudo block device without reading the entire stream to read the last block! As the data in the new disk is necessarily chunk compressed, parallelisation is perfect feasible, it's just a question of the

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
Hi, On 02/07/2012 04:29 AM, Ori Mamluk wrote: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. This RFC patch adds the repagent client module to Qemu. Please read http://wiki.qemu.org/Contribute/SubmitAPatch In particular, use a tool

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/07/2012 03:08 AM, Alexander Graf wrote: I don't like the idea too much. On s390 and ppc we can set other vcpu's interrupt status. How would that work in this model? It would be a vm-wide syscall. You can also do that on x86 (through KVM_IRQ_LINE). I really do like the ioctl model

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/06/2012 01:46 PM, Scott Wood wrote: On 02/03/2012 04:52 PM, Anthony Liguori wrote: On 02/03/2012 12:07 PM, Eric Northup wrote: On Thu, Feb 2, 2012 at 8:09 AM, Avi Kivitya...@redhat.com wrote: [...] Moving to syscalls avoids these problems, but introduces new ones: - adding new

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Ori Mamluk
In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. Yes - I mentioned that in the patch mail as one of the open issues. Can you direct me to the lock I need? The function I call

Re: [Qemu-devel] [PULL] VirtFS update

2012-02-07 Thread Aneesh Kumar K.V
Hi Anthony, Any update on this pull request ? You have merged the MAINTAINERS file update separately. But that conflict should be easy to fix. -anesh On Mon, 30 Jan 2012 21:44:33 +0530, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Hi Anthony, I now have a successful build at

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-07 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc.c |7 +++ hw/pc.h |1 - hw/pckbd.c |7 +-- hw/vmmouse.c | 11 +++ 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/pc.c

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
On 02/07/2012 06:30 AM, Ori Mamluk wrote: In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. Yes - I mentioned that in the patch mail as one of the open issues. Can you

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be selective with access because of that. As is true of the rest of the kernel. If you want finer grain access control, that's exactly why we

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 06:40 AM, Avi Kivity wrote: On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be selective with access because of that. As is true of the rest of the kernel. If you want finer

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 13:24, Avi Kivity wrote: On 02/07/2012 03:08 AM, Alexander Graf wrote: I don't like the idea too much. On s390 and ppc we can set other vcpu's interrupt status. How would that work in this model? It would be a vm-wide syscall. You can also do that on x86 (through

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 01:39 PM, Juan Quintela wrote: vmmouse = isa_try_create(isa_bus, vmmouse); +qdev_init_nofail(vmmouse-qdev); +qdev_connect_gpio_out(DEVICE(vmmouse), 0, + qdev_get_gpio_in(DEVICE(i8042), 0)); Are you sue that vmmouse is

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/07/2012 02:51 PM, Alexander Graf wrote: On 07.02.2012, at 13:24, Avi Kivity wrote: On 02/07/2012 03:08 AM, Alexander Graf wrote: I don't like the idea too much. On s390 and ppc we can set other vcpu's interrupt status. How would that work in this model? It would be a vm-wide

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/07/2012 02:51 PM, Anthony Liguori wrote: On 02/07/2012 06:40 AM, Avi Kivity wrote: On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be selective with access because of that. As is true of

Re: [Qemu-devel] [PATCH v2 00/27] next steps for qdev QOM

2012-02-07 Thread Paolo Bonzini
Hi Anthony, I fixed the two nits you found (static in the middle of the file, and *strchr) and dropped the OMAP patches for now to give more time to Peter and Andrzej. I also fixed object_dynamic_cast with TYPE_OBJECT as the target. With this fix, you can actually browse the OMAP clocks with

[Qemu-devel] [PATCH v5 1/6] cutils: extract buffer_is_zero() from qemu-img.c

2012-02-07 Thread Stefan Hajnoczi
The qemu-img.c:is_not_zero() function checks if a buffer contains all zeroes. This function will come in handy for zero-detection in the block layer, so clean it up and move it to cutils.c. Note that the function now returns true if the buffer is all zeroes. This avoids the double-negatives

[Qemu-devel] [PATCH v5 0/6] block: zero writes

2012-02-07 Thread Stefan Hajnoczi
This series adds an interface for efficient writes when data contains all zeros. It also takes advantage of this new interface by extending the copy-on-read feature to perform zero-detection. The details of efficient zero representations depend on the image format. This series includes a patch

[Qemu-devel] [PATCH v5 3/6] block: perform zero-detection during copy-on-read

2012-02-07 Thread Stefan Hajnoczi
Copy-on-Read populates the image file with data read from a backing image. In order to avoid bloating the image file when all zeroes are read we should scan the buffer and perform an optimized zero write operation. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 14

[Qemu-devel] [PATCH v5 5/6] qed: add .bdrv_co_write_zeroes() support

2012-02-07 Thread Stefan Hajnoczi
Zero writes are a dedicated interface for writing regions of zeroes into the image file. If clusters are not yet allocated it is possible to use an efficient metadata representation which keeps the image file compact and does not store individual zero bytes. Implementing this for the QED image

[Qemu-devel] [PATCH v5 4/6] qed: replace is_write with flags field

2012-02-07 Thread Stefan Hajnoczi
Per-request attributes like read/write are currently implemented as bool fields in the QEDAIOCB struct. This becomes unwiedly as the number of attributes grows. For example, the qed_aio_setup() function would have to take multiple bool arguments and at call sites it would be hard to distinguish

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. This RFC patch adds the repagent client module to Qemu. Documentation of the module role and API is in the patch at

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 14:16, Avi Kivity wrote: On 02/07/2012 02:51 PM, Alexander Graf wrote: On 07.02.2012, at 13:24, Avi Kivity wrote: On 02/07/2012 03:08 AM, Alexander Graf wrote: I don't like the idea too much. On s390 and ppc we can set other vcpu's interrupt status. How would that

[Qemu-devel] [PATCH v5 2/6] block: add .bdrv_co_write_zeroes() interface

2012-02-07 Thread Stefan Hajnoczi
The ability to zero regions of an image file is a useful primitive for higher-level features such as image streaming or zero write detection. Image formats may support an optimized metadata representation instead of writing zeroes into the image file. This allows zero writes to be potentially

[Qemu-devel] [PATCH v5 6/6] qemu-io: add write -z option for bdrv_co_write_zeroes

2012-02-07 Thread Stefan Hajnoczi
Extend the qemu-io write command with the -z option to call bdrv_co_write_zeroes(). Exposing the zero write interface from qemu-io allows us to write tests that exercise this new block layer interface. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-io.c | 77

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Andreas Färber
Am 06.02.2012 20:25, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. I had some follow-up questions to the last call that remained unanswered. We don't really need a call for that though, email is fine.

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Stefan Hajnoczi
On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolf kw...@redhat.com wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. I recently joked with Kevin that QEMU is on its way to reimplementing the Linux

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 02:45 PM, Andreas Färber wrote: Another topic that can be answered by email is what the time planning for the 4th QOM series looks like. Are there things that developers of new devices should keep in mind / start doing differently wrt SysBus? Another related question is, should

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 02:50 PM, Stefan Hajnoczi wrote: We still haven't figured out a nice way to make image files full-fledged Linux block devices, so we're reimplementing all the block code in QEMU userspace. What about my favorite hammer, NBD? Paolo

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 02:50 PM, Stefan Hajnoczi wrote: I guess we might need to attach multiple QMP monitors for this to work (one for libvirt, one for the rephub). I'm not sure if there is a fundamental problem with this or if it just needs to be done. Agreed. You can already query block devices

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Ori Mamluk
On 07/02/2012 14:40, Anthony Liguori wrote: On 02/07/2012 06:30 AM, Ori Mamluk wrote: In addition, I don't see that the listener thread holds any lock while it reads the image. I guess that during that period the guest runs and may race w/ this new thread. Yes - I mentioned that in the patch

[Qemu-devel] [PATCH 18/19] qemu-char: Chardev open error reporting, generic part

2012-02-07 Thread Markus Armbruster
1. Convert to error_report(). 2. All backends now report their errors, no need to follow up with an unspecific opening backend failed. Drop the message. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-char.c | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-)

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Ori Mamluk
On 07/02/2012 15:50, Stefan Hajnoczi wrote: First let me say that I'm not completely used to the inline replies - so I initially missed some of your mail before. On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolfkw...@redhat.com wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Avi Kivity
On 02/07/2012 03:40 PM, Alexander Graf wrote: Not sure we'll ever get there. For PPC, it will probably take another 1-2 years until we get the 32-bit targets stabilized. By then we will have new 64-bit support though. And then the next gen will come out giving us even more new constraints.

[Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check

2012-02-07 Thread Markus Armbruster
Cleaned up silently in commit aad04cd0, but that just got reverted. Re-apply this part. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-char.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index c25863a..bb9e3f5 100644 ---

[Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-07 Thread Markus Armbruster
Convert to error_report(). This adds error locations to the messages, which is particularly important when the location is buried in a configuration file. Moreover, we'll need this when we create a monitor command to add character devices, so its errors actually appear in the monitor, not

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-07 Thread Corey Bryant
On 02/07/2012 05:28 AM, Stefan Hajnoczi wrote: On Mon, Feb 6, 2012 at 8:27 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 02/04/2012 03:29 AM, Stefan Weil wrote: Am 04.02.2012 00:43, schrieb Anthony Liguori: On 02/03/2012 06:11 PM, q...@buildbot.b1-systems.de wrote: The Buildbot

[Qemu-devel] [PATCH v2] Add SPICE support to add_client monitor command

2012-02-07 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com This is a followup to http://patchwork.ozlabs.org/patch/121004/ With the acceptance of some new APIs to libspice-server.so it is possible to add support for SPICE to the 'add_client' monitor command, bringing parity with VNC. Since SPICE can use

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 15:21, Avi Kivity wrote: On 02/07/2012 03:40 PM, Alexander Graf wrote: Not sure we'll ever get there. For PPC, it will probably take another 1-2 years until we get the 32-bit targets stabilized. By then we will have new 64-bit support though. And then the next gen

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 03:06 PM, Ori Mamluk wrote: The main issue about it is that the Rephub also needs the other direction - to read the protected volume. I get the feeling that with live block copy and NBD there's probably something that might fit this need, no? Yes, with two NBD sockets you could

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Ori Mamluk
On 07/02/2012 15:34, Kevin Wolf wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. This RFC patch adds the repagent client module to Qemu. Documentation of the module role and API is in the

[Qemu-devel] [PATCH 11/19] qemu-char: Chardev open error reporting, _WIN32 part

2012-02-07 Thread Markus Armbruster
Convert backends pipe, console and serial to error_report(). While there, improve the atrocious error messages some. Unlike many other backends, file and stdio leave open error reporting to their caller. Because the caller doesn't know what went wrong, this results in a pretty useless error

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Ori Mamluk
On 07/02/2012 16:40, Paolo Bonzini wrote: On 02/07/2012 03:06 PM, Ori Mamluk wrote: The main issue about it is that the Rephub also needs the other direction - to read the protected volume. I get the feeling that with live block copy and NBD there's probably something that might fit this need,

[Qemu-devel] [PATCH 12/19] qemu-char: Chardev open error reporting, tty part

2012-02-07 Thread Markus Armbruster
Unlike many other backends, this one leaves open error reporting to its caller. Because the caller doesn't know what went wrong, this results in a pretty useless error message. Change it to report its errors. Improves user-hostile messages like this one for -chardev tty,id=foo,path=/dev/ttyy1

[Qemu-devel] [PATCH 08/19] sockets: Clean up inet_listen_opts()'s convoluted bind() loop

2012-02-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-sockets.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index e6e6c72..6bcb8e3 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -107,7 +107,7 @@ int

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. As there were only one topic for the call, and Andreas suggested to use email, we cancel this week call. Have a nice day, Juan.

[Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part

2012-02-07 Thread Markus Armbruster
This part takes care of backends file, pipe, pty and stdio. Unlike many other backends, these leave open error reporting to their caller. Because the caller doesn't know what went wrong, this results in a pretty useless error message. Change them to report their errors. Improves comically

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Anthony Liguori
On 02/07/2012 07:52 AM, Paolo Bonzini wrote: On 02/07/2012 02:45 PM, Andreas Färber wrote: Another topic that can be answered by email is what the time planning for the 4th QOM series looks like. qom-upstream.16 is pretty close to ready to be sent out for v1. It's fairly tricky getting

[Qemu-devel] [PATCH 03/19] qemu-char: Re-apply style fixes from just reverted aad04cd0

2012-02-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-char.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 368df2e..c25863a 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -640,8 +640,9 @@ static CharDriverState

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-07 Thread Stefan Hajnoczi
On Tue, Feb 7, 2012 at 2:32 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 02/07/2012 05:28 AM, Stefan Hajnoczi wrote: On Mon, Feb 6, 2012 at 8:27 PM, Corey Bryantcor...@linux.vnet.ibm.com  wrote: On 02/04/2012 03:29 AM, Stefan Weil wrote: Am 04.02.2012 00:43, schrieb Anthony

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolfkw...@redhat.com wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. I recently joked with Kevin that

[Qemu-devel] [PATCH 02/19] qemu-char: Use qemu_open() to avoid leaking fds to children

2012-02-07 Thread Markus Armbruster
Fixed silently in commit aad04cd0, but that just got reverted. Re-apply the fixes, plus one missed instance: parport on Linux. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-char.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-char.c

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:40 AM, Paolo Bonzini wrote: On 02/07/2012 03:06 PM, Ori Mamluk wrote: The main issue about it is that the Rephub also needs the other direction - to read the protected volume. I get the feeling that with live block copy and NBD there's probably something that might fit this

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 15:57, Andreas Färber wrote: Hi Alex, Am 30.01.2012 23:29, schrieb Alexander Graf: When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows

[Qemu-devel] [PATCH 2/2] qcow2: Keep unknown header extension when rewriting header

2012-02-07 Thread Kevin Wolf
If we want header extensions to work as compatible extensions, we can't destroy yet unknown header extensions when rewriting the header (e.g. for changing the backing file). Save all unknown header extensions in a list of blobs and include them in a new header. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 1/2] qcow2: Update whole header at once

2012-02-07 Thread Kevin Wolf
In order to switch the backing file, qcow2 issues multiple write requests that only changed a part of the image header. Any failure after the first one would leave the header in an corrupted state. With this patch, the whole header is written at once, so we can't fail in the middle. At the same

Re: [Qemu-devel] [PATCH 01/19] Revert qemu-char: Print strerror message on failure and deps

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: The commit's purpose is laudable: The only way for chardev drivers to communicate an error was to return a NULL pointer, which resulted in an error message that said _that_ something went wrong, but not _why_. It attempts to

Re: [Qemu-devel] [PATCH 03/19] qemu-char: Re-apply style fixes from just reverted aad04cd0

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbrusterarm...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- qemu-char.c | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] qemu-ga: add guest-sync-delimited

2012-02-07 Thread Daniel P. Berrange
On Mon, Feb 06, 2012 at 06:07:35PM -0600, Michael Roth wrote: guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-sentence due to reboot,

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-02-07 Thread Corey Bryant
On 02/07/2012 09:59 AM, Stefan Hajnoczi wrote: On Tue, Feb 7, 2012 at 2:32 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 02/07/2012 05:28 AM, Stefan Hajnoczi wrote: On Mon, Feb 6, 2012 at 8:27 PM, Corey Bryantcor...@linux.vnet.ibm.com wrote: On 02/04/2012 03:29 AM, Stefan

Re: [Qemu-devel] [PATCH 02/19] qemu-char: Use qemu_open() to avoid leaking fds to children

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Fixed silently in commit aad04cd0, but that just got reverted. Re-apply the fixes, plus one missed instance: parport on Linux. Signed-off-by: Markus Armbrusterarm...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony

[Qemu-devel] [PATCH 17/19] baum: Chardev open error reporting, braille part

2012-02-07 Thread Markus Armbruster
Convert to error_report(). Improves user-hostile messages like this one baum_init: brlapi_openConnection: connect: No such file or directory chardev: opening backend braille failed to qemu-system-x86_64: -chardev braille,id=foo: Can't open braille: connect: No such file or

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 07:18 AM, Avi Kivity wrote: On 02/07/2012 02:51 PM, Anthony Liguori wrote: On 02/07/2012 06:40 AM, Avi Kivity wrote: On 02/07/2012 02:28 PM, Anthony Liguori wrote: It's a potential source of exploits (from bugs in KVM or in hardware). I can see people wanting to be selective

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Convert to error_report(). This adds error locations to the messages, which is particularly important when the location is buried in a configuration file. Moreover, we'll need this when we create a monitor command to add character devices, so

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 06:03 AM, Avi Kivity wrote: On 02/06/2012 09:11 PM, Anthony Liguori wrote: I'm not so sure. ioeventfds and a future mmio-over-socketpair have to put the kthread to sleep while it waits for the other end to process it. This is effectively equivalent to a heavy weight exit. The

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-sync-delimited

2012-02-07 Thread Michal Privoznik
On 07.02.2012 02:09, Michael Roth wrote: guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-sentence due to reboot, forced restart, etc).

[Qemu-devel] [PATCH 19/19] qemu-char: Fix legacy chardev syntax error reporting

2012-02-07 Thread Markus Armbruster
Watch this: $ qemu-system-x86_64 -nodefaults -vnc :0 -debugcon crap $ echo $? 1 $ qemu-system-x86_64 -nodefaults -vnc :0 -serial crap qemu: could not open serial device 'crap': Success Two issues: 1. qemu_chr_new() fails silently on syntax errors. It does report other

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Stefan Hajnoczi
On Tue, Feb 7, 2012 at 2:59 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/07/2012 07:50 AM, Stefan Hajnoczi wrote: On Tue, Feb 7, 2012 at 1:34 PM, Kevin Wolfkw...@redhat.com  wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external

Re: [Qemu-devel] KVM call agenda for Tuesday 7

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 03:56 PM, Anthony Liguori wrote: Another related question is, should the 4th QOM series present a full composition tree based on the legacy qdev bus concept? Composition, no. The legacy qbus concept doesn't model composition because it puts children created by composition (like

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Anthony Liguori
On 02/07/2012 07:40 AM, Alexander Graf wrote: Why? For the HPET timer register for example, we could have a simple MMIO hook that says on_read: return read_current_time() - shared_page.offset; on_write: handle_in_user_space(); For IDE, it would be as simple as

[Qemu-devel] [PATCH] vga: Fix full updates in graphic mode

2012-02-07 Thread Jan Kiszka
This fixes the regression introduced by cd7a45c95e: We lost the or'ing with the full_update flag. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Applies on top of the other related fix: http://thread.gmane.org/gmane.comp.emulators.qemu/134958 hw/vga.c |5 +++-- 1 files changed, 3

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:40, schrieb Paolo Bonzini: On 02/07/2012 03:06 PM, Ori Mamluk wrote: The main issue about it is that the Rephub also needs the other direction - to read the protected volume. I get the feeling that with live block copy and NBD there's probably something that might fit this

Re: [Qemu-devel] [RFC] Next gen kvm api

2012-02-07 Thread Alexander Graf
On 07.02.2012, at 16:23, Anthony Liguori wrote: On 02/07/2012 07:40 AM, Alexander Graf wrote: Why? For the HPET timer register for example, we could have a simple MMIO hook that says on_read: return read_current_time() - shared_page.offset; on_write:

Re: [Qemu-devel] [PATCH 06/19] gdbstub: Error locations for -gdb

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:09, schrieb Markus Armbruster: Stash away the option argument with add_device_config(), so we still have its location when we get around to parsing it. This doesn't improve any messages I can see just yet, but that'll change shortly. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 04/19] qemu-char: qemu_chr_open_fd() can't fail, don't check

2012-02-07 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Cleaned up silently in commit aad04cd0, but that just got reverted. Re-apply this part. Signed-off-by: Markus Armbrusterarm...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- qemu-char.c |4

Re: [Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command

2012-02-07 Thread Stefan Hajnoczi
On Fri, Jan 20, 2012 at 7:55 PM, Eric Blake ebl...@redhat.com wrote: On 01/20/2012 01:30 AM, Kevin Wolf wrote: Is there any policy on _ vs - in command names?  It seems awkward to have block_job_cancel but query-block-jobs. block_job_cancel is HMP, whereas query-block-jobs is a QMP command.

[Qemu-devel] [PATCH v3 0/3] jazz-led: QOM conversion

2012-02-07 Thread Hervé Poussineau
Following patches update jazz-led emulation to current Qemu standards: - use trace framework to report events - remove usage of old_mmio API - convert to QOM Changes v2 - v3: - rebased Changes v1 - v2: - rebased Hervé Poussineau (3): jazz-led: use trace framework jazz-led: convert to QOM

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 03:48 PM, Ori Mamluk wrote: The current streaming code in QEMU only deals with the former. Streaming to a remote server would not be supported. I need it at the same time. The Rephub reads either the full volume or parts of, and concurrently protects new IOs. Why can't QEMU

Re: [Qemu-devel] [PATCH 10/19] qemu-char: Chardev open error reporting, !_WIN32 part

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:09, schrieb Markus Armbruster: This part takes care of backends file, pipe, pty and stdio. Unlike many other backends, these leave open error reporting to their caller. Because the caller doesn't know what went wrong, this results in a pretty useless error message. Change

[Qemu-devel] [PATCH 16/19] spice-qemu-char: Chardev open error reporting, spicevmc part

2012-02-07 Thread Markus Armbruster
Convert to error_report(). Signed-off-by: Markus Armbruster arm...@redhat.com --- spice-qemu-char.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 1e735ff..290437d 100644 --- a/spice-qemu-char.c +++

[Qemu-devel] [PATCH v3 2/3] jazz-led: convert to QOM

2012-02-07 Thread Hervé Poussineau
Some simplifications in I/O functions are possible because Jazz LED only registers one byte of I/O. Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/jazz_led.c | 157 hw/mips.h |3 - hw/mips_jazz.c |2 +- 3 files

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-02-07 Thread Andreas Färber
Hi Alex, Am 30.01.2012 23:29, schrieb Alexander Graf: When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows expects it to be there. Since without security

Re: [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages

2012-02-07 Thread Kevin Wolf
Am 07.02.2012 15:09, schrieb Markus Armbruster: Our chardev open error messages are an embarrassment. Commit 6e1db57b tried to improve the useless opening backend FOO failed message in qemu_chr_open_opts(), but it is flawed: some failure modes went from an unhelpful failed to an outright

  1   2   >