Re: [Qemu-devel] [PATCH 1/6] memory: change dirty getting API to take a size

2012-02-08 Thread Evgeny Voevodin
On 02/08/2012 11:42 AM, Jan Kiszka wrote: On 2012-02-08 08:19, Evgeny Voevodin wrote: On 01/29/2012 11:13 PM, Blue Swirl wrote: Instead of each device knowing or guessing the guest page size, just pass the desired size of dirtied memory area. Signed-off-by: Blue Swirlblauwir...@gmail.com ---

[Qemu-devel] [Bug 928676] [NEW] QEMU does not support Westmere (Intel Xeon) CPU model

2012-02-08 Thread Stefan
Public bug reported: Setting the CPU model to Westmere (Intel Xeon server CPU) is not possible. libvirt uses 'core2duo' as fallback: https://bugzilla.redhat.com/show_bug.cgi?id=708927 $ qemu -cpu ? x86 [n270] x86 [athlon] x86 [pentium3] x86 [pentium2] x86

Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled

2012-02-08 Thread Aneesh Kumar K.V
On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge mead...@codesourcery.com wrote: There have been reports [1, 2] where folks have had issues building VirtFS and the virtio backend on older systems. I personally saw problems due to the use of features (struct statfs f_frsize field, fdopendir,

Re: [Qemu-devel] [PATCH 0/4] arm: add device tree support (via machine opts)

2012-02-08 Thread Peter Crosthwaite
Hi Peter, Anthony suggested to us the Idea of setting up bootloaders as devices in order to solve this command line argument problem. I have posted a patch to the mailing list ([RFC PATCH] arm boot: added QOM device definition) which is my first attempt at this for arm_boot, i.e. arm_boot.c is

Re: [Qemu-devel] [RFC PATCH v2 0/4]Zynq-7000 EPP platform model

2012-02-08 Thread Peter Crosthwaite
2012/2/7 Paul Brook p...@codesourcery.com This is an RFC for a suite of Device models and a machine model for the Xilinx Zynq-7000 Extensible Processing Platform: http://www.xilinx.com/products/silicon-devices/epp/zynq-7000/index.htm I don't see any documentation on that page. Are

[Qemu-devel] [Bug 824650] Re: Latest GIT assert error in arp_table.c

2012-02-08 Thread Bjoern Bornemann
okay I forgot to post the qemu command here it is: qemu-system-i386 -balloon none -smbios type=0,vendor=Lenovo,version=7LETC6WW,date=05/11/2009,release=2.38 \ -smbios

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Dor Laor
On 02/08/2012 08:10 AM, Ori Mamluk wrote: On 07/02/2012 17:47, Paolo Bonzini wrote: On 02/07/2012 03:48 PM, Ori Mamluk wrote: The current streaming code in QEMU only deals with the former. Streaming to a remote server would not be supported. I need it at the same time. The Rephub reads

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 07:10, schrieb Ori Mamluk: On 07/02/2012 17:47, Paolo Bonzini wrote: On 02/07/2012 03:48 PM, Ori Mamluk wrote: The current streaming code in QEMU only deals with the former. Streaming to a remote server would not be supported. I need it at the same time. The Rephub reads either

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 6e28e78..e42d845 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c @@ -313,12 +313,14 @@ static void versatile_init(ram_addr_t ram_size, /* 0x101f3000 UART2. */ /* 0x101f4000 SSPI. */ -versatile_binfo.ram_size =

Re: [Qemu-devel] [Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-02-08 Thread David Jaša
Vadim Rozenfeld píše v St 08. 02. 2012 v 02:47 -0500: I'm afraid to give you any recommendations regarding QEMU stability. I usually work with qemu-kvm repository. But we are always doing WHQL process on RHEL platform only. Maybe someone from the SPICE team can comment on your question?

[Qemu-devel] [PATCH] slirp: Prevent sending ICMP error replies to source-only addresses

2012-02-08 Thread Jan Kiszka
This triggered the related assert in arp_table_search. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- slirp/ip_icmp.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c index 4b43994..5dbf21d 100644 --- a/slirp/ip_icmp.c +++

Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets

2012-02-08 Thread Laurent Desnogues
On Fri, Feb 3, 2012 at 3:49 PM, riku.voi...@linaro.org wrote: From: Riku Voipio riku.voi...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org ---  linux-user/qemu.h |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Ori Mamluk
On 08/02/2012 10:55, Kevin Wolf wrote: Am 08.02.2012 07:10, schrieb Ori Mamluk: On 07/02/2012 17:47, Paolo Bonzini wrote: Why can't QEMU itself stream the full volume in the background, and send that together with any new I/O? Is it because the rephub knows which parts are out-of-date and

Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-08 Thread Goswin von Brederlow
Stefan Hajnoczi stefa...@gmail.com writes: On Sat, Feb 4, 2012 at 5:38 PM, Goswin von Brederlow goswin-...@web.de wrote: Description: Allow 64bit elf binaries in multiboot format  This patch allows 64bit elf files with multiboot header to be loaded.  The entry point will still be called in

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 10:47, schrieb Ori Mamluk: On 08/02/2012 10:55, Kevin Wolf wrote: Am 08.02.2012 07:10, schrieb Ori Mamluk: On 07/02/2012 17:47, Paolo Bonzini wrote: Why can't QEMU itself stream the full volume in the background, and send that together with any new I/O? Is it because the

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/8 Paul Brook p...@codesourcery.com diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 6e28e78..e42d845 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c @@ -313,12 +313,14 @@ static void versatile_init(ram_addr_t ram_size, /* 0x101f3000 UART2. */ /*

[Qemu-devel] Restore consistent formatting

2012-02-08 Thread Evgeny Voevodin
The last commit Restore consistent formatting (cf4dc461a4cfc3e056ee24edb26154f4d34a6278) which is on the master but absent in mailing list results in such output of checkpatch.pl: ./scripts/checkpatch.pl --no-tree --file hw/cs4231a.c ... total: 107 errors, 88 warnings, 696 lines checked

Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled

2012-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2012 at 01:45:15PM +0530, Aneesh Kumar K.V wrote: On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge mead...@codesourcery.com wrote: There have been reports [1, 2] where folks have had issues building VirtFS and the virtio backend on older systems. I personally saw problems

Re: [Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-08 Thread Paul Brook
Implemented cadence Triple Timer Counter (TCC) It looks like you're implementing a periodic timer as sequence of chained oneshot timers. This is a bad idea. In qemu interrupt latency may be high, so you're likely to suffer from significant time skew. Ok, I could implemented the

Re: [Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-08 Thread Peter Crosthwaite
2012/2/8 Paul Brook p...@codesourcery.com Implemented cadence Triple Timer Counter (TCC) It looks like you're implementing a periodic timer as sequence of chained oneshot timers. This is a bad idea. In qemu interrupt latency may be high, so you're likely to suffer from

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
+ arm_load_kernel(env, versatile_binfo); + } } This should be using the new object you just added. Yes I agree. There is another question tho that if this approach is to be considered, should this call to arm_load_kernel be removed from the machine model

Re: [Qemu-devel] [PATCH v5 0/6] block: zero writes

2012-02-08 Thread Kevin Wolf
Am 07.02.2012 14:27, schrieb Stefan Hajnoczi: This series adds an interface for efficient writes when data contains all zeros. It also takes advantage of this new interface by extending the copy-on-read feature to perform zero-detection. The details of efficient zero representations depend

Re: [Qemu-devel] QEMU build errors with 'fdopendir'

2012-02-08 Thread M. Mohan Kumar
Hi, I will give a fix to disable virtfs by providing a configure option --disable-virtfs. But if you want use virtfs with your current setup, we can give the option to disable handle and proxy FS driver. Still you can use local FS driver. Meador Inge wrote: Did these [1] builds errors

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread David Gibson
On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: On Wed, 8 Feb 2012, David Gibson wrote: From: Thomas Huth th...@linux.vnet.ibm.com These instructions for loading and storing byte-swapped 64-bit values have been introduced in PowerISA 2.06. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH v3 4/6] suspend: make ps/2 devices wakeup the guest

2012-02-08 Thread Gerd Hoffmann
This patch adds wakeup support to ps/2 emulation. Any key press on the ps/2 keyboard will wakeup the guest. Likewise any mouse button press will wakeup the guest. Mouse moves are ignored, so the guest will not wakeup in case your mouse crosses the vnc window of a suspended guest by accident.

[Qemu-devel] [PATCH v3 1/6] suspend: add infrastructure

2012-02-08 Thread Gerd Hoffmann
This patch adds some infrastructure to handle suspend and resume to qemu. First there are two functions to switch state and second there is a suspend notifier: * qemu_system_suspend_request() is supposed to be called when the guest asks for being be suspended, for example via ACPI. *

[Qemu-devel] [PATCH v3 3/6] suspend: add system_wakeup monitor command

2012-02-08 Thread Gerd Hoffmann
This patch adds the system_wakeup monitor command which will simply wake up suspended guests. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 11 +++ qmp-commands.hx

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 6:10 AM, Ori Mamluk omam...@zerto.com wrote: 2. drbd is 'below' all the Qemu block layers - if the protected volume is qcow2 then drbd doesn't get the raw IOs, right? No, if you look at the layers again: Guest - QEMU - drbd - local NBD server The local NBD server runs

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/8 Paul Brook p...@codesourcery.com + arm_load_kernel(env, versatile_binfo); + } } This should be using the new object you just added. Yes I agree. There is another question tho that if this approach is to be considered, should this call to

[Qemu-devel] [Bug 818673] Re: virtio: trying to map MMIO memory

2012-02-08 Thread Vitalis
Now have next config and bug still: /usr/bin/kvm -S -M pc-0.12 -cpu qemu32 -enable-kvm -m 2048 -smp 1 -name boss_xp -uuid 9041090d-acee-da4a-921d-238f2a43be64 -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/boss_xp.monitor,server,nowait -monitor chardev:monitor -localtime -boot c -drive

Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-08 Thread Kevin Wolf
Am 08.02.2012 10:53, schrieb Goswin von Brederlow: Stefan Hajnoczi stefa...@gmail.com writes: On Sat, Feb 4, 2012 at 5:38 PM, Goswin von Brederlow goswin-...@web.de wrote: Description: Allow 64bit elf binaries in multiboot format This patch allows 64bit elf files with multiboot header to

[Qemu-devel] [PATCH v3 2/6] suspend: switch acpi s3 to new infrastructure.

2012-02-08 Thread Gerd Hoffmann
This patch switches pc s3 suspend over to the new infrastructure. The cmos_s3 qemu_irq is killed, the new notifier is used instead. The xen hack goes away with that too, the hypercall can simply be done in a notifier function now. This patch also makes the guest actually stay suspended instead of

[Qemu-devel] [PATCH v3 6/6] suspend: make rtc alarm wakeup the guest.

2012-02-08 Thread Gerd Hoffmann
Add a 'wakeup' property to the mc146818rtc. It is on by default. When enabled the rtc will wake up the guest when the alarm fires. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/mc146818rtc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/mc146818rtc.c

[Qemu-devel] [PATCH v3 5/6] suspend: make serial ports wakeup the guest.

2012-02-08 Thread Gerd Hoffmann
Add a 'wakeup' property to the serial port. It is off by default. When enabled any incoming character on the serial line will wake up the guest. Useful for guests which have a serial console configured. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/serial.c |6 ++ 1 files

[Qemu-devel] [PATCH v3 0/6] initial suspend support

2012-02-08 Thread Gerd Hoffmann
This patch series makes suspend support in qemu alot more useful. Right now the guest can put itself into s3, but qemu will wakeup the guest instantly. With this patch series applied the guest will stay suspended instead and there are a few events which can kick the guest out of suspend state:

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does this mean the machine model would still explicitly instantiate the bootloader device? Yes. Bootloaders inherently have machine specific knowledge. They need to

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Luiz Capitulino
On Tue, 07 Feb 2012 14:34:12 +0100 Kevin Wolf kw...@redhat.com wrote: The other message types could possibly be implemented as QMP commands. I guess we might need to attach multiple QMP monitors for this to work (one for libvirt, one for the rephub). I'm not sure if there is a fundamental

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/8 Paul Brook p...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does this mean the machine model would still explicitly instantiate the bootloader device? Yes. Bootloaders

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
2012/2/8 Dor Laor dl...@redhat.com: On 02/08/2012 08:10 AM, Ori Mamluk wrote: 2. drbd is 'below' all the Qemu block layers - if the protected volume is qcow2 then drbd doesn't get the raw IOs, right? That's one of the major caveats in drbd/iscsi/nbd - there is no support for block level

Re: [Qemu-devel] [RFC Patch 1/7]Qemu: Enhance info block to display host cache setting

2012-02-08 Thread Luiz Capitulino
On Wed, 01 Feb 2012 08:36:14 +0530 Supriya Kannery supri...@linux.vnet.ibm.com wrote: Enhance info block to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 Enhanced to display hostcache

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 6:10 AM, Ori Mamluk omam...@zerto.com wrote: On 07/02/2012 17:47, Paolo Bonzini wrote: But I'm also starting to wonder whether it would be simpler to use existing replication code.  DRBD is more feature-rich, and you can use it over loopback or NBD devices (respectively

Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 9:53 AM, Goswin von Brederlow goswin-...@web.de wrote: Stefan Hajnoczi stefa...@gmail.com writes: On Sat, Feb 4, 2012 at 5:38 PM, Goswin von Brederlow goswin-...@web.de wrote: Description: Allow 64bit elf binaries in multiboot format  This patch allows 64bit elf files

Re: [Qemu-devel] [RFC Patch 3/7]Qemu: Cmd block_set_hostcache for dynamic cache change

2012-02-08 Thread Luiz Capitulino
On Wed, 01 Feb 2012 08:36:41 +0530 Supriya Kannery supri...@linux.vnet.ibm.com wrote: New command block_set_hostcache added for dynamically changing host pagecache setting of a block device. Usage: block_set_hostcache device option device = block device option = on/off

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Orit Wasserman
On 02/07/2012 04:05 PM, Paolo Bonzini wrote: On 02/07/2012 02:50 PM, Stefan Hajnoczi wrote: I guess we might need to attach multiple QMP monitors for this to work (one for libvirt, one for the rephub). I'm not sure if there is a fundamental problem with this or if it just needs to be done.

[Qemu-devel] [PATCH] vnc: lift modifier keys on client disconnect.

2012-02-08 Thread Gerd Hoffmann
For any modifier key (shift, ctrl, alt) still pressed on disconnect inject a key-up event into the guest. The vnc client is gone, it will not do that, so qemu has to do it instead. Without this keys will get stuck, making the guest act in weird ways after reconnecting. Reproducer: exit vnc

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
2012/2/8 Paul Brook p...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does this mean the machine model would still explicitly instantiate the bootloader device? Yes. Bootloaders

Re: [Qemu-devel] [PATCH v2 06/27] qom: add QObject-based property get/set wrappers

2012-02-08 Thread Luiz Capitulino
On Tue, 07 Feb 2012 10:12:34 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 02/06/2012 03:16 PM, Anthony Liguori wrote: Move the creation of QmpInputVisitor and QmpOutputVisitor from qmp.c to qom/object.c, since it's the only practical way to access object properties.

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Orit Wasserman
On 02/07/2012 04:45 PM, Ori Mamluk wrote: On 07/02/2012 15:34, Kevin Wolf wrote: Am 07.02.2012 11:29, schrieb Ori Mamluk: Repagent is a new module that allows an external replication system to replicate a volume of a Qemu VM. This RFC patch adds the repagent client module to Qemu.

Re: [Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-08 Thread Paul Brook
- When are interrupts raised. You mention a user specified match value. Do we also get an interrupt on wraparound? Yes, an interrupts occur on wrap around of the 16 bit timer value. There are three match registers which correspond to three more (separately maskable) interrupts which

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Alexander Graf
On 08.02.2012, at 13:27, Paul Brook wrote: 2012/2/8 Paul Brook p...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does this mean the machine model would still explicitly instantiate the

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. And please post your patches to the mailing list. Thanks, Andreas Am 08.02.2012 11:11, schrieb Evgeny Voevodin: The

Re: [Qemu-devel] [RFC PATCH v2 2/4] cadence_ttc: initial version of device model

2012-02-08 Thread Peter Crosthwaite
2012/2/8 Paul Brook p...@codesourcery.com - When are interrupts raised. You mention a user specified match value. Do we also get an interrupt on wraparound? Yes, an interrupts occur on wrap around of the 16 bit timer value. There are three match registers which correspond to three

[Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-08 Thread Gerd Hoffmann
This patch adds --{enable,disable}-debug-info switches to configure which allows to include/exclude the '-g' switch on the gcc ld command lines. Not building debug info reduces ressource usage (especially disk) alot and is quite useful for test builds. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [RFC] Replication agent requirements (was [RFC PATCH] replication agent module)

2012-02-08 Thread Ori Mamluk
Hi, Following previous mails from Kevin and Dor, I'd like to specify the high level requirements of a replication agent as I see them. 1. Report each write to a protected volume to the rephub, at an IO transaction granularity * The reporting is not synchronous, i.e. the write completion

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
On Wed, Feb 8, 2012 at 10:41 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 13:27, Paul Brook wrote: 2012/2/8 Paul Brook p...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does

Re: [Qemu-devel] [Qemu-ppc] Emulating AmigaOS 4.0

2012-02-08 Thread Alexander Graf
On 08.02.2012, at 14:00, Davide Calaminici wrote: Hello, just would like to know if with QEMU is possible to emulate AmigaOS 4.0 (powerPC 440 embedded processor). Emulating the CPU shouldn't be too bad, but I'm fairly sure we don't emulate the bootstrap and board model. If you have

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Alexander Graf
On 08.02.2012, at 14:04, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 10:41 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 13:27, Paul Brook wrote: 2012/2/8 Paul Brook p...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Paolo Bonzini
On 02/08/2012 01:03 PM, Stefan Hajnoczi wrote: If you intend to run an unmodified drbd server on the rephub, then it may not be possible to get point-in-time backups. (Although this probably depends since things like btrfs or zfs may allow you to get back to arbitrary transactions or

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2012-02-08 Thread Kevin Wolf
Am 20.12.2011 10:03, schrieb Dong Xu Wang: From: Dong Xu Wang wdon...@linux.vnet.ibm.com On some platforms, __LINE__ will not expand to real number in QEMU_BUILD_BUG_ON, so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch will fix it. BTW, I got error message

Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows

2012-02-08 Thread Kevin O'Connor
On Wed, Feb 08, 2012 at 09:18:24AM +0200, Gleb Natapov wrote: On Tue, Feb 07, 2012 at 07:35:34PM -0500, Kevin O'Connor wrote: I'm concerned about the VGA passthrough case. (I know that's not common and has other issues, but I also know several people have been working with it.) As near as

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

2012-02-08 Thread Thomas Huth
Am Wed, 8 Feb 2012 21:48:40 +1100 schrieb David Gibson da...@gibson.dropbear.id.au: On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote: On Wed, 8 Feb 2012, David Gibson wrote: From: Thomas Huth th...@linux.vnet.ibm.com These instructions for loading and storing byte-swapped

Re: [Qemu-devel] [RFC] Replication agent design (was [RFC PATCH] replication agent module)

2012-02-08 Thread Ori Mamluk
Hi, Thanks for all the valuable inputs provided so far, I'll try to suggest a design based on them. The main inputs were about the use a new transport protocol between repagent and rephub. It was suggested to use some standard network storage protocol instead, and use QMP commands for the

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
On Wed, Feb 8, 2012 at 11:10 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 14:04, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 10:41 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 13:27, Paul Brook wrote: 2012/2/8 Paul Brook p...@codesourcery.com I

Re: [Qemu-devel] [RFC] Replication agent requirements (was [RFC PATCH] replication agent module)

2012-02-08 Thread Anthony Liguori
On 02/08/2012 07:00 AM, Ori Mamluk wrote: Hi, Following previous mails from Kevin and Dor, I'd like to specify the high level requirements of a replication agent as I see them. 1. Report each write to a protected volume to the rephub, at an IO transaction granularity * The reporting is not

[Qemu-devel] [PATCH] server: support IPV6 addresses in channel events sent to qemu

2012-02-08 Thread Yonit Halperin
RHBZ #788444 CC: Gerd Hoffmann kra...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Yonit Halperin yhalp...@redhat.com --- server/reds.c | 21 + server/spice.h |6 ++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH] spice: support ipv6 channel address in monitor events and in spice info

2012-02-08 Thread Yonit Halperin
RHBZ #788444 CC: Gerd Hoffmann kra...@redhat.com Signed-off-by: Yonit Halperin yhalp...@redhat.com --- ui/spice-core.c | 37 - 1 files changed, 32 insertions(+), 5 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5639c6f..60fd6c3 100644

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
On 02/08/2012 01:55 AM, Peter A. G. Crosthwaite wrote: From: Peter A. G. Crosthwaitepeter.crosthwa...@petalogix.com Create a QOM device for bootstrapping linux on arm. Wraps the existing arm_boot code and calls arm_load_kernel() at device init. Allows booting of linux without -kernel -initrd

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Anthony Liguori
On 02/08/2012 06:41 AM, Alexander Graf wrote: On 08.02.2012, at 13:27, Paul Brook wrote: 2012/2/8 Paul Brookp...@codesourcery.com I suspect we want to replace the arm_load_kernel call with an arm_linux_loader device with appropriate properties. Ok, so does this mean the machine model

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
On Wed, Feb 8, 2012 at 11:35 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 14:30, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 11:10 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 14:04, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 10:41 PM, Alexander

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Alexander Graf
On 08.02.2012, at 15:05, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 11:35 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 14:30, Peter Crosthwaite wrote: On Wed, Feb 8, 2012 at 11:10 PM, Alexander Graf ag...@suse.de wrote: On 08.02.2012, at 14:04, Peter

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
So if we consider this bootloader a device and its -dtb argument a property of that device, then what you are implying is that every device property of every device in a machine must be managed by the machine model? Isn't the dynamic machine model work that is in progress is trying to get away

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
2012/2/9 Paul Brook p...@codesourcery.com So if we consider this bootloader a device and its -dtb argument a property of that device, then what you are implying is that every device property of every device in a machine must be managed by the machine model? Isn't the dynamic machine

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 12:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/08/2012 01:03 PM, Stefan Hajnoczi wrote: If you intend to run an unmodified drbd server on the rephub, then it may not be possible to get point-in-time backups.  (Although this probably depends since things like

Re: [Qemu-devel] [RFC Patch 5/7]Qemu: raw-posix image file reopen

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:07, schrieb Supriya Kannery: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery supri...@linux.vnet.ibm.com Index:

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Paolo Bonzini
On 02/08/2012 03:39 PM, Stefan Hajnoczi wrote: What about taking the existing Ceph/RBD driver in QEMU and changing it to support arbitrary image formats rather than just raw? That sounds much much easier. The main advantage is that Ceph has a user-space library for use in the

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Paul Brook
Its the other problem I am more worried about, i.e. when I -device instantiate my bootloader with an existing machine how do I get my ram_size and board_ID? The no machine opts for devices policy makes this impossible such that I would have to pass in board_id and ram_size to the boot-loader

Re: [Qemu-devel] [RFC] Replication agent design (was [RFC PATCH] replication agent module)

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 1:28 PM, Ori Mamluk omam...@zerto.com wrote: Hi, Thanks for all the valuable inputs provided so far, I'll try to suggest a design based on them. The main inputs were about the use a new transport protocol between repagent and rephub. It was suggested to use some

Re: [Qemu-devel] [RFC] Replication agent design (was [RFC PATCH] replication agent module)

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 2:59 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Feb 8, 2012 at 1:28 PM, Ori Mamluk omam...@zerto.com wrote: Hi, Thanks for all the valuable inputs provided so far, I'll try to suggest a design based on them. The main inputs were about the use a new transport

Re: [Qemu-devel] [RFC Patch 6/7]Qemu: raw-win32 image file reopen

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:07, schrieb Supriya Kannery: win32 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery supri...@linux.vnet.ibm.com Index:

[Qemu-devel] [PATCH v2] nic: zap obsolote romloading bits from ne2k + pcnet

2012-02-08 Thread Gerd Hoffmann
These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via romfile=emptystring like it is possible for all other nics. [ v2: rebased adapted to qom changes ] Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [RFC Patch 4/7]Qemu: Framework for reopening image files safely

2012-02-08 Thread Kevin Wolf
Am 01.02.2012 04:06, schrieb Supriya Kannery: Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya Kannery

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread malc
On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. It was always formatter like this (internally consistent), then others

Re: [Qemu-devel] [RFC PATCH] replication agent module

2012-02-08 Thread Stefan Hajnoczi
On Wed, Feb 8, 2012 at 2:55 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/08/2012 03:39 PM, Stefan Hajnoczi wrote:  What about taking the existing Ceph/RBD driver in QEMU and changing it to  support arbitrary image formats rather than just raw?  That sounds much much  easier.  

Re: [Qemu-devel] [RFC PATCH] arm boot: added QOM device definition

2012-02-08 Thread Peter Crosthwaite
So here are some of the problems im trying to solve with the bootloader: Smp bootstrap secondary CPUs while loading an elf (currently elfs will be assumed to be not kernels). Change the kernel, initrd and dtb load address on the command line. Use my own SMP secondary bootloop. My intention with

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-02-08 Thread Gerd Hoffmann
On 02/08/12 01:17, Rusty Russell wrote: As featured on: https://bugs.launchpad.net/qemu-linaro/+bug/928432 Since we compile with -Werror, the presence of spice headers breaks compile. Yet except for x86-64, it doesn't compile, doesn't work, isn't supported. See:

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: malc, Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. It was always formatter like this

Re: [Qemu-devel] [PATCH 1/3] Device isolation group infrastructure (v3)

2012-02-08 Thread Joerg Roedel
On Wed, Feb 01, 2012 at 03:46:52PM +1100, David Gibson wrote: In order to safely drive a device with a userspace driver, or to pass it through to a guest system, we must first make sure that the device is isolated in such a way that it cannot interfere with other devices on the system. This

[Qemu-devel] [PATCH 05/10] memory: code motion: move MEMORY_LISTENER_CALL()

2012-02-08 Thread Avi Kivity
So it can be used in earlier code. Signed-off-by: Avi Kivity a...@redhat.com --- memory.c | 64 +++--- 1 files changed, 32 insertions(+), 32 deletions(-) diff --git a/memory.c b/memory.c index cb2b4f1..a1013bc 100644 --- a/memory.c +++

[Qemu-devel] [PATCH 04/10] memory: switch memory listeners to a QTAILQ

2012-02-08 Thread Avi Kivity
This allows reverse iteration, which in turns allows consistent ordering among multiple listeners: l1-add l2-add l2-del l1-del Signed-off-by: Avi Kivity a...@redhat.com --- hw/vhost.c |1 + kvm-all.c |1 + memory.c | 70

[Qemu-devel] [PATCH 02/10] memory: remove memory_region_set_offset()

2012-02-08 Thread Avi Kivity
memory_region_set_offset() complicates the API, and has been deprecated since its introduction. Now that it is no longer used, remove it. Signed-off-by: Avi Kivity a...@redhat.com --- memory.c | 26 ++ memory.h |9 - 2 files changed, 10 insertions(+), 25

[Qemu-devel] [PATCH 06/10] memory: move ioeventfd ops to MemoryListener

2012-02-08 Thread Avi Kivity
This way the accelerator (kvm) can handle them directly. Signed-off-by: Avi Kivity a...@redhat.com --- hw/vhost.c | 14 ++ kvm-all.c | 78 memory.c | 74 ++---

[Qemu-devel] [PATCH 03/10] memory: add shorthand for invoking a callback on all listeners

2012-02-08 Thread Avi Kivity
Signed-off-by: Avi Kivity a...@redhat.com --- memory.c | 54 +++--- 1 files changed, 19 insertions(+), 35 deletions(-) diff --git a/memory.c b/memory.c index 382dded..6afe414 100644 --- a/memory.c +++ b/memory.c @@ -678,31 +678,23 @@ static void

[Qemu-devel] [PATCH 01/10] ioport: change portio_list not to use memory_region_set_offset()

2012-02-08 Thread Avi Kivity
memory_region_set_offset() will be going away soon, so don't use it. Use an alias instead. Signed-off-by: Avi Kivity a...@redhat.com --- ioport.c | 25 +++-- ioport.h |1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/ioport.c b/ioport.c index

[Qemu-devel] [PATCH 07/10] memory: add a readonly attribute to MemoryRegionSection

2012-02-08 Thread Avi Kivity
.readonly cannot be obtained from the MemoryRegion, since it is inherited from aliases (so you can have a MemoryRegion mapped RW at one address and RO at another). Record it in a MemoryRegionSection for listeners. Signed-off-by: Avi Kivity a...@redhat.com --- memory.c |5 + memory.h |

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:04, schrieb malc: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files. It was always formatter like this

[Qemu-devel] [PATCH 09/10] memory: use a MemoryListener for core memory map updates too

2012-02-08 Thread Avi Kivity
This transforms memory.c into a library which can then be unit tested easily, by feeding it inputs and listening to its outputs. Signed-off-by: Avi Kivity a...@redhat.com --- exec-obsolete.h |3 ++ exec.c | 75 +++ memory.c

Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

2012-02-08 Thread Avi Kivity
On 02/08/2012 05:27 PM, Avi Kivity wrote: This patchset makes the memory core (memory.c) talk to the backend (in exec.c) via a MemoryListener instead of named functions. While the motivation for this is to simplify the memory core, it also enables optimizing accelerators some more (by having

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Andreas Färber
Am 08.02.2012 16:23, schrieb Anthony Liguori: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first to not error on that formatting in your files.

[Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

2012-02-08 Thread Avi Kivity
This patchset makes the memory core (memory.c) talk to the backend (in exec.c) via a MemoryListener instead of named functions. While the motivation for this is to simplify the memory core, it also enables optimizing accelerators some more (by having a tcg MemoryListener to do tcg specific core)

Re: [Qemu-devel] Restore consistent formatting

2012-02-08 Thread Anthony Liguori
On 02/08/2012 09:36 AM, Andreas Färber wrote: Am 08.02.2012 16:23, schrieb Anthony Liguori: On 02/08/2012 09:04 AM, malc wrote: On Wed, 8 Feb 2012, Andreas F?rber wrote: Arbitrarily reformatting your files is not okay. If you want a different formatting, you need to fix checkpatch.pl first

  1   2   >