Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-02-23 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 02/15/2012 07:33 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 02/14/2012 11:24 AM, Markus Armbruster wrote: Markus Armbrusterarm...@redhat.com writes: Anthony Liguorialigu...@us.ibm.com writes: [Anthony

[Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
Hi, $subject says all, which pretty much breaks libvirt-managed qemu ... cheers, Gerd

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 09:20, Gerd Hoffmann wrote: Hi, $subject says all, which pretty much breaks libvirt-managed qemu ... Even just qemu segfaults, right here: (gdb) bt #0 qemu_opt_get (opts=0x0, name=0x77f7478f kernel) at /home/kraxel/projects/qemu/qemu-option.c:545 #1 0x77deb1b0

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Peter Maydell
On 23 February 2012 08:20, Gerd Hoffmann kra...@redhat.com wrote: $subject says all, which pretty much breaks libvirt-managed qemu ... Does http://patchwork.ozlabs.org/patch/142548/ fix this for you? -- PMM

[Qemu-devel] effect of cluster_size on qcow2 performance during expansion

2012-02-23 Thread PANKAJ RAWAT
Hi all I have been working on the qcow2 image format , In theory regarding cluster size it is written that as the size of cluster increase performance should increase. But something surprising happen The performance is degrading as the size of cluster increased from *64K* to *1M* or *2M* (

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote: $subject says all, which pretty much breaks libvirt-managed qemu ... Also device_add nonexistent-device in the monitor gives a rather unhelpful message: Parameter 'driver' expects device type Cheers

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Markus Armbruster
andrzej zaborowski balr...@gmail.com writes: On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote: $subject says all, which pretty much breaks libvirt-managed qemu ... Also device_add nonexistent-device in the monitor gives a rather unhelpful message: Parameter 'driver' expects

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 09:23, Peter Maydell wrote: On 23 February 2012 08:20, Gerd Hoffmann kra...@redhat.com wrote: $subject says all, which pretty much breaks libvirt-managed qemu ... Does http://patchwork.ozlabs.org/patch/142548/ fix this for you? Yes. thanks, Gerd

Re: [Qemu-devel] qemu -device ? segfaults

2012-02-23 Thread andrzej zaborowski
On 23 February 2012 09:48, Markus Armbruster arm...@redhat.com wrote: andrzej zaborowski balr...@gmail.com writes: On 23 February 2012 09:20, Gerd Hoffmann kra...@redhat.com wrote: $subject says all, which pretty much breaks libvirt-managed qemu ... Also device_add nonexistent-device in the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl.c: Increase width of machine name column in -M ? output

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 10:13:11PM +, Peter Maydell wrote: Increase the width of the column used for the machine name in the -M ? output from 10 to 20 spaces. This fixes the formatting so it looks nice for architectures where a few of the machines have overly long names. (Our current

Re: [Qemu-devel] [Bug 939027] [NEW] Combining direct_io and non-direct_io leads to hang

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 09:49:59PM -, Avleen Vig wrote: Version 0.12.2 - I know this isn't the latest but I looked through the changelogs and couldn't find any references to this being fixed. This is related to issues that many apps have, and is described in more detail here:

Re: [Qemu-devel] Cluster_size parameter issue on qcow2 image format

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 11:01:46AM +0530, PANKAJ RAWAT wrote: I theory regarding cluster size it is written that as the size of cluster increase performance should increase. But something surprising happen The performance is degrading as the size of cluster increased from 64K to 1M (

Re: [Qemu-devel] effect of cluster_size on qcow2 performance during expansion

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 8:24 AM, PANKAJ RAWAT pankajr...@gmail.com wrote: Here are the reading taken through fio tool during write operation Cluster size : 32K    587Mb/sec (aggrb MB/sec) Cluster size : 64K    697Mb/sec (aggrb MB/sec) Cluster size : 1M     440Mb/sec  (aggrb MB/sec)

[Qemu-devel] [PATCH 2/2] optimize screendump for the common non-switch case

2012-02-23 Thread Gerd Hoffmann
switch console only if needed, also pass down whenever the console was switched or not because a displaysurface redraw is only needed in case the console was switched. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 10 +++--- console.h |2 +- hw/qxl.c

[Qemu-devel] [PATCH 0/2] screendump fixups

2012-02-23 Thread Gerd Hoffmann
Hi, After checking again I figured the displaychangelistener for screendumps isn't needed. Sorry alon. So lets just zap it. Also the console switching can be optimized further, when no switching was needed (the common case) we can just go ahead and write out the dump without a full

[Qemu-devel] [PATCH 1/2] vga: simplify screendump

2012-02-23 Thread Gerd Hoffmann
The displaychangelistener isn't needed at all, we can simply save the image when vga_hw_update is done instead of hooking into the update process. --- hw/vga.c | 36 +--- 1 files changed, 1 insertions(+), 35 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index

Re: [Qemu-devel] [PATCH v5 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-23 Thread Gerd Hoffmann
Hi, vga: stop after the first ppm_save - single liner to ensure a single ppm_save for a single screendump monitor command. That needs a refinement. /me somehow looked at a old vga.c checkout and missed commit 2313e998d7bf55d02499ee162fb4558af4fbb3f5. See the small patch series

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Paolo Bonzini pbonz...@redhat.com Cc: Federico Simoncelli fsimo...@redhat.com, kw...@redhat.com, mtosa...@redhat.com, qemu-devel@nongnu.org Sent: Thursday, February 23, 2012 8:38:55 AM Subject: Re: [PATCH 3/3] Add nocreate option to snapshot_blkdev On

[Qemu-devel] qemu-ga error reporting

2012-02-23 Thread Michal Privoznik
Hi guys, I ran into weird issue. Issuing unknown-command on qemu monitor gives this: {error: {class: CommandNotFound, desc: The command unknown-command has not been found, data: {name: unknown-command}}} However, issuing the very same on GA socket gets me: {error: {class: CommandNotFound,

Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Paolo Bonzini pbonz...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 8:18:28 AM Subject: Re: [PATCH 2/3] Update the blkmirror block driver On

[Qemu-devel] [PULL] Merge qemu-iotests into qemu.git

2012-02-23 Thread Kevin Wolf
The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christoph Hellwig (10): qemu-iotests: Initial import into the public

Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 10:44 AM, Federico Simoncelli wrote: Any comment on the BDRV_O_NO_BACKING flag I added? That's the real trick I'm pulling here. It basically allows to open the second image only for writing and it doesn't complain if the backing file is not there yet (it will be copied during

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 10:39 AM, Federico Simoncelli wrote: I agree on the fact that using snapshot_blkdev is a misnomer but at the same time I like very much how blkmirror is modular and it can be used as a regular image filename. True, on the other hand if we add this we will have to keep it forever.

Re: [Qemu-devel] [PATCH 1/2] vga: simplify screendump

2012-02-23 Thread Alon Levy
On Thu, Feb 23, 2012 at 10:22:37AM +0100, Gerd Hoffmann wrote: The displaychangelistener isn't needed at all, we can simply save the image when vga_hw_update is done instead of hooking into the update process. ACK. --- hw/vga.c | 36 +--- 1 files changed,

Re: [Qemu-devel] Cluster_size parameter issue on qcow2 image format

2012-02-23 Thread PANKAJ RAWAT
Thanks for the reply . i am not using a backing file. My concern is growing file system. The performance of 64K is better than 1M , 2M or 32K Is the degrade in performance is only due to allocation of large cluster during expansion of qcow2 image ? But the trend is same in case of Sequential

Re: [Qemu-devel] [PATCH 2/2] optimize screendump for the common non-switch case

2012-02-23 Thread Alon Levy
On Thu, Feb 23, 2012 at 10:22:38AM +0100, Gerd Hoffmann wrote: switch console only if needed, also pass down whenever the console was switched or not because a displaysurface redraw is only needed in case the console was switched. You've missed some implementations of the

Re: [Qemu-devel] Cluster_size parameter issue on qcow2 image format

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 10:02 AM, PANKAJ RAWAT pankajr...@gmail.com wrote: Is the degrade in performance is only due to allocation of large cluster during expansion of qcow2 image ? But the trend is same in case of Sequential write Random write  of 1 GB data In random i can understand the

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Paolo Bonzini pbonz...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: kw...@redhat.com, mtosa...@redhat.com, qemu-devel@nongnu.org Sent: Thursday, February 23, 2012 10:48:59 AM Subject: Re: [PATCH 3/3] Add nocreate option to snapshot_blkdev On

[Qemu-devel] [PATCH 4/6 v2] virtio-serial: Call .guest_ready when new space is available in the queue.

2012-02-23 Thread Andrzej Zaborowski
Without that it's impossible to write a virtio-serial port driver that sends any buffers bigger than a couple kilobytes, other than by polling to check when space in the queue becomes available. Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- v2: rebase after QOM. ---

[Qemu-devel] [PATCH 5/6 v2] gl: virtio-serial port driver for OpenGL passthrough.

2012-02-23 Thread Andrzej Zaborowski
This is a relatively simple to use OpenGL passthrough transport because it doesn't need any guest kernel changes, but it's not blazing fast. Still faster than software rendering. The main problems are: * transfers are split in very small chunks by virtio queues, some OpenGL calls (think

[Qemu-devel] [PATCH 6/6 v2] gl: -enable-gl switch to enable the OpenGL virtio port.

2012-02-23 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- qemu-options.hx | 24 vl.c| 36 2 files changed, 60 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index b129996..8a5784c

Re: [Qemu-devel] Cluster_size parameter issue on qcow2 image format

2012-02-23 Thread PANKAJ RAWAT
Thanks for the reply On Thu, Feb 23, 2012 at 3:46 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Feb 23, 2012 at 10:02 AM, PANKAJ RAWAT pankajr...@gmail.com wrote: Is the degrade in performance is only due to allocation of large cluster during expansion of qcow2 image ? But the

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 11:19 AM, Federico Simoncelli wrote: I'm worried that blkmirror does not satisfy _all_ mirroring needs, for example you cannot use block_stream to copy from the source to the destination, so perhaps in the future we want to change it to something else. Are you talking about a

[Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-23 Thread Erik Rull
When running qemu with -device usb-host an assertion failed caused by attaching a new usb device to the host that gets routed to the guest. The assertion that fails is: qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_complete: Assertion 'p-state == USB_PACKET_QUEUED' failed. It was

Re: [Qemu-devel] arm-linux-user, i386-linux-user: Make QEMU act as TCG compiler

2012-02-23 Thread Rajat Goyal
QEMU as a dynamic translator is already available. This adds extra functionality to QEMU. I needed to do this since I wanted to explore the ARM memory model over TCG micro-operations; so I needed translation of the whole binary and not just the parts which QEMU needs to execute. Don't know if

[Qemu-devel] [Bug 939437] [NEW] spice is not supported by this qemu build.(ubuntu 12.04)

2012-02-23 Thread qpine
Public bug reported: $ kvm -spice port=5900,addr=127.0.0.1,disable-ticketing kvm: -spice port=5900,addr=127.0.0.1,disable-ticketing: there is no option group spice spice is not supported by this qemu build. $ kvm -version QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice

[Qemu-devel] [Bug 939443] [NEW] qemu-system-x86_64 can no support 1366x768

2012-02-23 Thread qpine
Public bug reported: My laptop resolution is 1366x768, but can not support at -vga vmware the -vga std. $ kvm -version QEMU emulator version 1.0 (qemu-kvm-1.0), Copyright (c) 2003-2008 Fabrice Bellard ** Affects: qemu Importance: Undecided Status: New -- You received this bug

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-23 Thread Luiz Capitulino
On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbruster arm...@redhat.com wrote: Kevin Wolf kw...@redhat.com writes: Am 17.02.2012 20:21, schrieb Luiz Capitulino: It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-by: Luiz Capitulino

[Qemu-devel] git bisect results was: qemu assertion failed with usb on current git master!

2012-02-23 Thread Erik Rull
Here the bisect results: db4be873d312576c6971da15a38e056017a406b8 is the first bad commit commit db4be873d312576c6971da15a38e056017a406b8 Author: Gerd Hoffmann kra...@redhat.com Date: Thu Jan 12 14:26:13 2012 +0100 usb: maintain async packet list per endpoint Maintain a list of

[Qemu-devel] [PATCH v6 01/12] acpi: move around structs

2012-02-23 Thread Gerd Hoffmann
Group all structs at the top of hw/acpi.h. Just moving around lines, no code changes. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.h | 48 +++- 1 files changed, 23 insertions(+), 25 deletions(-) diff --git a/hw/acpi.h b/hw/acpi.h index

[Qemu-devel] [PATCH v6 00/12] initial suspend support

2012-02-23 Thread Gerd Hoffmann
Hi, Next round, dropping the wakeup reason from the wakeup qmp event and improving monitor command description in the josn schema. cheers, Gerd The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in

[Qemu-devel] [PATCH v6 04/12] acpi: add acpi_pm1_evt_write_en

2012-02-23 Thread Gerd Hoffmann
Do APCIREGS-pm1.evt.en updates using the new acpi_pm1_evt_write_en function, so the acpi code will see those updates. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c |5 + hw/acpi.h |1 + hw/acpi_piix4.c |2 +- hw/vt82c686.c |2 +- 4 files changed,

[Qemu-devel] [PATCH v6 06/12] suspend: switch acpi s3 to new infrastructure.

2012-02-23 Thread Gerd Hoffmann
This patch switches pc s3 suspend over to the new infrastructure. The cmos_s3 qemu_irq is killed, the new notifier is used instead. The xen hack goes away with that too, the hypercall can simply be done in a notifier function now. This patch also makes the guest actually stay suspended instead of

[Qemu-devel] [PATCH v6 08/12] suspend: make ps/2 devices wakeup the guest

2012-02-23 Thread Gerd Hoffmann
This patch adds wakeup support to ps/2 emulation. Any key press on the ps/2 keyboard will wakeup the guest. Likewise any mouse button press will wakeup the guest. Mouse moves are ignored, so the guest will not wakeup in case your mouse crosses the vnc window of a suspended guest by accident.

[Qemu-devel] [PATCH v6 07/12] suspend: add system_wakeup monitor command

2012-02-23 Thread Gerd Hoffmann
This patch adds the system_wakeup monitor command which will simply wake up suspended guests. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 14 ++ hmp.c|5 + hmp.h|1 + qapi-schema.json | 11 +++ qmp-commands.hx

[Qemu-devel] [PATCH v6 09/12] suspend: make serial ports wakeup the guest.

2012-02-23 Thread Gerd Hoffmann
Add a 'wakeup' property to the serial port. It is off by default. When enabled any incoming character on the serial line will wake up the guest. Useful for guests which have a serial console configured. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/serial.c |6 ++ 1 files

[Qemu-devel] [PATCH v6 12/12] suspend: add qmp events

2012-02-23 Thread Gerd Hoffmann
Send qmp events on suspend and wakeup so libvirt has a chance to track the vm state. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- monitor.c |6 ++ monitor.h |2 ++ vl.c |2 ++ 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH] ehci: fix reset

2012-02-23 Thread Gerd Hoffmann
Two reset fixes: * pick up s-usbcmd value after ehci_reset call to make sure it keeps the reset value and doesn't get rubbish filled in when val is written back to the mmio register array later on. * make sure the frame timer is zapped on reset. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 2/2] build: replace librt check function

2012-02-23 Thread Roger Pau Monné
2012/2/22 Anthony Liguori anth...@codemonkey.ws: On 02/20/2012 06:11 AM, Roger Pau Monne wrote: Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking against librt (although the manual page states the opposite).

[Qemu-devel] [PATCH v6 03/12] acpi: don't pass overflow_time to acpi_pm1_evt_get_sts

2012-02-23 Thread Gerd Hoffmann
Pretty pointless, can easily be reached via ACPIREGS now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c |6 +++--- hw/acpi.h |2 +- hw/acpi_piix4.c |4 ++-- hw/vt82c686.c |4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v6 10/12] suspend: make rtc alarm wakeup the guest.

2012-02-23 Thread Gerd Hoffmann
Make the rtc wake up the guest when the alarm fires. Add acpi windup to property support RTC_EN, so guests can enable and disable this. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c|7 +++ hw/mc146818rtc.c |1 + sysemu.h |1 + 3 files changed, 9

[Qemu-devel] [PATCH v6 11/12] suspend: make acpi timer wakeup the guest.

2012-02-23 Thread Gerd Hoffmann
Make the acpi timer wake up the guest. Guests can enable/disable this via acpi too. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi.c |8 sysemu.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index c05dde6..5d521e5 100644

[Qemu-devel] [PATCH v6 02/12] acpi: add ACPIREGS

2012-02-23 Thread Gerd Hoffmann
All those acpi structs are not independent from each other. Various acpi functions expecting multiple acpi structs passed in are a clean indicator for that ;) So this patch bundles all acpi structs in the new ACPIREGS struct, then use it everythere pass around acpi state. Signed-off-by: Gerd

[Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-02-23 Thread Meador Inge
'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the opcode table creation code to erroneously register 'eieio' and 'mbar' for the default processor: ** ERROR: opcode 1a already assigned in opcode table 16 *** ERROR: unable to insert opcode [1f-16-1a] *** ERROR

[Qemu-devel] [PATCH v6 05/12] suspend: add infrastructure

2012-02-23 Thread Gerd Hoffmann
This patch adds some infrastructure to handle suspend and resume to qemu. First there are two functions to switch state and second there is a suspend notifier: * qemu_system_suspend_request is supposed to be called when the guest asks for being be suspended, for example via ACPI. *

Re: [Qemu-devel] [PATCH 0/5] VMState cleanups

2012-02-23 Thread Juan Quintela
Alexander Graf ag...@suse.de wrote: On 22.02.2012, at 17:09, Peter Maydell wrote: On 22 February 2012 16:04, Andreas Färber afaer...@suse.de wrote: Am 22.02.2012 16:42, schrieb Peter Maydell: On 22 February 2012 15:37, Andreas Färber afaer...@suse.de wrote: NB: Your cpu-vmstate patches were

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-23 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbruster arm...@redhat.com wrote: Kevin Wolf kw...@redhat.com writes: Am 17.02.2012 20:21, schrieb Luiz Capitulino: It's emitted whenever the tray is moved by the guest or by HMP/QMP commands.

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-23 Thread Luiz Capitulino
On Sun, 19 Feb 2012 12:15:43 +0100 Michal Privoznik mpriv...@redhat.com wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal

[Qemu-devel] [PATCH] usb-hid: fix tablet activation

2012-02-23 Thread Gerd Hoffmann
Activate usb hid pointer devices (mouse+tablet) unconditionally on polls, even if we NAK the poll due to lack of new events. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hid.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/usb-hid.c b/hw/usb-hid.c

[Qemu-devel] [PULL 0/5]: QMP queue

2012-02-23 Thread Luiz Capitulino
Contains only the DEVICE_TRAY_MOVED event series. The changes (since 235fe3bfd46b1104575b540d0bc3fdf584030b99) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (5): block: Rename bdrv_mon_event() BlockMonEventAction

[Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

2012-02-23 Thread Luiz Capitulino
This is used to sync the physical tray state after migration when using CD-ROM passthrough. However, migrating when using passthrough is broken anyway and shouldn't be supported... So, drop this function as it causes a problem with the DEVICE_TRAY_MOVED event, which is going to be introduced by

[Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool

2012-02-23 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- block.c |2 +- block.h |2 +- block/raw-posix.c |6 +++--- block/raw.c |2 +- block_int.h |2 +- 5

[Qemu-devel] [PATCH 1/5] block: Rename bdrv_mon_event() BlockMonEventAction

2012-02-23 Thread Luiz Capitulino
They are QMP events, not monitor events. Rename them accordingly. Also, move bdrv_emit_qmp_error_event() up in the file. A new event will be added soon and it's good to have them next each other. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-23 Thread Luiz Capitulino
It's emitted whenever the tray is moved by the guest or by HMP/QMP commands. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com Acked-by: Kevin Wolf kw...@redhat.com --- QMP/qmp-events.txt | 18 ++ block.c| 24

[Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-23 Thread Luiz Capitulino
It's not needed. Besides we can then assume that bdrv_eject() is only called when there's a tray state change, which is useful to the DEVICE_TRAY_MOVED event (going to be added in a future commit). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Markus Armbruster

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-23 Thread Gerd Hoffmann
On 02/23/12 12:38, Erik Rull wrote: When running qemu with -device usb-host an assertion failed caused by attaching a new usb device to the host that gets routed to the guest. The assertion that fails is: qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_complete: Assertion

Re: [Qemu-devel] [Bug 938945] [NEW] Slirp cannot be forward and makes segmentation faults

2012-02-23 Thread Andreas Färber
Am 22.02.2012 20:50, schrieb Vincent Autefage: $ qemu -enable-kvm -name opeth -hda debian1.img -k fr -localtime -m 512 The qemu executable has been renamed to qemu-system-i386 some time ago. Are you sure you're executing the right one, and which version are you using? Did you check qemu.git

[Qemu-devel] [Bug 883136] Re: qemu on ARM hosts aborts on startup because makecontext() always fails

2012-02-23 Thread Peter Maydell
Michael Hope pointed out that glibc defines a macro __stub_makecontext when the makecontext() implementation is a stub, so we can just add this to the qemu configure test to make it automatically fall back to the pthreads version as required. -- You received this bug notification because you are

[Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Peter Lieven
Hi, i have recently been playing with an old idea (originally in grsecurity for security reasons) to change the policy from zero on allocate to zero after free in the linux page allocator. My concern is that linux leaves a lot of waste in the physical memory unlike Windows which per default zeros

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli fsimo...@redhat.com wrote: Preparation === $ mkdir /tmp/{src/dst} $ qemu-img create -f qcow2 /tmp/src/hd0base.qcow2 20G Formatting '/tmp/src/hd0base.qcow2', fmt=qcow2 size=21474836480 encryption=off cluster_size=65536 Step 1 -

Re: [Qemu-devel] FLR capability hidden in VF config space

2012-02-23 Thread Alex Williamson
On Thu, 2012-02-23 at 09:25 +0530, rukhsana ansari wrote: Hello, Was wondering whether someone could shed some light on the issue below. Without FLR exposed in the VF, VF reset via FLR cannot be initiated from the guest. Appreciate any pointers. The device state needs to be restored after

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 4:47:38 PM Subject: Re: [Qemu-devel] Live Block Migration using Mirroring On

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli fsimo...@redhat.com wrote: From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. I think the right approach is to create a single blkmirror driver that also includes blkverify functionality. The code is

[Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2012-02-23 Thread Peter Maydell
Improve the configure test for presence of ucontext functions by making linker warnings fatal; this allows us to detect when we are linked with a glibc which implements makecontext() to always return ENOSYS. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Compiling on an Ubuntu Natty

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: By the way, this code does not build against qemu.git/master.  It uses interfaces which have been dropped. Ah, I see you changed that in Patch 2/3. Please don't do that, it's hard to review and breaks git-bisect.

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 5:14:09 PM Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2012-02-23 Thread Peter Maydell
On 23 February 2012 16:16, Peter Maydell peter.mayd...@linaro.org wrote: Improve the configure test for presence of ucontext functions by making linker warnings fatal; this allows us to detect when we are linked with a glibc which implements makecontext() to always return ENOSYS. Er, ignore

[Qemu-devel] [PATCH] configure: Check whether makecontext() is a glibc stub function

2012-02-23 Thread Peter Maydell
On some systems (notably ARM Linux) glibc provides implementations of makecontext(), getcontext() and friends which are stubs which always return failure. Make the configure test for makecontext() also check for the presence of the __stub_makecontext macro which indicates the presence of these

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 5:18:41 PM Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver On

Re: [Qemu-devel] [PATCH] qom: Make object_unref() free the object's memory when refcount goes to 0.

2012-02-23 Thread Alexander Barabash
On 02/22/2012 09:12 PM, Anthony Liguori wrote: On 02/22/2012 12:00 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabashalexander_barab...@mentor.com In the existing implementation, object_delete() calls object_unref(), then frees the object's storage. Running object_delete() on an

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 4:20 PM, Federico Simoncelli fsimo...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Stefan Hajnoczi
On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli fsimo...@redhat.com wrote:  recently I've been working on live block migration combining the live snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. The design is summarized at this url as Mirrored-Snapshot:

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit of zero after free in a virtualisation environment is obvious: 1) zero pages can easily be merged by ksm or other

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 5:28:23 PM Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver On

[Qemu-devel] [Bug 918791] Re: qemu-kvm dies when using vmvga driver and unity in the guest

2012-02-23 Thread Serge Hallyn
@Jamie, if you feel the priority if this needs to be raised, please do raise it or comment here. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/918791 Title: qemu-kvm dies when using vmvga driver

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 5:35:23 PM Subject: Re: [Qemu-devel] Live Block Migration using Mirroring On

Re: [Qemu-devel] VirtIO 9p mount_tag (bogus?) limit of 32 bytes

2012-02-23 Thread Aneesh Kumar K.V
On Tue, 21 Feb 2012 21:58:39 -0600, C Anthony Risinger anth...@xtfx.me wrote: On Sat, Feb 18, 2012 at 11:38 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: On Thu, 16 Feb 2012 06:20:21 -0600, C Anthony Risinger anth...@xtfx.me wrote: a) mapped FS security policy (xattrs)

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-23 Thread Erik Rull
Gerd Hoffmann wrote: On 02/23/12 12:38, Erik Rull wrote: When running qemu with -device usb-host an assertion failed caused by attaching a new usb device to the host that gets routed to the guest. The assertion that fails is: qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread Javier Guerra Giraldez
On Thu, Feb 23, 2012 at 11:42 AM, Stefan Hajnoczi stefa...@gmail.com wrote: The other approach is a memory page discard mechanism - which obviously requires more code changes than zeroing freed pages. The advantage is that we don't take the brute-force and CPU intensive approach of zeroing

Re: [Qemu-devel] linux guests and ksm performance

2012-02-23 Thread peter.lie...@gmail.com
Stefan Hajnoczi stefa...@gmail.com schrieb: On Thu, Feb 23, 2012 at 3:40 PM, Peter Lieven p...@dlh.net wrote: However, in a virtual machine I have not observed the above slow down to that extend while the benefit of zero after free in a virtualisation environment is obvious: 1) zero

Re: [Qemu-devel] arm-linux-user, i386-linux-user: Make QEMU act as TCG compiler

2012-02-23 Thread Rajat Goyal
Hi Peter, Would QEMU developers be interested in integrating this TCG compilation functionality that I have been working on into later releases of QEMU? The patch I have right now breaks the original emulation but if there is some interest in supporting static compilation into TCG in the future,

Re: [Qemu-devel] PCI: Add PCI_EXP_TYPE_PCIE_BRIDGE value

2012-02-23 Thread Jesse Barnes
On Tue, 21 Feb 2012 16:22:10 + Anthony PERARD anthony.per...@citrix.com wrote: Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- include/linux/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/pci_regs.h

Re: [Qemu-devel] [PATCH V7 03/11] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2012-02-23 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 05:08:37PM +, Anthony PERARD wrote: Signed-off-by: Anthony PERARD anthony.per...@citrix.com Applied, thanks. --- hw/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index 6b42515..56a404b 100644

[Qemu-devel] [PATCH v2 0/6] add fixed-width visitors and serialization tests

2012-02-23 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v2 CHANGES SINCE V1: - unit tests: covert QmpOutputVisitor qobject to json before passing it to QmpInputVisitor*. I.e., actually do the serialization :) -

[Qemu-devel] [PATCH v2 1/6] qapi: add Visitor interfaces for uint*_t and int*_t

2012-02-23 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type.

[Qemu-devel] [PATCH v2 4/6] qapi: add String visitor coverage to serialization unit tests

2012-02-23 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- test-visitor-serialization.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c index 6ef57d0..b8ad16f 100644 ---

[Qemu-devel] [PATCH v2 6/6] qdev: switch property accessors to fixed-width visitor interfaces

2012-02-23 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- hw/qdev-addr.c |4 ++-- hw/qdev-properties.c | 42 +- 2 files changed, 19 insertions(+), 27 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 ---

[Qemu-devel] [PATCH v2 3/6] qapi: QMP input visitor, handle floats parsed as ints

2012-02-23 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-23 Thread Stefan Berger
On 02/20/2012 10:48 AM, Stefan Berger wrote: On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote: +static const MemoryRegionOps tpm_tis_memory_ops = { +.read = tpm_tis_mmio_read, +.write = tpm_tis_mmio_write, +.endianness = DEVICE_NATIVE_ENDIAN, Are you sure? Most devices are BIG or

[Qemu-devel] [PATCH v2 2/6] qapi: unit tests for visitor-based serialization

2012-02-23 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for

  1   2   >