On 28.03.2012 19:43, Stefan Hajnoczi wrote:
void ide_sector_read(IDEState *s)
{
[]
+s-iov.iov_base = s-io_buffer;
+s-iov.iov_len = n * BDRV_SECTOR_SIZE;
+qemu_iovec_init_external(s-qiov, s-iov, 1);
+
+bdrv_acct_start(s-bs, s-acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_READ);
+
On 28.03.2012 19:43, Stefan Hajnoczi wrote:
...
void ide_sector_read(IDEState *s)
{
...
+s-iov.iov_base = s-io_buffer;
+s-iov.iov_len = n * BDRV_SECTOR_SIZE;
+qemu_iovec_init_external(s-qiov, s-iov, 1);
+bdrv_aio_readv(s-bs, sector_num, s-qiov, n,
+
On 29.03.2012 10:46, Michael Tokarev wrote:
On 28.03.2012 19:43, Stefan Hajnoczi wrote:
...
void ide_sector_read(IDEState *s)
{
...
+s-iov.iov_base = s-io_buffer;
+s-iov.iov_len = n * BDRV_SECTOR_SIZE;
+qemu_iovec_init_external(s-qiov, s-iov, 1);
+bdrv_aio_readv(s-bs,
On 29 March 2012 03:54, Peter A. G. Crosthwaite
peter.crosthwa...@petalogix.com wrote:
Device model for Primecell PL330 dma controller.
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
+/*
+ * ARM PrimeCell PL330 DMA Controller
+ *
+ * Copyright (c) 2009 Samsung
On Thu, 29 Mar 2012, David Gibson wrote:
From: Li Zhang zhlci...@linux.vnet.ibm.com
There two entries of INDEX_op_ld_i64 in the ppc_op_defs. That causes an
assertion failure in tcg_add_target_add_op_defs() when --enable-debug is
used on a ppc64 backend (that's ppc64 host, not target).
On Tue, Mar 27, 2012 at 07:59:08PM +0200, Michael S. Tsirkin wrote:
piix acpi interface suffers from the following 2 issues:
1.
- delete device a
- quickly add device b in another slot
if we do this before guest reads the down register,
the down event is discarded and device will never
On Thu, Mar 29, 2012 at 7:42 AM, Michael Tokarev m...@tls.msk.ru wrote:
On 28.03.2012 19:43, Stefan Hajnoczi wrote:
void ide_sector_read(IDEState *s)
{
[]
+ s-iov.iov_base = s-io_buffer;
+ s-iov.iov_len = n * BDRV_SECTOR_SIZE;
+ qemu_iovec_init_external(s-qiov, s-iov, 1);
+
+
On Wed, Mar 28, 2012 at 05:50:53PM -0300, Luiz Capitulino wrote:
@@ -268,7 +270,14 @@ static int pci_device_hot_remove(Monitor *mon, const
char *pci_addr)
monitor_printf(mon, slot %d empty\n, slot);
return -1;
}
-return qdev_unplug(d-qdev);
+
+ret =
On Wed, Mar 28, 2012 at 05:50:54PM -0300, Luiz Capitulino wrote:
ret = qdev_unplug(dev, local_err);
if (error_is_set(local_err)) {
-qerror_report_err(local_err);
-error_free(local_err);
+error_propagate(errp, local_err);
+} else if (ret) {
+
On Wed, Mar 28, 2012 at 08:56:38PM +0200, Jan Kiszka wrote:
Avoids lots of warnings.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
qemu_socket.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
Thanks, applied to the trivial patches tree:
Older pod2man don't have a --utf8 switch, check for this in conffigure
and use it only when present. Fixes build on RHEL-5.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
Makefile |1 -
configure |8
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/Makefile
On 03/28/12 20:47, Hans de Goede wrote:
frindex always is a 14 bits counter, and not a 13 bits one as we were
emulating. There are some subtle hints to this in the spec, first of all
Table 2-12. FRINDEX - Frame Index Register says:
Bit 13:0 Frame Index. The value in this register increments at
On 03/26/12 16:15, Alon Levy wrote:
Add mouse_mode, either server or mouse, to qmp and hmp commands, based
on spice_server_is_server_mouse added in spice-server 0.10.3.
Looks good. What is the status of the spice-server patch? Committed?
cheers,
Gerd
Il 29/03/2012 10:29, Stefan Hajnoczi ha scritto:
This was kind of a wart in the interface because it created 2 error
handling paths: one immediate return and one callback with error. I
think Paolo and Kevin were the ones to address this.
I think you did that when adding the coroutines. I
On 28/03/12 01:46, David Gibson wrote:
Hi David,
If we're going to make this specific to MSRs, might as well cut down on
the user's verbosity:
#define MSR_BIT(x) ((target_ulong)1 MSR_##x)
...and move it to a header file.
Or possibly have the header file define a set of MSRBIT_IR,
On Thu, Mar 29, 2012 at 02:53:52PM +1100, David Gibson wrote:
On Wed, Mar 28, 2012 at 11:30:56AM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 28, 2012 at 12:11:52PM +1100, David Gibson wrote:
Michael,
Any chance of an ack or nack on this one?
On Mon, Mar 19, 2012 at 03:58:11PM
The IDE PIO write sector code path uses bdrv_write() and hence can make
the guest unresponsive while the I/O request is in progress. This patch
converts ide_sector_write() to use bdrv_aio_writev() by using the
BUSY_STAT bit to tell the guest that the request is in progress.
Signed-off-by: Stefan
The IDE PIO interface currently uses bdrv_read() to perform reads
synchronously. Synchronous I/O in the vcpu thread is bad because it
prevents the guest from executing code - it makes the guest
unresponsive.
This patch converts IDE PIO to use bdrv_aio_readv(). We simply need to
use the
IDE PIO mode is currently implemented using synchronous I/O functions. There's
no need to do this because the IDE interface is actually designed with polling
and interrupts in mind - we can do asynchronous I/O and let the guest know when
the operation has completed. The benefit of asynchronous
Now I want to moniter memory access on QEMU (guest virtual or guest
physical).
I found that QEMU will translate arm instructions into TCG instructions,
and the TCG instructions will be translated into X86 instructions.
The function tcg_out_op(tcg/i386/tcg_target.c) will translate the TCG
Just wanted to say thanks to everyone who got this fix out. Works great!
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/524447
Title:
virsh save is very slow
Status in libvirt virtualization API:
On Wed, 2012-03-28 at 22:27 -0400, Kevin O'Connor wrote:
On Wed, Mar 28, 2012 at 04:39:07PM +0200, Gerd Hoffmann wrote:
On 03/28/12 06:28, Alexey Korolev wrote:
This linked list implementation is partially based on kernel code. So it
should be quite stable
How about just copying the
Hi Chenwj,
Thanks for your kindly help. Would you mind give me more help?
Now I have some probem with the exception handle. I found the funciton
do_interrupt in target-arm/helper.c and gen_exception in
target-arm/translate.c seems to handle the exceptions. But I am comfused
with those two
On 03/27/2012 10:03 PM, Jia Liu wrote:
Thanks.
do you mean, I should write like this?
helper.h:
DEF_HELPER_FLAGS_3(addq_ph, 0, i32, env, i32, i32)
dsp_helper.c:
uint32_t helper_addq_ph(CPUMIPSState *env, uint32_t rs, uint32_t rt)
{}
Yes. Although the 0 flags argument probably warrants
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes:
Chris and Richard: Please test this to confirm that it fixes the hang you
reported.
We've been testing this (v1 against qemu-kvm 1.0) today, and it's looking
very good. Thanks!
The lock-ups during boot no longer happen, and if you severely
On 2012-03-27 18:39, Anthony Liguori wrote:
On 03/27/2012 11:22 AM, Jan Kiszka wrote:
On 2012-03-27 17:59, Avi Kivity wrote:
On 03/27/2012 11:55 AM, Jan Kiszka wrote:
On 2012-03-27 10:55, Vasilis Liaskovitis wrote:
Hi,
is live migration between qemu-kvm stable-0.15 and stable-1.0 trees
The kvmvapic was not present in older QEMU versions, thus must be
disabled in compat machines.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/pc_piix.c | 43 +--
1 files changed, 33 insertions(+), 10 deletions(-)
diff --git a/hw/pc_piix.c
On 2012-03-16 14:18, Jan Kiszka wrote:
On 2012-03-16 14:16, Anthony Liguori wrote:
On 03/16/2012 07:25 AM, Jan Kiszka wrote:
Once a chr frontend is able to receive input again, we need to inform
the io-thread about this fact. Otherwise, main_loop_wait may continue to
select without the
This patch replaces the ARM_FEATURE_VFP3 test when reading MVFR registers
with a test for a new feature flag ARM_FEATURE_MVFR, and sets this feature
for all ARMv6K cores (ARM1156 is not a v6K core, yet supports MVFR; qemu
does not support ARM1156 at this time.)
MVFR0 and MVFR1 were introduced in
Now I have some probem with the exception handle. I found the funciton
do_interrupt in target-arm/helper.c and gen_exception in
target-arm/translate.c seems to handle the exceptions. But I am comfused
with those two functions, which function will do the really work about
generating an
piix acpi interface suffers from the following 2 issues:
1.
- delete device a
- quickly add device b in another slot
if we do this before guest reads the down register,
the down event is discarded and device will never
be deleted.
2.
- delete device a
- quickly reset before guest can respond
On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote:
piix acpi interface suffers from the following 2 issues:
1.
- delete device a
- quickly add device b in another slot
if we do this before guest reads the down register,
the down event is discarded and device will never
Am 29.03.2012 14:41, schrieb Andrew Towers:
This patch replaces the ARM_FEATURE_VFP3 test when reading MVFR registers
with a test for a new feature flag ARM_FEATURE_MVFR, and sets this feature
for all ARMv6K cores (ARM1156 is not a v6K core, yet supports MVFR; qemu
does not support ARM1156 at
On Thu, 29 Mar 2012 08:00:15 +0100
Stefan Hajnoczi stefa...@gmail.com wrote:
On Wed, Mar 28, 2012 at 05:50:53PM -0300, Luiz Capitulino wrote:
@@ -268,7 +270,14 @@ static int pci_device_hot_remove(Monitor *mon, const
char *pci_addr)
monitor_printf(mon, slot %d empty\n, slot);
On Thu, 29 Mar 2012 08:08:51 +0100
Stefan Hajnoczi stefa...@gmail.com wrote:
On Wed, Mar 28, 2012 at 05:50:54PM -0300, Luiz Capitulino wrote:
ret = qdev_unplug(dev, local_err);
if (error_is_set(local_err)) {
-qerror_report_err(local_err);
-error_free(local_err);
On 03/27/2012 09:43 PM, Jia Liu wrote:
On Wed, Mar 28, 2012 at 12:11 AM, Richard Henderson r...@twiddle.net wrote:
On 03/27/12 02:24, Jia Liu wrote:
+DEF_HELPER_FLAGS_2(shll_qb, TCG_CALL_CONST | TCG_CALL_PURE, i32, int, i32)
It should be DEF_HELPER_2(shll_qb, i32, int, i32). Is it?
Sorry
On 03/27/2012 09:36 PM, Jia Liu wrote:
This patch should have been split as well, adding translations of the insns
at the same time you add the helpers. That said, the actual code looks ok.
helpers can be grouped by MIPS DSP manual, BUT translations have to
grouped by opcode.
There is
On Thu, Mar 29, 2012 at 03:04:12PM +0200, Gleb Natapov wrote:
On Thu, Mar 29, 2012 at 02:51:44PM +0200, Michael S. Tsirkin wrote:
piix acpi interface suffers from the following 2 issues:
1.
- delete device a
- quickly add device b in another slot
if we do this before guest reads
On Thu, Mar 29, 2012 at 12:30 PM, Chris Webb ch...@arachsys.com wrote:
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes:
Chris and Richard: Please test this to confirm that it fixes the hang you
reported.
We've been testing this (v1 against qemu-kvm 1.0) today, and it's looking
very good.
On Thu, Mar 29, 2012 at 2:17 PM, Luiz Capitulino lcapitul...@redhat.com wrote:
On Thu, 29 Mar 2012 08:08:51 +0100
Stefan Hajnoczi stefa...@gmail.com wrote:
On Wed, Mar 28, 2012 at 05:50:54PM -0300, Luiz Capitulino wrote:
ret = qdev_unplug(dev, local_err);
if
On Thu, Mar 29, 2012 at 2:15 PM, Luiz Capitulino lcapitul...@redhat.com wrote:
On Thu, 29 Mar 2012 08:00:15 +0100
Stefan Hajnoczi stefa...@gmail.com wrote:
On Wed, Mar 28, 2012 at 05:50:53PM -0300, Luiz Capitulino wrote:
@@ -268,7 +270,14 @@ static int pci_device_hot_remove(Monitor *mon,
On 29 March 2012 13:41, Andrew Towers atow...@gmail.com wrote:
This patch replaces the ARM_FEATURE_VFP3 test when reading MVFR registers
with a test for a new feature flag ARM_FEATURE_MVFR, and sets this feature
for all ARMv6K cores (ARM1156 is not a v6K core, yet supports MVFR; qemu
does not
On Thu, 29 Mar 2012, Peter A. G. Crosthwaite wrote:
Device model for Primecell PL330 dma controller.
Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com
---
Signed-off-by: Kirill Batuzov batuz...@ispras.ru
+static int PL330Fifo_get(PL330Fifo *s, uint8_t *buf, int len,
Add config descriptor substruct to USBDescriptor,
use it in the descriptor generator code.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/desc.c | 22 --
hw/usb/desc.h |9 +
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git
This patch adds a new type for the binary representation of usb
descriptors. It is put into use for the descriptor generator code
where the struct replaces the hard-coded offsets.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/desc.c | 37 +++--
Hi,
This patch series reworks the usb descriptor handling in qemu. It adds
a struct for the binary representation of usb descriptors. It is put
into use for both generating usb descriptors (for emulated devices) and
parsing usb descriptors (usb-host driver). Additionally the usb-host
parser
Add endpoint descriptor substruct to USBDescriptor,
use it in the descriptor generator code.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/desc.c | 20 +++-
hw/usb/desc.h |9 +
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/hw/usb/desc.c
It's unused, so no need to QOM'ify it later.
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
---
target-arm/cpu.h|1 -
target-arm/helper.c |5 -
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/target-arm/cpu.h
This patch carries a complete rewrite of the usb descriptor parser.
Changes / improvements:
* We are using the USBDescriptor struct instead of hard-coded offsets
now to access descriptor data.
* (debug) printfs are all gone, tracepoints have been added instead.
* We don't try (and fail) to
On 29 March 2012 15:50, Andreas Färber afaer...@suse.de wrote:
Hello Peter,
Here's an improved mini-conversion. Please apply to target-arm.next tree.
Thanks. Both patches
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
and put into target-arm.next for tomorrow's pullreq.
-- PMM
Add device qualifier substruct to USBDescriptor,
use it in the descriptor generator code.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/desc.c | 23 ---
hw/usb/desc.h | 10 ++
2 files changed, 22 insertions(+), 11 deletions(-)
diff --git
Add interface descriptor substruct to USBDescriptor,
use it in the descriptor generator code.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/desc.c | 20 +++-
hw/usb/desc.h |9 +
2 files changed, 20 insertions(+), 9 deletions(-)
diff --git
On 03/29/2012 01:56 PM, Jan Kiszka wrote:
On 2012-03-27 18:39, Anthony Liguori wrote:
On 03/27/2012 11:22 AM, Jan Kiszka wrote:
On 2012-03-27 17:59, Avi Kivity wrote:
On 03/27/2012 11:55 AM, Jan Kiszka wrote:
On 2012-03-27 10:55, Vasilis Liaskovitis wrote:
Hi,
is live migration
Introduce only one non-abstract type TYPE_ARM_CPU and do not touch
cp15 registers to not interfere with Peter's ongoing remodelling.
Embed CPUARMState as first (additional) field of ARMCPU.
Let CPUClass::reset() call cpu_state_reset() for now.
Signed-off-by: Andreas Färber afaer...@suse.de
---
On 03/29/2012 10:17 AM, Avi Kivity wrote:
On 03/29/2012 01:56 PM, Jan Kiszka wrote:
On 2012-03-27 18:39, Anthony Liguori wrote:
On 03/27/2012 11:22 AM, Jan Kiszka wrote:
On 2012-03-27 17:59, Avi Kivity wrote:
On 03/27/2012 11:55 AM, Jan Kiszka wrote:
On 2012-03-27 10:55, Vasilis Liaskovitis
On 03/27/2012 12:42 PM, Jan Kiszka wrote:
On 2012-03-27 18:49, Anthony Liguori wrote:
On 03/27/2012 11:46 AM, Avi Kivity wrote:
On 03/27/2012 06:39 PM, Anthony Liguori wrote:
So, since we're approaching 1.1, we should really discuss release
criteria for 1.1 with respect to live migration.
On 03/29/2012 05:21 PM, Anthony Liguori wrote:
Option 1: make -M old force an old vmstate to be written out. Sounds
like a generally useful thing.
Option 2: ask those consumers to issue updates that bring their code up
to version 3. Require fully updated qemus on both sides. Easy to
Hello Peter,
Here's an improved mini-conversion. Please apply to target-arm.next tree.
Available at:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu-arm.v7
Regards,
Andreas
Cc: Peter Maydell peter.mayd...@linaro.org
Cc: Paul Brook p...@codesourcery.com
Cc: Andrzej Zaborowski
On Tue, Mar 27, 2012 at 9:59 PM, Artyom Tarasenko atar4q...@gmail.com wrote:
On Tue, Mar 27, 2012 at 7:01 PM, Laurent Desnogues
laurent.desnog...@gmail.com wrote:
On Tue, Mar 27, 2012 at 6:48 PM, Blue Swirl blauwir...@gmail.com wrote:
On Tue, Mar 27, 2012 at 13:40, Laurent Desnogues
On 2012-03-29 17:23, Anthony Liguori wrote:
On 03/27/2012 12:42 PM, Jan Kiszka wrote:
On 2012-03-27 18:49, Anthony Liguori wrote:
On 03/27/2012 11:46 AM, Avi Kivity wrote:
On 03/27/2012 06:39 PM, Anthony Liguori wrote:
So, since we're approaching 1.1, we should really discuss release
On Thu, Mar 15, 2012 at 12:45 PM, Stefan Hajnoczi
stefa...@linux.vnet.ibm.com wrote:
On Thu, Mar 15, 2012 at 08:13:31PM +0800, Dong Xu Wang wrote:
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Discussion can be found at:
http://patchwork.ozlabs.org/patch/128730/
This patch add image
On Thu, Mar 15, 2012 at 12:13 PM, Dong Xu Wang
wdon...@linux.vnet.ibm.com wrote:
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
Discussion can be found at:
http://patchwork.ozlabs.org/patch/128730/
This patch add image fragmentation statistics while using qemu-img check.
Signed-off-by: Dong
Streaming can issue I/O while qcow2_close is running. This causes the
L2 caches to become very confused or, alternatively, could cause a
segfault when the streaming coroutine is reentered after closing its
block device. The fix is to cancel streaming jobs when closing their
underlying device.
Stefan Hajnoczi stefa...@gmail.com writes:
Thanks for trying it out.
Regarding the guest kernel errors, they may be timeouts. The guest
may consider the IDE controller buggy/dead due to how long requests
take to complete under severe throttling. There's not much that can
be done about
On 03/29/2012 11:42 AM, Laurent Desnogues wrote:
That will indeed probably make the real problem, which is that
this patch increases the size of generated code, less obvious
on small benchmarks that don't put pressure on instruction
cache. But the fact is that generated code is larger and
On Thu, 2012-03-29 at 14:51 +0200, Michael S. Tsirkin wrote:
piix acpi interface suffers from the following 2 issues:
1.
- delete device a
- quickly add device b in another slot
if we do this before guest reads the down register,
the down event is discarded and device will never
be
V2:
o change qdev_unplug() to return void (this allows some simplifications)
o rename pci_device_hot_remove() 'errp' var to 'local_err'
o minor changelog fixes
hmp-commands.hx |3 +--
hmp.c|9 +
hmp.h|1 +
hw/pci-hotplug.c | 14
It currently uses qerror_report(), but next commit will convert
the drive_del command to the QAPI and this requires using
error_set().
One particularity of qerror_report() is that it knows when it's
running on monitor context or command-line context and prints the
error message accordingly.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hmp-commands.hx |3 +--
hmp.c |9 +
hmp.h |1 +
hw/qdev-monitor.c | 18 +-
qapi-schema.json | 20
Instead of setting values in a CPUID switch, do so in initfn functions.
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-unicore32/cpu.c| 14 ++
target-unicore32/helper.c | 23 ---
2 files changed, 14 insertions(+), 23 deletions(-)
diff --git
This is to limit relicensing obstacles to the pending IBM investigation.
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-unicore32/helper.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/target-unicore32/helper.c b/target-unicore32/helper.c
index
Hello Xuetao,
This updated series converts the UniCore32 CPU to QOM. In addition to
addressing review comments from v1, a new approach for CPU-dependent
values has been adopted: We should keep setting of features imperative
and can avoid adding new class fields as storage for default values
by
Embed CPUUniCore32State as first member of UniCore32CPU.
Contributed under GPLv2+.
Signed-off-by: Andreas Färber afaer...@suse.de
---
Makefile.target|1 +
target-unicore32/cpu-qom.h | 59 +
target-unicore32/cpu.c | 90
Adopt the license text suggested by Guan Xue-tao (with a minor
simplification) for all target-unicore/ files except helper.c.
To helper.c Anthony Liguori contributed a qemu_malloc() - g_malloc()
conversion, still pending IBM relicensing approval, so that remains
GPLv2 for now.
By relicensing all
This is an RFC because it's not 100% finished yet and I'm not sure if some
of the changes are the way to go.
Here's a summary of the series its issues, more details can be found in
the patches:
o Patches 1 to 11 convert several qemu-option and qemu-config functions
from qerror_report() to
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(),
but their callers expect QError semantics. Thus, both functions call
qerro_report_err() to keep the expected semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 54
Note that qemu_find_opts() callers still expect automatic error reporting
with QError, so qemu_find_opts() calls qerror_report_err() to keep the
same semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-config.c | 32 +---
1 file changed, 25
On 2012-03-05 15:09, Jan Kiszka wrote:
Now that we have a hard dependency on python anyway, we can replace the
slow shell script to calculate the option ROM checksum with a fast AND
portable python version. Tested both with python 2.7 and 3.1.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Note that set_option_parameter() callers still expect automatic error
reporting with QError, so set_option_parameter() calls
qerror_report_err() to keep the same semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 22 +++---
1 file changed, 15
This commit converts qemu_opts_create() from qerror_report() to
error_set().
This means that qemu_opts_create() now takes an Error argument and
callers need to pass it if they're interested in getting error
information.
Currently, most calls to qemu_opts_create() can't fail, so most
callers
On 03/29/2012 10:56 AM, Luiz Capitulino wrote:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hmp-commands.hx |3 +--
hmp.c |9 +
hmp.h |1 +
hw/qdev-monitor.c | 18
The functions qemu_opt_set() and opts_do_parse() both call opt_set(),
but their callers expect QError semantics. Thus, both functions call
qerro_report_err() to keep the expected semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 38
On Tue, Mar 27, 2012 at 09:49:12PM +0200, Lluís Vilanova wrote:
A full rewrite of the tracetool script using per-format and per-backend
modules,
so that it's easier to read and extend it in the future.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
NOTE: This series applies in
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index a8b50af..61354af 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -203,7 +203,8 @@ static void
This is like qemu_opt_set(), except that it takes an Error argument.
This new function allows for a incremental conversion of code using
qemu_opt_set().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c |6 ++
qemu-option.h |2 ++
2 files changed, 8
The functions qemu_opts_do_parse() and opts_parse() both call
opts_do_parse(), but their callers expect QError semantics. Thus,
both functions call qerro_report_err() to keep the expected semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 38
This allows for QAPI functions to receive a variable-length argument
list. This is going to be used by device_add and netdev_add commands.
In the schema, the argument list is represented by type name '**',
like this example:
{ 'command': 'foo', 'data': { 'arg-list': '**' } }
Each argument
This is like qemu_find_opts(), except that it takes an Error argument.
This new function allows for a incremental conversion of code using
qemu_find_opts().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-config.c |5 +
qemu-config.h |3 +++
2 files changed, 8
FIXME: HMP's help text (device_add ?) is not implemented. We need a way to
export this information in QMP.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hmp-commands.hx |3 +--
hmp.c | 24 ++
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+)
diff --git a/qerror.c b/qerror.c
index 41c729a..02e3a14 100644
--- a/qerror.c
+++ b/qerror.c
@@ -156,6 +156,10 @@ static const QErrorStringTable qerror_table[] =
Signed-off-by: Andreas Färber afaer...@suse.de
Acked-by: Guan Xuetao g...@mprc.pku.edu.cn
---
MAINTAINERS |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f83d07c2..922945c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -112,6 +112,11 @@
On 03/29/2012 12:26 PM, Luiz Capitulino wrote:
This allows for QAPI functions to receive a variable-length argument
list. This is going to be used by device_add and netdev_add commands.
In the schema, the argument list is represented by type name '**',
like this example:
{ 'command':
Note that qemu_opt_parse() callers still expect automatic error reporting
with QError, so qemu_opts_parse() calls qerror_report_err() to keep the
same semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 26 +++---
1 file changed, 19
On 2012-03-29 20:02, Stefan Weil wrote:
Am 28.03.2012 20:56, schrieb Jan Kiszka:
Avoids lots of warnings.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
qemu_socket.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/qemu_socket.h b/qemu_socket.h
index
On Thu, 29 Mar 2012 13:26:34 -0500
Anthony Liguori aligu...@us.ibm.com wrote:
On 03/29/2012 12:26 PM, Luiz Capitulino wrote:
This allows for QAPI functions to receive a variable-length argument
list. This is going to be used by device_add and netdev_add commands.
In the schema, the
On Wed, Mar 28, 2012 at 00:32, Richard Henderson r...@twiddle.net wrote:
Current code doesn't actually work in 32-bit mode at all. Since
no one really noticed, drop the complication of v7 and v8 cpus.
Eliminate the --sparc_cpu configure option and standardize macro
testing on
On Wed, Mar 28, 2012 at 00:32, Richard Henderson r...@twiddle.net wrote:
Given that we have an opcode for all sizes, all endianness,
turn the functions into a simple table lookup.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/sparc/tcg-target.c | 384
On 03/29/2012 02:45 PM, Blue Swirl wrote:
#elif defined(TARGET_SPARC)
print_insn = print_insn_sparc;
-#ifdef TARGET_SPARC64
disasm_info.mach = bfd_mach_sparc_v9b;
-#endif
This is not OK, it would change ASI printout for V8 guest code.
Ah, right. Ok, will fix for the next
On 03/29/2012 01:42 PM, Luiz Capitulino wrote:
On Thu, 29 Mar 2012 13:26:34 -0500
Anthony Liguorialigu...@us.ibm.com wrote:
On 03/29/2012 12:26 PM, Luiz Capitulino wrote:
This allows for QAPI functions to receive a variable-length argument
list. This is going to be used by device_add and
On Wed, Mar 28, 2012 at 00:32, Richard Henderson r...@twiddle.net wrote:
And change from %i4/%i5 to %g1/%o7 to remove a v8plus fixme.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/sparc/tcg-target.c | 114 ---
1 files changed, 58
1 - 100 of 138 matches
Mail list logo