Re: [Qemu-devel] RFC: delete darwin-user ?

2012-04-13 Thread Alexander Graf
On 13.04.2012, at 02:01, Andreas Färber wrote: Am 13.04.2012 01:57, schrieb Peter Maydell: So, the darwin-user/ subdirectory is officially Orphan, and looking at the git history the last commit to it which wasn't either apply a global change, fix cppcheck/spelling error/similar autodetected

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 12/04/2012 23:08, Andreas Färber ha scritto: Reality with SysBus is multi-stage constructors: A = qdev_create() A.a = x qdev_init_nofail(A) - A_initfn() - B = qdev_create() B.b = y qdev_init_nofail(B) - B_initfn()

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 03:55, Zhi Yong Wu ha scritto: On Thu, Apr 12, 2012 at 8:00 PM, Paolo Bonzini pbonz...@redhat.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com [ Iterate until all block devices have processed all requests, add comments.

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 08:17, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/04/2012 23:08, Andreas Färber ha scritto: If you look at the initialization of a typical qdev object, it goes like this:    dev = qdev_create(NULL, mv88w8618_eth);    qdev_set_nic_properties(dev, nd_table[0]);    

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Zhi Yong Wu
On Fri, Apr 13, 2012 at 3:18 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 03:55, Zhi Yong Wu ha scritto: On Thu, Apr 12, 2012 at 8:00 PM, Paolo Bonzini pbonz...@redhat.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com [

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 09:30, Peter Maydell ha scritto: ...but it's not uncommon for the number of memory regions or IRQs to depend on some qdev property, so you can't put these calls in instance_init, that would be too early. Do you have examples? The only example I can find in the tree from a quick

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 08:59, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 09:30, Peter Maydell ha scritto: ...but it's not uncommon for the number of memory regions or IRQs to depend on some qdev property, so you can't put these calls in instance_init, that would be too early. Do you

Re: [Qemu-devel] [PATCH 01/19] Specification for qcow2 version 3

2012-04-13 Thread Kevin Wolf
Am 12.04.2012 23:14, schrieb Anthony Liguori: On 04/12/2012 10:01 AM, Kevin Wolf wrote: This updates the qcow2 specification to cover version 3. It contains the following changes: - Added compatible/incompatible/auto-clear feature bits plus an optional feature name table to allow useful

Re: [Qemu-devel] [PATCH v8 0/8] Rewrite tracetool using python modules

2012-04-13 Thread Stefan Hajnoczi
On Tue, Apr 03, 2012 at 08:47:33PM +0200, Lluís Vilanova wrote: A full rewrite of the tracetool script using per-format and per-backend modules, so that it's easier to read and extend it in the future. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- NOTE: This series applies in

Re: [Qemu-devel] [PATCH] coroutine-gthread.c: Avoid threading APIs deprecated in GLib 2.31

2012-04-13 Thread Stefan Hajnoczi
On Thu, Apr 12, 2012 at 12:13:12PM +0100, Peter Maydell wrote: Ping^3 ? Waiting on a qemu.git committer, Andreas Faerber and I have reviewed this. Stefan

Re: [Qemu-devel] [PATCH v2] qemu-img: let 'qemu-img convert' flush data

2012-04-13 Thread Kevin Wolf
Am 13.04.2012 04:18, schrieb Liu Yuan: On 04/11/2012 11:21 PM, Liu Yuan wrote: On 04/11/2012 11:01 PM, Paolo Bonzini wrote: bdrv_delete already does this. Paolo Ah yes. Thanks pointing out. Hi Kevin, If no further comment, would you pick up following patch? Can you resend as

[Qemu-devel] Help with entry memory area

2012-04-13 Thread João Corrêa
Hi Guys, I'm trying to understand better intermediate code generation with qemu and I'm having some problems. I've seen that qemu have some different memory areas, such as code, start_brk, end_code... One of these areas is 'entry'. What exactly this area keeps? I've been able to see, through '-d

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 10:12, Peter Maydell ha scritto: Half a dozen from random grep: xilinx,timer -- memory region size depends on a property lan9118 -- which MemoryRegionOps we use for the region depends on the mode_16bit property. You can set these at realize time, before the memory region

Re: [Qemu-devel] [PATCH v2] bsd-user: fix compile failure

2012-04-13 Thread Stefan Hajnoczi
On Thu, Apr 12, 2012 at 12:43:41PM +0100, Peter Maydell wrote: bsd-user doesn't actually support reserving a memory area for the guest address space, but we need to at least define the reserved_va global so that cpu-all.h's RESERVED_VA macro will work correctly. This fixes a compilation

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Insist on a Python 2, not Python 3

2012-04-13 Thread Stefan Hajnoczi
On Thu, Apr 12, 2012 at 07:09:52PM +0100, Peter Maydell wrote: Our Python scripts require Python 2 and will fail on Python 3, eg: File /home/petmay01/linaro/qemu-from-laptop/qemu/scripts/qapi-commands.py, line 378 except getopt.GetoptError, err: ^

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 09:33, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 10:12, Peter Maydell ha scritto: Half a dozen from random grep: xilinx,timer -- memory region size depends on a property lan9118 -- which MemoryRegionOps we use for the region depends   on the mode_16bit property.

[Qemu-devel] [PATCH v3] qemu-img: let 'qemu-img convert' flush data

2012-04-13 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 2) is needed because some backend storage doesn't have a self-flush

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 11:09, Peter Maydell ha scritto: On 13 April 2012 09:33, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 10:12, Peter Maydell ha scritto: Half a dozen from random grep: xilinx,timer -- memory region size depends on a property lan9118 -- which MemoryRegionOps we use for

[Qemu-devel] [PATCH 4/6] ps2: avoid repeated header file includes

2012-04-13 Thread Stefan Hajnoczi
From: Wanpeng Li l...@linux.vnet.ibm.com Signed-off-by: Wanpeng Li l...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/ps2.h | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/ps2.h b/hw/ps2.h index 32a4231..7c45ce7

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 09:51, Zhi Yong Wu ha scritto: Sorry, i hadn't check the code. thanks for pointing out this. In the past, i tested this patch, and found it will assert about bs-tracked_requests. Do you think that only qemu_aio_wait can make sure that bs-tracked_requests is empty here? FWIW,

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Zhi Yong Wu
On Fri, Apr 13, 2012 at 5:49 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 09:51, Zhi Yong Wu ha scritto: Sorry, i hadn't check the code. thanks for pointing out this. In the past, i tested this patch, and found it will assert about bs-tracked_requests. Do you think that only

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 10:32, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 11:09, Peter Maydell ha scritto: You're right in general that we should be modelling these as container objects (I posted a series the other week that starts to move in that direction by dropping the weird

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Zhi Yong Wu
On Fri, Apr 13, 2012 at 5:49 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 09:51, Zhi Yong Wu ha scritto: Sorry, i hadn't check the code. thanks for pointing out this. In the past, i tested this patch, and found it will assert about bs-tracked_requests. Do you think that only

[Qemu-devel] [PULL 0/6] Trivial patches for 4 to 13 April 2012

2012-04-13 Thread Stefan Hajnoczi
The following changes since commit dadc1064c348545695b8a14d9dc72ccaa2983be7: target-microblaze: added PetaLogix copyright (2012-04-12 09:56:51 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 11:52, Zhi Yong Wu ha scritto: FWIW, live snapshot during guest boot (block_set_io_throttle ide0-hd0 0 50 50 0 50 50) died immediately without the patches. With the patch I could do 20 snapshots before I stopped. Why do you not use qemu_aio_flush before loop

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 11:53, Peter Maydell ha scritto: On 13 April 2012 10:32, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 11:09, Peter Maydell ha scritto: You're right in general that we should be modelling these as container objects (I posted a series the other week that starts to move

[Qemu-devel] [PATCH 3/6] make: Always set LC_ALL=C for makeinfo

2012-04-13 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de Otherwise the generated file qemu-doc.html will contain Anhang instead of Appendix with a German locale (de_DE.UTF-8). Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile |2 +- 1 file

[Qemu-devel] [PATCH] fix block_job_set_speed name in documentation

2012-04-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hmp-commands.hx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index a6f5a84..461fa59 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -92,8 +92,8 @@ ETEXI }, STEXI

[Qemu-devel] [PATCH 6/6] configure: Insist on a Python 2, not Python 3

2012-04-13 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Our Python scripts require Python 2 and will fail on Python 3, eg: File /home/petmay01/linaro/qemu-from-laptop/qemu/scripts/qapi-commands.py, line 378 except getopt.GetoptError, err: ^ SyntaxError: invalid

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 11:00, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 11:53, Peter Maydell ha scritto: On 13 April 2012 10:32, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 11:09, Peter Maydell ha scritto: You're right in general that we should be modelling these as

[Qemu-devel] [PATCH 5/6] bsd-user: fix compile failure

2012-04-13 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org bsd-user doesn't actually support reserving a memory area for the guest address space, but we need to at least define the reserved_va global so that cpu-all.h's RESERVED_VA macro will work correctly. This fixes a compilation error introduced in commit

[Qemu-devel] [PATCH 2/6] configure: Fix wrong preprocessor statement

2012-04-13 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de #abort is not a preprocessor statement. It aborts, but the preprocessor statement #error is more common to abort a compilation. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- configure |2 +- 1

[Qemu-devel] [PATCH 1/6] configure: Remove useless uses of ARCH_CFLAGS

2012-04-13 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Remove some useless uses of ARCH_CFLAGS -- this variable was never set so will always be empty. The uses were accidental: in commit 0c439cbf8 Juan Quintela removed ARCH_CFLAGS in favour of CFLAGS (which in turn became QEMU_CFLAGS). However in commit

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 12:09, Peter Maydell ha scritto: The GIC can have a (strongly-typed) backlink to the SoC, and can call object_property_get on it. The trouble with this is that the GIC is embedded into about half a dozen different parent devices, all of which obviously have different types.

Re: [Qemu-devel] [PATCH 01/19] Specification for qcow2 version 3

2012-04-13 Thread Stefan Hajnoczi
On Thu, Apr 12, 2012 at 4:01 PM, Kevin Wolf kw...@redhat.com wrote: +         96 -  99:  refcount_bits +                    Size of a reference count block entry in bits. For version 2 +                    images, the size is always assumed to be 16 bits. The size +                    must

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Peter Maydell
On 13 April 2012 11:24, Paolo Bonzini pbonz...@redhat.com wrote: The PC has a similar model but it is implemented with N+1 devices, one APIC per CPU plus the IO-APIC. For the ARM, it seems cleaner to me to also split it into a per-CPU object (gic_cpu_ops) and a connection object (gic_dist_ops

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 12:43, Peter Maydell ha scritto: On 13 April 2012 11:24, Paolo Bonzini pbonz...@redhat.com wrote: The PC has a similar model but it is implemented with N+1 devices, one APIC per CPU plus the IO-APIC. For the ARM, it seems cleaner to me to also split it into a per-CPU object

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-13 Thread Pavel Dovgaluk
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Thursday, April 12, 2012 8:57 PM To: Stefan Weil Cc: Kevin Wolf; 'qemu-devel'; Pavel Dovgaluk Subject: Re: [Qemu-devel] Fiber switching and stack protection Il 12/04/2012 18:31, Stefan Weil ha scritto: Am

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-13 Thread Andreas Färber
Am 12.04.2012 19:24, schrieb Scott Wood: On 04/12/2012 11:59 AM, Andreas Färber wrote: Am 10.04.2012 22:04, schrieb Meador Inge: commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache line size initialization inside of a '#if !defined(CONFIG_USER_ONLY)' block. This is

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Init dcache and icache size for e500 user mode

2012-04-13 Thread Meador Inge
On 04/13/2012 06:40 AM, Andreas Färber wrote: Am 12.04.2012 19:24, schrieb Scott Wood: On 04/12/2012 11:59 AM, Andreas Färber wrote: Am 10.04.2012 22:04, schrieb Meador Inge: commit f7aa558396dd0f6b7a2b22c05cb503c655854102 pulled the dcache and icache line size initialization inside of a

Re: [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-13 Thread Peter Maydell
On 4 April 2012 16:30, Peter Maydell peter.mayd...@linaro.org wrote: +static Property arm_gic_properties[] = { +    DEFINE_PROP_UINT32(num-cpu, gic_state, num_cpu, 1), +    DEFINE_PROP_UINT32(num-irq, gic_state, num_irq, 32), +}; Missing DEFINE_PROP_END_OF_LIST(). (This happens to only crash

Re: [Qemu-devel] [PATCH 06/19] qcow2: Ignore reserved bits in L1/L2 entries

2012-04-13 Thread Stefan Hajnoczi
On Thu, Apr 12, 2012 at 4:01 PM, Kevin Wolf kw...@redhat.com wrote: This changes the still existing places that assume that the only flags are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out reserved bits. It does not convert bdrv_check yet. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 14:42, Takayuki Konishi ha scritto: -if (!max_cpus) +if (qemu_opts_foreach(qemu_find_opts(smp), smp_init_func, NULL, 1) != 0) { +exit(1); +} +if (!max_cpus) { max_cpus = smp_cpus; - +} Isn't this 'if' block redundant?

Re: [Qemu-devel] RFC: delete darwin-user ?

2012-04-13 Thread Anthony Liguori
On 04/12/2012 06:57 PM, Peter Maydell wrote: So, the darwin-user/ subdirectory is officially Orphan, and looking at the git history the last commit to it which wasn't either apply a global change, fix cppcheck/spelling error/similar autodetected nit or duplicate a linux-user fix into darwin-user

[Qemu-devel] [PATCH 15/16] hw/arm_gic: gic_set_pending_private() is NVIC only

2012-04-13 Thread Peter Maydell
The function gic_set_pending_private() is now used by the NVIC only (for the GIC we now set PPI interrupts via gpio lines and gic_set_irq()). So make it #ifdef NVIC and remove the 'attribute unused' annotation. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm_gic.c |5 +++--

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Anthony Liguori
On 04/13/2012 04:09 AM, Peter Maydell wrote: On 13 April 2012 09:33, Paolo Bonzinipbonz...@redhat.com wrote: Il 13/04/2012 10:12, Peter Maydell ha scritto: Half a dozen from random grep: xilinx,timer -- memory region size depends on a property lan9118 -- which MemoryRegionOps we use for the

[Qemu-devel] [PATCH 13/16] hw/arm_gic: Make gic_reset a sysbus reset function

2012-04-13 Thread Peter Maydell
Make gic_reset a sysbus reset function, so we actually reset the GIC on system reset rather than only at init. For the NVIC this requires us also to implement reset of the SysTick. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm_gic.c |5 +++-- hw/armv7m_nvic.c | 16

[Qemu-devel] [PULL 00/16] arm-devs queue

2012-04-13 Thread Peter Maydell
This is a pullreq for the arm-devs queue. A couple of Exynos fixes, plus my make the GIC a sysbus device series. NOTE: I have sneaked in a one line fix to hw/arm_gic: Make the GIC its own sysbus device -- adding the missing DEFINE_PROP_END_OF_LIST() to the arm_gic_properties[] array. It didn't

[Qemu-devel] [PATCH 01/16] Fix bit test in Exynos4210 UART emulation to use instead of

2012-04-13 Thread Peter Maydell
From: Daniel P. Berrange berra...@redhat.com * hw/exynos4210_uart.c: s/// Signed-off-by: Daniel P. Berrange berra...@redhat.com Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/exynos4210_uart.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 14/16] hw/arm_gic: Use NVIC instead of LEGACY_INCLUDED_GIC define

2012-04-13 Thread Peter Maydell
Now all the A profile cores have been switched to use the standalone sysbus GIC, the only remaining code which #includes arm_gic.c is the v7M NVIC. The coupling is much closer here so it's not so easily disentangled. For now, add a comment about how arm_gic.c is compiled, and assume that the NVIC

[Qemu-devel] [PATCH 16/16] hw/arm_gic: Remove stray hardcoded tab

2012-04-13 Thread Peter Maydell
Remove the single instance of a hardcoded tab from hw/arm_gic.c. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm_gic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index ba6117a..72298b4 100644 --- a/hw/arm_gic.c +++

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Andreas Färber
Am 13.04.2012 09:17, schrieb Paolo Bonzini: initfn is unable to handle errors btw, which is another reason to do object creations in a second-stage constructor. What error handling do you need specifically? You could add an Error ** argument to object_{new,initialize{,_with_type} too as

[Qemu-devel] [PATCH 02/16] ARM: Exynos4210: Drop gic_cpu_write() after initialization.

2012-04-13 Thread Peter Maydell
From: Evgeny Voevodin e.voevo...@samsung.com Remove gic_cpu_write() call after initialization that was emulating functionality of earliest SOC bootloader which enables external GIC CPU1 interface. Instead introduce Exynos4210-specific secondary CPU bootloader, which enables both Internal and

Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-04-13 Thread Takayuki Konishi
On Tue, Mar 20, 2012 at 09:01:34AM +0100, Paolo Bonzini wrote: This introduces a new option group, but it is mostly trivial. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c | 31 + vl.c | 61

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Anthony Liguori
On 04/13/2012 08:36 AM, Andreas Färber wrote: Am 13.04.2012 09:17, schrieb Paolo Bonzini: initfn is unable to handle errors btw, which is another reason to do object creations in a second-stage constructor. What error handling do you need specifically? You could add an Error ** argument to

[Qemu-devel] [PATCH 03/16] hw/exynos4210_combiner.c: Drop excessive read/write access check.

2012-04-13 Thread Peter Maydell
From: Evgeny Voevodin e.voevo...@samsung.com Access to reserved area at offset higher than 0x3c is allowed in External Combiner. Samsung Galaxy Kernel implements this. So, drop excessive checks in read/write functions. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com Signed-off-by: Peter

[Qemu-devel] [PATCH 06/16] hw/arm_gic: Expose PPI inputs as gpio inputs

2012-04-13 Thread Peter Maydell
Expose the Private Peripheral Interrupt inputs as GPIO inputs. The layout of the GPIO array is thus: [0..N-1] SPIs [N..N+31] PPIs for CPU 0 [N+32..N+63] PPIs for CPU 1 ... Treating PPIs as being another kind of input line is in line with the GIC architecture specification, where they are

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Andreas Färber
Am 13.04.2012 16:00, schrieb Anthony Liguori: On 04/13/2012 08:36 AM, Andreas Färber wrote: Am 13.04.2012 09:17, schrieb Paolo Bonzini: initfn is unable to handle errors btw, which is another reason to do object creations in a second-stage constructor. What error handling do you need

[Qemu-devel] [PATCH 11/16] hw/exynos4210_gic: Convert to using sysbus GIC

2012-04-13 Thread Peter Maydell
Convert the Exynos GIC code to use the standalone sysbus GIC device. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Evgeny Voevodin e.voevo...@samsung.com --- hw/exynos4210_gic.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 10/16] hw/realview_gic: switch to sysbus GIC

2012-04-13 Thread Peter Maydell
Switch the realview_gic device to the standalone sysbus GIC. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/realview_gic.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/realview_gic.c b/hw/realview_gic.c index

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 16:06, Andreas Färber ha scritto: I'm still talking about the (pretty clear to me) graph that I posted. There, object A's init function creates a new qdev object - . Creating an object can fail - fatally or non-fatally. And yes, exactly my point, currently initfn (first stage)

[Qemu-devel] [PATCH 08/16] hw/a15mpcore: switch to using sysbus GIC

2012-04-13 Thread Peter Maydell
Switch the a15mpcore private peripheral region to using the standalone sysbus GIC device. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/a15mpcore.c | 35 ++- 1 files changed, 26 insertions(+), 9 deletions(-) diff --git a/hw/a15mpcore.c

[Qemu-devel] [PATCH] gitignore: ignore qtest binaries

2012-04-13 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9859c7d..db74219 100644 --- a/.gitignore +++ b/.gitignore @@ -89,3 +89,4 @@ cscope.* tags TAGS *~ +tests/*-test -- 1.7.9.5

[Qemu-devel] [PATCH 04/16] hw/arm_gic: Move NCPU definition to arm_gic.c

2012-04-13 Thread Peter Maydell
Move the NCPU definition to arm_gic.c: the maximum number of CPU interfaces is defined by the GIC architecture specification to be 8, so we don't need to have this #define in each of the sources files which currently includes arm_gic.c. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Andreas Färber
Am 13.04.2012 16:08, schrieb Paolo Bonzini: Il 13/04/2012 16:06, Andreas Färber ha scritto: I'm still talking about the (pretty clear to me) graph that I posted. There, object A's init function creates a new qdev object - . Creating an object can fail - fatally or non-fatally. And yes,

[Qemu-devel] [PATCH 07/16] hw/arm_gic: Make the GIC its own sysbus device

2012-04-13 Thread Peter Maydell
Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by:

[Qemu-devel] [PATCH 09/16] hw/a9mpcore: Switch to using sysbus GIC

2012-04-13 Thread Peter Maydell
Switch the a9mpcore to using the sysbus GIC device rather than having the a9mp private memory region device subclass the GIC. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/a9mpcore.c | 60 +--- 1 files changed, 35

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 16:21, Andreas Färber ha scritto: Am 13.04.2012 16:08, schrieb Paolo Bonzini: Il 13/04/2012 16:06, Andreas Färber ha scritto: I'm still talking about the (pretty clear to me) graph that I posted. There, object A's init function creates a new qdev object - . Creating an object

[Qemu-devel] [RFC PATCH 1/3] tests: add libpci qtest library

2012-04-13 Thread Stefan Hajnoczi
This patch adds a common PCI bus driver library which works for i386/x86-64 targets. Tests can use the library to probe for PCI devices, map BARs, and access configuration space. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- tests/libpci.c | 106

[Qemu-devel] [RFC PATCH 0/3] qtest: libpci and virtio demo testcase

2012-04-13 Thread Stefan Hajnoczi
This RFC series shows how I'm using qtest to implement virtio device test cases. The main pieces are: 1. libpci is a thin PCI device wrapper that makes it possible to access configuration space and map BARs. There is stuff missing, I have not dealt with MMIO or interrupts yet. But this

[Qemu-devel] [RFC PATCH 2/3] virtio: move virtio spec constants to separate headers

2012-04-13 Thread Stefan Hajnoczi
Tests that exercise virtio devices require the same constants we use to implement virtio device emulation. Move these constants into their own header files, thus allowing them to be used by test programs. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p-device.c

[Qemu-devel] [RFC PATCH 3/3] qtest: add virtio-test test-case

2012-04-13 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- tests/Makefile |3 +- tests/virtio-test.c | 88 +++ 2 files changed, 90 insertions(+), 1 deletion(-) create mode 100644 tests/virtio-test.c diff --git a/tests/Makefile

[Qemu-devel] [PATCH 05/16] hw/arm_gic: Move gic_get_current_cpu into arm_gic.c

2012-04-13 Thread Peter Maydell
Move the gic_get_current_cpu() function into arm_gic.c. There are only two implementations: (1) get the index of the currently executing CPU, used by all multicore GICs, and (2) always 0, used by all GICs instantiated with a single CPU interface (the Realview board GIC and the v7M NVIC). So we can

Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests

2012-04-13 Thread Zhi Yong Wu
On Fri, Apr 13, 2012 at 5:59 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/04/2012 11:52, Zhi Yong Wu ha scritto: FWIW, live snapshot during guest boot (block_set_io_throttle ide0-hd0 0 50 50 0 50 50) died immediately without the patches. With the patch I could do 20

[Qemu-devel] [PATCH 12/16] hw/arm11mpcore: Convert to using sysbus GIC device

2012-04-13 Thread Peter Maydell
Convert arm11mpcore to using the standalone sysbus GIC device. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/arm11mpcore.c | 49 ++--- 1 files changed, 30 insertions(+), 19 deletions(-) diff --git a/hw/arm11mpcore.c b/hw/arm11mpcore.c

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Andreas Färber
Am 13.04.2012 16:25, schrieb Paolo Bonzini: Il 13/04/2012 16:21, Andreas Färber ha scritto: Am 13.04.2012 16:08, schrieb Paolo Bonzini: Il 13/04/2012 16:06, Andreas Färber ha scritto: I'm still talking about the (pretty clear to me) graph that I posted. There, object A's init function creates

Re: [Qemu-devel] Fiber switching and stack protection

2012-04-13 Thread Bob Breuer
On 4/13/2012 6:25 AM, Pavel Dovgaluk wrote: -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Thursday, April 12, 2012 8:57 PM To: Stefan Weil Cc: Kevin Wolf; 'qemu-devel'; Pavel Dovgaluk Subject: Re: [Qemu-devel] Fiber switching and stack protection Il

[Qemu-devel] [PATCH] qapi: g_hash_table_find() instead of GHashTableIter.

2012-04-13 Thread NODA, Kai
From: NODA, Kai noda...@gmail.com GHashTableIter was first introduced in glib 2.16. This patch removes it in favor of older g_hash_table_find() for better compatibility with RHEL5. --- qapi/qmp-input-visitor.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Anthony Liguori
On 04/13/2012 09:06 AM, Andreas Färber wrote: Am 13.04.2012 16:00, schrieb Anthony Liguori: On 04/13/2012 08:36 AM, Andreas Färber wrote: Am 13.04.2012 09:17, schrieb Paolo Bonzini: initfn is unable to handle errors btw, which is another reason to do object creations in a second-stage

Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

2012-04-13 Thread Anthony Liguori
On 04/13/2012 09:21 AM, Andreas Färber wrote: Am 13.04.2012 16:08, schrieb Paolo Bonzini: Il 13/04/2012 16:06, Andreas Färber ha scritto: I'm still talking about the (pretty clear to me) graph that I posted. There, object A's init function creates a new qdev object - . Creating an object can

[Qemu-devel] [Bug 935945] Re: SLIRP still not working for win32

2012-04-13 Thread Kenneth Salerno
SLIRP is now currently WORKING for win32 in qemu.org git master as of Apr 13 2012 10:20 Eastern. The last time I checked unsuccessfully with things still broken was earlier in the week, probably April 9th, I don't remember exactly, but the fix was definitely committed this week. Thanks!!! --

Re: [Qemu-devel] [PULL] QOM CPUState for lm32

2012-04-13 Thread Anthony Liguori
On 04/11/2012 06:19 PM, Andreas Färber wrote: Hello Anthony, Blue or Edgar, Please pull the lm32 QOM CPU conversion. Cc: Anthony Liguorianth...@codemonkey.ws Cc: Blue Swirlblauwir...@gmail.com Cc: Edgar E. Iglesiasedgar.igles...@gmail.com Cc: Michael Wallemich...@walle.cc Pulled. Thanks.

Re: [Qemu-devel] [PULL 0/6] Trivial patches for 4 to 13 April 2012

2012-04-13 Thread Anthony Liguori
On 04/13/2012 04:39 AM, Stefan Hajnoczi wrote: The following changes since commit dadc1064c348545695b8a14d9dc72ccaa2983be7: target-microblaze: added PetaLogix copyright (2012-04-12 09:56:51 +0200) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2012-04-13 Thread Anthony Liguori
On 04/12/2012 08:32 PM, Marcelo Tosatti wrote: The following changes since commit dadc1064c348545695b8a14d9dc72ccaa2983be7: target-microblaze: added PetaLogix copyright (2012-04-12 09:56:51 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git

[Qemu-devel] [RFC PATCH 0/8] job-based mirroring implementation

2012-04-13 Thread Paolo Bonzini
Hi all, this is an alternative implementation of mirroring using a block job. In the end this is the same as Marcelo's original live block copy code, only done on top of the job infrastructure and coroutines. Here, the drive-mirror command sets up a job that copies data using the existing

[Qemu-devel] [PATCH 2/8] block: allow interrupting a co_sleep_ns

2012-04-13 Thread Paolo Bonzini
In the next patch we want to reenter the coroutine from block_job_cancel_sync and cancel the timer. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-coroutine-sleep.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-coroutine-sleep.c b/qemu-coroutine-sleep.c

[Qemu-devel] [PATCH 8/8] docs: add mirroring to live block operations

2012-04-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/live-block-ops.txt | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt index a257087..caf3466 100644 --- a/docs/live-block-ops.txt

[Qemu-devel] [PATCH 3/8] block: allow doing I/O in a job after cancellation

2012-04-13 Thread Paolo Bonzini
Track the coroutine that executes the job, so that the wait can be cancelled before block_job_cancel restarts. This also gives to the coroutine an opportunity to flip job-busy to true, and submit new I/O before exiting. block_job_cancel_sync will wait for job-busy to become false again. Also

[Qemu-devel] [PATCH 4/8] block: add mirror job

2012-04-13 Thread Paolo Bonzini
This patch adds the implementation of a new job that mirrors a disk to a new image while letting the guest continue using the old image. The target is treated as a black box and data is copied from the source to the target in the background. The mirror job is never-ending, but it is logically

[Qemu-devel] [PATCH 5/8] block: add drive-mirror command

2012-04-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- blockdev.c | 102 -- hmp-commands.hx | 21 +++ hmp.c| 26 ++ hmp.h|1 + qapi-schema.json | 30 qmp-commands.hx |

[Qemu-devel] [Bug 935945] Re: SLIRP still not working for win32

2012-04-13 Thread Paolo Bonzini
Yes, I forgot to update the bug. Thanks for testing! :) ** Changed in: qemu Status: New = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/935945 Title: SLIRP still not working

[Qemu-devel] [Bug 916720] Re: select fails on windows because a non-socket fd is in the rfds set

2012-04-13 Thread Paolo Bonzini
** Changed in: qemu Status: New = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/916720 Title: select fails on windows because a non-socket fd is in the rfds set Status in

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3] PPC: Fix interrupt MSR value for classic exception models.

2012-04-13 Thread Mark Cave-Ayland
On 11/04/12 02:08, David Gibson wrote: Hi David, Commit 41557447d30eeb944e42069513df13585f5e6c7f introduced a new method of calculating the MSR for the interrupt context. However this doesn't quite agree with the PowerISA 2.06B specification (pp. 811-814) since too many bits were being

[Qemu-devel] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-13 Thread Paolo Bonzini
Management needs a way for QEMU to confirm that no I/O has been sent to the target and not to the source. To provide this guarantee we rely on a file in local persistent storage. QEMU receives a file descriptor via SCM_RIGHTS and writes a single byte to it. If it fails, it will fail the

[Qemu-devel] Reminder: Upcoming soft freeze for 1.1

2012-04-13 Thread Anthony Liguori
Hi, Just a friendly reminder that this Sunday (April 15th) is the scheduled soft freeze for 1.1. The full 1.1 release schedule is available at. If you have any questions about the upcoming dates, please don't hesitate to ask. Happy hacking! http://wiki.qemu.org/Planning/1.1 == What is

[Qemu-devel] [PATCH 6/8] block: add the drive-reopen command

2012-04-13 Thread Paolo Bonzini
From: Federico Simoncelli fsimo...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- blockdev.c | 75 ++ hmp-commands.hx | 16 hmp.c| 11

Re: [Qemu-devel] [PATCH 8/8] docs: add mirroring to live block operations

2012-04-13 Thread Eric Blake
On 04/13/2012 10:23 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- docs/live-block-ops.txt | 38 +++--- 1 file changed, 31 insertions(+), 7 deletions(-) +Live block migration + + +Migrating an in

[Qemu-devel] [PATCH 1/8] block: introduce new dirty bitmap functionality

2012-04-13 Thread Paolo Bonzini
Assert that write_compressed is never used with the dirty bitmap. Setting the bits early is wrong, because a coroutine might concurrently examine them and copy incomplete data from the source. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 51

Re: [Qemu-devel] [PATCH 8/8] docs: add mirroring to live block operations

2012-04-13 Thread Paolo Bonzini
Il 13/04/2012 19:09, Eric Blake ha scritto: +It is also possible to use raw as the format of the destination image. +Converting an image to raw will properly support thin provisioning. Do you need to mention the use of block_job_cancel needed at the point where you are ready to stop qemu

[Qemu-devel] [PULL] Xen MSI, mapcache, xen_disk

2012-04-13 Thread Stefano Stabellini
Hi Anthony, please pull the following branch: git://xenbits.xen.org/people/sstabellini/qemu-dm.git for_anthony It includes two mapcache fixes, one xen_disk fix, two patches to allow MSI injection into HVM guests and finally a patch to receive notification from Xen for buffered io events:

  1   2   >