I came here from : http://lists.gnu.org/archive/html/qemu-
devel/2011-07/msg02806.html
Actually, I experience an issue which may be useful to you.
I have a corrupted VHD file (as explained in that thread :
https://forums.virtualbox.org/viewtopic.php?f=7t=20614 ). I wanted to
follow that
I have found several places cmake may hang, with either qemu-arm-static
or mipsel, and in debian (testing) as well as in Ubuntu. One of them is
the cmake check for c++ compiler, which can be overridden. Things that
use cmake's pkg_check_modules and pkg-config files will also hang.
Curiously,
Il 10/05/2012 01:15, Andreas Färber ha scritto:
In particular I needed /machine/cpu[n] to pass the X86CPU to the APIC in
a sensible way - next commit on that branch, currently:
https://github.com/afaerber/qemu-cpu/commit/1134efc143aa1629f8961ef058416e1acfa50f8e
Yay, thanks for doing that!
Il 10/05/2012 03:41, Zhang, Yang Z ha scritto:
2) it doesn't pass tests/rtc-test, but that might even be a problem with
the test; I'll try to look at it.
How to use rtc-test? I cannot manage to run rtc-test. I searched in google
but get nothing.
make check-qtest-i386 V=1 will show how to
Il 09/05/2012 22:01, Igor Mammedov ha scritto:
Hi Paolo,
Are you plannig to respin this and related patches?
If yes, when?
After the first part goes in (21 patches including Anthony's bus
series). A reviewed-by from Andreas or Anthony would help, so that I
can make Andreas's suggested
This is needed in particular on Win32.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Kevin, this fixes the failure to build block branch on mingw.
qemu-common.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/qemu-common.h b/qemu-common.h
index 50f659a..cccfb42 100644
Il 10/05/2012 03:04, q...@buildbot.b1-systems.de ha scritto:
The Buildbot has detected a new failure on builder block_mingw32 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/208
Buildbot URL:
Il 09/05/2012 19:23, Jan Kiszka ha scritto:
Use pthread_kill instead of process-wide kill to invoke the signal
handler used for stack switching. This may fix spurious lock-ups with
this backend, easily triggerable by extending the time window between
kill and sigsuspend.
Signed-off-by: Jan
Am 09.05.2012 19:11, schrieb Andreas Färber:
Am 08.05.2012 17:51, schrieb Kevin Wolf:
Let's start with testing media change.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/Makefile |2 +
tests/fdc-test.c | 186
++
2 files
Il 09/05/2012 18:54, Michael Tokarev ha scritto:
And in case kvm is enabled, and we run on some other CPU
(not intel and not amd), we'll have some other CPU model,
which might exist or might not, which may make some sense
or may not, etc - we simple don't know.
Leaving aside the discussions
Il 09/05/2012 19:11, Andreas Färber ha scritto:
# All QTests for now are POSIX-only, but the dependencies are
# really in libqtest, not in the testcases themselves.
check-qtest-i386-y = tests/rtc-test
+check-qtest-i386-y = tests/fdc-test
$(EXESUF)?
In practice qtests will only run on
Il 08/05/2012 17:51, Kevin Wolf ha scritto:
Kevin Wolf (2):
qtest: Add function to send QMP commands
qtest: Add floppy test
tests/Makefile |2 +
tests/fdc-test.c | 186
++
tests/libqtest.c | 123
Il 09/05/2012 18:10, Michael Tokarev ha scritto:
The old hacks which were prematurely removed from qemu-kvm makes the
life easier for the _user_, which is the main target of the software.
I'd love to stop using them but sometimes it is not possible. With
this extboot thing, qemu-kvm dropped
This is a partial revert of commits a369da5 (vga: improve VGA logic,
committed 2012-01-22) and c5bd4f3 (vga: fix -nodefaults -device VGA,
2012-01-24) which broke command-line option parsing in different ways.
Since commit a369da5 it has become impossible to specify a VGA device
entirely with
On 10.05.2012 11:30, Paolo Bonzini wrote:
Il 09/05/2012 18:54, Michael Tokarev ha scritto:
And in case kvm is enabled, and we run on some other CPU
(not intel and not amd), we'll have some other CPU model,
which might exist or might not, which may make some sense
or may not, etc - we simple
Signed-off-by: Kevin Wolf kw...@redhat.com
---
To be applied on top of the floppy qtest patch.
tests/Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index a7697bd..20e4da9 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@
Il 10/05/2012 09:46, Michael Tokarev ha scritto:
And in case kvm is enabled, and we run on some other CPU
(not intel and not amd), we'll have some other CPU model,
which might exist or might not, which may make some sense
or may not, etc - we simple don't know.
Leaving aside the
Am 10.05.2012 09:29, schrieb Paolo Bonzini:
Il 09/05/2012 19:23, Jan Kiszka ha scritto:
Use pthread_kill instead of process-wide kill to invoke the signal
handler used for stack switching. This may fix spurious lock-ups with
this backend, easily triggerable by extending the time window between
Hi all,
I see only x86 define TARGET_HAS_PRECISE_SMC (target-i386/cpu.h), and the
comment says,
/* support for self modifying code even if the modified instruction is
close to the modifying instruction */
#define TARGET_HAS_PRECISE_SMC
I would like to know what it means and want to know
On 05/10/2012 12:20 AM, Avi Kivity wrote:
On 05/09/2012 07:12 PM, Anthony Liguori wrote:
On 05/09/2012 10:15 AM, Avi Kivity wrote:
Autotest fails for me with this patch. The symptoms are that the guest
fails DHCP on bootup (not all bootups).
Please investigate.
Which guest?
Sorry, forgot
This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is because
the linux 8139cp driver would leave the card in Config Register Write Enable
mode after the eeprom were read or write ( which is unexpected in the spec
). Also a physical 8139 card can still DMA into host memory in modes
Am 10.05.2012 09:27, schrieb Paolo Bonzini:
This is needed in particular on Win32.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Kevin, this fixes the failure to build block branch on mingw.
qemu-common.h |3 +++
1 file changed, 3 insertions(+)
Thanks, applied to the
On Thu, May 10, 2012 at 04:37:22PM +0800, Jason Wang wrote:
This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is because
the linux 8139cp driver would leave the card in Config Register Write Enable
mode after the eeprom were read or write ( which is unexpected in the spec
).
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
These hunks were left out of stream: add testcase for partial
streaming v2 due a bad rebase on my side (I added the os.remove
on top of an old branch rather than the latest). Please squash
them in, sorry for the
Am 10.05.2012 10:59, schrieb Paolo Bonzini:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
These hunks were left out of stream: add testcase for partial
streaming v2 due a bad rebase on my side (I added the os.remove
on top of an old branch rather than the
On 05/10/2012 01:23 AM, Anthony Liguori wrote:
On 04/04/2012 03:41 AM, Avi Kivity wrote:
On 04/04/2012 04:15 AM, David Gibson wrote:
If the kernel page size is larger than TARGET_PAGE_SIZE, which
happens for example on ppc64 with kernels compiled for 64K pages,
the dirty tracking doesn't
On 10 May 2012 09:10, 陳韋任 che...@iis.sinica.edu.tw wrote:
I see only x86 define TARGET_HAS_PRECISE_SMC (target-i386/cpu.h), and the
comment says,
/* support for self modifying code even if the modified instruction is
close to the modifying instruction */
#define TARGET_HAS_PRECISE_SMC
On 05/10/2012 04:54 PM, Michael S. Tsirkin wrote:
On Thu, May 10, 2012 at 04:37:22PM +0800, Jason Wang wrote:
This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is because
the linux 8139cp driver would leave the card in Config Register Write Enable
mode after the eeprom were
On 05/10/2012 01:14 AM, Jan Kiszka wrote:
Use SIGUSR1 unconditionally as SIG_IPI. First, ucontext coroutines tend
to corrupt RT signal masks due to a 32-on-64-bit Linux kernel bug. And,
second, there appears to be no advantage in using RT signals for VCPU
kicking.
Signed-off-by: Jan Kiszka
Am 10.05.2012 02:10, schrieb Andreas Färber:
Andreas Färber (74):
target-arm: Use cpu_reset() in cpu_arm_init()
target-mips: Use cpu_reset() in cpu_mips_init()
target-i386: Pass X86CPU to do_cpu_{init,sipi}()
target-i386: Let cpu_x86_init() return X86CPU
Sorry, apparently I ran into
Am 10.05.2012 08:57, schrieb Paolo Bonzini:
Il 10/05/2012 01:15, Andreas Färber ha scritto:
In particular I needed /machine/cpu[n] to pass the X86CPU to the APIC in
a sensible way - next commit on that branch, currently:
Il 10/05/2012 11:51, Andreas Färber ha scritto:
In particular I needed /machine/cpu[n] to pass the X86CPU to the APIC in
a sensible way - next commit on that branch, currently:
https://github.com/afaerber/qemu-cpu/commit/1134efc143aa1629f8961ef058416e1acfa50f8e
Yay, thanks for doing
Am 10.05.2012 09:05, schrieb Paolo Bonzini:
Il 09/05/2012 22:01, Igor Mammedov ha scritto:
Hi Paolo,
Are you plannig to respin this and related patches?
If yes, when?
After the first part goes in (21 patches including Anthony's bus
series). A reviewed-by from Andreas or Anthony would
Am 09.05.2012 11:23, schrieb Jim Meyering:
[Argh. First attempt omitted the most important address: qemu-devel.
Sorry to all who get two copies. ]
Given qemu's HACKING comments, I'm sure many here have read man strncpy,
where it indicates it is often not the best function to use.
Anthony,
Hi,
anyone can explain what checkpatch tries to tell me here?
ERROR: need consistent spacing around '*' (ctx:WxV)
#11: FILE: hw/usb/hcd-ehci.c:1398:
+static int ehci_execute(EHCIPacket *p)
thanks,
Gerd
On Thu, May 10, 2012 at 2:10 PM, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
anyone can explain what checkpatch tries to tell me here?
ERROR: need consistent spacing around '*' (ctx:WxV)
#11: FILE: hw/usb/hcd-ehci.c:1398:
+static int ehci_execute(EHCIPacket *p)
I guess that it takes
On 2012-05-10 06:27, Avi Kivity wrote:
On 05/10/2012 01:23 AM, Anthony Liguori wrote:
On 04/04/2012 03:41 AM, Avi Kivity wrote:
On 04/04/2012 04:15 AM, David Gibson wrote:
If the kernel page size is larger than TARGET_PAGE_SIZE, which
happens for example on ppc64 with kernels compiled for 64K
On 05/10/2012 01:49 PM, Jan Kiszka wrote:
On 2012-05-10 06:27, Avi Kivity wrote:
On 05/10/2012 01:23 AM, Anthony Liguori wrote:
On 04/04/2012 03:41 AM, Avi Kivity wrote:
On 04/04/2012 04:15 AM, David Gibson wrote:
If the kernel page size is larger than TARGET_PAGE_SIZE, which
happens
Please pull from:
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
to receive a fix for qemu 1.1, fixing dirty tracking with a large host
page size; only applicable to ppc.
David Gibson (1):
kvm: Fix dirty
On Thu, May 10, 2012 at 05:31:56PM +0800, Jason Wang wrote:
On 05/10/2012 04:54 PM, Michael S. Tsirkin wrote:
On Thu, May 10, 2012 at 04:37:22PM +0800, Jason Wang wrote:
This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is
because
the linux 8139cp driver would leave the card
Hi, guys!
While trying to refactor virtio-pci as continuation of my RFC
virtio-mmio patch series:
http://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03665.html
I've faced a problem.
I try to create virtio-pci-transport device to which virtio-blk,net,etc
could be connected. Any board could
This enables support for handling the case where a guest instruction
modifies the memory corresponding to the QEMU TB which it is in.
For most CPU architectures this will (on hardware) give unpredictable
results because of hardware prefetch / pipelining / caching, and so
there's no need for
On 10 May 2012 12:29, 陳韋任 che...@iis.sinica.edu.tw wrote:
From the backtrace I observed, the argument is_cpu_write_access is one only
when guest is doing MMIO (see below).
It's one when the reason we got here is that the guest CPU did a write
instruction...
---
#0
The following changes since commit 1b3e76ebd1e270eae27e502ea8b836c31d95f801:
tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode (2012-05-09 13:59:19 -0500)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Kevin Wolf (3):
qtest: Add function to send QMP commands
From: Zhi Yong Wu wu...@linux.vnet.ibm.com
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
[ Iterate until all block devices have processed all requests,
add comments. - Paolo ]
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 21
From: Paolo Bonzini pbonz...@redhat.com
This is another bug caused by not doing a full cleanup of the BDS
across close/open. This was found with mirroring by Shaolong Hu,
but it can probably be reproduced also with eject or change.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by:
From: Paolo Bonzini pbonz...@redhat.com
We are reusing bs-file across close/open, which may not cause any
known bugs but is a recipe for trouble. Prefer bdrv_delete, and
enjoy the new invariant in the implementation of bdrv_delete.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by:
From: Paolo Bonzini pbonz...@redhat.com
On Windows, all the logic is already in is_windows_drive and
is_windows_drive_prefix. On POSIX, there is no need to look
out for colons.
The win32 code changes the behaviour in some cases, we could have
something like d:foo.img. The old code would treat
From: Paolo Bonzini pbonz...@redhat.com
QED's opaque data includes a pointer back to the BlockDriverState.
This breaks when bdrv_append shuffles data between bs_new and bs_top.
To avoid this, add a rebind function that tells the driver about
the new relationship between the BlockDriverState and
From: Paolo Bonzini pbonz...@redhat.com
path_has_protocol will erroneously return true if the colon is part
of a filename. These names are common with stable device names produced
by udev. We cannot fully protect against this in case the filename
does not have a path component (e.g. if the
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/qemu-iotests/030 | 28 +++-
tests/qemu-iotests/030.out |4 ++--
2 files changed, 29 insertions(+), 3 deletions(-)
diff
From: Paolo Bonzini pbonz...@redhat.com
The test on sectors not allocated can fail if the L1/L2 tables are
not on disk yet. Allow tests to shutdown the VM early.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/qemu-iotests/030|1
From: Paolo Bonzini pbonz...@redhat.com
bdrv_img_create will temporarily open the backing file to probe its size.
However, this could be done with a read-write open if the wrong flags are
passed to bdrv_img_create. Since there is really no documentation on
what flags can be passed, assume that
On 05/10/2012 05:01 AM, Andreas Färber wrote:
Am 10.05.2012 09:05, schrieb Paolo Bonzini:
Il 09/05/2012 22:01, Igor Mammedov ha scritto:
Hi Paolo,
Are you plannig to respin this and related patches?
If yes, when?
After the first part goes in (21 patches including Anthony's bus
series). A
From: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
blockdev.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
On Wed, May 09, 2012 at 08:10:07PM +0400, Michael Tokarev wrote:
On 09.05.2012 12:02, Gleb Natapov wrote:
On Tue, May 08, 2012 at 09:56:10PM +0400, Michael Tokarev wrote:
[]
It's two only:
-drive if=none,id=name,...
-device virtio-blk-pci,drive=name
Ok, at least it is not
From: Paolo Bonzini pbonz...@redhat.com
bdrv_append must also copy open_flags to the top, because the snapshot
has BDRV_O_NO_BACKING set. This causes interesting results if you
later use drive-reopen (not upstream) to reopen the image, and lose
the backing file in the process.
Signed-off-by:
Currently when you mount a filesystem, you face two issues:
- you have to be root
- if the media is untrusted, it can exploit your kernel
With kvm and fuse, we can have a virtualized kernel mount the
filesystem, and re-export to the host, which mounts it using a fuse
interface. This solves both
From: Paolo Bonzini pbonz...@redhat.com
The change of the argument name from value to speed was not propagated there.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hmp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Paolo Bonzini pbonz...@redhat.com
This check applies to all drivers, but QED lacks it.
Reviewed-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c |5 +
block/qcow2.c |5 -
2 files
On 10 May 2012 13:29, Avi Kivity a...@redhat.com wrote:
Currently when you mount a filesystem, you face two issues:
- you have to be root
- if the media is untrusted, it can exploit your kernel
With kvm and fuse, we can have a virtualized kernel mount the
filesystem, and re-export to the
From: Paolo Bonzini pbonz...@redhat.com
When an image is modified to point to the new backing file, the backing
file format is set to NULL, which means auto-probe. This is wrong, in
fact it is a small security problem.
Reviewed-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Paolo Bonzini
On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb Natapov wrote:
On Wed, May 09, 2012 at 11:05:58AM +0200, Alexander Graf wrote:
On 09.05.2012, at 10:51, Gleb Natapov wrote:
On Wed, May 09, 2012 at 10:42:26AM +0200,
From: Paolo Bonzini pbonz...@redhat.com
This is needed in particular on Win32.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-common.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
From: Paolo Bonzini pbonz...@redhat.com
These are needed to print info block output correctly. QCOW2 does this
because it needs it to write the header, but QED does not, and common code
is the right place to do it.
Reviewed-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Paolo Bonzini
On 05/10/2012 03:37 PM, Alex Bradbury wrote:
On 10 May 2012 13:29, Avi Kivity a...@redhat.com wrote:
Currently when you mount a filesystem, you face two issues:
- you have to be root
- if the media is untrusted, it can exploit your kernel
With kvm and fuse, we can have a virtualized
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of the first
release candidate for the QEMU 1.1 release. This release is meant for testing
purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-1.1-rc1.tar.gz
You can help
From: Paolo Bonzini pbonz...@redhat.com
This fixes inability to make progress in streaming if the quota is set
to less than the amount of data that an I/O operation has to write.
In this case, limit-dispatched + n will always be above the quota and,
due to the goto retry to recheck cancellation
Another pullreq for 1.1 -- this is an update of the previous
one to add the patch fixing the -cpu foo segfault. Please
pull in time for 1.1-rc2 :-)
thanks
-- PMM
The following changes since commit 9f34841a812dc622f8de98bc6141925c22f0ee93:
Update version for 1.1.0-rc0 release (2012-05-09
From: Matt Craighead mjcraigh...@gmail.com
This patch fixes a bug affecting a variety of Neon instructions, such as
VQADD.
Signed-off-by: Matt Craighead mjcraigh...@gmail.com
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
target-arm/neon_helper.c |2 +-
1 files changed, 1
The macro definition of cpu_init meant that if cpu_arm_init()
returned NULL this wouldn't result in cpu_init() itself returning
NULL. This had the effect that -cpu foo for some unknown CPU
name 'foo' would cause ARM targets to segfault rather than
generating a useful error message. Fix this by
From: Paolo Bonzini pbonz...@redhat.com
qemu-img info should use the same logic as qemu when printing the
backing file path, or debugging becomes quite tricky. We can also
simplify the output in case the backing file has an absolute path
or a protocol.
Signed-off-by: Paolo Bonzini
From: Paolo Bonzini pbonz...@redhat.com
Unallocated sectors should really never be accessed by the guest,
so there's no need to copy them during the streaming process.
If they are read by the guest during streaming, guest-initiated
copy-on-read will copy them (we're in the base == NULL case,
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/Makefile |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index a7697bd..20e4da9 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -18,8 +18,8 @@ check-block-$(CONFIG_POSIX) +=
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qmp-commands.hx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index c810c74..db980fa 100644
---
Let's start with testing media change.
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
tests/Makefile |2 +
tests/fdc-test.c | 195 ++
2 files changed, 197 insertions(+), 0 deletions(-)
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
tests/libqtest.c | 123 ++
tests/libqtest.h | 17 +++
2 files changed, 113 insertions(+), 27 deletions(-)
diff --git a/tests/libqtest.c
On 05/10/2012 03:35 PM, Richard W.M. Jones wrote:
On Thu, May 10, 2012 at 03:29:54PM +0300, Avi Kivity wrote:
Currently when you mount a filesystem, you face two issues:
- you have to be root
- if the media is untrusted, it can exploit your kernel
With kvm and fuse, we can have a
On 05/10/2012 02:53 PM, Gleb Natapov wrote:
On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb Natapov wrote:
On Wed, May 09, 2012 at 11:05:58AM +0200, Alexander Graf wrote:
On 09.05.2012, at 10:51, Gleb Natapov wrote:
On Wed, May
From: Paolo Bonzini pbonz...@redhat.com
Also reuse elsewhere the new constant for sizeof(unsigned long) * 8.
The dirty bitmap is allocated in bits but declared as unsigned long.
Thus, its memory block is accessed beyond its end unless the image
is a multiple of 64 chunks (i.e. a multiple of 64
From: Paolo Bonzini pbonz...@redhat.com
Because sector_num is not updated, the loop would either go on
forever or return garbage.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-io.c | 10 --
1 files changed, 8 insertions(+), 2
Also move it up into switch(qxl-revision) block
Signed-off-by: Uri Lublin u...@redhat.com
---
hw/qxl.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c11e70..3da3399 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1746,13 +1746,16 @@ static
From: Paolo Bonzini pbonz...@redhat.com
This function abstracts the pretty complex semantics of the busy
member of BlockJob.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c| 11 +++
block/stream.c | 23
From: Paolo Bonzini pbonz...@redhat.com
A trailing space is left when qemu-img has no arguments, for example if
-nocache is not used. This becomes an empty argument after split()
and causes qemu-io to fail.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com
bdrv_close should leave fields in the same state as bdrv_new. It is
not up to bdrv_open_common to fix the mess.
Also, backing_format was not being re-initialized.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
From: Paolo Bonzini pbonz...@redhat.com
The limitation on not having I/O after cancellation cannot really be
kept. Even streaming has a very small race window where you could
cancel a job and have it report completion. If this window is hit,
bdrv_change_backing_file() will yield and possibly
On Thu, May 10, 2012 at 03:21:41PM +0200, Alexander Graf wrote:
On 05/10/2012 02:53 PM, Gleb Natapov wrote:
On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb Natapov wrote:
On Wed, May 09, 2012 at 11:05:58AM +0200, Alexander Graf
Both solutions work for my application !
Thanks a lot. I think I will use one of them, even if I know it's not really
clean.
Thanks again,
Alain
On Wed, May 09, 2012 at 08:44:45PM -0400, Kevin O'Connor wrote:
On Wed, May 09, 2012 at 08:57:53AM -0700, Alain
Am 10.05.2012 09:48, schrieb Kevin Wolf:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
To be applied on top of the floppy qtest patch.
Reviewed-by: Andreas Färber afaer...@suse.de
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix
On 2012-05-10 09:29, Avi Kivity wrote:
Currently when you mount a filesystem, you face two issues:
- you have to be root
- if the media is untrusted, it can exploit your kernel
With kvm and fuse, we can have a virtualized kernel mount the
filesystem, and re-export to the host, which mounts
On Thu, May 10, 2012 at 04:39:45PM +0300, Gleb Natapov wrote:
On Thu, May 10, 2012 at 03:21:41PM +0200, Alexander Graf wrote:
On 05/10/2012 02:53 PM, Gleb Natapov wrote:
On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb Natapov
On 05/10/12 15:24, Uri Lublin wrote:
Also move it up into switch(qxl-revision) block
Looks good.
Anthony, want a one-patch-pull-req for this one?
Or can you just pick it up directly?
cheers,
Gerd
While for the normal case (called from blk_send_response_all())
decrementing requests_finished is correct, doing so in the parse error
case is wrong; requests_inflight needs to be decremented instead.
Signed-off-by: Jan Beulich jbeul...@suse.com
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -154,7
Hotplug CallTrace:
int acpiphp_enable_slot(struct acpiphp_slot *slot)
\_enable_device(slot);
\_pci_bus_add_devices(bus);
# un-added new devs(all funcs in slot) will be added
list_for_each_entry(dev, bus-devices, bus_list) {
if (dev-is_added)
On Tue, May 08, 2012 at 10:58:22PM +0800, Amos Kong wrote:
Add five new qerror strings, they are about listen/connect socket:
QERR_SOCKET_CONNECT_IN_PROGRESS
QERR_SOCKET_CONNECT_FAILED
QERR_SOCKET_LISTEN_FAILED
QERR_SOCKET_BIND_FAILED
QERR_SOCKET_CREATE_FAILED
Signed-off-by:
Kevin Wolf wrote:
Am 09.05.2012 11:23, schrieb Jim Meyering:
[Argh. First attempt omitted the most important address: qemu-devel.
Sorry to all who get two copies. ]
Given qemu's HACKING comments, I'm sure many here have read man strncpy,
where it indicates it is often not the best function
On Tue, May 08, 2012 at 10:58:40PM +0800, Amos Kong wrote:
Add a new argument in inet_listen()/inet_listen_opts()
to pass back listen error.
Change nbd, qemu-char, vnc to use new interface.
Signed-off-by: Amos Kong ak...@redhat.com
Reviewed-by: Orit Wasserman owass...@redhat.com
From: Jim Meyering meyer...@redhat.com
I ran coverity on all of qemu and have begun going through the results.
A couple problems jumped out as obvious and easy to fix:
Jim Meyering (2):
kvm/apic: correct short memset
cadence_gem: avoid stack-writing buffer-overrun
hw/cadence_gem.c | 2 +-
From: Jim Meyering meyer...@redhat.com
Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number
of bytes to clear. The latter would always clear 4 or 8
bytes, possibly writing beyond the end of that stack buffer.
Alternatively, depending on the value of the size parameter,
it could fail to
From: Jim Meyering meyer...@redhat.com
kvm_put_apic_state's attempt to clear *kapic before setting its
bits cleared sizeof(void*) bytes (no more than 8) rather than the
intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
Signed-off-by: Jim Meyering meyer...@redhat.com
---
1 - 100 of 177 matches
Mail list logo
