Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 6:28 PM, Peter Maydell wrote: > On 21 May 2012 19:08, Blue Swirl wrote: >> On Mon, May 21, 2012 at 10:36 AM, Peter Maydell >> wrote: >>> I think it would be nice to have this in upstream qemu; however adding >>> transaction properties to the IO interface would be quite tr

[Qemu-devel] [PATCH 04/19] pc: Enable MSI support at APIC level

2012-05-21 Thread Avi Kivity
From: Jan Kiszka Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. Acked-by: Stefano Stabellini Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/apic.c |3 +++ hw/pc.c

Re: [Qemu-devel] [PULL] qemu-ga fixes for 1.1

2012-05-21 Thread Luiz Capitulino
On Tue, 15 May 2012 09:48:46 -0500 Michael Roth wrote: > The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: > > Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) > > are available in the git repository at: > git://github.com/mdroth/qemu.git qga-pull-5-15-12 >

[Qemu-devel] [PATCH 02/16] qemu-option: parse_option_number(): use error_set()

2012-05-21 Thread Luiz Capitulino
Note that qemu_opt_parse() callers still expect automatic error reporting with QError, so qemu_opts_parse() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-)

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 6:10 PM, Jim Meyering wrote: > Blue Swirl wrote: >> On Mon, May 21, 2012 at 10:03 AM, Jim Meyering wrote: >>> From: Jim Meyering >>> >>> I noticed this commit, >>> >>>    virtio-pci: add missing 'static' >>> >>> which made this change: >>> >>>    > -const MemoryRegionPort

[Qemu-devel] [PATCH 12/16] qemu-config: introduce qemu_find_opts_err()

2012-05-21 Thread Luiz Capitulino
This is like qemu_find_opts(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_find_opts(). Signed-off-by: Luiz Capitulino --- qemu-config.c |5 + qemu-config.h |3 +++ 2 files changed, 8 insertions(+) diff --git a/qe

[Qemu-devel] [PATCH 04/16] qemu-option: parse_option_size(): use error_set()

2012-05-21 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-option.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index b5da116..42bb685 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -203,7 +203,8 @@ static void parse_option_number(const ch

[Qemu-devel] [PATCH 03/16] qemu-option: parse_option_bool(): use error_set()

2012-05-21 Thread Luiz Capitulino
Note that set_option_parameter() callers still expect automatic error reporting with QError, so set_option_parameter() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 24 1 file changed, 16 insertions(+), 8 delet

[Qemu-devel] [PATCH 05/16] qemu-option: qemu_opt_parse(): use error_set()

2012-05-21 Thread Luiz Capitulino
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 36 +--- 1 fil

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Peter Maydell
On 21 May 2012 19:08, Blue Swirl wrote: > On Mon, May 21, 2012 at 10:36 AM, Peter Maydell > wrote: >> I think it would be nice to have this in upstream qemu; however adding >> transaction properties to the IO interface would be quite tricky I >> suspect... > > This is limited to CPU and CPU local

[Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-05-21 Thread Avi Kivity
Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master This is mostly Jan's MSI for KVM patches. Avi Kivity (1): kvm: update vmxcap for EPT A/D, INVPCID, RDRAND, VMFUNC Jan Kiszka (19): kvm: R

[Qemu-devel] [PATCH 02/19] Introduce MSIMessage structure

2012-05-21 Thread Avi Kivity
From: Jan Kiszka Will be used for generating and distributing MSI messages, both in emulation mode and under KVM. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- hw/msi.h |5 + qemu-common.h |1 + 2 files changed, 6 insertions(+) diff --git a/hw/msi.h b/hw/msi.h

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 9:09 AM, Andreas Färber wrote: > Am 14.05.2012 23:22, schrieb Blue Swirl: >> On Mon, May 14, 2012 at 8:59 PM, Andreas Färber wrote: >>> Am 14.05.2012 21:54, schrieb Blue Swirl: On Mon, May 14, 2012 at 4:15 PM, Andreas Färber wrote: > Am 10.05.2012 02:13, schrieb

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/21/2012 10:59 AM, Alex Williamson wrote: On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile

Re: [Qemu-devel] [PATCH qmp-next v5 00/16]: qapi: convert netdev_add & netdev_del

2012-05-21 Thread Laszlo Ersek
On 05/21/12 19:41, Luiz Capitulino wrote: > v5 > > - Simplify set_option_parameter() [Laszlo] patches changed: 3 & 4 > - Fix bad patch split in patch 15/16, hunk changing net_init_netdev() > pertains to patch 14/16 [Laszlo] hunk squashed from 15 into 14 > > blockdev.c |2 +- >

[Qemu-devel] [PATCH 15/19] kvm: Make kvm_irqchip_commit_routes an internal service

2012-05-21 Thread Avi Kivity
From: Jan Kiszka Automatically commit route changes after kvm_add_routing_entry and kvm_irqchip_release_virq. There is no performance relevant use case for which collecting multiple route changes is beneficial. This makes kvm_irqchip_commit_routes an internal service which assert()s that the corr

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: > On Mon, May 21, 2012 at 10:03 AM, Jim Meyering wrote: >> From: Jim Meyering >> >> I noticed this commit, >> >>    virtio-pci: add missing 'static' >> >> which made this change: >> >>    > -const MemoryRegionPortio virtio_portio[] = { >>    > +static const MemoryRegionPortio vi

[Qemu-devel] [PATCH 01/16] qemu-option: qemu_opts_create(): use error_set()

2012-05-21 Thread Luiz Capitulino
This commit converts qemu_opts_create() from qerror_report() to error_set(). Currently, most calls to qemu_opts_create() can't fail, so most callers don't need any changes. The two cases where code checks for qemu_opts_create() erros are: 1. Initialization code in vl.c. All of them print their

[Qemu-devel] [PATCH 14/16] net: net_client_init(): use error_set()

2012-05-21 Thread Luiz Capitulino
Callers are changed to use qerror_report_err() to keep their QError semantics. Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c |8 ++-- hw/usb/dev-network.c |7 +-- net.c| 54 +++--- net.h|2

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 10:13:47AM -0300, Jan Kiszka wrote: > Add a PCI IRQ path discovery function that walks from a given device to > the host bridge, returning the IRQ number that is reported to the > attached interrupt controller. For this purpose, another PCI bridge > callback function is intr

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:36 AM, Peter Maydell wrote: > On 21 May 2012 08:21, nicolas.sauzede wrote: >> Ok, so I guess that for now, we have to live with the lack of a way to >> actually >> get those io transaction properties, right ? >> Do you think it would be feasible to allow it the future

[Qemu-devel] [PATCH 08/16] qemu-option: introduce qemu_opt_set_err()

2012-05-21 Thread Luiz Capitulino
This is like qemu_opt_set(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_opt_set(). Signed-off-by: Luiz Capitulino --- qemu-option.c |6 ++ qemu-option.h |2 ++ 2 files changed, 8 insertions(+) diff --git a/qemu-o

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:25 AM, Jim Meyering wrote: > Blue Swirl wrote: >> On Tue, May 15, 2012 at 1:04 PM,   wrote: >>> From: Jim Meyering >>> >>> Without this, envlist_to_environ may silently fail to copy all >>> strings into the destination buffer, and both callers would leak >>> any env str

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-05-21 Thread Jason Baron
On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: > Add a command line parameter to not dump guest memory in the core dump, the > command line is: -dont-dump-guest. This brought the core dump down from > 383MB to 13 MB on a 1GB guest. > > Signed-off-by: Jason Baron > --- > exec.c

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:03 AM, Jim Meyering wrote: > From: Jim Meyering > > I noticed this commit, > >    virtio-pci: add missing 'static' > > which made this change: > >    > -const MemoryRegionPortio virtio_portio[] = { >    > +static const MemoryRegionPortio virtio_portio[] = { > > and wond

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Peter Maydell
On 21 May 2012 18:30, Blue Swirl wrote: > On Mon, May 21, 2012 at 8:14 AM, Kevin Wolf wrote: >> Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the >> point here is that today it's a FLOPPY_ERROR, and except for register >> fuzzing they report real problems with the emulation and

Re: [Qemu-devel] [PATCH 02/15] Openrisc: add MMU support

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 9:03 AM, 陳韋任 wrote: >> >> diff --git a/target-openrisc/mem_helper.c b/target-openrisc/mem_helper.c >> >> index a2d93c7..922dd6b 100644 >> >> --- a/target-openrisc/mem_helper.c >> >> +++ b/target-openrisc/mem_helper.c >> >> @@ -42,5 +42,30 @@ >> >> 戹oid tlb_fill(CPUOPENRISCS

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 8:18 AM, Paolo Bonzini wrote: >> >> What do you mean by fixing? Turning them into DPRINTFs? >> > >> > Or trace events? >> >> Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the >> point here is that today it's a FLOPPY_ERROR, and except for register >> fuzzi

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 8:14 AM, Kevin Wolf wrote: > Am 21.05.2012 10:11, schrieb Paolo Bonzini: >> Il 21/05/2012 09:51, Kevin Wolf ha scritto: > GTESTER check-qtest-i386 > FLOPPY ERROR: fdctrl_read_data: controller not ready for reading > FLOPPY ERROR: fdctrl_read_data: controller not

[Qemu-devel] Current differences between qemu --enable-kvm and qemu-kvm?

2012-05-21 Thread Erik Rull
Hi all, is there a summary existing that shows up the rough or actual differences between qemu --enable-kvm and qemu-kvm? I tested both versions with the same compile and start options, the CPU performance results are identical, only the bootup time of my guest system with qemu-kvm seemed to b

[Qemu-devel] [PATCH for-1.1] Makefile.user: Clean libuser/qom/ subdirectory

2012-05-21 Thread Andreas Färber
Commit dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) introduced a qom/ subdir in libuser/. It contains cpu.o once built. That never gets cleaned up. Add qom to the list of subdirectories to be cleaned. Signed-off-by: Andreas Färber Cc: Riku Voipio Cc: Blue Swirl --- Make

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Andreas Färber
Am 21.05.2012 18:11, schrieb Fabien Chouteau: > The size of EPN field in MAS2 depends on page size. This patch adds a > mask to discard invalid bits in EPN field. > > Definition of EPN field from e500v2 RM: > EPN Effective page number: Depending on page size, only the bits > associated with a page

Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support

2012-05-21 Thread Anthony Liguori
On 05/21/2012 10:56 AM, Paolo Bonzini wrote: Il 16/05/2012 12:54, Paolo Bonzini ha scritto: Previous versions of these patches have been posted already, but they were lost. Sorry for realizing this quite late. VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* SCSI requests, no

[Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
The size of EPN field in MAS2 depends on page size. This patch adds a mask to discard invalid bits in EPN field. Definition of EPN field from e500v2 RM: EPN Effective page number: Depending on page size, only the bits associated with a page boundary are valid. Bits that represent offsets within a

Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support

2012-05-21 Thread Paolo Bonzini
Il 16/05/2012 12:54, Paolo Bonzini ha scritto: > Previous versions of these patches have been posted already, but they > were lost. Sorry for realizing this quite late. > > VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* > SCSI requests, not *execute* them. So it should always

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 17:44, Anthony Liguori ha scritto: > It also gets very challenging if some options are backported and others > aren't. It gets challenging anyway with backports. If qmp_block_stream_v1_2 knows of defaults and doesn't send them on the wire, it will work if you only rely on the subset

Re: [Qemu-devel] [PATCH 1.1 0/4] sheepdog: various sheepdog fixes

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 20:15, schrieb MORITA Kazutaka: > This patchset contains various fixes for Sheepdog. See individual > patches for details. > > MORITA Kazutaka (4): > sheepdog: mark image as snapshot when tag is specified > sheepdog: fix return value of do_load_save_vm_state > sheepdog: return

Re: [Qemu-devel] [PATCH 1.1 2/4] sheepdog: fix return value of do_load_save_vm_state

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 20:15, schrieb MORITA Kazutaka: > bdrv_save_vmstate and bdrv_load_vmstate should return the number of > processed bytes on success. > > Signed-off-by: MORITA Kazutaka > --- > block/sheepdog.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/bloc

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:47 AM, Paolo Bonzini wrote: Il 21/05/2012 16:40, Anthony Liguori ha scritto: On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is: comma

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 17:30, schrieb Eric Blake: > On 05/21/2012 07:59 AM, Richard W.M. Jones wrote: > >>> >>> Hm, I'm wondering... If I have a command line like this: >>> >>> qemu-img diff -b base.img modified.img diff.qcow2 >>> >>> Would this be equivalent to this sequence? >>> >>> qemu-img create -

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Eric Blake
On 05/21/2012 07:59 AM, Richard W.M. Jones wrote: >> >> Hm, I'm wondering... If I have a command line like this: >> >> qemu-img diff -b base.img modified.img diff.qcow2 >> >> Would this be equivalent to this sequence? >> >> qemu-img create -f qcow2 -b modified.img diff.qcow2 >> qemu-img reba

[Qemu-devel] KVM call agenda for May, Tuesday 22

2012-05-21 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 16:34, schrieb Stefan Hajnoczi: > On Tue, May 15, 2012 at 02:42:54PM +0200, Paolo Bonzini wrote: >> Il 15/05/2012 14:01, Kevin Wolf ha scritto: >>> Hi all, >>> >>> after having implemented refcount fixing in qcow2's img_check, I'm now >>> wondering what the best way is to allow users

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 15:07, Kevin Wolf ha scritto: > Am 21.05.2012 13:02, schrieb Paolo Bonzini: >> Il 21/05/2012 12:32, Kevin Wolf ha scritto: >>> Am 21.05.2012 12:02, schrieb Paolo Bonzini: Il 21/05/2012 11:29, Kevin Wolf ha scritto: >>> If source/target is really the distinction we want to have, s

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 14:18, Michael S. Tsirkin ha scritto: >> > Almost all our >> > devices were written without any thought given to ordering, so they >> > basically can and should be considered as all broken. > Problem is, a lot of code is likely broken even after you sprinkle > barriers around. For exa

Re: [Qemu-devel] qxl performance problems and spice issues

2012-05-21 Thread Luis Geraldes
Thank you for you reply, > What version of drivers (windows guest, linux guest) do you have? Windows: http://spice-space.org/download/binaries/spice-guest-tools-0.1.exe Debian wheezy: from repository: http://packages.debian.org/wheezy/xserver-xorg-video-qxl (0.0.17-2) http://packages.debian.

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:50, Igor Mammedov wrote: >> I've used cpu_index, but it seems cpuid_apic_id is assigned only once, >> from cpu_index, so it should be identical. What's the difference? > Once Jan voiced that user visible cpu id, should be apic_id in context of cpu > hotplug > (i.e. when doing: dev

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: > On 05/18/2012 10:47 PM, Alex Williamson wrote: > > On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: > >> On 05/18/2012 06:02 PM, Alex Williamson wrote: > >>> On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: > On 05/15/2012 05:09 PM

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Igor Mammedov
On 05/10/2012 01:15 AM, Andreas Färber wrote: Am 17.04.2012 12:28, schrieb Igor Mammedov: - Original Message - From: "Andreas Färber" ... I think the right name would be /machine/cpu[%d]/cpu. The local APIC for example should reside under /machine/cpu[%d]/apic. Depends on how we mo

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:36, Avi Kivity wrote: > On 05/21/2012 04:13 PM, Jan Kiszka wrote: >> Add a PCI IRQ path discovery function that walks from a given device to >> the host bridge, returning the IRQ number that is reported to the >> attached interrupt controller. For this purpose, another PCI bridge >

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 16:40, Anthony Liguori ha scritto: > On 05/21/2012 09:26 AM, Paolo Bonzini wrote: >> Il 21/05/2012 16:19, Anthony Liguori ha scritto: >>> >>> I'm not against it in principle, just in practice. Today, checking >>> whether a command exists is: >>> >>> commands = qmp.query_commands

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is: commands = qmp.query_commands() if 'block-stream' in commands: # has block-stream I have a har

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 15:59, Luiz Capitulino ha scritto: > I understand your reasoning, and since the beginning I thought this was > something useful to do, but we've already settled for not doing this. > > I also think that we shouldn't have exceptions, as in practice this means > we're extending command

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Avi Kivity
On 05/21/2012 04:13 PM, Jan Kiszka wrote: > Add a PCI IRQ path discovery function that walks from a given device to > the host bridge, returning the IRQ number that is reported to the > attached interrupt controller. For this purpose, another PCI bridge > callback function is introduced: map_host_i

Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-21 Thread Stefan Hajnoczi
On Tue, May 15, 2012 at 02:42:54PM +0200, Paolo Bonzini wrote: > Il 15/05/2012 14:01, Kevin Wolf ha scritto: > > Hi all, > > > > after having implemented refcount fixing in qcow2's img_check, I'm now > > wondering what the best way is to allow users to optionally enable the > > "QED mode" for cach

[Qemu-devel] [QEMU 1.1 PATCH v3] Expose CPUID leaf 7 only for -cpu host

2012-05-21 Thread Eduardo Habkost
Changes v2 -> v3; - Check for kvm_enabled() before setting cpuid_7_0_ebx_features Changes v1 -> v2: - Use kvm_arch_get_supported_cpuid() instead of host_cpuid() on cpu_x86_fill_host(). We should use GET_SUPPORTED_CPUID for all bits on "-cpu host" eventually, but I am not changing all

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 16:19, Anthony Liguori ha scritto: >> > > I'm not against it in principle, just in practice. Today, checking > whether a command exists is: > > commands = qmp.query_commands() > > if 'block-stream' in commands: > # has block-stream > > I have a hard time envisioning how schem

Re: [Qemu-devel] [QEMU 1.1 PATCH v2] Expose CPUID leaf 7 only for -cpu host

2012-05-21 Thread Eduardo Habkost
On Thu, May 17, 2012 at 01:26:55PM -0300, Eduardo Habkost wrote: [...] > @@ -521,6 +523,12 @@ static int cpu_x86_fill_host(x86_def_t *x86_cpu_def) > x86_cpu_def->ext_features = ecx; > x86_cpu_def->features = edx; > > +if (x86_cpu_def->level >= 7) { > +x86_cpu_def->cpuid_7_0_

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/21/2012 03:57 PM, Alexander Graf wrote: > On 05/21/2012 03:47 PM, Fabien Chouteau wrote: >> On 05/21/2012 01:11 PM, Alexander Graf wrote: >>> On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: > On 21.05.2012, at 10:56, Fabien Chouteau wrote:

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:16 AM, Luiz Capitulino wrote: On Mon, 21 May 2012 09:10:40 -0500 Anthony Liguori wrote: On 05/21/2012 08:59 AM, Luiz Capitulino wrote: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we'

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:09 AM, Kevin Wolf wrote: Am 21.05.2012 15:59, schrieb Luiz Capitulino: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, a

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 16:10, schrieb Anthony Liguori: > On 05/21/2012 08:59 AM, Luiz Capitulino wrote: >> On Fri, 18 May 2012 19:08:42 +0200 >> Paolo Bonzini wrote: >> >>> Modified QMP commands >>> = >> >> As we have discussed on the ML, we're not going to extend QMP commands. >> >> I

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Mon, 21 May 2012 16:09:28 +0200 Kevin Wolf wrote: > Am 21.05.2012 15:59, schrieb Luiz Capitulino: > > On Fri, 18 May 2012 19:08:42 +0200 > > Paolo Bonzini wrote: > > > >> Modified QMP commands > >> = > > > > As we have discussed on the ML, we're not going to extend QMP c

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Mon, 21 May 2012 09:10:40 -0500 Anthony Liguori wrote: > On 05/21/2012 08:59 AM, Luiz Capitulino wrote: > > On Fri, 18 May 2012 19:08:42 +0200 > > Paolo Bonzini wrote: > > > >> Modified QMP commands > >> = > > > > As we have discussed on the ML, we're not going to extend Q

Re: [Qemu-devel] [PATCH 2/2] pci: Add INTx routing notifier

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 10:15 -0300, Jan Kiszka wrote: > This per-device notifier shall be triggered by any interrupt router > along the path of a device's legacy interrupt signal on routing changes. > For simplicity reasons and as this is a slow path anyway, no further > details on the routing chang

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 10:13 -0300, Jan Kiszka wrote: > Add a PCI IRQ path discovery function that walks from a given device to > the host bridge, returning the IRQ number that is reported to the > attached interrupt controller. For this purpose, another PCI bridge > callback function is introduced:

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 08:59 AM, Luiz Capitulino wrote: On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: Modified QMP commands = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, and since the beginning I thought this was

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 15:59, schrieb Luiz Capitulino: > On Fri, 18 May 2012 19:08:42 +0200 > Paolo Bonzini wrote: > >> Modified QMP commands >> = > > As we have discussed on the ML, we're not going to extend QMP commands. > > I understand your reasoning, and since the beginning I th

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 15:59, schrieb Richard W.M. Jones: > On Mon, May 21, 2012 at 03:29:22PM +0200, Kevin Wolf wrote: >> Am 17.05.2012 17:34, schrieb Richard W.M. Jones: >>> From: "Richard W.M. Jones" >>> >>> This produces a qcow2 file which is the difference between >>> two disk images. ie, if: >>> >>>

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Andreas Färber
Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): [...] > target-mips: Use cpu_reset() in cpu_mips_init() [...] > target-mips: Use cpu_reset() in do_interrupt() > target-mips: Let cpu_mips_init() return MIPSCPU > mips_fulong2e: Use cpu_mips_cpu() to obtain MIPSCPU > mips

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Richard W.M. Jones
On Mon, May 21, 2012 at 03:29:22PM +0200, Kevin Wolf wrote: > Am 17.05.2012 17:34, schrieb Richard W.M. Jones: > > From: "Richard W.M. Jones" > > > > This produces a qcow2 file which is the difference between > > two disk images. ie, if: > > > > base.img - is a disk image (in any format)

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Luiz Capitulino
On Fri, 18 May 2012 19:08:42 +0200 Paolo Bonzini wrote: > Modified QMP commands > = As we have discussed on the ML, we're not going to extend QMP commands. I understand your reasoning, and since the beginning I thought this was something useful to do, but we've already settl

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 05/21/2012 03:47 PM, Fabien Chouteau wrote: On 05/21/2012 01:11 PM, Alexander Graf wrote: On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: On 21.05.2012, at 10:56, Fabien Chouteau wrote: On 05/20/2012 12:18 PM, Alexander Graf wrote: On 20.05.20

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Alexander Graf
On 05/10/2012 02:10 AM, Andreas Färber wrote: Hello, Based on my CPUState patches for 1.1 (qom-cpu-1.1) this series kills off the cpu_state_reset() function, which had been renamed as an interim solution to free the identifier "cpu_reset" for QOM. The interested observer may note that the earli

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
On 05/21/2012 01:11 PM, Alexander Graf wrote: > On 05/21/2012 12:59 PM, Fabien Chouteau wrote: >> On 05/21/2012 11:08 AM, Alexander Graf wrote: >>> On 21.05.2012, at 10:56, Fabien Chouteau wrote: >>> On 05/20/2012 12:18 PM, Alexander Graf wrote: > > On 20.05.2012, at 12:15, Alexander G

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helga

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 17.05.2012 17:34, schrieb Richard W.M. Jones: > From: "Richard W.M. Jones" > > This produces a qcow2 file which is the difference between > two disk images. ie, if: > > base.img - is a disk image (in any format) > modified.img - is base.img, copied and modified > > then: > > qemu

Re: [Qemu-devel] The image size of instance VM keeps growing

2012-05-21 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 10:08 AM, Charles.Tsai-蔡清海-研究發展部 wrote: > We can run a tool to see if there is any active I/O or not. Does the image > size shrink back if an I/O activity stops? > What we found here is that the image size kept growing. If this problem > persists, it could eat up the enti

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-21 Thread Stefan Hajnoczi
On Mon, May 21, 2012 at 12:00 PM, ronnie sahlberg wrote: > Yes, I use IDE since I boot from this LUN. > > > I just managed to track it down to the IDE changes. > > It looks like basically this change triggered it : > > commit bef0fd5958120542f126f2dedbfce65d8839a94d > Author: Stefan Hajnoczi > Da

[Qemu-devel] [PATCH 2/2] pci: Add INTx routing notifier

2012-05-21 Thread Jan Kiszka
This per-device notifier shall be triggered by any interrupt router along the path of a device's legacy interrupt signal on routing changes. For simplicity reasons and as this is a slow path anyway, no further details on the routing changes are provided. Instead, the callback is expected to use pci

[Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose, another PCI bridge callback function is introduced: map_host_irq. It is so far only implemented by the PIIX3, ot

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Eric Blake
On 05/21/2012 05:02 AM, Paolo Bonzini wrote: > Eric, is it a problem for libvirt if a pause or target error during > mirroring causes the job to exit steady state? That means that after a > target error the offset can go back from 100% to <100%. Libvirt would really like to have events present.

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 13:02, schrieb Paolo Bonzini: > Il 21/05/2012 12:32, Kevin Wolf ha scritto: >> Am 21.05.2012 12:02, schrieb Paolo Bonzini: >>> Il 21/05/2012 11:29, Kevin Wolf ha scritto: > * block-stream: I propose adding two options to the existing > block-stream command. If this is rejecte

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Stefan Hajnoczi
This makes sense given the generic nature of block jobs. If mirroring was only for live migration, for example, then we could avoid all this by choosing a single policy. As a generic operation it's nice to have control over error policy. Stefan

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 09:45:58PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-05-21 at 13:31 +0300, Michael S. Tsirkin wrote: > > > > IE. Just making the default accessors ordered means that all devices > > > written with the assumption that the guest will see accesses in the > > > order

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Amit Shah
On (Mon) 21 May 2012 [12:29:52], Daniel P. Berrange wrote: > On Mon, May 21, 2012 at 04:44:38PM +0530, Amit Shah wrote: > > On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > > > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > > > On 05/16/2012 01:42 PM, Luiz Capituli

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Andreas Färber
Am 21.05.2012 09:21, schrieb nicolas.sauzede: > Hi Peter, > >> Message du 19/05/12 11:39 >> De : "Peter Maydell" >> A : "Blue Swirl" >> Copie à : "nicolas.sauzede" , qemu-devel@nongnu.org >> Objet : Re: [Qemu-devel] Get current env within io_handler ? >> >> On 19 May 2012 08:13, Blue Swirl wrot

Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Gerd Hoffmann
Hi, > OK, so I can fix this and remove the qxl0 hack at the same stroke. I was > looking at using the system_bus, but that seems like another hack. Didn't check what qom provides these days, searching for objects of a certain type (for example a qxl device) should be possible IMO. Dunno whenev

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Benjamin Herrenschmidt
On Mon, 2012-05-21 at 13:31 +0300, Michael S. Tsirkin wrote: > > IE. Just making the default accessors ordered means that all devices > > written with the assumption that the guest will see accesses in the > > order they are written in the emulated device will be correct, which > > means pretty mu

Re: [Qemu-devel] [RFC 2/2] hmp/qxl: info spice: add qxl0_mode & qxl0_guest_bug

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 11:22:16AM +0200, Gerd Hoffmann wrote: > Hi, > > > +if (info->qxl0_guest_bug != -1 && info->qxl0_mode != -1) { > > +monitor_printf(mon, " qxl0\n"); > > +monitor_printf(mon, " guest_bug: %"PRIu64"d\n", > > info->qxl0_guest_bug); > > +monitor_

Re: [Qemu-devel] [RFC][PATCH v2 00/11] uq/master: irqfd-based interrupt injection for virtio/vhost

2012-05-21 Thread Avi Kivity
On 05/21/2012 02:31 PM, Jan Kiszka wrote: > On 2012-05-20 11:45, Avi Kivity wrote: > > On 05/20/2012 05:42 PM, Michael S. Tsirkin wrote: > >> On Thu, May 17, 2012 at 10:32:28AM -0300, Jan Kiszka wrote: > >>> After this series, to only reasons to still use qemu-kvm for production > >>> purposes will

Re: [Qemu-devel] [RFC 1/2] hw/qxl: ignore guest from guestbug until reset

2012-05-21 Thread Alon Levy
On Mon, May 21, 2012 at 11:12:35AM +0200, Gerd Hoffmann wrote: > On 05/21/12 11:04, Alon Levy wrote: > > reset only by a guest QXL_IO_RESET > > Looks sensible. I guess you want clear guest_bug in the "guest touched > vga registers" code path too. good point, will fix for v2. > > cheers, > Ge

Re: [Qemu-devel] [RFC][PATCH v2 00/11] uq/master: irqfd-based interrupt injection for virtio/vhost

2012-05-21 Thread Jan Kiszka
On 2012-05-20 11:45, Avi Kivity wrote: > On 05/20/2012 05:42 PM, Michael S. Tsirkin wrote: >> On Thu, May 17, 2012 at 10:32:28AM -0300, Jan Kiszka wrote: >>> After this series, to only reasons to still use qemu-kvm for production >>> purposes will be PCI device assignment >> >> Yay! >> >> By the wa

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Daniel P. Berrange
On Mon, May 21, 2012 at 04:44:38PM +0530, Amit Shah wrote: > On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > > On 05/16/2012 01:42 PM, Luiz Capitulino wrote: > > > >On Wed, 16 May 2012 11:10:47 +0100 > > > >"Daniel

Re: [Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 13:06, schrieb Jim Meyering: > > Signed-off-by: Jim Meyering > --- > Thanks to Kevin Wolf for the improvement. > > block/qcow2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 655799c..c2e49cd 100644 > --- a/block/

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-21 Thread Amit Shah
On (Thu) 17 May 2012 [08:49:44], Daniel P. Berrange wrote: > On Wed, May 16, 2012 at 01:58:34PM -0500, Anthony Liguori wrote: > > On 05/16/2012 01:42 PM, Luiz Capitulino wrote: > > >On Wed, 16 May 2012 11:10:47 +0100 > > >"Daniel P. Berrange" wrote: > > > > > >>From: "Daniel P. Berrange" > > >> >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 05/21/2012 12:59 PM, Fabien Chouteau wrote: On 05/21/2012 11:08 AM, Alexander Graf wrote: On 21.05.2012, at 10:56, Fabien Chouteau wrote: On 05/20/2012 12:18 PM, Alexander Graf wrote: On 20.05.2012, at 12:15, Alexander Graf wrote: On 09.05.2012, at 15:28, Fabien Chouteau wrote: The

Re: [Qemu-devel] [PATCH 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Jim Meyering
Kevin Wolf wrote: > Am 16.05.2012 15:07, schrieb Jim Meyering: >> From: Jim Meyering >> >> >> Signed-off-by: Jim Meyering >> --- >> block/qcow2.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/block/qcow2.c b/block/qcow2.c >> index 655799c..f3388bf 100644 >> --- a/block/qcow2.c >> +

[Qemu-devel] [PATCHv2 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-21 Thread Jim Meyering
Signed-off-by: Jim Meyering --- Thanks to Kevin Wolf for the improvement. block/qcow2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index 655799c..c2e49cd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -919,7 +919,8 @@ int qcow2_update_

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 12:32, Kevin Wolf ha scritto: > Am 21.05.2012 12:02, schrieb Paolo Bonzini: >> Il 21/05/2012 11:29, Kevin Wolf ha scritto: * block-stream: I propose adding two options to the existing block-stream command. If this is rejected, only mirroring will be able to use rerror/

<    1   2   3   >