[Qemu-devel] [PATCH 24/25] PPC: e500: enable manual loading of dtb blob

2012-05-30 Thread Alexander Graf
We want to be able to override the automatically created device tree by using the -dtb option. Implement this for the mpc8544ds machine. Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 13:54, Andreas Färber wrote: Am 30.05.2012 13:29, schrieb Alexander Graf: On 30.05.2012, at 13:22, Andreas Färber wrote: Am 30.05.2012 10:13, schrieb Alexander Graf: On 21.05.2012, at 18:11, Fabien Chouteau wrote: The size of EPN field in MAS2 depends on page size.

[Qemu-devel] [PATCH 21/25] dt: Add -machine dumpdtb option to dump the current dtb

2012-05-30 Thread Alexander Graf
Now that we are dynamically creating the dtb, it's really useful to be able to dump the created blob for debugging. This patch implements a -machine dumpdtb=file option for e500 that dumps the dtb exactly in the form the guest would get it to disk. It can then be analyzed by dtc to get

[Qemu-devel] [PATCH 07/25] dt: add helper for phandle allocation

2012-05-30 Thread Alexander Graf
Phandle references work by having 2 pieces: - a phandle 1-cell property in the device tree node - a reference to the same value in a property we want to point to the other node To generate the 1-cell property, we need an allocation mechanism that gives us a unique number space. This

[Qemu-devel] [PATCH 16/25] PPC: e500: dt: create serial nodes dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c | 35 +++ pc-bios/mpc8544ds.dts | 26 -- 2 files changed, 35 insertions(+), 26 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index

[Qemu-devel] [PATCH 06/25] dt: add helper for empty dt creation

2012-05-30 Thread Alexander Graf
We want to get rid of the concept of loading an external device tree and instead generate our own. However, to do this we need to also create a device tree template programatically. This patch adds a helper to create an empty device tree in memory. Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PATCH 18/25] PPC: e500: dt: create global-utils node dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c |9 + pc-bios/mpc8544ds.dts |6 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 3d073dd..3f6c6e3 100644 --- a/hw/ppce500_mpc8544ds.c

[Qemu-devel] [PATCH 20/25] PPC: e500: dt: start with empty device tree

2012-05-30 Thread Alexander Graf
Now that all of the device tree bits are generated during runtime, we can get rid of the device tree blob and instead start from scratch with an empty device tree. Signed-off-by: Alexander Graf ag...@suse.de --- Makefile |1 - hw/ppce500_mpc8544ds.c |8 +---

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Andreas Färber
Am 30.05.2012 14:01, schrieb Markus Armbruster: Ordinary device models have a single state struct. The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. Virtio device models are different. Their state struct is really a proxy object that

[Qemu-devel] [PATCH 15/25] PPC: e500: dt: create /soc8544 node dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c | 17 + pc-bios/mpc8544ds.dts |9 - 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 63515bb..5ff2d24 100644 ---

[Qemu-devel] [PATCH 22/25] PPC: e500: dt: use 64bit cell helper

2012-05-30 Thread Alexander Graf
We have a nice 64bit helper to ease the device tree generation and make the code more readable when creating 64bit 2-cell parameters. Use it when generating the device tree. Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c | 10 -- 1 files changed, 4

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-30 Thread Geert Jansen
On 05/29/2012 02:52 PM, Paolo Bonzini wrote: Does the drive-mirror coroutine send the writes to the target in the same order as they are sent to the source? I assume so. No, it doesn't. It's asynchronous; for continuous replication, the target knows that it has a consistent view whenever it

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-30 Thread Andreas Färber
Am 30.05.2012 14:16, schrieb Alexander Graf: On 30.05.2012, at 13:54, Andreas Färber wrote: Am 30.05.2012 13:29, schrieb Alexander Graf: On 30.05.2012, at 13:22, Andreas Färber wrote: Am 30.05.2012 10:13, schrieb Alexander Graf: No reply from Blue, so I applied this patch to ppc-next

[Qemu-devel] [PATCH 14/25] PPC: e500: dt: create /chosen node dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 39b221d..63515bb 100644 --- a/hw/ppce500_mpc8544ds.c +++ b/hw/ppce500_mpc8544ds.c @@ -101,6 +101,7

[Qemu-devel] [PATCH 01/25] dt: allow add_subnode to create root subnodes

2012-05-30 Thread Alexander Graf
Our subnode creation helper can't handle creation of root subnodes, like /memory. Fix this by allowing the parent node to be an empty string, indicating the root node. Signed-off-by: Alexander Graf ag...@suse.de --- device_tree.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH 08/25] dt: add helper for 64bit cell adds

2012-05-30 Thread Alexander Graf
Some times in the device tree, we find an array of 2 u32 cells that really are a single u64 value. This patch adds a helper to make the creation of these easy. Signed-off-by: Alexander Graf ag...@suse.de --- device_tree.c |7 +++ device_tree.h |2 ++ 2 files changed, 9 insertions(+),

[Qemu-devel] [PATCH 25/25] Revert dt: temporarily disable subtree creation failure check

2012-05-30 Thread Alexander Graf
This reverts commit 417d5f1051e73db3f0d185d3be3ff3e69174893d which was meant as a temporary solution to keep external and dynamic device tree construction intact. Now that we switched to fully dynamic dt construction, it's no longer necessary. Signed-off-by: Alexander Graf ag...@suse.de ---

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-30 Thread Alexander Graf
On 30.05.2012, at 14:38, Andreas Färber wrote: Am 30.05.2012 14:16, schrieb Alexander Graf: On 30.05.2012, at 13:54, Andreas Färber wrote: Am 30.05.2012 13:29, schrieb Alexander Graf: On 30.05.2012, at 13:22, Andreas Färber wrote: Am 30.05.2012 10:13, schrieb Alexander Graf: No

[Qemu-devel] [PATCH 05/25] dt: add helper for phandle enumeration

2012-05-30 Thread Alexander Graf
This patch adds a helper to search for a node's phandle by its path. This is especially useful when the phandle is part of an array, not just a single cell in which case qemu_devtree_setprop_phandle would be the easy choice. Signed-off-by: Alexander Graf ag...@suse.de --- device_tree.c | 16

Re: [Qemu-devel] [PATCH 2/2] qmp: revert add set_echo implementation for qemu_chr_stdio

2012-05-30 Thread Eric Blake
On 05/30/2012 04:01 AM, Pavel Hrdina wrote: This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this code is not used in order that we use readline mode for '-qmp stdio'. Conflicts: qemu-char.c This is evidence that you've rebased locally, but as none of us know

[Qemu-devel] [PATCH 12/25] PPC: e500: dt: create /hypervisor node dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c |1 + pc-bios/mpc8544ds.dtb | Bin 1924 - 1904 bytes pc-bios/mpc8544ds.dts |3 --- 3 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index

[Qemu-devel] [PATCH 03/25] dt: add helper for phandle references

2012-05-30 Thread Alexander Graf
Phandles are the fancy device tree name for pointer to another node. To create a phandle property, we most likely want to reference to the node we're pointing to by its path. So create a helper that allows us to do so. Signed-off-by: Alexander Graf ag...@suse.de --- device_tree.c |7 +++

[Qemu-devel] [PATCH 04/25] dt: temporarily disable subtree creation failure check

2012-05-30 Thread Alexander Graf
Usually we want to know when creating a subtree fails. However, while introducing this patch set we have to modify the device tree and some times have the code to create a subtree in both the binary tree and the dynamically created tree. So ignore failures about this for now and enable them once

[Qemu-devel] [PATCH 17/25] PPC: e500: dt: create mpic node dynamically

2012-05-30 Thread Alexander Graf
Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_mpc8544ds.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 493ad6e..3d073dd 100644 --- a/hw/ppce500_mpc8544ds.c +++ b/hw/ppce500_mpc8544ds.c

[Qemu-devel] [PATCH 09/25] PPC: e500: require libfdt

2012-05-30 Thread Alexander Graf
Now that we're moving all of the device tree generation from an external pre-execution generated blob to runtime generation using libfdt, we absolutely must have libfdt around. This requirement was there before already, as the only way to not require libfdt with e500 was to not use -kernel, which

[Qemu-devel] [PATCH 02/25] dt: add helpers for 2, 3 and 4 cell adds

2012-05-30 Thread Alexander Graf
We have device tree helpers that allow us to create single cell (u32) wide properties. However, when creating properties that contain an array of cells, we need to jump through hoops, manually passing in an array with converted endianness. To ease the pain of this a bit, create helpers for the

Re: [Qemu-devel] [PATCH 2/2] qmp: revert add set_echo implementation for qemu_chr_stdio

2012-05-30 Thread Pavel Hrdina
On 05/30/2012 02:49 PM, Eric Blake wrote: On 05/30/2012 04:01 AM, Pavel Hrdina wrote: This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this code is not used in order that we use readline mode for '-qmp stdio'. Conflicts: qemu-char.c This is evidence that you've

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 11:54:11 +0300 Alon Levy al...@redhat.com wrote: On Tue, May 29, 2012 at 01:44:35PM -0300, Luiz Capitulino wrote: On Tue, 29 May 2012 17:51:50 +0300 Alon Levy al...@redhat.com wrote: On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote: On Tue, 29 May

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-05-30 Thread Scott Moser
This fix-commited upstream at http://git.qemu.org/?p=qemu.git;a=commit;h=9c3a596a03cc10c2d9097f057b9ccb9d557a4d5f . ** Changed in: qemu Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 2/5] sheepdog: fix return value of do_load_save_vm_state

2012-05-30 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp bdrv_save_vmstate and bdrv_load_vmstate should return the vmstate size on success, and -errno on error. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c | 10

[Qemu-devel] [PATCH 3/5] block: prevent snapshot mode $TMPDIR symlink attack

2012-05-30 Thread Kevin Wolf
From: Jim Meyering j...@meyering.net In snapshot mode, bdrv_open creates an empty temporary file without checking for mkstemp or close failure, and ignoring the possibility of a buffer overrun given a surprisingly long $TMPDIR. Change the get_tmp_filename function to return int (not void), so

Re: [Qemu-devel] [PATCH qom-next 01/12] store prev_debug_excp_handler globaly and not per target

2012-05-30 Thread Igor Mammedov
On 05/30/2012 12:51 PM, Jan Kiszka wrote: On 2012-05-30 00:10, Igor Mammedov wrote: current callers all do the same thing, storing in prev_debug_excp_handler previous handler and then calling it in breakpoint_handler. Move prev_debug_excp_handler from local scope to global and make

[Qemu-devel] [PATCH 5/5] ahci: SATA FIS is 20 bytes, not 0x20

2012-05-30 Thread Kevin Wolf
From: Daniel Verkamp dan...@drv.nu As in the SATA and AHCI specifications, a FIS is 5 Dwords of 4 bytes each, which comes to 20 bytes (decimal), not 0x20. Signed-off-by: Daniel Verkamp dan...@drv.nu Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/ahci.c |4 ++-- 1 files changed, 2

Re: [Qemu-devel] [PATCH qom-next 09/12] target-i386: make cpu a child of /machine right after it's created

2012-05-30 Thread Igor Mammedov
Andreas, Would it be better to squash this patch into pc: Add CPU as /machine/cpu[n] or just leave it as is? Is there any reason why it shouldn't be done in cpu's initfn? My concern here is that if it's done outside *_cpu_initfn then we will have provide 'device_add' with an option to specify

Re: [Qemu-devel] Keysymbol interpretation missing in QEMU's VNC server?

2012-05-30 Thread Fabian Holler
Howdy Erik, On Tue, May 29, 2012 at 09:22:02PM +0200, Erik Rull wrote: Fabian Holler wrote: I just want to route all keypresses to the guest without interfering with the native QEMU key layout. Is that possible? Yes, if you start kvm without the -k option and use a linux VNC client that

[Qemu-devel] [PATCH qmp-next v2 00/14]: qapi: convert screendump

2012-05-30 Thread Luiz Capitulino
Converting the screendump command is simple and shouldn't take more than or or two patches, the complicated part is to report all errors correctly. I hope I didn't go too far there, but at least this series does the right thing (or is very near to). o V2 - fix typos in various places [Alon/Me]

[Qemu-devel] [PATCH 04/14] cutils: introduce qemu_fprintf_err()

2012-05-30 Thread Luiz Capitulino
A fprintf() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cutils.c | 31 +++ qemu-common.h | 1 + 2 files changed, 32 insertions(+) diff --git a/cutils.c b/cutils.c index 85dbb06..7bbd1b7 100644 --- a/cutils.c

Re: [Qemu-devel] Android Goldfish on QEMU

2012-05-30 Thread Peter Maydell
On 30 May 2012 12:37, Andreas Färber afaer...@suse.de wrote: Am 30.05.2012 00:30, schrieb Peter Maydell: On 28 May 2012 13:28, Stefan Hajnoczi stefa...@gmail.com wrote: Is goldfish still a relevant Android dev platform?  In other words - would goldfish be useful to Android developers or just

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Kevin Wolf
Am 30.05.2012 12:01, schrieb Pavel Hrdina: For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need anymore an echo function for stdio,

[Qemu-devel] [PATCH 12/14] tcx: tcx24_screen_dump(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]-hw_screen_dump() with errp=NULL. The error will be

[Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES

2012-05-30 Thread Luiz Capitulino
Specify it's too many open files in system (ENFILE). There's no compatibility issue because QERR_TOO_MANY_FILES is actually not used today. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c | 4 ++-- qerror.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v4 02/23] ppc: Split exception helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Move exception helpers from op_helper.c to excp_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target |6 ++

[Qemu-devel] [PATCH v4 03/23] ppc: Avoid AREG0 for exception helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Add an explicit CPUPPCState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target |3 --

Re: [Qemu-devel] ARM: Virtual / Physical address translation

2012-05-30 Thread Laurent Desnogues
On Wed, May 30, 2012 at 3:20 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 30 May 2012 02:00, Ira Ray Jenkins irarayjenk...@gmail.com wrote: What I would like is to be able to get the physical addresses of both data and instructions. Can anyone help me work through how to get the

Re: [Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-30 Thread Igor Mammedov
On 05/30/2012 12:41 PM, Jan Kiszka wrote: On 2012-05-30 00:10, Igor Mammedov wrote: (L)APIC is a part of cpu [1] so move APIC initialization inside of x86_cpu object. Since cpu_model and override flags currently specify whether APIC should be created or not, APIC creation is moved into

[Qemu-devel] [PATCH 14/14] qapi: convert screendump

2012-05-30 Thread Luiz Capitulino
Also activates full error reporting from devices. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.c| 7 --- console.h| 1 - hmp-commands.hx | 3 +-- hmp.c| 9 + hmp.h| 1 + monitor.c| 6 -- qapi-schema.json

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Stefan Hajnoczi
On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster arm...@redhat.com wrote: Ordinary device models have a single state struct.  The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. I think Evgeny's virtio mmio patches change all this. In the

[Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-30 Thread Kevin Wolf
The following changes since commit e78bd5ab07d65fec77fcae468b2836c79a836d49: xhci: add usage info to docs (2012-05-30 10:28:44 +0800) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christian Borntraeger (1): virtio-blk: Fix geometry sector

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 02:11:58PM +0200, Jan Kiszka wrote: On 2012-05-21 23:03, Michael S. Tsirkin wrote: On Mon, May 21, 2012 at 05:35:34PM -0300, Jan Kiszka wrote: On 2012-05-21 16:05, Michael S. Tsirkin wrote: On Mon, May 21, 2012 at 10:13:47AM -0300, Jan Kiszka wrote: @@ -386,6

[Qemu-devel] [PATCH 1/5] virtio: Fix compiler warning for non Linux hosts

2012-05-30 Thread Kevin Wolf
From: Stefan Weil s...@weilnetz.de The local variables ret, i are only used if __linux__ is defined. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/virtio-blk.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 4/5] virtio-blk: Fix geometry sector calculation

2012-05-30 Thread Kevin Wolf
From: Christian Borntraeger borntrae...@de.ibm.com Currently the sector value for the geometry is masked, even if the user usesa command line parameter that explicitely gives a number. This breaks dasd devices on s390. A dasd device can have a physical block size of 4096 (== same for logical

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 15:34, Michael S. Tsirkin wrote: Below's as far as I got - hopefully this explains what I had in mind: for deep hierarchies this will save a bus scan so I think this makes sense even in the absense of kvm irqchip. Warning: completely untested and known to be incomplete.

Re: [Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-30 Thread Jan Kiszka
On 2012-05-30 16:27, Igor Mammedov wrote: + +#ifndef CONFIG_USER_ONLY +#define MSI_ADDR_BASE 0xfee0 + +static void x86_cpu_apic_init(X86CPU *cpu, Error **errp) +{ +static int apic_mapped; +CPUX86State *env =cpu-env; + +if (env-apic_state == NULL) { +return; +

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30 15:34, Michael S. Tsirkin wrote: Below's as far as I got - hopefully this explains what I had in mind: for deep hierarchies this will save a bus scan so I think this makes sense even in the absense of kvm irqchip.

Re: [Qemu-devel] [PATCH 25/25] Revert dt: temporarily disable subtree creation failure check

2012-05-30 Thread Andreas Färber
Am 30.05.2012 13:00, schrieb Alexander Graf: This reverts commit 417d5f1051e73db3f0d185d3be3ff3e69174893d which was meant as a temporary solution to keep external and dynamic device tree construction intact. Now that we switched to fully dynamic dt construction, it's no longer necessary.

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 16:42, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30 15:34, Michael S. Tsirkin wrote: Below's as far as I got - hopefully this explains what I had in mind: for deep hierarchies this will save a bus scan so I think this makes

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Amos Kong
- Original Message - On Wed, 30 May 2012 18:17:54 +0800 Amos Kong ak...@redhat.com wrote: On 29/05/12 21:24, Luiz Capitulino wrote: On Tue, 29 May 2012 20:17:53 +0800 Amos Kongak...@redhat.com wrote: On 05/29/2012 07:57 PM, Amos Kong wrote: On 05/25/2012 09:14 PM,

Re: [Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-30 Thread Igor Mammedov
On 05/30/2012 04:38 PM, Jan Kiszka wrote: On 2012-05-30 16:27, Igor Mammedov wrote: + +#ifndef CONFIG_USER_ONLY +#define MSI_ADDR_BASE 0xfee0 + +static void x86_cpu_apic_init(X86CPU *cpu, Error **errp) +{ +static int apic_mapped; +CPUX86State *env =cpu-env; + +if (env-apic_state

Re: [Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-30 Thread Andreas Färber
Am 30.05.2012 16:13, schrieb Igor Mammedov: On 05/30/2012 02:11 PM, Andreas Färber wrote: Am 30.05.2012 00:10, schrieb Igor Mammedov: From: Igor Mammedovniall...@gmail.com MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it

[Qemu-devel] [PATCH v4 11/23] ppc: Avoid AREG0 for MMU etc. helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Add an explicit CPUPPCState parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target |3 -

Re: [Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-30 Thread Jan Kiszka
On 2012-05-30 16:52, Igor Mammedov wrote: On 05/30/2012 04:38 PM, Jan Kiszka wrote: On 2012-05-30 16:27, Igor Mammedov wrote: + +#ifndef CONFIG_USER_ONLY +#define MSI_ADDR_BASE 0xfee0 + +static void x86_cpu_apic_init(X86CPU *cpu, Error **errp) +{ +static int apic_mapped; +

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: On 2012-05-30 16:42, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30 15:34, Michael S. Tsirkin wrote: Below's as far as I got - hopefully this explains what I had in mind: for

[Qemu-devel] [PATCH v4 22/23] ppc: Make hbrev table const

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Lookup table 'hbrev' is never written to, so add a 'const' qualifier. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/int_helper.c |2 +- 1 files

[Qemu-devel] [PATCH 09/14] vga: ppm_save(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fwrite_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Adding error handling to ppm_save() has the net effect of automatically adding error handling to all devices using ppm_save(), but note that the

[Qemu-devel] [PATCH 06/14] cutils: introduce qemu_fwrite_err()

2012-05-30 Thread Luiz Capitulino
A fwrite() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cutils.c | 15 +++ qemu-common.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/cutils.c b/cutils.c index c44ead9..646e08a 100644 --- a/cutils.c +++ b/cutils.c @@

[Qemu-devel] [PATCH 05/14] cutils: introduce qemu_fputc_err()

2012-05-30 Thread Luiz Capitulino
A fputc() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cutils.c | 12 qemu-common.h | 1 + 2 files changed, 13 insertions(+) diff --git a/cutils.c b/cutils.c index 7bbd1b7..c44ead9 100644 --- a/cutils.c +++ b/cutils.c @@

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-30 Thread Paolo Bonzini
Il 30/05/2012 14:34, Geert Jansen ha scritto: On 05/29/2012 02:52 PM, Paolo Bonzini wrote: Does the drive-mirror coroutine send the writes to the target in the same order as they are sent to the source? I assume so. No, it doesn't. It's asynchronous; for continuous replication, the

[Qemu-devel] [PATCH 11/14] g364fb: g364fb_screen_dump(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]-hw_screen_dump() with errp=NULL. The error will be

Re: [Qemu-devel] [PATCH qom-next 01/12] store prev_debug_excp_handler globaly and not per target

2012-05-30 Thread Jan Kiszka
On 2012-05-30 15:35, Igor Mammedov wrote: On 05/30/2012 12:51 PM, Jan Kiszka wrote: On 2012-05-30 00:10, Igor Mammedov wrote: current callers all do the same thing, storing in prev_debug_excp_handler previous handler and then calling it in breakpoint_handler. Move prev_debug_excp_handler from

Re: [Qemu-devel] [PATCH qom-next 11/12] target-i386: initialize APIC at CPU level

2012-05-30 Thread Igor Mammedov
On 05/30/2012 04:55 PM, Jan Kiszka wrote: On 2012-05-30 16:52, Igor Mammedov wrote: On 05/30/2012 04:38 PM, Jan Kiszka wrote: On 2012-05-30 16:27, Igor Mammedov wrote: + +#ifndef CONFIG_USER_ONLY +#define MSI_ADDR_BASE 0xfee0 + +static void x86_cpu_apic_init(X86CPU *cpu, Error **errp) +{

[Qemu-devel] [PATCH v4 10/23] ppc: Split MMU etc. helpers from op_helper.c

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Move MMU, TLB, SLB and BAT ops to mmu_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target |5 +- target-ppc/mmu_helper.c | 882

Re: [Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-30 Thread Igor Mammedov
On 05/30/2012 04:54 PM, Andreas Färber wrote: Am 30.05.2012 16:13, schrieb Igor Mammedov: On 05/30/2012 02:11 PM, Andreas Färber wrote: Am 30.05.2012 00:10, schrieb Igor Mammedov: From: Igor Mammedovniall...@gmail.com MP initialization protocol differs between cpu families, and for P6 and

Re: [Qemu-devel] [PATCH qom-next 08/12] target-i386: introduce cpu-model property for x86_cpu

2012-05-30 Thread Andreas Färber
Am 30.05.2012 00:10, schrieb Igor Mammedov: it's probably intermidiate step till cpu modeled as sub-classes. After then we probably could drop it. However it still could be used for overiding default cpu subclasses definition, and probably renamed to something like 'features'. v2: -

[Qemu-devel] [PATCH 03/14] cutils: introduce qemu_fopen_err()

2012-05-30 Thread Luiz Capitulino
A fopen() wrapper that takes an Error argument. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- cutils.c | 45 + qemu-common.h | 3 +++ 2 files changed, 48 insertions(+) diff --git a/cutils.c b/cutils.c index af308cd..85dbb06 100644

Re: [Qemu-devel] [PATCH qom-next 01/12] store prev_debug_excp_handler globaly and not per target

2012-05-30 Thread Igor Mammedov
On 05/30/2012 05:07 PM, Jan Kiszka wrote: On 2012-05-30 15:35, Igor Mammedov wrote: On 05/30/2012 12:51 PM, Jan Kiszka wrote: On 2012-05-30 00:10, Igor Mammedov wrote: current callers all do the same thing, storing in prev_debug_excp_handler previous handler and then calling it in

[Qemu-devel] [PATCH v4 14/23] ppc: Cleanup MMU merge

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Remove useless wrappers. In some cases 'int' parameters are changed to uint32_t. Make internal functions static. Signed-off-by: Blue Swirl blauwir...@gmail.com [agraf: fix kvm compilation] Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas

Re: [Qemu-devel] [PATCHv2 03/22] block: avoid buffer overrun by using pstrcpy, not strncpy

2012-05-30 Thread Stefan Weil
Am 30.05.2012 09:46, schrieb Jim Meyering: From: Jim Meyeringmeyer...@redhat.com Also, use PATH_MAX, rather than the arbitrary 1024. Using PATH_MAX is more consistent with other filename-related variables in this file, like backing_filename and tmp_filename. Acked-by: Kevin

[Qemu-devel] [PATCH v4 21/23] ppc: Add missing break

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Add obviously missing 'break' statement. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/fpu_helper.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [PATCH 07/14] omap_lcdc: rename ppm_save() to omap_ppm_save()

2012-05-30 Thread Luiz Capitulino
Avoids confusion with the global ppm_save() defined in hw/vga.c. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/omap_lcdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c index 4a08e9d..6d2e83a 100644 ---

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Jan Kiszka
On 2012-05-30 16:59, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: On 2012-05-30 16:42, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30 15:34, Michael S. Tsirkin wrote: Below's as far as I got -

[Qemu-devel] [PATCH v4 19/23] ppc: Move misc helpers from helper.c to misc_helper.c

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Move more misc helpers from helper.c to misc_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/helper.c |9 -

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-30 Thread Luiz Capitulino
On Wed, 30 May 2012 18:17:54 +0800 Amos Kong ak...@redhat.com wrote: On 29/05/12 21:24, Luiz Capitulino wrote: On Tue, 29 May 2012 20:17:53 +0800 Amos Kongak...@redhat.com wrote: On 05/29/2012 07:57 PM, Amos Kong wrote: On 05/25/2012 09:14 PM, Anthony Liguori wrote: On 05/24/2012

Re: [Qemu-devel] [PATCHv2 03/22] block: avoid buffer overrun by using pstrcpy, not strncpy

2012-05-30 Thread Jim Meyering
Stefan Weil wrote: Am 30.05.2012 09:46, schrieb Jim Meyering: From: Jim Meyeringmeyer...@redhat.com Also, use PATH_MAX, rather than the arbitrary 1024. Using PATH_MAX is more consistent with other filename-related variables in this file, like backing_filename and tmp_filename. Acked-by:

[Qemu-devel] [PATCH 13/14] tcx: tcx_screen_dump(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]-hw_screen_dump() with errp=NULL. The error will be

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Pavel Hrdina
On 05/30/2012 04:19 PM, Kevin Wolf wrote: Am 30.05.2012 12:01, schrieb Pavel Hrdina: For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need

[Qemu-devel] [PATCH v2 2/2] qmp: revert add set_echo implementation for qemu_chr_stdio

2012-05-30 Thread Pavel Hrdina
This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this code is not used in order that we use readline mode for '-qmp stdio'. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- qemu-char.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-)

[Qemu-devel] [PATCH v2 0/2] qmp: implement readline handlig for stdio

2012-05-30 Thread Pavel Hrdina
For debug it would be nice to have a same functionality for the qmp monitor on stdio as the hmp monitor on stdio has. For this purpose we also use readline mode for qmp monitor on stdio. Because we don't need anymore an echo function for stdio, there is also revert of a commit, which added this

[Qemu-devel] [PATCH 10/14] omap_lcdc: omap_ppm_save(): add error handling

2012-05-30 Thread Luiz Capitulino
This is done by using qemu_fopen_err(), qemu_fputc_err() and handling errors appropriately (eg. removing the screendump file if the operation fails). Note that the error is not passed up yet, as vga_hw_screen_dump() still calls consoles[0]-hw_screen_dump() with errp=NULL. The error will be

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-30 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Wed, May 30, 2012 at 1:01 PM, Markus Armbruster arm...@redhat.com wrote: Ordinary device models have a single state struct.  The first member is a DeviceState or a specialization of DeviceState, e.g. a PCIDevice. Simple enough. I think Evgeny's

Re: [Qemu-devel] [PATCH qom-next 07/12] target-i386: move cpu halted decision into x86_cpu_reset

2012-05-30 Thread Igor Mammedov
On 05/30/2012 02:11 PM, Andreas Färber wrote: Am 30.05.2012 00:10, schrieb Igor Mammedov: From: Igor Mammedovniall...@gmail.com MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model

[Qemu-devel] [PATCH v4 20/23] ppc: Move load and store helpers, switch to AREG0 free mode

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Add an explicit CPUPPCState parameter instead of relying on AREG0 and rename op_helper.c (which only contains load and store helpers) to mem_helper.c. Remove AREG0 swapping in tlb_fill(). Switch to AREG0 free mode. Use cpu_ld{l,uw}_code in translation and

Re: [Qemu-devel] [RFC next] ui: Split main() in two to not have Cocoa hijack it

2012-05-30 Thread Andreas Färber
Am 30.05.2012 09:11, schrieb Anthony Liguori: On 05/29/2012 02:18 AM, Andreas Färber wrote: Only call into cocoa.m when determined necessary by QEMU's option handling. Avoids redoing all option parsing in ui/cocoa.m:main() and constantly missing new options like -machine accel=qtest. Move

Re: [Qemu-devel] [PATCH 1/1] Fix strcpy calls

2012-05-30 Thread Crístian Viana
On 30-05-2012 02:41, Peter Maydell wrote: Nak. This is duplicating a much better patchset from Jim Meyering: http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg01151.html -- PMM Sorry, I hadn't seen his patchset. Is it OK for me to proceed with a similar patch regarding the function

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-30 Thread Michael S. Tsirkin
On Wed, May 30, 2012 at 05:47:45PM +0200, Jan Kiszka wrote: On 2012-05-30 16:59, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:46:14PM +0200, Jan Kiszka wrote: On 2012-05-30 16:42, Michael S. Tsirkin wrote: On Wed, May 30, 2012 at 04:38:25PM +0200, Jan Kiszka wrote: On 2012-05-30

[Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-30 Thread Igor Mammedov
without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) = object_dynamic_cast(obj, typename) = object_is_type(obj, target_type) = type_is_ancestor(obj-class-type, target_type);

Re: [Qemu-devel] [RFC next] ui: Split main() in two to not have Cocoa hijack it

2012-05-30 Thread Andreas Färber
Am 30.05.2012 11:00, schrieb Paolo Bonzini: Il 28/05/2012 20:18, Andreas Färber ha scritto: Only call into cocoa.m when determined necessary by QEMU's option handling. Avoids redoing all option parsing in ui/cocoa.m:main() and constantly missing new options like -machine accel=qtest. Move

[Qemu-devel] [PATCH v4 12/23] ppc: Avoid a warning with the next patch

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com When the code is moved together by the next patch, compiler detects a possible uninitialized variable use. Avoid the warning by initializing the variables. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-30 Thread Andreas Färber
Am 30.05.2012 18:19, schrieb Igor Mammedov: without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) = object_dynamic_cast(obj, typename) = object_is_type(obj, target_type) =

[Qemu-devel] [PATCH v4 00/23] Power Architecture AREG0 conversion, rebased

2012-05-30 Thread Andreas Färber
Hello Alex, Here's the mentioned version of your qemu.areg0 repository (considered v3), including your fixed-up version of Blue's AREG0 v2 conversion and François' ppc 440 TLB dump, rebased onto qom-next. Conflicts were removal of cpu_state_reset() and change of cpu_ppc_init() return type on

[Qemu-devel] [PATCH v4 15/23] ppc: Split off timebase helpers

2012-05-30 Thread Andreas Färber
From: Blue Swirl blauwir...@gmail.com Move decrementer and timebase helpers to a dedicated file. Signed-off-by: Blue Swirl blauwir...@gmail.com Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target |4 +

<    1   2   3   >