[Qemu-devel] [PATCH v3 3/3] i386: KVM: List -cpu host and best in -cpu ?

2012-07-09 Thread Alexander Graf
The kvm_enabled() helper doesn't work in a function as early as -cpu ? yet. It also doesn't make sense to list the -cpu ? output conditional on the -enable-kvm parameter. So let's always mention -cpu host in the CPU list when KVM is supported on that configuration. In addition, this patch also

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:06, Alexander Graf wrote: When just calling ./configure on my box, I always ran into the same issue: In file included from /usr/include/nss3/pkcs11t.h:1780, from /usr/include/nss3/keythi.h:41, from /usr/include/nss3/keyt.h:41,

Re: [Qemu-devel] [PATCH] configure: fix libsmartcard_nss compile check

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 15:29, Gerd Hoffmann wrote: On 07/09/12 14:06, Alexander Graf wrote: When just calling ./configure on my box, I always ran into the same issue: In file included from /usr/include/nss3/pkcs11t.h:1780, from /usr/include/nss3/keythi.h:41,

[Qemu-devel] [PATCH v3 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means the maximum TCG can emulate. That's a really good default when using TCG, but when running with KVM we much rather want a default saying the

[Qemu-devel] [PATCH 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And

[Qemu-devel] [PATCH] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Alexander Graf
We want all configure tests pass with -Werror if it is enabled. So we need to update QEMU_CFLAGS early on to make sure we also pass it in to all the compile test jobs. This fixes a warning-became-error bug in nss for me with the default configuration: In file included from

Re: [Qemu-devel] [PATCH] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Gerd Hoffmann
On 07/09/12 14:23, Alexander Graf wrote: We want all configure tests pass with -Werror if it is enabled. So we need to update QEMU_CFLAGS early on to make sure we also pass it in to all the compile test jobs. Much better than v1 Acked-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

[Qemu-devel] [PATCH v3 1/3] KVM: Add new -cpu best

2012-07-09 Thread Alexander Graf
During discussions on whether to support -cpu host in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can it possibly be reasonable to default to -cpu host in upstream QEMU? And

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Eric Blake
On 07/09/2012 06:10 AM, Alexander Graf wrote: This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ v2 - v3: - fix typo in commit message but not all of them :) -- Eric Blake ebl...@redhat.com

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 15:47, Eric Blake wrote: On 07/09/2012 06:10 AM, Alexander Graf wrote: This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ v2 - v3: - fix typo in commit message but not

Re: [Qemu-devel] [PATCH 2/3] KVM: Use -cpu best as default on x86

2012-07-09 Thread Eric Blake
On 07/09/2012 07:48 AM, Alexander Graf wrote: On 09.07.2012, at 15:47, Eric Blake wrote: On 07/09/2012 06:10 AM, Alexander Graf wrote: This fixes a lot of subtle breakage in the GNU toolchain (libgmp) which hicks up on QEMU's non-existent CPU models. s/hicks up/hiccups/ v2 - v3:

[Qemu-devel] [PATCH v2] configure: add -Werror to QEMU_CFLAGS early

2012-07-09 Thread Alexander Graf
We want all configure tests pass with -Werror if it is enabled. So we need to update QEMU_CFLAGS early on to make sure we also pass it in to all the compile test jobs. This fixes a warning-became-error bug in nss for me with the default configuration: In file included from

[Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Scott Wood
Recent patches PPC: e500: rename mpc8544ds into generic file, PPC: e500: split mpc8544ds machine from generic e500 code, and PPC: e500: add generic e500 platform moved certain e500-related files to the bottom of the makefile because they're now in ppc/, but the dependency on CONFIG_FDT was

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 06.07.2012 19:40, schrieb Corey Bryant: On 07/06/2012 05:11 AM, Kevin Wolf wrote: Am 05.07.2012 19:00, schrieb Eric Blake: On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount of 0; fd=4's in-use flag is turned on 2.

[Qemu-devel] [PATCH v3 0/3] Add -cpu best support

2012-07-09 Thread Alexander Graf
[resend, forgot the v3, sorry] This patch set implements support for a sane default CPU type, that plays the middle ground between -cpu host (unmanagable test matrix) and -cpu qemu64 (breaks assumptions wrt family/model numbers). It also makes it the default for -M pc, so that users who don't

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Andreas Färber
Am 09.07.2012 16:04, schrieb Scott Wood: Recent patches PPC: e500: rename mpc8544ds into generic file, PPC: e500: split mpc8544ds machine from generic e500 code, and PPC: e500: add generic e500 platform moved certain e500-related files to the bottom of the makefile because they're now in ppc/,

[Qemu-devel] [PULL 00/25] Block patches

2012-07-09 Thread Kevin Wolf
The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit bitfields (2012-07-07 09:07:01 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony MORITA Kazutaka (6): sheepdog: fix

[Qemu-devel] [PATCH 04/25] sheepdog: fix dprintf format strings

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This fixes warnings about dprintf format in debug mode. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c |8 1 files changed, 4 insertions(+), 4

[Qemu-devel] [PATCH 05/25] sheepdog: restart I/O when socket becomes ready in do_co_req()

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Currently, no one reenters the yielded coroutine. This fixes it. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c | 14 ++ 1 files changed, 14

[Qemu-devel] [PATCH 18/25] fdc: rewrite seek and DSKCHG bit handling

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina phrd...@redhat.com This bit is cleared on every successful seek to a different track (cylinder). The seek is also called on revalidate or on read/write/format commands which also clear the DSKCHG bit. Signed-off-by: Pavel Hrdina phrd...@redhat.com Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH] sheepdog: always use coroutine-based network functions

2012-07-09 Thread Kevin Wolf
Am 04.07.2012 18:41, schrieb MORITA Kazutaka: This reduces some code duplication. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH] hw/pl011.c: Avoid crash on read when no chr backend present

2012-07-09 Thread Peter Maydell
Add a missing guard that meant we would segfault if the guest read UARTDR on a PL011 serial device which had no chr backend connected. (This didn't happen for Linux guests because Linux reads the flags register and doesn't try to read the UART if it's empty.) Reported-by: Christian Müller

[Qemu-devel] [PATCH] vl.c: Don't print errno after failed qemu_chr_new()

2012-07-09 Thread Peter Maydell
The qemu_chr_new() function doesn't set errno on failure, so don't print strerror(errno) on the error handling path when dealing with the -serial, -parallel and -virtioconsole arguments. This avoids nonsensical error messages like: $ ./arm-softmmu/qemu-system-arm -serial wombat qemu: could not

[Qemu-devel] [PATCH 19/25] fdc: fix interrupt handling

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina phrd...@redhat.com If you call the SENSE INTERRUPT STATUS command while there is no interrupt waiting you get as result unknown command. Fixed status0 register handling for read/write/format commands. Signed-off-by: Pavel Hrdina phrd...@redhat.com Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH v3] sheepdog: do not blindly memset all read buffers

2012-07-09 Thread Christoph Hellwig
Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig h...@lst.de --- block/sheepdog.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) Index: qemu/block/sheepdog.c

[Qemu-devel] [PATCH 15/25] raw: hook into blkdebug

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/raw.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/raw.c b/block/raw.c index 09d9b48..ff34ea4 100644 --- a/block/raw.c

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-09 Thread Christoph Hellwig
On Mon, Jul 09, 2012 at 04:54:08PM +0800, Wenchao Xia wrote: Hi, Paolo and folks, qemu have good capabilities to access different virtual disks, I want to expose its block layer API to let 3rd party program linked in, such as management stack or block tools, to access images data directly.

Re: [Qemu-devel] CVE-2011-2212: has it been actually fixed?

2012-07-09 Thread Anthony Liguori
On 07/07/2012 08:37 AM, Michael Tokarev wrote: I come across a patch in ububtu qemu-kvm package, this: From: Nelson Elhagenelh...@ksplice.com Date: Thu, 19 May 2011 13:23:17 -0400 Subject: [PATCH] virtqueue: Sanity-check the length of indirect descriptors. We were previously allowing

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 16:36, Scott Wood wrote: On 07/09/2012 09:07 AM, Andreas Färber wrote: Am 09.07.2012 16:04, schrieb Scott Wood: Recent patches PPC: e500: rename mpc8544ds into generic file, PPC: e500: split mpc8544ds machine from generic e500 code, and PPC: e500: add generic e500 platform

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 15:26, schrieb Peter Maydell: On 9 July 2012 14:19, Andreas Färber afaer...@suse.de wrote: Am 25.06.2012 16:55, schrieb Peter Maydell: In our disassembly code, the bfd_vma type is always 64 bits, even if the target's virtual address width is only 32 bits. This means that when we

[Qemu-devel] [PATCH 12/25] blkdebug: pass getlength to underlying file

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This is required when using blkdebug with raw format. Unlike qcow2/QED, raw asks blkdebug for the length of the file, it doesn't get it from a header. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 0/3] apic: Fixes for userspace model

2012-07-09 Thread Jan Kiszka
As Avi noted recently, there is a problem in way we inject interrupts into the userspace APIC under KVM: The TRP check over the iothread may race with the VCPU raising the TPR value while in KVM mode. Patch 3 addresses this issue. The other two patches fix problems I came across while thinking

[Qemu-devel] [PATCH 1/3] apic: Resolve potential endless loop around apic_update_irq

2012-07-09 Thread Jan Kiszka
Commit d96e173769 refactored the reinjection of pending PIC interrupts. However, it missed the potential loop of apic_update_irq - apic_deliver_pic_intr - apic_local_deliver - apic_set_irq - apic_update_irq that /could/ occur if LINT0 is injected as APIC_DM_FIXED and that vector is currently

[Qemu-devel] [PATCH 2/3] apic: Reevaluate pending interrupts on LVT_LINT0 changes

2012-07-09 Thread Jan Kiszka
When the guest modifies the LVT_LINT0 register, we need to check if some pending PIC interrupt can now be delivered. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/apic.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/apic.c b/hw/apic.c

[Qemu-devel] [PATCH 3/3] apic: Defer interrupt updates to VCPU thread

2012-07-09 Thread Jan Kiszka
KVM performs TPR raising asynchronously to QEMU, specifically outside QEMU's global lock. When an interrupt is injected into the APIC and TPR is checked to decide if this can be delivered, a stale TPR value may be used, causing spurious interrupts in the end. Fix this by deferring apic_update_irq

[Qemu-devel] [PATCH 17/25] block: introduce bdrv_swap, implement bdrv_append on top of it

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com The new function can be made a bit nicer than bdrv_append. It swaps the whole contents, and then swaps back (using the usual t=a;a=b;b=t idiom) the fields that need to stay on top. Thus, it does not need explicit bdrv_detach_dev, bdrv_iostatus_disable,

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance info block to display host cache setting

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 23:07, schrieb Eric Blake: On 06/15/2012 02:47 PM, Supriya Kannery wrote: Enhance info block to display hostcache setting for each block device. ## { 'type': 'BlockInfo', 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', - 'locked': 'bool',

[Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing is still in block.c. To be

Re: [Qemu-devel] [v1 Patch 2/10]Qemu: Error classes for hostcache setting and data sync failures

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: New error classes defined for hostcache setting and data sync error Signed-off-by: Supriya Kannery supri...@linux.vnet.ibm.com --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd block_set_hostcache for dynamic cache change

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: New command block_set_hostcache added for dynamically changing host pagecache setting of a block device. Usage: block_set_hostcache device option device = block device option = on/off Example: (qemu) block_set_hostcache ide0-hd0

[Qemu-devel] [PATCH v2] console: Implementing blinking of cursor

2012-07-09 Thread Jan Kiszka
Let the text console cursor blink at 2 HZ. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Changes in v2: - fixed semantic of CONSOLE_CURSOR_PERIOD and reduced frequency I know there was a concern regarding the approach in general, but I still consider it useful and visually more

[Qemu-devel] [PATCH 24/25] qtest: Tidy up temporary files properly

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com Each test litters /tmp with several files: a pid file and two sockets. Tidy up. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/libqtest.c | 29 - 1 files changed, 16

[Qemu-devel] [PATCH 07/25] sheepdog: make sure we don't free aiocb before sending all requests

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This patch increments the pending counter before sending requests, and make sures that aiocb is not freed while sending them. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 08/25] sheepdog: split outstanding list into inflight and pending

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp outstanding_list_head is used for both pending and inflight requests. This patch splits it and improves readability. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c |

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Anthony Liguori
On 07/09/2012 09:16 AM, Kevin Wolf wrote: From: Markus Armbrusterarm...@redhat.com Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk

[Qemu-devel] [PATCH 20/25] fdc_test: update media_change test

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina phrd...@redhat.com After rewrite DSKCHG bit handling the test has to be updated. Now is needed to seek to different track to clear DSKCHG bit. Signed-off-by: Pavel Hrdina phrd...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/fdc-test.c | 25

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 10:05 AM, Luiz Capitulino wrote: On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey

Re: [Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely

2012-07-09 Thread Kevin Wolf
Am 15.06.2012 22:47, schrieb Supriya Kannery: Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya Kannery

[Qemu-devel] [PATCH 03/25] blockdev: warn when copy_on_read=on and readonly=on

2012-07-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com If the image is read-only then it's not possible to copy read data into it. Therefore copy-on-read is automatically disabled for read-only images. Up until now this behavior was silent, add a warning so the user knows why copy-on-read is not

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 17:01, schrieb Anthony Liguori: On 07/09/2012 09:16 AM, Kevin Wolf wrote: From: Markus Armbrusterarm...@redhat.com Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific functionality should be kept in device

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 10:04 AM, Kevin Wolf wrote: Am 06.07.2012 19:40, schrieb Corey Bryant: On 07/06/2012 05:11 AM, Kevin Wolf wrote: Am 05.07.2012 19:00, schrieb Eric Blake: On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount

[Qemu-devel] [PATCH 14/25] blkdebug: optionally tie errors to a specific sector

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This makes blkdebug scripts more powerful, and independent of the exact sequence of operations performed by streaming. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 26

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Scott Wood
On 07/09/2012 09:07 AM, Andreas Färber wrote: Am 09.07.2012 16:04, schrieb Scott Wood: Recent patches PPC: e500: rename mpc8544ds into generic file, PPC: e500: split mpc8544ds machine from generic e500 code, and PPC: e500: add generic e500 platform moved certain e500-related files to the

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 17:23, schrieb Corey Bryant: I think it would cause fds to sit on the monitor until refcount gets to zero (monitor disconnects). Here's an example without the in-use flag: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount of 1 (incremented because of

[Qemu-devel] [PATCH 10/25] blkdebug: remove sync i/o events

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com These are unused, except (by mistake more or less) in QED. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.h |2 -- block/blkdebug.c |2 -- block/qed.c |2 +- 3 files changed,

[Qemu-devel] [PATCH 11/25] blkdebug: tiny cleanup

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1eff940..1f79ef2

[Qemu-devel] [PATCH 4/4] slirp: Improve error reporting of inaccessible smb directories

2012-07-09 Thread Jan Kiszka
Instead of guessing, print the error code returned by access. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- net/slirp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index eb80889..b82eab0 100644 --- a/net/slirp.c +++ b/net/slirp.c

[Qemu-devel] [PATCH 3/4] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-09 Thread Jan Kiszka
From: Dunrong Huang riegama...@gmail.com Users may pass the following parameters to qemu: $ qemu-kvm -net nic -net user,smb= ... $ qemu-kvm -net nic -net user,smb ... $ qemu-kvm -net nic -net user,smb=bad_directory ... In these cases, qemu started successfully while samba server

[Qemu-devel] [PATCH 2/4] slirp: add 'cmd:' target for guestfwd

2012-07-09 Thread Jan Kiszka
From: Alexander Graf ag...@suse.de When using guestfwd=, Qemu only connects the virtual server's TCP port to a single chardev. This is useless in most cases, as we usually want to have more than a single connection from the guest to the outside world. This patch adds a new cmd: target to

[Qemu-devel] [PATCH 1/4] slirp: Enforce host-side user of smb share

2012-07-09 Thread Jan Kiszka
Windows 7 (and possibly other versions) cannot connect to the samba share if the exported host directory is not world-readable. This can be resolved by forcing the username used for access checks to the one under which QEMU and smbd are running. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] [PATCH 0/4] [PULL] slirp: smb fixes and cmd: target for guestfwd

2012-07-09 Thread Jan Kiszka
The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit bitfields (2012-07-07 09:07:01 +) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Alexander Graf (1): slirp: add 'cmd:'

[Qemu-devel] [PATCH 25/25] block: Factor bdrv_read_unthrottled() out of guess_disk_lchs()

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com To prepare move of guess_disk_lchs() into hw/, where it poking BlockDriverState member io_limits_enabled directly would be unclean. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 24

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Anthony Liguori
On 07/09/2012 10:24 AM, Kevin Wolf wrote: Am 09.07.2012 17:01, schrieb Anthony Liguori: On 07/09/2012 09:16 AM, Kevin Wolf wrote: From: Markus Armbrusterarm...@redhat.com Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific

[Qemu-devel] [PATCH 02/25] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails

2012-07-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com When qcow2_alloc_clusters() error handling code was introduced in commit 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset was clobbered in the error case. This patch keeps free_byte_offset at 0 so we will try to allocate

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Kevin Wolf
Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am working from. Please let me know if you still see any issues. FD passing: ---

[Qemu-devel] [PATCH 21/25] fdc_test: introduce test_sense_interrupt

2012-07-09 Thread Kevin Wolf
From: Pavel Hrdina phrd...@redhat.com Calling sense interrupt status while there is no interrupt should return invalid command (0x80). Read command should always returns in st0 seek_end bit set to 1. Signed-off-by: Pavel Hrdina phrd...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 01/25] qcow2: fix #ifdef'd qcow2_check_refcounts() callers

2012-07-09 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The DEBUG_ALLOC qcow2.h macro enables additional consistency checks throughout the code. This makes it easier to spot corruptions that are introduced during development. Since consistency check is an expensive operation the DEBUG_ALLOC macro is

[Qemu-devel] [PATCH 22/25] fdc: Drop broken code for user-defined floppy geometry

2012-07-09 Thread Kevin Wolf
From: Markus Armbruster arm...@redhat.com bdrv_get_floppy_geometry_hint() fails to store through its parameter drive when bs has a geometry hint. Makes fd_revalidate() assign random crap to drv-drive. Has been broken that way for ages. Harmless, because: * The only way to set a geometry hint

[Qemu-devel] [PATCH 09/25] sheepdog: traverse pending_list from the first for each time

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp The pending list can be modified in other coroutine context sd_co_rw_vector, so we need to traverse the list from the first again after we send the pending request. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by:

[Qemu-devel] [PATCH 13/25] blkdebug: store list of active rules

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This prepares for the next patch, where some active rules may actually not trigger depending on input to readv/writev. Store the active rules in a SIMPLEQ (so that it can be emptied easily with QSIMPLEQ_INIT), and fetch the errno/once/immediately arguments

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.07.2012 17:01, schrieb Anthony Liguori: On 07/09/2012 09:16 AM, Kevin Wolf wrote: From: Markus Armbrusterarm...@redhat.com Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific

[Qemu-devel] [PATCH 16/25] block: copy over job and dirty bitmap fields in bdrv_append

2012-07-09 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com While these should not be in use at the time a transaction is started, a command in the prepare phase of a transaction might have added them, so they need to be brought over. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 06/25] sheepdog: use coroutine based socket functions in coroutine context

2012-07-09 Thread Kevin Wolf
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp This removes blocking network I/Os in coroutine context. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Kevin Wolf kw...@redhat.com --- block/sheepdog.c | 10 -- 1 files changed, 8 insertions(+), 2

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 17:46:00 +0200 Kevin Wolf kw...@redhat.com wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am working from.

Re: [Qemu-devel] [PATCH] PPC: e500: reconditionalize on CONFIG_FDT

2012-07-09 Thread Alexander Graf
On 09.07.2012, at 16:04, Scott Wood wrote: Recent patches PPC: e500: rename mpc8544ds into generic file, PPC: e500: split mpc8544ds machine from generic e500 code, and PPC: e500: add generic e500 platform moved certain e500-related files to the bottom of the makefile because they're now in

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Eric Blake
On 07/09/2012 10:07 AM, Markus Armbruster wrote: This is an unconditional use of fd_type[0]. If floppy == NULL, this is dereferencing an uninitialized value. I'm not sure why the explicit initialization was removed... Brain fart on my part, sorry. The old loop assigns only if the drive

Re: [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02

2012-07-09 Thread Anthony Liguori
On 07/02/2012 04:41 AM, Paolo Bonzini wrote: Anthony, The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: bsd-user: fix build (2012-06-28 20:28:36 +) Pulled. Thanks. Regards, Anthony Liguori are available in the git repository at:

Re: [Qemu-devel] [PULL 0/9] usb patch queue

2012-07-09 Thread Anthony Liguori
On 07/09/2012 05:20 AM, Gerd Hoffmann wrote: Hi, Here comes the most recent usb patch queue, featuring a collection of little bug fixes all over the place. See individual patches for details. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd The following changes since

Re: [Qemu-devel] [PULL 00/25] Block patches

2012-07-09 Thread Anthony Liguori
On 07/09/2012 09:16 AM, Kevin Wolf wrote: The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit bitfields (2012-07-07 09:07:01 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-09 Thread Richard W.M. Jones
On Thu, Jul 05, 2012 at 02:32:44PM +0100, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com glibc 2.16 will remove the undocumented definition of 'struct siginfo' from bits/siginfo.h. This change is already present in glibc 2.15.90, so qemu compilation of certain

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-09 Thread Peter Maydell
On 9 July 2012 17:50, Richard W.M. Jones rjo...@redhat.com wrote: On Thu, Jul 05, 2012 at 02:32:44PM +0100, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com glibc 2.16 will remove the undocumented definition of 'struct siginfo' from bits/siginfo.h. This change is already

Re: [Qemu-devel] [PULL 0/3] Trivial patches for June 22 to 2 July 2012

2012-07-09 Thread Anthony Liguori
On 07/02/2012 04:36 AM, Stefan Hajnoczi wrote: I will be away from 3 - 11 July. Here is the current trivial-patches queue. Pulled. Thanks. Regards, Anthony Liguoriggg The following changes since commit 71ea2e016131a9fcde6f1ffd3e0e34a64c21f593: bsd-user: fix build (2012-06-28

Re: [Qemu-devel] [PATCH 23/25] fdc: Move floppy geometry guessing back from block.c

2012-07-09 Thread Anthony Liguori
On 07/09/2012 11:46 AM, Eric Blake wrote: On 07/09/2012 10:07 AM, Markus Armbruster wrote: This is an unconditional use of fd_type[0]. If floppy == NULL, this is dereferencing an uninitialized value. I'm not sure why the explicit initialization was removed... Brain fart on my part, sorry.

Re: [Qemu-devel] [PATCH] place qemu-sockets.c contributions since 2012-01-13 under GPLv2+

2012-07-09 Thread Stefan Weil
Am 09.07.2012 11:08, schrieb Paolo Bonzini: Past contributions since 2012-01-13 were only made by Red Hat people, so they are already available under GPLv2+. Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- qemu-sockets.c |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Qemu-devel] [PULL] iov* function rework (one more time)

2012-07-09 Thread Michael Tokarev
Ping? Another month has passed without any reply... Thanks, /mjt On 11.06.2012 23:19, Michael Tokarev wrote: On 11.06.2012 22:31, Anthony Liguori wrote: [] Doesn't build: LINK qemu-ga cutils.o: In function `qemu_iovec_to_buf': /home/anthony/git/qemu/cutils.c:226: undefined reference

Re: [Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-07-09 Thread Stefan Weil
Am 09.07.2012 10:27, schrieb Daniel Berrange: On Sun, Jul 08, 2012 at 11:45:34PM +0100, Peter Maydell wrote: On 8 July 2012 20:44, Michael Tokarev1022...@bugs.launchpad.net wrote: Please take this to your shell. The queston mark is a metacharacter for any *nix shell, you should just quote or

Re: [Qemu-devel] [PULL v2 00/13] Migration tree

2012-07-09 Thread Anthony Liguori
On 06/29/2012 07:06 AM, Juan Quintela wrote: Hi v2: - Change Migration params from int to bool (Orit) - Change %ld to %PRIu64 (Blue found it) - cc Anthony O:-) Atacched the interdiff, it is trivial, instead of repost all patches (changes are really trivial). Anthony, please pull. Pulled.

Re: [Qemu-devel] [PATCH 0/4] [PULL] slirp: smb fixes and cmd: target for guestfwd

2012-07-09 Thread Anthony Liguori
On 07/09/2012 10:44 AM, Jan Kiszka wrote: The following changes since commit 84988cf910a6881f2180fdcec516b60f8f0dc8c4: bitops.h: Add functions to extract and deposit bitfields (2012-07-07 09:07:01 +) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste the current design that I am working from. Please let me know if you still see

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Luiz Capitulino
On Mon, 09 Jul 2012 13:35:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so

Re: [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and image file reopen

2012-07-09 Thread Stefan Weil
Am 15.06.2012 22:46, schrieb Supriya Kannery: For changing host pagecache setting of a running VM, it is important to have a safe way of reopening its image file. Hello, please use 'QEMU' instead of 'Qemu' where needed. I assume that everybody here expects that any patch on this mailing

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 12:18 PM, Luiz Capitulino wrote: On Mon, 09 Jul 2012 17:46:00 +0200 Kevin Wolf kw...@redhat.com wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have changed a bit as the email threads evolved, so I'll paste

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 01:48 PM, Luiz Capitulino wrote: On Mon, 09 Jul 2012 13:35:19 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/09/2012 11:46 AM, Kevin Wolf wrote: Am 09.07.2012 17:05, schrieb Corey Bryant: I'm not sure this is an issue with current design. I know things have

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-09 Thread Corey Bryant
On 07/09/2012 11:05 AM, Corey Bryant wrote: On 07/09/2012 10:05 AM, Luiz Capitulino wrote: On Thu, 05 Jul 2012 11:06:56 -0400 Corey Bryant cor...@linux.vnet.ibm.com wrote: On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric

[Qemu-devel] [PATCH v16 0/9] XBZRLE delta for live migration of large memory app

2012-07-09 Thread Orit Wasserman
Changes from v15: - Fix example in documentation - Fix identation in qmp-commands.hx - Fix missing comments from v13 - Fix other comments by Eric Blake Changes from v14: - rebase on top on Juan's patches - Use clz64 to calculate pow2floor (round

[Qemu-devel] [PATCH v16 4/9] Add uleb encoding/decoding functions

2012-07-09 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman owass...@redhat.com --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index 02d5bd0..7d99fe0

[Qemu-devel] [PATCH v16 1/9] Add migration capabilities

2012-07-09 Thread Orit Wasserman
Add migration capabilities that can be queried by the management. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The management can enable a capability for the next migration by using

[Qemu-devel] [PATCH v16 5/9] Change ram_save_block to return -1 if there are no more changes

2012-07-09 Thread Orit Wasserman
It will return 0 if the page is unmodifed. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9fd6346..e36899e 100644 --- a/arch_init.c +++ b/arch_init.c @@ -188,7

[Qemu-devel] [PATCH v16 3/9] Add cache handling functions

2012-07-09 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by: Orit Wasserman owass...@redhat.com --- Makefile.objs

<    1   2   3   >