[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-07-11 Thread M. Mohan Kumar
Georg, pass-through security model needs root privilege, if you want to run qemu as non-root user either you have to use mapped security model or proxy fs driver. But libvirt does not have support for proxy FS driver. I posted a patch few months ago to libvirt for enabling the same. I will do the

Re: [Qemu-devel] [PATCH 1/5] qemu-option: add alias support

2012-07-11 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: It allows for specifying an alias for each option name, see next commits examples. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c | 9 - qemu-option.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 1/5] qdev: introduce qdev_create_kid(Object *parent, const char *type)

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 03:17, liu ping fan ha scritto: OK, I will move the creation in the CPU. But I think as part of qom, DeviceState can have a DeviceState child, so there is need for wrapper for the function. Maybe just make the qdev_create_kid(Object*) - qdev_create_kid(DeviceState*) ? You can

Re: [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 03:17, liu ping fan ha scritto: It really looks like time is ripe to make CPUs children of Device, so you can just use qdev_reset_all to reset the CPU. Change CPUState as child of Device? It is cool, but I think it will a huge work with argue. Luckily other people (Igor,

Re: [Qemu-devel] [PATCH 0/5]: rename machine options to use dashes

2012-07-11 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Today, machine options use underscores to separate words (eg. kernel_irqchip), however upcoming QOM conversion wants to use dashes instead. Command line users will appreciate consistent use of '-', too. This series converts all machine type

[Qemu-devel] [Bug 602336] Re: bad network performance with 10Gbit

2012-07-11 Thread Ken Sharp
Have you tried compiling the latest upstream version to see if this is still an issue? ** Changed in: qemu Status: New = Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/602336

Re: [Qemu-devel] Disk geometry and migration

2012-07-11 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Tue, Jul 10, 2012 at 6:34 PM, Markus Armbruster arm...@redhat.com wrote: Scenario: 1. Start a guest with a blank disk (need not be the only disk) and default disk geometry. 2. Examine the disk's physical geometry Details depend on the

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-11 Thread liu ping fan
On Mon, Jul 9, 2012 at 8:57 PM, Andreas Färber afaer...@suse.de wrote: Am 09.07.2012 12:59, schrieb igor: On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov: It's not correct to make CPU runnable (i.e. calling x86_cpu_realize()) when not all properties

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-11 Thread liu ping fan
On Tue, Jul 10, 2012 at 9:35 PM, Igor Mammedov imamm...@redhat.com wrote: On 07/09/2012 02:57 PM, Andreas Färber wrote: Am 09.07.2012 12:59, schrieb igor: On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov: It's not correct to make CPU runnable (i.e.

Re: [Qemu-devel] [PATCH 0/5]: rename machine options to use dashes

2012-07-11 Thread Markus Armbruster
A quick git-grep for more instances of '_' in option parameter names finds only vcard_emul_options(). Yet another ad hoc option argument parser. I'm not asking you to do anything about it.

Re: [Qemu-devel] Disk geometry and migration

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 09:16, Markus Armbruster ha scritto: C. Do not derive default geometry from DOS partition table Can do only for new machine type, because it may break guests. It will indeed break boot of old images (e.g. FreeDOS). Hence: C1. Do not derive default geometry from DOS partition

Re: [Qemu-devel] [PATCH 5/5] apic: create apic as a child of cpu, not system_bus any longer

2012-07-11 Thread Igor Mammedov
On 07/10/2012 12:41 PM, Andreas Färber wrote: Am 10.07.2012 10:45, schrieb Paolo Bonzini: Il 10/07/2012 08:16, Liu Ping Fan ha scritto: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/pc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
On 07/10/2012 07:29 PM, Andreas Färber wrote: Am 10.07.2012 12:43, schrieb Fabien Chouteau: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile |2 +- configure |8

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: hardware random number generator device

2012-07-11 Thread Dor Laor
On 07/06/2012 03:06 PM, Amit Shah wrote: On (Tue) 26 Jun 2012 [08:01:20], Anthony Liguori wrote: On 06/26/2012 05:48 AM, Amit Shah wrote: On (Mon) 25 Jun 2012 [17:59:28], Anthony Liguori wrote: On 06/25/2012 05:46 PM, Anthony Liguori wrote: From: Amit Shahamit.s...@redhat.com diff

Re: [Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-07-11 Thread Dor Laor
On 06/19/2012 08:22 PM, Michael Roth wrote: On Tue, Jun 19, 2012 at 11:34:42PM +0900, Takuya Yoshikawa wrote: On Tue, 19 Jun 2012 09:01:36 -0500 Anthony Liguori anth...@codemonkey.ws wrote: I'm not at all convinced that postcopy is a good idea. There needs a clear expression of what the

[Qemu-devel] [PATCH 0/2] Exynos4210 RTC

2012-07-11 Thread Oleg Ogurtsov
Patches fixed calculationg for value of year and remove unnecessary code. Oleg Ogurtsov (2): hw/exynos4210_rtc.c: Fix calculating for value of year hw/exynos4210_rtc.c: remove unnecessary code hw/exynos4210_rtc.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) -- 1.7.5.4

[Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year

2012-07-11 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov o.ogurt...@samsung.com --- hw/exynos4210_rtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index f781020..b42586e 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos4210_rtc.c @@ -142,7 +142,7 @@

[Qemu-devel] [PATCH V2] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile |2 +- configure | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile

Re: [Qemu-devel] [PATCH V2] Add --disable-bridge-helper configure flag

2012-07-11 Thread Peter Maydell
On 11 July 2012 11:09, Fabien Chouteau chout...@adacore.com wrote: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. This is still the wrong approach -- you need to be testing for presence of the ioctls and disabling the bridge helper if

[Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-11 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov o.ogurt...@samsung.com --- hw/exynos4210_rtc.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index b42586e..42a4ddc 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos4210_rtc.c @@ -510,10 +510,7

Re: [Qemu-devel] [PATCH qom-next 06/59] pc: Pass X86CPU to cpu_is_bsp()

2012-07-11 Thread Igor Mammedov
On 05/23/2012 05:07 AM, Andreas Färber wrote: Also change return type to bool. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/apic.h|2 +- hw/apic_common.c |2 +- hw/pc.c |6 +++--- target-i386/helper.c |2 +- target-i386/kvm.c|4

[Qemu-devel] [PATCH] fix info qtree indention

2012-07-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qdev-monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 7915b45..2053c4a 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -545,7 +545,7 @@ static void

[Qemu-devel] [RFC PATCH v2 01/21][SeaBIOS] Add ACPI_EXTRACT_DEVICE* macros

2012-07-11 Thread Vasilis Liaskovitis
This allows to extract the beginning, end and name of a Device object. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- tools/acpi_extract.py | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/tools/acpi_extract.py

[Qemu-devel] [RFC PATCH v2 07/21] acpi_piix4: Implement memory device hotplug registers

2012-07-11 Thread Vasilis Liaskovitis
A 32-byte register is used to present up to 256 hotplug-able memory devices to BIOS and OSPM. Hot-add and hot-remove functions trigger an ACPI hotplug event through these. Only reads are allowed from these registers. An ACPI hot-remove event but needs to wait for OSPM to eject the device. We use

[Qemu-devel] [RFC PATCH v2 17/21][SeaBIOS] acpi_dsdt: Revert internal dimm state on _OST failure

2012-07-11 Thread Vasilis Liaskovitis
This reverts bitmap state in the case of a failed hot operation, in order to allow retry of failed hot operations Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices

2012-07-11 Thread Wen Congyang
At 07/11/2012 06:31 PM, Vasilis Liaskovitis Wrote: The memory device generation is guided by qemu paravirt info. Seabios first uses the info to setup SRAT entries for the hotplug-able memory slots. Afterwards, build_memssdt uses the created SRAT entries to generate appropriate memory device

Re: [Qemu-devel] [PATCH qom-next 05/59] apic: Replace cpu_env pointer by X86CPU link

2012-07-11 Thread Igor Mammedov
On 05/23/2012 05:07 AM, Andreas Färber wrote: Needed for converting cpu_is_bsp(). Signed-off-by: Andreas Färber afaer...@suse.de Cc: Paolo Bonzini pbonz...@redhat.com --- ... @@ -899,7 +900,13 @@ static DeviceState *apic_init(void *env, uint8_t apic_id) }

[Qemu-devel] [RFC PATCH v2 08/21] pc: calculate dimm physical addresses and adjust memory map

2012-07-11 Thread Vasilis Liaskovitis
Dimm physical address offsets are calculated automatically and memory map is adjusted accordingly. If a DIMM can fit before the PCI_HOLE_START (currently 0xe000), it will be added normally, otherwise its physical address will be above 4GB. Signed-off-by: Vasilis Liaskovitis

[Qemu-devel] [RFC PATCH v2 12/21] fix live-migration when populated=on is missing

2012-07-11 Thread Vasilis Liaskovitis
Live migration works after memory hot-add events, as long as the qemu command line -dimm arguments are changed on the destination host to specify populated=on for the dimms that have been hot-added. If a command-line change has not occured, the destination host does not yet have the corresponding

[Qemu-devel] [RFC PATCH v2 09/21] pc: Add dimm paravirt SRAT info

2012-07-11 Thread Vasilis Liaskovitis
The numa_fw_cfg paravirt interface is extended to include SRAT information for all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, denoting start address, size and node proximity. The new info is appended after existing numa info, so that the fw_cfg layout does not break.

[Qemu-devel] [PATCH v2] fix info qtree indention

2012-07-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qdev-monitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 7915b45..e7d2804 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -543,7 +543,7 @@ static void

[Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Vasilis Liaskovitis
Implement batch dimm creation command line options. These could be useful for not bloating the command line with a large number of dimms. syntax: -dimms pfx=poolid,size=sz,num=n Will create numdimms dimms with ids poolid0, ..., poolidn-1. Each dimm has a size of sz. Implement -dimmpop option

[Qemu-devel] [RFC PATCH v2 04/21][SeaBIOS] acpi: generate hotplug memory devices

2012-07-11 Thread Vasilis Liaskovitis
The memory device generation is guided by qemu paravirt info. Seabios first uses the info to setup SRAT entries for the hotplug-able memory slots. Afterwards, build_memssdt uses the created SRAT entries to generate appropriate memory device objects. One memory device (and corresponding SRAT entry)

[Qemu-devel] [RFC PATCH v2 06/21] dimm: Implement memory device abstraction

2012-07-11 Thread Vasilis Liaskovitis
Each hotplug-able memory slot is a SysBusDevice. A hot-add operation for a particular dimm creates a new MemoryRegion of the given physical address offset, size and node proximity, and attaches it to main system memory as a sub_region. A hot-remove operation detaches and frees the MemoryRegion

[Qemu-devel] [RFC PATCH v2 21/21] Implement mem_increase, mem_decrease hmp/qmp commands

2012-07-11 Thread Vasilis Liaskovitis
This implements batch monitor operations for hot-add and hot-remove. These are probably better suited for a higher-level management layer, but are useful for testing. Let me know if there is interest for such commands upstream. syntax: mem_increase poolid num will hotplug num dimms from pool

[Qemu-devel] [PATCH] megasas: Replace trace_megasas_dcmd_dump_frame()

2012-07-11 Thread Hannes Reinecke
trace_megasas_dcmd_dump_frame() takes 9 arguments, which is rather much. Plus the trace infrastructure doesn't support it anymore. As we can get the information via other means it's pointless to have it in the driver, so rather use some proper trace point here and remove the old one.

[Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value

2012-07-11 Thread Vasilis Liaskovitis
In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe000). Otherwise, the guest cannot online new dimms at those ranges due to pci_root window conflicts. (workaround for linux guest is booting with pci=nocrs) Signed-off-by:

[Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Avi Kivity
Current qemu-kvm master merged with latest upstream fails on startup: (gdb) bt #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at /home/tlv/akivity/qemu/kvm-all.c:1602 #1 0x7fdcd49c9fda in kvm_apic_enable_tpr_reporting (s=0x7fdcd75af6c0, enable=false) at

[Qemu-devel] [RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-07-11 Thread Vasilis Liaskovitis
Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 70

[Qemu-devel] [RFC PATCH v2 16/21] acpi_piix4: Update dimm state on VM reboot

2012-07-11 Thread Vasilis Liaskovitis
in case of hot-remove or hot-add failure, the dimm bitmaps in qemu and Seabios are inconsistent with the true state of the DIMM devices. The populated field of the DimmState reflects the true state of the device. This inconsistency means that a failed operation cannot be retried. Ths patch

[Qemu-devel] [RFC PATCH v2 19/21] Implement info memtotal and query-memtotal

2012-07-11 Thread Vasilis Liaskovitis
Returns total memory of guest in bytes, including hotplugged memory. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx |2 ++ hmp.c|7 +++ hmp.h|1 + hw/dimm.c| 15 +++ monitor.c|

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Jan Kiszka
On 2012-07-11 13:46, Avi Kivity wrote: Current qemu-kvm master merged with latest upstream fails on startup: (gdb) bt #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at /home/tlv/akivity/qemu/kvm-all.c:1602 #1 0x7fdcd49c9fda in kvm_apic_enable_tpr_reporting

Re: [Qemu-devel] [RFC PATCH v2 05/21][SeaBIOS] pciinit: Fix pcimem_start value

2012-07-11 Thread Gerd Hoffmann
On 07/11/12 12:31, Vasilis Liaskovitis wrote: In order to hotplug memory between RamSize and BUILD_PCIMEM_START, the pci window needs to start at BUILD_PCIMEM_START (0xe000). Otherwise, the guest cannot online new dimms at those ranges due to pci_root window conflicts. (workaround for

Re: [Qemu-devel] [libvirt] Problem setting CPU topology

2012-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2012 at 09:19:37PM -0500, Doug Goldstein wrote: On Tue, Jul 10, 2012 at 2:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Jul 10, 2012 at 11:54:05AM +0200, Christophe Fergeau wrote: On Sat, Jul 07, 2012 at 07:10:53PM +0300, Zeeshan Ali (Khattak) wrote: Hi,

[Qemu-devel] [RFC PATCH v2 18/21] acpi_piix4: Update dimm bitmap state on hot-remove fail

2012-07-11 Thread Vasilis Liaskovitis
This allows failed hot operations to be retried at anytime. This only works for guests that use _OST notification. Other guests cannot retry failed hot operations on same devices until after reboot. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hw/acpi_piix4.c |

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Jan Kiszka
On 2012-07-11 13:58, Avi Kivity wrote: On 07/11/2012 02:55 PM, Jan Kiszka wrote: On 2012-07-11 13:46, Avi Kivity wrote: Current qemu-kvm master merged with latest upstream fails on startup: (gdb) bt #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Avi Kivity
On 07/11/2012 02:59 PM, Jan Kiszka wrote: I will try to reproduce. Is there a tree of the merge available? I just merged upstream into qemu-kvm master. For some reason there were no conflicts. A rare moment, I guess. ;) I'll put it down to random chance until we can figure out who's

[Qemu-devel] [RFC PATCH v2 10/21] Implement -dimm command line option

2012-07-11 Thread Vasilis Liaskovitis
Syntax: -dimm id=name,size=sz,node=pxm,populated=on|off The starting physical address for all dimms is calculated automatically from top of memory, skipping the pci hole at [PCI_HOLE_START, 4G). populated=on means the dimm is populated at machine startup. Default is off. node is defining numa

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Avi Kivity
On 07/11/2012 03:04 PM, Avi Kivity wrote: specific command line or guest? qemu-system-x86_64 Just did the same, but it's all fine here. Ok, I'll debug it. Probably something stupid like a miscompile. Indeed, a simple clean build fixed it up. Paolo, it looks like autodependencies are

[Qemu-devel] [RFC PATCH v2 02/21][SeaBIOS] Add SSDT memory device support

2012-07-11 Thread Vasilis Liaskovitis
Define SSDT hotplug-able memory devices in _SB namespace. The dynamically generated SSDT includes per memory device hotplug methods. These methods just call methods defined in the DSDT. Also dynamically generate a MTFY method and a MEON array of the online/available memory devices. ACPI

[Qemu-devel] [RFC PATCH v2 11/21] Implement dimm_add and dimm_del hmp/qmp commands

2012-07-11 Thread Vasilis Liaskovitis
Hot-add hmp syntax: dimm_add dimmid Hot-remove hmp syntax: dimm_del dimmid Respective qmp commands are dimm-add, dimm-del. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- hmp-commands.hx | 32 monitor.c | 11 +++

[Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Vasilis Liaskovitis
Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. This patch implements a tail queue to store guest notifications for memory hot-add and hot-remove requests. Guest responses for memory hotplug command on a per-dimm basis can be detected with the new hmp command info memhp or

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Avi Kivity
On 07/11/2012 02:55 PM, Jan Kiszka wrote: On 2012-07-11 13:46, Avi Kivity wrote: Current qemu-kvm master merged with latest upstream fails on startup: (gdb) bt #0 0x7fdcd4a047a0 in kvm_vcpu_ioctl (env=0x0, type=-1071075694) at /home/tlv/akivity/qemu/kvm-all.c:1602 #1

[Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-11 Thread Vasilis Liaskovitis
This is v2 of the ACPI memory hotplug prototype for x86_64 target. Changes v1-v2 - memory map is automatically calculated for hotplug dimms. Dimms are added from top-of-memory skipping the pci hole at [PCI_HOLE_START, 4G). - Renamed from -memslot to -dimm. Commands changed to dimm_add,

[Qemu-devel] [RFC PATCH v2 14/21][SeaBIOS] acpi_dsdt: Support _OST dimm method

2012-07-11 Thread Vasilis Liaskovitis
Add support for _OST method. _OST method will write into the correct I/O byte to signal success / failure of hot-add or hot-remove to qemu. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com --- src/acpi-dsdt.dsl | 46 ++

[Qemu-devel] [RFC PATCH v2 15/21] acpi_piix4: _OST dimm support

2012-07-11 Thread Vasilis Liaskovitis
This allows qemu to receive notifications from the guest OS on success or failure of a memory hotplug request. The guest OS needs to implement the _OST functionality for this to work (linux-next: http://lkml.org/lkml/2012/6/25/321) Also add new _OST registers in docs/specs/acpi_hotplug.txt

Re: [Qemu-devel] [PATCH 3/5] target-i386: call x86_cpu_realize() after APIC is initialized.

2012-07-11 Thread Igor Mammedov
On 07/11/2012 09:35 AM, liu ping fan wrote: On Tue, Jul 10, 2012 at 9:35 PM, Igor Mammedov imamm...@redhat.com wrote: On 07/09/2012 02:57 PM, Andreas Färber wrote: Am 09.07.2012 12:59, schrieb igor: On 06/20/2012 03:35 PM, Andreas Färber wrote: Am 20.06.2012 14:59, schrieb Igor Mammedov:

Re: [Qemu-devel] [PATCH 4/5] qom-cpu: during cpu reset, it will reset its child

2012-07-11 Thread Igor Mammedov
On 07/11/2012 03:17 AM, liu ping fan wrote: On Tue, Jul 10, 2012 at 6:12 PM, Andreas Färber afaer...@suse.de wrote: Am 10.07.2012 10:41, schrieb Paolo Bonzini: Il 10/07/2012 08:16, Liu Ping Fan ha scritto: This will give the embeded logic module, such as apic has the opportunity to reset.

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Kevin Wolf
Am 11.07.2012 07:25, schrieb Michael Tokarev: On 11.07.2012 09:09, Stefan Weil wrote: Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) because it partially replaced ret by count. It also changed the handling of EINTR in a wrong way. The patch restores the old code for

Re: [Qemu-devel] Segfault starting vcpu thread

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 14:08, Avi Kivity ha scritto: specific command line or guest? qemu-system-x86_64 Just did the same, but it's all fine here. Ok, I'll debug it. Probably something stupid like a miscompile. Indeed, a simple clean build fixed it up. Paolo, it looks like

Re: [Qemu-devel] [PATCH v2 1/3] bitops: fix types

2012-07-11 Thread Kevin Wolf
Am 08.07.2012 21:22, schrieb blauwir...@gmail.com: From: Blue Swirl blauwir...@gmail.com Use 'unsigned int' for bit numbers instead of 'unsigned long' or 'int'. Adjust asserts. Signed-off-by: Blue Swirl blauwir...@gmail.com I haven't followed the original discussion and therefore don't

Re: [Qemu-devel] [PATCH 1/5] qemu-option: add alias support

2012-07-11 Thread Luiz Capitulino
On Wed, 11 Jul 2012 09:00:59 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: It allows for specifying an alias for each option name, see next commits examples. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c |

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Kevin Wolf
Am 08.07.2012 14:09, schrieb Andreas Schwab: blauwir...@gmail.com writes: +pstrcpy(bs-backing_format, sizeof(bs-backing_format), +backing_fmt ? backing_file : ); s/backing_file/backing_fmt/ Which is why such changes are probably a bad idea. Even more so if they aren't

Re: [Qemu-devel] [PATCH v4] sheepdog: do not blindly memset all read buffers

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 20:06, schrieb MORITA Kazutaka: At Tue, 10 Jul 2012 16:12:27 +0200, Christoph Hellwig wrote: Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig h...@lst.de --- block/sheepdog.c | 37 ++--- 1

[Qemu-devel] [PATCH 3/4] blockdev: Don't limit DriveInfo serial to 20 characters

2012-07-11 Thread Markus Armbruster
All current users (IDE, SCSI and virtio-blk) happen to share this 20 characters limit. Still, it should be left to device models. They already enforce their limits. They have to, as the DriveInfo limit only affects legacy -drive serial=..., not the qdev properties. usb-storage, which doesn't

[Qemu-devel] [PATCH 0/4] Cleanups around hw/block-common.h

2012-07-11 Thread Markus Armbruster
Applies on top of [PATCH v3 00/29] Disk geometry cleanup. Markus Armbruster (4): hw/block-common: Move BlockConf friends from block.h hw/block-common: Factor out fall back to legacy -drive serial=... blockdev: Don't limit DriveInfo serial to 20 characters hw/block-common: Factor out fall

[Qemu-devel] [PATCH 1/4] hw/block-common: Move BlockConf friends from block.h

2012-07-11 Thread Markus Armbruster
This stuff doesn't belong to block layer, and was put there only because a better home didn't exist then. Now it does. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.h | 45 - hw/block-common.h | 45

[Qemu-devel] [PATCH 2/4] hw/block-common: Factor out fall back to legacy -drive serial=...

2012-07-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/Makefile.objs |2 +- hw/block-common.c| 24 hw/block-common.h|3 +++ hw/ide/qdev.c| 12 ++-- hw/scsi-disk.c |8 +--- hw/usb/dev-storage.c | 10 ++

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Peter Maydell
On 11 July 2012 13:54, Kevin Wolf kw...@redhat.com wrote: Does this patch improve anything? Last time I checked, qemu only compiled on gcc anyway. It would be nice to be able to compile with LLVM/Clang; however since Clang supports the ?: gcc extension this patch doesn't move us any further in

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-11 Thread Wei-Ren Chen
On Wed, Jul 11, 2012 at 02:09:53PM +0100, Peter Maydell wrote: On 11 July 2012 13:54, Kevin Wolf kw...@redhat.com wrote: Does this patch improve anything? Last time I checked, qemu only compiled on gcc anyway. It would be nice to be able to compile with LLVM/Clang; however since Clang

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 14:39, Kevin Wolf ha scritto: Am 11.07.2012 07:25, schrieb Michael Tokarev: On 11.07.2012 09:09, Stefan Weil wrote: Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) because it partially replaced ret by count. It also changed the handling of EINTR in a wrong

[Qemu-devel] [PATCH 4/4] hw/block-common: Factor out fall back to legacy -drive cyls=...

2012-07-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block-common.c | 40 hw/block-common.h |2 ++ hw/ide/core.c | 24 hw/ide/qdev.c | 19 ++- hw/scsi-disk.c| 31

Re: [Qemu-devel] [PATCH] iov: Fix do_send_recv() for MinGW (also fixes a build breakage)

2012-07-11 Thread Anthony Liguori
On 07/11/2012 08:15 AM, Paolo Bonzini wrote: Il 11/07/2012 14:39, Kevin Wolf ha scritto: Am 11.07.2012 07:25, schrieb Michael Tokarev: On 11.07.2012 09:09, Stefan Weil wrote: Commit 25e5e4c7 broke compilation for non POSIX hosts (e.g. MinGW) because it partially replaced ret by count. It

Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 11:12, schrieb Markus Armbruster: Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to hw/hd-geometry.c, and make stylistic changes required

[Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Jing Huang
This patch fix ping issues for linux-user guest. * The do_setsockopts function in linux-user does not support SOL_RAW socket which is used in ping net tool. * The recvmsg in main_loop of ping could not fetch sockaddr_in struct. That is because do_sendrecvmsg in linux-user does not pass the

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance info block to display host cache setting

2012-07-11 Thread Luiz Capitulino
On Mon, 09 Jul 2012 16:43:40 +0200 Kevin Wolf kw...@redhat.com wrote: Am 15.06.2012 23:07, schrieb Eric Blake: On 06/15/2012 02:47 PM, Supriya Kannery wrote: Enhance info block to display hostcache setting for each block device. ## { 'type': 'BlockInfo', 'data': {'device':

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-11 Thread Avi Kivity
On 07/06/2012 08:11 AM, Markus Armbruster wrote: It seems there could be more knobs to control than just dump guest state yes/no. Therefore, extensible command line syntax like --core-dump guest-ram=off seems to be advisable. We have too many -dont-do-FOO options already. -m 2T,dump=no ?

[Qemu-devel] [PATCH V3] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau chout...@adacore.com --- Makefile |2 +- configure | 42 ++ 2 files changed, 43 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd block_set_hostcache for dynamic cache change

2012-07-11 Thread Luiz Capitulino
On Sat, 16 Jun 2012 02:17:30 +0530 Supriya Kannery supri...@linux.vnet.ibm.com wrote: New command block_set_hostcache added for dynamically changing host pagecache setting of a block device. Usage: block_set_hostcache device option device = block device option = on/off

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/10/2012 09:37 AM, Fabien Chouteau wrote: On 07/10/2012 01:06 PM, Paolo Bonzini wrote: Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we

Re: [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c

2012-07-11 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 10.07.2012 11:12, schrieb Markus Armbruster: Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to

[Qemu-devel] [PATCH 0/2] build: get all *.d files

2012-07-11 Thread Paolo Bonzini
Avi and Jan experienced more problem with dependencies. This series should fix them. Paolo Bonzini (2): build: include qapi-generated/ files in qga/Makefile.objs build: get dependency file directories from object file names build: do not use hw/kvm/ Makefile |4 ++--

[Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Paolo Bonzini
No reason to leave them out, and it will ensure that the dependencies are picked up. Later we can perhaps move the files to another directory to avoid ../ usage. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile |2 +- qga/Makefile.objs |2 ++ 2 files changed, 3

[Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names

2012-07-11 Thread Paolo Bonzini
After commit dcff25f2cd8c11a9368cc2369aeb0319c32d9e26, Dependency file are taken from the directories that have a Makefile.objs file. This is not enough, since files can be included from other directories. So, pick them from directories that have an object file in them. Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Peter Maydell
Thanks for this patch. Review comments below... (cc'ing the linux-user maintainer) On 11 July 2012 14:56, Jing Huang jing.huang@gmail.com wrote: This patch fix ping issues for linux-user guest. * The do_setsockopts function in linux-user does not support SOL_RAW socket which is used in

Re: [Qemu-devel] [RFC PATCH v2 20/21] Implement -dimms, -dimmspop command line options

2012-07-11 Thread Avi Kivity
On 07/11/2012 01:32 PM, Vasilis Liaskovitis wrote: Implement batch dimm creation command line options. These could be useful for not bloating the command line with a large number of dimms. IMO this is unneeded. With a management tool there is no problem generating a long command line; from the

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
On 07/11/2012 04:22 PM, Corey Bryant wrote: On 07/10/2012 09:37 AM, Fabien Chouteau wrote: On 07/10/2012 01:06 PM, Paolo Bonzini wrote: Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build.

Re: [Qemu-devel] [RFC PATCH v2 13/21] Implement memory hotplug notification lists

2012-07-11 Thread Eric Blake
On 07/11/2012 04:31 AM, Vasilis Liaskovitis wrote: Guest can respond to ACPI hotplug events e.g. with _EJ or _OST method. This patch implements a tail queue to store guest notifications for memory hot-add and hot-remove requests. Guest responses for memory hotplug command on a per-dimm basis

Re: [Qemu-devel] [PATCH] Fix ping issue for linux-user guest

2012-07-11 Thread Dunrong Huang
2012/7/11 Jing Huang jing.huang@gmail.com: This patch fix ping issues for linux-user guest. * The do_setsockopts function in linux-user does not support SOL_RAW socket which is used in ping net tool. * The recvmsg in main_loop of ping could not fetch sockaddr_in struct. That is because

Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement info memtotal and query-memtotal

2012-07-11 Thread Eric Blake
On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote: Returns total memory of guest in bytes, including hotplugged memory. Signed-off-by: Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com Should this instead be merged with query-balloon output, so that we have a single command that shows

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 16:56, Fabien Chouteau ha scritto: So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were inclined to do so... Unfortunately I don't have time to go deep into the code. It's not a feature I plan to use, so the quickest solution for me is to disable it.

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Michael Roth
On Wed, Jul 11, 2012 at 04:40:20PM +0200, Paolo Bonzini wrote: No reason to leave them out, and it will ensure that the dependencies are picked up. Later we can perhaps move the files to another directory to avoid ../ usage. Couldn't we accomplish that by just adding the dependencies to

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 17:25, Michael Roth ha scritto: No reason to leave them out, and it will ensure that the dependencies are picked up. Later we can perhaps move the files to another directory to avoid ../ usage. Couldn't we accomplish that by just adding the dependencies to qga-obj-y in the

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/11/2012 10:57 AM, Paolo Bonzini wrote: Il 11/07/2012 16:56, Fabien Chouteau ha scritto: So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were inclined to do so... Unfortunately I don't have time to go deep into the code. It's not a feature I plan to use, so the

Re: [Qemu-devel] [PATCH v3 00/29] Disk geometry cleanup

2012-07-11 Thread Kevin Wolf
Am 10.07.2012 11:12, schrieb Markus Armbruster: 29 patches may look discouraging, but most patches are small, and the ones that aren't just move code around. Goals of this series: 1. One more step towards a clean separation block device host and guest part. 2. Purge CHS geometry

Re: [Qemu-devel] [RFC PATCH 01/36] qapi: generalize documentation of streaming commands

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 18:45, Eric Blake ha scritto: Pre-existing, but do we have any policy on US (canceled) vs. UK (cancelled) spelling? Obviously, our API spelling is locked into UK spelling, but if the docs generally prefer US spelling, do we need to adjust things here? But any such adjustments

Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs

2012-07-11 Thread Michael Roth
On Wed, Jul 11, 2012 at 05:28:26PM +0200, Paolo Bonzini wrote: Il 11/07/2012 17:25, Michael Roth ha scritto: No reason to leave them out, and it will ensure that the dependencies are picked up. Later we can perhaps move the files to another directory to avoid ../ usage. Couldn't we

Re: [Qemu-devel] [RFC PATCH 06/36] qmp: add block-job-pause and block-job-resume

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:32, Eric Blake ha scritto: Just so I'm clear, am I right that: calling block-job-pause multiple times means the subsequent calls are successful no-ops; likewise, calling block-job-resume on a job not paused (whether by calling multiple times, or if the job never paused in

Re: [Qemu-devel] [RFC PATCH 12/36] block: sort BlockDeviceIoStatus errors by severity

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:45, Eric Blake ha scritto: +++ b/qapi-schema.json @@ -429,7 +429,7 @@ # # Since: 1.0 ## -{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ] } +{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'nospace', 'failed' ] } Isn't this an ABI change?

Re: [Qemu-devel] [RFC PATCH 13/36] block: introduce block job error

2012-07-11 Thread Paolo Bonzini
Il 15/06/2012 19:50, Eric Blake ha scritto: { 'type': 'BlockJobInfo', 'data': {'type': 'str', 'device': 'str', 'len': 'int', - 'offset': 'int', 'paused': 'bool', 'speed': 'int'} } + 'offset': 'int', 'paused': 'bool', 'speed': 'int', + 'io-status':

  1   2   >