On 27 July 2012 16:31, Anthony Liguori wrote:
> Peter Maydell writes:
>> My approach to this is to avoid non-standard things
>
> http://en.wikipedia.org/wiki/C99#Implementations
>
> So unless you plan on compiling QEMU with xlc, pgi, or icc, I don't
> think relying on "standard things" really hel
Luiz Capitulino writes:
> On Thu, 26 Jul 2012 19:09:13 +0200
> Markus Armbruster wrote:
>
>> Support escaping the escape character, and make more robust (don't die
>> for '', handle ' without matching '.
>>
>> Signed-off-by: Markus Armbruster
>
> Can you please do you it on top of master so th
Blue Swirl writes:
> On Wed, Jul 25, 2012 at 11:49 AM, Markus Armbruster wrote:
>> Asking for "funny" memory sizes sometimes crashes for me. For instance
>> -m 0.8 or the equivalent -m 838860b. -m 0.7 appears to work.
>>
>> Should we round memory sizes? How? Where?
>
> We had a discussion ab
Matthew Ogilvie writes:
> I've recently been trying to get an ancient version of UNIX
> I used to use working in qemu:
>
> Micoport UNIX System V/386, v 2.1 (ca 1987).
>
> I used this from about 1987 until about 1996, when I first
> got Linux.
[...]
> I've also noticed some other problems tha
Anthony Liguori writes:
> Blue Swirl writes:
>
>> On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori wrote:
>>> If someone comes along and actively maintains support for another
>>> compiler, we can revisit. But otherwise, there's no practical reason to
>>> avoid extensions.
Exactly.
>> Becaus
On Fri, Jul 27, 2012 at 06:44:04PM +, Blue Swirl wrote:
> > +struct GlusterOpts {
>
> static
Sure.
>
> > +bool optional;
> > +char defval[10];
>
> const char *defval?
Sure I could.
>
> > +char *value;
> > +} GlusterOpts[] = {
> > +{false, "", NULL },
> > +{false, "",
On 28/07/12 05:22, Blue Swirl wrote:
On Wed, Jul 25, 2012 at 5:03 PM, Alex Williamson
+
+static void vfio_enable_intx_kvm(VFIODevice *vdev)
+{
+#ifdef CONFIG_KVM
These shouldn't be needed. The device will not be useful without KVM,
so the file shouldn't be compiled for non-KVM case at all.
I
The START STOP UNIT command will only eject/load media if
power condition is zero.
If power condition is !0 then LOEJ and START will be ignored.
>From MMC (sbc contains similar wordings too)
The Power Conditions field requests the block device to be placed
in the power condition defined in
Paolo, List
Please find a trivial fix for the STARTSTOPUNIT emulation.
This command will only eject/load media if powercondition is 0.
With this patch, QEMU SCSI emulation now pass all my SSU tests :
$ ./bin/iscsi-test --dataloss --test="*startstop*"
iscsi://127.0.0.1:32601/iqn.qemu.scsi-test/3
This patch updates the iscsi layer to automatically pick a
'unique' initiator-name based on the name of the vm in case the user
has not set an explicit iqn-name to use.
Save the -name of the vm so that we can use it in the default iscsi name.
Add a new variable that holds the name for the vm as s
List,
Please find a patch that updates the iSCSI block driver to automatically
generate a 'unique' initiator-name based on the name given to the virtual
machine.
Normally users will always have to set the initiator-name properly since LUN
masking on the iscsi targets would almost always requir
qerror_abort() depends on the 'file', 'func' and 'linenr' members of
QError. However, these members are going to be dropped by the next
commit, so let's drop qerror_abort() in favor of printing an error
message to stderr plus an abort() call.
Signed-off-by: Luiz Capitulino
---
qerror.c | 65
Several block/ files are relying on qerror.h being provided by
qapi-types.h. However, qapi-types.h won't provide it anymore.
Signed-off-by: Luiz Capitulino
---
block_int.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/block_int.h b/block_int.h
index d72317f..00892e8 100644
--- a/block_int.
In the old QMP days, this code was used to find out QMP commands that
might be calling monitor_printf() down its call chain.
This is almost impossible to happen today, because the qapi converted
commands don't even have a monitor object. Besides, it's been more than
a year since I used this last t
IMPORTANT: this commit BREAKS QMP's compatibility for the error response.
This commit changes QMP's wire protocol to make use of the simpler
error format introduced by previous commits.
There are two important (and mostly incompatible) changes:
1. Almost all error classes have been replaced by
Blue Swirl writes:
> On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori wrote:
>> If someone comes along and actively maintains support for another
>> compiler, we can revisit. But otherwise, there's no practical reason to
>> avoid extensions.
>
> Because it's more compliant to standards.
That i
A future commit will add a new qapi script which escapes that character.
Signed-off-by: Luiz Capitulino
---
scripts/qapi.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index e062336..9aa518f 100644
--- a/scripts/qapi.py
+++ b/scripts/q
hmp.h is relying on qdict.h being provided by qapi-types.h. However,
qapi-types.h won't provide it anymore.
Signed-off-by: Luiz Capitulino
---
hmp.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/hmp.h b/hmp.h
index 8d2b0d7..3275522 100644
--- a/hmp.h
+++ b/hmp.h
@@ -16,6 +16,7 @@
#inclu
The new argument is added to functions qerror_report(), error_set()
and error_is_type(). qerror_report_err() is also updated to take
care of it.
However, the new argument is not used yet. It's only stored in
Error and QError.
The QERR_ macros are also changed to contain an ErrorClass value.
Thus,
Use the 'device' passed by the user and call qmp_query_block() to
get the 'filename' info.
error_get_field() is going to be dropped by a future commit.
Signed-off-by: Luiz Capitulino
---
hmp.c | 37 -
1 file changed, 28 insertions(+), 9 deletions(-)
diff --g
Actually, renames it to 'object'. This must be what the original author
meant to write, as there's no 'object' in the error's data member.
Signed-off-by: Luiz Capitulino
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qerror.c b/qerror.c
index 92c4eff..082de98 10
This commit replaces the place holder value for the ErrorClass
argument being passed to all current error calls to the real
ErrorClass value.
That is, all current errors are mapped to GenericError, except the
following errors: CommandNotFound, DeviceNotActive, DeviceNotFound,
KVMMissingCap, Migrat
It's going to be dropped.
Signed-off-by: Luiz Capitulino
---
error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/error.c b/error.c
index acb10a2..cdeeafe 100644
--- a/error.c
+++ b/error.c
@@ -113,7 +113,7 @@ bool error_is_type(Error *err, const char *fmt)
end = strc
They have never been fully used and conflict with future error related
improvements.
Signed-off-by: Luiz Capitulino
---
qerror.c | 20 +++-
qerror.h | 8 +---
2 files changed, 4 insertions(+), 24 deletions(-)
diff --git a/qerror.c b/qerror.c
index 59025ea..f55a652 100644
--
They not used anymore.
Signed-off-by: Luiz Capitulino
---
qerror.c | 404 ---
qerror.h | 1 -
2 files changed, 405 deletions(-)
diff --git a/qerror.c b/qerror.c
index f443261..e1606d3 100644
--- a/qerror.c
+++ b/qerror.c
@@ -23,315 +
Today, the error message is only constructed when it's used. This commit
changes that to construct the error message when the error object is
built (ie. when the error is reported).
This simplifies the Error object.
Signed-off-by: Luiz Capitulino
---
error.c | 8 +---
qerror.c | 4 +---
2
Simplifies current and future users.
Signed-off-by: Luiz Capitulino
---
error.c | 5 +
qerror.c | 10 --
qerror.h | 2 +-
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/error.c b/error.c
index a52b771..b630b05 100644
--- a/error.c
+++ b/error.c
@@ -64,10 +64,7 @@
Today, hmp_cont() checks for QERR_DEVICE_ENCRYPTED in order to know
if qmp_cont() failed due to an encrypted device. If it did,
hmp_cont() accesses QERR_DEVICE_ENCRYPTED's data member 'device' to
precisely know for which device an encryption key must be set.
However, all errors data members are go
Today, the error message is only constructed when it's used. This commit
changes that to construct the error message when the error object is
built (ie. when the error is reported).
This eliminates the need of storing a pointer to qerror_table[], which
will be dropped soon, and also simplifies the
That's, generate ERROR_CLASS_GENERIC_ERROR instead of
ERROR_CLASS_GENERICERROR.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 3ed9f04..9b7da96 100644
--
Make functions only used in qerror.c static.
Signed-off-by: Luiz Capitulino
---
qerror.c | 10 +-
qerror.h | 5 -
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/qerror.c b/qerror.c
index b2ed0e3..ce0499b 100644
--- a/qerror.c
+++ b/qerror.c
@@ -336,7 +336,7 @@ stati
Next commit will introduce enum strings in camel case.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 9b7da96..cf601ae 100644
--- a/scripts/qapi-types.py
+++ b/script
They are not used anymore and all current errors' data are going to
be dropped.
Signed-off-by: Luiz Capitulino
---
error.c | 23 ---
error.h | 10 --
error_int.h | 1 -
3 files changed, 34 deletions(-)
diff --git a/error.c b/error.c
index cdeeafe..b9d9b64 10
FIXME: broke error_is_type() and qemu-ga.
Signed-off-by: Luiz Capitulino
---
error.c | 5 ++-
qerror.c | 44 ++--
qerror.h | 143 +++
3 files changed, 77 insertions(+), 115 deletions(-)
diff --git a/error.c b/error.
Signed-off-by: Luiz Capitulino
---
block.c | 1 +
qapi-schema.json | 7 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index ce7eb8f..b230f16 100644
--- a/block.c
+++ b/block.c
@@ -2445,6 +2445,7 @@ BlockInfoList *qmp_query_block(Error **errp)
This allows for changing QERR_ macros to initialize two struct members
at the same time. See next commit for more details.
Signed-off-by: Luiz Capitulino
---
qerror.c | 280 +++
qerror.h | 2 +-
2 files changed, 141 insertions(+), 141
Signed-off-by: Luiz Capitulino
---
qapi-schema.json | 26 ++
1 file changed, 26 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index 7500754..b1325c4 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3,6 +3,32 @@
# QAPI Schema
##
+# @ErrorClass
qapi-types.h needs only qemu-common.h. Including qapi-types-core.h
causes problems when qerror.h or error.h includes qapi-types.h.
Signed-off-by: Luiz Capitulino
---
scripts/qapi-types.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-t
Signed-off-by: Luiz Capitulino
---
qerror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qerror.c b/qerror.c
index 082de98..b2ed0e3 100644
--- a/qerror.c
+++ b/qerror.c
@@ -81,7 +81,7 @@ static const QErrorStringTable qerror_table[] = {
},
{
.error_fmt =
[Please, read below why this is an RFC]
This series implements the 'Plan for error handling in QMP' as described
by Anthony in this email:
http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg03764.html
Basically, this replaces almost all error classes by GenericError (the
exception are a
On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori wrote:
> Blue Swirl writes:
>
>> On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori wrote:
>>> Peter Maydell writes:
>>>
On 27 July 2012 15:27, Anthony Liguori wrote:
> Peter Maydell writes:
>> The GCC manual says "Weak symbols are s
On Fri, 27 Jul 2012, Matthew Ogilvie wrote:
> Microport UNIX System V/386 v 2.1 (ca 1987) uses mod R/M bytes for
> the control register mov instructions where the mod bits are 0,
> even though the 80386 spec claims they are "always" 1's. The fact
> that it ran at all clearly indicates the real ch
Blue Swirl writes:
> On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori wrote:
>> Peter Maydell writes:
>>
>>> On 27 July 2012 15:27, Anthony Liguori wrote:
Peter Maydell writes:
> The GCC manual says "Weak symbols are supported for ELF targets,
> and also for a.out targets when us
On Mon, Jul 23, 2012 at 2:29 AM, wrote:
> are available in the git repository at:
>
> git://github.com/gxt/QEMU.git unicore32
I'm getting these errors, please fix:
CClibhw64/hw/puv3_gpio.o
/src/qemu/hw/puv3_gpio.c: In function 'puv3_gpio_read':
/src/qemu/hw/puv3_gpio.c:48:5: error: 'ret
Hello folks,
The RFC-v5 patch for tcm_vhost kernel code was sent out for review a bit
less than 24 hours ago, and thus far there has not been any additional
comments.. Thanks to everyone who has been participating in the various
threads over the past week and giving their feedback!
Also, just a
On Fri, 2012-07-27 at 19:22 +, Blue Swirl wrote:
> On Wed, Jul 25, 2012 at 5:03 PM, Alex Williamson
> > diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
> > new file mode 100644
> > index 000..e9ae421
> > --- /dev/null
> > +++ b/hw/vfio_pci.c
> > @@ -0,0 +1,2030 @@
> > +/*
> > + * vfio based devi
Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly
restricting SD card address range. Change address argument type to uint64_t.
Signed-off-by: Igor Mitsyanko
---
hw/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index 57
Microport UNIX System V/386 v 2.1 (ca 1987) uses mod R/M bytes for
the control register mov instructions where the mod bits are 0,
even though the 80386 spec claims they are "always" 1's. The fact
that it ran at all clearly indicates the real chips (at least 386
and 486) just ignores the bits and
Hi Stefan,
I'm assigning this bug to you to get your input about which package I
need to target it to. It's invalid (I believe) for qemu-kvm. We need
server cloud guests to have pci_hotplog auto-loaded at boot (to avoid
this bug). Should I assign to package linux for that?
--
You received thi
pci_hotplog actually is available, at least on precise. But it is not
loaded (acpiphp is).
After I modprobe pci_hotplug, the problem goes away. Thanks wangpan.
** Changed in: qemu-kvm (Ubuntu)
Assignee: (unassigned) => Stefan Bader (stefan-bader-canonical)
--
You received this bug notifi
Background:
I don't really think it is appropriate to include this patch in it's
current form, but I'm posting it to illustrate some of the obscure
things that Microport UNIX System V/386 v 2.1 (ca 1987) is trying
to do to the video card.
On real hardware, this version of UNIX c
Signed-off-by: Matthew Ogilvie
---
hw/cirrus_vga.c | 4 ++--
hw/ide/cmd646.c | 5 +++--
hw/ide/via.c| 5 +++--
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 623dd68..24ddea6 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2055,8
I've recently been trying to get an ancient version of UNIX
I used to use working in qemu:
Micoport UNIX System V/386, v 2.1 (ca 1987).
I used this from about 1987 until about 1996, when I first
got Linux.
With a couple of small patches, I can get qemu to boot and run UNIX
from the first ins
*** This bug is a duplicate of bug 989452 ***
https://bugs.launchpad.net/bugs/989452
Hi,
How do you turning off gssapi-auth ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/988291
Title:
virsh
Several members of SDState have type int when they actually are binary
variables.
Change type of these variables to bool to improve code readability. Change SD
API
to be in consistency with new variables type.
Signed-off-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
---
hw/sd.c | 24 +++
Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use
block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32
and CMD33, we have to account for this.
Signed-off-by: Igor Mitsyanko
---
hw/sd.c |6 --
1 files changed, 4 insertions(+), 2 d
Setting "drive" SD card property ties SD card with BlockDriverState of the
same name. This property can be set dynamically, allowing for SD card
hot-insert.
With "drive" property we no longer need SDClass::init method, all work is
done in property setter.
Signed-off-by: Igor Mitsyanko
Cc: Paolo
v3->v4
PATCH11: "spi" property now can be set until SD card is not attached to
BlockDriverState,
not when card in idle state;
PATCH12: "device-id" property renamed to "drive", few code movements;
PATCH13 droped, its functionality is available in BlockDriverState;
v2->v3
Patchset modified in such
For the sake of code clarity
Signed-off-by: Igor Mitsyanko
---
hw/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index a51d18d..20ebd8e 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -544,7 +544,7 @@ static void sd_function_switch(SDState *sd, uint32_t ar
Representing each group write protection flag with only one bit instead of int
variable significantly reduces memory consumption.
Signed-off-by: Igor Mitsyanko
---
hw/sd.c | 33 +++--
1 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
Rather that repeatedly call SD_GET_CLASS() in a loop, call it once before
a loop starts.
Signed-off-by: Igor Mitsyanko
---
hw/omap_mmc.c|9 +
hw/pl181.c |7 ---
hw/pxa2xx_mmci.c |6 --
3 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/hw/omap_m
Add wrapper function sd_addr_to_wpnum() to replace long address-->wg_group
conversion line.
Signed-off-by: Igor Mitsyanko
---
hw/sd.c | 27 +--
1 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index e24d04a..d0674d5 100644
--- a/hw/sd.c
This patch updates SD card model to support save/load of card's state.
Signed-off-by: Igor Mitsyanko
---
hw/sd.c | 88 +-
1 files changed, 64 insertions(+), 24 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index 20ebd8e..f8ab045 100644
And drop passing is_spi argument to SDCardClass::init function.
"spi" property could be set only while SD card object is not
attached to any BlockDriverState.
It defaults to "false".
Signed-off-by: Igor Mitsyanko
Cc: Paul Brook
---
hw/sd.c | 33 +++--
hw/sd.h |
For the sake of code clarity
Signed-off-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
---
hw/sd.c |2 +-
hw/sd.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index d4a8927..a51d18d 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -1705,7 +1705,7 @@ uint8_
Public bug reported:
After running "make clean" qemu won't build with -j option.
When I run "./configure && make clean" and then make -j5, following errors
occur:
GEN config-host.h
GEN trace.h
GEN qemu-options.def
GEN qmp-commands.h
GEN qapi-types.h
GEN qapi-visit.h
GEN
A straightforward conversion of SD card implementation to a proper QEMU object.
Wrapper functions were introduced for SDClass methods in order to avoid SD card
users modification. Because of this, name change for several functions in
hw/sd.c
was required.
Signed-off-by: Igor Mitsyanko
---
hw/sd
On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori wrote:
> Peter Maydell writes:
>
>> On 27 July 2012 15:27, Anthony Liguori wrote:
>>> Peter Maydell writes:
The GCC manual says "Weak symbols are supported for ELF targets,
and also for a.out targets when using the GNU assembler and lin
For the cloud-images specifically, this problem was solved once before in bug
450463. our cloud-images have the following in their /etc/modules:
# /etc/modules: kernel modules to load at boot time.
#
# This file contains the names of kernel modules that should be loaded
# at boot time, one per li
On Thu, Jul 26, 2012 at 4:49 AM, Amos Kong wrote:
> Event would be ignored if ps2 queue is full, this patch
> added a warning in ignore path.
>
> Signed-off-by: Amos Kong
> ---
> hw/ps2.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ps2.c b/hw/ps2.c
> index
Il 27/07/2012 15:58, Anthony Liguori ha scritto:
>> Note that if you want to test this feature, you must use a qcow2
>> version 3 file. To create that, do:
>>
>> qemu-img create -f qcow2 -o compat=1.1
>>
>> Ordinary qcow2 (v2) and raw do NOT know how to treat zero blocks
>> specially, so you w
On Wed, Jul 25, 2012 at 11:49 AM, Markus Armbruster wrote:
> Asking for "funny" memory sizes sometimes crashes for me. For instance
> -m 0.8 or the equivalent -m 838860b. -m 0.7 appears to work.
>
> Should we round memory sizes? How? Where?
We had a discussion about this recently:
http://list
On Wed, Jul 25, 2012 at 8:15 AM, Masami Hiramatsu
wrote:
> (2012/07/25 5:26), Blue Swirl wrote:>
>>> The following patch set provides a low-overhead system for collecting kernel
>>> tracing data of guests by a host in a virtualization environment.
>>>
>>> A guest OS generally shares some devices w
On Wed, Jul 25, 2012 at 6:00 AM, Bharata B Rao
wrote:
> block: Support GlusterFS as a QEMU block backend.
>
> From: Bharata B Rao
>
> This patch adds gluster as the new block backend in QEMU. This gives
> QEMU the ability to boot VM images from gluster volumes. Its already
> possible to boot from
On 07/27/2012 07:37 AM, Anthony Liguori wrote:
> This command attempts to map to the behavior of -cpu ?. Unfortunately, the
> output of this command differs wildly across targets.
>
> To accomodate this, we use a weak symbol to implement a default version of the
s/accomodate/accommodate/
> comm
On 07/27/2012 12:12 PM, Anthony Liguori wrote:
> Eric Blake writes:
>>> +# @name: the name of the machine
>>> +#
>>> +# @alias: #optional an alias for the machine name
>>
>> Can a machine have more than one alias?
>
> No, it can't. Really, alias is only used to map 'pc' -> 'pc-1.1'. It's
> nev
Eric Blake writes:
> On 07/27/2012 07:37 AM, Anthony Liguori wrote:
>> This provides the same output as -M ? but in a structured way.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> qapi-schema.json | 28
>> qmp-commands.hx |6 ++
>> vl.c |
Acked-by: Edgar E. Iglesias
Im currently traveling but can apply when Im back.
Thanks
Edgar
---
Sent from my phone
On Jul 26, 2012 2:29 PM, "Andreas Färber" wrote:
> It's a ppc440, so place it close to Bamboo.
>
> Signed-off-by: Andreas Färber
> Cc: Alexander Graf
> Cc: Edgar E. Iglesias
>
On 27 July 2012 18:16, Rob Landley wrote:
> On 07/27/2012 09:32 AM, Peter Maydell wrote:
>> On 27 July 2012 14:45, Rob Landley wrote:
>>> I.E. sci_getreg(port, SCFCR) move to before checking whether or not
>>> we'll ever possibly use the result. SCFCR is 0x18 and QEMU calls abort()
>>> on an atte
On 07/27/2012 07:37 AM, Anthony Liguori wrote:
> This provides the same output as -M ? but in a structured way.
>
> Signed-off-by: Anthony Liguori
> ---
> qapi-schema.json | 28
> qmp-commands.hx |6 ++
> vl.c | 31 +++
"Daniel P. Berrange" writes:
> On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote:
>> "Daniel P. Berrange" writes:
>> > The above would take care of probably 50% of the current libvirt
>> > capabilities probing, including a portion of the -help stuff. Then
>> > there is all the re
On 07/27/2012 09:32 AM, Peter Maydell wrote:
> On 27 July 2012 14:45, Rob Landley wrote:
>> I.E. sci_getreg(port, SCFCR) move to before checking whether or not
>> we'll ever possibly use the result. SCFCR is 0x18 and QEMU calls abort()
>> on an attempt to read from an unimplemented register.
>>
>>
Am 12.06.2012 10:24, schrieb Andreas Färber:
> Am 29.05.2012 15:35, schrieb Stefano Stabellini:
>> qemu_rearm_alarm_timer partially duplicates the code in
>> qemu_next_alarm_deadline to figure out if it needs to rearm the timer.
>> If it calls qemu_next_alarm_deadline, it always rearms the timer ev
On Fri, Jul 27, 2012 at 01:21:01PM -0300, Luiz Capitulino wrote:
> On Fri, 27 Jul 2012 08:37:12 -0500
> Anthony Liguori wrote:
>
> > This series implements the necessary commands to implements danpb's idea to
> > remove -help parsing in libvirt. We would introduce all of these commands
> > in
>
On Fri, Jul 27, 2012 at 01:23:03PM +0200, Markus Armbruster wrote:
> "Daniel P. Berrange" writes:
> > The above would take care of probably 50% of the current libvirt
> > capabilities probing, including a portion of the -help stuff. Then
> > there is all the rest of the crap we detect from the -he
From: Hannes Reinecke
trace_megasas_dcmd_dump_frame() takes 9 arguments, which is
rather much. Plus the trace infrastructure doesn't support
it. As we can get the information via other means it's pointless
to have it in the driver, so rather use some proper trace
point here and remove the old on
On Fri, 20 Jul 2012 15:34:38 +0100
Anthony PERARD wrote:
> This command is used during a migration of a guest under Xen. It calls
> memory_global_dirty_log_start or memory_global_dirty_log_stop according to the
> argument pass to the command.
>
> Signed-off-by: Anthony PERARD
Reviewed-by: Luiz
When a device is resized, we will report a unit attention condition
for CAPACITY DATA HAS CHANGED. However, we should ensure that this
condition does not override a more important unit attention condition.
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c | 52 ++
The previous patch only separated the send_command callback.
Use different implementations also for read_data and write_data.
The latter is still unreachable, so it aborts for now.
read_data passes the data buffer that was prepared and completes
the command.
Signed-off-by: Paolo Bonzini
---
hw/
From: Ronnie Sahlberg
Add sense code for DATA_PROTECT/WRITE_PROTECTED and return this error
for any WRITE*/WRITE_VERIFY* calls if the device is readonly=on,
i.e. write-protected
Signed-off-by: Ronnie Sahlberg
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |5 +
hw/scsi-disk.c | 15
By making discard asynchronous, we can reuse all the error handling
code that is used for other commands.
Signed-off-by: Paolo Bonzini
---
hw/scsi-disk.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 788fe86..
From: Cong Meng
Add two interfaces hotplug() and hot_unplug() to scsi bus info.
The scsi bus can implement these two interfaces to signal the HBA driver
of guest kernel to add/remove the scsi device in question.
Signed-off-by: Sen Wang
Signed-off-by: Cong Meng
[ Fixed braces and indentation -
On Fri, 27 Jul 2012 08:37:12 -0500
Anthony Liguori wrote:
> This series implements the necessary commands to implements danpb's idea to
> remove -help parsing in libvirt. We would introduce all of these commands in
> 1.2 and then change the -help output starting in 1.3.
I've reviewed this and a
Signed-off-by: Paolo Bonzini
---
hw/scsi-bus.c |1 +
trace-events |1 +
2 files changed, 2 insertions(+)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index dd0cdd0..543d9d2 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1496,6 +1496,7 @@ void scsi_req_complete(SCSIRequest *req, int st
On Fri, 27 Jul 2012 08:37:17 -0500
Anthony Liguori wrote:
> This command attempts to map to the behavior of -cpu ?. Unfortunately, the
> output of this command differs wildly across targets.
>
> To accomodate this, we use a weak symbol to implement a default version of the
> command that fails
Signed-off-by: Paolo Bonzini
---
hw/virtio-scsi.c | 16
1 file changed, 16 insertions(+)
diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c
index bf18861..c4a5b22 100644
--- a/hw/virtio-scsi.c
+++ b/hw/virtio-scsi.c
@@ -27,6 +27,7 @@
/* Feature Bits */
#define VIRTIO_SCSI_F_IN
Simplify the code by checking against req->hba_private directly,
and asserting that it is non-NULL before a command is completed
or canceled.
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c89
On Fri, 27 Jul 2012 08:37:15 -0500
Anthony Liguori wrote:
> This provides the same output as -M ? but in a structured way.
>
> Signed-off-by: Anthony Liguori
> ---
> qapi-schema.json | 28
> qmp-commands.hx |6 ++
> vl.c | 31 ++
By first resetting the devices, lsi_soft_reset will find the queue
already cleared so there is no need to do that forcibly (which may also
leak SCSIRequests, and/or worse due to dangling references to the
lsi_request in the hba_private field).
Signed-off-by: Paolo Bonzini
---
hw/lsi53c895a.c |
On Fri, 27 Jul 2012 08:37:14 -0500
Anthony Liguori wrote:
> We've had a cycle to tweak. It is time to commit to supporting them.
qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't
we convert it to the qapi?
>
> Signed-off-by: Anthony Liguori
> ---
> qapi-schema.js
1 - 100 of 202 matches
Mail list logo
