[Qemu-devel] buildbot failure in qemu on xen41

2012-07-31 Thread qemu
The Buildbot has detected a new failure on builder xen41 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen41/builds/79 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

[Qemu-devel] [0/5] Assorted pseries fixes and updates

2012-07-31 Thread David Gibson
Hi Alex, I'm now back from vacation, and have more or less got back on top of my qemu tree. Here's my first batch of new patches, an assortment of fairly simple fixes and cleanups for the pseries code. Please apply.

[Qemu-devel] [PATCH 3/5] pseries: Add support for -vga option

2012-07-31 Thread David Gibson
From: Ben Herrenschmidt b...@kernel.crashing.org Also instantiate the USB keyboard and mouse when that option is used (you can still use -device to create individual devices without all the defaults) Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: David Gibson

[Qemu-devel] Compile errors on latest checkout

2012-07-31 Thread Gerhard Wiesinger
Hello, I'm getting the following compile errors: /root/download/qemu/git/qemu/hw/megasas.c: In function ‘megasas_class_init’: /root/download/qemu/git/qemu/hw/megasas.c:2155:14: error: assignment from incompatible pointer type [-Werror] pc-exit = megasas_scsi_uninit; With #define DEBUG_SCSI

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Aneesh Kumar K.V
Richard W.M. Jones rjo...@redhat.com writes: On Mon, Jul 30, 2012 at 03:35:39PM +0300, Avi Kivity wrote: Having an annoying bug on i386 kvm I decided to debug it buy running an i386 guest on my x86_64 host, use 9p to access a guest image, and run it using nested kvm. However, 9p appears to

[Qemu-devel] [PATCH 5/5] pseries: Add support for new KVM hash table control call

2012-07-31 Thread David Gibson
From: Ben Herrenschmidt b...@kernel.crashing.org This adds support for then new reset htab ioctl which allows qemu to properly cleanup the MMU hash table when the guest is reset. With the corresponding kernel support, reset of a guest now works properly. This also paves the way for indicating a

[Qemu-devel] [PATCH 4/5] pseries: Remove extraneous prints

2012-07-31 Thread David Gibson
The pseries machine prints several messages to stderr whenever it starts up and another whenever the vm is reset. It's not normal for qemu machines to do this though, so this patch removes them. We can put them back conditional on a DEBUG symbol if we really need them in future. Signed-off-by:

[Qemu-devel] [PATCH] configure: Fix configure error with --enable-virtfs

2012-07-31 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This fix the below error on ubuntu 12.04 a.c: In function ‘main’: a.c:3:24: error: variable ‘caps’ set but not used [-Werror=unused-but-set-variable] a.c:3:1: error: control reaches end of non-void function [-Werror=return-type]

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Aneesh Kumar K.V
Avi Kivity a...@redhat.com writes: Having an annoying bug on i386 kvm I decided to debug it buy running an i386 guest on my x86_64 host, use 9p to access a guest image, and run it using nested kvm. However, 9p appears to be broken: first, the configure test fails (patch sent). Second,

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Aneesh Kumar K.V
Avi Kivity a...@redhat.com writes: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

2012-07-31 Thread David Gibson
The pseries machine currently ignores the -usb command line option. This patch corrects the problem by having it instantiate a PCI OHCI USB host controller when -usb is specified. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/spapr.c |7 +++ 1 file changed, 7

Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-31 Thread Andreas Jaeger
On Monday, July 30, 2012 22:38:32 Peter Maydell wrote: On 30 July 2012 22:33, Andreas Färber afaer...@suse.de wrote: Am 30.07.2012 23:30, schrieb Alexander Graf: On 30.07.2012, at 09:21, Andreas Jaeger wrote: glibc 2.16 does not export the undocumented struct siginfo anymore. qemu uses

Re: [Qemu-devel] [PATCH] ATAPI: Add support for ASCQ in sense codes

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 04:07, Ronnie Sahlberg ha scritto: Add support for setting the ASCQ for SCSI sense codes in the ATAPI driver. Use this to set ASCQ==2 for the medium removal prevention that is recommended in MMC for this condition. asc:0x53 ascq:0x02 is the recommended error for

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Aneesh Kumar K.V
Avi Kivity a...@redhat.com writes: Having an annoying bug on i386 kvm I decided to debug it buy running an i386 guest on my x86_64 host, use 9p to access a guest image, and run it using nested kvm. However, 9p appears to be broken: first, the configure test fails (patch sent). Second,

[Qemu-devel] buildbot failure in qemu on xen40

2012-07-31 Thread qemu
The Buildbot has detected a new failure on builder xen40 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen40/builds/80 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler

[Qemu-devel] [PATCH] hw/9pfs: Fix assert when disabling migration

2012-07-31 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com For 9p we can get the attach request multiple times for the same export. So don't adding migration blocker for every attach request. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/9pfs/virtio-9p.c | 15

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Paolo Bonzini
Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: From: Blue Swirl blauwir...@gmail.com Clang compiler complained about use of reserved word 'restrict' in SLIRP and QAPI. Rename 'restrict' to 'restricted' which also matches other SLIRP code. Can't do it, this changes the command-line

Re: [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

2012-07-31 Thread Benjamin Herrenschmidt
On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote: The pseries machine currently ignores the -usb command line option. This patch corrects the problem by having it instantiate a PCI OHCI USB host controller when -usb is specified. Signed-off-by: David Gibson da...@gibson.dropbear.id.au

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-31 Thread Orit Wasserman
On 07/30/2012 08:41 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:42:54 +0300 Orit Wasserman owass...@redhat.com wrote: The management can enable/disable a capability for the next migration by using migrate_set_parameter command. The management can query the current migration

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-31 Thread Orit Wasserman
On 07/30/2012 08:41 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:42:54 +0300 Orit Wasserman owass...@redhat.com wrote: The management can enable/disable a capability for the next migration by using migrate_set_parameter command. The management can query the current migration

Re: [Qemu-devel] [GIT PULL (PATCH 0/4)] VFIO driver for v3.6

2012-07-31 Thread Linus Torvalds
On Mon, Jul 30, 2012 at 4:17 PM, Alex Williamson alex.william...@redhat.com wrote: I'm pretty anxious to find out as well. Linus, ping, any thoughts on including this in 3.6? Thanks, I just pulled it, but then I unpulled again when I realized it's not a signed tag and it's on github.

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread Alon Levy
On Tue, Jul 31, 2012 at 08:24:23AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 18:24 +0200, Alon Levy wrote: On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: Let's balkanize some more then?

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

2012-07-31 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Apart from cleanups, the major change in this version is to expose all the gluster configuration options to QEMU user. With this, the gluster specification looks like this: -drive

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread Alon Levy
On Mon, Jul 30, 2012 at 09:29:01AM -0500, Anthony Liguori wrote: Avi Kivity a...@redhat.com writes: Virtio makes sense for qxl, but for now we have the original pci model which I don't see a reason why it can't work for ppc. I'm sure it can work for PPC given enough effort. But I

Re: [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

2012-07-31 Thread Benjamin Herrenschmidt
On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote: The pseries machine currently ignores the -usb command line option. This patch corrects the problem by having it instantiate a PCI OHCI USB host controller when -usb is specified. Signed-off-by: David Gibson da...@gibson.dropbear.id.au

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-31 Thread Orit Wasserman
On 07/30/2012 10:37 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:43:02 +0300 Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by:

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-07-31 Thread Orit Wasserman
On 07/30/2012 10:30 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:43:01 +0300 Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard pett...@cs.umu.se Signed-off-by: Aidan Shribman aidan.shrib...@sap.com Signed-off-by:

[Qemu-devel] Tracing drivers commands to an emulated device

2012-07-31 Thread ffdevel
Hello to all, I would trace the commands issued by the driver to an emulated device. I've read in docs/tracing that it is possible but it is not completely clear how doing that. Is it possible to place hooks inside the emulated device code? Or is better tracing the in/out operations and the

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread ronnie sahlberg
On Mon, Jul 30, 2012 at 4:24 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: So I got cirrus working on ppc with cirrusdrmfb... The fun part is that it works :-) Basically, the issue is that normally, for it to work, one would have to access the framebuffer using the appropriate

Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

2012-07-31 Thread Kevin Wolf
Am 30.07.2012 17:05, schrieb Paolo Bonzini: Il 30/07/2012 16:47, Kevin Wolf ha scritto: +BlockJobInfo *block_job_query(BlockJob *job) +{ +BlockJobInfo *info = g_new(BlockJobInfo, 1); +info-type = g_strdup(job-job_type-job_type); +info-device =

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 5:46 AM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Wed, Jul 25, 2012 at 11:28:06AM +0530, Bharata B Rao wrote: Hi, This is the v3 of the patchset to support GlusterFS backend from QEMU. I am planning a v4 post to address a few minor cleanups suggested by

Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 10:47, Kevin Wolf ha scritto: Why did you convert the initialisation to separate statement? If you really want to do this, I think using g_new0 would be safer now, but I actually like compound literals better. Later on I will have some more initialization beyond the list

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 10:22:37AM +0800, Zhi Yong Wu wrote: On Mon, Jul 30, 2012 at 11:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: [These patches are based on the net tree at

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Kevin Wolf
Am 24.07.2012 13:04, schrieb Paolo Bonzini: This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini pbonz...@redhat.com [ Moving the discussion upstream ] Why make all of it inaccessible? Everything except target device access does have a stable API. The

Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko i.mitsya...@samsung.com writes: Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32 and CMD33, we have to account for this. Signed-off-by: Igor Mitsyanko

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko i.mitsya...@samsung.com writes: This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com --- hw/sd.c | 88 +- 1 files changed, 64 insertions(+),

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 11:26, Kevin Wolf ha scritto: Am 24.07.2012 13:04, schrieb Paolo Bonzini: This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini pbonz...@redhat.com [ Moving the discussion upstream ] Why make all of it inaccessible? Everything except

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko i.mitsya...@samsung.com writes: A straightforward conversion of SD card implementation to a proper QEMU object. Wrapper functions were introduced for SDClass methods in order to avoid SD card users modification. Because of this, name change for several functions in hw/sd.c

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 11:33, schrieb Paolo Bonzini: Il 31/07/2012 11:26, Kevin Wolf ha scritto: Am 24.07.2012 13:04, schrieb Paolo Bonzini: This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini pbonz...@redhat.com [ Moving the discussion upstream ] Why make all

Re: [Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 7:22 PM, riegama...@gmail.com wrote: From: Dunrong Huang riegama...@gmail.com Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function.

[Qemu-devel] [PATCH] Fix ALSA configure check

2012-07-31 Thread Paul Brook
Recent gcc notice that the ASLA configure check uses an uninitialized variable, causing spurious failures. Adjust the testcase to avoid this. Signed-off-by: Paul Brook p...@codesourcery.com --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce spi property for SD card objects

2012-07-31 Thread Markus Armbruster
Igor Mitsyanko i.mitsya...@samsung.com writes: And drop passing is_spi argument to SDCardClass::init function. spi property could be set only while SD card object is not attached to any BlockDriverState. It defaults to false. Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com Cc: Paul

Re: [Qemu-devel] [PATCH] Fix ALSA configure check

2012-07-31 Thread malc
On Tue, 31 Jul 2012, Paul Brook wrote: Recent gcc notice that the ASLA configure check uses an uninitialized variable, causing spurious failures. Adjust the testcase to avoid this. http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02704.html Signed-off-by: Paul Brook

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

2012-07-31 Thread Peter Maydell
On 31 July 2012 10:45, Markus Armbruster arm...@redhat.com wrote: Igor Mitsyanko i.mitsya...@samsung.com writes: @@ -1510,7 +1508,7 @@ void sd_write_data(SDState *sd, uint8_t value) return; if (sd-state != sd_receivingdata_state) { -fprintf(stderr, sd_write_data: not in

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 11:46, Kevin Wolf ha scritto: I'm not even sure about the QMP mirror command itself. I don't really like it, it does too many things at once: It can create the target image file, it opens the target and it actually starts the mirroring. It's rather bad at the first two steps,

Re: [Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread Peter Maydell
On 30 July 2012 19:22, riegama...@gmail.com wrote: +static int kvm_max_vcpus(KVMState *s) +{ +int max_vcpus = 4; +int ret; +ret = kvm_check_extension(s, KVM_CAP_MAX_VCPUS); +if (ret) { +max_vcpus = ret; +} else { + ret = kvm_check_extension(s,

[Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread riegamaths
From: Dunrong Huang riegama...@gmail.com Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function. Signed-off-by: Dunrong Huang riegama...@gmail.com --- v1 - v2: * Fix

Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 01:29 PM, Markus Armbruster wrote: Igor Mitsyanko i.mitsya...@samsung.com writes: Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32 and CMD33, we have to account for

[Qemu-devel] [RFC] Factor out fifos / circular buffers

2012-07-31 Thread Peter Crosthwaite
Hi All, A lot of devices have little internal fifos that are often implemented as circular buffers in the device state. Any reason to not factor that out into a helper module? Was thinkin just a struct defintion containing the key elements (the uint8_t *data buffer, head/tail pointers, capacity).

Re: [Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread Peter Maydell
On 31 July 2012 11:14, riegama...@gmail.com wrote: @@ -1256,6 +1274,13 @@ int kvm_init(void) goto err; } +max_vcpus = kvm_max_vcpus(s); +if (smp_cpus max_vcpus) { +fprintf(stderr, Number of SMP cpus requested (%d) exceeds max cpus +

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 12:02, schrieb Paolo Bonzini: Il 31/07/2012 11:46, Kevin Wolf ha scritto: I'm not even sure about the QMP mirror command itself. I don't really like it, it does too many things at once: It can create the target image file, it opens the target and it actually starts the

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

2012-07-31 Thread Igor Mitsyanko
On 07/31/2012 01:33 PM, Markus Armbruster wrote: Igor Mitsyanko i.mitsya...@samsung.com writes: This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko i.mitsya...@samsung.com --- hw/sd.c | 88

Re: [Qemu-devel] Tracing drivers commands to an emulated device

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 9:43 AM, ffde...@gmail.com wrote: I would trace the commands issued by the driver to an emulated device. I've read in docs/tracing that it is possible but it is not completely clear how doing that. Is it possible to place hooks inside the emulated device code? Or is

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread Benjamin Herrenschmidt
On Tue, 2012-07-31 at 18:44 +1000, ronnie sahlberg wrote: I use lots of guests that will never ever get virtio drivers. So for those guests, any work on making sure bog standard vga keeps working or even improving it gets two thumbs up from me! So I've been essentially restarting my work to

Re: [Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread Dunrong Huang
2012/7/31 Peter Maydell peter.mayd...@linaro.org: On 31 July 2012 11:14, riegama...@gmail.com wrote: @@ -1256,6 +1274,13 @@ int kvm_init(void) goto err; } +max_vcpus = kvm_max_vcpus(s); +if (smp_cpus max_vcpus) { +fprintf(stderr, Number of SMP cpus

Re: [Qemu-devel] [PATCH] Makefile: Remove generated hw/usb files in 'clean' target

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 5:46 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 30 July 2012 17:42, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, Jul 29, 2012 at 03:48:49PM +0200, Stefan Weil wrote: Commit f1ae32a1ecda8aaff7a355c9030c0d8c363f3a70 moved the usb directory to hw, so the

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 12:25, Kevin Wolf ha scritto: Yeah, but do you really care about for example io=threads vs. io=native? The only interesting one is cache=unsafe; the mirror should enable writeback caching on the target (bdrv_swap will disable it if needed; I'll change this in the next

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 12:51, schrieb Paolo Bonzini: Il 31/07/2012 12:25, Kevin Wolf ha scritto: Yeah, but do you really care about for example io=threads vs. io=native? The only interesting one is cache=unsafe; the mirror should enable writeback caching on the target (bdrv_swap will disable it if

[Qemu-devel] [PATCH v3] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-31 Thread riegamaths
From: Dunrong Huang riegama...@gmail.com Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function. Signed-off-by: Dunrong Huang riegama...@gmail.com --- v1 - v2: * Fix

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 13:13, Kevin Wolf ha scritto: Am 31.07.2012 12:51, schrieb Paolo Bonzini: Il 31/07/2012 12:25, Kevin Wolf ha scritto: Yeah, but do you really care about for example io=threads vs. io=native? The only interesting one is cache=unsafe; the mirror should enable writeback caching on

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-31 Thread Laszlo Ersek
(in reply to http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html -- In-Reply-To set, but that may not be enough for the web archive) Looks good to me. A minor nit: 2/2 keeps the close(s-fd) call (instead of calling closesocket(s-fd), like in eoc handling) in net_socket_cleanup().

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Avi Kivity
On 07/31/2012 09:51 AM, Aneesh Kumar K.V wrote: Avi Kivity a...@redhat.com writes: Having an annoying bug on i386 kvm I decided to debug it buy running an i386 guest on my x86_64 host, use 9p to access a guest image, and run it using nested kvm. However, 9p appears to be broken: first, the

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Kevin Wolf
Am 31.07.2012 13:25, schrieb Paolo Bonzini: Il 31/07/2012 13:13, Kevin Wolf ha scritto: Am 31.07.2012 12:51, schrieb Paolo Bonzini: Il 31/07/2012 12:25, Kevin Wolf ha scritto: Another interesting thing is I/O throttling. The mirror currently implements rate limiting itself, but is there

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce spi property for SD card objects

2012-07-31 Thread Andreas Färber
Am 31.07.2012 11:54, schrieb Markus Armbruster: Igor Mitsyanko i.mitsya...@samsung.com writes: And drop passing is_spi argument to SDCardClass::init function. spi property could be set only while SD card object is not attached to any BlockDriverState. It defaults to false. Signed-off-by:

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-31 Thread Avi Kivity
On 07/31/2012 01:29 AM, Alex Williamson wrote: If the region size is zero, then both memory_region_del_subregion() (assuming the region is parented) and munmap() do nothing. So you could call this unconditionally. I suppose parenting them is the key. I'm counting on memory_region_size

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

2012-07-31 Thread Bharata B Rao
On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Apart from cleanups, the major change in this version is to expose all the gluster configuration options to QEMU user. With this, the gluster

[Qemu-devel] R: Re: Tracing drivers commands to an emulated device

2012-07-31 Thread ffdevel
Hi Stefan, thanks for the support i think that the better way for me is to combine the two approaches. At this time i want start profiling the disk and network driver activity. I will submit patches in the case that the trace events that i add can be useful for others. Francesco

Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

2012-07-31 Thread Christian Borntraeger
On 30/07/12 16:05, Alexander Graf wrote: On 26.07.2012, at 10:59, Christian Borntraeger wrote: This patch makes the sclp ascii default for S390. It requires a guest kernel that autodetects the console and which not blindly assumes that kvm means virtio console. (commit

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 14:17, Kevin Wolf ha scritto: No, that should be ok. Though I'm not sure if it's so useful to apply throttling on the target. It's more useful to throttle the source (making writes slower than reads will help the job's convergence) and copy at full steam to the target. But

Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

2012-07-31 Thread Alexander Graf
On 07/31/2012 02:44 PM, Christian Borntraeger wrote: On 30/07/12 16:05, Alexander Graf wrote: On 26.07.2012, at 10:59, Christian Borntraeger wrote: This patch makes the sclp ascii default for S390. It requires a guest kernel that autodetects the console and which not blindly assumes that kvm

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce spi property for SD card objects

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 14:19, Andreas Färber ha scritto: +sd-spi = false; +object_property_add(obj, spi, boolean, sd_is_spi, sd_set_spimode, +NULL, NULL, NULL); +} + static const TypeInfo sd_type_info = { .name = TYPE_SD_CARD, .parent = TYPE_OBJECT,

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 1:38 PM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Apart from cleanups, the major change in this version is to expose

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

2012-07-31 Thread Luiz Capitulino
On Tue, 31 Jul 2012 09:28:43 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: From: Blue Swirl blauwir...@gmail.com Clang compiler complained about use of reserved word 'restrict' in SLIRP and QAPI. Rename 'restrict' to

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-07-31 Thread Andreas Färber
Am 24.07.2012 09:37, schrieb Christian Borntraeger: From: Heinz Graalfs graa...@linux.vnet.ibm.com Several SCLP features are considered to be events. Those events don't provide SCLP commands on their own, instead they are all based on Read Event Data, Write Event Data, Write Event Mask and

[Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Peter Maydell
Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- I figured that (unlike Makefile.target) we should probably take the xargs route here since otherwise the rm command

Re: [Qemu-devel] KVM call agenda for Tuesday, July 31

2012-07-31 Thread Stefan Hajnoczi
On Mon, Jul 30, 2012 at 8:34 AM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in covering. QEMU 1.2 Test Day * Let's find -rc bugs and ensure the release is stable * We've done this in the past and have a wiki template but can discuss suggestions

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 12:41 PM, Laszlo Ersek ler...@redhat.com wrote: (in reply to http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02637.html -- In-Reply-To set, but that may not be enough for the web archive) Looks good to me. A minor nit: 2/2 keeps the close(s-fd) call (instead

Re: [Qemu-devel] [PATCH v4 06/07] s390: sclp ascii console support

2012-07-31 Thread Christian Borntraeger
On 30/07/12 16:02, Alexander Graf wrote: +qemu_irq sclp_read_vt220; I'm sure this one wants a name that indicates it's an irq line ;) ok. +} SCLPConsole; + +/* character layer call-back functions */ + +/* Return number of bytes that fit into iov buffer */ +static int

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-31 Thread Luiz Capitulino
On Tue, 31 Jul 2012 10:46:02 +0300 Orit Wasserman owass...@redhat.com wrote: On 07/30/2012 08:41 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:42:54 +0300 Orit Wasserman owass...@redhat.com wrote: The management can enable/disable a capability for the next migration by using

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

2012-07-31 Thread Bharata B Rao
On Tue, Jul 31, 2012 at 01:56:29PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 31, 2012 at 1:38 PM, Bharata B Rao bhar...@linux.vnet.ibm.com wrote: On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao bhar...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-31 Thread Luiz Capitulino
On Tue, 31 Jul 2012 11:31:09 +0300 Orit Wasserman owass...@redhat.com wrote: On 07/30/2012 10:37 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:43:02 +0300 Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-07-31 Thread Luiz Capitulino
On Tue, 31 Jul 2012 11:36:03 +0300 Orit Wasserman owass...@redhat.com wrote: On 07/30/2012 10:30 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:43:01 +0300 Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Benoit Hudzia benoit.hud...@sap.com Signed-off-by: Petter Svard

Re: [Qemu-devel] Adding a parameter to a helper

2012-07-31 Thread Laurent Desnogues
On Mon, Jul 30, 2012 at 6:40 PM, Jose Cano Reyes jc...@ac.upc.edu wrote: I am trying to add a new integer parameter to an existing helper and call this helper in targeti386/translate.c. I have several problems: 1) I cannot add an integer parameter to the helper, the compiler says that it must

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names compatibility aliases

2012-07-31 Thread Igor Mammedov
On Thu, Jul 26, 2012 at 10:48:45AM -0400, Eduardo Habkost wrote: ... [1] There are multiple changes I want to make the cpudef config format: - Make it based on boolean per-feature flags, not low-level feature_register bits I'm trying to convert features to properties before looking at

Re: [Qemu-devel] KVM call agenda for Tuesday, July 31

2012-07-31 Thread Eduardo Habkost
On Mon, Jul 30, 2012 at 09:34:05AM +0200, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. - 1.2 plans for CPU model versioning/compatibility (global properties vs QOM vs qdev) -- Eduardo

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Stefan Hajnoczi
On Tue, Jul 31, 2012 at 02:01:35PM +0100, Peter Maydell wrote: Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- I figured that (unlike Makefile.target) we

Re: [Qemu-devel] [PATCH v4] Fixes related to processing of qemu's -numa option

2012-07-31 Thread Eduardo Habkost
Ping? Can anybody help Vinod, here? How can we get the attention of some maintainer, to get this pulled in? On Wed, Jul 18, 2012 at 06:26:52PM +, Vinod, Chegu wrote: Thanks Eduardo ! Hi Anthony, If you are ok with this patch...could you pl pull these changes into upstream (or)

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Aneesh Kumar K.V
Avi Kivity a...@redhat.com writes: On 07/31/2012 09:51 AM, Aneesh Kumar K.V wrote: Avi Kivity a...@redhat.com writes: Having an annoying bug on i386 kvm I decided to debug it buy running an i386 guest on my x86_64 host, use 9p to access a guest image, and run it using nested kvm.

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-31 Thread Stefan Hajnoczi
On Fri, Jul 20, 2012 at 2:25 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The socket backend does not support the listen= option with -netdev. The problem is how the socket NetClientState lifecycle is implemented: the socket backend waits for an incoming client connection before

Re: [Qemu-devel] [libvirt-users] Using virsh to load scripts for the guest machine

2012-07-31 Thread Eric Blake
On 07/30/2012 12:00 PM, Mauricio Tavares wrote: On Mon, Jul 30, 2012 at 1:50 PM, Eric Blake ebl...@redhat.com wrote: On 07/15/2012 07:52 PM, Mauricio Tavares wrote: Right on the top of http://www.centos.org/docs/5/html/5.2/Virtualization/chap-Virtualization-Managing_guests_with_virsh.html,

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names compatibility aliases

2012-07-31 Thread Eduardo Habkost
On Tue, Jul 31, 2012 at 03:22:59PM +0200, Igor Mammedov wrote: On Thu, Jul 26, 2012 at 10:48:45AM -0400, Eduardo Habkost wrote: ... [1] There are multiple changes I want to make the cpudef config format: - Make it based on boolean per-feature flags, not low-level feature_register

Re: [Qemu-devel] 9p broken?

2012-07-31 Thread Avi Kivity
On 07/31/2012 04:30 PM, Aneesh Kumar K.V wrote: Did this help ? http://mid.gmane.org/1343719453-26768-1-git-send-email-aneesh.ku...@linux.vnet.ibm.com It did: thanks. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Compile errors on latest checkout

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 08:04, Gerhard Wiesinger ha scritto: Hello, I'm getting the following compile errors: /root/download/qemu/git/qemu/hw/megasas.c: In function ‘megasas_class_init’: /root/download/qemu/git/qemu/hw/megasas.c:2155:14: error: assignment from incompatible pointer type [-Werror]

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-31 Thread Orit Wasserman
On 07/31/2012 04:16 PM, Luiz Capitulino wrote: On Tue, 31 Jul 2012 11:31:09 +0300 Orit Wasserman owass...@redhat.com wrote: On 07/30/2012 10:37 PM, Luiz Capitulino wrote: On Sun, 29 Jul 2012 12:43:02 +0300 Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Benoit Hudzia

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 07:54, Stefan Weil ha scritto: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- I figured that (unlike Makefile.target) we should probably take

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 15:04, Stefan Hajnoczi ha scritto: Looks good to me. A minor nit: 2/2 keeps the close(s-fd) call (instead of calling closesocket(s-fd), like in eoc handling) in net_socket_cleanup(). The reason I didn't change close(2) to closesocket() is because -netdev socket,fd= can pass

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Peter Maydell
On 31 July 2012 15:19, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: + find . -name '*.[od]' | xargs rm -f + rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~ Shit happens if you somehow manage to create a mean file

Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield

2012-07-31 Thread Peter Maydell
On 27 July 2012 20:29, Igor Mitsyanko i.mitsya...@samsung.com wrote: Representing each group write protection flag with only one bit instead of int variable significantly reduces memory consumption. ...and it looks much nicer too. Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

2012-07-31 Thread Eric Blake
On 07/31/2012 08:19 AM, Markus Armbruster wrote: Peter Maydell peter.mayd...@linaro.org writes: Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. rm -f qemu-options.def -rm -f *.o *.d *.a *.lo $(TOOLS)

  1   2   3   >