Re: [Qemu-devel] [PATCH] iov_send_recv(): Handle zero bytes case even if OS does not

2012-08-13 Thread Kevin Wolf
Am 12.08.2012 12:32, schrieb Michael Tokarev: On 12.08.2012 01:24, Peter Maydell wrote: POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero msg.msg_iovlen (in particular the MacOS X implementation will do this). Handle the case where iov_send_recv() is passed a zero byte

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-13 Thread Kevin Wolf
Am 10.08.2012 19:48, schrieb Benoît Canet: Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet benoit.ca...@gmail.com wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 62

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 12.08.2012 04:48, schrieb Kevin Shanahan: So qmp_change_blockdev uses bdrv_is_read_only() to check whether to try and open the backing file read only, which uses the -read_only member of struct BlockDriverState to decide whether to pass the BDRV_O_RDRW flag to qmp_bdrv_open_encypted() and

Re: [Qemu-devel] TRIM, UNMAP and QCOW2 release of block information - Thin provisioning

2012-08-13 Thread Stefan Hajnoczi
On Sun, Aug 12, 2012 at 8:00 PM, Gerhard Wiesinger li...@wiesinger.com wrote: As far as I saw QEMU/KVM supports the trim command on IDE/SATA devices and the UNMAP command on SCSI devices/disks (thanks Paolo Bonzini). Will the qcow2 format (or other formats) use this information and also release

[Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This is required to get past the following assert with: commit 1523ed9e1d46b0b54540049d491475ccac7e6421 Author: Jan Kiszka jan.kis...@siemens.com Date: Thu May 17 10:32:39 2012 -0300 virtio/vhost: Add support for KVM in-kernel MSI injection

[Qemu-devel] [RFC-v2 0/6] vhost-scsi: Add support for host virtualized target

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Paolo, Stefan, QEMU folks, The following is the second RFC series for vhost-scsi patches against mainline QEMU v1.1.0. The series is available from the following working branch: git://git.kernel.org/pub/scm/virt/kvm/nab/qemu-kvm.git

[Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI-cmd_vqs[0] definition

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes bug in the definition of VirtIOSCSI-cmd_vqs[0], where the return of virtio_add_queue() in virtio_scsi_init() ends up overwriting past the end of -cmd_vqs[0]. Since virtio_scsi currently assumes a single vqs for data, this patch

Re: [Qemu-devel] [PATCH v6 5/7] add the QKeyCode enum and the key_defs table

2012-08-13 Thread Amos Kong
On 08/03/2012 09:32 PM, Luiz Capitulino wrote: On Fri, 3 Aug 2012 10:48:40 +0800 Amos Kong ak...@redhat.com wrote: key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum and a new key_defs table, Key's index in the enmu is same as keycode's index

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:12AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This is required to get past the following assert with: commit 1523ed9e1d46b0b54540049d491475ccac7e6421 Author: Jan Kiszka jan.kis...@siemens.com Date: Thu May 17

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The

Re: [Qemu-devel] [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-08-13 Thread Cornelia Huck
On Wed, 08 Aug 2012 13:52:57 +0930 Rusty Russell ru...@rustcorp.com.au wrote: On Tue, 7 Aug 2012 16:52:47 +0200, Cornelia Huck cornelia.h...@de.ibm.com wrote: Add a driver for kvm guests that matches virtual ccw devices provided by the host as virtio bridge devices. Hi Cornelia,

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The

Re: [Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params

2012-08-13 Thread Yonit Halperin
Ack On 08/13/2012 11:32 AM, Christophe Fergeau wrote: When parsing its command line parameters, spice aborts when it finds unexpected values, except for the 'streaming-video' option. This happens because the parsing of the parameters for this option is done using the 'name2enum' helper, which

Re: [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI-cmd_vqs[0] definition

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:17AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes bug in the definition of VirtIOSCSI-cmd_vqs[0], where the return of virtio_add_queue() in virtio_scsi_init() ends up overwriting past the end of -cmd_vqs[0].

Re: [Qemu-devel] [RFC-v2 0/6] vhost-scsi: Add support for host virtualized target

2012-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2012 at 08:35:11AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Paolo, Stefan, QEMU folks, The following is the second RFC series for vhost-scsi patches against mainline QEMU v1.1.0. The series is available from the following

[Qemu-devel] [RFC-v2 5/6] virtio-scsi: Set max_target=0 during vhost-scsi operation

2012-08-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This QEMU patch sets VirtIOSCSIConfig-max_target=0 for vhost-scsi operation to restrict virtio-scsi LLD guest scanning to max_id=0 (a single target ID instance) when connected to individual tcm_vhost endpoints. This ensures that virtio-scsi LLD only

[Qemu-devel] [RFC-v2 2/6] vhost: Pass device path to vhost_dev_init()

2012-08-13 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com The path to /dev/vhost-net is currently hardcoded in vhost_dev_init(). This needs to be changed so that /dev/vhost-scsi can be used. Pass in the device path instead of hardcoding it. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Cc:

[Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-13 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch adds a new type of host device that drives the vhost_scsi device. The syntax to add vhost-scsi is: qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 The virtio-scsi emulated device will make use of vhost-scsi to process virtio-scsi

[Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-13 Thread Nicholas A. Bellinger
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com This patch starts and stops vhost as the virtio device transitions through its status phases. Vhost can only be started once the guest reports its driver has successfully initialized, which means the virtqueues have been set up by the guest. v2:

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

2012-08-13 Thread Peter Maydell
Ping^2? On 3 August 2012 13:55, Peter Maydell peter.mayd...@linaro.org wrote: Ping? patchwork url: http://patchwork.ozlabs.org/patch/171628/ -- PMM On 18 July 2012 11:11, Peter Maydell peter.mayd...@linaro.org wrote: Rather than hardcoding the list of architectures in the kernel header

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-13 Thread Peter Maydell
Ping^2 ? On 8 August 2012 13:34, Peter Maydell peter.mayd...@linaro.org wrote: Ping? patchwork url: http://patchwork.ozlabs.org/patch/173202/ -- PMM On 25 July 2012 16:29, Peter Maydell peter.mayd...@linaro.org wrote: Add asm-generic/kvm_para.h to the set of non-architecture specific KVM

Re: [Qemu-devel] [PULL 0/2] QOMify AXI stream for Xilinx AXI ethernet/DMA

2012-08-13 Thread Edgar E. Iglesias
On Fri, Aug 10, 2012 at 01:16:09PM +1000, Peter A. G. Crosthwaite wrote: The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89: Bruce Rogers (1): handle device help before accelerator set up are available in the git repository at:

Re: [Qemu-devel] [PATCH v6 0/2] GlusterFS support in QEMU - v6

2012-08-13 Thread Bharata B Rao
On Thu, Aug 09, 2012 at 06:30:10PM +0530, Bharata B Rao wrote: Hi, This is the v6 of the patchset to support GlusterFS backend from QEMU. The changes include defining a default value for glusterfs feature in the configure script and a few minor cleanups suggested by Stefan. As I mentioned

[Qemu-devel] KVM call agenda for Tuesday, August 14

2012-08-13 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] github mirror still stale

2012-08-13 Thread Stefan Weil
Am 12.08.2012 00:03, schrieb Anthony Liguori: Peter Maydell peter.mayd...@linaro.org writes: On 18 July 2012 10:28, Peter Maydell peter.mayd...@linaro.org wrote: On 12 March 2012 20:12, Stefan Weil s...@weilnetz.de wrote: We also need more resources for technical maintenance of the QEMU

[Qemu-devel] [PATCH] spice: abort on invalid streaming cmdline params

2012-08-13 Thread Christophe Fergeau
When parsing its command line parameters, spice aborts when it finds unexpected values, except for the 'streaming-video' option. This happens because the parsing of the parameters for this option is done using the 'name2enum' helper, which does not error out on unknown values. Using the

[Qemu-devel] [PATCH 2/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-08-13 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com This patch extends the function guess_disk_lchs. If no geo could be derived from reading disk content, HDIO_GETGEO ioctl is issued. If this is not successful (e.g. image files) geometry is derived from the size of the disk (as before). To achieve

[Qemu-devel] [PATCH 0/2] s390: block size auto-sensing and geometry guessing changes in common code

2012-08-13 Thread Jens Freimann
From: Jens Freimann jf...@linux.vnet.ibm.com Here are two patches for block device characteristics detection. The first one implements block size auto-sensing for virtio-block and the second patch changes geometry guessing common code. More details in the patch descriptions. Einar Lueck (2):

[Qemu-devel] [PATCH 1/2] virtio-block: support auto-sensing of block sizes

2012-08-13 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com Virtio-blk does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. This automatic lookup needs to be enabled explicitly. Users may do this by

[Qemu-devel] [PATCH 2/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-08-13 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com This patch extends the function guess_disk_lchs. If no geo could be derived from reading disk content, HDIO_GETGEO ioctl is issued. If this is not successful (e.g. image files) geometry is derived from the size of the disk (as before). To achieve

[Qemu-devel] [PATCH 1/2] virtio-block: support auto-sensing of block sizes

2012-08-13 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com Virtio-blk does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. This automatic lookup needs to be enabled explicitly. Users may do this by

[Qemu-devel] [PATCH 0/2] s390: block size auto-sensing and geometry guessing changes in common code

2012-08-13 Thread Jens Freimann
[resend because the first attempt didn't make it to the mailing list] Here are two patches for block device characteristics detection. The first one implements block size auto-sensing for virtio-block and the second patch changes geometry guessing common code. More details in the patch

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-13 Thread Wenchao Xia
于 2012-8-10 18:48, Paolo Bonzini 写道: Il 09/08/2012 12:12, Wenchao Xia ha scritto: +/* copy information and take care the member difference in differect version. + Assuming all new member are added in the tail, struct size is the first + member, this is old to new version, src have its

[Qemu-devel] [RFC 0/7] Migration stats

2012-08-13 Thread Juan Quintela
Hi This modifies the output of info migrate/qmp_query_migrate to add the stats that I got request for. - It moves total time to MigrationInfo instead of ram (luiz suggestion) - Prints the real downtime that we have had really, it prints the total downtime of the complete phase, but the

[Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 8e4c508..159728d 100644 --- a/migration.c +++ b/migration.c @@ -326,6 +326,7 @@ static void migrate_fd_put_ready(void *opaque)

[Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 migration.c | 5 - migration.h | 1 + qapi-schema.json | 6 +- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index c0b0a10..10fee1b 100644 --- a/hmp.c +++ b/hmp.c @@

[Qemu-devel] [PATCH v2 0/2] two little build fixes

2012-08-13 Thread Gerd Hoffmann
Hi, Patch #1 uses g_strdup_printf now, #2 is unchanged. cheers, Gerd Gerd Hoffmann (2): Avoid asprintf() which is not available on mingw scsi: fix warning hw/msix.c |8 ++-- hw/scsi-bus.c |2 ++ 2 files changed, 4 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v2 2/2] scsi: fix warning

2012-08-13 Thread Gerd Hoffmann
hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this function Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5) are not clever enougth to figure, so sprinkle in a default: line to make them happy. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH v2 1/2] Avoid asprintf() which is not available on mingw

2012-08-13 Thread Gerd Hoffmann
Use g_strdup_printf() instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/msix.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 800fc32..aea340b 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -307,13 +307,9 @@ int

[Qemu-devel] [PATCH 6/7] migration: print expected downtime in info migrate

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 2 ++ hmp.c| 4 migration.c | 2 ++ migration.h | 1 + qapi-schema.json | 4 5 files changed, 13 insertions(+) diff --git a/arch_init.c b/arch_init.c index 5559d68..b150852 100644 ---

[Qemu-devel] [PATCH 7/7] migration: Add dirty_pages_rate to query migrate output

2012-08-13 Thread Juan Quintela
For now this is a placeholder, real info will appear once the bitmap changes in the migration thread series is integrated. Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 migration.c | 2 ++ migration.h | 1 + qapi-schema.json | 6 +- 4 files

[Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 ++-- migration.c | 6 +++--- qapi-schema.json | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hmp.c b/hmp.c index c13386b..c0b0a10 100644 --- a/hmp.c +++ b/hmp.c @@ -149,6

Re: [Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

2012-08-13 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: Add support for saving/loading bitmap.h bitmaps in vmstate. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- This will be needed for saving/restoring the bitmap in sd.c which is introduced by Igor's latest patchset; the relevant VMSTATE

[Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9b46bfc..5559d68 100644 --- a/arch_init.c +++ b/arch_init.c @@ -537,7 +537,7 @@ static int

[Qemu-devel] [PATCH 5/7] migration: export migration_get_current()

2012-08-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 2 +- migration.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 4c2ac6c..12de941 100644 --- a/migration.c +++ b/migration.c @@ -53,7 +53,7 @@ static NotifierList

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-13 Thread Wenchao Xia
于 2012-8-10 19:02, Kevin Wolf 写道: Am 09.08.2012 12:12, schrieb Wenchao Xia: This patch is the API design. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock.c | 670 +++ libqblock.h | 447

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-13 Thread Wenchao Xia
于 2012-8-11 20:18, Blue Swirl 写道: On Fri, Aug 10, 2012 at 8:04 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Thanks for your review, sorry I have forgot some fixing you mentioned before, will correct them this time. 于 2012-8-10 1:12, Blue Swirl 写道: On Thu, Aug 9, 2012 at 10:10 AM,

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 12.08.2012 04:48, schrieb Kevin Shanahan: So qmp_change_blockdev uses bdrv_is_read_only() to check whether to try and open the backing file read only, which uses the -read_only member of struct BlockDriverState to decide whether to pass the BDRV_O_RDRW

Re: [Qemu-devel] [RFC-v2 1/6] msix: Work-around for vhost-scsi with KVM in-kernel MSI injection

2012-08-13 Thread Jan Kiszka
On 2012-08-13 10:35, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This is required to get past the following assert with: commit 1523ed9e1d46b0b54540049d491475ccac7e6421 Author: Jan Kiszka jan.kis...@siemens.com Date: Thu May 17 10:32:39 2012 -0300

[Qemu-devel] [PATCH for-1.2 v2] arm: Move some ARM devices into libhw

2012-08-13 Thread Andreas Färber
Avoids some unnecessary dependencies on cpu.h and prepares for a future armeb-softmmu where most machines would not be built. Defer touching the SoC devices since most have implicit or explicit dependencies on the CPU. Signed-off-by: Andreas Färber andreas.faer...@web.de ---

Re: [Qemu-devel] [PATCH for-1.2 v2] arm: Move some ARM devices into libhw

2012-08-13 Thread Andreas Färber
Am 13.08.2012 14:11, schrieb Andreas Färber: Avoids some unnecessary dependencies on cpu.h and prepares for a future armeb-softmmu where most machines would not be built. Defer touching the SoC devices since most have implicit or explicit dependencies on the CPU. Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH for-1.2 v5 00/14] pci_host: Convert to QOM

2012-08-13 Thread Andreas Färber
Am 09.08.2012 17:09, schrieb Andreas Färber: Am 02.08.2012 10:30, schrieb Michael S. Tsirkin: On Thu, Aug 02, 2012 at 03:46:52AM +0200, Andreas Färber wrote: Here's a fixed version of the series making pci_host a first-class QOM type. MAINTAINERS entries for the ppc devices touched herein are

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-13 Thread Kevin Wolf
Am 09.08.2012 15:02, schrieb Bharata B Rao: block: Support GlusterFS as a QEMU block backend. From: Bharata B Rao bhar...@linux.vnet.ibm.com This patch adds gluster as the new block backend in QEMU. This gives QEMU the ability to boot VM images from gluster volumes. Its already possible

Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-13 Thread Jan Kiszka
On 2012-08-12 11:24, Michael Tokarev wrote: On 12.08.2012 12:10, Gleb Natapov wrote: [] Any chance to bisect it? The bisecion leads to this commit: commit 17ee47418e65b1593defb30edbab33ccd47fc1f8 Merge: 13b0496 5d17c0d Author: Jan Kiszka jan.kis...@siemens.com Date: Tue Apr 10

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-13 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/alpha_typhoon.c |2 +- hw/dec_pci.c |2 +-

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-13 Thread Michael S. Tsirkin
On Thu, Aug 02, 2012 at 03:47:06AM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de IMHO only one chunk from this patch should be

Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-13 Thread Michael Tokarev
On 13.08.2012 17:07, Jan Kiszka wrote: [] The bisecion leads to this commit: commit 17ee47418e65b1593defb30edbab33ccd47fc1f8 Merge: 13b0496 5d17c0d Author: Jan Kiszka jan.kis...@siemens.com Date: Tue Apr 10 16:26:23 2012 +0200 Merge commit '5d17c0d2df4998598e6002b27b8e47e792899a0f'

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-13 Thread Kevin Wolf
Am 13.08.2012 13:57, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 12.08.2012 04:48, schrieb Kevin Shanahan: So qmp_change_blockdev uses bdrv_is_read_only() to check whether to try and open the backing file read only, which uses the -read_only member of struct

Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Anthony Liguori
Alex Williamson alex.william...@redhat.com writes: VFIO kernel support was just merged into Linux, so I'd like to formally propose inclusion of the QEMU vfio-pci driver for QEMU 1.2. Included here is support for x86 PCI device assignment. PCI INTx is not yet enabled, but devices making use

Re: [Qemu-devel] [PATCH v3 00/35]: add new error format

2012-08-13 Thread Luiz Capitulino
On Sat, 11 Aug 2012 09:05:33 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] This series implements the 'Plan for error handling in QMP' as described by Anthony in this email:

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-13 Thread Andreas Färber
Am 13.08.2012 15:14, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c index df70cd2..8937030 100644 --- a/hw/spapr_pci.c +++ b/hw/spapr_pci.c @@ -36,16 +36,18 @@ static PCIDevice *find_dev(sPAPREnvironment *spapr,

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-13 Thread Luiz Capitulino
On Sat, 11 Aug 2012 09:45:14 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 10 Aug 2012 19:17:22 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 10 Aug 2012 18:35:26

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-08-13 Thread Erik Rull
On August 9, 2012 at 10:59 AM Gerd Hoffmann kra...@redhat.com wrote: Hi Gerd, sorry for the delays, I tested the latest pulled patch queue and it's now fine on my Intel board, too. The dongle gets detected again without assertions. Thanks for your work. Still remaining are the

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 08/08/2012 12:04 PM, Markus Armbruster wrote: Yes please, maybe with a notice to the user. Next problem: minimum RAM size. For instance, -M pc -m X, where X 32KiB dies qemu: fatal: Trying to execute code outside RAM or ROM at [...] Aborted (core

Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-13 Thread Jan Kiszka
On 2012-08-13 15:16, Michael Tokarev wrote: On 13.08.2012 17:07, Jan Kiszka wrote: [] The bisecion leads to this commit: commit 17ee47418e65b1593defb30edbab33ccd47fc1f8 Merge: 13b0496 5d17c0d Author: Jan Kiszka jan.kis...@siemens.com Date: Tue Apr 10 16:26:23 2012 +0200 Merge

Re: [Qemu-devel] [PATCH v9 5/7] block: Convert close calls to qemu_close

2012-08-13 Thread Corey Bryant
On 08/11/2012 09:22 AM, Blue Swirl wrote: On Sat, Aug 11, 2012 at 1:14 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v5: -This

Re: [Qemu-devel] [PATCH v9 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-13 Thread Corey Bryant
I'll send a new version shortly with these updates. -- Regards, Corey On 08/11/2012 10:16 AM, Eric Blake wrote: On 08/11/2012 07:14 AM, Corey Bryant wrote: This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-08-13 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 10 August 2012 17:04, Anthony Liguori aligu...@us.ibm.com wrote: This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com I'm sure you'll be thrilled to hear

Re: [Qemu-devel] [PATCH v9 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-13 Thread Corey Bryant
I'll send a new version shortly with these updates. -- Regards, Corey On 08/11/2012 10:16 AM, Eric Blake wrote: On 08/11/2012 07:14 AM, Corey Bryant wrote: This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file

Re: [Qemu-devel] [PATCH v9 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-13 Thread Corey Bryant
I'll send a new version shortly with these updates also. -- Regards, Corey On 08/11/2012 10:28 AM, Eric Blake wrote: On 08/11/2012 07:14 AM, Corey Bryant wrote: When qemu_open is passed a filename of the /dev/fdset/nnn format (where nnn is the fdset ID), an fd with matching access mode flags

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-13 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 11 Aug 2012 09:45:14 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 10 Aug 2012 19:17:22 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Avi Kivity
On 08/13/2012 04:41 PM, Markus Armbruster wrote: Avi Kivity a...@redhat.com writes: On 08/08/2012 12:04 PM, Markus Armbruster wrote: Yes please, maybe with a notice to the user. Next problem: minimum RAM size. For instance, -M pc -m X, where X 32KiB dies qemu: fatal: Trying to

Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Avi Kivity
On 08/13/2012 04:27 PM, Anthony Liguori wrote: Thanks for pushing this forward! Hopefully this will finally kill off qemu-kvm.git for good. No, it won't. vfio requires a 3.6 kernel, which we cannot assume anyone has. We'll need the original device assignment code side-by-side. -- error

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-13 Thread Luiz Capitulino
On Mon, 13 Aug 2012 15:50:13 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Sat, 11 Aug 2012 09:45:14 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 10 Aug 2012 19:17:22

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 04:56:53PM +0300, Avi Kivity wrote: On 08/13/2012 04:41 PM, Markus Armbruster wrote: Avi Kivity a...@redhat.com writes: On 08/08/2012 12:04 PM, Markus Armbruster wrote: Yes please, maybe with a notice to the user. Next problem: minimum RAM size. For

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Avi Kivity
On 08/13/2012 05:02 PM, Gleb Natapov wrote: IMO we need to fix CMOS reporting. (technically we shouldn't touch CMOS NVRAM at all; seabios should discover memory size via fwcfg and program it itself. But it's pointless to change it now) Chipset we emulate does not support all those crazy

Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Jan Kiszka
On 2012-08-13 15:58, Avi Kivity wrote: On 08/13/2012 04:27 PM, Anthony Liguori wrote: Thanks for pushing this forward! Hopefully this will finally kill off qemu-kvm.git for good. No, it won't. vfio requires a 3.6 kernel, which we cannot assume anyone has. We'll need the original device

[Qemu-devel] [PATCH v10 1/7] qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg

2012-08-13 Thread Corey Bryant
Set the close-on-exec flag for the file descriptor received via SCM_RIGHTS. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v4 -This patch is new in v4 (ebl...@redhat.com) v5 -Fallback to FD_CLOEXEC if MSG_CMSG_CLOEXEC is not available (ebl...@redhat.com,

[Qemu-devel] [PATCH v10 4/7] block: Convert open calls to qemu_open

2012-08-13 Thread Corey Bryant
This patch converts all block layer open calls to qemu_open. Note that this adds the O_CLOEXEC flag to the changed open paths when the O_CLOEXEC macro is defined. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v2: -Convert calls to qemu_open instead of file_open (kw...@redhat.com)

[Qemu-devel] [PATCH v10 5/7] block: Convert close calls to qemu_close

2012-08-13 Thread Corey Bryant
This patch converts all block layer close calls, that correspond to qemu_open calls, to qemu_close. Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v5: -This patch is new in v5. (kw...@redhat.com, ebl...@redhat.com) v6-v9: -No changes v10: -Don't use underscore prefix on functions.

[Qemu-devel] [PATCH v10 3/7] block: Prevent detection of /dev/fdset/ as floppy

2012-08-13 Thread Corey Bryant
Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- v8 -This patch is new in v8. It was reported on a prior fd passing approach and I realized it's needed in this series. (kw...@redhat.com) v9-v10 -No changes block/raw-posix.c |4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v10 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-13 Thread Corey Bryant
This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to store file descriptors for the same file. This allows the client to open a file with

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Gleb Natapov
On Mon, Aug 13, 2012 at 05:04:30PM +0300, Avi Kivity wrote: On 08/13/2012 05:02 PM, Gleb Natapov wrote: IMO we need to fix CMOS reporting. (technically we shouldn't touch CMOS NVRAM at all; seabios should discover memory size via fwcfg and program it itself. But it's pointless to

[Qemu-devel] [PATCH v10 7/7] monitor: Clean up fd sets on monitor disconnect

2012-08-13 Thread Corey Bryant
Fd sets are shared by all monitor connections. Fd sets are considered to be in use while at least one monitor is connected. When the last monitor disconnects, all fds that are members of an fd set with no outstanding dup references are closed. This prevents any fd leakage associated with a

[Qemu-devel] [PATCH v10 0/7] file descriptor passing using fd sets

2012-08-13 Thread Corey Bryant
libvirt's sVirt security driver provides SELinux MAC isolation for Qemu guest processes and their corresponding image files. In other words, sVirt uses SELinux to prevent a QEMU process from opening files that do not belong to it. sVirt provides this support by labeling guests and resources with

[Qemu-devel] [PATCH v10 6/7] block: Enable qemu_open/close to work with fd sets

2012-08-13 Thread Corey Bryant
When qemu_open is passed a filename of the /dev/fdset/nnn format (where nnn is the fdset ID), an fd with matching access mode flags will be searched for within the specified monitor fd set. If the fd is found, a dup of the fd will be returned from qemu_open. Signed-off-by: Corey Bryant

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-13 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Thu, Aug 02, 2012 at 03:47:06AM +0200, Andreas Färber wrote: Uglify the parent field to enforce QOM-style access via casts. Don't just typedef PCIHostState, either use it directly or embed it. Signed-off-by: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Avi Kivity a...@redhat.com writes: On 08/08/2012 12:04 PM, Markus Armbruster wrote: Yes please, maybe with a notice to the user. Next problem: minimum RAM size. For instance, -M pc -m X, where X 32KiB dies qemu: fatal: Trying to execute

Re: [Qemu-devel] [PATCH 0/3] VFIO-based PCI device assignment for QEMU 1.2

2012-08-13 Thread Alex Williamson
On Mon, 2012-08-13 at 08:27 -0500, Anthony Liguori wrote: Alex Williamson alex.william...@redhat.com writes: VFIO kernel support was just merged into Linux, so I'd like to formally propose inclusion of the QEMU vfio-pci driver for QEMU 1.2. Included here is support for x86 PCI device

Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Pull in asm-generic/kvm_para.h

2012-08-13 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: Ping^2 ? In a previous thread, we all agreed that all changes to linux headers would come in through uq/master to ensure that we didn't have a repeat scenario of depending on a header that didn't make it to Avi's tree unchanged. Avi/Marcelo, can

Re: [Qemu-devel] [PATCH 1/7] migration: move total_time from ram stats to migration info

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 ++-- migration.c | 6 +++--- qapi-schema.json | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) Looks reasonable to me! Missed

Re: [Qemu-devel] Funny -m arguments can crash

2012-08-13 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Avi Kivity a...@redhat.com writes: On 08/08/2012 12:04 PM, Markus Armbruster wrote: Yes please, maybe with a notice to the user. Next problem: minimum RAM size. For instance, -M pc -m X, where X

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: Factor out guest space probing into a function

2012-08-13 Thread Peter Maydell
On 27 July 2012 03:50, Meador Inge mead...@codesourcery.com wrote: Signed-off-by: Meador Inge mead...@codesourcery.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PATCH v2 2/2] linux-user: Use init_guest_space when -R and -B are specified

2012-08-13 Thread Peter Maydell
On 27 July 2012 03:50, Meador Inge mead...@codesourcery.com wrote: Roll the code used to initialize the guest memory space when -R or -B is used into 'init_guest_space' and then call 'init_guest_space' from the driver. This way the reserved guest memory space can be probed for. Calling

Re: [Qemu-devel] [RFC 0/7] Migration stats

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Hi This modifies the output of info migrate/qmp_query_migrate to add the stats that I got request for. - It moves total time to MigrationInfo instead of ram (luiz suggestion) Now's the time to do this, since the stat is new to 1.2 and we

Re: [Qemu-devel] [PATCH 2/7] migration: store end_time in a local variable

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization

Re: [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 migration.c | 5 - migration.h | 1 + qapi-schema.json | 6 +- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c

Re: [Qemu-devel] [PATCH 3/7] migration: print total downtime for final phase of migration

2012-08-13 Thread Eric Blake
On 08/13/2012 09:02 AM, Eric Blake wrote: On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- hmp.c| 4 migration.c | 5 - migration.h | 1 + qapi-schema.json | 6 +- 4 files changed, 14 insertions(+), 2

Re: [Qemu-devel] [PATCH 4/7] migration: rename expected_time to expected_downtime

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Trivial rename. @@ -576,24 +576,25 @@ static int ram_save_iterate(QEMUFile *f, void *opaque) bwidth =

Re: [Qemu-devel] [PATCH 5/7] migration: export migration_get_current()

2012-08-13 Thread Eric Blake
On 08/13/2012 04:50 AM, Juan Quintela wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 2 +- migration.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

  1   2   3   >