Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on sPAPR platform.

2012-08-15 Thread Li Zhang
On 2012年08月15日 02:09, Alexander Graf wrote: On 14.08.2012, at 19:49, Li Zhang zhlci...@gmail.com wrote: USB is enabled as default on sPAPR platform because it needs USB keyboard and USB mouse when VGA is enabled. This patch is to add USB controller on sPAPR platform. Signed-off-by: Li Zhang

[Qemu-devel] What is cpu_A0 in target-i386/translate.c

2012-08-15 Thread Steven
Hi, I would like to trace the guest physical address of the load instructions from the guest. I thought the cpu_A0 is the memory address to be accessed. However, when I print out the value of cpu_A0, like static inline void gen_op_ld_v(int idx, TCGv t0, TCGv a0) { int mem_index = (idx 2) -

Re: [Qemu-devel] [Qemu-ppc][PATCH v8 2/2] Add USB enablement on sPAPR platform.

2012-08-15 Thread Alexander Graf
On 15.08.2012, at 08:00, Li Zhang zhlci...@linux.vnet.ibm.com wrote: On 2012年08月15日 02:09, Alexander Graf wrote: On 14.08.2012, at 19:49, Li Zhang zhlci...@gmail.com wrote: USB is enabled as default on sPAPR platform because it needs USB keyboard and USB mouse when VGA is enabled.

[Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe
--- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 12ca76d..1c8b049 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -76,6 +76,10 @@ static void

[Qemu-devel] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe
This patch fixes two main issues with block/iscsi.c: 1.) iscsi_task_mgmt_abort_task_async calls iscsi_scsi_task_cancel which was also directly called in iscsi_aio_cancel 2.) a race between task completition and task abortion could happen cause the scsi_free_scsi_task were done before

[Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe
Signed-off-by: Stefan Priebe s.pri...@profihost.ag --- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 12ca76d..1c8b049 100644 --- a/block/iscsi.c +++

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe - Profihost AG
This patch fixes two main issues with block/iscsi.c: 1.) iscsi_task_mgmt_abort_task_async calls iscsi_scsi_task_cancel which was also directly called in iscsi_aio_cancel 2.) a race between task completition and task abortion could happen cause the scsi_free_scsi_task were done before

Re: [Qemu-devel] [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-08-15 Thread Rusty Russell
On Tue, 14 Aug 2012 14:56:07 -0500, Anthony Liguori aligu...@us.ibm.com wrote: Cornelia Huck cornelia.h...@de.ibm.com writes: Add a driver for kvm guests that matches virtual ccw devices provided by the host as virtio bridge devices. These virtio-ccw devices use a special set of channel

[Qemu-devel] [PATCH 00/18] qapi: Convert savevm, loadvm, delvm and info snapshots

2012-08-15 Thread Pavel Hrdina
This patch series convert these commands into qapi and intruduce QMP commands vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots. It also rewrite error report for function used by these commands. Last two patches introduce new functionality of savevm and

[Qemu-devel] [PATCH 16/18] qapi: Convert info snapshots

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hmp.c| 33 + hmp.h| 1 + monitor.c| 2 +- qapi-schema.json | 34 ++ qmp-commands.hx | 30 ++ savevm.c | 51

[Qemu-devel] [PATCH 0/2 v2] s390: block size auto-sensing and geometry guessing changes in common code

2012-08-15 Thread Jens Freimann
v1-v2: do BLKPBSZGET ioctl in Patch 1/2 only when running on Linux Here are two patches for block device characteristics detection. The first one implements block size auto-sensing for virtio-block and the second patch changes geometry guessing common code. More details in the patch descriptions.

[Qemu-devel] [PATCH 1/2] virtio-block: support auto-sensing of block sizes

2012-08-15 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com Virtio-blk does not impose fixed block sizes for access to backing devices. This patch introduces support for auto lookup of the block sizes of the backing block device. This automatic lookup needs to be enabled explicitly. Users may do this by

[Qemu-devel] [PATCH 2/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-08-15 Thread Jens Freimann
From: Einar Lueck elelu...@linux.vnet.ibm.com This patch extends the function guess_disk_lchs. If no geo could be derived from reading disk content, HDIO_GETGEO ioctl is issued. If this is not successful (e.g. image files) geometry is derived from the size of the disk (as before). To achieve

Re: [Qemu-devel] [PATCH 0/4] [PULL] qemu-kvm.git uq/master queue

2012-08-15 Thread Peter Maydell
On 15 August 2012 00:59, Marcelo Tosatti mtosa...@redhat.com wrote: The following changes since commit 873359d411eeb380906761e46839a2b705dbcf75: Merge branch 'linux-user.next' of git://git.linaro.org/people/pmaydell/qemu-arm (2012-08-14 19:50:22 +) are available in the git repository

Re: [Qemu-devel] [PULL 0/6 1.2] Tracing patches for QEMU 1.2

2012-08-15 Thread Stefan Hajnoczi
On Tue, Aug 14, 2012 at 7:44 PM, Anthony Liguori aligu...@us.ibm.com wrote: Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: The last pull request from 19 July was not merged. Here it is rebased on qemu.git/master with two additional fixes from Stefan Weil. I'm not sure what you mean:

Re: [Qemu-devel] [PATCH 3/4] s390/kvm: Add a channel I/O based virtio transport driver.

2012-08-15 Thread Christian Borntraeger
Have you written an appendix for the virtio specification for virtio-ccw? I think it would be good to include in this series for the purposes of review. Might be nice, but don't get fancy about it. Text will be fine and I can cut paste it in once it's finalized. There was a patch

[Qemu-devel] [Bug 1036987] [NEW] compilation error due to bug in savevm.c

2012-08-15 Thread Evgeny Voevodin
Public bug reported: Since 302dfbeb21fc5154c24ca50d296e865a3778c7da Add xbzrle_encode_buffer and xbzrle_decode_buffer functions For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword -

[Qemu-devel] [PATCH 03/18] block: add error parameter to bdrv_snapshot_goto() and related functions

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- block.c| 26 +++--- block.h| 3 ++- block/qcow2-snapshot.c | 11 --- block/qcow2.h | 4 +++- block/rbd.c| 6 +- block/sheepdog.c | 16 +---

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-15 Thread Kevin Wolf
Am 15.08.2012 07:21, schrieb Bharata B Rao: On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote: +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void *arg) +{ +GlusterAIOCB *acb = (GlusterAIOCB *)arg; +BDRVGlusterState *s = acb-common.bs-opaque; + +

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread ronnie sahlberg
Acked-by: Ronnie Sahlberg ronniesahlb...@gmail.com On Wed, Aug 15, 2012 at 5:09 PM, Stefan Priebe s.pri...@profihost.ag wrote: Signed-off-by: Stefan Priebe s.pri...@profihost.ag --- block/iscsi.c | 55 +++ 1 files changed, 23

[Qemu-devel] [RFC] libqblock-API v2, re-designed

2012-08-15 Thread Wenchao Xia
Hi, according to the comments, the header files were adjusted as following: 1 info are sorted into two kinds of structure: location and format, which are both union + structure type. 2 removed size_struct. Although it is suggested to use pointer to make embbed struct easier, but with union

Re: [Qemu-devel] [PATCH 2/2] pc: Fix RTC CMOS info on RAM for ram_size 1MiB

2012-08-15 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Tue, Aug 14, 2012 at 11:58 AM, Markus Armbruster arm...@redhat.com wrote: pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to lots of extended memory. Fix both, and clean up some.

Re: [Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-15 Thread Gerd Hoffmann
On 08/07/12 08:27, Gerd Hoffmann wrote: Without the patch bus properties are are not in line with the other properties: [ ... ] dev: fw_cfg, id ctl_iobase = 0x510 data_iobase = 0x511 irq 0 mmio /0002 mmio

[Qemu-devel] [PATCH 05/18] block: add error parameter to bdrv_snapshot_list() and related functions

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- block.c| 25 + block.h| 3 ++- block/qcow2-snapshot.c | 4 +++- block/qcow2.h | 4 +++- block/rbd.c| 4 +++- block/sheepdog.c | 11 +-- block_int.h

[Qemu-devel] [PATCH 06/18] block: add error parameter to bdrv_snapshot_find()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- savevm.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/savevm.c b/savevm.c index 92da274..55b65cf 100644 --- a/savevm.c +++ b/savevm.c @@ -2015,16 +2015,21 @@ out: return ret; } -static

[Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- block.c| 25 + block.h| 3 ++- block/qcow2-snapshot.c | 9 - block/qcow2.h | 4 +++- block/rbd.c| 20 ++-- block/sheepdog.c | 17

[Qemu-devel] [PATCH 14/18] qapi: Convert loadvm

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hmp-commands.hx | 2 +- hmp.c| 10 + hmp.h| 1 + monitor.c| 12 --- qapi-schema.json | 15 ++ qmp-commands.hx | 25 ++ savevm.c | 63

[Qemu-devel] [PATCH 07/18] block: add error parameter to del_existing_snapshots()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- savevm.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index 55b65cf..0d14f71 100644 --- a/savevm.c +++ b/savevm.c @@ -2048,22 +2048,18 @@ static int bdrv_snapshot_find(BlockDriverState *bs,

[Qemu-devel] [PATCH 11/18] savevm: add error parameter to qemu_savevm_state()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- savevm.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index 0f7d681..0d54115 100644 --- a/savevm.c +++ b/savevm.c @@ -1741,7 +1741,8 @@ void qemu_savevm_state_cancel(QEMUFile *f)

[Qemu-devel] [PATCH 18/18] vm-snapshot-save: add force parameter

2012-08-15 Thread Pavel Hrdina
HMP command savevm now takes extra optional force parameter to specifi whether replace existing snapshot or not. QMP command vm-snapshot-save has also extra optional force parameter and name parameter isn't optional anymore. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hmp-commands.hx |

[Qemu-devel] [PATCH 09/18] savevm: add error parameter to qemu_savevm_state_iterate()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- migration.c | 2 +- savevm.c| 11 +-- sysemu.h| 3 ++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/migration.c b/migration.c index dde4dec..1e71374 100644 --- a/migration.c +++ b/migration.c @@ -321,7 +321,7

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Gerd Hoffmann
On 08/09/12 16:21, Alon Levy wrote: Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. Patch doesn't apply cleanly to master. +if $pkg_config --atleast-version=0.12.0 spice-protocol /dev/null 21;

Re: [Qemu-devel] [PATCH] let qemu-img info genereate json output

2012-08-15 Thread Benoît Canet
Le Friday 27 Jul 2012 à 08:50:43 (-0500), Anthony Liguori a écrit : Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch would add option -j in qemu-img info command, which would generate json output in stdout. This is a great idea. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-15 Thread Bharata B Rao
On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote: Am 14.08.2012 06:38, schrieb Bharata B Rao: Kevin, Thanks for your review. I will address all of your comments in the next iteration, but have a few questions/comments on the others... On Mon, Aug 13, 2012 at 02:50:29PM +0200,

[Qemu-devel] [PATCH 17/18] hmp: allow bool parameter to be optional

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- monitor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/monitor.c b/monitor.c index db9a8d0..a538e6a 100644 --- a/monitor.c +++ b/monitor.c @@ -3769,6 +3769,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,

[Qemu-devel] [PATCH 10/18] savevm: add error parameter to qemu_savevm_state_complete()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- migration.c | 2 +- savevm.c| 13 ++--- sysemu.h| 3 ++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/migration.c b/migration.c index 1e71374..ec2f267 100644 --- a/migration.c +++ b/migration.c @@ -331,7

Re: [Qemu-devel] [PATCH 2/3] vfio: vfio-pci device assignment driver

2012-08-15 Thread Avi Kivity
On 08/14/2012 08:23 PM, Alex Williamson wrote: Unrelated nit: memcmp() doesn't return a boolean or a count, so !memcmp() is really unintuitive, at least to me. I figure we're all pretty used to it growing up on !strcmp though. I hate that one too. + +/* XXX This should move to msi.c

Re: [Qemu-devel] Qemu memory operations

2012-08-15 Thread Prathmesh Kallurkar
1. Did you get the guest physical address for the load/store instructions? No, I am getting the guest virtual address for the load and store instructions. 2. The code you pasted seems translated code. The number of input code could be smaller than this. So don't you think we should trap the

[Qemu-devel] [PATCH 04/18] block: add error parameter to bdrv_snapshot_delete() and related functions

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- block.c| 26 ++ block.h| 4 +++- block/qcow2-snapshot.c | 9 - block/qcow2.h | 4 +++- block/rbd.c| 6 +- block/sheepdog.c | 4 +++- block_int.h

[Qemu-devel] [PATCH 12/18] savevm: add error parameter to qemu_loadvm_state()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- migration.c | 2 +- savevm.c| 44 sysemu.h| 3 ++- 3 files changed, 31 insertions(+), 18 deletions(-) diff --git a/migration.c b/migration.c index ec2f267..f048faf 100644 --- a/migration.c

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-08-15 Thread Bug Watch Updater
** Changed in: qemu-kvm (Debian) Status: Unknown = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033727 Title: USB passthrough doesn't work anymore with qemu-kvm 1.1.1 Status in

[Qemu-devel] [PATCH 15/18] qapi: Convert delvm

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hmp-commands.hx | 2 +- hmp.c| 10 ++ hmp.h| 1 + qapi-schema.json | 14 ++ qmp-commands.hx | 24 savevm.c | 17 +++-- sysemu.h | 1 - 7 files

[Qemu-devel] [PATCH 13/18] qapi: Convert savevm

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- hmp-commands.hx | 2 +- hmp.c| 10 ++ hmp.h| 1 + qapi-schema.json | 19 +++ qmp-commands.hx | 29 + savevm.c | 25 + sysemu.h

[Qemu-devel] [PATCH 08/18] savevm: add error parameter to qemu_savevm_state_begin()

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- migration.c | 2 +- savevm.c| 7 +-- sysemu.h| 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/migration.c b/migration.c index 653a3c1..dde4dec 100644 --- a/migration.c +++ b/migration.c @@ -429,7 +429,7 @@ void

[Qemu-devel] [PATCH 01/18] qerror: introduce QERR_GENERIC_ERROR

2012-08-15 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina phrd...@redhat.com --- qerror.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qerror.h b/qerror.h index d0a76a4..7e0bae7 100644 --- a/qerror.h +++ b/qerror.h @@ -120,6 +120,9 @@ void assert_no_error(Error *err); #define QERR_FEATURE_DISABLED \

[Qemu-devel] [PATCH] savevm.c: Fix compilation error on 32bit host.

2012-08-15 Thread Evgeny Voevodin
Casting of 0x0101010101010101ULL to long will truncate it to 32 bits on 32bit hosts, and won't truncate on 64bit hosts. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- savevm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-15 Thread Bharata B Rao
On Wed, Aug 15, 2012 at 10:00:27AM +0200, Kevin Wolf wrote: Am 15.08.2012 07:21, schrieb Bharata B Rao: On Tue, Aug 14, 2012 at 10:29:26AM +0200, Kevin Wolf wrote: +static void gluster_finish_aiocb(struct glfs_fd *fd, ssize_t ret, void *arg) +{ +GlusterAIOCB *acb = (GlusterAIOCB

Re: [Qemu-devel] [Bug 1036987] [NEW] compilation error due to bug in savevm.c

2012-08-15 Thread Peter Maydell
On 15 August 2012 08:44, Evgeny Voevodin e.voevo...@samsung.com wrote: Since 302dfbeb21fc5154c24ca50d296e865a3778c7da Add xbzrle_encode_buffer and xbzrle_decode_buffer functions commit arrived into master barnch, I can't compile qemu at all: savevm.c:2476:13: error: overflow in implicit

Re: [Qemu-devel] [Qemu-ppc] [0/10] pseries updates and cleanups

2012-08-15 Thread Alexander Graf
On 15.08.2012, at 03:05, David Gibson wrote: On Tue, Aug 14, 2012 at 02:56:43PM +0200, Alexander Graf wrote: On 08/14/2012 02:34 PM, Alexander Graf wrote: On 08/08/2012 04:10 AM, David Gibson wrote: Hi Alex, This series contains all my outstanding pseries updates which aren't dependent

Re: [Qemu-devel] [PATCH] savevm.c: Fix compilation error on 32bit host.

2012-08-15 Thread Peter Maydell
On 15 August 2012 10:10, Evgeny Voevodin e.voevo...@samsung.com wrote: Casting of 0x0101010101010101ULL to long will truncate it to 32 bits on 32bit hosts, and won't truncate on 64bit hosts. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com Dup of http://patchwork.ozlabs.org/patch/177217/

[Qemu-devel] [PATCH v2 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-15 Thread Markus Armbruster
Partial pages make little sense and don't work. Ensure the RAM size is a multiple of any possible target's page size. Fixes $ qemu-system-x86_64 -nodefaults -S -vnc :0 -m 0.8 qemu-system-x86_64: /work/armbru/qemu/exec.c:2255: register_subpage: Assertion `existing-mr-subpage ||

[Qemu-devel] [PATCH v2 2/2] pc: Fix RTC CMOS info on RAM for ram_size 1MiB

2012-08-15 Thread Markus Armbruster
pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to lots of extended memory. Fix both, and clean up some. Note: SeaBIOS currently requires 1MiB of RAM, and doesn't check whether it got enough. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v2 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
There are more, but let's start with these two. v2: * Use QEMU_ALIGN_UP (Avi) * Cover size overflow * Coding style (Blue) Markus Armbruster (2): vl: Round argument of -m up to multiple of 8KiB pc: Fix RTC CMOS info on RAM for ram_size 1MiB hw/pc.c | 31 ++-

Re: [Qemu-devel] [PATCH] savevm.c: Fix compilation error on 32bit host.

2012-08-15 Thread Evgeny Voevodin
On 08/15/2012 01:30 PM, Peter Maydell wrote: On 15 August 2012 10:10, Evgeny Voevodin e.voevo...@samsung.com wrote: Casting of 0x0101010101010101ULL to long will truncate it to 32 bits on 32bit hosts, and won't truncate on 64bit hosts. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com

Re: [Qemu-devel] [PATCH v8] kvm: notify host when the guest is panicked

2012-08-15 Thread Gleb Natapov
On Tue, Aug 14, 2012 at 02:35:34PM -0500, Anthony Liguori wrote: Do you consider allowing support for Windows as overengineering? I don't think there is a way to hook BSOD on Windows so attempting to engineer something that works with Windows seems odd, no? Yan says in other email that is

[Qemu-devel] [PULL 00/24] ppc patch queue 2012-08-15

2012-08-15 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 03834e22abafbc8dc4052d46a5ccd6dd135a54a3: Anthony Liguori (1): Merge remote-tracking branch 'origin/master' into staging are available in the git repository at:

[Qemu-devel] [PATCH 21/24] pseries: Add PCI MSI/MSI-X support

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This patch implements MSI and MSI-X support for the pseries PCI host bridge. To do this it adds: * A config_space_address to msi_table map, since the MSI RTAS calls take a PCI config space address as an identifier. * A MSIX memory region to catch

Re: [Qemu-devel] [PATCH 01/24] pseries pci: removed redundant busdev

2012-08-15 Thread Andreas Färber
Am 15.08.2012 11:58, schrieb Alexander Graf: From: Alexey Kardashevskiy a...@ozlabs.ru The PCIHostState struct already contains SysBusDevice so the one in sPAPRPHBState has to go. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Alexander Graf ag...@suse.de As mentioned,

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Kevin Wolf
Am 15.08.2012 10:13, schrieb ronnie sahlberg: Acked-by: Ronnie Sahlberg ronniesahlb...@gmail.com On Wed, Aug 15, 2012 at 5:09 PM, Stefan Priebe s.pri...@profihost.ag wrote: Signed-off-by: Stefan Priebe s.pri...@profihost.ag --- block/iscsi.c | 55

[Qemu-devel] [PATCH 04/24] PPC: e500: change internal references away from mpc8544ds

2012-08-15 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com No functional changes -- machine is still outwardly mpc8544ds. The references that are not changed contain mpc8544 hardware details that need to be parameterized if/when a different e500 platform wants to change them. Signed-off-by: Scott Wood

[Qemu-devel] [PATCH 18/24] pseries: added allocator for a block of IRQs

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru The patch adds a simple helper which allocates a consecutive sequence of IRQs calling spapr_allocate_irq for each and checks that allocated IRQs go consequently. The patch is required for upcoming support of MSI/MSIX on POWER. Signed-off-by: Alexey

Re: [Qemu-devel] What is cpu_A0 in target-i386/translate.c

2012-08-15 Thread Andreas Färber
Hi, Am 15.08.2012 08:33, schrieb Steven: I would like to trace the guest physical address of the load instructions from the guest. I thought the cpu_A0 is the memory address to be accessed. However, when I print out the value of cpu_A0, like static inline void gen_op_ld_v(int idx, TCGv t0,

[Qemu-devel] [PATCH 19/24] pseries: Export find_phb() utility function for PCI code

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru The pseries PCI code makes use of an internal find_dev() function which locates a PCIDevice * given a (platform specific) bus ID and device address. Internally this needs to first locate the host bridge on which the device resides based on the bus ID.

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Alon Levy
On Wed, Aug 15, 2012 at 10:23:23AM +0200, Gerd Hoffmann wrote: On 08/09/12 16:21, Alon Levy wrote: Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. Patch doesn't apply cleanly to master.

[Qemu-devel] [PATCH] Add support for pretty-printing response in qmp-shell

2012-08-15 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Add a '-p' arg to the QMP/qmp-shell test program, which uses the python pprint module to pretty-print the dictionary returned from a command $ qmp-shell -p /tmp/qemu Welcome to the QMP low-level shell! Connected to QEMU 1.1.50 (QEMU)

[Qemu-devel] [PATCH 23/24] pseries: Update SLOF firmware image

2012-08-15 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au This updates SLOF to handle the necessary device tree properties for MSI and MSI-X. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexander Graf ag...@suse.de --- pc-bios/README |2 +- pc-bios/slof.bin | Bin 878088 -

[Qemu-devel] [PATCH 15/24] pseries: Remove extraneous prints

2012-08-15 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au The pseries machine prints several messages to stderr whenever it starts up and another whenever the vm is reset. It's not normal for qemu machines to do this though, so this patch removes them. We can put them back conditional on a DEBUG symbol if

[Qemu-devel] [PATCH 12/24] PPC: spapr: Rework VGA select logic

2012-08-15 Thread Alexander Graf
When selecting our VGA adapter, we want to: * fail completely when we can't satisfy the user's request * support -nographic where no VGA adapter should be spawned This patch reworks the logic so we fulfill the two conditions above. Signed-off-by: Alexander Graf ag...@suse.de --- hw/spapr.c

[Qemu-devel] [PATCH 24/24] openpic: Added BRR1 register

2012-08-15 Thread Alexander Graf
From: Bharat Bhushan r65...@freescale.com Linux mpic driver uses (changes may be in pipeline to get upstreamed soon) BRR1. This patch adds the support to emulate readonly FSL BRR1 register. Currently QEMU does not fully emulate any version on MPIC, so the MPIC Major number and Minor number are

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Gerd Hoffmann
Hi, Or maybe just use #ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC $whatever #endif I don't get this. You mean to have add #define QXL_HAS_IO_MONITORS_CONFIG_ASYNC bla to spice-protocol? No, to qemu, so QXL_HAS_IO_MONITORS_CONFIG_ASYNC is

Re: [Qemu-devel] [RFC V2 03/10] quorum: Add quorum_open().

2012-08-15 Thread Kevin Wolf
Am 14.08.2012 18:56, schrieb Benoît Canet: Le Monday 13 Aug 2012 à 09:41:00 (+0200), Kevin Wolf a écrit : Am 10.08.2012 19:48, schrieb Benoît Canet: Le Tuesday 07 Aug 2012 à 20:30:09 (+), Blue Swirl a écrit : On Tue, Aug 7, 2012 at 1:44 PM, Benoît Canet benoit.ca...@gmail.com wrote:

[Qemu-devel] [PATCH 03/24] PPC: e500: rename mpc8544ds into generic file

2012-08-15 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com Rename the file (with no changes other than fixing up the header paths) in preparation for refactoring into a generic e500 platform. Also move it into the newly created ppc/ directory. Signed-off-by: Scott Wood scottw...@freescale.com Reviewed-by:

[Qemu-devel] [PATCH 20/24] pseries: Add trace event for PCI irqs

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru This adds a trace event in the pseries PCI specific set_irq() function to assist in debugging. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: David Gibson da...@gibson.dropbear.id.au [agraf: add trace.h include] Signed-off-by:

Re: [Qemu-devel] [RFC V3 9/9] quorum: Add quorum mechanism.

2012-08-15 Thread Stefan Hajnoczi
On Tue, Aug 14, 2012 at 04:14:11PM +0200, Benoît Canet wrote: +#define QUORUM_FREE_QIOV_ITEMS(qlist) do { \ +QLIST_FOREACH_SAFE(item, qlist, next, next_item) { \ +QLIST_REMOVE(item, next); \ +g_free(item);

Re: [Qemu-devel] [RFC V3 8/9] quorum: Add quorum_aio_readv.

2012-08-15 Thread Stefan Hajnoczi
On Tue, Aug 14, 2012 at 04:14:10PM +0200, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 86962b4..8b449fb

[Qemu-devel] [PATCH 17/24] pseries: Separate PCI RTAS setup from common from emulation specific PCI setup

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru Currently the RTAS functions for handling PCI are registered from the class init code for the PCI host bridge. That sort of makes sense now, but will break in the future when vfio gives us multiple types of host bridge for pseries (emulated and

[Qemu-devel] [PATCH] block: Flush parent to OS with cache=unsafe

2012-08-15 Thread Kevin Wolf
Commit 29cdb251 already added a comment that no unnecessary flushes to disk will occur, this patch makes the code even get to the point of the comment. This is mostly theoretical because in practice we only stack one format on top of one protocol, the former implementing flush_to_os and the latter

[Qemu-devel] [PATCH 09/24] Add one new file vga-pci.h and cleanup on all platforms

2012-08-15 Thread Alexander Graf
From: zhlci...@gmail.com zhlci...@gmail.com Functions pci_vga_init() and pci_cirrus_vga_init() are declared in pc.h. That prevents other platforms (e.g. sPAPR) to use them. This patch is to create one new file vga-pci.h and move the declarations to vga-pci.h, so that they can be shared by all

[Qemu-devel] [PATCH 11/24] xbzrle: fix compilation on ppc32

2012-08-15 Thread Alexander Graf
When compiling the xbzrle code on my ppc32 user space, I hit the following gcc compiler warning (treated as an error): cc1: warnings being treated as errors savevm.c: In function ‘xbzrle_encode_buffer’: savevm.c:2476: error: overflow in implicit constant conversion Fix this by making the

[Qemu-devel] [PATCH 08/24] Revert PPC: e500: Use new MPIC dt format

2012-08-15 Thread Alexander Graf
This reverts commit 518c7fb44f2182cde943dc64f88cb2fd4e4ff6b5. It breaks new Linux guests with SMP, because IPIs get mapped to large vectors which our MPIC emulation does not implement. Conflicts: hw/ppc/e500.c --- hw/ppc/e500.c | 31 ++- 1 files changed, 14

[Qemu-devel] [PATCH 01/24] pseries pci: removed redundant busdev

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru The PCIHostState struct already contains SysBusDevice so the one in sPAPRPHBState has to go. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Alexander Graf ag...@suse.de --- hw/spapr_pci.c |4 ++-- hw/spapr_pci.h |1 - 2 files

[Qemu-devel] [PATCH 10/24] spapr: Add support for -vga option

2012-08-15 Thread Alexander Graf
From: zhlci...@gmail.com zhlci...@gmail.com Also instanciate the USB keyboard and mouse when that option is used (you can still use -device to create individual devices without all the defaults) Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Li Zhang

Re: [Qemu-devel] [PATCH] savevm.c: Fix compilation error on 32bit host.

2012-08-15 Thread Michael Tokarev
On 15.08.2012 13:10, Evgeny Voevodin wrote: Casting of 0x0101010101010101ULL to long will truncate it to 32 bits on 32bit hosts, and won't truncate on 64bit hosts. Signed-off-by: Evgeny Voevodin e.voevo...@samsung.com --- savevm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-15 Thread Peter Maydell
Move the init of the irqchip_inject_ioctl field of KVMState out of kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() can be used even when no irqchip is created (for architectures that support async interrupt notification even without an in kernel irqchip). Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
Sent the wrong one. v3 coming. Sorry for the inconvenience.

[Qemu-devel] [PATCH v3 2/2] pc: Fix RTC CMOS info on RAM for ram_size 1MiB

2012-08-15 Thread Markus Armbruster
pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB extended memory. The latter can underflow to lots of extended memory. Fix both, and clean up some. Note: SeaBIOS currently requires 1MiB of RAM, and doesn't check whether it got enough. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v3 1/2] vl: Round argument of -m up to multiple of 8KiB

2012-08-15 Thread Markus Armbruster
Partial pages make little sense and don't work. Ensure the RAM size is a multiple of any possible target's page size. Fixes $ qemu-system-x86_64 -nodefaults -S -vnc :0 -m 0.8 qemu-system-x86_64: /work/armbru/qemu/exec.c:2255: register_subpage: Assertion `existing-mr-subpage ||

[Qemu-devel] [PATCH 05/24] PPC: e500: split mpc8544ds machine from generic e500 code

2012-08-15 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com Currently the only mpc8544ds-ism that is factored out is toplevel compatible and model. In the future the generic e500 code is expected to become more generic. Signed-off-by: Scott Wood scottw...@freescale.com [agraf: conditionalize on CONFIG_FDT]

[Qemu-devel] [PATCH v3 0/2] Fix two bugs related to ram_size

2012-08-15 Thread Markus Armbruster
There are more, but let's start with these two. v1 - v3: * Use QEMU_ALIGN_UP (Avi) * Cover size overflow * Coding style (Blue) Markus Armbruster (2): vl: Round argument of -m up to multiple of 8KiB pc: Fix RTC CMOS info on RAM for ram_size 1MiB hw/pc.c | 31 ++-

[Qemu-devel] [PATCH 06/24] PPC: e500: add generic e500 platform

2012-08-15 Thread Alexander Graf
From: Scott Wood scottw...@freescale.com This gives the kernel a paravirtualized machine to target, without requiring both sides to pretend to be targeting a specific board that likely has little to do with the host in KVM scenarios. This avoids the need to add new boards to QEMU, just to be

[Qemu-devel] [PATCH 13/24] PPC: spapr: Remove global variable

2012-08-15 Thread Alexander Graf
Global variables are bad. Let's move spapr_has_graphics into the machine state struct. Signed-off-by: Alexander Graf ag...@suse.de --- hw/spapr.c |5 ++--- hw/spapr.h |1 + 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/spapr.c b/hw/spapr.c index 709673e..aa39d2d

[Qemu-devel] [PATCH 22/24] pseries dma: DMA window params added to PHB and DT population changed

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru Previously the only PCI bus supported was the emulated PCI bus with fixed DMA window with start at 0 and size 1GB. As we are going to support PCI pass through which DMA window properties are set by the host kernel, we have to support DMA windows with

[Qemu-devel] [PATCH 16/24] pseries: Rework irq assignment to avoid carrying qemu_irqs around

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru Currently, the interfaces in the pseries machine code for assignment and setup of interrupts pass around qemu_irq objects. That was done in an attempt not to be too closely linked to the specific XICS interrupt controller. However interactions with the

Re: [Qemu-devel] [PATCH] Add support for pretty-printing response in qmp-shell

2012-08-15 Thread Peter Maydell
On 15 August 2012 11:33, Daniel P. Berrange berra...@redhat.com wrote: class QMPShell(qmp.QEMUMonitorProtocol): -def __init__(self, address): +def __init__(self, address, pp=None): qmp.QEMUMonitorProtocol.__init__(self, self.__get_address(address)) self._greeting =

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-15 Thread Hans de Goede
Hi, On 08/14/2012 06:12 PM, Hans de Goede wrote: Hi, While testing qemu-master I've encountered 2 problems caused by the ehci changes made since 1.1: 1) Newly plugged in devices don't get recognized by the guest This seems to be a case of no interrupt getting generated while it should, doing

[Qemu-devel] [PATCH 02/24] pseries pci: spapr_populate_pci_devices renamed to spapr_populate_pci_dt

2012-08-15 Thread Alexander Graf
From: Alexey Kardashevskiy a...@ozlabs.ru spapr_populate_pci_devices() populates the device tree only with bus properties and has nothing to do with the devices on it as PCI BAR allocation is done by the system firmware (SLOF). New name - spapr_populate_pci_dt() - describes the functionality

[Qemu-devel] [PATCH 07/24] ppc: Fix bug in handling of PAPR hypercall exits

2012-08-15 Thread Alexander Graf
From: David Gibson da...@gibson.dropbear.id.au Currently for powerpc, kvm_arch_handle_exit() always returns 1, meaning that its caller - kvm_cpu_exec() - will always exit immediately afterwards to the loop in qemu_kvm_cpu_thread_fn(). There's no need to do this. Once we've handled the hypercall

[Qemu-devel] [PATCH v2] Makefile: Avoid explicit list of directories in clean target

2012-08-15 Thread Peter Maydell
Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Changes v1-v2: use portable 'find -exec' rather than unsafe 'find | xargs' or unportable 'find -print0 | xargs -0'.

Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 1/3] Add USB option in machine options

2012-08-15 Thread David Gibson
On Wed, Aug 15, 2012 at 01:44:28PM +0800, Li Zhang wrote: On Wed, Aug 15, 2012 at 10:57 AM, David Gibson d...@au1.ibm.com wrote: On Wed, Aug 15, 2012 at 10:50:04AM +0800, Li Zhang wrote: On Wed, Aug 15, 2012 at 9:47 AM, David Gibson d...@au1.ibm.com wrote: On Wed, Aug 15, 2012 at

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-15 Thread Gerd Hoffmann
On 08/15/12 13:22, Hans de Goede wrote: Hi, On 08/14/2012 06:12 PM, Hans de Goede wrote: Hi, While testing qemu-master I've encountered 2 problems caused by the ehci changes made since 1.1: 1) Newly plugged in devices don't get recognized by the guest This seems to be a case of no

  1   2   3   4   >