Re: [Qemu-devel] [PATCH v9 5/6] introduce a new qom device to deal with panicked event

2012-08-24 Thread Wen Congyang
At 08/23/2012 06:51 PM, Jan Kiszka Wrote: On 2012-08-23 04:32, Wen Congyang wrote: If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new qom device kvm_pv_ioport to listen this I/O port, and deal with

Re: [Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-24 Thread Gerd Hoffmann
On 08/15/12 10:26, Gerd Hoffmann wrote: On 08/07/12 08:27, Gerd Hoffmann wrote: Without the patch bus properties are are not in line with the other properties: [ ... ] dev: fw_cfg, id ctl_iobase = 0x510 data_iobase = 0x511 irq 0 mmio

[Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Jan Kiszka
From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. It also tried to handle the case of vectors shared between different sources of the same device. However, this never really worked and

Re: [Qemu-devel] [PATCH v9 5/6] introduce a new qom device to deal with panicked event

2012-08-24 Thread Jan Kiszka
On 2012-08-24 08:05, Wen Congyang wrote: At 08/23/2012 06:51 PM, Jan Kiszka Wrote: On 2012-08-23 04:32, Wen Congyang wrote: If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new qom device kvm_pv_ioport

Re: [Qemu-devel] [PATCH v9 5/6] introduce a new qom device to deal with panicked event

2012-08-24 Thread Wen Congyang
At 08/24/2012 02:21 PM, Jan Kiszka Wrote: On 2012-08-24 08:05, Wen Congyang wrote: At 08/23/2012 06:51 PM, Jan Kiszka Wrote: On 2012-08-23 04:32, Wen Congyang wrote: If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_EVENT_PORT when it is panciked. This patch

Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast

2012-08-24 Thread Hannes Reinecke
On 08/23/2012 11:02 PM, Stefan Weil wrote: Type casts from pointer to integer values must use uintptr_t instead of unsigned long. Otherwise the compiler complains on hosts with sizeof(pointer) != sizeof(long). The patch also replace magic number 32 by sizeof(info.serial_number) which has the

Re: [Qemu-devel] [PATCH v9 5/6] introduce a new qom device to deal with panicked event

2012-08-24 Thread Jan Kiszka
On 2012-08-24 08:33, Wen Congyang wrote: At 08/24/2012 02:21 PM, Jan Kiszka Wrote: On 2012-08-24 08:05, Wen Congyang wrote: At 08/23/2012 06:51 PM, Jan Kiszka Wrote: On 2012-08-23 04:32, Wen Congyang wrote: If the target is x86/x86_64, the guest's kernel will write 0x01 to the port

Re: [Qemu-devel] What's the proper type of guest pde address, target_ulong or target_phys_addr_t?

2012-08-24 Thread Peter Maydell
On 24 August 2012 04:34, 陳韋任 (Wei-Ren Chen) che...@iis.sinica.edu.tw wrote: Hi all, When I read cpu_get_phys_page_debug (target-i386/helper.c), I found the type of pde_addr and pte_addr might be not correct. See below, --- target_phys_addr_t cpu_get_phys_page_debug(CPUX86State *env,

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Peter Maydell
On 24 August 2012 06:44, Jan Kiszka jan.kis...@web.de wrote: On 2012-08-24 05:58, malc wrote: On Thu, 23 Aug 2012, Matthew Ogilvie wrote: After applying this version 2 of this patch series, I can successfully run Micoport UNIX System V/386, v 2.1 (ca 1987) under qemu. (although not if I try

Re: [Qemu-devel] [PATCH v9 5/6] introduce a new qom device to deal with panicked event

2012-08-24 Thread Wen Congyang
At 08/24/2012 02:30 PM, Jan Kiszka Wrote: On 2012-08-24 08:33, Wen Congyang wrote: At 08/24/2012 02:21 PM, Jan Kiszka Wrote: On 2012-08-24 08:05, Wen Congyang wrote: At 08/23/2012 06:51 PM, Jan Kiszka Wrote: On 2012-08-23 04:32, Wen Congyang wrote: If the target is x86/x86_64, the guest's

Re: [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer handler

2012-08-24 Thread Paolo Bonzini
Il 23/08/2012 20:09, Jan Kiszka ha scritto: On 2012-08-23 15:11, Paolo Bonzini wrote: So, in order to remove the qemu_notify_event completely, what about not using signals anymore for timers? You could just tweak the select timeout and drop all the -clock madness. Zero syscalls, practically

[Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy

2012-08-24 Thread rongqing.li
From: Roy.Li rongqing...@windriver.com Only one hub port's peer can_receive() returns 1, the source hub port .can_receive should return 1, to fix the below bug: The up state NIC can not receive any packets if guest has more than two NICs and only one NIC is in down state.

[Qemu-devel] [PATCH 1/2] Usb: create the receive queue for the virtual USB NIC

2012-08-24 Thread rongqing.li
From: Roy.Li rongqing...@windriver.com The virtual USB NIC originally used a fixed buffer to receive packets which only store 1 packet at a time, which is easy to overrun with packets if the guest does not consume it quickly, and always lost packets at the below case: The emulated

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 02:45, Nicholas A. Bellinger ha scritto: So up until very recently, TCM would accept an I/O request for an DATA I/O type CDB with a max_sectors larger than the reported max_sectors for it's TCM backend (regardless of backend type), and silently generate N backend 'tasks' to

Re: [Qemu-devel] [PATCH v2 6/6] i8259: add -no-spurious-interrupt-hack option

2012-08-24 Thread Matthew Ogilvie
On Fri, Aug 24, 2012 at 07:40:36AM +0200, Jan Kiszka wrote: On 2012-08-23 08:24, Matthew Ogilvie wrote: This patch provides a way to optionally suppress spurious interrupts, [snip] I'm not sure why it only sporadically hits this sequence of events. There doesn't seem to be other IRQs

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: On 2012-08-24 01:13, Cam Macdonell wrote: Hi Jan, I've bisected a bug in which MSI interrupts are not being delivered to the following patch, where msix_reset was moved in tot he PCI core. commit

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Jan Kiszka
On 2012-08-24 10:11, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: On 2012-08-24 01:13, Cam Macdonell wrote: Hi Jan, I've bisected a bug in which MSI interrupts are not being delivered to the following patch, where msix_reset was moved in tot he PCI

Re: [Qemu-devel] passing translated address out in QEMU

2012-08-24 Thread Wei-Ren Chen
not too sure how much impact inlined lookup has on the performance. since i disabled it, next step i would just get rid of that piece of generated assembly, as it is no good for icache ( generated for every memory operation). You can run a benchmark inside your guest. I guess if you

Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 10:31, Hannes Reinecke ha scritto: Type casts from pointer to integer values must use uintptr_t instead of unsigned long. Otherwise the compiler complains on hosts with sizeof(pointer) != sizeof(long). The patch also replace magic number 32 by sizeof(info.serial_number) which

Re: [Qemu-devel] [PATCH v2 6/6] i8259: add -no-spurious-interrupt-hack option

2012-08-24 Thread Jan Kiszka
On 2012-08-24 10:05, Matthew Ogilvie wrote: On Fri, Aug 24, 2012 at 07:40:36AM +0200, Jan Kiszka wrote: On 2012-08-23 08:24, Matthew Ogilvie wrote: This patch provides a way to optionally suppress spurious interrupts, [snip] I'm not sure why it only sporadically hits this sequence of

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. It also tried to handle the case of vectors shared between different

Re: [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 09:56, rongqing...@windriver.com ha scritto: Only one hub port's peer can_receive() returns 1, the source hub port .can_receive should return 1, to fix the below bug: The up state NIC can not receive any packets if guest has more than two NICs and only one NIC is in

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Jan Kiszka
On 2012-08-24 10:20, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem via lazy updates. It also tried to handle

Re: [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy

2012-08-24 Thread Rongqing Li
On 2012年08月24日 16:20, Paolo Bonzini wrote: A link-down NIC should always return 1 from can_receive (and will drop the packet). Is that the real bug here? A link-down NIC always return 0 from can_receive. Yes, it is a bug. -Roy Paolo -- Best Reagrds, Roy | RongQing Li

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:15:33AM +0200, Jan Kiszka wrote: On 2012-08-24 10:11, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: On 2012-08-24 01:13, Cam Macdonell wrote: Hi Jan, I've bisected a bug in which MSI interrupts are not being delivered to

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Jan Kiszka
On 2012-08-24 10:21, Jan Kiszka wrote: On 2012-08-24 10:20, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in qemu-kvm to keep KVM route usage low. But now we solved that problem

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:21:44AM +0200, Jan Kiszka wrote: On 2012-08-24 10:20, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in qemu-kvm to keep KVM route usage low. But now

Re: [Qemu-devel] [PATCH v2][for 1.2?] msix: Drop tracking of used vectors

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:35:34AM +0200, Jan Kiszka wrote: On 2012-08-24 10:21, Jan Kiszka wrote: On 2012-08-24 10:20, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 08:19:50AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com This optimization was once used in

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Jan Kiszka
On 2012-08-24 10:36, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 10:15:33AM +0200, Jan Kiszka wrote: On 2012-08-24 10:11, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: On 2012-08-24 01:13, Cam Macdonell wrote: Hi Jan, I've bisected a bug in

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-24 Thread Hannes Reinecke
On 08/24/2012 09:56 AM, Paolo Bonzini wrote: Il 24/08/2012 02:45, Nicholas A. Bellinger ha scritto: So up until very recently, TCM would accept an I/O request for an DATA I/O type CDB with a max_sectors larger than the reported max_sectors for it's TCM backend (regardless of backend type), and

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 12:43:34PM +0200, Hannes Reinecke wrote: On 08/24/2012 09:56 AM, Paolo Bonzini wrote: Il 24/08/2012 02:45, Nicholas A. Bellinger ha scritto: So up until very recently, TCM would accept an I/O request for an DATA I/O type CDB with a max_sectors larger than the reported

Re: [Qemu-devel] [PATCH 1/2 v1] blkdrv: Add queue limits parameters for sg block drive

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 12:43, Hannes Reinecke ha scritto: Hehe. So finally someone else stumbled across this one. All is fine and dandy as long as you're able to use scsi-disk. As soon as you're forced to use scsi-generic we're in trouble. With scsi-generic we actually have two problems: 1)

[Qemu-devel] [PATCH v3 0/3] Microport UNIX series (was: [PATCH v2 0/6] ...)

2012-08-24 Thread Matthew Ogilvie
This version is an incremental on top of version 2 to address various concerns. At least as of this moment, version 2 has been applied upstream, so this version is incremental. On Fri, Aug 24, 2012 at 07:44:16AM +0200, Jan Kiszka wrote: On 2012-08-24 05:58, malc wrote: Applied, thanks. Err,

[Qemu-devel] [PATCH 1/3] debug printf (cirrus_vga): fixup unintended format change

2012-08-24 Thread Matthew Ogilvie
I unintentionally dropped an 02 from one of the format strings in commit 145c7c880ff520a9, as noted by Andreas Färber afaer...@suse.de. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- The 02 in debug code seems extremely low priority, but on the other hand, there is no good reason

[Qemu-devel] [PATCH 3/3] doc: mention that -no-spurious-interrupt-hack doesn't work with KVM

2012-08-24 Thread Matthew Ogilvie
Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- On Fri, Aug 24, 2012 at 07:40:36AM +0200, Jan Kiszka wrote: Has to mention or even actively warn that it doesn't work with KVM and its in-kernel irqchip (as that PIC model lacks your hack). qemu-options.hx | 3 ++- 1 file changed,

Re: [Qemu-devel] MSI-X bug with ivshmem since msix_reset moved to PCI

2012-08-24 Thread Michael S. Tsirkin
On Fri, Aug 24, 2012 at 10:39:15AM +0200, Jan Kiszka wrote: On 2012-08-24 10:36, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 10:15:33AM +0200, Jan Kiszka wrote: On 2012-08-24 10:11, Michael S. Tsirkin wrote: On Fri, Aug 24, 2012 at 07:59:06AM +0200, Jan Kiszka wrote: On 2012-08-24

[Qemu-devel] [PATCH 2/3] vga cga_hack=palette_blanking: narrower conditions for hack

2012-08-24 Thread Matthew Ogilvie
In commit 482f7bf86b43af9f, I mistakenly inverted the logic I intended for ar_flip_flop. I intended to allow the GMODE_BLANK case as soon as any palette register was modified. Also include minor tweak to documentation about how to list multiple hacks on the command line. Signed-off-by: Matthew

Re: [Qemu-devel] What's the proper type of guest pde address, target_ulong or target_phys_addr_t?

2012-08-24 Thread Wei-Ren Chen
In principle, yes, but you need to check the code carefully to make sure your type change doesn't change any of the results. (Or if it does, you then need to confirm against the specs that this was a bug that is being fixed, not a new one being introduced). The thing you have to remember is

[Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware architecture (.e.g. macppc vs powerpc). Signed-off-by: Brad

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-08-24 Thread Stefan Hajnoczi
On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno aurel...@aurel32.net wrote: The lan9118 emulation tries to compute the multicast index by calling directly the crc32() function from zlib, but fails to get the correct result. Use the common compute_mcast_idx() function instead, which gives the

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-24 Thread liu ping fan
On Tue, Aug 21, 2012 at 8:41 PM, Avi Kivity a...@redhat.com wrote: On 08/21/2012 02:18 PM, liu ping fan wrote: But as it will also take the code path which has object_ref(Object*), so it has to convert, otherwise the code will corrupt. That is what I want to express. Option 2, for example,

[Qemu-devel] [PATCH 0/10] rework on hot unplug

2012-08-24 Thread Liu Ping Fan
This patchset takes the mmio-dispatch out of big lock's protection into consideration. In that scene, the finalize of parent can not mean the end of children immediately. Also, this patchset elimate one major obstale to change the 3rd param of memory_region_init_io from void* to Object * refer

[Qemu-devel] [PATCH 01/10] qom: add, remove of link property need to ref, unref its target

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Currently, link property's target is only managed by object_set_link_property(). This will raise such issue that when the property is finalized, its target has no opportunity to release. Fix this issue by introduce object_finalize_link_property() In

[Qemu-devel] [PATCH 02/10] qdev: change iterator callback seq

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Some func should be called after iteration over object's children, for example, func will put ref of object. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/qdev.c | 30 ++ hw/qdev.h |4 ++-- 2 files

[Qemu-devel] [PATCH 04/10] qdev: introduce new interface to remove composite sub-tree

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com When a bridge device removed, all the children bebind it should be removed. Using qdev_delete_subtree(dev) to emulate this event. And it is achieved by iterated laughed by qdev_walk_children() Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 05/10] qdev: finalize of qbus, qdev will not the right place to free children

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com When breaking big lock, the child object can be hold by mmio-dispatch, and it is not right to free them when their parent gone. We will isolate and release the children by qdev_delete_subtree(), and let each object manage its own life cycle.

[Qemu-devel] [PATCH 09/10] mon: release dev's ref hold by qdev_get_peripheral

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com When add it at qdev_device_add(), so need to release it at qmp_device_del(). Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/qdev-monitor.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Peter Maydell
On 24 August 2012 10:47, Brad Smith b...@comstyle.com wrote: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware

[Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com We are not long to force to delete the obj at that place, just let its refcnt handle this issue. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/acpi_piix4.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 10:55:10AM +0100, Peter Maydell wrote: On 24 August 2012 10:47, Brad Smith b...@comstyle.com wrote: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as

[Qemu-devel] [PATCH 06/10] qom: expose object_property_del_child

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com qmp and qdev need it. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- include/qemu/object.h |3 +++ qom/object.c |2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/qemu/object.h

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-08-24 Thread Aurelien Jarno
On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote: On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno aurel...@aurel32.net wrote: The lan9118 emulation tries to compute the multicast index by calling directly the crc32() function from zlib, but fails to get the correct result.

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-08-24 Thread Erik Rull
On August 9, 2012 at 10:59 AM Gerd Hoffmann kra...@redhat.com wrote: Hi Gerd, sorry for the delays, I tested the latest pulled patch queue and it's now fine on my Intel board, too. The dongle gets detected again without assertions. Thanks for your work. Still remaining are the

Re: [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 9:33 AM, Rongqing Li rongqing...@windriver.com wrote: On 2012年08月24日 16:20, Paolo Bonzini wrote: A link-down NIC should always return 1 from can_receive (and will drop the packet). Is that the real bug here? A link-down NIC always return 0 from can_receive. Yes,

Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 11:08 AM, Aurelien Jarno aurel...@aurel32.net wrote: On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote: On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno aurel...@aurel32.net wrote: The lan9118 emulation tries to compute the multicast index by calling

[Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Scene: obja lies in objA, when objA's ref-0, it will be freed, but at that time obja can still be in use. The real example is: typedef struct PCIIDEState { PCIDevice dev; IDEBus bus[2]; -- create in place . } When without big lock

Re: [Qemu-devel] [PATCH 07/10] unplug: using new intf qdev_delete_subtree in acpi_piix_eject_slot

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:49, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com We are not long to force to delete the obj at that place, just let its refcnt handle this issue. This seems wrong. If anything, unplug requests should propagate down the tree and the top device

[Qemu-devel] [PATCH 08/10] qdev: rename qdev_unplug to qdev_unplug_req

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Unplug divides into two steps: request and complete The name req show more clearly about its meaning and as to the complete, it is qdev_delete_subtree() Also adding ret to indicate the request can be eject or not Signed-off-by: Liu Ping Fan

[Qemu-devel] [PATCH 03/10] qom: export object_property_is_child, object_property_is_link

2012-08-24 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com qdev will use them to judge how to remove the bus and device's reference. So export them in object.h Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- include/qemu/object.h |3 +++ qom/object.c |4 ++-- 2 files changed, 5

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-24 Thread Julien Grall
On 08/23/2012 08:52 PM, Ian Campbell wrote: On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: On 08/23/2012 02:27 PM, Ian Campbell wrote: @@ -103,6 +103,9 @@ static ssize_t rdexact(xc_interface *xch, struct restore_ctx *ctx, #else #define RDEXACT read_exact

Re: [Qemu-devel] [Qemu-trivial] [PATCH] ui: Fix spelling in comment (ressource - resource)

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 17, 2012 at 03:20:00PM +0200, Stefan Weil wrote: The function is called interface_release_resource. Signed-off-by: Stefan Weil s...@weilnetz.de --- ui/spice-display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 09:17:51AM +0200, Markus Armbruster wrote: Stefan Weil s...@weilnetz.de writes: Am 17.08.2012 17:02, schrieb Luiz Capitulino: On Fri, 17 Aug 2012 16:41:34 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 01/17] hvm: Modify interface to support multiple ioreq server

2012-08-24 Thread Julien Grall
On 08/23/2012 02:26 PM, Keir Fraser wrote: On 23/08/2012 14:18, Ian Campbellian.campb...@citrix.com wrote: diff --git a/xen/include/public/hvm/ioreq.h b/xen/include/public/hvm/ioreq.h index 4022a1d..87aacd3 100644 --- a/xen/include/public/hvm/ioreq.h +++ b/xen/include/public/hvm/ioreq.h

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 11/17] xc: modify save/restore to support multiple device models

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 11:27 +0100, Julien Grall wrote: On 08/23/2012 08:52 PM, Ian Campbell wrote: On Thu, 2012-08-23 at 20:13 +0100, Julien Grall wrote: On 08/23/2012 02:27 PM, Ian Campbell wrote: @@ -103,6 +103,9 @@ static ssize_t rdexact(xc_interface *xch, struct

[Qemu-devel] [PATCH] megasas: Add 'hba_serial' property

2012-08-24 Thread Hannes Reinecke
Add a 'hba_serial' property to the megasas driver. Originally it would be using a pointer value which would break migration. Reported-by: Stefan Weil s...@weilnetz.de Signed-off-by: Hannes Reinecke h...@suse.de Cc: Paolo Bonzini pbonz...@redhat.com --- hw/megasas.c |9 +++-- 1 files

Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler warning caused by illegal type cast

2012-08-24 Thread Hannes Reinecke
On 08/24/2012 10:16 AM, Paolo Bonzini wrote: Il 24/08/2012 10:31, Hannes Reinecke ha scritto: Type casts from pointer to integer values must use uintptr_t instead of unsigned long. Otherwise the compiler complains on hosts with sizeof(pointer) != sizeof(long). The patch also replace magic

Re: [Qemu-devel] What's the proper type of guest pde address, target_ulong or target_phys_addr_t?

2012-08-24 Thread Wei-Ren Chen
In principle, yes, but you need to check the code carefully to make sure your type change doesn't change any of the results. (Or if it does, you then need to confirm against the specs that this was a bug that is being fixed, not a new one being introduced). The thing you have to remember is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: This allows using qemu_irq in the target specific cpu.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-common.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) I'm not sure if there's a reason why qemu_irq

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Remove #if 0'd cpu_get_real_ticks() definition

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 02:03:36PM +0100, Peter Maydell wrote: Remove the cpu_get_real_ticks() definition from linux-user/main.c. This has been disabled via #if 0 and unused since commit 1dce7c3c22 in 2006; the definitions we actually use are in qemu-timer.h. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Peter Maydell
On 24 August 2012 11:54, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: This allows using qemu_irq in the target specific cpu.h. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-common.h |3 ++- 1 files changed, 2

Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:23:49PM +0200, Jan Kiszka wrote: On 2012-08-22 12:19, BALATON Zoltan wrote: On Wed, 22 Aug 2012, Jan Kiszka wrote: This is a rather big patch. I strongly suspect you can break it up into smaller pieces that address separate aspects one-by-one. Also, it is

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Fix copypaste typos in documentation comments

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:18:38PM +0200, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan bala...@eik.bme.hu --- memory.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) v2: indented memory_region_init_ram_ptr Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:19:42PM +0200, BALATON Zoltan wrote: Division with round up is the correct way to compute this even if the only case where division with round down gives incorrect result is probably 15 bpp. This case was explicitely patched up in one of these functions but was

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: On 2012-08-22 18:29, Stefan Weil wrote: Am 22.08.2012 17:32, schrieb Jan Kiszka: On 2012-08-22 17:19, BALATON Zoltan wrote: Division with round up is the correct way to compute this even if the only case where division with round

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Jan Kiszka
On 2012-08-24 13:20, Stefan Hajnoczi wrote: On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: On 2012-08-22 18:29, Stefan Weil wrote: Am 22.08.2012 17:32, schrieb Jan Kiszka: On 2012-08-22 17:19, BALATON Zoltan wrote: Division with round up is the correct way to compute this even if

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread Stefan Hajnoczi
On Thu, Aug 23, 2012 at 02:08:36AM +0200, BALATON Zoltan wrote: Division with round up is the correct way to compute this even if the only case where division with round down gives incorrect result is probably 15 bpp. This case was explicitely patched up in one of these functions but was

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.2] qemu-ga: Fix null pointer passed to unlink in failure branch

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 07:03:03AM +0200, Stefan Weil wrote: Clang reports this warning: Null pointer passed as an argument to a 'nonnull' parameter Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-ga.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Nice, this looks

[Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Jan Kiszka
This variable is no longer bound to irqchip, and the IOCTL sets the IRQ level, does not directly inject it. No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kvm-all.c

Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases

2012-08-24 Thread Peter Maydell
On 23 August 2012 01:08, BALATON Zoltan bala...@eik.bme.hu wrote: Division with round up is the correct way to compute this even if the only case where division with round down gives incorrect result is probably 15 bpp. This case was explicitely patched up in one of these functions but was

Re: [Qemu-devel] [PATCH] megasas: Add 'hba_serial' property

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 12:36, Hannes Reinecke ha scritto: Add a 'hba_serial' property to the megasas driver. Originally it would be using a pointer value which would break migration. Reported-by: Stefan Weil s...@weilnetz.de Signed-off-by: Hannes Reinecke h...@suse.de Cc: Paolo Bonzini

Re: [Qemu-devel] [PATCH uq/master] kvm: Rename irqchip_inject_ioctl to irq_set_ioctl

2012-08-24 Thread Peter Maydell
On 24 August 2012 12:34, Jan Kiszka jan.kis...@siemens.com wrote: This variable is no longer bound to irqchip, and the IOCTL sets the IRQ level, does not directly inject it. No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Reviewed-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] console: Correct computation of bytes per pixel from bits per pixel

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 12:21 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-08-24 13:20, Stefan Hajnoczi wrote: On Wed, Aug 22, 2012 at 06:44:08PM +0200, Jan Kiszka wrote: On 2012-08-22 18:29, Stefan Weil wrote: Am 22.08.2012 17:32, schrieb Jan Kiszka: On 2012-08-22 17:19, BALATON

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:55, Peter Maydell ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 August 2012 11:54, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: This allows using qemu_irq in the target specific cpu.h. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 01:56:31PM +0200, Paolo Bonzini wrote: Il 24/08/2012 11:55, Peter Maydell ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: On 2012-08-24 05:58, malc wrote: On Thu, 23 Aug 2012, Matthew Ogilvie wrote: After applying this version 2 of this patch series, I can successfully run Micoport UNIX System V/386, v 2.1 (ca 1987) under qemu. (although not if I try to enable KVM)

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 14:00, Brad Smith ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Jan Kiszka
On 2012-08-24 14:02, malc wrote: On Fri, 24 Aug 2012, Jan Kiszka wrote: On 2012-08-24 05:58, malc wrote: On Thu, 23 Aug 2012, Matthew Ogilvie wrote: After applying this version 2 of this patch series, I can successfully run Micoport UNIX System V/386, v 2.1 (ca 1987) under qemu.

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 02:02:57PM +0200, Paolo Bonzini wrote: Il 24/08/2012 14:00, Brad Smith ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: On 2012-08-24 14:02, malc wrote: On Fri, 24 Aug 2012, Jan Kiszka wrote: On 2012-08-24 05:58, malc wrote: On Thu, 23 Aug 2012, Matthew Ogilvie wrote: After applying this version 2 of this patch series, I can successfully run Micoport UNIX

Re: [Qemu-devel] [PATCH 1/2] Usb: create the receive queue for the virtual USB NIC

2012-08-24 Thread Stefan Hajnoczi
On Fri, Aug 24, 2012 at 8:56 AM, rongqing...@windriver.com wrote: From: Roy.Li rongqing...@windriver.com The virtual USB NIC originally used a fixed buffer to receive packets which only store 1 packet at a time, which is easy to overrun with packets if the guest does not consume it quickly,

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Julien Grall
On 08/23/2012 02:30 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: This patch modifies libxl interface for qemu disaggregation. I'd rather see the interfaces changes in the same patch as the implementation of the new interfaces. For the moment,

Re: [Qemu-devel] [QEMU][RFC V2 06/10] xen-pci: register PCI device in Xen and handle IOREQ_TYPE_PCI_CONFIG

2012-08-24 Thread Julien Grall
On 08/23/2012 03:41 PM, Stefano Stabellini wrote: On Wed, 22 Aug 2012, Julien Grall wrote: With QEMU disaggregation QEMU needs to specify which PCI device it's able to handle. It will use the device place in the topology (domain, bus, device, function). When Xen will trap an access for the

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Ian Campbell
On Fri, 2012-08-24 at 13:56 +0100, Julien Grall wrote: On 08/23/2012 02:30 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:31 +0100, Julien Grall wrote: This patch modifies libxl interface for qemu disaggregation. I'd rather see the interfaces changes in the same patch as the

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 14/17] xl-parsing: Parse new device_models option

2012-08-24 Thread Julien Grall
On 08/23/2012 02:35 PM, Ian Campbell wrote: On Wed, 2012-08-22 at 13:32 +0100, Julien Grall wrote: Add new option device_models. The user can specify the capability of the QEMU (ui, vifs, ...). This option only works with QEMU upstream (qemu-xen). For instance: device_models= [

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH V2 12/17] xl: Add interface to handle qemu disaggregation

2012-08-24 Thread Julien Grall
On 08/24/2012 02:03 PM, Ian Campbell wrote: @@ -246,6 +246,20 @@ libxl_domain_sched_params = Struct(domain_sched_params,[ (extratime,integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT'}), ]) +libxl_dm_cap = Enumeration(dm_cap, [ +(1, UI), # Emulate all UI

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 09:19, Peter Maydell ha scritto: Err, does this comply with the -rcX process? Patch 6 alone has been on the list for less than a day. Only now I was able to comment on it, and I would prefer to not have it merged that easily. Adding a new command line option certainly looks

[Qemu-devel] [PATCH 0/3] net: fix hub control flow (again)

2012-08-24 Thread Stefan Hajnoczi
Two networking issues have been observed: 1. When the USB network interface and dump net client are on the same VLAN, the USB network interface drops packets. This was assumed to be because the dump net client can receive packets all the time, whereas the USB network interface has a

[Qemu-devel] [PATCH 1/3] net: clean up usbnet_receive()

2012-08-24 Thread Stefan Hajnoczi
The USB network interface has two code paths depending on whether or not RNDIS mode is enabled. Refactor usbnet_receive() so that there is a common path throughout the function instead of duplicating everything across if (is_rndis(s)) ... else ... code paths. Clean up coding style and 80

Re: [Qemu-devel] [PATCH V5 3/8] hw/cirrus_vga.c: replace register_ioport*

2012-08-24 Thread Jan Kiszka
On 2012-08-22 14:27, Julien Grall wrote: This patch replaces all register_ioport* with portio_*. It permits to use the new Memory stuff like listener. Signed-off-by: Julien Grall julien.gr...@citrix.com --- hw/cirrus_vga.c | 42 -- 1 files

  1   2   >