Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Paolo Bonzini
Il 12/09/2012 01:50, Michael S. Tsirkin ha scritto: +static void lsilogic_abort_command(LsilogicCmd *cmd) +{ +if (cmd-req) { +scsi_req_cancel(cmd-req); +cmd-req = NULL; +} +} This only needs to be cmd-req = NULL. +if (cmd) { +

Re: [Qemu-devel] [PATCH] configure: usbredir fixes

2012-09-12 Thread Gerd Hoffmann
On 09/11/12 20:57, Aurelien Jarno wrote: usbredir is only used by system emulation, so add the libraries to libs_softmmu instead of LIBS. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH 0/2] ehci: Misc fixes

2012-09-12 Thread Gerd Hoffmann
Hi, http://cgit.freedesktop.org/~jwrdegoede/qemu/log/?h=usb-for-gerd Except for the ehci: Don't process too much frames in 1 timer tick patch as you've already added v2 of that :) If you want I can re-spin and send them as patches to the list. Phew, usb backlog is merged. Can you

Re: [Qemu-devel] [PATCH] virtio spec amendment for virtio-ccw

2012-09-12 Thread Rusty Russell
Heinz Graalfs graa...@linux.vnet.ibm.com writes: Rusty, here is Conny's virtio spec amendment. Cornelia Huck (1): virtio-ccw: Add secondary indicators. Technically, you should have signed this off too. But applied anyway, Rusty.

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Gerhard Wiesinger
On 11.09.2012 19:00, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from VirtualBox Open Source Edition. Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works. Tested with Fedora 16, 17. CentoOS 6. Windows

Re: [Qemu-devel] [PATCH V12 5/6] add-cow file format

2012-09-12 Thread Dong Xu Wang
On Tue, Sep 11, 2012 at 5:40 PM, Kevin Wolf kw...@redhat.com wrote: Am 10.08.2012 17:39, schrieb Dong Xu Wang: add-cow file format core code. It use block-cache.c as cache code. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block/Makefile.objs |1 + block/add-cow.c |

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-09-12 Thread Avi Kivity
On 09/12/2012 08:57 AM, Michael Tokarev wrote: This unbreaks isapc for TCG, and keep it working for KVM once it starts supporting read-only memslots. Can you clarify please, -- referring to the above? :) kvm only works due to a bug. Once the kvm bug is fixed, isapc will break, unless the

Re: [Qemu-devel] [PATCH V12 5/6] add-cow file format

2012-09-12 Thread Kevin Wolf
Am 12.09.2012 09:28, schrieb Dong Xu Wang: +static bool is_allocated(BlockDriverState *bs, int64_t sector_num) +{ +BDRVAddCowState *s = bs-opaque; +BlockCache *c = s-bitmap_cache; +int64_t cluster_num = sector_num / SECTORS_PER_CLUSTER; +uint8_t *table = NULL; +

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Avi Kivity
On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or goes away unhandled. So the only

Re: [Qemu-devel] [PATCH V2 1/6] libqblock API design

2012-09-12 Thread Kevin Wolf
Am 11.09.2012 22:28, schrieb Blue Swirl: On Mon, Sep 10, 2012 at 8:26 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch contains the major APIs in the library. Important APIs: 1 QBroker. These structure was used to retrieve errors, every thread must create one first, later

Re: [Qemu-devel] [PATCH] isapc: Shadow ISA BIOS by default

2012-09-12 Thread Jan Kiszka
[forgot to CC stable: this one apparently qualifies for older QEMU releases as well but would require some adaptions for 1.1] On 2012-09-11 17:53, Jan Kiszka wrote: Our one and only BIOS depends on a writable shadowed BIOS in the ISA range. As we have no interface to control the write

[Qemu-devel] qemu-nbd very slow, patch available

2012-09-12 Thread Tristan Wibberley
Hello qemu devs, A couple of years ago Stephane Chazelas (https://launchpad.net/~stephane-chazelas) reported a performance issue with qemu-nbd due to the lack of an option to switch on writeback caching (ie a mode like any typical program that just modifies files of data where resilience is not

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Jan Kiszka
On 2012-09-12 10:01, Avi Kivity wrote: On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Avi Kivity
On 09/12/2012 11:48 AM, Jan Kiszka wrote: On 2012-09-12 10:01, Avi Kivity wrote: On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Jan Kiszka
On 2012-09-12 10:51, Avi Kivity wrote: On 09/12/2012 11:48 AM, Jan Kiszka wrote: On 2012-09-12 10:01, Avi Kivity wrote: On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and

Re: [Qemu-devel] [PATCH 1/2] KVM: fix i8259 interrupt high to low transition logic

2012-09-12 Thread Avi Kivity
On 09/12/2012 11:57 AM, Jan Kiszka wrote: On 2012-09-12 10:51, Avi Kivity wrote: On 09/12/2012 11:48 AM, Jan Kiszka wrote: On 2012-09-12 10:01, Avi Kivity wrote: On 09/10/2012 04:29 AM, Matthew Ogilvie wrote: Intel's definition of edge triggered means: asserted with a low-to-high transition

[Qemu-devel] [PATCH v5] configure: properly check if -lrt and -lm is needed

2012-09-12 Thread Natanael Copa
Fixes build against uClibc. uClibc provides 2 versions of clock_gettime(), one with realtime support and one without (this is so you can avoid linking in -lrt unless actually needed). This means that the clock_gettime() don't need -lrt. We still need it for timer_create() so we check for this

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-12 Thread Bharata B Rao
On Fri, Sep 07, 2012 at 11:57:58AM +0200, Kevin Wolf wrote: Am 07.09.2012 11:36, schrieb Paolo Bonzini: Hmm, why don't we do the exact same thing as libvirt (http://libvirt.org/remote.html): ipv4 - gluster+tcp://1.2.3.4:0/testvol/dir/a.img ipv6 -

Re: [Qemu-devel] [PATCH V2 1/6] libqblock API design

2012-09-12 Thread Wenchao Xia
于 2012-9-12 16:19, Kevin Wolf 写道: Am 11.09.2012 22:28, schrieb Blue Swirl: On Mon, Sep 10, 2012 at 8:26 AM, Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: This patch contains the major APIs in the library. Important APIs: 1 QBroker. These structure was used to retrieve errors, every

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-12 Thread Paolo Bonzini
Il 12/09/2012 11:22, Bharata B Rao ha scritto: FYI, bdrv_find_protocol() fails for protocols like this. It detects the protocol as gluster+tcp and compares it with drv-protocol_name (which is only gluster). I guess I will have to fix bdrv_find_protocol() to handle the '+' within protocol

Re: [Qemu-devel] qemu-nbd very slow, patch available

2012-09-12 Thread Paolo Bonzini
Il 12/09/2012 10:25, Tristan Wibberley ha scritto: The attached diff adds a commandline option --cache= with four modes and makes no change to the default behaviour of qemu-nbd: --cache=writethrough [default, O_DSYNC, very slow, very resilient] --cache=off [same as --nocache, O_DIRECT,

Re: [Qemu-devel] Windows VM slow boot

2012-09-12 Thread Richard Davies
[ adding linux-mm - previously at http://marc.info/?t=13451150943 ] Hi Rik, Since qemu-kvm 1.2.0 and Linux 3.6.0-rc5 came out, I thought that I would retest with these. The typical symptom now appears to be that the Windows VMs boot reasonably fast, but then there is high CPU use and load

[Qemu-devel] [PATCH v2 1/3] Refactor inet_connect_opts function

2012-09-12 Thread Orit Wasserman
From: Michael S. Tsirkin m...@redhat.com refactor address resolution code to fix nonblocking connect Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com --- qemu-sockets.c | 139

[Qemu-devel] [PATCH v2 3/3] Fix address handling in inet_nonblocking_connect

2012-09-12 Thread Orit Wasserman
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_connect_nonblocking retry connection with a

[Qemu-devel] [PATCH v2 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-12 Thread Orit Wasserman
No need to add non blocking parameters to the blocking inet_connect Signed-off-by: Orit Wasserman owass...@redhat.com --- migration-tcp.c |2 +- nbd.c |2 +- qemu-sockets.c | 24 qemu_socket.h |4 +++- ui/vnc.c|2 +- 5 files

[Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup

2012-09-12 Thread Orit Wasserman
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. A simple way to reproduce the problem is migration: for the

Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets

2012-09-12 Thread Laurent Desnogues
On Tue, Sep 11, 2012 at 8:56 PM, Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Sep 10, 2012 at 06:00:54PM -0500, Anthony Liguori wrote: Daniel P. Berrange berra...@redhat.com writes: From: Daniel P. Berrange berra...@redhat.com Allow passing of '--target-list=' to configure to

[Qemu-devel] [PATCH 1/5] qemu-char: Add new char device CirMemCharDriver

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c | 84 +++ 1 files changed, 84 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 767da93..0470085 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2591,6

[Qemu-devel] [RFC v3 ATCH 0/5] char: expose CirMemCharDriver and provide QMP interface

2012-09-12 Thread Lei Li
This RFC series attempts to convert the MemCharDriver to use a circular buffer for input and output, expose it to users by introducing QMP commands memchar_write and memchar_read and via the command line like the other CharDriverStates. Serial ports in qemu always use CharDriverStates as there

[Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read QMP command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 25 + hmp.c| 18 ++ hmp.h|1 + qapi-schema.json | 27 +++ qemu-char.c | 48

[Qemu-devel] [PATCH 2/5] Expose CirMemCharDriver via command line

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c | 31 +++ qemu-config.c |3 +++ qemu-options.hx | 10 ++ 3 files changed, 44 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 0470085..6e84acc 100644 ---

[Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp.c | 42 ++ monitor.c | 18 ++ monitor.h |2 ++ 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/hmp.c b/hmp.c index 4397981..a016a5c 100644 --- a/hmp.c +++

[Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-09-12 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 23 ++ hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69 ++ qemu-char.c | 48

[Qemu-devel] [PATCH] Basic support for ARM A15 architectured (cp15) timers

2012-09-12 Thread Daniel Forsgren
This patch adds basic support for the architected timers (i.e. cp15) found in A15. It's enough to allow Linux to boot, using arch_timer for the tick. However - it is not a complete model of the timer block at large, it is not that well structured, and it is currently tested with

[Qemu-devel] [PATCH 2/9] ehci: Walk async schedule before and after migration

2012-09-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 28 1 file changed, 28 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index c5f2635..e67cbc7 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -34,6 +34,7 @@ #include

[Qemu-devel] [PATCH 1/9] ehci: Don't set seen to 0 when removing unseen queue-heads

2012-09-12 Thread Hans de Goede
When removing unseen queue-heads from the async queue list, we should not set the seen flag to 0, as this may cause them to be removed by ehci_queues_rip_unused() during the next call to ehci_advance_async_state() if the timer is late or running at a low frequency. Note: 1) This *may* have caused

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Kevin Wolf
Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from VirtualBox Open Source Edition. Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. I think you mean

Re: [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines

2012-09-12 Thread Eric Blake
On 09/11/2012 09:05 PM, Wenchao Xia wrote: Seriously? We require a C99-compliant compiler, which is required to treat the more compact version identically (all undefined names evaluate to 0 in the preprocessor), and HACKING doesn't mandate that we spell out a defined-ness check first. Okay,

[Qemu-devel] [PATCH 1/9] ehci: Don't set seen to 0 when removing unseen queue-heads

2012-09-12 Thread Hans de Goede
When removing unseen queue-heads from the async queue list, we should not set the seen flag to 0, as this may cause them to be removed by ehci_queues_rip_unused() during the next call to ehci_advance_async_state() if the timer is late or running at a low frequency. Note: 1) This *may* have caused

[Qemu-devel] [PATCH 7/9] usb-redir: Add chardev open / close debug logging

2012-09-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 8d3cf3b..e438fd1 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -854,6 +854,7 @@ static void

[Qemu-devel] [PATCH 9/9] uhci: Don't queue up packets after one with the SPD flag set

2012-09-12 Thread Hans de Goede
Don't queue up packets after a packet with the SPD (short packet detect) flag set. Since we won't know if the packet will actually be short until it has completed, and if it is short we should stop the queue. This fixes a miniature photoframe emulating a USB cdrom with the windows software for it

[Qemu-devel] [PATCH 0/3] client monitors config support

2012-09-12 Thread Alon Levy
v3: - no addition of guest capabilities, use interrupt mask instead, ignore 0 or ~0 that are set by current windows driver. - use crc to solve possible write while read. - limit heads to 64, statically allocated on rom by host. - some misc trace fixes. QEMU: Alon Levy (3): hw/qxl:

[Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device

2012-09-12 Thread Alon Levy
Until now we used only the agent to change the monitor count and each monitor resolution. This patch introduces the qemu part of using the device as the mediator instead of the agent via virtio-serial. Spice (=0.11.5) calls the new QXLInterface::client_monitors_config, which returns wether the

[Qemu-devel] [PATCH 2/3] qxl: add trace-event for QXL_IO_LOG

2012-09-12 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 1 + trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 94eb3c8..12dfc79 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1503,6 +1503,7 @@ async_common: qxl_set_mode(d, val, 0);

[Qemu-devel] [PATCH 1/3] hw/qxl: tracing fixes

2012-09-12 Thread Alon Levy
Add two new trace events: qxl_send_events(int qid, uint32_t events) %d %d qxl_set_guest_bug(int qid) %d Change qxl_io_unexpected_vga_mode parameters to be equivalent to those of qxl_io_write for easier grouping under a single systemtap probe. Change d to qxl in one place. Signed-off-by: Alon

Re: [Qemu-devel] TCG questions

2012-09-12 Thread Lluís Vilanova
Xin Tong writes: i do not know. could be similar. I am doing architecture research. i need traces of memory access for programming running under a full system environment, so i wrote this. i do nto seem to be able to access the linked provided from the link you give me though.

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-12 Thread Laurent Desnogues
Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for comma-separated target lists on the --target-list option. e.g.: $ ./configure

Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub

2012-09-12 Thread Alexander Graf
On 09/09/2012 11:04 PM, Richard Henderson wrote: The real gdb protocol doesn't split out pc or cc as real registers. Those are pseudos that are extracted as needed from the PSW. Don't modify env-cc_op during read -- that way lies heisenbugs. Fill in the XXX for the fp registers. Remove

[Qemu-devel] [PATCH 2/9] ehci: Walk async schedule before and after migration

2012-09-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 28 1 file changed, 28 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index c5f2635..e67cbc7 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -34,6 +34,7 @@ #include

[Qemu-devel] [PATCH 3/9] usb-redir: Change cancelled packet code into a generic packet-id queue

2012-09-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 102 +- 1 file changed, 71 insertions(+), 31 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 5301a69..603262a 100644 --- a/hw/usb/redirect.c +++

[Qemu-devel] [PATCH 4/9] usb-redir: Add an already_in_flight packet-id queue

2012-09-12 Thread Hans de Goede
After a live migration, the usb-hcd will re-queue all packets by walking over the schedule in the guest memory again, but requests which were encountered on the migration source before will already be in flight, so these should *not* be re-send to the usbredir-host. This patch adds an already in

[Qemu-devel] [PATCH 5/9] usb-redir: Store max_packet_size in endp_data

2012-09-12 Thread Hans de Goede
So that we've a place to migrate it to / from to allow restoring it after migration. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index f474da8..3196665 100644

[Qemu-devel] [PATCH 6/9] usb-redir: Add support for migration

2012-09-12 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 349 +- 1 file changed, 346 insertions(+), 3 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 3196665..8d3cf3b 100644 --- a/hw/usb/redirect.c +++

[Qemu-devel] [PATCH 8/9] usb-redir: Revert usb-redir part of commit 93bfef4c

2012-09-12 Thread Hans de Goede
Commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4 makes qemu-devices which report the qemu version string to the guest in some way use a qemu_get_version function which reports a machine-specific version string. However usb-redir does not expose the qemu version to the guest, only to the

[Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Anthony Liguori
Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a while talking about it yesterday and I wanted to take the discussion to the list to get

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Anthony Liguori
Kevin Wolf kw...@redhat.com writes: Am 12.09.2012 01:50, schrieb Michael S. Tsirkin: On Tue, Sep 11, 2012 at 01:00:13PM -0400, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from VirtualBox Open Source Edition. Based on QEMU MegaRAID SAS 8708EM2. This is a common

Re: [Qemu-devel] [PATCH v2 0/3] nonblocking connect address handling cleanup

2012-09-12 Thread Amos Kong
On 12/09/12 19:12, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. A simple way to reproduce

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a while talking about it yesterday and I

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Anthony Liguori
Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 16:44, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick

[Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-09-12 Thread Erlon Cruz
Hi all, We are planning to implement DLPAR capacity on QEMU pSeries. As we lack of experience in the internals of the arch we would like you guys to give us some design directions and confirm if we going in the right direction. Our first idea is: 1 - to patch 'spapr.c' so it can dynamically

Re: [Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read QMP command

2012-09-12 Thread Eric Blake
On 09/12/2012 05:57 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 25 + hmp.c| 18 ++ hmp.h|1 + qapi-schema.json | 27 +++ qemu-char.c | 48

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 09:44:10AM -0500, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by

Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub

2012-09-12 Thread Richard Henderson
On 09/12/2012 06:25 AM, Alexander Graf wrote: +case S390_PSWM_REGNUM: +env-psw.mask = tmpl; +env-cc_op = (tmpl 13) 3; Are you sure this is correct? I thought gdbstub would just ignore the cc bits. Well... no it won't ignore the cc bits. But it would appear that I've

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 08:54:26AM -0500, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a while talking

Re: [Qemu-devel] [PATCH] hw: Add support for new LSI Logic devices.

2012-09-12 Thread Avi Kivity
On 09/11/2012 08:00 PM, Don Slutz wrote: Add LSI53C1030, SAS1068, SAS1068e. Based on code from VirtualBox Open Source Edition. Based on QEMU MegaRAID SAS 8708EM2. This is a common VMware disk controller. SEABIOS change for booting is in the works. Tested with Fedora 16, 17. CentoOS

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Jan Kiszka
On 2012-09-12 17:06, Gleb Natapov wrote: Are there other issues with reinjection that people are aware of? Does anything seem obviously wrong with the above? We should take the chance and design everything in a way that the HPET can finally be (left) enabled. I thought the issue with the

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 05:42:58PM +0200, Jan Kiszka wrote: On 2012-09-12 17:06, Gleb Natapov wrote: Are there other issues with reinjection that people are aware of? Does anything seem obviously wrong with the above? We should take the chance and design everything in a way that the HPET

Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-09-12 Thread Alexander Graf
On 09/12/2012 04:54 PM, Erlon Cruz wrote: Hi all, We are planning to implement DLPAR capacity on QEMU pSeries. As we What is DLPAR? Hotplug support? lack of experience in the internals of the arch we would like you guys to give us some design directions and confirm if we going in the right

Re: [Qemu-devel] [RFC v3 ATCH 0/5] char: expose CirMemCharDriver and provide QMP interface

2012-09-12 Thread Avi Kivity
On 09/12/2012 02:57 PM, Lei Li wrote: This RFC series attempts to convert the MemCharDriver to use a circular buffer for input and output, expose it to users by introducing QMP commands memchar_write and memchar_read and via the command line like the other CharDriverStates. Serial ports in

Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub

2012-09-12 Thread Alexander Graf
On 09/12/2012 05:11 PM, Richard Henderson wrote: On 09/12/2012 06:25 AM, Alexander Graf wrote: +case S390_PSWM_REGNUM: +env-psw.mask = tmpl; +env-cc_op = (tmpl 13) 3; Are you sure this is correct? I thought gdbstub would just ignore the cc bits. Well... no it won't

[Qemu-devel] Does TCG IR use static single assignment (SSA) form?

2012-09-12 Thread Yichen Yang
Dear all, Excuse me for asking, does TCG-IR use static single assignment (SSA) form? I just wanna know how to translate a register-based bytecode to TCG-IR. thanks :) Yichen

Re: [Qemu-devel] Windows VM slow boot

2012-09-12 Thread Mel Gorman
On Wed, Sep 12, 2012 at 11:56:59AM +0100, Richard Davies wrote: [ adding linux-mm - previously at http://marc.info/?t=13451150943 ] Hi Rik, I'm not Rik but hi anyway. Since qemu-kvm 1.2.0 and Linux 3.6.0-rc5 came out, I thought that I would retest with these. Ok. 3.6.0-rc5

Re: [Qemu-devel] [RFC v3 ATCH 0/5] char: expose CirMemCharDriver and provide QMP interface

2012-09-12 Thread Daniel P. Berrange
On Wed, Sep 12, 2012 at 07:57:21PM +0800, Lei Li wrote: This RFC series attempts to convert the MemCharDriver to use a circular buffer for input and output, expose it to users by introducing QMP commands memchar_write and memchar_read and via the command line like the other CharDriverStates.

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 06:06:47PM +0300, Gleb Natapov wrote: On Wed, Sep 12, 2012 at 09:44:10AM -0500, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with

Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub

2012-09-12 Thread Richard Henderson
On 09/12/2012 08:54 AM, Alexander Graf wrote: So the CC pseudo-register is never written to? They do handle a write to cc_regnum in s390_pseudo_register_write. They modify psw.mask as one would expect. r~

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Stefan Weil
Am 12.09.2012 15:54, schrieb Anthony Liguori: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a while talking about it yesterday and I

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 06:27:14PM +0200, Stefan Weil wrote: Am 12.09.2012 15:54, schrieb Anthony Liguori: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we

Re: [Qemu-devel] Windows VM slow boot

2012-09-12 Thread Richard Davies
Hi Mel - thanks for replying to my underhand bcc! Mel Gorman wrote: I see that this is an old-ish bug but I did not read the full history. Is it now booting faster than 3.5.0 was? I'm asking because I'm interested to see if commit c67fe375 helped your particular case. Yes, I think 3.6.0-rc5

Re: [Qemu-devel] [PATCH v3 01/17] vga: rename pci_vga_init() into pci_std_vga_init()

2012-09-12 Thread Richard Henderson
On 09/11/2012 12:10 PM, Aurelien Jarno wrote: This better explains what is this function about. Adjust all callers. Cc: Richard Henderson r...@twiddle.net Cc: Alexander Graf ag...@suse.de Cc: Andreas Färber andreas.faer...@web.de Cc: David Gibson da...@gibson.dropbear.id.au Cc: Anthony

Re: [Qemu-devel] Does TCG IR use static single assignment (SSA) form?

2012-09-12 Thread Peter Maydell
On 12 September 2012 10:45, (Yichen Yang)楊逸臣 coldl...@sslab.cs.nthu.edu.tw wrote: Excuse me for asking, does TCG-IR use static single assignment (SSA) form? No. The TCG IR is documented in tcg/README -- this should be enough to be able to translate something else into it. -- PMM

Re: [Qemu-devel] Does TCG IR use static single assignment (SSA) form?

2012-09-12 Thread Richard Henderson
On 09/12/2012 02:45 AM, (Yichen Yang)楊逸臣 wrote: Excuse me for asking, does TCG-IR use static single assignment (SSA) form? No. r~

Re: [Qemu-devel] TCG questions

2012-09-12 Thread Xin Tong
On Wed, Sep 12, 2012 at 6:14 AM, Lluís Vilanova vilan...@ac.upc.edu wrote: Xin Tong writes: i do not know. could be similar. I am doing architecture research. i need traces of memory access for programming running under a full system environment, so i wrote this. i do nto seem to be able to

Re: [Qemu-devel] TCG questions

2012-09-12 Thread Xin Tong
I have the code on http://code.google.com/p/qemu-trace/. I currently have memory trace, branch trace and some special instructions traces ready ( unverified though). we should discuss about what is the best way to do this btw. Xin On Wed, Sep 12, 2012 at 10:09 AM, Xin Tong

[Qemu-devel] [PATCH] tcg: Fix MAX_OPC_PARAM_IARGS

2012-09-12 Thread Stefan Weil
DEF_HELPER_FLAGS_5 was added some time ago without adjusting MAX_OPC_PARAM_IARGS. Fixing the definition becomes more important as QEMU is using an increasing number of helper functions called with 5 arguments. Add also a comment to avoid future problems when DEF_HELPER_FLAGS_6 will be added.

Re: [Qemu-devel] [PATCH] tcg: Fix MAX_OPC_PARAM_IARGS

2012-09-12 Thread Richard Henderson
On 09/12/2012 10:18 AM, Stefan Weil wrote: DEF_HELPER_FLAGS_5 was added some time ago without adjusting MAX_OPC_PARAM_IARGS. Fixing the definition becomes more important as QEMU is using an increasing number of helper functions called with 5 arguments. Add also a comment to avoid future

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Luiz Capitulino
On Wed, 12 Sep 2012 08:54:26 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Stefan Weil
Am 12.09.2012 18:45, schrieb Gleb Natapov: On Wed, Sep 12, 2012 at 06:27:14PM +0200, Stefan Weil wrote: Am 12.09.2012 15:54, schrieb Anthony Liguori: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the

Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Eric Blake
On 09/12/2012 09:22 AM, Guannan Ren wrote: After failure of qemu transaction command, the snapshot file still be there with non-zero in size. In order to unlink the file, the patch removes the file size checking. Can you give some exact steps to reproduce this, so that I know who is making the

[Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Stefan Weil
TCG uses 6 registers for function arguments on 64 bit Linux hosts, but only 4 registers on W64 hosts. Commit 2999a0b20074a7e4a58f56572bb1436749368f59 increased the number of arguments for some important helper functions from 4 to 5 which triggered a bug for W64 hosts: QEMU aborts when executing

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Clemens Kolbitsch
On 2012-09-12 15:54, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use. Mike and I spent a while talking about it yesterday and I

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Peter Maydell
On 12 September 2012 19:03, Stefan Weil s...@weilnetz.de wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index da17bba..43b5572 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -118,7 +118,7 @@ static void patch_reloc(uint8_t *code_ptr, int type, static

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Gleb Natapov
On Wed, Sep 12, 2012 at 07:30:08PM +0200, Stefan Weil wrote: Am 12.09.2012 18:45, schrieb Gleb Natapov: On Wed, Sep 12, 2012 at 06:27:14PM +0200, Stefan Weil wrote: Am 12.09.2012 15:54, schrieb Anthony Liguori: Hi, We've been running into a lot of problems lately with Windows guests and I

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-12 Thread Anthony Liguori
Gleb Natapov g...@redhat.com writes: On Wed, Sep 12, 2012 at 08:54:26AM -0500, Anthony Liguori wrote: Hi, We've been running into a lot of problems lately with Windows guests and I think they all ultimately could be addressed by revisiting the missed tick catchup algorithms that we use.

Re: [Qemu-devel] [PATCH v2 3/4] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-12 Thread Marcelo Tosatti
The problem with integrating this is that it has little or no assurance from documentation. The Linux kernel source is a good source, then say accordingly to VMWare guest support code in version xyz in the changelog. Also extracting this information in a text file (or comment in the code) would

Re: [Qemu-devel] [libvirt] [PATCH] snapshot: fix rollback failure in transaction mode

2012-09-12 Thread Jeff Cody
On 09/12/2012 01:47 PM, Eric Blake wrote: On 09/12/2012 09:22 AM, Guannan Ren wrote: After failure of qemu transaction command, the snapshot file still be there with non-zero in size. In order to unlink the file, the patch removes the file size checking. Can you give some exact steps to

Re: [Qemu-devel] [PATCH] socket: don't attempt to reconnect a TCP socket in server mode

2012-09-12 Thread Richard W.M. Jones
On Wed, Sep 05, 2012 at 02:01:36PM -0500, Anthony Liguori wrote: Commit c3767ed0eb5d0bb25fe409ae5dec06e3411ff1b6 introduced a possible SEGV when using a socket chardev with server=on because it assumes that all TCP sockets are in client mode. This patch adds a check to only reconnect when

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Aurelien Jarno
On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: On 12 September 2012 19:03, Stefan Weil s...@weilnetz.de wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index da17bba..43b5572 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -118,7

Re: [Qemu-devel] [PATCH] socket: don't attempt to reconnect a TCP socket in server mode

2012-09-12 Thread Anthony Liguori
Richard W.M. Jones rjo...@redhat.com writes: On Wed, Sep 05, 2012 at 02:01:36PM -0500, Anthony Liguori wrote: Commit c3767ed0eb5d0bb25fe409ae5dec06e3411ff1b6 introduced a possible SEGV when using a socket chardev with server=on because it assumes that all TCP sockets are in client mode.

Re: [Qemu-devel] [PATCH] w64: Fix calls of TCG helper functions with 5 arguments

2012-09-12 Thread Stefan Weil
Am 12.09.2012 21:14, schrieb Aurelien Jarno: On Wed, Sep 12, 2012 at 07:12:47PM +0100, Peter Maydell wrote: On 12 September 2012 19:03, Stefan Weils...@weilnetz.de wrote: diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index da17bba..43b5572 100644 --- a/tcg/i386/tcg-target.c +++

  1   2   >