[Qemu-devel] Doubts on SMP, VCPU and CONFIG_IOTHREAD

2012-09-18 Thread Alex Barcelo
Sorry for being so confused, I am sure that there is some manual which I haven't read, but I am not able to find it :-\ I saw some things[1] about multiple vcpu, smp and things like that. It seemed to me that --enable-io-thread enables it. But, it only works for KVM, doesn't it? I assume that

Re: [Qemu-devel] [PATCH v6 2/4] exynos4210: Added SD host controller model

2012-09-18 Thread Igor Mitsyanko
On 09/18/2012 06:41 AM, Peter Crosthwaite wrote: Ping! Igor, are you able to provide a diff of this patch so I can send the next revision? Sure, but I still don't understand what to do with QEMU-lockup issue, I believe the same topic was discussed here

[Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-18 Thread Gerd Hoffmann
Stop reinventing the wheel. Use the pixman library for raster ops. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure | 12 ui/fbdev.c | 172 +++ 2 files changed, 114 insertions(+), 70 deletions(-) diff --git

[Qemu-devel] [PATCH 9/9] fbdev: add display scaling support

2012-09-18 Thread Gerd Hoffmann
Add support for scaling the guest display. Ctrl-Alt-S hotkey toggles scaling. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/fbdev.c | 61 ++- 1 files changed, 51 insertions(+), 10 deletions(-) diff --git a/ui/fbdev.c b/ui/fbdev.c

[Qemu-devel] [PATCH 4/9] fbdev: add linux framebuffer display driver.

2012-09-18 Thread Gerd Hoffmann
Display works, requires truecolor framebuffer with 16 or 32 bpp on the host. 32bpp is recommended. The framebuffer is used as-is, qemu doesn't try to switch modes. With LCD displays mode switching is pretty pointless IMHO, also it wouldn't work anyway with the most common fbdev drivers (vesafb,

[Qemu-devel] [PATCH 2/9] add unregister_displaychangelistener

2012-09-18 Thread Gerd Hoffmann
Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the gui timer works correctly with

[Qemu-devel] [PATCH 3/9] move set_mouse + cursor_define callbacks

2012-09-18 Thread Gerd Hoffmann
When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |2 +- console.h | 39 +++ hw/jazz_led.c

[Qemu-devel] [PATCH 6/9] fbdev: make configurable at compile time.

2012-09-18 Thread Gerd Hoffmann
Add CONFIG_FBDEV, add --enable-fbdev and --disable-fbdev configure switches so fbdev can be enabled/disabled at compile time. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure| 12 qmp.c|2 +- ui/Makefile.objs |2 +- vl.c |4

[Qemu-devel] [PATCH 5/9] fbdev: add monitor command to enable/disable

2012-09-18 Thread Gerd Hoffmann
This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: fbdev enable=on|off hmp: fbdev on|off Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 15 +++ hmp.c|9 + hmp.h

[Qemu-devel] [PATCH 1/9] QLIST-ify display change listeners.

2012-09-18 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index f990684..646ad4b 100644

[Qemu-devel] [PATCH 8/9] fbdev: add mouse pointer support

2012-09-18 Thread Gerd Hoffmann
Add mouse_set and cursor_define DisplayChangeListener callbacks and mouse pointer rendering support. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/fbdev.c | 95 1 files changed, 95 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PULL 0/9] linux framebuffer display driver

2012-09-18 Thread Gerd Hoffmann
Hi, Third round of the framebuffer display driver patches, including git tree for pull as I think it's ready now. Changes: Addressed review comments from Markus. Catch a few more fatal signals, especially SIGABRT, so fbdev restores your console when qemu runs into an assert(). Misc little

Re: [Qemu-devel] Doubts on SMP, VCPU and CONFIG_IOTHREAD

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 08:27, Alex Barcelo ha scritto: I saw some things[1] about multiple vcpu, smp and things like that. It seemed to me that --enable-io-thread enables it. iothread means that the QEMU main thread only services an event loop (I/O, bottom halves, timers, etc.). Running CPUs is

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 17.09.2012 18:43, schrieb Paolo Bonzini: Il 07/09/2012 18:11, Kevin Wolf ha scritto: I was planning to review it in more detail next week, but I just had a quick look. I'm not sure if automatically shutting down the NBD server when the guest stops using it is always right (for removable

[Qemu-devel] [PATCH V3 1/5] libqblock build system

2012-09-18 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock.

[Qemu-devel] [PATCH V3 0/5] libqblock qemu block layer library

2012-09-18 Thread Wenchao Xia
This patch introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Paolo Bonzini
Luckily removable media are usually not too interesting, so a slightly suboptimal behavior is okay as long as it does not break the important use cases---mostly migration without shared storage, where also uninteresting images have to be mirrored or exposed via NBD. Those should be

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 03:52, Wen Congyang wrote: At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: Hi Wen, We've re-reviewed the dump-guest-memory command and found some possible issues with the -p option. The main issue is that it seems possible for a malicious guest to set page tables in a way that

[Qemu-devel] [PATCH V3 2/5] libqblock type defines

2012-09-18 Thread Wenchao Xia
This patch contains type and defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-internal.h | 56 + libqblock/libqblock-types.h| 268

Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-09-18 Thread Hans de Goede
Hi, On 09/17/2012 06:22 PM, Jan Kiszka wrote: If that does not work, add the debug parameter to the usb-redir device, set it to 4, collect logs of trying to redirect the device and send me the logs please, ie: -device usb-redir,chardev=usbredirchardev1,id=usbredirdev1,debug=4 Also be aware

[Qemu-devel] [PATCH V3 4/5] libqblock test build system

2012-09-18 Thread Wenchao Xia
Created a new directory in tests, make chekc-libqblock will build an executable binrary, make clean will delete it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- .gitignore |1 + Makefile |1 + tests/Makefile |

[Qemu-devel] [PATCH V3 3/5] libqblock API

2012-09-18 Thread Wenchao Xia
This patch contains the major APIs in the library. Important APIs: 1 QBroker. These structure was used to retrieve errors, every thread must create one first, later maybe thread related staff could be added into it. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It

[Qemu-devel] [PATCH V3 5/5] libqblock test example code

2012-09-18 Thread Wenchao Xia
In this example, user first create two qcow2 images, and then get the backing file relationship information of them. Then does write and read sync IO on them. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/libqblock/libqblock-test.c | 233

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 11:09, schrieb Paolo Bonzini: Luckily removable media are usually not too interesting, so a slightly suboptimal behavior is okay as long as it does not break the important use cases---mostly migration without shared storage, where also uninteresting images have to be mirrored or

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:40, Kevin Wolf ha scritto: Note that after completing the refactoring, we'll only have one combined bdrv_close/delete function and so there won't be BlockDriverStates that are closed. In this case, I think it's quite obvious that not closing the filters wouldn't make

[Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Gerd Hoffmann
This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga-pci.c | 97

Re: [Qemu-devel] ping Re: [RFC PATCH 00/13] Embedded NBD server

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 11:48, schrieb Paolo Bonzini: Il 18/09/2012 11:40, Kevin Wolf ha scritto: Note that after completing the refactoring, we'll only have one combined bdrv_close/delete function and so there won't be BlockDriverStates that are closed. In this case, I think it's quite obvious that not

Re: [Qemu-devel] [PATCH V3 2/5] libqblock type defines

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:01, Wenchao Xia ha scritto: This patch contains type and defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-internal.h | 56 +

Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:01, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and

Re: [Qemu-devel] [PATCH V3 4/5] libqblock test build system

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:01, Wenchao Xia ha scritto: Created a new directory in tests, make chekc-libqblock will build an executable binrary, make clean will delete it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- .gitignore |1 + Makefile

Re: [Qemu-devel] [PATCH V3 5/5] libqblock test example code

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:01, Wenchao Xia ha scritto: In this example, user first create two qcow2 images, and then get the backing file relationship information of them. Then does write and read sync IO on them. Please use gtest so that this can be easily extensible. Paolo Signed-off-by: Wenchao

Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-09-18 Thread Stefano Stabellini
On Tue, 18 Sep 2012, Xu, Dongxiao wrote: Hi Stefano, Is these patches merged with Xen 4.2? I didn't see them in the upstream. The uint/int fix is critical to fix the nested guest boot issue. They are not. Ian decided that he wanted to merge a different version of them.

Re: [Qemu-devel] Block Migration Assertion in qemu-kvm 1.2.0

2012-09-18 Thread Peter Lieven
On 09/17/12 22:12, Peter Lieven wrote: On 09/17/12 10:41, Kevin Wolf wrote: Am 16.09.2012 12:13, schrieb Peter Lieven: Hi, when trying to block migrate a VM from one node to another, the source VM crashed with the following assertion: block.c:3829: bdrv_set_in_use: Assertion `bs-in_use !=

Re: [Qemu-devel] Block Migration Assertion in qemu-kvm 1.2.0

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 12:28, schrieb Peter Lieven: On 09/17/12 22:12, Peter Lieven wrote: On 09/17/12 10:41, Kevin Wolf wrote: Am 16.09.2012 12:13, schrieb Peter Lieven: Hi, when trying to block migrate a VM from one node to another, the source VM crashed with the following assertion:

Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 11:01, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Benjamin Herrenschmidt
On Tue, 2012-09-18 at 11:51 +0200, Gerd Hoffmann wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. I had a patch like that somewhere (or is that it ? :-) I dropped it in favor of a more

Re: [Qemu-devel] [PATCH 2/9] add unregister_displaychangelistener

2012-09-18 Thread Stefano Stabellini
On Tue, 18 Sep 2012, Gerd Hoffmann wrote: Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the

Re: [Qemu-devel] [PATCH -v2 2/2] make the compaction skip ahead logic robust

2012-09-18 Thread Mel Gorman
On Tue, Sep 18, 2012 at 09:14:55AM +0100, Richard Davies wrote: Hi Mel, Thanks for your latest patch, I attach a perf report below with this on top of all previous patches. There is still lock contention, though in a different place. 59.97% qemu-kvm [kernel.kallsyms] [k]

Re: [Qemu-devel] [PATCH 1/2] qemu-char: BUGFIX, don't call FD_ISSET with negative fd

2012-09-18 Thread Andreas Färber
Am 18.09.2012 02:08, schrieb David Gibson: On Mon, Sep 17, 2012 at 01:24:51PM -0500, Anthony Liguori wrote: David Gibson da...@gibson.dropbear.id.au writes: tcp_chr_connect(), unlike for example udp_chr_update_read_handler() does not check if the fd it is using is valid (= 0) before passing

Re: [Qemu-devel] Breakage

2012-09-18 Thread malc
On Tue, 18 Sep 2012, Max Filippov wrote: On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote: On Mon, 17 Sep 2012, Anthony Liguori wrote: malc av1...@comtv.ru writes: Some(thing|one) broke compilation

Re: [Qemu-devel] [PATCH v2 1/2] Versatile Express: Fix NOR flash 0 address and remove flash alias

2012-09-18 Thread Peter Maydell
On 17 September 2012 21:07, Francesco Lavra francescolavra...@gmail.com wrote: In the A series memory map (implemented in the Cortex A15 CoreTile), the first NOR flash bank (flash 0) is mapped to address 0x0800, while address 0x can be configured as alias to either the first or the

[Qemu-devel] [RFC PATCH 05/16] qcow2: Allocate l2meta only for cluster allocations

2012-09-18 Thread Kevin Wolf
Even for writes to already allocated clusters, an l2meta is allocated, though it stays effectively unused. After this patch, only allocating requests still have one. Each l2meta now describes an in-flight request that writes to clusters that are not yet hooked up in the L2 table. Signed-off-by:

[Qemu-devel] [RFC PATCH 11/16] qcow2: Add error handling to the l2meta coroutine

2012-09-18 Thread Kevin Wolf
Not exactly bisectable, but one large patch isn't much better either :-( m-error is used to allow bdrv_drain() to stop with l2meta in error state rather than go into an endless loop. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 44

[Qemu-devel] [RFC PATCH 12/16] qcow2: Handle dependencies earlier

2012-09-18 Thread Kevin Wolf
Handling overlapping allocations aren't just a detail of cluster allocation. They are rather one of three ways to get the host cluster offset for a write request: 1. If a request overlaps an in-flight allocations, the cluster offset can be taken from there (this is what handle_dependencies

[Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 29 + block/qcow2.c | 31 --- block/qcow2.h | 10 ++ 3 files changed, 67 insertions(+), 3 deletions(-) diff --git a/block/qcow2-cluster.c

[Qemu-devel] [RFC PATCH 14/16] qcow2: Execute run_dependent_requests() without lock

2012-09-18 Thread Kevin Wolf
There's no reason for run_dependent_requests() to hold s-lock, and a later patch will require that in fact the lock is not held. Also, before this patch, run_dependent_requests() not only does what its name suggests, but also removes the l2meta from the list of in-flight requests. Change this,

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Gerd Hoffmann
On 09/18/12 12:32, Benjamin Herrenschmidt wrote: On Tue, 2012-09-18 at 11:51 +0200, Gerd Hoffmann wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. I had a patch like that somewhere (or

[Qemu-devel] [RFC PATCH 07/16] qcow2: Factor out handle_dependencies()

2012-09-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 70 +--- 1 files changed, 42 insertions(+), 28 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 7a038ac..468ef1b 100644 --- a/block/qcow2-cluster.c

[Qemu-devel] [RFC PATCH 02/16] qcow2: Introduce Qcow2COWRegion

2012-09-18 Thread Kevin Wolf
This makes it easier to address the areas for which a COW must be performed. As a nice side effect, the COW code in qcow2_alloc_cluster_link_l2 becomes really trivial. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 85 +++--

[Qemu-devel] [RFC PATCH 13/16] qcow2: Change handle_dependency to byte granularity

2012-09-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 26 -- block/qcow2.h | 11 +++ 2 files changed, 27 insertions(+), 10 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 4d5c3da..440fdbf 100644 ---

[Qemu-devel] [RFC PATCH 15/16] qcow2: Cancel COW when overwritten

2012-09-18 Thread Kevin Wolf
This is the first part of an optimisation to improve the performance of sequential cluster allocations. Typically, write requests aren't aligned to cluster boundaries, so sequential allocation means that every other request has to wait for the COW of the previous request to complete. We can do

[Qemu-devel] [PATCH] Added LEON MMU ASI mappings and corrected LEON3 MMU masks.

2012-09-18 Thread Ronald Hecht
This patch adds SPARC ASI mappings that are used by the LEON processor.It also corrects the MMU context register and context table pointer mask of the LEON3. Signed-off-by: Ronald Hecht ronald.he...@gmx.de --- target-sparc/cpu.c |4 ++-- target-sparc/ldst_helper.c |6 ++ 2

[Qemu-devel] [PATCH] Added LEON MMU ASI mappings and corrected LEON3 MMU masks.

2012-09-18 Thread Ronald Hecht
This patch adds SPARC ASI mappings that are used by the LEON processor.It also corrects the MMU context register and context table pointer mask of the LEON3. Signed-off-by: Ronald Hecht ronald.he...@gmx.de --- target-sparc/cpu.c |4 ++-- target-sparc/ldst_helper.c |6 ++ 2

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-18 03:52, Wen Congyang wrote: At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: Hi Wen, We've re-reviewed the dump-guest-memory command and found some possible issues with the -p option. The main issue is that it seems possible for a

[Qemu-devel] [RFC PATCH 16/16] [BROKEN] qcow2: Overwrite COW and allocate new cluster at the same time

2012-09-18 Thread Kevin Wolf
Cancelling COW when it's overwritten by a subsequent write request of the guest was a good start, however in practice we don't gain performance yet. The second write request is split in two, the first one containing the overwritten COW area, and the second one allocating another cluster. We can

[Qemu-devel] [RFC PATCH 08/16] qcow2: Reading from areas not in L2 tables yet

2012-09-18 Thread Kevin Wolf
In preparation of delayed COW (i.e. completing the guest write request before the associated COWs have completed) we must make sure that after the guest data has written the new data is read back, even if the COW hasn't completed and the new cluster isn't linked in the L2 table yet.

Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file

2012-09-18 Thread Michael Tokarev
Has it been applied to anything? I don't think so. Is it still needed? Thanks, /mjt On 07.06.2012 20:23, Andreas Färber wrote: config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual

[Qemu-devel] [RFC PATCH 00/16] qcow2: Delayed COW

2012-09-18 Thread Kevin Wolf
During the last few releases we have got rid of most of the overhead of metadata writes during cluster allocation. What's left is the COW for unaligned allocating write requests, and it's quite expensive. In the general case, this cost cannot be avoided. However, if we're lucky enough that before

[Qemu-devel] [RFC PATCH 09/16] qcow2: Move COW and L2 update into own coroutine

2012-09-18 Thread Kevin Wolf
This creates a separate coroutine for processing the COW and the L2 table update of allocating requests. The request itself can then complete while the second part is still being processed. We need a qemu_aio_flush() hook in order to ensure that these coroutines for the second part aren't still

[Qemu-devel] [RFC PATCH 01/16] qcow2: Round QCowL2Meta.offset down to cluster boundary

2012-09-18 Thread Kevin Wolf
The offset within the cluster is already present as n_start and this is what the code uses. QCowL2Meta.offset is only needed at a cluster granularity. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |4 ++-- block/qcow2.h | 22 ++ 2 files

[Qemu-devel] [RFC PATCH 04/16] qcow2: Drop l2meta.cluster_offset

2012-09-18 Thread Kevin Wolf
There's no real reason to have an l2meta for normal requests that don't allocate anything. Before we can get rid of it, we must return the host cluster offset in a different way. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 10 ++ block/qcow2.c | 14

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 14:23, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-18 03:52, Wen Congyang wrote: At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: Hi Wen, We've re-reviewed the dump-guest-memory command and found some possible issues with the -p option. The

[Qemu-devel] [RFC PATCH 03/16] qcow2: Allocate l2meta dynamically

2012-09-18 Thread Kevin Wolf
As soon as delayed COW is introduced, the l2meta struct is needed even after completion of the request, so it can't live on the stack. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 26 +++--- 1 files changed, 15 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 5/9] fbdev: add monitor command to enable/disable

2012-09-18 Thread Luiz Capitulino
On Tue, 18 Sep 2012 09:17:10 +0200 Gerd Hoffmann kra...@redhat.com wrote: This patch adds a fbdev monitor command to enable/disable the fbdev display at runtime to both qmp and hmp. qmp: fbdev enable=on|off hmp: fbdev on|off Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.

2012-09-18 Thread Kevin Wolf
Am 17.09.2012 17:22, schrieb Bharata B Rao: sockets: Make inet_parse() non static. From: Bharata B Rao bhar...@linux.vnet.ibm.com Make inet_parse() non-static so that other subsystems like gluster can use it to parse inet addresses. As a pre-requisite, define and globalize the

[Qemu-devel] [RFC PATCH 06/16] qcow2: Enable dirty flag in qcow2_alloc_cluster_link_l2

2012-09-18 Thread Kevin Wolf
This is closer to where the dirty flag is really needed, and it avoids having checks for special cases related to cluster allocation directly in the writev loop. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |5 - block/qcow2.c |7 +-- block/qcow2.h

Re: [Qemu-devel] [PATCH] Added LEON MMU ASI mappings and corrected LEON3 MMU masks.

2012-09-18 Thread Fabien Chouteau
On 09/18/2012 01:47 PM, Ronald Hecht wrote: This patch adds SPARC ASI mappings that are used by the LEON processor.It also corrects the MMU context register and context table pointer mask of the LEON3. Reviewed-by: Fabien Chouteau chout...@adacore.com -- Fabien Chouteau

Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static.

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 14:47, Kevin Wolf ha scritto: Makefile.objs |2 +- qemu-config.c | 31 +++ qemu-sockets.c | 42 ++ qemu_socket.h |1 + 4 files changed, 39 insertions(+), 37 deletions(-) Making the option

[Qemu-devel] [PATCH] SPARC LEON power-down support added

2012-09-18 Thread Ronald Hecht
Signed-off-by: Ronald Hecht address@hidden --- target-sparc/cpu.c |2 +- target-sparc/cpu.h |1 + target-sparc/helper.h |1 + target-sparc/ldst_helper.c |9 + target-sparc/translate.c |5 + 5 files changed, 17 insertions(+), 1 deletions(-)

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-18 Thread Jan Kiszka
On 2012-09-18 14:50, GaoYi wrote: Hi Jan, I have followed a previous thread about ELI proposed by Abel Gordon, http://www.spinics.net/lists/kvm/msg73907.html. I wonder whether this mechanism will be incorporated in KVM someday. Likely not. Both Intel and AMD will soon ship hardware

[Qemu-devel] guest clock management for testing real-time systems

2012-09-18 Thread Sébastien Barthélémy
Hello all, In order to test and debug a linux-based real-time system, I'd like to hook it up to a software simulator, which sadly does not run fast enough to meet the real-time constraints. To workaround this problem, I had the idea of running the real-time system in guest whose clock would be

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-18 Thread Kevin Wolf
Am 17.09.2012 17:23, schrieb Bharata B Rao: sockets: Change inet_parse() to accept address specification without port From: Bharata B Rao bhar...@linux.vnet.ibm.com inet_parse() expects address:port. Change it to work without explicit port specification. In addition, don't depend solely on

Re: [Qemu-devel] KVM call for agenda for Tuesday, September 18th

2012-09-18 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. there are no agenda so . call is cancelled. Happy hacking, Juan.

[Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-18 Thread Ronald Hecht
Signed-off-by: Ronald Hecht ronald.he...@gmx.de --- target-sparc/helper.h |1 + target-sparc/ldst_helper.c |6 ++ target-sparc/translate.c | 10 +++--- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/target-sparc/helper.h b/target-sparc/helper.h index

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Luiz Capitulino
On Tue, 18 Sep 2012 14:41:53 +0200 Jan Kiszka jan.kis...@siemens.com wrote: On 2012-09-18 14:23, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-18 03:52, Wen Congyang wrote: At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: Hi Wen, We've re-reviewed the

Re: [Qemu-devel] qmp: dump-guest-memory: -p option has issues, fix it or drop it?

2012-09-18 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-18 14:23, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2012-09-18 03:52, Wen Congyang wrote: At 09/18/2012 01:56 AM, Luiz Capitulino Wrote: Hi Wen, We've re-reviewed the dump-guest-memory command and found some

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 15:22, Kevin Wolf ha scritto: Am 17.09.2012 17:23, schrieb Bharata B Rao: sockets: Change inet_parse() to accept address specification without port From: Bharata B Rao bhar...@linux.vnet.ibm.com inet_parse() expects address:port. Change it to work without explicit port

Re: [Qemu-devel] [PATCH v2 2/2] Versatile Express: add modelling of NOR flash

2012-09-18 Thread Peter Maydell
On 17 September 2012 21:08, Francesco Lavra francescolavra...@gmail.com wrote: This patch adds modelling of the two NOR flash banks found on the Versatile Express motherboard. Tested with U-Boot running on an emulated Versatile Express, with either A9 or A15 CoreTile. Signed-off-by: Francesco

[Qemu-devel] [PATCH] hw/pflash_cfi0[12]: Use host-utils.h ctz32()

2012-09-18 Thread Peter Maydell
Drop the private reimplementation of ctz32() from pflash_cfi0[12] in favour of using the standard version from host-utils.h. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/pflash_cfi01.c | 37 + hw/pflash_cfi02.c | 37

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-18 Thread Kevin Wolf
Am 17.09.2012 17:26, schrieb Bharata B Rao: block: Support GlusterFS as a QEMU block backend. From: Bharata B Rao bhar...@linux.vnet.ibm.com This patch adds gluster as the new block backend in QEMU. This gives QEMU the ability to boot VM images from gluster volumes. Its already possible

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 15:31, schrieb Paolo Bonzini: Il 18/09/2012 15:22, Kevin Wolf ha scritto: Am 17.09.2012 17:23, schrieb Bharata B Rao: sockets: Change inet_parse() to accept address specification without port From: Bharata B Rao bhar...@linux.vnet.ibm.com inet_parse() expects address:port.

Re: [Qemu-devel] [PATCH 3/9] move set_mouse + cursor_define callbacks

2012-09-18 Thread Stefano Stabellini
On Tue, 18 Sep 2012, Gerd Hoffmann wrote: When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com This patch is good. The one thing I don't like is

Re: [Qemu-devel] [PATCH] SPARC LEON power-down support added

2012-09-18 Thread Andreas Färber
Hi, Am 18.09.2012 14:58, schrieb Ronald Hecht: Signed-off-by: Ronald Hecht address@hidden That's not a valid SoB, please fix. :) Also please use a target-sparc: prefix in your subjects to make clear what the patch is about (applies to all three patches). If the patches are otherwise okay,

Re: [Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-18 Thread Fabien Chouteau
On 09/18/2012 03:29 PM, Ronald Hecht wrote: Signed-off-by: Ronald Hecht ronald.he...@gmx.de Reviewed-by: Fabien Chouteau chout...@adacore.com -- Fabien Chouteau

[Qemu-devel] [PATCH 5/5] tcg: Optimize two-address commutative operations

2012-09-18 Thread Richard Henderson
While swapping constants to the second operand, swap sources matching destinations to the first operand. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 13:40, Kevin Wolf ha scritto: +again: +QLIST_FOREACH(m, s-cluster_allocs, next_in_flight) { +if (m-sleeping) { +qemu_coroutine_enter(m-co, NULL); +/* next_in_flight link could have become invalid */ +goto again; +} +

Re: [Qemu-devel] [RFC PATCH 11/16] qcow2: Add error handling to the l2meta coroutine

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 13:40, Kevin Wolf ha scritto: Not exactly bisectable, but one large patch isn't much better either For better bisectability you could add the co_sleep_ns in a separate patch, later in the series. Paolo

Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file

2012-09-18 Thread Andreas Färber
Am 18.09.2012 14:29, schrieb Michael Tokarev: Has it been applied to anything? I don't think so. Is it still needed? Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo. /-F Thanks, /mjt On 07.06.2012 20:23, Andreas Färber wrote: config-devices.mak.d is included from

Re: [Qemu-devel] [RFC PATCH 14/16] qcow2: Execute run_dependent_requests() without lock

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 13:40, Kevin Wolf ha scritto: static void run_dependent_requests(BDRVQcowState *s, QCowL2Meta *m) { -/* Take the request off the list of running requests */ -if (m-nb_clusters != 0) { -QLIST_REMOVE(m, next_in_flight); -} - /* Restart all dependent

[Qemu-devel] [PATCH 1/5] tcg: Introduce movcond

2012-09-18 Thread Richard Henderson
Implemented with setcond if the target does not provide the optional opcode. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/README | 6 ++ tcg/arm/tcg-target.h | 1 + tcg/hppa/tcg-target.h | 1 + tcg/i386/tcg-target.h | 2 ++ tcg/ia64/tcg-target.h | 2 ++

[Qemu-devel] [PATCH] target-sparc: SPARC LEON power-down support added

2012-09-18 Thread Ronald Hecht
Signed-off-by: Ronald Hecht ronald.he...@gmx.de --- target-sparc/cpu.c |2 +- target-sparc/cpu.h |1 + target-sparc/helper.h |1 + target-sparc/ldst_helper.c |9 + target-sparc/translate.c |5 + 5 files changed, 17 insertions(+), 1

[Qemu-devel] [PATCH 4/5] tcg: Optimize movcond for constant comparisons

2012-09-18 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index fba0ed9..5b0a8ce 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -397,6 +397,14 @@ static TCGArg

Re: [Qemu-devel] [RFC PATCH 09/16] qcow2: Move COW and L2 update into own coroutine

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 16:24, schrieb Paolo Bonzini: Il 18/09/2012 13:40, Kevin Wolf ha scritto: +qemu_co_mutex_unlock(s-lock); +qemu_co_rwlock_rdlock(s-l2meta_flush); Should this lock be taken in process_l2meta? It's a bit easier to follow. I'm pretty sure there was a

Re: [Qemu-devel] [RFC PATCH 15/16] qcow2: Cancel COW when overwritten

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 13:40, Kevin Wolf ha scritto: +qemu_co_mutex_unlock(s-lock); +qemu_co_rwlock_wrlock(m-l2_writeback_lock); Can anybody else take the lock as reader again at this point? If not, I wonder if this is more clear if you write it as a CoQueue. Paolo +has_wr_lock = true;

[Qemu-devel] [PATCH 2/5] target-alpha: Use movcond

2012-09-18 Thread Richard Henderson
For proper cmov insns, as well as the non-goto-tb case of conditional branch. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 102 ++- 1 file changed, 48 insertions(+), 54 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-18 Thread Kevin Wolf
Am 18.09.2012 16:27, schrieb Paolo Bonzini: Il 18/09/2012 13:40, Kevin Wolf ha scritto: +again: +QLIST_FOREACH(m, s-cluster_allocs, next_in_flight) { +if (m-sleeping) { +qemu_coroutine_enter(m-co, NULL); +/* next_in_flight link could have become invalid */

[Qemu-devel] [PATCH 0/2] target-i386: Fix default Hypervisor level for kvm

2012-09-18 Thread Don Slutz
Looking at http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html The new value for EAX is 0x4001. This depends on http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02497.html As far as I known it is #5. It depends on (1), (2), (3) and (4). Based on cpu-queue[1] branch.

[Qemu-devel] [PATCH 1/2] target-i386: Fix default Hypervisor level for accel=kvm.

2012-09-18 Thread Don Slutz
From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html EAX should be KVM_CPUID_FEATURES (0x4001) not 0. --- target-i386/kvm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 761a9b1..0c9f5dd 100644 ---

Re: [Qemu-devel] [RFC PATCH 09/16] qcow2: Move COW and L2 update into own coroutine

2012-09-18 Thread Paolo Bonzini
Il 18/09/2012 13:40, Kevin Wolf ha scritto: +qemu_co_mutex_unlock(s-lock); +qemu_co_rwlock_rdlock(s-l2meta_flush); Should this lock be taken in process_l2meta? It's a bit easier to follow. Paolo +l2meta-is_written = true; +co =

[Qemu-devel] [PATCH 2/2] target-i386: Fix default Hypervisor level for hypervisor-vendor=kvm.

2012-09-18 Thread Don Slutz
From http://lkml.indiana.edu/hypermail/linux/kernel/1205.0/00100.html EAX should be KVM_CPUID_FEATURES (0x4001) not 0. If kvm is not configured, the additional option of hypervisor-level=1 (or hypervisor-level=0x4001) needs to be specified to get this. --- target-i386/cpu.c | 12

  1   2   3   >