[Qemu-devel] [PATCH v1 3/7] pflash_cfi0x: QOMified

2012-10-18 Thread Peter Crosthwaite
QOMified the pflash_cfi0x so machine models can connect them up in custom ways. Kept the pflash_cfi0x_register functions as is. They can still be used to create a flash straight onto system memory. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c | 142 ++

Re: [Qemu-devel] Building QEMU with multiple CPU targets.

2012-10-18 Thread Peter Crosthwaite
Hi All, Thanks for the responses. Ill look into further in the near future, probably starting the the Linker based approaches. Regards, Peter

[Qemu-devel] [PATCH v1 7/7] nand: Reset addressing after READSTATUS.

2012-10-18 Thread Peter Crosthwaite
From: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/nand.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index 01f3ada..f931d0c 100644 --- a/hw/nand.c +++ b/hw/nand.c @@ -478,6 +478,12 @@ void nand_setio(DeviceState *dev, uint32

[Qemu-devel] [PATCH v1 6/7] xilinx_zynq: add pl353

2012-10-18 Thread Peter Crosthwaite
Add the pl353 memory controller with both NAND and parallel flashes attached. Signed-off-by: Peter Crosthwaite --- hw/xilinx_zynq.c | 49 + 1 files changed, 41 insertions(+), 8 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index

[Qemu-devel] [PATCH v1 5/7] hw: Model of Primecell pl35x mem controller

2012-10-18 Thread Peter Crosthwaite
Initial device model for the pl35x series of memory controllers. The SRAM interface is just implemented as a passthrough using memory regions. NAND interfaces are modelled. Signed-off-by: Peter Crosthwaite --- default-configs/arm-softmmu.mak |1 + hw/Makefile.objs|1 + h

[Qemu-devel] [PATCH v1 4/7] sysbus/sysbus_mmio_map: parameterise mapped region

2012-10-18 Thread Peter Crosthwaite
Add a variant to sysbus_mmio_map that allow specifying a target memory region. The requested device memory region is mapped within the argument target memory region rather than the default (get_system_memory()). Behaviour of original sysbus_mmio_map remains unchanged. The will probably go away or

[Qemu-devel] [PATCH v1 2/7] pflash_cfi01: remove unused total_len field

2012-10-18 Thread Peter Crosthwaite
This field is completely unused. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 4f3f5f0..ebc8a57 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflash_cfi01.c @@ -62,7 +62,6 @@

[Qemu-devel] [PATCH v1 1/7] pflash_cfi0x: remove unused base field

2012-10-18 Thread Peter Crosthwaite
This field is completely unused. The base address should also be abstracted away from the device anyway. Removed. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c |2 -- hw/pflash_cfi02.c |4 +--- 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/pflash_cfi01.c b/h

[Qemu-devel] [PATCH v1 0/7] QOMify pflash_cfi0x + PL353 for Xilinx Zynq

2012-10-18 Thread Peter Crosthwaite
This series adds the PL353 to Xilinx Zynq with both NAND and pflashes attached. Had to QOMify the pflash_cfi0x devices to get them working with PL35x in the least hackish way. Regression tested pflash_cfi_01 using petalogix-ml605 and pflash_cfi_02 tested using zynq. Further testing by clients of

[Qemu-devel] [PATCH V3] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c

[Qemu-devel] [PATCH V3] E1000 RX ring management fix

2012-10-18 Thread Dmitry Fleytman
Following patch fixes improper RX ring management E1000 code Changes from version 2: Commit message beautification Changes from version 1: 1st patch changed so it drops check_rxov field because it is redundant and leads to race conditions See commit description for details 2nd p

[Qemu-devel] [PATCH v11 13/14] target-mips: Add ASE DSP testcases

2012-10-18 Thread Jovanovic, Petar
> diff --git a/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c > b/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c > new file mode 100644 > index 000..65d3993 > --- /dev/null > +++ b/tests/tcg/mips/mips32-dspr2/dpaqx_sa_w_ph.c > @@ -0,0 +1,31 @@ > +#include > +#include > + > +int main() > +{ > +i

[Qemu-devel] [PATCH 05/26] qapi: qapi_visit.py, support arrays and complex qapi definitions

2012-10-18 Thread Michael Roth
Add support for arrays in the code generators. Complex field descriptions can now be used to provide additional information to the visitor generators, such as the max size of an array, or the field within a struct to use to determine how many elements are present in the array to avoid serializing

[Qemu-devel] [PATCH 24/26] qidl: add QAPI-based code generator

2012-10-18 Thread Michael Roth
This takes the declarations generated by the QIDL parser and converts them to QAPI schemas to generate the visitor routines and other supporting code for QIDL. Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- scripts/qidl.py | 291 +

[Qemu-devel] [PATCH 04/26] qapi: qapi_visit.py, make code useable as module

2012-10-18 Thread Michael Roth
Reviewed-by: Anthony Liguori Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- scripts/qapi_visit.py | 157 + 1 file changed, 81 insertions(+), 76 deletions(-) diff --git a/scripts/qapi_visit.py b/scripts/qapi_visit.py index a360de7..f9

[Qemu-devel] [PATCH 12/26] qapi: fix potential segfault for visit_type_size()

2012-10-18 Thread Michael Roth
visit_type_size() was added for use-cases currently only encountered by OptsVisitor users, which implements a specific handler for visit_type_size(). For Visitor implementations that don't implement the handler, we fallback to using v->type_uint64(). However, some visitor implementations, such as

[Qemu-devel] [PATCH 07/26] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs

2012-10-18 Thread Michael Roth
Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth --- scripts/qapi_visit.py |9 + 1 file changed, 9 insertions(+) diff --git a/scripts/qapi_visit.py b/scripts/qapi_visit.py index 856df5e..c531a5a 100644 --- a/scripts/qapi_visit.py +++ b/scripts/qapi_visit.py @@ -145,6 +145,15

[Qemu-devel] [PATCH 09/26] qapi: QmpOutputVisitor, implement array handling

2012-10-18 Thread Michael Roth
Signed-off-by: Michael Roth --- qapi/qmp-output-visitor.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/qapi/qmp-output-visitor.c b/qapi/qmp-output-visitor.c index 2bce9d5..83cf0dc 100644 --- a/qapi/qmp-output-visitor.c +++ b/qapi/qmp-output-visitor.c @@ -181,6 +181,

[Qemu-devel] [PATCH 08/26] qapi: add visitor interfaces for C arrays

2012-10-18 Thread Michael Roth
Generally these will be serialized into lists, but the representation can be of any form so long as it can be deserialized into a single-dimension C array. Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- qapi/qapi-visit-core.c | 25 + qapi/qapi-visit-core.h

[Qemu-devel] [PATCH 25/26] qidl: qidl.h, definitions for qidl annotations

2012-10-18 Thread Michael Roth
Signed-off-by: Michael Roth --- qidl.h | 149 1 file changed, 149 insertions(+) create mode 100644 qidl.h diff --git a/qidl.h b/qidl.h new file mode 100644 index 000..27f04ac --- /dev/null +++ b/qidl.h @@ -0,0 +1,149 @@ +/*

[Qemu-devel] [PATCH 11/26] qapi: QmpInputVisitor, don't re-allocate memory in start_struct

2012-10-18 Thread Michael Roth
If we're given a pointer that has already be initialized to a non-NULL value, don't attempt to allocate memory for the object as we'll likely clobber something we weren't supposed to. Also, fix up a check in the unit test that may fail as a result of this change do to it not initializing the objec

[Qemu-devel] [PATCH 16/26] qapi: Improve existing docs and document annotated QAPI types

2012-10-18 Thread Michael Roth
Signed-off-by: Michael Roth --- docs/qapi-code-gen.txt | 251 +--- 1 file changed, 237 insertions(+), 14 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index cccb11e..d3ca74a 100644 --- a/docs/qapi-code-gen.txt +++ b/docs/q

[Qemu-devel] [PATCH 18/26] qom-fuse: workaround for truncated properties > 4096

2012-10-18 Thread Michael Roth
We currently hard-code property size at 4096 for the purposes of getattr()/stat()/etc. For 'state' properties we can exceed this easily, leading to truncated responses. Instead, for a particular property, make it max(4096, most_recent_property_size * 2). This allows some head-room for properties t

[Qemu-devel] [PATCH 06/26] qapi: qapi_visit.py, support generating static functions

2012-10-18 Thread Michael Roth
qidl embeds visitor code into object files rather than linking against seperate files, so allow for static declarations when we're using qapi_visit.py as a library as we do with qidl.py Reviewed-by: Anthony Liguori Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- scripts/qapi_visit.p

Re: [Qemu-devel] [PATCH v4 26/26] qidl: unit tests and build infrastructure

2012-10-18 Thread Michael Roth
On Tue, Oct 16, 2012 at 09:21:05AM +0200, Paolo Bonzini wrote: > Il 15/10/2012 18:37, Michael Roth ha scritto: > > There is another way to do this (still using a "dummy" target) that is a > > bit less cryptic: > > > > QIDL-PP-%: %.c qidl.h ... > > > > > > %.o: QIDL-PP-% > > > > > > Bu

[Qemu-devel] [PATCH 03/26] qapi: qapi-commands.py -> qapi_commands.py

2012-10-18 Thread Michael Roth
Python doesn't allow "-" in module names, so we need to rename the file so we can re-use bits of the codegen. Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- Makefile |8 scripts/{qapi-commands.py => qapi_commands.py} |0 tests/M

[Qemu-devel] [PATCH 14/26] qapi: qapi.py, make json parser more robust

2012-10-18 Thread Michael Roth
Currently the QAPI JSON parser expects a very particular style of code indentation, the major one being that terminating curly/square brackets are not on placed on a seperate line. This is incompatible with most pretty-print formats, so make it a little more robust by supporting these cases. Also

Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator

2012-10-18 Thread Michael Roth
On Tue, Oct 16, 2012 at 09:20:09AM +0200, Paolo Bonzini wrote: > Il 15/10/2012 18:35, Michael Roth ha scritto: > >> - immutable/derived/broken/elsewhere (and the default, let's call it > >> serialized) are really five cases of the same QIDL property. Perhaps > >> this could be enforced in the exte

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-18 Thread Oliver
Thank you for all the help. I have made a lot of progress. I think there might be a bug lm3s811 device, but I will look into that and log a bug if I find it. As usual with these problems, it was not just one thing. The TI make files for using gcc produced bad code (I hand check by looking at t

[Qemu-devel] [PATCH 26/26] qidl: unit tests and build infrastructure

2012-10-18 Thread Michael Roth
Signed-off-by: Michael Roth --- Makefile |3 + configure|1 + rules.mak| 27 ++- tests/Makefile |8 +- tests/test-qidl-included.h | 25 +++ tests/test-qidl-linked.c | 101 +++ tests/test-qidl

[Qemu-devel] [PATCH 23/26] qidl: add C parser (based on QC parser)

2012-10-18 Thread Michael Roth
This introduces the QIDL parser to process QIDL annotations in C files. This code is mostly a straight import from qc.git, with some reworking to handle the declaration/annotation format and lexer we're using for QEMU. Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- scripts/qidl_pars

[Qemu-devel] [PATCH 21/26] qidl: add documentation

2012-10-18 Thread Michael Roth
Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- docs/qidl.txt | 347 + 1 file changed, 347 insertions(+) create mode 100644 docs/qidl.txt diff --git a/docs/qidl.txt b/docs/qidl.txt new file mode 100644 index 000..7d17cdc -

[Qemu-devel] [PATCH 20/26] qdev: move Property-related declarations to qdev-properties.h

2012-10-18 Thread Michael Roth
Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- hw/qdev-properties.h | 151 ++ hw/qdev.h| 126 + 2 files changed, 152 insertions(+), 125 deletions(-) create mode 100644 hw/qdev-prope

[Qemu-devel] [PATCH 22/26] qidl: add lexer library (based on QC parser)

2012-10-18 Thread Michael Roth
Adds an abstract Lexer class to handle tokenizer via a peek/pop/peekline/popline interface, along with an implementation for C based on the lexer from qc.git Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- scripts/lexer.py | 325 ++

[Qemu-devel] [PATCH 19/26] module additions for schema registration

2012-10-18 Thread Michael Roth
Reviewed-by: Anthony Liguori Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- module.h |2 ++ vl.c |1 + 2 files changed, 3 insertions(+) diff --git a/module.h b/module.h index c4ccd57..cb81aa2 100644 --- a/module.h +++ b/module.h @@ -25,6 +25,7 @@ typedef enum { MOD

[Qemu-devel] [PATCH 13/26] qapi: ordereddict, add to_json() method

2012-10-18 Thread Michael Roth
This allows OrderedDict() instances to be [pretty-]printed to QAPI-compatible JSON structures with field ordering preserved. This is useful for QIDL, which generates schemas programatically and exposes them to users in various ways. Signed-off-by: Michael Roth --- scripts/ordereddict.py | 51 +

[Qemu-devel] [PATCH 17/26] qom-fuse: force single-threaded mode to avoid QMP races

2012-10-18 Thread Michael Roth
python-fuse defaults to multi-threaded handling of filesystem calls. In the case of QOM this can lead to threads reading QMP responses to requests executed by other threads, causing all sorts of strangeness when interacting with QOM mounts. For instance: mdroth@loki:~/w/qom$ ls -l machine | grep

[Qemu-devel] [PATCH 10/26] qapi: QmpInputVisitor, implement array handling

2012-10-18 Thread Michael Roth
Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c index 107d8d3..635106e 100644 --- a/qapi/qmp-input-visitor.c +++ b/qapi/qm

[Qemu-devel] [PATCH 15/26] qapi: add open-coded visitor for struct tm types

2012-10-18 Thread Michael Roth
Reviewed-by: Anthony Liguori Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- qapi/Makefile.objs |1 + qapi/misc-qapi-visit.c | 14 ++ qapi/qapi-visit-core.h |3 +++ 3 files changed, 18 insertions(+) create mode 100644 qapi/misc-qapi-visit.c diff --git a/qa

[Qemu-devel] [PATCH 02/26] qapi: qapi-types.py -> qapi_types.py

2012-10-18 Thread Michael Roth
Python doesn't allow "-" in module names, so we need to rename the file so we can re-use bits of the codegen Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- Makefile |8 scripts/{qapi-types.py => qapi_types.py} |0 tests/Makefile

[Qemu-devel] [PATCH v5 00/26] Add infrastructure for QIDL-based device serialization

2012-10-18 Thread Michael Roth
These patches are based are origin/master, and can also be obtained from: git://github.com/mdroth/qemu.git qidl-base-v5 Changes since v4: - Added QIDL_DECLARE_PUBLIC() and QIDL_IMPLEMENT_PUBLIC() to avoid duplicating generated code for declarations pulled in via public header files. QIDL_

[Qemu-devel] [PATCH 01/26] qapi: qapi-visit.py -> qapi_visit.py so we can import

2012-10-18 Thread Michael Roth
Python doesn't allow "-" in module names, so we need to rename the file so we can re-use bits of the codegen Reviewed-by: Anthony Liguori Reviewed-by: Paolo Bonzini Signed-off-by: Michael Roth --- Makefile |8 scripts/{qapi-visit.py => qapi_visit.py

Re: [Qemu-devel] [PATCH V13 1/6] docs: document for add-cow file format

2012-10-18 Thread Dong Xu Wang
于 10/19/2012 12:10 AM, Eric Blake 写道: > On 10/18/2012 03:51 AM, Dong Xu Wang wrote: >> Document for add-cow format, the usage and spec of add-cow are introduced. >> >> Signed-off-by: Dong Xu Wang >> --- >> docs/specs/add-cow.txt | 139 >> >> 1

Re: [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits

2012-10-18 Thread Eduardo Habkost
On Fri, Oct 19, 2012 at 01:34:19AM +0200, Andre Przywara wrote: > On 10/18/12 18:33, Eduardo Habkost wrote: > >On Wed, Oct 17, 2012 at 11:17:26PM +0200, Andre Przywara wrote: > >>Update QEMU's knowledge of CPUID bit names. This allows to > >>enable/disable those new features on QEMU's command line

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-18 Thread Peter Maydell
I just built QEMU from source (git master commit b6348f29, same gcc as you, MacOS 10.8.2), like this: ./configure --target-list=arm-softmmu && make -j2 and the resulting QEMU works for me. I tested with a Cortex-M3 image from here: https://bugs.launchpad.net/qemu/+bug/1028260/+attachment/3233691/

[Qemu-devel] [Bug 944645] Re: ARM: CORTEX M, ICI/IT bits in XPSR were not cleared then entering exception

2012-10-18 Thread Peter Maydell
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/944645 Title: ARM: CORTEX M, ICI/IT bits in XPSR were not cleared then entering exception Sta

[Qemu-devel] [Bug 1028260] Re: ARM: stellaris lm3s6965evb machine model broken

2012-10-18 Thread Peter Maydell
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1028260 Title: ARM: stellaris lm3s6965evb machine model broken Status in QEMU: Fix Committed

Re: [Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-18 Thread Peter Maydell
On 18 October 2012 23:06, Oliver wrote: > I tried compiling under Ubuntu > Linux oliverks-virtual-machine 2.6.38-16-generic #67-Ubuntu SMP Thu Sep 6 > 17:58:38 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux > > and it does not appear to work. I just get the statement > > VNC server running on `127.0.0.

[Qemu-devel] [Bug 1065325] Re: qemu-system-arm hangs on SIGUSR1 on OS X 10.8.2

2012-10-18 Thread Oliver
I tried compiling under Ubuntu Linux oliverks-virtual-machine 2.6.38-16-generic #67-Ubuntu SMP Thu Sep 6 17:58:38 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux and it does not appear to work. I just get the statement VNC server running on `127.0.0.1:5900' Oliver -- You received this bug notificatio

Re: [Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-18 Thread Eric Blake
On 10/18/2012 01:19 PM, Corey Bryant wrote: > This option can be used for passing file descriptors on the > command line. It mirrors the existing add-fd QMP command which > allows an fd to be passed to QEMU via SCM_RIGHTS and added to an > fd set. > > + > +static int cleanup_add_fd(QemuOpts *opts

Re: [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits

2012-10-18 Thread Andre Przywara
On 10/18/12 18:33, Eduardo Habkost wrote: On Wed, Oct 17, 2012 at 11:17:26PM +0200, Andre Przywara wrote: Update QEMU's knowledge of CPUID bit names. This allows to enable/disable those new features on QEMU's command line when using KVM and prepares future feature enablement in QEMU. ... @@ -7

Re: [Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-18 Thread Corey Bryant
On 10/18/2012 04:43 PM, Eric Blake wrote: On 10/18/2012 01:19 PM, Corey Bryant wrote: This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can b

[Qemu-devel] [RFC PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-18 Thread Alex Williamson
This makes use of the new level irqfd support enabling bypass of qemu userspace both on INTx injection and unmask. This significantly boosts the performance of devices making use of legacy interrupts (ex. ~60% better netperf TCP_RR scores for an e1000e assigned to a Linux guest and booted with pci

Re: [Qemu-devel] [PATCHv4] qemu-img rebase: use empty string to rebase without backing file

2012-10-18 Thread Alex Bligh
Kevin, --On 17 October 2012 16:45:39 +0200 Kevin Wolf wrote: um_sectors) { @@ -1675,7 +1679,12 @@ static int img_rebase(int argc, char **argv) * backing file are overwritten in the COW file now, so the visible content * doesn't change when we switch the backing file. */ -

Re: [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Thanks, Peter I'll resend the patch. Sent from my iPad On Oct 18, 2012, at 9:20 PM, Peter Maydell wrote: > On 18 October 2012 19:59, Dmitry Fleytman wrote: >> Real HW always treats RX ring with RDH == RDT as empty. >> Emulation is supposed to behave the same. > > If you need to do a v3 of th

[Qemu-devel] [PATCH 1/2] vfio-pci: Fix debug build

2012-10-18 Thread Alex Williamson
Stray variable from before MSI-X rework Signed-off-by: Alex Williamson --- hw/vfio_pci.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 639371e..0619af4 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -639,9 +639,8 @@ static voi

[Qemu-devel] [PATCH 2/2] vfio-pci: Mark non-migratable

2012-10-18 Thread Alex Williamson
We haven't magically fixed this yet. Toss in a description too. Signed-off-by: Alex Williamson --- hw/vfio_pci.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 0619af4..d5ff367 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -1946,6 +1946,10

[Qemu-devel] [PATCH 0/2][PULL] vfio-pci fixes

2012-10-18 Thread Alex Williamson
Anthony, The following changes since commit 1414968a6aecd23cb037bc9e718d6f05ead2afaf: tcg: Optimize mulu2 (2012-10-17 17:51:39 +0200) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-for-qemu-20121017.0 for you to fetch changes up to d9f0e63898d

Re: [Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-18 Thread Eric Blake
On 10/18/2012 01:19 PM, Corey Bryant wrote: > This option can be used for passing file descriptors on the > command line. It mirrors the existing add-fd QMP command which > allows an fd to be passed to QEMU via SCM_RIGHTS and added to an > fd set. > > This can be combined with commands such as -d

[Qemu-devel] [PATCH] osdep: Less restrictive F_SEFL in qemu_dup_flags()

2012-10-18 Thread Corey Bryant
qemu_dup_flags() currently limits the flags that can be set on the fcntl() F_SETFL call to those that we currently know can be set with fcntl() F_SETFL. The problem with this is that it will prevent use of new flags in the future without a code update. This patch relaxes the checking and lets fcn

[Qemu-devel] [PATCH v4 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-18 Thread Corey Bryant
qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. Note: All of the code added to monitor_fdset_add_fd(), with the exception of the error path

[Qemu-devel] [PATCH v4 4/4] qemu-config: Add new -add-fd command line option

2012-10-18 Thread Corey Bryant
This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands such as -drive to link file descriptors in an fd set to a drive:

[Qemu-devel] [PATCH v4 3/4] monitor: Prevent removing fd from set during init

2012-10-18 Thread Corey Bryant
If an fd is added to an fd set via the command line, and it is not referenced by another command line option (ie. -drive), then clean it up after QEMU initialization is complete. Signed-off-by: Corey Bryant Reviewed-by: Eric Blake --- v3: - This patch was split into it's own patch in v3 (e

[Qemu-devel] [PATCH v4 0/4] command line fd passing using fd sets

2012-10-18 Thread Corey Bryant
This series adds command line file descriptor passing support via a new -add-fd option. This is a follow-on to the existing QMP fd passing support provided in the following patch series: comments.gmane.org/gmane.comp.emulators.qemu/165463 The new -add-fd option is designed to mirror the add-fd QM

Re: [Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty

2012-10-18 Thread Peter Maydell
On 18 October 2012 19:59, Dmitry Fleytman wrote: > Real HW always treats RX ring with RDH == RDT as empty. > Emulation is supposed to behave the same. If you need to do a v3 of this patch for some reason, it would be nice to amend the summary line so it started "e1000: " so people scanning git lo

[Qemu-devel] [PATCH v4 1/4] monitor: Allow add-fd to any specified fd set

2012-10-18 Thread Corey Bryant
The first call to add an fd to an fd set was previously not allowed to choose the fd set ID. The ID was generated as the first available and ensuing calls could add more fds by specifying the fd set ID. This change allows users to choose the fd set ID on the first call. Signed-off-by: Corey Brya

Re: [Qemu-devel] [PATCH 1/4 v3] vmware_vga: Coding style cleanup

2012-10-18 Thread BALATON Zoltan
Ping? http://patchwork.ozlabs.org/patch/189750/ http://patchwork.ozlabs.org/patch/189751/ http://patchwork.ozlabs.org/patch/189752/ http://patchwork.ozlabs.org/patch/189754/

[Qemu-devel] [PATCH V2] Drop check_rxov, always treat RX ring with RHD == RDT as empty

2012-10-18 Thread Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman --- hw/e1000.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c

[Qemu-devel] [PATCH V2] E1000 RX ring management fix

2012-10-18 Thread Dmitry Fleytman
Following patch fixes improper RX ring management E1000 code Changes from version 1: 1st patch changed so it drops check_rxov field because it is redundant and leads to race conditions See commit description for details 2nd patch (live migration) dropped because corresponding field g

[Qemu-devel] [Bug 1068044] [NEW] regression: booting winxp installation iso makes qemu-system-i386 crash in latest git

2012-10-18 Thread Bernhard Übelacker
Public bug reported: Booting a windows xp sp3 installation cd with current git results on arm host and x86 host in a SIGSEGV between loading the drivers for some hardware and the selection for installation, repair or the recovery console. Bisecting leads to this commit: 0b57e287138728f72d88b06

Re: [Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-18 Thread Alexander Duyck
On 10/18/2012 07:31 AM, Stefan Hajnoczi wrote: > On Thu, Oct 18, 2012 at 10:34 AM, Dmitry Fleytman wrote: >> The real purpose of check_rxov it a bit confusing indeed, mainly >> because of unclear name (rename?), >> however it works as following: >> >> There are 2 possible when RDT == RDH for RX ri

Re: [Qemu-devel] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-18 Thread Corey Bryant
On 10/18/2012 10:29 AM, Corey Bryant wrote: On 10/17/2012 10:02 AM, Kevin Wolf wrote: Am 17.10.2012 06:16, schrieb Eric Blake: I'm still seeing the corner case of: qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&- where the dup(3) will populate fd 4 prior to the point where we get to pr

Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.

2012-10-18 Thread Paolo Bonzini
Il 18/10/2012 12:03, Gerd Hoffmann ha scritto: > Trying another approach, see attached patch. This adds backend-specific > qemu commands to add chardevs, with just the parameters needed for the > specific backend. Starting with file and tty, both accepting a path. > 'file' is nice for testing, 't

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-18 Thread Peter Maydell
On 18 October 2012 18:41, Jan Kiszka wrote: > Minor: If you do > > function() > { > #ifdef CONFIG_KVM > ... > #endif > } > >> + >> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu) >> { >> +#ifdef CONFIG_KVM >> +if (kvm_enabled()) { >> +return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2

Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-18 Thread Peter Maydell
On 18 October 2012 18:40, malc wrote: > On Thu, 18 Oct 2012, Peter Maydell wrote: > > [..snip..] > >> >> -/* FIXME: Implement this natively. */ >> -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1) >> +static void tcg_gen_abs_i32(TCGv dest, TCGv src) >> +{ >> +TCGv c0 = tcg_const_i32(0)

Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture

2012-10-18 Thread Jan Kiszka
On 2012-10-10 17:07, Peter Maydell wrote: > From: Christoffer Dall > > Add basic support for KVM on ARM architecture. > > Signed-off-by: Christoffer Dall > [PMM: Minor tweaks and code cleanup, switch to ONE_REG] > Signed-off-by: Peter Maydell > --- > hw/arm_pic.c | 28 > ta

Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-18 Thread malc
On Thu, 18 Oct 2012, Peter Maydell wrote: [..snip..] > > -/* FIXME: Implement this natively. */ > -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1) > +static void tcg_gen_abs_i32(TCGv dest, TCGv src) > +{ > +TCGv c0 = tcg_const_i32(0); > +printf("tcg_gen_abs_i32\n"); ^^^

Re: [Qemu-devel] Disabling KVM "on the fly"

2012-10-18 Thread Clemens Kolbitsch
On Thu, Oct 18, 2012 at 10:24 AM, Jan Kiszka wrote: > On 2012-10-18 08:29, Paolo Bonzini wrote: >> Il 17/10/2012 20:37, Jan Kiszka ha scritto: >>> On 2012-10-17 18:44, Paolo Bonzini wrote: Il 17/10/2012 18:37, Clemens Kolbitsch ha scritto: > Guys, > > I know this is question might

Re: [Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-18 Thread Eric Blake
On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > +# > +# @format: #optional the format of the new destination, default is to > +# probe is @mode is 'existing', e

[Qemu-devel] [PATCH 1/2] target-arm: Use TCG operation for Neon 64 bit negation

2012-10-18 Thread Peter Maydell
Use the TCG operation to do Neon 64 bit negations rather than calling a helper routine for it. Signed-off-by: Peter Maydell --- target-arm/helper.h |1 - target-arm/neon_helper.c |6 -- target-arm/translate.c |4 +++- 3 files changed, 3 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PATCH 0/2] target-arm: inline abs, 64-bit negate

2012-10-18 Thread Peter Maydell
Two minor patches which inline some operations rather than using helper functions. The 64 bit negate is a no-brainer since there's a simple TCG op for it. For abs we implement in terms of movcond: movi_i32 tmp6,$0x0 neg_i32 tmp7,tmp5 movcond_i32 tmp5,tmp5,tmp6,tmp5,tmp7,gt which the x86-64 backe

[Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-18 Thread Peter Maydell
Implement abs_i32 inline (with movcond) rather than using a helper function. Signed-off-by: Peter Maydell --- target-arm/helper.c|5 - target-arm/helper.h|1 - target-arm/translate.c | 10 -- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target-arm/

Re: [Qemu-devel] Disabling KVM "on the fly"

2012-10-18 Thread Jan Kiszka
On 2012-10-18 08:29, Paolo Bonzini wrote: > Il 17/10/2012 20:37, Jan Kiszka ha scritto: >> On 2012-10-17 18:44, Paolo Bonzini wrote: >>> Il 17/10/2012 18:37, Clemens Kolbitsch ha scritto: Guys, I know this is question might seem a bit odd, but I'm curious: Has anyone ever t

Re: [Qemu-devel] [PATCH 2/8] block: bdrv_img_create(): add param_list argument

2012-10-18 Thread Luiz Capitulino
On Thu, 18 Oct 2012 10:33:30 -0300 Luiz Capitulino wrote: > On Thu, 18 Oct 2012 13:57:45 +0200 > Kevin Wolf wrote: > > > Am 17.10.2012 21:35, schrieb Luiz Capitulino: > > > If set returns a copy of the parameter list used by the block driver > > > to create the new image. > > > > > > Signed-of

Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event

2012-10-18 Thread Eric Blake
On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > Even for jobs that need to be manually completed, management may want > to take care itself of the completion, not requiring the user to issue > a command to terminate the job. In this case we want to avoid that > they poll us continuously, waiting fo

Re: [Qemu-devel] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Stefan Weil
Am 18.10.2012 18:40, schrieb Peter Maydell: Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell --- v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil. ui/vnc-jobs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v3 05/16] block: export dirty bitmap information in query-block

2012-10-18 Thread Eric Blake
On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > v2->v3: unit of measure is now bytes > > block.c | 7 +++ > qapi-schema.json | 20 ++-- > 2 file modificati, 25 inserzioni(+), 2 rimozioni(-) > > +++ b/qapi-schema.json > @@

Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state

2012-10-18 Thread Luiz Capitulino
On Thu, 18 Oct 2012 11:14:22 +0200 Paolo Bonzini wrote: > Right now, stop followed by an incoming migration will let the > virtual machine start. cont before an incoming migration instead > will fail. > > This is bad because the actual behavior is not predictable; it is > racy with respect to t

[Qemu-devel] [PATCH v2] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Peter Maydell
Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell --- v1->v2: reinstated carelessly dropped 'if', noted by Stefan Weil. ui/vnc-jobs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 087b84d..3

Re: [Qemu-devel] [PATCH] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Peter Maydell
On 18 October 2012 17:09, Stefan Weil wrote: > Am 18.10.2012 17:03, schrieb Peter Maydell: >> - * if two threads try to write on it at the same >> time >> + * two threads try to write on it at the same >> time > > > > Did you remove the 'if' intentiona

Re: [Qemu-devel] [PATCH] i386/cpu: name new CPUID bits

2012-10-18 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 11:17:26PM +0200, Andre Przywara wrote: > Update QEMU's knowledge of CPUID bit names. This allows to > enable/disable those new features on QEMU's command line when > using KVM and prepares future feature enablement in QEMU. > > This adds F16C, RDRAND, LWP, TBM, TopoExt, Pe

Re: [Qemu-devel] [PATCH 1/2] Ignore RX tail kicks when RX disabled.

2012-10-18 Thread Dmitry Fleytman
Great! Thanks, Alex. I'll prepare a new changeset that drops check_rxov completely. Also migration-related patch becomes unneeded with this solution. On Thu, Oct 18, 2012 at 6:06 PM, Alexander Duyck wrote: > On 10/18/2012 07:31 AM, Stefan Hajnoczi wrote: >> On Thu, Oct 18, 2012 at 10:34 AM, Dmit

Re: [Qemu-devel] [PATCH V13 1/6] docs: document for add-cow file format

2012-10-18 Thread Eric Blake
On 10/18/2012 03:51 AM, Dong Xu Wang wrote: > Document for add-cow format, the usage and spec of add-cow are introduced. > > Signed-off-by: Dong Xu Wang > --- > docs/specs/add-cow.txt | 139 > > 1 files changed, 139 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] ui/vnc-jobs.c: Fix minor typos in comments

2012-10-18 Thread Stefan Weil
Please see my comments below. Am 18.10.2012 17:03, schrieb Peter Maydell: Fix some minor typos/grammar errors in comments. Signed-off-by: Peter Maydell --- ui/vnc-jobs.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c inde

[Qemu-devel] [PATCH v3 10/16] qmp: add drive-mirror command

2012-10-18 Thread Paolo Bonzini
This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini --- v2->v3: bdrv_is_inserted pulled before dereference of bs->drv blockdev.c | 124 +++ hmp-commands.hx | 21 ++ hmp.c

[Qemu-devel] [PATCH v3 11/16] mirror: implement completion

2012-10-18 Thread Paolo Bonzini
Switching to the target of the migration is done mostly asynchronously, and reported to management via the BLOCK_JOB_COMPLETED event; the only synchronous phase is opening the backing files. bdrv_open_backing_file can always be done, even for migration of the full image (aka sync: 'full'). In thi

Re: [Qemu-devel] [PATCH 2/4] net: add net_is_tap_client()

2012-10-18 Thread Stefan Hajnoczi
On Thu, Oct 18, 2012 at 05:05:51PM +0200, Paolo Bonzini wrote: > Il 18/10/2012 16:56, Stefan Hajnoczi ha scritto: > > From: Stefan Hajnoczi > > > > The vhost-net code interacts closely with the net/tap.c backend so that > > it can pass the underlying file descriptor to the vhost_net.ko driver. >

[Qemu-devel] [PATCH v3 07/16] block: add block-job-complete

2012-10-18 Thread Paolo Bonzini
While streaming can be dropped as soon as it progressed through the whole image, mirroring needs to be completed manually for two reasons: 1) so that management knows exactly when the VM switches to the target; 2) because for other use cases such as replication, we may leave the operation running f

Re: [Qemu-devel] [PATCH] ui/vnc-jobs: Delete unused and buggy vnc_stop_worker_thread()

2012-10-18 Thread Peter Maydell
Another bug: (4) if vnc_job_push() discovers that queue->exit is true it will free the job but leak its rectangle list (5) the early-exit ("goto disconnected") code paths in vnc_worker_thread_loop() also leak the rectangle list And a couple of inefficiencies/oddities which aren't actually bugs:

[Qemu-devel] [PATCH v3 05/16] block: export dirty bitmap information in query-block

2012-10-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- v2->v3: unit of measure is now bytes block.c | 7 +++ qapi-schema.json | 20 ++-- 2 file modificati, 25 inserzioni(+), 2 rimozioni(-) diff --git a/block.c b/block.c index 057b2b2..b167f61 100644 --- a/block.c +++ b/block.c @

  1   2   3   >