Re: [Qemu-devel] [PATCH] Fix out-of-tree and cross compile builds for pixman

2012-11-17 Thread Stefan Weil
Am 07.11.2012 12:47, schrieb Gerd Hoffmann: Hi, The internal pixman code is also too old for cross compilations with MinGW-w64. It already fails when running configure. Newer versions of pixman compile after a trivial modification which is needed to avoid redefined symbols: I'd prefer to

Re: [Qemu-devel] usb: uhci: Look up queue by address, not token

2012-11-17 Thread Hans de Goede
Hi, On 11/16/2012 04:06 PM, Jan Kiszka wrote: On 2012-11-16 14:29, Hans de Goede wrote: Hi, On 11/15/2012 04:40 PM, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token

Re: [Qemu-devel] usb: uhci: Look up queue by address, not token

2012-11-17 Thread Hans de Goede
Hi, On 11/16/2012 02:43 PM, Gerd Hoffmann wrote: On 11/16/12 12:24, Jan Kiszka wrote: On 2012-11-16 11:25, Gerd Hoffmann wrote: On 11/15/12 16:40, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've

[Qemu-devel] [USB Fixes for 1.3] Various uhci fixes

2012-11-17 Thread Hans de Goede
Here are 3 uhci bugfix patches for 1.3 Regards, Hans

[Qemu-devel] [PATCH 1/3] uhci: Add a completions_only flag for async completions

2012-11-17 Thread Hans de Goede
Add a completions_only flag, and set this when running process_frame for async completion handling, this fixes 2 issues in a single patch: 1) It makes sure async completed packets get written to guest mem immediately, even if all the bandwidth for the frame was consumed from the timer run

[Qemu-devel] [PATCH 2/3] uhci: Don't allow the guest to set port-enabled when there is no dev connected

2012-11-17 Thread Hans de Goede
It is possible for device disconnect and the guest trying to reset the port (because of USB xact errors prior to the disconnect getting signaled) to race, when we hit this race, the guest will write the port-control register with its pre-disconnect value + the reset bit set, after which we have a

[Qemu-devel] [PATCH 3/3] uhci: Fix double unlink

2012-11-17 Thread Hans de Goede
uhci_async_cancel() already does a uhci_async_unlink(). Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-uhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 078be2a..8e47803 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@

[Qemu-devel] [USB fixes for 1.3] Fix some interrupt eps not properly nak-ing

2012-11-17 Thread Hans de Goede
As will become clear in my next patchset, I've been reviewing all usb-devices in qemu with interrupt endpoints to add wakeup calls to all of them, during this I found that the bt and smartcard-reader devices don't properly return NAK from interrupt endpoints when they've no data, these patches fix

[Qemu-devel] [PATCH 1/2] usb-bt: Return NAK instead of STALL when interrupt ep has no data

2012-11-17 Thread Hans de Goede
I noticed this while making all devices with interrupt endpoints properly do wakeup. While at it also add wakeup support. Note that I've not tested this, but returning STALL for an interrupt ep which has no data is cleary the wrong thing to do. Signed-off-by: Hans de Goede hdego...@redhat.com

[Qemu-devel] [PATCH 2/2] usb-smartcard-reader: Properly NAK interrupt eps when we've no events

2012-11-17 Thread Hans de Goede
When we've no data to return from the interrupt endpoint, return NAK rather then a 0 length packet. CC: Alon Levy al...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/dev-smartcard-reader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [USB fixes for 1.3] usb-redir: Fix migration race with output int eps

2012-11-17 Thread Hans de Goede
This 2 patch set for 1.3 fixes a migration race for devices with output interrupt endpoints. Regards, Hans

[Qemu-devel] [PATCH 2/2] usb-redir: Don't handle interrupt output packets async

2012-11-17 Thread Hans de Goede
Instead report them as successfully completed directly on submission, this has 2 advantages: 1) This matches the timing of interrupt output packets on real hardware, with the previous async handling, if an ep has an interval of say 500 ms, then there would be 500+ ms between the submission and

[Qemu-devel] [USB patches for 1.3]: Lower cpuload when using the usb-tablet

2012-11-17 Thread Hans de Goede
And here then is my piece de resistance (at least for the last few weeks), my final version of the patchset to lower the cpuload when using the usb-tablet device, or for that matter when using any usb devices with interrupt eps connected to the ehci controller. This final version is actually

[Qemu-devel] [PATCH 1/5] usb: Call wakeup when data becomes available for all devices with int eps

2012-11-17 Thread Hans de Goede
This is necessary for proper interaction with the xhci controller, and it will allow other hcds to lower there frame timer while waiting for interrupt data. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/dev-hub.c | 2 ++ hw/usb/dev-network.c | 7 +++ hw/usb/dev-wacom.c |

[Qemu-devel] [PATCH 3/5] usb: Allow overriding of usb_desc at the device level

2012-11-17 Thread Hans de Goede
This allows devices to present a different set of descriptors based on device properties. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb.h | 1 + hw/usb/bus.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/hw/usb.h b/hw/usb.h index 58f812f..268e653 100644 --- a/hw/usb.h

[Qemu-devel] [PATCH 2/5] usb: Don't allow USB_RET_ASYNC for interrupt packets

2012-11-17 Thread Hans de Goede
It is tempting to use USB_RET_ASYNC for interrupt packets, rather then the current NAK + polling approach, but this causes issues for migration, as an async completed packet will not getting written back to guest memory until the next poll time, and if a migration happens in between it will get

[Qemu-devel] [PATCH 4/5] ehci: Lower timer freq when the periodic schedule is idle

2012-11-17 Thread Hans de Goede
Lower the timer freq if no iso schedule packets complete for 64 frames in a row. We can safely do this, without adding latency, because: 1) If there is isoc traffic this will never trigger 2) For async handled interrupt packets (only usb-host), the completion handler will immediately schedule

[Qemu-devel] [PATCH 5/5] usb-tablet: Allow connecting to ehci

2012-11-17 Thread Hans de Goede
Our ehci code has is capable of significantly lowering the wakeup rate for the hcd emulation while the device is idle. It is possible to add similar code ot the uhci emulation, but that simply is not there atm, and there is no reason why a (virtual) usb-tablet can not be a USB-2 device. Making

[Qemu-devel] [PATCH 1/2] usb-redir: Split usb_handle_interrupt_data into separate in/out functions

2012-11-17 Thread Hans de Goede
No functional changes. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 136 -- 1 file changed, 71 insertions(+), 65 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index c8e2718..9658bda 100644 ---

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-17 Thread Andreas Färber
Am 16.11.2012 17:37, schrieb Peter Maydell: When building for MacOS X, default the C compiler to 'cc' (usually clang) rather than 'gcc'. This avoids the Apple 'gcc', which is generally an elderly llvm-gcc provided mostly for legacy purposes, in favour of the best supported compiler available

Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-17 Thread Peter Maydell
On 17 November 2012 13:02, Andreas Färber andreas.faer...@web.de wrote: Am 16.11.2012 17:37, schrieb Peter Maydell: When building for MacOS X, default the C compiler to 'cc' (usually clang) rather than 'gcc'. This avoids the Apple 'gcc', which is generally an elderly llvm-gcc provided mostly

[Qemu-devel] [PATCH v2] iscsi: fix deadlock during login

2012-11-17 Thread Peter Lieven
If the connection is interrupted before the first login is successfully completed qemu-kvm is waiting forever in qemu_aio_wait(). This is fixed by performing an sync login to the target. If the connection breaks after the first successful login errors are handled internally by libiscsi. v2:

[Qemu-devel] [PATCH] rng-random: only build on POSIX platforms

2012-11-17 Thread Anthony Liguori
There is no /dev/random on win32. Cc: Stefan Weil w...@mail.berlios.de Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- backends/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backends/Makefile.objs b/backends/Makefile.objs index 875eebc..8836761 100644

[Qemu-devel] [PATCH] iscsi: add iscsi_create support

2012-11-17 Thread Peter Lieven
This patch adds support for bdrv_create. This allows e.g. to use qemu-img to convert from any supported device to an iscsi backed storage as destination. Signed-off-by: Peter Lieven p...@kamp.de diff --git a/block/iscsi.c b/block/iscsi.c index 4bc3d4b..eb586cb 100644 --- a/block/iscsi.c +++

[Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized

2012-11-17 Thread Peter Lieven
Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index eb586cb..d685f20 100644 --- a/block/iscsi.c +++

Re: [Qemu-devel] [PATCH 01/24] user: move *-user/qemu-types.h to main directory

2012-11-17 Thread Blue Swirl
On Mon, Nov 12, 2012 at 9:38 PM, Andreas Färber afaer...@suse.de wrote: Am 09.11.2012 15:56, schrieb Eduardo Habkost: The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost the same, but linux-user have the additional definitions of tswapal(). This moves the linux-user file to

Re: [Qemu-devel] [PATCH 09/17] target-i386: move out CPU features initialization to separate func

2012-11-17 Thread Blue Swirl
On Mon, Nov 12, 2012 at 9:38 PM, Eduardo Habkost ehabk...@redhat.com wrote: From: Igor Mammedov imamm...@redhat.com Later it will be used in cpu_x86_init() to init CPU from found cpudef. This is will make it easier to reorder and clean up the cpu_x86_init() code later. Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation

2012-11-17 Thread Blue Swirl
On Tue, Nov 13, 2012 at 8:50 AM, Christian Borntraeger borntrae...@de.ibm.com wrote: From: Einar Lueck elelu...@linux.vnet.ibm.com This patch disables the translation of geometry information read from disks on s390. On s390 such translations lead to wrong geometries being advertized to the

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-17 Thread Blue Swirl
On Wed, Nov 14, 2012 at 1:09 PM, Alon Levy al...@redhat.com wrote: Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v4 3/3] use elf_reset to reload elf image

2012-11-17 Thread Blue Swirl
On Wed, Nov 14, 2012 at 1:28 PM, Olivia Yin hong-hua@freescale.com wrote: Signed-off-by: Olivia Yin hong-hua@freescale.com --- elf.h| 10 ++ hw/elf_ops.h | 101 ++ 2 files changed, 111 insertions(+), 0

Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-17 Thread Blue Swirl
On Thu, Nov 15, 2012 at 3:19 PM, Stefan Hajnoczi stefa...@redhat.com wrote: The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module

[Qemu-devel] [PATCH] qemu-common: Add definition for O_NONBLOCK

2012-11-17 Thread Stefan Weil
backends/rng-random.c which was added by commit 5c74521d249486fa3e749dbbf6d56a70d4d7235f needs macro O_NONBLOCK. The macro O_NONBLOCK is not defined for all hosts. Adding a default definition fixes builds for MinGW. Signed-off-by: Stefan Weil s...@weilnetz.de --- This is a build fix. Therefore

[Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Goswin von Brederlow
Hi, I'm having problems with the startup code for my toy kernel for amd64 that switches from 32bit mode to 64bit mode and I'm at a loss how to debug this. The code used to work last year (with qemu-kvm 0.14.0) but fails now with QEMU emulator version 1.1.0 (Debian 1.1.0+dfsg-1). Has something

Re: [Qemu-devel] [PATCH v6 0/7] TCG global variables clean-up

2012-11-17 Thread Blue Swirl
On Mon, Nov 12, 2012 at 9:27 AM, Evgeny Voevodin e.voevo...@samsung.com wrote: This set of patches moves global variables to tcg_ctx: gen_opc_ptr gen_opparam_ptr gen_opc_buf gen_opparam_buf Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was

Re: [Qemu-devel] [PULL for-1.3 0/2] vga bugfixes

2012-11-17 Thread Blue Swirl
On Fri, Nov 16, 2012 at 1:47 PM, Gerd Hoffmann kra...@redhat.com wrote: Hi, Two little fixes for the standard vga, sent to the list for review earlier this week. please pull, Thanks, pulled. Gerd The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887:

[Qemu-devel] [Bug 1080086] [NEW] MC146818 RTC breaks when SET bit in Register B is on.

2012-11-17 Thread Alex Horn
Public bug reported: This bug occurs when the SET flag of Register B is enabled. When an RTC data register (i.e. any of the 10 bytes of time/calender data in CMOS) is set, the data is (as expected) correctly stored in the cmos_data array. However, since the SET flag is enabled, the function

[Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-17 Thread Alex Horn
I have attached a patch for the most recent version of the file hw/mc146818rtc.c [1]. The patch also features a functional test which executes through the QTest framework. I would appreciate your thoughts on this. [1]

Re: [Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Max Filippov
On Sat, Nov 17, 2012 at 9:50 PM, Goswin von Brederlow goswin-...@web.de wrote: Hi, I'm having problems with the startup code for my toy kernel for amd64 that switches from 32bit mode to 64bit mode and I'm at a loss how to debug this. The code used to work last year (with qemu-kvm 0.14.0) but

Re: [Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Max Filippov
On Sat, Nov 17, 2012 at 11:58 PM, Max Filippov jcmvb...@gmail.com wrote: On Sat, Nov 17, 2012 at 9:50 PM, Goswin von Brederlow goswin-...@web.de wrote: /* Enable PAE */ movl%cr4, %eax btsl$5, %eax movl%eax, %cr4 Interestingly with the current

[Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug

2012-11-17 Thread Max Filippov
cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault: the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK. This fixes odd gdb code display with PAE enabled. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-i386/helper.c | 37

Re: [Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Goswin von Brederlow
On Sat, Nov 17, 2012 at 11:18:03PM +0300, Max Filippov wrote: On Sat, Nov 17, 2012 at 11:58 PM, Max Filippov jcmvb...@gmail.com wrote: On Sat, Nov 17, 2012 at 9:50 PM, Goswin von Brederlow goswin-...@web.de wrote: /* Enable PAE */ movl%cr4, %eax btsl$5,

Re: [Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Goswin von Brederlow
On Sat, Nov 17, 2012 at 10:58:17PM +0300, Max Filippov wrote: On Sat, Nov 17, 2012 at 9:50 PM, Goswin von Brederlow goswin-...@web.de wrote: Hi, I'm having problems with the startup code for my toy kernel for amd64 that switches from 32bit mode to 64bit mode and I'm at a loss how to

Re: [Qemu-devel] Can't switch to 64bit mode at boot, how to debug?

2012-11-17 Thread Max Filippov
On Sun, Nov 18, 2012 at 2:09 AM, Goswin von Brederlow goswin-...@web.de wrote: On Sat, Nov 17, 2012 at 10:58:17PM +0300, Max Filippov wrote: On Sat, Nov 17, 2012 at 9:50 PM, Goswin von Brederlow goswin-...@web.de wrote: [...] (gdb) b *0x10 Breakpoint 1 at 0x10 (gdb) c Continuing.

[Qemu-devel] Commit b90600eed3 broke qemu-system-ppc -M g3beige.

2012-11-17 Thread Rob Landley
It worked in 1.2.0, but qemu segfaults during linux boot now. Test case: grab http://landley.net/aboriginal/bin/system-image-powerpc.tar.bz2 and in that ./run-emulator.sh. Checkout the above commit and build it: the result fails. Then git show b90600eed3 | patch -p1 -R and rebuild, it

[Qemu-devel] [PATCH v2] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-17 Thread Alon Levy
Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com --- v1-v2 deanonymized added structs (Blue Swirl) hw/virtio-serial-bus.c | 54

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode fails (bash: fork: Invalid argument)

2012-11-17 Thread Matt Zimmerman
** Summary changed: - qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument) + qemu-i386 user mode fails (bash: fork: Invalid argument) ** Summary changed: - qemu-i386 user mode fails (bash: fork: Invalid argument) + qemu-i386 user mode can't fork (bash: fork: Invalid argument)

[Qemu-devel] assertion in temp_save

2012-11-17 Thread Max Filippov
Hi Aurelien, starting with commit 2c0366f tcg: don't explicitly save globals and temps I get the following abort on target-xtensa: qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion `s-temps[temp].val_type == 2 || s-temps[temp].fixed_reg' failed. Aborted I see that that commit only adds

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] target-mips: Clean up microMIPS32 major opcode

2012-11-17 Thread Wei-Ren Chen
Please send this through Aurelian as maintainer for target-mips/. The discussion on previous the thread show this isn't qemu-trivial material :). O.K., I'll remove this from qemu-trivial if I need to send revision next time. Thanks, Stefan. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-17 Thread Wei-Ren Chen
On Fri, Nov 16, 2012 at 02:59:30PM +0100, Stefan Hajnoczi wrote: On Fri, Nov 16, 2012 at 10:29:47AM +0800, 陳韋任 (Wei-Ren Chen) wrote: Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 and microMIPS32 DSP. Add comment here to help reading. Please review, thanks. Regards,

Re: [Qemu-devel] assertion in temp_save

2012-11-17 Thread Max Filippov
On Sun, Nov 18, 2012 at 7:19 AM, Max Filippov jcmvb...@gmail.com wrote: Hi Aurelien, starting with commit 2c0366f tcg: don't explicitly save globals and temps I get the following abort on target-xtensa: qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion `s-temps[temp].val_type == 2 ||

Re: [Qemu-devel] KVM Forum 2012 Block BoF minutes

2012-11-17 Thread Marcelo Tosatti
On Thu, Nov 15, 2012 at 02:31:53PM +0100, Markus Armbruster wrote: Attendees: Kevin Wolf kw...@redhat.com Stefan Hajnoczi stefa...@redhat.com Jeff Cody jc...@redhat.com Markus Armbruster arm...@redhat.com and a few people dropping in and out. Minutes are basically a TODO list. Could

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-17 Thread Michael Tokarev
** Bug watch added: Debian Bug tracker #674201 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674201 ** Also affects: qemu (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674201 Importance: Unknown Status: Unknown -- You received this bug notification because you