[Qemu-devel] [PATCH] block: Fix regression for MinGW (assertion caused by short string)

2012-11-18 Thread Stefan Weil
The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this regression. Signed-off-by:

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-18 Thread Paolo Bonzini
Il 17/11/2012 19:47, Alex Horn ha scritto: I have attached a patch for the most recent version of the file hw/mc146818rtc.c [1]. The patch also features a functional test which executes through the QTest framework. I would appreciate your thoughts on this. [1]

Re: [Qemu-devel] [PATCH] qemu-common: Add definition for O_NONBLOCK

2012-11-18 Thread Paolo Bonzini
Il 17/11/2012 17:40, Stefan Weil ha scritto: backends/rng-random.c which was added by commit 5c74521d249486fa3e749dbbf6d56a70d4d7235f needs macro O_NONBLOCK. The macro O_NONBLOCK is not defined for all hosts. Adding a default definition fixes builds for MinGW. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-18 Thread Brad Smith
On 11/02/12 09:14, Paolo Bonzini wrote: OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-thread-posix.c | 74 + qemu-thread-posix.h | 6 + 2 file

Re: [Qemu-devel] [PATCH 3/7] dataplane: add virtqueue vring code

2012-11-18 Thread Stefan Hajnoczi
On Sat, Nov 17, 2012 at 5:15 PM, Blue Swirl blauwir...@gmail.com wrote: On Thu, Nov 15, 2012 at 3:19 PM, Stefan Hajnoczi stefa...@redhat.com wrote: The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-18 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 4:13 PM, Tim Hardeck thard...@suse.de wrote: Websockets connections are recognized by waiting 500ms for a Websocket handshake. If no data is received a regular vnc connection is assumed. If this is not acceptable please suggest if Websockets should be activated by a

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-11-18 Thread Brad Smith
On 10/23/12 08:00, Paolo Bonzini wrote: Il 23/10/2012 13:50, Peter Maydell ha scritto: On 23 October 2012 12:48, Paolo Bonzini pbonz...@redhat.com wrote: Il 22/10/2012 19:13, Peter Maydell ha scritto: Can't we enhance qemu-tls.h to work via pthread_setspecific in case __thread is not working

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-18 Thread Avi Kivity
On 11/15/2012 09:47 AM, liu ping fan wrote: On Wed, Nov 14, 2012 at 5:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/11/2012 10:38, liu ping fan ha scritto: On Tue, Nov 13, 2012 at 6:11 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/11/2012 06:38, Liu Ping Fan ha scritto: From: Liu

Re: [Qemu-devel] [PATCH] rng-random: only build on POSIX platforms

2012-11-18 Thread Stefan Weil
Am 17.11.2012 14:41, schrieb Anthony Liguori: There is no /dev/random on win32. Cc: Stefan Weilw...@mail.berlios.de Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- backends/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backends/Makefile.objs

Re: [Qemu-devel] [PATCH] qemu-common: Add definition for O_NONBLOCK

2012-11-18 Thread Stefan Weil
Am 18.11.2012 09:55, schrieb Paolo Bonzini: Il 17/11/2012 17:40, Stefan Weil ha scritto: backends/rng-random.c which was added by commit 5c74521d249486fa3e749dbbf6d56a70d4d7235f needs macro O_NONBLOCK. The macro O_NONBLOCK is not defined for all hosts. Adding a default definition fixes builds

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-18 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/739785 Title: qemu-i386 user mode can't fork (bash: fork: Invalid argument) Status in

Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs

2012-11-18 Thread Wenchao Xia
于 2012-11-16 19:12, Paolo Bonzini 写道: Il 16/11/2012 11:58, Wenchao Xia ha scritto: Sub Makefile may need qapi generated files, so move them to Makefile.objs, In this way Makfile.objs control file auto generation. No objection in principle, but why are you doing this? Does it fix

Re: [Qemu-devel] [PATCH V9 5/8] libqblock build system

2012-11-18 Thread Wenchao Xia
于 2012-11-16 19:08, Paolo Bonzini 写道: Il 16/11/2012 11:12, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first

Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly

2012-11-18 Thread Wenchao Xia
于 2012-11-16 20:49, Paolo Bonzini 写道: Il 16/11/2012 13:40, Wenchao Xia ha scritto: I guess make distclean for second time would fail in this case, because $(SRC_PATH) is not set. I found a better way to do it without MAKEFILES: -ifneq ($(wildcard config-host.mak),) - include

Re: [Qemu-devel] [PATCH] rng-random: only build on POSIX platforms

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 11:29, Stefan Weil ha scritto: Am 17.11.2012 14:41, schrieb Anthony Liguori: There is no /dev/random on win32. Cc: Stefan Weilw...@mail.berlios.de Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- backends/Makefile.objs | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 13:56, Wenchao Xia ha scritto: 于 2012-11-16 19:12, Paolo Bonzini 写道: Il 16/11/2012 11:58, Wenchao Xia ha scritto: Sub Makefile may need qapi generated files, so move them to Makefile.objs, In this way Makfile.objs control file auto generation. No objection in principle,

Re: [Qemu-devel] [PATCH V9 5/8] libqblock build system

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 14:06, Wenchao Xia ha scritto: 于 2012-11-16 19:08, Paolo Bonzini 写道: Il 16/11/2012 11:12, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 10:09, Brad Smith ha scritto: On 11/02/12 09:14, Paolo Bonzini wrote: OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-thread-posix.c | 74

Re: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation

2012-11-18 Thread Paolo Bonzini
Il 17/11/2012 17:07, Blue Swirl ha scritto: On Tue, Nov 13, 2012 at 8:50 AM, Christian Borntraeger borntrae...@de.ibm.com wrote: From: Einar Lueck elelu...@linux.vnet.ibm.com This patch disables the translation of geometry information read from disks on s390. On s390 such translations lead

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Paolo Bonzini
Il 16/11/2012 19:18, Peter Maydell ha scritto: On 16 November 2012 17:35, Paolo Bonzini pbonz...@redhat.com wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This patch uses a

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-11-18 Thread Paolo Bonzini
It does support pthread_get/setspecific, but it didn't support something else so the qemu-tls.h variant that used pthread_get/setspecific didn't work either. And it doesn't support sigaltstack in threads, so it's the only platform where the gthread-based coroutines are used. Those are

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-11-18 Thread Paolo Bonzini
It does support pthread_get/setspecific, but it didn't support something else so the qemu-tls.h variant that used pthread_get/setspecific didn't work either. And it doesn't support sigaltstack in threads, so it's the only platform where the gthread-based coroutines are

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-18 Thread Paolo Bonzini
struct virtio_console_config config; + +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Paolo +QEMUTimer *timer; +int nr_active_ports; +struct { +

Re: [Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-11-18 Thread Avi Kivity
On 11/13/2012 01:44 PM, Peter Maydell wrote: On 26 October 2012 17:00, Peter Maydell peter.mayd...@linaro.org wrote: On 26 October 2012 14:09, Paolo Bonzini pbonz...@redhat.com wrote: As soon as Avi's iommu patches go in, in fact, dma-as will just be as. Even if as == NULL were to be outlawed

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Stefan Weil
Am 18.11.2012 17:10, schrieb Paolo Bonzini: Il 16/11/2012 19:18, Peter Maydell ha scritto: On 16 November 2012 17:35, Paolo Bonzinipbonz...@redhat.com wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular

[Qemu-devel] [PATCH] tci: fix build breakage for target MIPS

2012-11-18 Thread Stefan Weil
commit 5f7319cd introduced GETPC() usage for MIPS, which is currently not defined when building with --enable-tcg-interpreter. Add MIPS to the list of targets we selectively define GETPC() for. Signed-off-by: Stefan Weil s...@weilnetz.de --- exec-all.h |7 --- 1 file changed, 4

Re: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation

2012-11-18 Thread Blue Swirl
On Sun, Nov 18, 2012 at 4:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 17/11/2012 17:07, Blue Swirl ha scritto: On Tue, Nov 13, 2012 at 8:50 AM, Christian Borntraeger borntrae...@de.ibm.com wrote: From: Einar Lueck elelu...@linux.vnet.ibm.com This patch disables the translation of

[Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize)

2012-11-18 Thread Stefan Weil
Commit 32761257c0b9fa7ee04d2871a6e48a41f119c469 enabled qemu_ld/st optimization unconditionally for some hosts. The TCG interpreter still does not support this kind of optimization. Therefore builds with TCI fail with an unresolved symbol tcg_out_tb_finalize. This is fixed here. Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-18 Thread Blue Swirl
On Sun, Nov 18, 2012 at 4:29 PM, Paolo Bonzini pbonz...@redhat.com wrote: struct virtio_console_config config; + +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Otherwise the

Re: [Qemu-devel] [PATCH] s390x: Spelling fixes (endianess - endianness, occured - occurred)

2012-11-18 Thread Stefan Weil
Am 02.11.2012 08:35, schrieb Stefan Weil: Replace also write into by write to. Signed-off-by: Stefan Weils...@weilnetz.de --- I think write to is better, but I am not sure about this, so please wait until a native speaker has reviewed that patch. Regards Stefan Weil hw/s390x/sclp.h

Re: [Qemu-devel] [PATCH] Fix comments (adress - address, layed - laid, wierd - weird)

2012-11-18 Thread Stefan Weil
Am 02.11.2012 08:29, schrieb Stefan Weil: Remove also a duplicated 'the'. Signed-off-by: Stefan Weils...@weilnetz.de --- slirp/ip_icmp.c |2 +- tcg/tcg.h |4 ++-- uri.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/ip_icmp.c

Re: [Qemu-devel] [PATCH] Fix spelling (prefered - preferred)

2012-11-18 Thread Stefan Weil
Am 02.11.2012 08:14, schrieb Stefan Weil: Signed-off-by: Stefan Weils...@weilnetz.de --- configure |2 +- net/tap-win32.c |7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 79701ea..860859b 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH v2] tci: Support deposit operations

2012-11-18 Thread Stefan Weil
Am 18.09.2012 22:52, schrieb Stefan Weil: The operations for INDEX_op_deposit_i32 and INDEX_op_deposit_i64 are now supported and enabled by default. Signed-off-by: Stefan Weils...@weilnetz.de --- The interpreter code for INDEX_op_deposit_i64 was buggy in v1 of this patch. There is also an

Re: [Qemu-devel] [PATCH 3/5] exec: Do not use absolute address hints for code_gen_buffer with -fpie

2012-11-18 Thread Stefan Weil
Am 16.10.2012 09:30, schrieb Richard Henderson: The hard-coded addresses inside alloc_code_gen_buffer only make sense if we're building an executable that will actually run at the address we've put into the linker scripts. When we're building with -fpie, the executable will run at some random

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Blue Swirl
Thanks, applied. On Fri, Nov 16, 2012 at 5:35 PM, Paolo Bonzini pbonz...@redhat.com wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This patch uses a surprisingly low-tech

Re: [Qemu-devel] [PATCH] tci: fix build breakage for target MIPS

2012-11-18 Thread Blue Swirl
Thanks, applied. On Sun, Nov 18, 2012 at 7:06 PM, Stefan Weil s...@weilnetz.de wrote: commit 5f7319cd introduced GETPC() usage for MIPS, which is currently not defined when building with --enable-tcg-interpreter. Add MIPS to the list of targets we selectively define GETPC() for.

Re: [Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize)

2012-11-18 Thread Blue Swirl
Thanks, applied. On Sun, Nov 18, 2012 at 7:16 PM, Stefan Weil s...@weilnetz.de wrote: Commit 32761257c0b9fa7ee04d2871a6e48a41f119c469 enabled qemu_ld/st optimization unconditionally for some hosts. The TCG interpreter still does not support this kind of optimization. Therefore builds with

Re: [Qemu-devel] [PATCH v2] tci: Support deposit operations

2012-11-18 Thread Blue Swirl
Thanks, applied. On Tue, Sep 18, 2012 at 8:52 PM, Stefan Weil s...@weilnetz.de wrote: The operations for INDEX_op_deposit_i32 and INDEX_op_deposit_i64 are now supported and enabled by default. Signed-off-by: Stefan Weil s...@weilnetz.de --- The interpreter code for INDEX_op_deposit_i64

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-18 Thread Stefan Priebe
Hi Paolo, Am 06.11.2012 23:42, schrieb Paolo Bonzini: i wantes to use scsi unmap with rbd. rbd documention says you need to set discard_granularity=512 for the device. I'm using qemu 1.2. If i set this and send an UNMAP command i get this kernel output: The discard request is failing.

[Qemu-devel] [PATCH] Makefile: Add missing dependency (fix parallel builds)

2012-11-18 Thread Stefan Weil
The executables in i386-softmmu, i386-linux-user, ... depend on the recently added libqemustub.a. Signed-off-by: Stefan Weil s...@weilnetz.de --- Makefile |2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index be52153..47482ea 100644 --- a/Makefile +++ b/Makefile @@

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-18 Thread Stefan Weil
Am 18.11.2012 22:09, schrieb Blue Swirl: Thanks, applied. On Fri, Nov 16, 2012 at 5:35 PM, Paolo Bonzinipbonz...@redhat.com wrote: Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2012-11-18 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/454 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-18 Thread Tim Hardeck
Hi Stefan, thanks for your input but how should it be implemented? I personally would like activating Websockets as a VNC option like: -vnc :0 -vnc :1,websockets I have already tested this locally and it does work but only for one protocol since QEMU does only interpret the last vnc option. So

[Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2012-11-18 Thread qemu
The Buildbot has detected a new failure on builder default_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_6_0/builds/454 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] [PATCH] arm: a9mpcore: remove un-used ptimer_iomem field

2012-11-18 Thread Peter Crosthwaite
I'm guessing this is a hangover from a previous coreification of the mptimer sub-module. This field is completely unused - removed. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/a9mpcore.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] QOMification of SCU in a9mpcore

2012-11-18 Thread Peter Crosthwaite
Hi All, Im currently doing some re-factoring in and around the A9mpcore for our work on dynamic machine model creation. Id like to change the SCU component currently implemented in a9mpcore to be its own QOM object, just like with the GIC and the mptimer. Any reasons not to? Would this change be

Re: [Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2012-11-18 Thread Stefan Weil
Am 19.11.2012 00:43, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_6_0/builds/454 Buildbot URL:

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-18 Thread Peter Lieven
Am 15.11.2012 um 16:54 schrieb Paolo Bonzini pbonz...@redhat.com: Il 15/11/2012 15:57, ronnie sahlberg ha scritto: I dont know if we should switch to use synchronous code here. It is much nicer if all code is async. bdrv_open is generally synchronous, so I think Peter's patch is ok.

Re: [Qemu-devel] [PATCH V9 5/8] libqblock build system

2012-11-18 Thread Wenchao Xia
于 2012-11-18 22:58, Paolo Bonzini 写道: Il 18/11/2012 14:06, Wenchao Xia ha scritto: 于 2012-11-16 19:08, Paolo Bonzini 写道: Il 16/11/2012 11:12, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer