于 2013-1-15 15:27, Wenchao Xia 写道:
于 2013-1-15 1:08, Luiz Capitulino 写道:
On Mon, 14 Jan 2013 15:09:37 +0800
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
Parameter *fmt was not used, so remove it.
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Wenchao Xia
At Mon, 14 Jan 2013 14:01:02 +0800,
Liu Yuan wrote:
@@ -964,7 +971,10 @@ static int coroutine_fn
add_aio_request(BDRVSheepdogState *s, AIOReq *aio_req,
memset(hdr, 0, sizeof(hdr));
-if (aiocb_type == AIOCB_READ_UDATA) {
+if (aiocb_type == AIOCB_FLUSH_CACHE) {
+
On Mon, Jan 14, 2013 at 05:31:31PM +0100, Kevin Wolf wrote:
One of the recent refactoring patches (commit f50f88b9) didn't take care
to initialise l2meta properly, so with zero-length writes, which don't
even enter the write loop, qemu just segfaulted.
Signed-off-by: Kevin Wolf
15.01.2013 00:02, Doug Goldstein wrote:
commit 72a04d0c178f01908d74539230d9de64ffc6da19
Author: Hans de Goede hdego...@redhat.com
Date: Wed Sep 12 15:08:40 2012 +0200
uhci: Don't queue up packets after one with the SPD flag set
which I wanted to queue for 1.1-stable too, initially,
From: Liu Yuan tailai...@taobao.com
This will reduce sockfds connected to the sheep server to one, which simply the
future hacks.
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Liu Yuan tailai...@taobao.com
On Fri, Jan 11, 2013 at 01:29:55PM +0100, Peter Lieven wrote:
bdrv_io_limits_enable() starts a new slice, but does not set io_base
correctly for that slice.
Here is how io_base is used:
bytes_base = bs-nr_bytes[is_write] - bs-io_base.bytes[is_write];
bytes_res = (unsigned)
Am 15.01.2013 06:39, schrieb liguang:
implictly use of dr7 bit field is a little hard
to understand, so try to define them and use the
defined name.
Signed-off-by: liguang lig.f...@cn.fujitsu.com
---
target-i386/cpu.h |6 ++
target-i386/machine.c |5 +++--
From: Liu Yuan tailai...@taobao.com
This will reduce sockfds connected to the sheep server to one, which simply the
future hacks.
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Liu Yuan tailai...@taobao.com
Hello Guang,
Are you okay with this version?
Regards,
Andreas
v5 - v6:
* Fix bisectability by deferring use of hw_{local,global}_breakpoint_enabled().
* Reword the commit messages for clarity.
* Squash more constant usage into first patch.
* Reorder DATA_RW and DATA_WR to match original switch
From: liguang lig.f...@cn.fujitsu.com
Go To Statement Considered Harmful -- E. Dijkstra
To avoid an unnecessary goto within the switch statement, move
watchpoint insertion out of the switch statement. Improves readability.
While at it, fix Coding Style issues (missing braces, indentation).
From: liguang lig.f...@cn.fujitsu.com
Replace an if statement using magic numbers for breakpoint type with a
more explicit switch statement. This is to aid readability.
Change the return type and force_dr6_update argument type to bool.
While at it, fix Coding Style issues (missing braces).
I am trying to use QEMU to print the virtual and physical addresses of all
memory accesses for target-arm. I can see the addresses being computed, but
they pass IS_USER(s) as an index to routines like gen_ld8s etc, Can you please
explain what this does?
Any help is appreciated; thanks in
From: liguang lig.f...@cn.fujitsu.com
Implicit use of dr7 bit field is a little hard to understand,
so define constants for them and use them consistently.
Signed-off-by: liguang lig.f...@cn.fujitsu.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.h |6 ++
From: liguang lig.f...@cn.fujitsu.com
hw_breakpoint_enabled() returned a bit field indicating whether a local
breakpoint and/or global breakpoint was enabled. Avoid this number magic
by using explicit boolean helper functions hw_local_breakpoint_enabled()
and hw_global_breakpoint_enabled(), to
On Mon, Jan 14, 2013 at 04:26:55PM +0100, Paolo Bonzini wrote:
+static ssize_t handle_aiocb_discard(RawPosixAIOData *aiocb)
+{
+int ret = -EOPNOTSUPP;
+BDRVRawState *s = aiocb-bs-opaque;
+
+if (s-has_discard == 0) {
+return 0;
+}
+
+if (aiocb-aio_type
From: Blue Swirl blauwir...@gmail.com
Mingw32 headers define FAR, causing this warning:
/src/qemu/hw/pc87312.c:38:0: warning: FAR redefined [enabled by default]
In file included from
/usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windows.h:48:0,
Prepare an instance_init function for the MemoryRegion init.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Tested-by: Hervé Poussineau hpous...@reactos.org
---
hw/pc87312.c | 26 ++
hw/pc87312.h |2 ++
2 Dateien geändert, 24 Zeilen hinzugefügt(+), 4 Zeilen
Hello,
Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master.
This contains a warning fix for mingw32 plus a minor I/O port cleanup.
(My pending prep_pci patch needs to be reposted first and misses the pull.)
The following changes since commit
On Tue, 15 Jan 2013 05:16:52 +0100
Andreas Färber afaer...@suse.de wrote:
Am 11.01.2013 03:10, schrieb Igor Mammedov:
Igor Mammedov (17):
target-i386: move setting defaults out of cpu_x86_parse_featurestr()
target-i386: cpu_x86_register() consolidate freeing resources
target-i386:
On Mon, Jan 14, 2013 at 04:26:51PM +0100, Paolo Bonzini wrote:
This series builds on the patch from Kusanagi Kouichi, and also adds
discard support for non-passthrough block devices (BLKDISCARD), and
asynchronous discard support.
SCSI already calls bdrv_aio_discard, so it is not affected by
Thanks for your smooth work!
fine for me.
在 2013-01-15二的 09:29 +0100,Andreas Färber写道:
Hello Guang,
Are you okay with this version?
Regards,
Andreas
v5 - v6:
* Fix bisectability by deferring use of
hw_{local,global}_breakpoint_enabled().
* Reword the commit messages for clarity.
.lo files in stubs/, util/ and libcacard/ were not cleaned.
Fix this.
Cc: Blue Swirl blauwir...@gmail.com
Reported-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
I had missed the introduction of the gcov-files-* variables.
Cc: Blue Swirl blauwir...@gmail.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Blue, can you look at introducing a common variable for the coroutine
backend? Like
coroutine-backend-y = gthread
Am 15.01.2013 09:49, schrieb li guang:
Thanks for your smooth work!
fine for me.
Thanks, applied to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
在 2013-01-15二的 09:29 +0100,Andreas Färber写道:
Hello Guang,
Are you okay with this version?
Regards,
Andreas
v5 -
The version.o file did not appear explicitly as a dependency, and
this caused clean builds to fail. Force its build by making the
Makefile depend on version.o.
(We cannot add it to libqemuutil.a, because it doesn't export any
symbol and thus would not be pulled by the linker).
Cc: Blue Swirl
Hello,
This is my current QOM CPU patch queue. Please pull.
It includes:
* topology-related field movements to CPUState,
* better support for checking and enforcing x86 CPUID features,
* more cleanups and preparations for x86 realizefn and subclasses,
* x86 DR7 breakpoint cleanups.
Regards,
From: Eduardo Habkost ehabk...@redhat.com
Instead of carrying the CPUID leaf/register and feature name array on
the model_features_t struct, move that information into
feature_word_info so it can be reused by other functions.
The goal is to eventually kill model_features_t entirely, but to do
Move the declaration to qemu/cpu.h and add documentation.
The implementation still depends on CPUArchState for CPU iteration.
Signed-off-by: Andreas Färber afaer...@suse.de
---
exec.c |6 +++---
hw/pxa2xx_gpio.c|2 +-
include/exec/cpu-all.h |1 -
From: Igor Mammedov imamm...@redhat.com
kvm_check_features_against_host() should be called when features can't
be changed, and when features are converted to properties it would be
possible to change them until realize time, so correct way is to call
kvm_check_features_against_host() in
From: liguang lig.f...@cn.fujitsu.com
Replace an if statement using magic numbers for breakpoint type with a
more explicit switch statement. This is to aid readability.
Change the return type and force_dr6_update argument type to bool.
While at it, fix Coding Style issues (missing braces).
On Fri, Jan 11, 2013 at 05:45:28PM +0200, Gleb Natapov wrote:
On Thu, Jan 10, 2013 at 11:40:07PM -0700, Matthew Ogilvie wrote:
On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote:
On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote:
On Mon, 7 Jan 2013 11:39:18
On Fri, Jan 11, 2013 at 04:51:24PM +0400, Vadim Evard wrote:
ping
Пнд 31 Дек 2012 20:30:59, Vadim Evard писал:
configure: try pkg-config for curses
Static linkikng against ncurses may require explicit -ltinfo.
In case -lcurses and -lncurses both didn't work give pkg-config a
chance.
From: liguang lig.f...@cn.fujitsu.com
Go To Statement Considered Harmful -- E. Dijkstra
To avoid an unnecessary goto within the switch statement, move
watchpoint insertion out of the switch statement. Improves readability.
While at it, fix Coding Style issues (missing braces, indentation).
On Tue, Jan 15, 2013 at 02:55:10AM +0100, Andreas Färber wrote:
A usage with a hardcoded partial path such as
object_resolve_path_component(obj, foo)
is totally valid but currently leads to a compilation error. Fix this.
Signed-off-by: Andreas Färber afaer...@suse.de
---
14.01.2013 20:04, 曾君亮 wrote:
Hi all,
I want to test usb2.0 passthrough on xen 4.2.0 and qemu 1.2.2, and now I
have done it successfully! But these days, I encountered a lot of
difficulties. I fonud that the USB2.0 device can not be formatted while it was
passthrough to a windows
On Tue, Jan 15, 2013 at 09:41:04AM +0100, Igor Mammedov wrote:
On Mon, 10 Dec 2012 23:59:31 +0100
Andreas Färber afaer...@suse.de wrote:
TODO: sort classes for -cpu ?, generalize X86CPUListState, more testing
Signed-off-by: Andreas Färber afaer...@suse.de
Cc: Eduardo Habkost
That's quite an.. interesting $Subject. Can be read in at least two ways... ;)
Sorry can't resist ;)
/mjt
Am 13.01.2013 11:47, schrieb Michael S. Tsirkin:
The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f342975:
Revert virtio-pci: replace byte swap hack (2013-01-06 18:30:17 +)
are available in the git repository at:
From: Eduardo Habkost ehabk...@redhat.com
This adds the following feature words to the list of flags to be checked
by kvm_check_features_against_host():
- cpuid_7_0_ebx_features
- ext4_features
- kvm_features
- svm_features
This will ensure the enforce flag works as it should: it won't
On 01/15/2013 03:44 AM, Anthony Liguori wrote:
Jason Wang jasow...@redhat.com writes:
Hello all:
This seires is an update of last version of multiqueue virtio-net support.
Recently, linux tap gets multiqueue support. This series implements basic
support for multiqueue tap, nic and vhost.
From: Eduardo Habkost ehabk...@redhat.com
Any KVM-specific code that use these constants must check if
kvm_enabled() is true before using them.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Gleb Natapov g...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
From: Igor Mammedov imamm...@redhat.com
Freeing resources in one place would require setting 'error'
to not NULL, so add some more error reporting before jumping to
exit branch.
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
Signed-off-by:
On Tue, Jan 15, 2013 at 04:28:55PM +0800, Liu Yuan wrote:
From: Liu Yuan tailai...@taobao.com
This will reduce sockfds connected to the sheep server to one, which simply
the
future hacks.
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan
On Tue, Jan 15, 2013 at 09:49:37AM +0100, Paolo Bonzini wrote:
.lo files in stubs/, util/ and libcacard/ were not cleaned.
Fix this.
Cc: Blue Swirl blauwir...@gmail.com
Reported-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile | 6
于 2013-1-15 7:39, Eric Blake 写道:
On 01/14/2013 12:09 AM, Wenchao Xia wrote:
This patch move it from savevm.c to block.c and export it.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block.c | 23 +++
include/block/block.h |2 ++
When the device doesn't have an image, this returns:
{
device: ide1-cd0,
info: {
virtual-size: 0,
filename: ,
format:
}
},
But it would be better to return an empty dict or even omit
On 01/15/2013 06:20 PM, Stefan Hajnoczi wrote:
Please remember to run scripts/checkpatch.pl before posting patches. I
fixed up a tab character that snuck into this patch.
Ah, Okay, it was in a hasty.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Seems
CPUArchState is no longer needed, and it thereby no longer depends on
NEED_CPU_H.
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpus.c |2 +-
include/sysemu/kvm.h |5 +++--
kvm-all.c|3 +--
kvm-stub.c |2 +-
4 Dateien geändert, 6 Zeilen
On Mon, Jan 14, 2013 at 02:26:12PM +0100, Juan Quintela wrote:
Hi
Please send in any agenda topics that you have.
- CPU hotplug plan/design
--
Eduardo
From: Eduardo Habkost ehabk...@redhat.com
This introduces a FeatureWord enum, FeatureWordInfo struct (with
generation information about a feature word), and a FeatureWordArray
typedef, and changes add_flagname_to_bitmaps() code and
cpu_x86_parse_featurestr() to use the new typedefs instead of
Use the global first_cpu variable to halt the CPU rather than using a
local first_cpu initialized from qemu_get_cpu(0).
This will allow to change qemu_get_cpu() return type to CPUState
despite use of the CPU_COMMON halted field in the reset handler.
Signed-off-by: Andreas Färber afaer...@suse.de
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpus.c |4 +++-
exec.c |4 +---
hw/spapr.c |4 +++-
include/exec/cpu-defs.h |1 -
include/qom/cpu.h |2 ++
monitor.c |4 +++-
6 Dateien geändert, 12 Zeilen
From: liguang lig.f...@cn.fujitsu.com
hw_breakpoint_enabled() returned a bit field indicating whether a local
breakpoint and/or global breakpoint was enabled. Avoid this number magic
by using explicit boolean helper functions hw_local_breakpoint_enabled()
and hw_global_breakpoint_enabled(), to
From: liguang lig.f...@cn.fujitsu.com
Implicit use of dr7 bit field is a little hard to understand,
so define constants for them and use them consistently.
Signed-off-by: liguang lig.f...@cn.fujitsu.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.h |6 ++
From: Igor Mammedov imamm...@redhat.com
No functional change, needed for simplifying conversion to properties.
Signed-off-by: Igor Mammedov imamm...@redhat.com
Reviewed-by: Eduardo Habkost ehabk...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.c |9 -
On Mon, Jan 14, 2013 at 10:52:52PM +0100, Igor Mammedov wrote:
[...]
@@ -987,9 +937,7 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def)
x86_cpu_def-vendor_override = 0;
/* Call Centaur's CPUID instruction. */
-if (x86_cpu_def-vendor1 == CPUID_VENDOR_VIA_1
From: Eduardo Habkost ehabk...@redhat.com
Feature names were taken from the X86_FEATURE_* constants in the Linux
kernel code.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
Reviewed-by: Gleb Natapov g...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
target-i386/cpu.c | 17
To facilitate the field movements, pass MIPSCPU to malta_mips_config();
avoid that for mips_cpu_map_tc() since callers only access MIPS Thread
Contexts, inside TCG helpers.
Signed-off-by: Andreas Färber afaer...@suse.de
---
cpus.c |4 ++--
hw/mips_malta.c |9
This function will be touched again soon, so a good understanding of env
vs. other helps. Adopt gtk-doc style.
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Eric Johnson er...@mips.com
---
target-mips/op_helper.c | 14 +-
1 Datei geändert, 9 Zeilen hinzugefügt(+), 5
Note that target-alpha accesses this field from TCG, now using a
negative offset. Therefore the field is placed last in CPUState.
Pass PowerPCCPU to [kvm]ppc_fixup_cpu() to facilitate this change.
Move common parts of mips cpu_state_reset() to mips_cpu_reset().
Acked-by: Richard Henderson
From: Eduardo Habkost ehabk...@redhat.com
KVM_CAP_PV_MMU capability reporting was removed from the kernel since
v2.6.33 (see commit a68a6a7282373), and was completely removed from the
kernel since v3.3 (see commit fb92045843). It doesn't make sense to keep
it enabled by default, as it would cause
On Tue, 15 Jan 2013, Andreas Färber wrote:
Use the global first_cpu variable to halt the CPU rather than using a
local first_cpu initialized from qemu_get_cpu(0).
This will allow to change qemu_get_cpu() return type to CPUState
despite use of the CPU_COMMON halted field in the reset handler.
On Tue, 15 Jan 2013 10:36:22 +0800
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
On Mon, 2013-01-14 at 15:09 +0800, Wenchao Xia wrote:
This patch use block layer API to qmp snapshot info on a block
device, then use the same code dumping vm snapshot info, to print
in monitor.
Am 07.01.2013 06:26, schrieb Dong Xu Wang:
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print will be used while using qemu-img create, it will
produce the same output as previous code.
The behavior of this function has changed:
1. Print every possible
On 15.01.2013, at 12:05, Suzuki K. Poulose wrote:
Hi
I have been trying to setup a qemu session for qemu-system-s390x (on
x86_64) using a kernel (with initramfs built-in the kernel) without a
disk image. The kernel was built with s390 defconfig + disabled loadable
modules (just to keep
On Tue, 15 Jan 2013 15:58:34 +0800
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
于 2013-1-15 15:27, Wenchao Xia 写道:
于 2013-1-15 1:08, Luiz Capitulino 写道:
On Mon, 14 Jan 2013 15:09:37 +0800
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
Parameter *fmt was not used, so remove it.
Hi
This is the intersect of the paolo me patches for migration thread,
please consided for inclusion.
The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)
are available in the git repository at:
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
arch_init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index 86f8544..8c833b6 100644
---
From: Paolo Bonzini pbonz...@redhat.com
Previous patch missed this case
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index
Now that we have error handling we can do proper handling of
buffered_flush().
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 7ae1d93..17eb27d 100644
--- a/migration.c
+++
This will allow us finer control in next patches.
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 95 ++---
1 file changed, 41 insertions(+), 54 deletions(-)
diff --git a/migration.c b/migration.c
index 651edd5..6d3aeed
This is consistent once that we have moved everything to migration.c
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/migration.c b/migration.c
index 77c1971..ac67525
On 15.01.2013, at 12:39, Suzuki K. Poulose wrote:
On 01/15/2013 04:39 PM, Alexander Graf wrote:
On 15.01.2013, at 12:05, Suzuki K. Poulose wrote:
Hi
I have been trying to setup a qemu session for qemu-system-s390x (on
x86_64) using a kernel (with initramfs built-in the kernel) without
From: Paolo Bonzini pbonz...@redhat.com
The call in buffered_close is enough, because buffered_close is called
already by migrate_fd_cleanup.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 1 -
1 file changed, 1 deletion(-)
Signed-off-by: Juan Quintela quint...@redhat.com
---
savevm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/savevm.c b/savevm.c
index 4e970ca..611e997 100644
--- a/savevm.c
+++ b/savevm.c
@@ -419,7 +419,9 @@ int qemu_file_get_error(QEMUFile *f)
static void
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
arch_init.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 8c833b6..dada6de 100644
---
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 5513dde..380f3cb 100644
--- a/migration.c
Signed-off-by: Orit Wasserman owass...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 6d3aeed..fe1a103 100644
--- a/migration.c
+++ b/migration.c
@@ -698,7 +698,7 @@
Tested on x86 host yet, I don't have bigendian host avilable right now.
Vendor property setter takes string as vendor value but cpudefs
use uint32_t vendor[123] fields to define vendor value. It makes it
difficult to unify and use property setter for values from cpudefs.
Simplify code by using
Signed-off-by: Juan Quintela quint...@redhat.com
---
migration.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 17eb27d..651edd5 100644
--- a/migration.c
+++ b/migration.c
@@ -669,12 +669,6 @@ static bool
Static linkikng against ncurses may require explicit -ltinfo.
In case -lcurses and -lncurses both didn't work give pkg-config a
chance.
Fixes #1094786 for me.
Signed-off-by: Vadim Evard v.e.ev...@gmail.com
---
configure |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Juan Quintela quint...@redhat.com
---
include/sysemu/sysemu.h | 2 +-
migration.c | 2 +-
savevm.c| 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index c07d4ee..d65a9f1 100644
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Juan Quintela quint...@redhat.com
---
include/migration/migration.h | 2 --
migration.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Juan Quintela quint...@redhat.com
---
include/migration/migration.h | 1 -
migration.c | 28 +++-
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/migration/migration.h b/include/migration/migration.h
index
Am 07.01.2013 06:26, schrieb Dong Xu Wang:
This patch will use QemuOpts related functions in block layer, add
a member bdrv_create_options to BlockDriver struct, it will return
a QemuOptsList pointer, which includes the image format's create
options.
And create options's primary consumer is
On Tue, Jan 15, 2013 at 06:28:24PM +0800, Liu Yuan wrote:
On 01/15/2013 06:20 PM, Stefan Hajnoczi wrote:
Please remember to run scripts/checkpatch.pl before posting patches. I
fixed up a tab character that snuck into this patch.
Ah, Okay, it was in a hasty.
Thanks, applied to my
Eric Blake ebl...@redhat.com writes:
On 01/14/2013 12:09 AM, Wenchao Xia wrote:
This patch move it from savevm.c to block.c and export it.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block.c | 23 +++
include/block/block.h |2 ++
Am 11.01.2013 19:11, schrieb Paolo Bonzini:
Brad and Peter,
as far as I know OpenBSD and Linux/ARM were the main users of
coroutine-gthread. Do you think we could dump it and rely on
coroutine-sigaltstack only? The differences in signal handling of the
gthread implementation always
Il 15/01/2013 14:18, Kevin Wolf ha scritto:
Brad and Peter,
as far as I know OpenBSD and Linux/ARM were the main users of
coroutine-gthread. Do you think we could dump it and rely on
coroutine-sigaltstack only? The differences in signal handling of the
gthread implementation always
On Sun, Dec 23, 2012 at 10:31:38PM +0200, Alon Levy wrote:
On Thu, Dec 13, 2012 at 01:05:48PM +0100, Gerd Hoffmann wrote:
On 12/13/12 12:36, Alon Levy wrote:
This is a simpler solution to 869981, where migration breaks since qxl's
rom bar size has changed. Instead of ignoring fields in
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/scsi-disk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index f8d7ef3..96db9a7 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -85,9 +85,7 @@ static void
Markus Armbruster (4):
w32: Make qemu_vfree() accept NULL like the POSIX implementation
scsi-disk: qemu_vfree(NULL) is fine, simplify
win32-aio: Fix how win32_aio_process_completion() frees buffer
block: Fix how mirror_run() frees its buffer
block/mirror.c | 2 +-
block/win32-aio.c
Am 15.01.2013 14:28, schrieb Paolo Bonzini:
Il 15/01/2013 14:18, Kevin Wolf ha scritto:
Brad and Peter,
as far as I know OpenBSD and Linux/ARM were the main users of
coroutine-gthread. Do you think we could dump it and rely on
coroutine-sigaltstack only? The differences in signal handling
On 01/15/2013 01:01 PM, Markus Armbruster wrote:
Eric Blake ebl...@redhat.com writes:
On 01/14/2013 12:09 AM, Wenchao Xia wrote:
This patch move it from savevm.c to block.c and export it.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
block.c | 23
Am 15.01.2013 14:23, schrieb Markus Armbruster:
win32_aio_submit() allocates it with qemu_blockalign(), therefore it
must be freed with qemu_vfree(), not g_free().
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/win32-aio.c | 2 +-
1 file changed, 1 insertion(+), 1
Am 15.01.2013 14:23, schrieb Markus Armbruster:
It allocates with qemu_blockalign(), therefore it must free with
qemu_vfree(), not g_free().
Since I'm touching it anyway, move the free to a more obviosly correct
place.
...except that it's now leaked for all error cases but the first.
Kevin
Am 15.01.2013 14:23, schrieb Markus Armbruster:
Markus Armbruster (4):
w32: Make qemu_vfree() accept NULL like the POSIX implementation
scsi-disk: qemu_vfree(NULL) is fine, simplify
win32-aio: Fix how win32_aio_process_completion() frees buffer
block: Fix how mirror_run() frees its
It allocates with qemu_blockalign(), therefore it must free with
qemu_vfree(), not g_free().
Since I'm touching it anyway, move the free to a more obviosly correct
place.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
win32_aio_submit() allocates it with qemu_blockalign(), therefore it
must be freed with qemu_vfree(), not g_free().
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/win32-aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/win32-aio.c b/block/win32-aio.c
On POSIX, qemu_vfree() accepts NULL, because it's merely wrapper
around free(). As far as I can tell, the Windows implementation
doesn't. Breeds bugs that bite only under Windows.
Make the Windows implementation behave like the POSIX implementation.
Signed-off-by: Markus Armbruster
1 - 100 of 302 matches
Mail list logo