Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-18 Thread li guang
在 2013-01-17四的 16:16 +0100,Igor Mammedov写道: diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ce914da..ab80dbe 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -45,6 +45,18 @@ #include hw/apic_internal.h #endif +static void x86_cpu_vendor_words2str(char *dst,

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-18 Thread Paolo Bonzini
Il 17/01/2013 22:18, Blue Swirl ha scritto: On Thu, Jan 17, 2013 at 8:54 PM, Stefan Weil s...@weilnetz.de wrote: Am 17.01.2013 21:45, schrieb Blue Swirl: On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weils...@weilnetz.de wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h.

Re: [Qemu-devel] [PATCH 16/18] hw: add QEMU model for Faraday RTC timer

2013-01-18 Thread KONRAD Frédéric
On 18/01/2013 07:32, Dante wrote: Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com --- hw/ftrtc011.c | 308 + 1 file changed, 308 insertions(+) create mode 100644 hw/ftrtc011.c diff --git a/hw/ftrtc011.c b/hw/ftrtc011.c new file

Re: [Qemu-devel] [PATCH] tests: adjust gcov variables for directory movement

2013-01-18 Thread Paolo Bonzini
Il 17/01/2013 21:43, Blue Swirl ha scritto: Blue, can you look at introducing a common variable for the coroutine backend? Like coroutine-backend-y = gthread coroutine-backend-$(CONFIG_SIGALTSTACK_COROUTINE) = sigaltstack

Re: [Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-18 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil s...@weilnetz.de --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +-

Re: [Qemu-devel] [PATCH] target-arm: add Faraday ARMv5TE processors support

2013-01-18 Thread Paul Brook
* ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE) All the single core RISC listed above are included in this patch. And there are two Faraday CP15 extensions (AUX and I/D-Scratchpad) have been implemented as NOP. Is a NOP appropriate? Should you at least read the value

[Qemu-devel] [PATCH v9 2/4] use uimage_reset to reload uImage

2013-01-18 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 57 + hw/loader.h |6 ++ 2 files changed, 51 insertions(+), 12 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index 4fa9965..89ce853 100644 ---

[Qemu-devel] [PATCH v9 4/4] use info images to check images which could be reloaded on reset

2013-01-18 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c| 43 +-- hw/loader.h| 20 hw/ppc/e500.c |2 +- hw/ppc440_bamboo.c |2 +- monitor.c |7 +++ 5 files changed, 62

Re: [Qemu-devel] [PATCH v4 0/3] AHCI migration

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 11:01:52AM +0100, Kevin Wolf wrote: Let's get Jason's patches merged while they still apply. I addressed the review comments (mostly my own) that came up during the v3 review, otherwise this is unchanged. Please note that in my tests it didn't work entirely reliably

Re: [Qemu-devel] [PATCH v3] win32-aio: use iov utility functions instead of open-coding them

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 06:47:52PM +0400, Michael Tokarev wrote: We have iov_from_buf() and iov_to_buf(), use them instead of open-coding these in block/win32-aio.c --- v3: added the forgotten #include (compile-tested on mingw32) v2: rebase on top of the fix from bonzini@

Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead of open-coding them

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 05:51:05PM +0400, Michael Tokarev wrote: 17.01.2013 17:06, Stefan Hajnoczi wrote: On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote: We have iov_from_buf() and iov_to_buf(), use them instead of open-coding these in block/win32-aio.c Please use

[Qemu-devel] [PATCH v9 3/4] use elf_reset to reload elf image

2013-01-18 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/elf_ops.h | 45 - hw/loader.c | 11 +++ hw/loader.h |9 + 3 files changed, 60 insertions(+), 5 deletions(-) diff --git a/hw/elf_ops.h b/hw/elf_ops.h index

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-18 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values:

Re: [Qemu-devel] [PATCH 16/18] hw: add QEMU model for Faraday RTC timer

2013-01-18 Thread Andreas Färber
Kuo-Jung, please thread your messages together (e.g., using git-send-email) and prepend a cover letter, right now this is a badly reviewable mess of individual patches on the list. Am 18.01.2013 09:44, schrieb KONRAD Frédéric: On 18/01/2013 07:32, Dante wrote: Signed-off-by: Kuo-Jung Su

[Qemu-devel] [PATCH v9 0/4] reload images from host rootfs on reset to save footprint

2013-01-18 Thread Olivia Yin
The current model of loader copy rom blobs and kept in memory until a reset occurs and waste host memory. This serial of patches set uimage/initrd/vmlinux as reloadable images and use private reset handlers to load these images from hard disk on reset, which could make loader framework more

Re: [Qemu-devel] [PATCH 06/18] hw: add QEMU model for Faraday I2C master controller

2013-01-18 Thread Andreas Färber
Am 18.01.2013 07:30, schrieb Dante: Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com These patches are all for QEMU so please generally drop QEMU model for from the subject for readability. --- hw/fti2c010.c | 209 +

[Qemu-devel] [PATCH v9 1/4] use image_file_reset to reload initrd

2013-01-18 Thread Olivia Yin
Signed-off-by: Olivia Yin hong-hua@freescale.com --- hw/loader.c | 25 + hw/loader.h |6 ++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index ba01ca6..4fa9965 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -86,6

Re: [Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-18 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared

Re: [Qemu-devel] [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 06:40:12PM +0800, ak...@redhat.com wrote: diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 395ab4f..837c978 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -802,14 +802,32 @@ static int virtnet_set_mac_address(struct

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 08:13:38PM +, Blue Swirl wrote: On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, Jan 12, 2013 at 10:46:18AM +, Blue Swirl wrote: On Thu, Jan 10, 2013 at 12:43 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jan 09,

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: This will allow each architecture to define how the VCPU ID is set on the KVM_CREATE_VCPU ioctl call. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin m...@redhat.com Cc: Gleb Natapov

Re: [Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-18 Thread Gleb Natapov
On Fri, Jan 18, 2013 at 11:58:34AM +0100, Andreas Färber wrote: Am 17.01.2013 21:59, schrieb Eduardo Habkost: This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this

Re: [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-18 Thread Andreas Färber
Am 17.01.2013 21:59, schrieb Eduardo Habkost: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin m...@redhat.com Cc: Gleb Natapov g...@redhat.com Cc: Marcelo Tosatti mtosa...@redhat.com It appears as if Cc: below --- gets ignored? Please

Re: [Qemu-devel] [PATCH v4 0/3] AHCI migration

2013-01-18 Thread Juan Quintela
Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, Jan 17, 2013 at 11:01:52AM +0100, Kevin Wolf wrote: Let's get Jason's patches merged while they still apply. I addressed the review comments (mostly my own) that came up during the v3 review, otherwise this is unchanged. Please note that

Re: [Qemu-devel] [PATCH v4 2/3] ahci: Change data types in preparation for migration

2013-01-18 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: The size of an int depends on the host, so in order to be able to migrate these fields, make them either int32_t or bool, depending on the use. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

Re: [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: Am 17.01.2013 21:59, schrieb Eduardo Habkost: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin m...@redhat.com Cc: Gleb Natapov g...@redhat.com Cc: Marcelo Tosatti

Re: [Qemu-devel] [PATCH v4 3/3] ahci: Add migration support

2013-01-18 Thread Juan Quintela
Kevin Wolf kw...@redhat.com wrote: From: Jason Baron jba...@redhat.com Jason tested these patches by migrating Windows 7 and Fedora 17 guests (while under I/O) on both piix with ahci attached and on q35 (which has a built-in AHCI controller). Signed-off-by: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-18 Thread Gleb Natapov
On Fri, Jan 18, 2013 at 09:36:33AM -0200, Eduardo Habkost wrote: On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: Am 17.01.2013 21:59, schrieb Eduardo Habkost: Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin

[Qemu-devel] [PATCH 3/4] ram: reuse ram_save_iterate() for the complete stage

2013-01-18 Thread Juan Quintela
This means that we only have one memory loop for the iterate and complete phase. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 16 migration.c | 12 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/arch_init.c b/arch_init.c index

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 08:22:40PM +, Blue Swirl wrote: On Mon, Jan 14, 2013 at 9:13 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, Jan 12, 2013 at 12:00:45PM +, Blue Swirl wrote: On Fri, Jan 11, 2013 at 7:27 AM, 马磊 aware@gmail.com wrote: On Fri, Jan 11, 2013 at

[Qemu-devel] [PATCH 2/4] ram: remove xbrle last_stage optimization

2013-01-18 Thread Juan Quintela
We need to remove it to be able to return from complete to iterative phases of migration. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/arch_init.c b/arch_init.c index

Re: [Qemu-devel] [[PATCH v2]] Add option to slow qemu down

2013-01-18 Thread Wolfgang Mauerer
Hello Stefan, On 17/01/13 21:21, Stefan Weil wrote: Please test your patch using scripts/checkpatch.pl before sending it. embarrassingly, I did not do that, true. Stylistically correct version follows. Best regards, Wolfgang

[Qemu-devel] [PATCH] Add option to slow qemu down

2013-01-18 Thread Wolfgang Mauerer
For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU emulation. Signed-off-by: Wolfgang Mauerer wolfgang.maue...@siemens.com --- cpus.c

[Qemu-devel] VMSTate state of the union

2013-01-18 Thread Juan Quintela
Hi Executive summary: Nothing changed since last time Abstract: Things missing: - cpus: They are blocked by comment that we should be able to sent generated fields. Stalled :-( - slirp: I have preleminary patches for it. Stalled on how to describe LISTS. - virtio: Stalled

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2013-01-18 Thread Luke Kim
I have tested cmake.patch but it doesn't work for me. It didn't hang but it failed to run gmake. I applied this patch onto qemu-1.3. [ 52s] -- Detecting CXX compiler ABI info [ 53s] CMake Error: Generator: execution of make failed. Make command was: /usr/bin/gmake cmTryCompileExec/fast [

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-18 Thread Marcelo Tosatti
On Wed, Jan 16, 2013 at 06:17:03PM -0500, Cole Robinson wrote: On 01/15/2013 11:29 AM, Paolo Bonzini wrote: Il 15/01/2013 04:45, Cole Robinson ha scritto: Libvirt always specifies an explicit machine type and carries it for the life of the VM. What we want is for 'qemu-kvm-1.2 -M pc-1.2'

[Qemu-devel] [PATCH 1/4] ram: add free_space parameter to save_live functions

2013-01-18 Thread Juan Quintela
As we really know how much space we have free in the buffers, we can send that information instead of guessing how much we can sent each time. Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 20 +--- block-migration.c | 2 +-

[Qemu-devel] [PATCH 4/4] migration: print times for end phase

2013-01-18 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- block.c | 6 ++ cpus.c | 17 + migration.c | 13 + savevm.c| 13 + 4 files changed, 49 insertions(+) diff --git a/block.c b/block.c index 6fa7c90..c121db3 100644 --- a/block.c +++

[Qemu-devel] [RFC 0/4] migration.experimental queue

2013-01-18 Thread Juan Quintela
Hi This is the other half of the series for the people that want to test the migration latency improvements. They are on top of the pull request submmited yesterday. Last patch as usual is to print where the time is spent in the completation stage, will be removed on proper submission.= Paolo

Re: [Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 01:48:38PM +0200, Gleb Natapov wrote: On Fri, Jan 18, 2013 at 09:36:33AM -0200, Eduardo Habkost wrote: On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: Am 17.01.2013 21:59, schrieb Eduardo Habkost: Signed-off-by: Eduardo Habkost ehabk...@redhat.com

Re: [Qemu-devel] VMSTate state of the union

2013-01-18 Thread Andreas Färber
Hi Juan, Am 18.01.2013 13:13, schrieb Juan Quintela: Things missing: - cpus: They are blocked by comment that we should be able to sent generated fields. Stalled :-( I'm not sure what you mean here, but I have an old CPU series of yours on my radar that I am about to partially

Re: [Qemu-devel] VMSTate state of the union

2013-01-18 Thread Peter Maydell
On 18 January 2013 12:13, Juan Quintela quint...@redhat.com wrote: - virtio: Stalled for even longer. Suspect are LISTS again. My pet hate with virtio state save/restore is that the transport information isn't versioned separately from the backend info. Any chance we could split things up

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 12:11:29PM +0100, Andreas Färber wrote: [...] +/* Returns VCPU ID to be used on KVM_CREATE_VCPU ioctl() */ +unsigned long kvm_arch_vcpu_id(CPUState *cpu); + void kvm_arch_reset_vcpu(CPUState *cpu); int kvm_arch_on_sigbus_vcpu(CPUState *cpu, int code, void

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Andreas Färber
Am 18.01.2013 13:53, schrieb Eduardo Habkost: On Fri, Jan 18, 2013 at 12:11:29PM +0100, Andreas Färber wrote: [...] +/* Returns VCPU ID to be used on KVM_CREATE_VCPU ioctl() */ +unsigned long kvm_arch_vcpu_id(CPUState *cpu); + void kvm_arch_reset_vcpu(CPUState *cpu); int

Re: [Qemu-devel] [PATCH v2 02/12] add hierarchical bitmap data type and test cases

2013-01-18 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: HBitmaps provides an array of bits. The bits are stored as usual in an array of unsigned longs, but HBitmap is also optimized to provide fast iteration over set bits; going from one bit to the next is O(logB n) worst case, with B = sizeof(long) *

Re: [Qemu-devel] Fwd: [Users] oVirt Node (HyperVisor) - Memory Usage

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 10:10:48AM +, Alex Leonhardt wrote: I dont have the original VM running anymore - but here is another one, with full command line : qemu 23663 6.2 0.6 *4131312* 641092 ? Sl Jan16 109:49 /usr/libexec/qemu-kvm -S -M rhel6.3.0 -cpu Conroe -enable-kvm -m

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 11:01:14AM +0100, Markus Armbruster wrote: Eduardo Habkost ehabk...@redhat.com writes: There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing

Re: [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 12:48:51PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 17, 2013 at 11:28:46AM +0100, Stefan Hajnoczi wrote: On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote: Using a global pattern makes it easier to clean out old generated files.

Re: [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 12:50:18PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 17, 2013 at 11:33:03AM +0100, Stefan Hajnoczi wrote: On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote: libcacard lacks a clean target. Need to fix it, meanwhile mark this target phony so it

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-18 Thread Andreas Färber
Am 18.01.2013 14:26, schrieb Eduardo Habkost: On Fri, Jan 18, 2013 at 11:01:14AM +0100, Markus Armbruster wrote: Your list of error checks isn't quite complete. Here's my try: Even better would be: /** * parse_uint: * @s: String to parse * @value: Destination for parsed integer

Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-18 Thread Igor Mammedov
On Fri, 18 Jan 2013 15:12:36 +0800 li guang lig.f...@cn.fujitsu.com wrote: 在 2013-01-17四的 16:16 +0100,Igor Mammedov写道: diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ce914da..ab80dbe 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -45,6 +45,18 @@ #include

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Spelling fix in log message

2013-01-18 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 06:40:29PM +0100, Stefan Weil wrote: defineition - definition Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/openrisc_sim.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 02:53:52PM +0400, Michael Tokarev wrote: -acpitable {file|data}=file reads the content of file, but it is in binary form, so the file should be opened usin O_BINARY flag. On *nix it is a no-op, but on windows and other weird platform it is really needed.

Re: [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 03:52:08PM +, Peter Maydell wrote: Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to

[Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-18 Thread Vadim Evard
Signed-off-by: Vadim Evard v.e.ev...@gmail.com --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4ebb60d..6211db9 100755 --- a/configure +++ b/configure @@ -2039,7 +2039,7 @@ fi if test $mingw32 = yes ; then

Re: [Qemu-devel] Fwd: [Users] oVirt Node (HyperVisor) - Memory Usage

2013-01-18 Thread Anthony Liguori
Stefan Hajnoczi stefa...@gmail.com writes: On Thu, Jan 17, 2013 at 10:10:48AM +, Alex Leonhardt wrote: I dont have the original VM running anymore - but here is another one, with full command line : qemu 23663 6.2 0.6 *4131312* 641092 ? Sl Jan16 109:49

Re: [Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-18 Thread Peter Maydell
On 18 January 2013 13:47, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 17, 2013 at 03:52:08PM +, Peter Maydell wrote: Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-18 Thread Stefan Hajnoczi
On Fri, Jan 18, 2013 at 05:48:04PM +0400, Vadim Evard wrote: Signed-off-by: Vadim Evard v.e.ev...@gmail.com --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

[Qemu-devel] [Bug 1091115] Re: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys

2013-01-18 Thread Eduard DRUSA
Alternative BIOS works for me with both installed system and installer. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1091115 Title: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 02:03:09PM +0100, Andreas Färber wrote: Am 18.01.2013 13:53, schrieb Eduardo Habkost: On Fri, Jan 18, 2013 at 12:11:29PM +0100, Andreas Färber wrote: [...] +/* Returns VCPU ID to be used on KVM_CREATE_VCPU ioctl() */ +unsigned long kvm_arch_vcpu_id(CPUState *cpu);

Re: [Qemu-devel] [PATCH] block: do_commit() does not pass along error messages for all errors

2013-01-18 Thread Jeff Cody
On Thu, Jan 17, 2013 at 09:57:28AM -0200, Luiz Capitulino wrote: On Thu, 17 Jan 2013 08:49:38 +0100 Markus Armbruster arm...@redhat.com wrote: [Cc: Luiz for error stuff] Jeff Cody jc...@redhat.com writes: The non-live bdrv_commit() function may return one of the following

[Qemu-devel] [PATCH v2] block: do_commit() does not pass along error messages for all errors

2013-01-18 Thread Jeff Cody
The non-live bdrv_commit() function may return one of the following errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is checked in the HMP handler is -EBUSY, so the monitor command 'commit' silently fails for all error cases other than 'Device is in use'. Return error using

Re: [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-18 Thread Igor Mammedov
On Thu, 17 Jan 2013 15:44:45 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Thu, Jan 17, 2013 at 04:16:33PM +0100, Igor Mammedov wrote: Move custom features parsing after built-in cpu_model defaults are set and set custom features directly on CPU instance. That allows to make clear

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-18 Thread Kevin Wolf
Am 16.01.2013 18:31, schrieb Paolo Bonzini: When mirroring runs, the backing files for the target may not yet be ready. However, this means that a copy-on-write operation on the target would fill the missing sectors with zeros. Copy-on-write only happens if the granularity of the dirty

Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-18 Thread Benoît Canet
Hmm, adler32() is basically a weak hashing mechanism; are you sure you won't have any false collisions? Furthermore, how does this compare with the series for adding deduplication, which uses much stronger/longer hashes, but where those take more time to compute? Is there any way you can

Re: [Qemu-devel] Go along with glib's basic type typedef silliness?

2013-01-18 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Mon, Jan 14, 2013 at 7:01 PM, Markus Armbruster arm...@redhat.com wrote: [Thread hijack, dropping cc: qemu-trivial, qemu-ppc] Andreas Färber afaer...@suse.de writes: Am 14.01.2013 13:19, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de

[Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
Hi List, Recently I found bdrv_co_flush_to_disk() doesn't work as expected. As it is advertised /* * Flushes all data that was already written to the OS all the way down to * the disk (for example raw-posix calls fsync()). */ int coroutine_fn

Re: [Qemu-devel] [PATCH V3 41/44] virtio-9p: add the virtio-9p device.

2013-01-18 Thread Deepak C Shetty
On 01/15/2013 07:39 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com Create virtio-9p which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com Tested-by: Deepak C Shetty

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Stefan Hajnoczi
On Fri, Jan 18, 2013 at 4:43 PM, Liu Yuan namei.u...@gmail.com wrote: Recently I found bdrv_co_flush_to_disk() doesn't work as expected. As it is advertised /* * Flushes all data that was already written to the OS all the way down to * the disk (for example raw-posix calls

[Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD

2013-01-18 Thread Andreas Färber
Avoid an undefined reference to sem_timedwait. Signed-off-by: Andreas Färber andreas.faer...@web.de --- include/qemu/thread-posix.h |2 +- util/qemu-thread-posix.c| 10 +- 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git

Re: [Qemu-devel] [PATCH] dataplane: avoid reentrancy during virtio_blk_data_plane_stop()

2013-01-18 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 05:19:38PM +0100, Stefan Hajnoczi wrote: When dataplane is stopping, the s-vdev-binding-set_host_notifier(..., false) call can invoke the virtqueue handler if an ioeventfd notification is pending. This causes hw/virtio-blk.c to invoke virtio_blk_data_plane_start()

Re: [Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 16:58, Andreas Färber ha scritto: Avoid an undefined reference to sem_timedwait. Signed-off-by: Andreas Färber andreas.faer...@web.de --- include/qemu/thread-posix.h |2 +- util/qemu-thread-posix.c| 10 +- 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 6

Re: [Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD

2013-01-18 Thread Andreas Färber
Am 18.01.2013 17:05, schrieb Paolo Bonzini: Il 18/01/2013 16:58, Andreas Färber ha scritto: Avoid an undefined reference to sem_timedwait. Signed-off-by: Andreas Färber andreas.faer...@web.de --- include/qemu/thread-posix.h |2 +- util/qemu-thread-posix.c| 10 +- 2

[Qemu-devel] [PATCH V20 2/8] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-01-18 Thread Stefan Berger
This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to QEMU. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support for changing of localities and all the

[Qemu-devel] [PATCH V20 1/8] Support for TPM command line options

2013-01-18 Thread Stefan Berger
This patch adds support for TPM command line options. The command line options supported here are ./qemu-... -tpmdev passthrough,path=path to TPM device,id=id -device tpm-tis,tpmdev=id and ./qemu-... -tpmdev ? where the latter works similar to -soundhw ? and shows a list of

[Qemu-devel] [PATCH V20 0/8] Qemu Trusted Platform Module (TPM) integration

2013-01-18 Thread Stefan Berger
From: root r...@k-d941f-5.watson.ibm.com The following series of patches adds TPM (Trusted Platform Module) support to Qemu. An emulator for the TIS (TPM Interface Spec) interface is added that provides the basis for accessing a 'backend' implementing the actual TPM functionality. The TIS

[Qemu-devel] [PATCH V20 4/8] Build the TPM frontend code

2013-01-18 Thread Stefan Berger
Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- Makefile.objs| 1 + configure| 11 +++ hw/Makefile.objs | 3 +++ 3 files changed, 15 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index

[Qemu-devel] [PATCH V20 7/8] Introduce --enable-tpm-passthrough configure option

2013-01-18 Thread Stefan Berger
Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 73fc146..f54d40e 100755 --- a/configure +++ b/configure @@

[Qemu-devel] [PATCH V20 5/8] Add a TPM Passthrough backend driver implementation

2013-01-18 Thread Stefan Berger
From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series QEMU Trusted Platform Module (TPM) integration and adds a new backend driver for it. This patch adds a passthrough backend driver for passing commands

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Eric Blake
On 01/18/2013 07:20 AM, Eduardo Habkost wrote: Could you suggest a text for me to add please? The argument passed to KVM_CREATE_VCPU now has 'unsigned long' type instead of 'int', as expected by the Linux ioctl() syscall. Maybe an int works on most or all architectures supporting KVM, but it

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote: How are you checking that sd_co_flush_to_disk() is called? Please post the diff. From the sheep.log, I can see Jan 19 00:09:39 [main] queue_request(355) FLUSH_VDI, 1 ... This means a flush request is sent from QEMU. I added a printf() in

Re: [Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 17:04, Luigi Rizzo ha scritto: Hi, with a bunch of e1000 improvements we are at a point where we are doing over 1Mpps (short frames) and 7-8Gbit/s (1500 byte frames) between two guests, and two things that are high in the perf top stats are phys_page_find() and related memory

Re: [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-18 Thread Eduardo Habkost
Adding kvm@vger, Gleb, Michael, Marcelo to Cc, as I forgot to disable suppress-cc when sending the patches. On Thu, Jan 17, 2013 at 06:59:26PM -0200, Eduardo Habkost wrote: I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the RFC I sent last week, though. Igor argued

Re: [Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 02:54:41PM +0800, li guang wrote: 在 2013-01-17四的 18:59 -0200,Eduardo Habkost写道: I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the RFC I sent last week, though. Igor argued that APIC ID should be set by the board and not by the CPU

Re: [Qemu-devel] [PATCH RFC for-1.4] qemu-thread-posix: Fix build for OpenBSD

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 17:07, Andreas Färber ha scritto: Am 18.01.2013 17:05, schrieb Paolo Bonzini: Il 18/01/2013 16:58, Andreas Färber ha scritto: Avoid an undefined reference to sem_timedwait. Signed-off-by: Andreas Färber andreas.faer...@web.de --- include/qemu/thread-posix.h |2 +-

Re: [Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types

2013-01-18 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: See PATCH 1/3 for rationale. Markus Armbruster (3): Purge the silly GLib Basic Types, except for gboolean Purge GLib's gboolean, it's a trap for the unwary checkpatch: Keep out the GLib silliness we just purged Changing QEMU code to work

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 16:13, Kevin Wolf ha scritto: Am 16.01.2013 18:31, schrieb Paolo Bonzini: When mirroring runs, the backing files for the target may not yet be ready. However, this means that a copy-on-write operation on the target would fill the missing sectors with zeros. Copy-on-write only

[Qemu-devel] [PATCH V20 6/8] Add support for cancelling of a TPM command

2013-01-18 Thread Stefan Berger
This patch adds support for cancelling an executing TPM command. In Linux for example a user can cancel a command through the TPM's sysfs 'cancel' entry using echo 1 /sysfs/.../cancel This patch propagates the cancellation to the host TPM's sysfs entry. It also uses the possibility to cancel

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote: How are you checking that sd_co_flush_to_disk() is called? Please post the diff. Okay, this is where I added printf(). Yuan diff --git a/block/sheepdog.c b/block/sheepdog.c index 3e49bb8..41edd46 100644 --- a/block/sheepdog.c +++

[Qemu-devel] [PULL for-1.4 0/8] Block patches

2013-01-18 Thread Stefan Hajnoczi
Bug fixes plus a cleanup from mjt which logically follows the win32-aio fixes. The following changes since commit 47f4dac3fde809e3da4e60d9eb699f1d4b378249: Merge remote-tracking branch 'kraxel/chardev.1' into staging (2013-01-16 15:20:05 -0600) are available in the git repository at:

[Qemu-devel] [PATCH 4/8] win32-aio: Fix vectored reads

2013-01-18 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Copying data in the right direction really helps a lot! Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/win32-aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 5/8] win32-aio: Fix memory leak

2013-01-18 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com The buffer is allocated for both reads and writes, and obviously it should be freed even if an error occurs. Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/win32-aio.c | 2 +- 1

[Qemu-devel] [PATCH 8/8] dataplane: support viostor virtio-pci status bit setting

2013-01-18 Thread Stefan Hajnoczi
The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is running. We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK) as an indication

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-18 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is

Re: [Qemu-devel] [PATCH] bswap: improve gluing

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 08:50, Markus Armbruster wrote: David Gibson da...@gibson.dropbear.id.au writes: On Sun, Jan 13, 2013 at 04:35:41PM +, Blue Swirl wrote: OpenBSD system compiler (gcc 4.2.1) has problems with concatenation of macro arguments in macro functions: CCaes.o In file

Re: [Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Luigi Rizzo
On Fri, Jan 18, 2013 at 05:14:02PM +0100, Paolo Bonzini wrote: ... This relies on the assumption that the ring (which is contiguous in the guest's physical address space) is also contiguous in the host's virtual address space. In principle the property could be easily verified once the

Re: [Qemu-devel] [Qemu-ppc] [RFC ppc-next v3 00/10] target-ppc: MacIO QOM'ification

2013-01-18 Thread Andreas Färber
Hi Mark, Am 14.01.2013 22:56, schrieb Mark Cave-Ayland: On 13/01/13 23:54, Andreas Färber wrote: ESCC would affect sparc as well. I'll be very interested to test anything that involves converting the SPARC devices to QOM/qdev, as it's been on my TODO list for quite a while to see if it is

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Eduardo Habkost
On Fri, Jan 18, 2013 at 09:11:42AM -0700, Eric Blake wrote: On 01/18/2013 07:20 AM, Eduardo Habkost wrote: Could you suggest a text for me to add please? The argument passed to KVM_CREATE_VCPU now has 'unsigned long' type instead of 'int', as expected by the Linux ioctl() syscall. Maybe

Re: [Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 17:33, Luigi Rizzo ha scritto: First, host memory mappings could change (though they rarely do on PC). The result of address_space_map is not guaranteed to be stable. To avoid problems with this, however, you could use something like hw/dataplane/hostmem.c and even avoid

Re: [Qemu-devel] [PATCH v5 00/12] s390: channel I/O support in qemu.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: Hi, here's the latest incarnation of my channel I/O and virtio-ccw patchset for qemu, containing various changes over the last one. Which tree are you working against? This set doesn't apply on s390-next. Alex (Note that s390: Add a

  1   2   >