Andreas Färber writes:
> Am 21.02.2013 09:38, schrieb Kevin Wolf:
>> On Wed, Feb 20, 2013 at 06:26:55PM +0100, Andreas Färber wrote:
>>> Am 20.02.2013 18:05, schrieb Anthony Liguori:
Andreas Färber writes:
> Am 20.02.2013 14:43, schrieb Anthony Liguori:
>> This includes a de_DE
Manual page and qemu-doc on talk about "Bochs BIOS". We use SeaBIOS,
and it implements the feature. Replace by just "BIOS", and drop the
ugly TODO line wondering about the Bochs reference.
Signed-off-by: Markus Armbruster
---
qemu-options.hx | 3 +--
1 file changed, 1 insertion(+), 2 deletions
KVM ARM support has just hit Linus' kernel tree, so we can
finally commit this series to QEMU. Since all the patches got
reviewed last time round this should be ready to commit.
I'm happy to commit via arm-devs.next unless you'd prefer
it to go via the kvm qemu tree.
NB: the linux-headers sync is
From: Christian Borntraeger
We have to consider the m bit to find the real channel subsystem when
determining the last subchannel.
If we fail to take this into account, removal of a subchannel in
the middle of a big list of devices will stop device detection after
a reboot.
Signed-off-by: Chris
From: Christian Borntraeger
blockdev_mark_auto_del is already called in virtio-blk-exit.
Remove the redundant call.
Signed-off-by: Christian Borntraeger
Signed-off-by: Jens Freimann
---
hw/s390x/virtio-ccw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/v
From: Christian Borntraeger
This patch fixes a crash when unplugging a virtio-ccw device. We no
longer need to do that in virtio-ccw since common code does now
proper handling.
Signed-off-by: Christian Borntraeger
Signed-off-by: Jens Freimann
---
hw/s390x/virtio-ccw.c | 1 -
1 file changed, 1
Alex,
The following changes since commit 1143df5c72fd1f88b4b2b0774d11bf0ba6eb44d6:
target-s390x: Pass S390CPU to s390_{add, del}_running_cpu() (2013-02-01
01:58:50 +0100)
are available in the git repository at:
git://github.com/jensfr/qemu.git for-s390-next
for you to fetch changes up to
Sorry, wrong patch. The version check should check for 2.26.0 instead of
2.24.0.
Am 22.02.2013 19:56, schrieb Stefan Weil:
> This is needed for current Debian stable (Squeeze).
>
> VTE versions before 2.26 did not support VtePty.
>
> Lower the version requirement and use alternate code which works
This is needed for current Debian stable (Squeeze).
Extract from NEWS in gtk+-2.0:
Overview of Changes from GTK+ 2.90.6 to 2.90.7
==
* All GDK keysym names have been changed from GDK_keysym to GDK_KEY_keysym;
the previous names are still avai
This is needed for current Debian stable (Squeeze).
VTE versions before 2.26 did not support VtePty.
Lower the version requirement and use alternate code which works for Debian.
Signed-off-by: Stefan Weil
---
configure |2 +-
ui/gtk.c |7 ++-
2 files changed, 7 insertions(+), 2 de
Am 22.02.2013 18:51, schrieb Anthony Liguori:
> Stefan Weil writes:
>
>> Am 22.02.2013 18:01, schrieb Anthony Liguori:
>>> Applied. Thanks.
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>> Debian stable (Squeeze) has vte-0.24.3.
>> Your patch disables QEMU's GTK gui for that common platform.
>>
>> Wou
Andreas Färber writes:
> Am 22.02.2013 18:20, schrieb Markus Armbruster:
>> Covers only PC so far.
>>
>> Signed-off-by: Markus Armbruster
>
> Reviewed-by: Andreas Färber
>
>> +static void test_cmos_byte(int reg, int expected)
>> +{
>> +int actual;
>> +
>> +outb(0x70 + 0, reg);
>> +
Always use qemu_file_get_error to detect errors, since that is how
QEMUFile itself drops I/O after an error occurs. There is no need
to propagate and check return values all the time.
Also remove the "complete" member, since we know that it is set (via
migrate_fd_cleanup) only when the state chan
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
include/migration/qemu-file.h | 2 +-
migration-tcp.c | 2 +-
migration-unix.c | 2 +-
savevm.c | 33 +++--
4 files changed, 34
Only the migration_bitmap_sync() call needs the iothread lock.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
arch_init.c | 10 ++
block-migration.c | 2 ++
include/migration/vmstate.h | 2 +-
migration.c
Am 22.02.2013 16:37, schrieb Hao, Xudong:
>> -Original Message-
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>> Sent: Friday, February 22, 2013 5:04 PM
>> To: Hao, Xudong
>> Cc: stefano.stabell...@eu.citrix.com; Zhang, Xiantao;
>> xen-de...@lists.xen.org;
>> qemu-devel@nongnu.org; m...@
Applied. Thanks.
Regards,
Anthony Liguori
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration.c b/migration.c
index 5d9..f35728d 100644
--- a/migration.c
+++ b/migration.c
@@ -628,7 +628,7 @@ static void
Applied. Thanks.
Regards,
Anthony Liguori
On 02/22/13 18:33, Jan Kiszka wrote:
> On 2013-02-20 11:28, Stefan Hajnoczi wrote:
>> Convert iohandler_select_fill() and iohandler_select_poll() to use
>> GPollFD instead of rfds/wfds/xfds.
>
> Since this commmit, I'm getting QEMU lock-ups, apparently slirp is
> involved (the Linux guest tries to
This patch series gets rid of cpu_unlink_tb(), which is irredeemably
racy, since it modifies the TB graph with no locking from other
threads, signal handlers, etc etc. (The signal handler case is
why you can't just fix this with more locks.) Instead we take the
much simpler approach of setting a fl
This reduces the required translations and gives a nicer menu
with an icon.
Signed-off-by: Stefan Weil
---
po/de_DE.po|4
po/it.po |4
po/messages.po |4
ui/gtk.c |3 ++-
4 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/po/de_DE.po b/
This is in fact very simply: When the input in grabbed, everything
should be exclusively passed to the guest - except it has our magic
CTRL-ALT modifier set. Then let GTK filter out those accels that are in
use.
Signed-off-by: Jan Kiszka
---
ui/gtk.c | 16 ++--
1 files changed, 2 i
Am 22.02.2013 19:10, schrieb Peter Maydell:
> From: Andreas Färber
>
> Introduce ENV_OFFSET macros which can be used in non-target-specific
> code that needs to generate TCG instructions which reference CPUState
> fields given the cpu_env register that TCG targets set up with a
> pointer to the C
Andreas Färber wrote:
> Am 22.02.2013 14:22, schrieb Juan Quintela:
>> And now that I review the 3rd patch that does the same, couldn't be
>> easier to do just:
>>
>>
>> static const VMStateDescription vmstate_cpu = {
>> .name = "cpu",
>> .version_id = 1,
>> .minimum_version_id = 1,
On 2013-02-20 14:43, Anthony Liguori wrote:
> If you're full screen, you probably expect Ctrl-Q to go to the guest,
> not the host. I think restricting certain menus is the right way to
> handle this generally speaking.
>
> Signed-off-by: Anthony Liguori
> ---
> ui/gtk.c | 34 ++
On 22 February 2013 18:20, Andreas Färber wrote:
> Am 22.02.2013 19:10, schrieb Peter Maydell:
>> From: Andreas Färber
>> index c0f6c6d..252bd14 100644
>> --- a/target-alpha/cpu-qom.h
>> +++ b/target-alpha/cpu-qom.h
>> @@ -72,5 +72,6 @@ static inline AlphaCPU *alpha_env_get_cpu(CPUAlphaState
>>
The (unsafe) function cpu_unlink_tb() is now unused, so we can simply
remove it and any code that was only used by it.
Signed-off-by: Peter Maydell
---
translate-all.c | 69 ---
1 file changed, 69 deletions(-)
diff --git a/translate-all.c b/
Stefan Weil writes:
> Am 22.02.2013 18:04, schrieb Markus Armbruster:
>> Anthony Liguori writes:
>>
>>> Stefan Weil writes:
>>>
Am 22.02.2013 16:50, schrieb Anthony Liguori:
> This gives us the bare amount of features we need. We can add work
> arounds
> for older versions an
The gen_icount_start/end functions are now somewhat misnamed since they
are useful for generic "start/end of TB" code, used for more than just
icount. Rename them to gen_tb_start/end.
Signed-off-by: Peter Maydell
---
include/exec/gen-icount.h |4 ++--
target-alpha/translate.c |4
Fix some of the nasty TCG race conditions and crashes by implementing
cpu_exit() as setting a flag which is checked at the start of each TB.
This avoids crashes if a thread or signal handler calls cpu_exit()
while the execution thread is itself modifying the TB graph (which
may happen in system emu
Document tcg_qemu_tb_exec(). In particular, its return value is a
combination of a pointer to the next translation block and some
extra information in the low two bits. Provide some #defines for
the values passed in these bits to improve code clarity.
Signed-off-by: Peter Maydell
---
cpu-exec.c
migration_put_buffer is never called if there has been an error.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/migration.c b/migration.c
index 414e0f9..5d9 100644
--- a/migration.
Il 22/02/2013 18:57, Dietmar Maurer ha scritto:
>>> If we use nbd, how can we pass additional information to the other
>>> side, for example information about unallocated regions?
>>>
>>
>> You can either send trim commands, or just skip those regions and let the
>> other
>> side figure it out.
>
Am 22.02.2013 18:51, schrieb Paolo Bonzini:
> Il 22/02/2013 18:50, Andreas Färber ha scritto:
But since we're using some standard GTK menu entries, not translating
would actually give you the much bigger inconsistency: In the same menu,
you would have both English and translated entr
On 2013-02-22 18:53, Anthony Liguori wrote:
> Jan Kiszka writes:
>
>> On 2013-02-22 18:16, Anthony Liguori wrote:
>>> Jan Kiszka writes:
>>>
This adds basic guest control commands to the "Machine" menu - a nice
added-value for the GTK UI. We pick up the stock stop accelerators (if
Cc: qemu-sta...@nongnu.org
Signed-off-by: Markus Armbruster
---
qmp-commands.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 799adea..95022e2 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -822,7 +822,7 @@ Example:
-> { "execu
Am 22.02.2013 18:51, schrieb Paolo Bonzini:
> Il 22/02/2013 18:50, Andreas Färber ha scritto:
But since we're using some standard GTK menu entries, not translating
would actually give you the much bigger inconsistency: In the same menu,
you would have both English and translated entr
> > If we use nbd, how can we pass additional information to the other
> > side, for example information about unallocated regions?
> >
>
> You can either send trim commands, or just skip those regions and let the
> other
> side figure it out.
But we are lost if we want to transfer something els
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 6 +++---
savevm.c| 44 ++--
2 files changed, 21 insertions(+), 29 deletions(-)
diff --git a/include/sysemu/sysemu.h b/incl
Completion of migration is currently done with a "nested" loop that
invokes buffered_flush: migrate_fd_completed is called by
buffered_file_thread, which calls migrate_fd_cleanup, which calls
buffered_close (via qemu_fclose), which flushes the buffer.
Simplify this, by reusing the buffered_flush c
Jan Kiszka writes:
> On 2013-02-22 18:16, Anthony Liguori wrote:
>> Jan Kiszka writes:
>>
>>> This adds basic guest control commands to the "Machine" menu - a nice
>>> added-value for the GTK UI. We pick up the stock stop accelerators (if
>>> any) but not its image as we add a check item.
>>>
>
Stefan Weil writes:
> Am 22.02.2013 18:01, schrieb Anthony Liguori:
>> Applied. Thanks.
>>
>> Regards,
>>
>> Anthony Liguori
>
> Debian stable (Squeeze) has vte-0.24.3.
> Your patch disables QEMU's GTK gui for that common platform.
>
> Would you mind reducing the VTE version requirement to 0.24.
Il 22/02/2013 18:50, Andreas Färber ha scritto:
>> > But since we're using some standard GTK menu entries, not translating
>> > would actually give you the much bigger inconsistency: In the same menu,
>> > you would have both English and translated entries. This is what the
>> > first version of th
This adds basic guest control commands to the "Machine" menu - a nice
added-value for the GTK UI. We pick up the stock stop label and
accelerator (if any) but not its image as we add a check item.
Signed-off-by: Jan Kiszka
---
Changes in v2:
- stock label
- Power-down -> Power Down
ui/gtk.c
Am 21.02.2013 09:38, schrieb Kevin Wolf:
> On Wed, Feb 20, 2013 at 06:26:55PM +0100, Andreas Färber wrote:
>> Am 20.02.2013 18:05, schrieb Anthony Liguori:
>>> Andreas Färber writes:
>>>
Am 20.02.2013 14:43, schrieb Anthony Liguori:
> This includes a de_DE translation from Kevin Wolf and
Il 22/02/2013 18:49, Dietmar Maurer ha scritto:
> >> unix sockets works with qemu nbd code?
>>> > >
>>> > > Sure. nbd+unix:///exportname?socket=path is the new URI syntax, I
>>> > > honestly forgot the old one. SCM_CREDENTIALS checks (qemu-nbd --pid
>>> > > or something like that) is not sup
Stefan Weil writes:
> Am 22.02.2013 17:48, schrieb Anthony Liguori:
>> Stefan Weil writes:
>>
>>> But we need a different solution because not all platforms
>>> support VTE. It must be possible to use GTK without VTE,
>>> so VTE needs its own section in configure.
>> As I mentioned eariler, the
> On Fri, Feb 22, 2013 at 2:07 PM, Paolo Bonzini wrote:
> > Il 22/02/2013 14:02, Dietmar Maurer ha scritto:
> >>> But you can always sandbox using SELinux, if you care about that, or
> >>> use a Unix socket + SCM_CREDENTIALS.
> >>
> >> unix sockets works with qemu nbd code?
> >
> > Sure. nbd+uni
Richard Henderson writes:
> On 02/22/2013 08:16 AM, Andreas Färber wrote:
>> I would be willing to do a macro-based v3 using do { ... } while (0) if
>> maintainers can reach agreement on that and on how to do the if (0).
>
> FWIW, I'm in favor of the
>
> #ifndef DEBUG
> # define DEBUG 0
> #endif
Option "once" sets up a different boot order just for the initial
boot. Boot order reverts back to normal on reset. Option "order"
changes the normal boot order.
The reversal is implemented by reset handler restore_boot_devices(),
which takes the boot order to revert to as argument.
restore_boot
On Fri, Feb 22, 2013 at 05:10:29PM +, Serge E. Hallyn wrote:
> Hi,
>
> up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an
> unknown arg, would do help_cmd(mon, "info"); That behavior is gone in
> 1.4.0, so that 'info', 'info help', and 'info whatever' just say unknown
> ar
Previous code has #define POWERPC_INSNS2_ PPC_NONE in some
places for macrofied assignment to insns_flags2 field.
PPC_NONE is defined as zero though and QOM classes are zero-initialized,
so drop any pcc->insns_flags2 = PPC_NONE; assignments.
PPC_NONE itself is still in use in translate.c.
Sugges
On 2013-02-20 11:28, Stefan Hajnoczi wrote:
> Convert iohandler_select_fill() and iohandler_select_poll() to use
> GPollFD instead of rfds/wfds/xfds.
Since this commmit, I'm getting QEMU lock-ups, apparently slirp is
involved (the Linux guest tries to start its network at this point):
(gdb) threa
Am 22.02.2013 18:04, schrieb Markus Armbruster:
> Anthony Liguori writes:
>
>> Stefan Weil writes:
>>
>>> Am 22.02.2013 16:50, schrieb Anthony Liguori:
This gives us the bare amount of features we need. We can add work arounds
for older versions and lower the requirement but this shoul
Covers only PC so far.
Signed-off-by: Markus Armbruster
---
tests/Makefile | 2 ++
tests/boot-order-test.c | 71 +
2 files changed, 73 insertions(+)
create mode 100644 tests/boot-order-test.c
diff --git a/tests/Makefile b/tests/Makefile
libqtest's qtest_init() connecting to the qtest socket triggers reset.
This was coded in the hope we could use the same QEMU process for
multiple tests that way. Never used. Injects an extra reset even
when it's not used, and that can mess up tests such as the one of
-boot once I'm about to add.
Am 22.02.2013 18:01, schrieb Anthony Liguori:
> Applied. Thanks.
>
> Regards,
>
> Anthony Liguori
Debian stable (Squeeze) has vte-0.24.3.
Your patch disables QEMU's GTK gui for that common platform.
Would you mind reducing the VTE version requirement to 0.24.0?
I see no obvious problems when I c
On 02/21/2013 04:27 AM, Dietmar Maurer wrote:
> This is a very simple archive format, see docs/specs/vma_spec.txt
>
> Signed-off-by: Dietmar Maurer
> ---
> +++ b/docs/specs/vma_spec.txt
> @@ -0,0 +1,24 @@
> +=Virtual Machine Archive format (VMA)=
> +
> +This format contains a header which includ
Am 22.02.2013 18:20, schrieb Markus Armbruster:
> libqtest's qtest_init() connecting to the qtest socket triggers reset.
> This was coded in the hope we could use the same QEMU process for
> multiple tests that way. Never used. Injects an extra reset even
> when it's not used, and that can mess u
Applied. Thanks.
Regards,
Anthony Liguori
Some small changes that will simplify the positioning of lock/unlock
primitives.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
block-migration.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/block-migr
Rate limiting is now simply a byte counter; client call
qemu_file_rate_limit() manually to determine if they have to exit.
So it is possible and simple to move the functionality to QEMUFile.
This makes the remaining functionality of s->file redundant;
in the next patch we can remove it and write d
Cc: qemu-sta...@nongnu.org
Signed-off-by: Markus Armbruster
---
hw/hw.h | 4 ++--
vl.c| 16
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index dfced97..20dc0d6 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -44,9 +44,9 @@ void qemu_unregister_res
I'm afraid -boot regressed in 1.4, specifically commit e4ada29e. This
series fixes it, along with related bugs, and tops off with test
cases.
The first three patches fix the regression, the fourth cleans up
afterwards. I'm nominating these four for stable even though the
regression fix isn't exa
From: Kazuya Saito
Signed-off-by: Kazuya Saito
Signed-off-by: Paolo Bonzini
---
migration.c | 9 -
trace-events | 3 +++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/migration.c b/migration.c
index 9a234c7..b091532 100644
--- a/migration.c
+++ b/migration.c
@@ -23,6
On 2013-02-22 18:16, Anthony Liguori wrote:
> Jan Kiszka writes:
>
>> This adds basic guest control commands to the "Machine" menu - a nice
>> added-value for the GTK UI. We pick up the stock stop accelerators (if
>> any) but not its image as we add a check item.
>>
>> Signed-off-by: Jan Kiszka
On 2013-02-22 18:12, Anthony Liguori wrote:
> Jan Kiszka writes:
>
>> On 2013-02-22 16:14, Anthony Liguori wrote:
>>> Jan Kiszka writes:
>>>
Some smaller quirks I stumbled over so far:
- text consoles use an inferior font compared to SDL (ideally, that
one should also be used
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/migration.c b/migration.c
index 5d048ef..185d112 100644
--- a/migration.c
+++ b/migration.c
@@ -274,10 +274,10
Jan Kiszka writes:
> This adds basic guest control commands to the "Machine" menu - a nice
> added-value for the GTK UI. We pick up the stock stop accelerators (if
> any) but not its image as we add a check item.
>
> Signed-off-by: Jan Kiszka
> ---
>
> Changes in v2:
> - File -> Machine menu
>
Due to library conflicts, Fedora will have to put libiscsi in
/usr/lib/iscsi. Simplify configuration by using a pkg-config
file. The Fedora package will distribute one, and the patch
to add it has been sent to upstream libiscsi as well.
Signed-off-by: Paolo Bonzini
---
configure | 8 +++-
On 2013-02-22 18:10, Anthony Liguori wrote:
> Paolo Bonzini writes:
>
>> Il 22/02/2013 16:17, Anthony Liguori ha scritto:
> FWIW I'd be in favor of making grab-on-hover the default.
>>> It really breaks window manager key bindings. If you alt-tab between
>>> windows and you happen to end up
Jan Kiszka writes:
> On 2013-02-22 16:14, Anthony Liguori wrote:
>> Jan Kiszka writes:
>>
>>> Some smaller quirks I stumbled over so far:
>>> - text consoles use an inferior font compared to SDL (ideally, that
>>>one should also be used for GTK)
>>
>> It uses whatever your system font is.
Paolo Bonzini writes:
> Il 22/02/2013 16:17, Anthony Liguori ha scritto:
>>> > FWIW I'd be in favor of making grab-on-hover the default.
>> It really breaks window manager key bindings. If you alt-tab between
>> windows and you happen to end up with the window under your mouse,
>> alt-tab stops
Hi,
up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an
unknown arg, would do help_cmd(mon, "info"); That behavior is gone in
1.4.0, so that 'info', 'info help', and 'info whatever' just say unknown
argument. Was that intended, or would re-introducing the old behavior
be accep
On Fri, Feb 22, 2013 at 04:48:47PM +0100, Paolo Bonzini wrote:
> Il 22/02/2013 16:17, Anthony Liguori ha scritto:
> >> > FWIW I'd be in favor of making grab-on-hover the default.
> > It really breaks window manager key bindings. If you alt-tab between
> > windows and you happen to end up with the
This is what fd_close does. Prepare for switching to a QEMUFile.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
savevm.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/savevm.c b/savevm.c
index 38699de..1d49fde 100644
--- a/sav
Am 22.02.2013 17:48, schrieb Anthony Liguori:
> Stefan Weil writes:
>
>> Am 22.02.2013 16:50, schrieb Anthony Liguori:
>>> This gives us the bare amount of features we need. We can add work arounds
>>> for older versions and lower the requirement but this should be a good
>>> starting point.
>>>
Anthony Liguori writes:
> Stefan Weil writes:
>
>> Am 22.02.2013 16:50, schrieb Anthony Liguori:
>>> This gives us the bare amount of features we need. We can add work arounds
>>> for older versions and lower the requirement but this should be a good
>>> starting point.
>>>
>>> Suggested-by: Da
On 22 February 2013 16:59, Anthony Liguori wrote:
> They way I plan on doing it is simply making a NULL end up with 'video0'
> or something like that.
Mmm. (Might be nice to avoid having to touch every device to
add a NULL argument to the function though.)
> For the video cards we emulate for th
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
This groups together the callbacks that later will have similar
locking rules.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
include/migration/vmstate.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/migration/vmsta
Including data that resided in the QEMUFile's own buffer.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration.c b/migration.c
index 10ce9fe..c5a7f29 100644
--- a/migration.c
+++ b/mi
Unify the goto around the loop, with the exit condition at the end of it.
Both can be expressed as "while (ret >= 0)".
Signed-off-by: Paolo Bonzini
---
migration.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index 11725ae..ba8b647 100
Perform final cleanup in a bottom half, and add joining the thread to
the series of cleanup actions.
migrate_fd_error remains for connection error, but it doesn't need
to cleanup anything anymore.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
include/
Jan Kiszka writes:
> On 2013-02-22 16:14, Anthony Liguori wrote:
>> Jan Kiszka writes:
>>
>>> On 2013-02-22 10:56, Jan Kiszka wrote:
On 2013-02-22 00:04, Anthony Liguori wrote:
>
> Since this is a pretty visible change for a lot of people, I thought I'd
> send a top level note.
On 02/22/2013 08:16 AM, Andreas Färber wrote:
> I would be willing to do a macro-based v3 using do { ... } while (0) if
> maintainers can reach agreement on that and on how to do the if (0).
FWIW, I'm in favor of the
#ifndef DEBUG
# define DEBUG 0
#endif
#define MACRO_NAME(...) \
do { if (DEBUG
Jan Kiszka writes:
> On 2013-02-22 16:38, Jan Kiszka wrote:
@@ -995,6 +1038,22 @@ static void gd_create_menus(GtkDisplayState *s)
"/File/Quit");
gtk_accel_map_add_entry("/File/Quit", item.keyval,
item.modifier);
+s->contr
Stefan Weil writes:
> Am 22.02.2013 16:50, schrieb Anthony Liguori:
>> This gives us the bare amount of features we need. We can add work arounds
>> for older versions and lower the requirement but this should be a good
>> starting point.
>>
>> Suggested-by: Daniel Berrange
>> Signed-off-by: An
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration.c b/migration.c
index 612ffa7..414e0f9 100644
--- a/migration.c
+++ b/migration.c
@@ -657,6 +657,10 @@ static
The indirection is useless now. Backends can open s->file directly.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
include/migration/migration.h | 2 --
migration-exec.c | 4 ++--
migration-fd.c| 2 +-
migration-tcp.c
>>> On 22.02.13 at 16:37, "Hao, Xudong" wrote:
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>> And then again, wasting 4 bytes of config space on something that
>> one ought to be allowed to expect to be at least 64k-aligned seems
>> questionable too. hvmloader surely could align the value up t
Markus Armbruster wrote:
> Juan Quintela writes:
>
>>> I'm confused. Do you mean pages that are entirely filled with the same
>>> byte? Or pages with contents identical to some other, non-duplicate
>>> page?
>>
>> It is a page full of zeros. Yes, we can have pages full of any other
>> char, th
With this patch, the migration_file is not needed anymore.
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Paolo Bonzini
---
migration.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/migration.c b/migration.c
index 4b04d50..64d8e46
From: Juan Quintela
This is consistent once that we have moved everything to migration.c
Reviewed-by: Orit Wasserman
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
migration.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/
Buffering was needed because blocking writes could take a long time
and starve other threads seeking to grab the big QEMU mutex.
Now that all writes (except within _complete callbacks) are done
outside the big QEMU mutex, we do not need buffering at all.
Reviewed-by: Orit Wasserman
Reviewed-by:
This makes it possible to do blocking writes directly to the socket,
with no buffer in the middle. For RAM, only the migration_bitmap_sync()
call needs the iothread lock. For block migration, it is needed by
the block layer (including bdrv_drain_all and dirty bitmap access),
but because some code
101 - 200 of 419 matches
Mail list logo
