[Qemu-devel] [PATCH v5 13/24] hw/arm: add Faraday FTNANDC021 nand flash controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTNANDC021 is an integrated NAND flash controller which re-pack the NAND flash command set with a shorter built-in opcode. It also provides a register base interface for user to easily access the underlying NAND flash chips, and also supports HW ECC.

Re: [Qemu-devel] [PATCH 0/3] Implement and test asn1 ber visitors

2013-02-27 Thread Andreas Färber
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com: These patches implement asn1 ber visitors for encoding and decoding data. These depend on the previously posted patch Move File operations to qemu-file.c. These seem useful on their own so I thought I'd post them now so others can

[Qemu-devel] [PATCH v5 23/24] hw/arm: add Faraday FTTMR010 timer support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTTMR010 provides three independent sets of sub-timers. Two match registers are provided for each sub-timer, whenever the value of the match registers equals any one value of the sub-timers, the timer interrupt will be immediately triggered. And it

[Qemu-devel] [PATCH v5 06/24] hw/arm: add Faraday FTPWMTMR010 timer support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTPWMTMR010 is an APB device which provides up to 8 independent timers. Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com --- hw/arm/Makefile.objs |1 + hw/arm/faraday_a369_soc.c | 10 ++ hw/arm/ftpwmtmr010.c | 265

Re: [Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 27.02.2013 08:52, schrieb Jan Kiszka: On 2013-02-27 08:37, Igor Mammedov wrote: On Wed, 27 Feb 2013 00:26:38 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Feb 26, 2013 at 10:57:56PM +0100, Igor Mammedov wrote: On Sat, 23 Feb 2013

[Qemu-devel] [PATCH v5 15/24] hw: add WM8731 codec support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com Wolfson WM8731 is a simple audio codec for embedded systems. It has 2 input and 1 output ports: ** Input ** 1. Linue-In 2. Microphone ** Output ** 1. Headphone out BTW it's based on hw/wm8750.c with 16bit I2S support by default.

[Qemu-devel] [PATCH v5 16/24] hw/arm: add Faraday FTSSP010 multi-function controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTSSP010 is a multi-function synchronous serial port interface controller which supports SSP, SPI, I2S, AC97 and SPDIF. Only I2S and SPI protocol have been implemented in this patch. Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com ---

[Qemu-devel] [PATCH v5 19/24] hw/arm: add Faraday FTLCDC200 LCD controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTLCDC200 Color LCD controller performs translation of pixel-coded data into the required formats and timings to drive a variety of single/dual mono and color LCDs. Depending on the LCD type and mode, the unpacked data can represent: 1. an actual

[Qemu-devel] [PATCH v5 02/24] hw/arm: add Faraday a369 SoC platform support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The Faraday A369 EVB is a Faraday SoC platform evalution board used for Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com --- hw/arm/Makefile.objs |4 +

[Qemu-devel] [PATCH v5 24/24] hw/arm: add Faraday FTSPI020 SPI flash controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTSPI020 is an integrated SPI Flash controller which supports up to 4 flash chips. Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com --- hw/arm/Makefile.objs |1 + hw/arm/faraday_a369.c | 13 ++ hw/arm/faraday_a369_soc.c |4 +

Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition on target.OPC_MAX_SIZE - size of translation buffer - was increased because condition translated bytecode should be e

2013-02-27 Thread Jan Kiszka
On 2013-02-27 08:25, Neiman, Anna wrote: Hi Jan, Thank you for your review. I added 4 patches including whole implementation of this feature, not just infrastructure. Some explanations for your notes : Please comment inline, do not top-post. Cond_exp is the array of bytecodes ( not

Re: [Qemu-devel] [PATCH] block: for HMP commit() operations on 'all', skip non-COW drives

2013-02-27 Thread Markus Armbruster
Jeff Cody jc...@redhat.com writes: During a commit of 'all' using the HMP non-live commit, the operation is aborted and returns error on the first error enountered. When non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without a backing parent), that means a commit all will

[Qemu-devel] [PATCH v5 11/24] hw/nand.c: bug fix to BUSY/READY status bit

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The BIT6 of Status Register(SR): SR[6] behaves the same as R/B# pin SR[6] = 0 indicates the device is busy; SR[6] = 1 means the device is ready Some NAND flash controller (i.e. ftnandc021) relies on the SR[6] to determine if the NAND flash

[Qemu-devel] [PATCH v5 08/24] hw/arm: add Faraday FTRTC011 RTC timer support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com It provides separate second, minute, hour, and day counters. The second counter is toggled each second, the minute counter is toggled each minute, the hour counter is toggled each hour, and the day counter is toggled each day. The FTRTC011 provides a

[Qemu-devel] [PATCH v5 03/24] hw/arm: add Faraday FTINTC020 interrupt controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTINTC020 interrupt controller supports both FIQ and IRQ signals to the microprocessor. It can handle up to 64 configurable IRQ sources and 64 FIQ sources. The output signals to the microprocessor can be configured as level-high/low active or

Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-27 Thread Jan Kiszka
On 2013-02-26 23:18, Anthony Liguori wrote: Jan Kiszka jan.kis...@siemens.com writes: Otherwise we may start processing sockets in slirp_pollfds_poll that were created past slirp_pollfds_fill. Signed-off-by: Jan Kiszka jan.kis...@siemens.com I think there's still something wrong...

[Qemu-devel] [PATCH v5 20/24] hw/arm: add Faraday FTTSC010 touchscreen controller support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com The FTTSC010 provides two operation modes to sample the analog input voltage. 1. The manual operation mode needs to program and control the panel drivers by software step-by-step for the x-y position measurement. 2. The auto-scan mode

Re: [Qemu-devel] [PATCH 2/3] asn1 ber visitors

2013-02-27 Thread Andreas Färber
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com: These patches implement asn1 ber visitors for encoding and decoding data. Would be good to not be lazy and spell them correctly in at least one of the two lines of the commit where they're being introduced. References:

[Qemu-devel] [PATCH v5 04/24] hw/arm: add Faraday FTAHBC020 support

2013-02-27 Thread Kuo-Jung Su
From: Kuo-Jung Su dant...@faraday-tech.com It's used to perform AHB remap and if the SDRAM is initialized before AHB remap process activated, then it would also perform the QEMU RAM initialization. Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com --- hw/arm/Makefile.objs |1 +

Re: [Qemu-devel] [PATCH] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Igor Mammedov
On Wed, 27 Feb 2013 08:52:50 +0100 Jan Kiszka jan.kis...@web.de wrote: On 2013-02-27 08:37, Igor Mammedov wrote: On Wed, 27 Feb 2013 00:26:38 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Tue, Feb 26, 2013 at 10:57:56PM +0100, Igor Mammedov wrote: On Sat, 23 Feb 2013 16:45:00

Re: [Qemu-devel] [PATCH V7 14/14] hmp: show snapshots on single block device

2013-02-27 Thread Wenchao Xia
于 2013-2-27 10:29, Wenchao Xia 写道: 于 2013-2-27 0:13, Eric Blake 写道: On 02/26/2013 03:40 AM, Wenchao Xia wrote: This patch added the support of showing internal snapshots on an image in the backing chain of a block device in hmp layer, by calling a qmp function. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-27 Thread Jan Kiszka
On 2013-02-27 05:44, Peter Crosthwaite wrote: Hi Jan, I actually have my own subset implementation of this currently on list. Yours is more complete however, So id prefer to drop mine in favour of yours and reverify Zynq as working with yours. Great! I'm trying to look for a slot to address

Re: [Qemu-devel] [PATCH v5 1/6] add documenation for new backup framework

2013-02-27 Thread Markus Armbruster
Starting the series with a problem statement is a good idea. Suggest Subject: subsystem: Design documentation, where subsystem is how you'd like to call the beast. Also tack it to your other patch subjects, except when they really patch other subsystems (use your judgement). More inline.

[Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Jan Kiszka
Several issues fixed: - We were missing a bunch of feature lists. Fix this by simply dumping the meta list feature_word_info. - kvm_enabled() cannot be true at this point because accelerators are initialized much later during init. Also, hiding this makes it very hard to discover for

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Andreas Färber
Am 27.02.2013 01:47, schrieb Keith Busch: NVM Express is an open standard for PCI-e attached Non-Volatile Memory storage. This commit adds an emulated device that supports the register interface and command set defined by this standard. The standard can be viewed at nvmexpress.org. This

Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Igor Mammedov
On Wed, 27 Feb 2013 10:15:51 +0100 Jan Kiszka jan.kis...@siemens.com wrote: Several issues fixed: - We were missing a bunch of feature lists. Fix this by simply dumping the meta list feature_word_info. - kvm_enabled() cannot be true at this point because accelerators are initialized

Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Andreas Färber
Am 27.02.2013 10:15, schrieb Jan Kiszka: Several issues fixed: - We were missing a bunch of feature lists. Fix this by simply dumping the meta list feature_word_info. - kvm_enabled() cannot be true at this point because accelerators are initialized much later during init. Also, hiding

Re: [Qemu-devel] [PATCH 6/9] virtio net: introduce dataplane for virtio net

2013-02-27 Thread liu ping fan
On Fri, Feb 22, 2013 at 4:55 AM, mdroth mdr...@linux.vnet.ibm.com wrote: On Thu, Feb 21, 2013 at 08:54:50PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This is a emulation to virtio-blk dataplane, which push the data handling out of biglock. And it is a try to

Re: [Qemu-devel] [PATCH v2] target-i386: Improve x86_cpu_list output

2013-02-27 Thread Jan Kiszka
On 2013-02-27 10:33, Andreas Färber wrote: Am 27.02.2013 10:15, schrieb Jan Kiszka: Several issues fixed: - We were missing a bunch of feature lists. Fix this by simply dumping the meta list feature_word_info. - kvm_enabled() cannot be true at this point because accelerators are

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-27 Thread liu ping fan
On Tue, Feb 26, 2013 at 1:53 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 25/02/2013 18:35, mdroth ha scritto: Moving more of the os_host_main_loop_wait to AioContext would be possible (timers are on the todo list, in fact), but we should only do it as need arises. Were you planning on

Re: [Qemu-devel] [PATCH v5 2/6] add basic backup support to block driver

2013-02-27 Thread Markus Armbruster
First pass, fairly superficial, hope it helps anyway. Dietmar Maurer diet...@proxmox.com writes: Function backup_job_create() creates a block job to backup a block device. The coroutine is started with backup_job_start(). We call backup_do_cow() for each write during backup. That function

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-27 Thread liu ping fan
On Fri, Feb 22, 2013 at 12:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 21, 2013 at 06:45:54PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 21, 2013 at 10:15:58AM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Feb 21, 2013 at 08:54:44PM

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 10:30, Andreas Färber ha scritto: +id-vwc = 1; +snprintf((char *)id-mn, sizeof(id-mn), QEMU NVMe Ctrl); +snprintf((char *)id-fr, sizeof(id-fr), 1.0); +snprintf((char *)id-sn, sizeof(id-sn), NVMeQx10%02x, n-instance); Does this linear instance counting

Re: [Qemu-devel] [PATCH 10/11] QEMU NVMe: Add logging

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 01:47, Keith Busch ha scritto: Adds logging at various levels of detail throughout the code so that a developer may see what is occuring within a device interacting with their nvme drivers and utilities. Please use the existing trace support (see file trace-events and configure

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-27 Thread Zhang, Xiantao
Given that Xen has at least two other mechanisms (xenstore and hvmparams) for passing this sort of information around I'm not sure why hacking the emulated i440fx device should be the preferred option. Actually, even in hardware, I believe there are many registers which are implemented with

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-27 Thread Michael S. Tsirkin
On Wed, Feb 27, 2013 at 05:41:40PM +0800, liu ping fan wrote: On Fri, Feb 22, 2013 at 12:51 AM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 21, 2013 at 06:45:54PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 21, 2013 at 10:15:58AM -0600, Anthony Liguori wrote: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] target-arm: Added CP15 VBAR support

2013-02-27 Thread Peter Maydell
On 27 February 2013 07:16, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: From: Nathan Rossi nathan.ro...@xilinx.com Added Vector Base Address remapping on ARM v7. This one's tricky because the VBAR only exists in CPUs with TrustZone, and strictly speaking QEMU models a non-TrustZone

[Qemu-devel] [PATCH] PATCH1 v2 infrastructure for Evaluate breakpoint cond on target

2013-02-27 Thread Anna Neiman
Signed-off-by: Anna Neiman anna_nei...@mentor.com --- exec.c|5 + gdbstub.c | 22 +++--- 2 files changed, 4 insertions(+), 23 deletions(-) diff --git a/exec.c b/exec.c index 4289c87..c7d1284 100644 --- a/exec.c +++ b/exec.c @@ -458,10 +458,7 @@ void

Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands

2013-02-27 Thread Markus Armbruster
First pass, concentrating on interfaces, implementation mostly ignored. Dietmar Maurer diet...@proxmox.com writes: We use a generic BackupDriver struct to encapsulate all archive format related function. Another option would be to simply dump devid,cluster_num,cluster_data to the output fh

Re: [Qemu-devel] [PATCH] PATCH1 v2 infrastructure for Evaluate breakpoint cond on target

2013-02-27 Thread Peter Maydell
On 27 February 2013 10:16, Anna Neiman anna_nei...@mentor.com wrote: You need more than just a one liner commit message. You should be sending your patches with the right tools (git format-patch and git send-email) so they come out with a cover letter, properly threaded, and with git putting the

Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format

2013-02-27 Thread Kevin Wolf
Am 25.02.2013 um 16:12 hat Eric Blake geschrieben: On 02/24/2013 11:37 PM, Dietmar Maurer wrote: I tried to do that, but it seems that gcc does not support sizeof in preprocessor conditionals, so I added a runtime check in vma_writer_create(). Then you've never written a compile-time

[Qemu-devel] [PATCH] qom/object.h: fix comment of ObjectClass

2013-02-27 Thread Hu Tao
It's now not true what the comment says. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- include/qom/object.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index cf094e7..ccebd90 100644 --- a/include/qom/object.h +++

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-27 Thread Michael S. Tsirkin
On Mon, Feb 25, 2013 at 02:53:37PM +0800, Xudong Hao wrote: v2: * Use piix: in the subject rather than qemu: * Define TOM register as one byte * Define default TOM value instead of hardcode 0xe000 in more that one place * Use API pci_set_byte for pci config access * Use dev-config

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Kevin Wolf
Am 27.02.2013 um 10:48 hat Paolo Bonzini geschrieben: Finally, and unrelated to the code above, we usually do not add new if values. It's enough to have access via if=none -device. In any case it should be a separate patch, so it's easy to drop it if that's the decision. -device is an

Re: [Qemu-devel] [PATCH 10/11] QEMU NVMe: Add logging

2013-02-27 Thread Kevin Wolf
Am 27.02.2013 um 10:49 hat Paolo Bonzini geschrieben: Il 27/02/2013 01:47, Keith Busch ha scritto: Adds logging at various levels of detail throughout the code so that a developer may see what is occuring within a device interacting with their nvme drivers and utilities. Please use the

Re: [Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-27 Thread Ian Campbell
I'm not sure about qemu-devel but on xen-devel the policy is not to top post so please could you avoid doping so. On Wed, 2013-02-27 at 09:49 +, Zhang, Xiantao wrote: Given that Xen has at least two other mechanisms (xenstore and hvmparams) for passing this sort of information around I'm

Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format

2013-02-27 Thread Markus Armbruster
Dietmar Maurer diet...@proxmox.com writes: This is a very simple archive format, see docs/specs/vma_spec.txt Signed-off-by: Dietmar Maurer diet...@proxmox.com --- Makefile|3 +- Makefile.objs |2 +- blockdev.c |6 +-

Re: [Qemu-devel] [PATCH v5 6/6] add vm state to backups

2013-02-27 Thread Markus Armbruster
First pass, concentrating on interfaces, implementation mostly ignored. Dietmar Maurer diet...@proxmox.com writes: Signed-off-by: Dietmar Maurer diet...@proxmox.com --- blockdev.c | 196 +- hmp.c|3 +-

Re: [Qemu-devel] [PATCH 01/11] NVMe: Initial commit for NVM Express device

2013-02-27 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 27.02.2013 um 10:48 hat Paolo Bonzini geschrieben: Finally, and unrelated to the code above, we usually do not add new if values. It's enough to have access via if=none -device. In any case it should be a separate patch, so it's easy to drop it if

Re: [Qemu-devel] QCOW2 deduplication

2013-02-27 Thread Kevin Wolf
Am 26.02.2013 um 18:14 hat Benoît Canet geschrieben: Hello Kevin, As you are best person to discuss QCOW2 implementations issues with I am writing this mail so you can know what has been done on deduplication and what I am planning to do next. In short I need your feedback before

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-27 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Mon, Feb 25, 2013 at 06:53:04PM +0100, Paolo Bonzini wrote: Il 25/02/2013 18:35, mdroth ha scritto: Yup, don't mean to get ahead of things, my main interest is just in how we might deal with the interaction between NetClients and virtio-net

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Amit Shah
On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto: static Property virtio_serial_properties[] = { DEFINE_PROP_BIT(ioeventfd, VirtIOPCIProxy, flags,

Re: [Qemu-devel] [PATCH v5 6/6] add vm state to backups

2013-02-27 Thread Dietmar Maurer
First pass, concentrating on interfaces, implementation mostly ignored. Hi Markus, many thanks for the review. I currently try to rewrite the whole series using and nbd server - like suggested by Stefan. So hmp/qmp commands will change.

Re: [Qemu-devel] [PATCH] spice-qemu-char: register interface on post load

2013-02-27 Thread Amit Shah
On (Mon) 24 Dec 2012 [13:09:20], Amit Shah wrote: On (Sun) 23 Dec 2012 [23:35:29], Alon Levy wrote: The target has not seen the guest_connected event via spice_chr_guest_open or spice_chr_write, and so spice server wrongly assumes there is no agent active, while the client continues to send

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 13:08, Markus Armbruster ha scritto: The main blocker to this series seems to be hubs, because they interact with multiple NetClients and thus could span multiple AioContexts. Adding proper locking there is going to be interesting. :) I think folks are pretty fed up with

Re: [Qemu-devel] [PATCH ui/gtk 00/13] Add support for GTK3 fix GTK 2.18

2013-02-27 Thread Daniel P. Berrange
Sorry Anthony, forgot to CC you on this thread originally. I can re-post it if you prefer. Daniel On Mon, Feb 25, 2013 at 03:20:33PM +, Daniel P. Berrange wrote: This series does the pretty minor work required to enable building QEMU GTK frontend with either GTK-2 or GTK-3, with a choice

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Gal Hammer
On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto: static Property virtio_serial_properties[] = { DEFINE_PROP_BIT(ioeventfd,

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 05:02:19PM +, Dietmar Maurer wrote: If you want to implement an alternative to rate-limiting, please do it in a separate patch series and make it work for all block job types. Well, I hoped you can see how to fix that. I guess the same applies for other types

Re: [Qemu-devel] [PATCH] glib: Add compat wrapper for g_poll on old glib

2013-02-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] qemu-log: default to stderr for logging output

2013-02-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH ui/gtk 00/13] Add support for GTK3 fix GTK 2.18

2013-02-27 Thread Anthony Liguori
Daniel P. Berrange berra...@redhat.com writes: Sorry Anthony, forgot to CC you on this thread originally. I can re-post it if you prefer. No worries, I had already applied it. Thanks for doing this work! Regards, Anthony Liguori Daniel On Mon, Feb 25, 2013 at 03:20:33PM +, Daniel

Re: [Qemu-devel] [PATCH ui/gtk 00/13] Add support for GTK3 fix GTK 2.18

2013-02-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] gtk ui: unbreak spice

2013-02-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Gal Hammer
On 27/02/2013 15:28, Paolo Bonzini wrote: Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: Il 03/02/2013 13:11, Michael S. Tsirkin ha

Re: [Qemu-devel] [PATCH 1/3] two new file wrappers

2013-02-27 Thread Stefan Berger
On 02/26/2013 09:19 PM, Anthony Liguori wrote: jsch...@linux.vnet.ibm.com writes: I think we've moved away from using qemu-file for anything other than migration. Our goal was to use the abstraction of a QEMUFile for writing into memory buffers and later on to also provide a wrapper for

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 14:46, Gal Hammer ha scritto: On 27/02/2013 15:28, Paolo Bonzini wrote: Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: Il

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Paolo Bonzini
Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto: static Property

Re: [Qemu-devel] [PATCH] show --disable-gtk and --enable-gtk in the help message

2013-02-27 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] qemu-log: default to stderr for logging output

2013-02-27 Thread Peter Maydell
On 27 February 2013 13:28, Anthony Liguori aligu...@us.ibm.com wrote: Applied. Thanks. Thanks. I've created a stub http://wiki.qemu.org/ChangeLog/1.5 and noted the change in default log output destination there. -- PMM

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Michael S. Tsirkin
On Wed, Feb 27, 2013 at 03:46:25PM +0200, Gal Hammer wrote: On 27/02/2013 15:28, Paolo Bonzini wrote: Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo

Re: [Qemu-devel] [PATCH V7 02/14] block: add bdrv_can_read_snapshot() function

2013-02-27 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: Compared to bdrv_can_snapshot(), this function return whether bs* is ready to read snapshot info from instead of write. If yes, caller can then query snapshot information, but taking snapshot is not always possible for that *bs may be read

[Qemu-devel] [PATCH] net: use socket_set_nodelay() for -netdev socket

2013-02-27 Thread Stefan Hajnoczi
Reduce -netdev socket latency by disabling the Nagle algorithm on SOCK_STREAM sockets in net/socket.c. Since we are tunelling Ethernet over TCP we shouldn't artificially delay outgoing packets, let the guest decide packet scheduling. I already get sub-millisecond -netdev socket ping times on

Re: [Qemu-devel] unix sockets for qemu

2013-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 05:31:04PM +0100, Stefan Hajnoczi wrote: On Mon, Feb 25, 2013 at 07:02:30PM -0600, clow...@clownix.net wrote: The associated file contains a README that will guide you through the experiment that shows the difference between unix socket carried pings: 0.7ms and inet

Re: [Qemu-devel] [PATCH V7 05/14] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-02-27 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch add function bdrv_query_snapshot_infolist(), which will adds return snapshot info of an image in qmp object format. The implementation code are based on the code moved from qemu-img.c with modification to fit more implementation is

Re: [Qemu-devel] [PATCHv2 for-1.4] e1000: unbreak the guest network migration to 1.3

2013-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 11:53:28PM +0200, Michael S. Tsirkin wrote: QEMU 1.3 does not emulate the link auto negotiation, so if migrate to a 1.3 machine during link auto negotiation, the guest link will be set to down. Fix this by just disabling auto negotiation for 1.3 and older. ... diff

Re: [Qemu-devel] [RFC V6 24/33] qcow2: Integrate deduplication in qcow2_co_writev loop.

2013-02-27 Thread Benoît Canet
I find this expression hard to understand. We only get here if ds.nb_undedupable_sectors 0. In other words, we tried to dedup but failed, so we must write data into the image file. Can we ensure that ds.nb_undedupable_sectors is limited to at most remaining_sectors? Then the expression

Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.

2013-02-27 Thread Benoît Canet
inc_refcounts(bs, res, refcount_table, refcount_table_size, -l2_offset, s-cluster_size); +l2_offset, dedup ? s-hash_block_size : s-l2_size 3); Why s-l2_size 3 instead of s-cluster_size for the non-dedup case? I wrote it like this so the code

Re: [Qemu-devel] [PATCH] help: add docs for missing 'queues' option of tap

2013-02-27 Thread Stefan Hajnoczi
On Fri, Feb 22, 2013 at 10:57:52PM +0800, Jason Wang wrote: Cc: Markus Armbruster arm...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang jasow...@redhat.com --- qapi-schema.json |2 ++ qemu-options.hx |3 ++- 2 files changed, 4 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH] qmp: netdev_add is like -netdev, not -net, fix documentation

2013-02-27 Thread Stefan Hajnoczi
On Fri, Feb 22, 2013 at 06:31:51PM +0100, Markus Armbruster wrote: Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com --- qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my net tree:

Re: [Qemu-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 05:47:03PM -0700, Keith Busch wrote: This is the initial patches needed for a qemu device. I've submitted a patch for this before, but it was very large had some issues. This splits the commit into multiple commits. The initial commit is the smallest I could make this

Re: [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup.

2013-02-27 Thread Benoît Canet
-if ((refcount == 1) != ((l2_entry QCOW_OFLAG_COPIED) != 0)) { +if (!s-has_dedup +(refcount == 1) != ((l2_entry QCOW_OFLAG_COPIED) != 0)) { +fprintf(stderr, ERROR OFLAG_COPIED: offset=% +

Re: [Qemu-devel] [PATCH 00/11] *** SUBJECT HERE ***

2013-02-27 Thread Keith Busch
On Wed, 27 Feb 2013, Stefan Hajnoczi wrote: Hi Keith, Any pointers on how to test this? For example NVMe-specific userspace tools that poke the more exotic commands/features? I use internal tools not externally available, but I know some folks use the compliance suite here:

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Gal Hammer
On 27/02/2013 16:03, Michael S. Tsirkin wrote: On Wed, Feb 27, 2013 at 03:46:25PM +0200, Gal Hammer wrote: On 27/02/2013 15:28, Paolo Bonzini wrote: Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote: On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote:

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Michael S. Tsirkin
On Wed, Feb 27, 2013 at 04:51:00PM +0200, Gal Hammer wrote: On 27/02/2013 16:03, Michael S. Tsirkin wrote: On Wed, Feb 27, 2013 at 03:46:25PM +0200, Gal Hammer wrote: On 27/02/2013 15:28, Paolo Bonzini wrote: Il 27/02/2013 14:24, Gal Hammer ha scritto: On 27/02/2013 14:35, Amit Shah wrote:

[Qemu-devel] [PULL 0/7] Net patches

2013-02-27 Thread Stefan Hajnoczi
Tested that tap still works with the QEMU vlan feature. The following changes since commit ee24aaf356f44ca7c8fbef136a438c12091cffd0: Merge remote-tracking branch 'kiszka/queues/slirp' into staging (2013-02-26 13:36:09 -0600) are available in the git repository at:

[Qemu-devel] [PATCH 5/7] net: reduce the unnecessary memory allocation of multiqueue

2013-02-27 Thread Stefan Hajnoczi
From: Jason Wang jasow...@redhat.com Edivaldo reports a problem that the array of NetClientState in NICState is too large - MAX_QUEUE_NUM(1024) which will wastes memory even if multiqueue is not used. Instead of static arrays, solving this issue by allocating the queues on demand for both the

[Qemu-devel] [PATCH 2/7] net: fix unbounded NetQueue

2013-02-27 Thread Stefan Hajnoczi
From: Luigi Rizzo ri...@iet.unipi.it In the current implementation of qemu, running without a network backend will cause the queue to grow unbounded when the guest is transmitting traffic. This patch fixes the problem by implementing bounded size NetQueue, used with an arbitrary limit of 1

[Qemu-devel] [PATCH 1/7] net: fix qemu_flush_queued_packets() in presence of a hub

2013-02-27 Thread Stefan Hajnoczi
From: Luigi Rizzo ri...@iet.unipi.it When frontend and backend are connected through a hub as below (showing only one direction), and the frontend (or in general, all output ports of the hub) cannot accept more traffic, the backend queues packets in queue-A. When the frontend (or in general, one

[Qemu-devel] [PATCH 7/7] qmp: netdev_add is like -netdev, not -net, fix documentation

2013-02-27 Thread Stefan Hajnoczi
From: Markus Armbruster arm...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 6/7] doc: document -netdev hubport

2013-02-27 Thread Stefan Hajnoczi
Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hmp-commands.hx | 2 +- qemu-options.hx | 11 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index cef7708..69c707d 100644 ---

[Qemu-devel] [PATCH 3/7] tap: forbid creating multiqueue tap when hub is used

2013-02-27 Thread Stefan Hajnoczi
From: Jason Wang jasow...@redhat.com Obviously, hub does not support multiqueue tap. So this patch forbids creating multiple queue tap when hub is used to prevent the crash when command line such as -net tap,queues=2 is used. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang

[Qemu-devel] [PATCH 4/7] tap: set IFF_ONE_QUEUE per default

2013-02-27 Thread Stefan Hajnoczi
From: Peter Lieven p...@dlhnet.de historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues overruns. setting IFF_ONE_QUEUE is the default in kernels = 3.8. the flag is ignored since then. see

Re: [Qemu-devel] Block I/O optimizations

2013-02-27 Thread Abel Gordon
Stefan Hajnoczi stefa...@gmail.com wrote on 26/02/2013 06:45:30 PM: But is this significantly different than any other security bug in the host, qemu, kvm? If you perform the I/O virtualization in a separate (not qemu) process, you have a significantly smaller, self-contained and

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-27 Thread Michael S. Tsirkin
From fddf3136cc2cd0372c52a09424715b15c6ad131f Mon Sep 17 00:00:00 2001 From: Gal Hammer gham...@redhat.com Date: Wed, 27 Feb 2013 15:15:31 +0200 Subject: [PATCH] Set virtio-serial device to have a default of 2 MSI vectors. The virtio-serial device is expected to use 2 MSI vectors, one for

Re: [Qemu-devel] [PATCH V7 06/14] block: add image info query function bdrv_query_image_info()

2013-02-27 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch add function bdrv_query_image_info(), which will return image info in qmp object format. The implementation code are based on the code moved from qemu-img.c, but use block layer function to get snapshot info. A check with

Re: [Qemu-devel] [PATCH v5 3/6] add backup related monitor commands

2013-02-27 Thread Eric Blake
On 02/27/2013 03:31 AM, Markus Armbruster wrote: First pass, concentrating on interfaces, implementation mostly ignored. Dietmar Maurer diet...@proxmox.com writes: We use a generic BackupDriver struct to encapsulate all archive format related function. +# @backup: +# +# Starts a VM

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-27 Thread Dietmar Maurer
Adding and IO queue and implement a scheduler is likely not what we want to do. The starting point for something smarter than just no policy or rate-limiting is BlockDriverState-tracked_requests. block.c keeps track of active requests using this list. The simplest policy using

Re: [Qemu-devel] [PATCH v2] gtk: Release modifier when graphic console loses keyboard focus

2013-02-27 Thread Stefan Hajnoczi
On Tue, Feb 26, 2013 at 8:45 PM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com This solves, e.g., sticky ALT when selecting a GTK menu, switching to a different window or selecting a different virtual console. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

Re: [Qemu-devel] Block I/O optimizations

2013-02-27 Thread Abel Gordon
Stefan Hajnoczi stefa...@gmail.com wrote on 26/02/2013 06:45:30 PM: But is this significantly different than any other security bug in the host, qemu, kvm? If you perform the I/O virtualization in a separate (not qemu) process, you have a significantly smaller, self-contained and

Re: [Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-27 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 26/02/2013 20:35, Anthony Liguori ha scritto: See also discussion on multi-valued keys in command line option arguments and config files in v1 thread. Hopefully we can reach a conclusion soon, and then we'll see whether this patch is what we

  1   2   3   >