Pure code motion, no functional changes.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/console.h |2 --
ui/console.c | 50 ++
vl.c | 49 -
3 files
On 04/16/2013 07:22 PM, Paolo Bonzini wrote:
Il 16/04/2013 09:57, Markus Armbruster ha scritto:
I think this is just beautiful. Fedora18, x86_64, NO cross
compiler. gcc does not apply -Wredundant-decls to /usr/include/* but
does it for all other headers and in the case of cross compilation I
On 04/16/2013 07:00 PM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/16/2013 01:55 AM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/15/2013 10:57 PM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On
Add helper functions to create pixman mask images for glyphs
and to render these glyphs into a pixman image.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/qemu-pixman.h |7 +++
ui/qemu-pixman.c | 43 +++
2 files changed,
I'm happy to say that I'm not touching IOWatchPoll (well, almost: only
for consistency). Instead, these patches try to make the code consistent
(thus avoiding CRITICAL messages from glib) and to fix detection of pty
connections; Gerd reported that it went berserk with polling. I think it
is the
Always check that the source is active, and zero the tag afterwards.
The occurrence in pty_chr_state will trigger with the next patch, the
others are just theoretical.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qemu-char.c | 32 +++-
1 file changed, 23
Even if a CharDriverState's source is blocked by the front-end,
it must not be dropped. The IOWatchPoll that wraps it will take
care of adding and removing it to the main loop. Only remove
the source when the channel is closed; and in that case, make sure
that the wrapping IOWatchPoll is removed
There is no need to use a timer and pty_chr_read to detect a connected
pty. It is simpler to just call g_poll periodically and check for POLLHUP.
It is done once per second, and only if the pty is disconnected, so it
is cheap enough.
Tested with -monitor pty and -serial mon:pty, both of which
Il 16/04/2013 12:54, Alexey Kardashevskiy ha scritto:
but you shouldn't need it. Just configure your GCC with
--with-sysroot=/foo and it should just work.
--sysroot helps for native compiler but does not for the cross compiler.
That usually points at an incorrect configuration when you
On 04/16/13 13:10, Paolo Bonzini wrote:
I'm happy to say that I'm not touching IOWatchPoll (well, almost: only
for consistency). Instead, these patches try to make the code consistent
(thus avoiding CRITICAL messages from glib) and to fix detection of pty
connections; Gerd reported that it
Paolo Bonzini pbonz...@redhat.com writes:
Moving the inclusions closer to Makefile, and before rules.mak, makes
Makefile and Makefile.target more consistent with each other.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Patch fixes the build with --enable-tpm for me.
Tested-by: Markus
Replace
#pragma GCC diagnostic ignored FOO
[Troublesome code...]
#pragma GCC diagnostic error FOO
by
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored FOO
[Troublesome code...]
#pragma GCC diagnostic pop
Broken in commit 3f4349d, commit 092bb30, and commit
Am 16.04.2013 um 11:00 hat Markus Armbruster geschrieben:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/16/2013 01:55 AM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/15/2013 10:57 PM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 12:54, Alexey Kardashevskiy ha scritto:
but you shouldn't need it. Just configure your GCC with
--with-sysroot=/foo and it should just work.
--sysroot helps for native compiler but does not for the cross compiler.
That usually
Le 16-04-2013 11:50, Peter Maydell a écrit :
On 15 April 2013 16:41,
François Legal francois.le...@thom.fr.eu.org wrote:
I made up this patch
to implement the Cortex A9 global timer in Qemu. My patch is based on the Qemu
branch maintained by Xilinx for the Zynq.
Hi François; thanks for
Kevin Wolf kw...@redhat.com writes:
Am 16.04.2013 um 11:00 hat Markus Armbruster geschrieben:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/16/2013 01:55 AM, Markus Armbruster wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 04/15/2013 10:57 PM, Markus Armbruster wrote:
On 16 April 2013 13:09, François Legal de...@thom.fr.eu.org wrote:
Ugh. Your mail client has completely mangled things (it's
run all the lines of code into each other and it's still
posting as multipart text+HTML). Please could you look at
fixing its configuration -- it makes it hard to reply in
On 04/16/2013 03:48 AM, Kevin Wolf wrote:
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command
replaces a bit too much. Restrict it to the start of the line and to
when it's followed by a colon, i.e. the form used by error messages.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
On 04/16/2013 04:13 AM, Amos Kong wrote:
Eric said String list contains additional JSON structure.
At least, it works.
Using the fat 'String' wrapper works, but requires more effort to decode.
= using StringList
'*unicast':['String'],
'*multicast':
On 04/16/2013 05:51 AM, Markus Armbruster wrote:
Replace
#pragma GCC diagnostic ignored FOO
[Troublesome code...]
#pragma GCC diagnostic error FOO
by
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored FOO
[Troublesome code...]
#pragma GCC
Le 16-04-2013 14:19, Peter Maydell a écrit :
On 16 April 2013 13:09, François Legal de...@thom.fr.eu.org wrote:
Ugh. Your mail client has completely mangled things (it's
run all the lines of code into each other and it's still
posting as multipart text+HTML). Please could you look at
fixing its
On 04/15/2013 10:50 PM, Paolo Bonzini wrote:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
{ 'enum': 'MigrationCapability',
- 'data': ['xbzrle'] }
+ 'data': ['xbzrle', 'chunk_register_destination'] }
x-chunk_register_destination.
Or better, x-rdma_chunk_registration.
Or
Eric Blake ebl...@redhat.com writes:
On 04/16/2013 05:51 AM, Markus Armbruster wrote:
Replace
#pragma GCC diagnostic ignored FOO
[Troublesome code...]
#pragma GCC diagnostic error FOO
by
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored FOO
On Tue, Apr 16, 2013 at 06:26:38AM -0600, Eric Blake wrote:
On 04/16/2013 03:48 AM, Kevin Wolf wrote:
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command
replaces a bit too much. Restrict it to the start of the line and to
when it's followed by a colon, i.e. the form used by
Ping!
-- PMM
On 9 April 2013 12:27, Peter Maydell peter.mayd...@linaro.org wrote:
There is currently only one user of the qdev taddr (target addr,
now hwaddr) property code, and that user is wrong anyway, since the
property it's trying to set isn't actually a taddr property.
Fix the
Pass all the relevant sub-directory make variables.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Cc: Anthony Liguori aligu...@us.ibm.com
Cc: Paul Brook p...@codesourcery.com
---
Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
instrument/qemu-instr/control-internal.h | 16
instrument/qemu-instr/control.h | 61 ++
2 files changed, 77 insertions(+)
diff --git a/instrument/qemu-instr/control-internal.h
Add commandline options to control initial loading of dynamic instrumentation
library.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
bsd-user/main.c | 25 +++
bsd-user/syscall.c |5 ++
instrument/Makefile.objs |2 +
instrument/cmdline.c | 101
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ccf6760..3fc5fb6 100644
--- a/Makefile
+++ b/Makefile
@@ -324,7 +324,29 @@ install-confdir:
install-sysconfig:
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
instrument/Makefile.objs |1
instrument/api-trace.c | 14 +
instrument/qemu-instr/trace-internal.h | 32 +++
instrument/qemu-instr/trace.h | 91
4
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
.gitignore |1
Makefile|1
configure |1
instrument/Makefile.objs| 13 +++
instrument/api-control.c
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile | 11 ++-
libcacard/Makefile |2 +-
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 028ef83..2d3431a 100644
--- a/Makefile
+++ b/Makefile
@@ -171,18 +171,19 @@ Makefile:
Compiles a user-provided static library during QEMU compilation.
This library must provide the implementation of the 'qi_event_*' routines.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.target |2 +
configure | 42
Lets the include directive work regardless of the current directory.
This is needed for code compiled in directories deeper than one level from the
build root.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.target |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Splits the QEMU-side tracing interface into different layers (in order of nested
invocation):
* trace_*
The interface used by QEMU code to signal traceable/instrumentable events
(now generated according to the selected instrumentation type).
* qi_event_*
The interface provided by the
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
docs/instrumentation.txt | 496 ++
docs/tracing.txt |9 +
2 files changed, 505 insertions(+)
create mode 100644 docs/instrumentation.txt
diff --git a/docs/instrumentation.txt
Hi Francois,
On Tue, Apr 16, 2013 at 10:50 PM, François Legal
francois.le...@thom.fr.eu.org wrote:
Le 16-04-2013 14:19, Peter Maydell a écrit :
On 16 April 2013 13:09, François Legal de...@thom.fr.eu.org wrote:
Ugh. Your mail client has completely mangled things (it's
run all the lines of
TODO: Make sure no TCG code is executing during 'instr_unload' (qemu_cpu_kick?
tb_lock?)
The whole set of patch series is available at:
https://projects.gso.ac.upc.edu/projects/qemu-dbi
Adds the instrument event property to declare which tracing events in QEMU
must be instrumentable.
On 04/16/2013 07:16 AM, Stefan Hajnoczi wrote:
+sed -e s#^$(basename $QEMU_PROG):#QEMU_PROG:#g
Why spawn a basename process, when you can use shell to do the same?
The problem with the POSIX shell string replacement is that the syntax
is horrible. I can never remember what ${%}, ${%%},
Am 16.04.2013 12:28, schrieb Amit Shah:
Not handling EAGAIN triggers the assert
qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != -1)
Aborted (core dumped)
This happens when starting a guest with '-device virtio-rng-pci',
issuing a 'cat /dev/hwrng' in the guest,
The header is not necessary, given that the simple backend does not define any
inlined tracing routines.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/simple.py |5 +
trace/simple.c |2 ++
2 files changed, 3 insertions(+), 4
Adds the input(...) primitive to the syntax of QAPI schema files.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/qapi-commands.py | 10 +++---
scripts/qapi-types.py| 10 +++---
scripts/qapi-visit.py| 10 +++---
scripts/qapi.py | 12 +++-
Stefan Hajnoczi stefa...@redhat.com writes:
[...]
The problem with the POSIX shell string replacement is that the syntax
is horrible. I can never remember what ${%}, ${%%}, ${#} and
%{##} do. $(basename $QEMU_PROG) is clear (although it doesn't handle
spaces in the filename!).
Here's how I
This ensures proper naming across tracing backends, even when someone overrides
the value without backends knowing it.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/__init__.py | 10 +-
scripts/tracetool/backend/dtrace.py |6 +++---
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index cf938be..8280273 100644
--- a/Makefile
+++ b/Makefile
@@ -211,13 +211,19 @@ $(SRC_PATH)/qga/qapi-schema.json
Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben:
Now qmp_transaction() can be extended with other operation,
external snapshot or backing chain creation, is just one case it.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
blockdev.c | 68
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.target |1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.target b/Makefile.target
index 114fc39..fe48432 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -149,6 +149,7 @@ include $(SRC_PATH)/Makefile.objs
all-obj-y
Provides a mechanism to dynamically change the routine invoked by 'trace_*'.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
.gitignore |1
Makefile |4 +
Makefile.objs |6 ++
Am 16.04.2013 um 15:16 hat Stefan Hajnoczi geschrieben:
On Tue, Apr 16, 2013 at 06:26:38AM -0600, Eric Blake wrote:
On 04/16/2013 03:48 AM, Kevin Wolf wrote:
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command
replaces a bit too much. Restrict it to the start of the line and
On Mon, 15 Apr 2013 16:25:34 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
As the cpuid_*_features fields will be replaced by an array, put the
level/xlevel/xlevel2 fields together in the struct, as they won't be
close to the corresponding cpuid_*_features fields anymore.
Signed-off-by:
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
docs/instrumentation.txt | 496 ++
docs/tracing.txt |9 +
2 files changed, 505 insertions(+)
create mode 100644 docs/instrumentation.txt
diff --git a/docs/instrumentation.txt
Hi Francois,
On Tue, Apr 16, 2013 at 1:41 AM, François Legal
francois.le...@thom.fr.eu.org wrote:
Hello,
I made up this patch to implement the Cortex A9 global timer in Qemu.
My patch is based on the Qemu branch maintained by Xilinx for the Zynq.
Patches against this tree can be
Add QMP commands to control (un)loading of dynamic instrumentation library.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
include/qapi/qmp/qerror.h |9 +
instrument/Makefile.objs|1 +
instrument/qapi-schema.json | 33
instrument/qmp.c|
TODO: Make sure no TCG code is executing during 'instr_unload' (qemu_cpu_kick?
tb_lock?)
The whole set of patch series is available at:
https://projects.gso.ac.upc.edu/projects/qemu-dbi
Adds the instrument event property to declare which tracing events in QEMU
must be instrumentable.
With this option the user can perform multiple builds of QEMU with different
tracing event properties.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.target |2 +-
configure | 19 +++
trace/Makefile.objs | 10 +-
3 files changed, 25
This interface provides two sets of operations:
* Loading/unloading a trace instrumentation library.
* Controls the instrumentation callbacks of the tracing events.
Note that in the case of static instrumentation, the library is not
loaded/unloaded, but is still properly (de)initialized when
This is libqos support for qtest. A few things are omitted from
the RFC review in order to help get this merged quickly. Notably,
there's still no way to tear down a device (pci_iounmap is hard to
implement well). I haven't attempted to refactor i2c support and
I have not introduced convenience
fw_cfg is needed to get the top of memory which is necessary for
doing PCI allocation and allocating RAM for DMA.
Add a PC version of fw_cfg and enough abstraction to support other
platforms.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 4 ++--
Juan Quintela quint...@redhat.com wrote:
Hi
Please send in any agenda topics you are interested in.
As there are no topics, call is cancelled.
Have a nice week.
Later, Juan.
This problem arises in the following patches.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
hw/virtio/virtio.c|1 +
monitor.c |4 +++-
scripts/tracetool/format/h.py |9 -
trace/control-internal.h |4 +++-
trace/control.c
On Tue, Apr 16, 2013 at 11:43:42AM +0200, Igor Mammedov wrote:
[...]
BTW:
You were advocating using APIC ID on device_add to identify CPU but Eduardo
would like avoid its usage on external interfaces.
It would be nice to have your opinion on subject.
relevant discussion threads are here:
Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben:
The code before really committing is moved into a function. Most
This line seems to be indented accidentally?
code are simply moved from qmp_transaction()i, except fail handling
label is changed from delete_and_fail to fail. Other code
This includes basic PCI support for the PC platform. Enough
abstraction should be present to support non-PC platforms too.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
v1 - v2
- fixup size calculation (Kevin Wolf)
---
configure | 2 +-
tests/Makefile| 5 +-
Add HMP commands to control (un)loading of dynamic instrumentation library.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs|1 +
hmp-commands.hx | 42 +
instrument/Makefile.objs |2 +
instrument/hmp.c | 66
Il 16/04/2013 16:52, Michael R. Hines ha scritto:
So, I should just CC Juan directly after the reviews are finished?
Is that correct?
No big deal, I can Cc him on my reviews too.
Paolo
This lets instrumentation clients in C++ use the auto-generated headers.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/__init__.py | 16 +++-
trace-events |8
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git
On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Add appropriate spaces around operators, and break line where it needs
to be broken to allow feature-words array to be introduced without
having too-long lines.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
On 04/16/2013 08:58 AM, Eric Blake wrote:
On 04/15/2013 10:50 PM, Paolo Bonzini wrote:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
{ 'enum': 'MigrationCapability',
- 'data': ['xbzrle'] }
+ 'data': ['xbzrle', 'chunk_register_destination'] }
x-chunk_register_destination.
Or
Currently we waitpid on the child process we spawn off that does
nothing more than system() another process. While this does not
appear to be incorrect, it's wasteful and confusing so get rid of
it.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/libqtest.c | 11 ---
1 file
Il 16/04/2013 16:32, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0:
virtio-balloon:
On Mon, 15 Apr 2013 16:25:36 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
As the *_features fields are going to be replaced with a features array,
the xlevel xlevel2 fields won't be close to the corresponding
*_features fields anymore.
patch has nothing to do with mentioned *_features.
On Tue, Apr 16, 2013 at 04:23:07PM +0200, Igor Mammedov wrote:
On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Add appropriate spaces around operators, and break line where it needs
to be broken to allow feature-words array to be introduced without
having
This test compares all of the default register values against the
spec. It turns out we deviate in quite a few places. These
places are really only visible to the BIOS though which is why
this hasn't created any problems.
The deviation actually happens in the core PCI layer so I suspect
it's
This tests PAM settings for the i440fx. This test does a lot of
byte MMIO which is fairly slow with qtest today. But the test
does complete in under 2 seconds.
We don't fully emulate PAM largely because of limitations with
KVM so we #if 0 that part of the test case.
Signed-off-by: Anthony
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0:
virtio-balloon: fix dynamic properties. (2013-04-15 17:06:58
This validates some basic characteristics of fw_cfg.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 2 +
tests/fw_cfg-test.c | 141
2 files changed, 143 insertions(+)
create mode 100644 tests/fw_cfg-test.c
This is a very simple allocator for the PC platform. It should
be possible to add backends for other platforms.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 1 +
tests/libqos/malloc-pc.c | 71
On 16 April 2013 15:47, Andreas Färber afaer...@suse.de wrote:
Am 09.04.2013 13:27, schrieb Peter Maydell:
The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.
Actually, it's declared as
DEFINE_PROP_DMAADDR(dma-offset,
On Tue, Apr 16, 2013 at 03:52:14PM +0200, Markus Armbruster wrote:
Stefan Hajnoczi stefa...@redhat.com writes:
[...]
The problem with the POSIX shell string replacement is that the syntax
is horrible. I can never remember what ${%}, ${%%}, ${#} and
%{##} do. $(basename $QEMU_PROG) is
Am 09.04.2013 13:27, schrieb Peter Maydell:
The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.
Actually, it's declared as
DEFINE_PROP_DMAADDR(dma-offset, OHCISysBusState, dma_offset, 3),
which is in turn defined as
On 04/16/2013 10:32 AM, Anthony Liguori wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit 24a6e7f4d91e9ed5f8117ecb083431a23f8609a0:
virtio-balloon: fix
On Tue, Apr 16, 2013 at 04:32:03PM +0200, Igor Mammedov wrote:
On Mon, 15 Apr 2013 16:25:36 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
As the *_features fields are going to be replaced with a features array,
the xlevel xlevel2 fields won't be close to the corresponding
*_features
On Tue, Apr 09, 2013 at 12:27:52PM +0100, Peter Maydell wrote:
The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
hw/display/sm501.c |2 +-
1 file changed, 1
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
The code is moved into preparation function, and is changed
a bit to tip more clearly what it is doing.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
blockdev.c | 38 +++---
1 files changed, 19
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
The code before really committing is moved into a function. Most
code are simply moved from qmp_transaction()i, except fail handling
s/i,/,/
label is changed from delete_and_fail to fail. Other code such
as input parsing is not touched, to make it
Hi Francois,
On Wed, Apr 17, 2013 at 12:06 AM, François Legal
francois.le...@thom.fr.eu.org wrote:
Hi Peter,
Le 16-04-2013 15:23, Peter Crosthwaite a écrit :
Hi Francois,
On Tue, Apr 16, 2013 at 10:50 PM, François Legal
francois.le...@thom.fr.eu.org wrote:
Le 16-04-2013 14:19, Peter
On Mon, 15 Apr 2013 16:25:37 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Break lines so they don't get too long once the *_features fields are
replaced by an array.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 6 --
1 file changed, 4 insertions(+),
On (Tue) 16 Apr 2013 [15:51:30], Andreas Färber wrote:
Am 16.04.2013 12:28, schrieb Amit Shah:
Not handling EAGAIN triggers the assert
qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len !=
-1)
Aborted (core dumped)
This happens when starting a guest with
On Tue, Apr 16, 2013 at 10:49:19AM +0200, Stefan Hajnoczi wrote:
On Mon, Apr 15, 2013 at 10:04:24PM +0200, Lluís Vilanova wrote:
Tried using a list of strings as an argument to a command, but the generated
code references the 'strList' type, which does not exist.
Is a specialized version
On Tue, 16 Apr 2013, Gonglei (Arei) wrote:
Yes, this disk was using EHCI, since guest QEMU and Linux kernel both
prints matching EHCI logs, such as transfer types and transfer sizes.
There are many buck-out URBs whose sizes are 31 or 4064 that are not
multiples of 512. Since URB size
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
The code is simply moved into a separate function.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
blockdev.c | 20 +---
1 files changed, 13 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
In the subject: s/rolling back/rollback/
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
blockdev.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
With the subject fix, feel free to add:
Reviewed-by: Eric Blake
Hi,
Fixing this will require qemu to copy the beginning and ending parts of
these non-aligned qTDs into separate bounce buffers so that the URB
length can be divisible by 512.
Worth trying: http://www.kraxel.org/cgit/qemu/log/?h=usb.80
It puts the qemu usb passthrough code upside down.
On 04/13/2013 05:11 AM, Wenchao Xia wrote:
Now qmp_transaction() can be extended with other operation,
external snapshot or backing chain creation, is just one case it.
This read a bit awkwardly. Might I suggest:
block: use callbacks in qmp_transaction()
Make it easier to add other
Orit Wasserman owass...@redhat.com writes:
On 03/27/2013 06:36 PM, Paolo Bonzini wrote:
This series fixes a few small problems in Orit's writev patches:
1) socket_put_buffer is not needed anymore and can be dropped (patch 1);
2) sendmsg could do a partial write even for a blocking socket,
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 16:32, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit
On Tue, Apr 16, 2013 at 05:18:08PM +0200, Igor Mammedov wrote:
On Mon, 15 Apr 2013 16:25:37 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Break lines so they don't get too long once the *_features fields are
replaced by an array.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
On Mon, 15 Apr 2013 16:25:40 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all feature words (e.g.
FYI: I will send v9 fixing the issues pointed by Igor, soon.
The only difference in the resulting tree should be the indentation
issue on patch 2, all the rest will be just patch merging and commit
message changes.
--
Eduardo
On 04/16/2013 08:45 AM, Anthony Liguori wrote:
This test compares all of the default register values against the
spec. It turns out we deviate in quite a few places. These
places are really only visible to the BIOS though which is why
this hasn't created any problems.
The deviation
101 - 200 of 272 matches
Mail list logo
