Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-21 Thread Gerd Hoffmann
On 04/19/13 10:37, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> Question for the libvirt guys: Is it ok for libvirt to just extend the >> existing screendump command? Can libvirt figure there is a new >> (optional) parameter? See patch #5. > > Nope, QMP can't do that. I argued for s

Re: [Qemu-devel] [PATCH] linux-user: fix compile error due to stray colon at end of #ifdef line

2013-04-21 Thread Riku Voipio
On Sun, Apr 21, 2013 at 01:30:03PM +0100, Peter Maydell wrote: > Remove a stray colon from the end of a #ifdef line. Some versions > of gcc complain about this: > linux-user/syscall.c: In function ‘do_syscall’: > linux-user/syscall.c:7606:28: error: extra tokens at end of #ifdef directive > [-We

[Qemu-devel] ppc64-linux-user broken since "PPC: Unify dcbzl code path" ?

2013-04-21 Thread Riku Voipio
Hi, While testing my linux-user smoke-testing setup, I noticed that with current qemu head: ./ppc64-linux-user/qemu-ppc64 ../../qemu-smoke/ppc64/busybox ls busybox: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) &((av)->bins[((1) - 1) * 2])) - __builtin_offsetof (struct

Re: [Qemu-devel] [PATCH v3 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug

2013-04-21 Thread li guang
ping ... 在 2013-04-16二的 11:53 +0800,liguang写道: > when use DEBUG_DEBUGCON, screen spits: > debugcon: write addr=0x val=0x00 > Rdebugcon: write addr=0x val=0x00 > udebugcon: write addr=0x val=0x00 > ndebugcon: write addr=0x val=0x00 > ndebugcon: write addr=0x val=0x00 > idebugcon

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: implement .bdrv_co_is_allocated

2013-04-21 Thread MORITA Kazutaka
At Thu, 18 Apr 2013 19:48:52 +0800, Liu Yuan wrote: > > +static coroutine_fn int > +sd_co_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors, > + int *pnum) > +{ > +BDRVSheepdogState *s = bs->opaque; > +SheepdogInode *inode = &s->inode; > +unsigned

Re: [Qemu-devel] [RFC PATCH v4 14/15] slirp: handle race condition

2013-04-21 Thread liu ping fan
On Fri, Apr 19, 2013 at 4:21 PM, Jan Kiszka wrote: > On 2013-04-19 02:18, liu ping fan wrote: >> On Thu, Apr 18, 2013 at 3:13 PM, Jan Kiszka wrote: >>> On 2013-04-17 10:39, Liu Ping Fan wrote: From: Liu Ping Fan Slirp and its peer can run on different context at the same time. >>>

[Qemu-devel] [PATCH for-1.5 v3 10/15] xilinx_spips: Fix CTRL register RW bits

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The CTRL register was RAZ/WI on some of the RW bits. Even though the function behind these bits is invalid in QEMU, they should still be guest accessible. Fix. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- changed from v1 Macroified magic number (PMM r

[Qemu-devel] [PATCH for-1.5 v3 15/15] xilinx_spips: lqspi: Fix byte/misaligned access

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The LQSPI bus attachment supports byte/halfword and misaligned accesses. Fixed. Refactored the LQSPI cache to be byte-wise instead of word wise accordingly. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c | 31 +-

[Qemu-devel] [PATCH for-1.5 v3 14/15] xilinx_spips: lqspi: Push more data to tx-fifo

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Do 16 words per fifo flush. Increases performance and decreases debug verbosity. This data depth has no real hardware analogue, so just go with something that has reasonable performance. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spi

[Qemu-devel] [PATCH for-1.5 v3 13/15] xilinx_spips: Multiple debug verbosity levels

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The debug printfs on every SPI operation is extremely verbose. Add a second level of debug for this. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c | 68 +--- 1 files changed, 41 inse

[Qemu-devel] [PATCH for-1.5 v3 12/15] xilinx_spips: Debug msgs for Snoop state

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite This is worth keeping track of when debugging the device model. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips

[Qemu-devel] [PATCH for-1.5 v3 11/15] xilinx_spips: Fix striping behaviour

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The QSPI controller was using byte-wide stripes when striping across the two flashes in dual parallel mode. The real hardware however uses individual bit striping. QEMU misbehaves in the (corner) case where data is written/read in dual-parallel mode and read/written back i

[Qemu-devel] [PATCH for-1.5 v3 09/15] xilinx_spips: lqspi: Dont touch config register

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The LQSPI mode is supposed to work via the automatic CS mode feature rather than manipulate CS lines itself. Now that auto CS is implemented remove LQSPIs CS mode override logic. There is still a need to manipulate the U_PAGE bit in LQSPI config register to implement dual-

[Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Implement the automatic CS control feature. If the MANUAL_CS bit is cleared then the chip select stay de-asserted as long as the tx FIFO is empty. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- changed from v1: Refresh CS on entry and exit from flush ro

[Qemu-devel] [PATCH for-1.5 v3 07/15] xilinx_spips: Add automatic start support

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite SPI has a mode where it automatically starts based on tx fifo occupancy. Implemented. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ssi/xilinx_spips.c

[Qemu-devel] [PATCH for-1.5 v3 06/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Invalidate the LQSPI cached page when transitioning into LQSPI mode. Otherwise there is a possibility that the controller will return stale data to the guest when transitioning back to LQ_MODE after a page program. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Mayd

Re: [Qemu-devel] [PATCH v4] Add option to mlock qemu and guest memory

2013-04-21 Thread Chegu Vinod
Hi Satoru, FYI... I had tried to use this change earlier and it did show some improvements in perf. (due to reduced exits). But as expected mlockall () on large sized guests adds a considerable delay in boot time. For e.g. on an 8 socket Westmere box => a 256G guest : took an additional ~2+

[Qemu-devel] [PATCH for-1.5 v3 05/15] xilinx_spips: Fix QSPI FIFO size

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite QSPI has a bigger FIFO than the regular SPI controller. Differentiate between the two with correct FIFO sizes for each. This is the first piece of class data for SPIPS, so this patch sees the creation of the XilinxSPIPSClass definition and assoicated QOM constructs. Sign

[Qemu-devel] [PATCH for-1.5 v3 04/15] xilinx_spips: Add verbose LQSPI debug output

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite You really need this is you want to track a guest banging on LQSPI. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx

[Qemu-devel] [PATCH for-1.5 v3 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The real hardware does not produce interrupts in LQSPI mode. Inhibit generation of interrupts when the LQ_MODE bit is set. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c |7 ++- 1 files changed, 6 insertions(+), 1 deletio

[Qemu-devel] [PATCH for-1.5 v3 02/15] xilinx_spips: Make interrupts clear on read

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite By default these interrupts are clear on read. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/ssi/xilinx_spips.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 734adf0

[Qemu-devel] [PATCH for-1.5 v3 01/15] xilinx_spips: seperate SPI and QSPI as two classes

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Make SPI and QSPI different classes. QSPIPS is setup as a child of SPIPS. Only QSPI has the LQSPI functionality, so move all that to the child class. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- Changed from v2: User parent_obj as appropriate for QOM

[Qemu-devel] [PATCH for-1.5 v3 00/15] Xilinx SPIPS fixes round 2

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by a number of bugs/incompletnesses found by some (very) rigourous test vectors. changed from v3: Fixed break after goto (PMM review) Peter Crosthwaite (15): xilinx_spips: seperate SPI and QSPI as tw

Re: [Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-21 Thread Peter Crosthwaite
On Fri, Apr 19, 2013 at 8:23 PM, Peter Maydell wrote: > On 19 April 2013 03:06, wrote: >> From: Peter Crosthwaite >> >> Invalidate the LQSPI cached page when transitioning into LQSPI mode. >> Otherwise there is a possibility that the controller will return stale >> data to the guest when transi

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-04-21 Thread Peter Crosthwaite
Hi Paolo, Blue, On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini wrote: > Il 20/04/2013 20:42, Blue Swirl ha scritto: >> This is not entirely correct, I get these errors: >> mingw32: >> CC libfdt/fdt.o >> cc1: warnings being treated as errors >> /src/qemu/dtc/libfdt/fdt.c:1: warning: -fPIC ig

[Qemu-devel] [PATCH RFT for-1.5 v1 2/2] Makefile: Use QEMU_FLAGS for DTC compilation

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Build DTC as QEMU is built. Fixes the issue with mingw build which can't handles DTC's default CFLAGS. Signed-off-by: Peter Crosthwaite --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index c4847aa..385e314 1

[Qemu-devel] [PATCH RFT for-1.5 v1 1/2] Makefile: Don't build shared libfdt

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite The submodule DTC should just build and use DTC as static (the whole motivation for using submod is lack of widespread distro support). The .so causes build failures on some platforms, so adjust the make target to just build the static lib. Signed-off-by: Peter Crosthwai

[Qemu-devel] [PATCH RFT for-1.5 v1 0/2] Fix DTC sub-module issues

2013-04-21 Thread peter . crosthwaite
From: Peter Crosthwaite Two issues reported by Blue for building the DTC submodule with clang and mingw. Peter Crosthwaite (2): Makefile: Don't build shared libfdt Makefile: Use QEMU_FLAGS for DTC compilation Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 0/1 V4] virtio-net: dynamic network offloads configuration

2013-04-21 Thread Rusty Russell
Dmitry Fleytman writes: > Spec patch already inside. > > Sent from my iPad > > On Apr 20, 2013, at 8:04 PM, "Michael S. Tsirkin" wrote: > >> On Fri, Apr 19, 2013 at 10:10:01AM +0300, Dmitry Fleytman wrote: >>> Hello All, >>> >>> Any news regarding this patch? >>> >>> Thanks, >>> Dmitry >> >> R

[Qemu-devel] [PATCH 04/12] target-i386/helper: remove EDX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/int_helper.c | 24 target-i386/mem_helper.c |8 target-i386/misc_helper.c |8 target-i386/seg_helper.c |8 target-i386/smm_helper.c |8 6

[Qemu-devel] [PATCH 01/12] target-i386/helper: remove EAX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 - target-i386/int_helper.c | 62 ++-- target-i386/mem_helper.c |8 +++--- target-i386/misc_helper.c | 10 +++--- target-i386/seg_helper.c |8 +++--- target-i386/smm_helper.c |8

[Qemu-devel] [PATCH 09/12] target-i386/helper: remove EIP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/excp_helper.c |2 +- target-i386/misc_helper.c |4 ++-- target-i386/seg_helper.c | 24 target-i386/svm_helper.c | 16 5 files changed, 23 insertions(+), 25 deletions

[Qemu-devel] [PATCH 06/12] target-i386/helper: remove ESP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 - target-i386/seg_helper.c | 80 +++-- target-i386/smm_helper.c |8 ++-- target-i386/svm_helper.c |8 ++-- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/target-i386/cpu

[Qemu-devel] [PATCH 03/12] target-i386/helper: remove ECX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c | 44 ++-- target-i386/seg_helper.c | 18 +- target-i386/smm_helper.c |8 target-i386/svm_hel

[Qemu-devel] [PATCH 03/12] target-i386/helper: remove ECX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c | 44 ++-- target-i386/seg_helper.c | 18 +- target-i386/smm_helper.c |8 target-i386/svm_hel

[Qemu-devel] [PATCH 08/12] target-i386/helper: remove EDI macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index a7c73bf..23166d1 100644 --- a/target-i386/cpu

[Qemu-devel] [PATCH 07/12] target-i386/helper: remove ESI macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 9d52939..a7c73bf 100644 --- a/target-i386/cpu

[Qemu-devel] [PATCH 11/12] target-i386/helper: remove redundant env->eip assignment

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/svm_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/svm_helper.c b/target-i386/svm_helper.c index 649be02..e18fa35 100644 --- a/target-i386/svm_helper.c +++ b/target-i386/svm_helper.c @@ -249,7 +249,7 @@ void he

[Qemu-devel] [PATCH 10/12] target-i386/helper: remove DF macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- cpu-exec.c |4 ++-- target-i386/cc_helper.c |2 +- target-i386/cpu.h |6 ++ 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 31c089d..ec46380 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -230,

[Qemu-devel] [PATCH 2/2] target-i386/seg_helper: define names for code/data segment types

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/seg_helper.c | 71 + 1 files changed, 52 insertions(+), 19 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 419efd8..6b35b7c 100644 --- a/target-i386/seg_helper.c +++ b/target-

[Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-04-21 Thread liguang
for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang --- target-i386/seg_helper.c | 179 ++--- 1 files changed, 56 insertions(+), 123 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 00/12] target-i386: remove some macros

2013-04-21 Thread li guang
sorry, please see new 12 patches, for previous sent patches have little manual-changed errors. 在 2013-04-22一的 11:37 +0800,liguang写道: > remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > as suggested by Richard Henderson > > Li Guang (12) >target-i386/helper: remove EAX macro

Re: [Qemu-devel] [PATCH] sheepdog: implement .bdrv_co_is_allocated

2013-04-21 Thread Liu Yuan
On 04/18/2013 07:48 PM, Liu Yuan wrote: > Cc: MORITA Kazutaka > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > NOTE: This patch based on the previous discard patch sheepdog: add > discard/trim support for sheepdog Ping... This is a relatively simple patch, anyone help

[Qemu-devel] [PATCH 08/12] target-i386/helper: remove EDI macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index a7c73bf..23166d1 100644 --- a/target-i386/cpu

[Qemu-devel] [PATCH 01/12] target-i386/helper: remove EAX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 - target-i386/int_helper.c | 62 ++-- target-i386/mem_helper.c |8 +++--- target-i386/misc_helper.c | 10 +++--- target-i386/seg_helper.c |8 +++--- target-i386/smm_helper.c |8

[Qemu-devel] [PATCH 06/12] target-i386/helper: remove ESP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 - target-i386/seg_helper.c | 80 +++-- target-i386/smm_helper.c |8 ++-- target-i386/svm_helper.c |8 ++-- 4 files changed, 49 insertions(+), 49 deletions(-) diff --git a/target-i386/cpu

[Qemu-devel] [PATCH 00/12] target-i386: remove some macros

2013-04-21 Thread liguang
remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX macro target-i386/helper: remove ECX macro target-i386/helper: remove EDX macro

[Qemu-devel] [PATCH 09/12] target-i386/helper: remove EIP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/excp_helper.c |2 +- target-i386/misc_helper.c |4 ++-- target-i386/seg_helper.c | 24 target-i386/svm_helper.c | 16 5 files changed, 23 insertions(+), 25 deletions

[Qemu-devel] [PATCH 02/12] target-i386/helper: remove EBX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c |2 +- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 5 files changed, 10 insertions(+), 12 deletions(-) diff --git a/target-i

[Qemu-devel] [PATCH 12/12] target-i386: fix over 80 chars warnings

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/misc_helper.c | 39 ++- target-i386/seg_helper.c | 16 +--- target-i386/svm_helper.c |6 -- 3 files changed, 39 insertions(+), 22 deletions(-) diff --git a/target-i386/misc_helper.c b/target-i386

[Qemu-devel] [PATCH 00/122] target-i386: remove some macros

2013-04-21 Thread liguang
remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX macro target-i386/helper: remove ECX macro target-i386/helper: remove EDX macro

[Qemu-devel] [PATCH 12/12] target-i386: fix over 80 chars warnings

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/misc_helper.c | 39 ++- target-i386/seg_helper.c | 16 +--- target-i386/svm_helper.c |6 -- 3 files changed, 39 insertions(+), 22 deletions(-) diff --git a/target-i386/misc_helper.c b/target-i386

[Qemu-devel] [PATCH 10/12] target-i386/helper: remove DF macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- cpu-exec.c |4 ++-- target-i386/cc_helper.c |2 +- target-i386/cpu.h |6 ++ 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 31c089d..ec46380 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -230,

[Qemu-devel] [PATCH 05/12] target-i386/helper: remove EBP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c | 10 +- target-i386/smm_helper.c |8 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 78d1033..f2c4a49 100644 --- a/target-i38

[Qemu-devel] [PATCH 04/12] target-i386/helper: remove EDX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/int_helper.c | 24 target-i386/mem_helper.c |8 target-i386/misc_helper.c |8 target-i386/seg_helper.c |8 target-i386/smm_helper.c |8 6

[Qemu-devel] [PATCH 00/11] target-i386: remove some macros

2013-04-21 Thread liguang
remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX macro target-i386/helper: remove ECX macro target-i386/helper: remove EDX macro

[Qemu-devel] [PATCH 11/12] target-i386/helper: remove redundant env->eip assignment

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/svm_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/svm_helper.c b/target-i386/svm_helper.c index 649be02..e18fa35 100644 --- a/target-i386/svm_helper.c +++ b/target-i386/svm_helper.c @@ -249,7 +249,7 @@ void he

[Qemu-devel] [PATCH 07/12] target-i386/helper: remove ESI macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 9d52939..a7c73bf 100644 --- a/target-i386/cpu

[Qemu-devel] [PATCH 05/12] target-i386/helper: remove EBP macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h|2 -- target-i386/seg_helper.c | 10 +- target-i386/smm_helper.c |8 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 78d1033..f2c4a49 100644 --- a/target-i38

[Qemu-devel] [PATCH 02/12] target-i386/helper: remove EBX macro

2013-04-21 Thread liguang
Signed-off-by: liguang --- target-i386/cpu.h |2 -- target-i386/mem_helper.c |4 ++-- target-i386/misc_helper.c |2 +- target-i386/seg_helper.c |6 +++--- target-i386/smm_helper.c |8 5 files changed, 10 insertions(+), 12 deletions(-) diff --git a/target-i

[Qemu-devel] [PATCH 00/11] target-i386: remove some macros

2013-04-21 Thread liguang
remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX macro target-i386/helper: remove ECX macro target-i386/helper: remove EDX macro

Re: [Qemu-devel] [PATCH V12 00/18] qmp/hmp interfaces for internal snapshot info

2013-04-21 Thread Wenchao Xia
Hi, Any other comments for it, especially HMP part? > > V12: >Address Markus's comments: >02/18: better incode comments for bdrv_snapshot_find(), add tip about the > logic change in snapshot create/delete/load/info if some snapshot's id is > mixed > with name in commit message. >05/

Re: [Qemu-devel] [PATCH V13 0/6] replace QEMUOptionParameter with QemuOpts parser

2013-04-21 Thread Dong Xu Wang
On 2013/4/10 14:25, Dong Xu Wang wrote: These patches will replace QEMUOptionParameter with QemuOpts. Change logs please go to each patch's commit message. Dong Xu Wang (6): add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print avoid duplication of default value in QemuOpts

[Qemu-devel] [PATCH v2 4/5] vmdk: change magic number to macro

2013-04-21 Thread Fam Zheng
Two hard coded flag bits are changed to macros. Signed-off-by: Fam Zheng --- block/vmdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index d8c6c70..632689b 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -32,6 +32,7 @@ #define VMDK3_MAGIC ((

[Qemu-devel] [PATCH v2 3/5] vmdk: Add option to create zeroed-grain image

2013-04-21 Thread Fam Zheng
Add image create option "zeroed-grain" to enable zeroed-grain GTE feature of vmdk sparse extents. When this option is on, header version of newly created extent will be 2 and VMDK4_FLAG_ZG flag bit will be set. Signed-off-by: Fam Zheng --- block/vmdk.c | 22 +- 1 file changed,

[Qemu-devel] [PATCH v2 1/5] vmdk: named return code.

2013-04-21 Thread Fam Zheng
Internal routines in vmdk.c previously return -1 on error and 0 on success. More return values are useful for future changes such as zeroed-grain GTE. Change all the magic `return 0` and `return -1` to macro names: * VMDK_OK 0 * VMDK_ERROR (-1) * VMDK_UNALLOC (-2) * VMDK_ZEROED (-3) S

[Qemu-devel] [PATCH v2 5/5] vmdk: add bdrv_co_write_zeroes

2013-04-21 Thread Fam Zheng
Use special offset to write zeroes efficiently, when zeroed-grain GTE is available. If zero-write an allocated cluster, cluster is leaked because its offset pointer is overwritten by "0x1". Signed-off-by: Fam Zheng --- block/vmdk.c | 82 ++-

[Qemu-devel] [PATCH v2 2/5] vmdk: add support for “zeroed‐grain” GTE

2013-04-21 Thread Fam Zheng
Introduced support for zeroed-grain GTE, as specified in Virtual Disk Format 5.0[1]. Recent VMware hosted platform products support a new “zeroed‐grain” grain table entry (GTE). The zeroed‐grain GTE returns all zeros on read. In other words, the zeroed‐grain GTE indicates that a grain

[Qemu-devel] [PATCH v2 0/5] vmdk: zeroed-grain GTE support

2013-04-21 Thread Fam Zheng
Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. [1] Virtual Disk Format 5.0 - VMware, http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Changes since v1: - all: fix From: field - 1/5: squash one line of ret code macro change from 2/5 - 2/5

[Qemu-devel] [Bug 1171211] [NEW] Qemu-kvm 1.4.0 q35 no bootable device

2013-04-21 Thread commiethebeastie
Public bug reported: I tried launch iso and raw images in qemu-kvm-1.4.0 with seabios-1.7.2 (and seabios-git) with this options: qemu-system-x86_64 -M q35 -smp 8,cores=8 -vga qxl -cpu host -enable-kvm -m 4096 -localtime -cdrom "/home/user/media/iso/windows7x86_64.iso" -drive file=/home/user/media

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-21 Thread Andreas Färber
Peter, Am 21.04.2013 11:54, schrieb Peter Maydell: > Early ping for compile-breakage fix patch (ccing Blue this time > round since you've been applying patches this weekend.) > > Patchwork url: http://patchwork.ozlabs.org/patch/237347/ Even after this has been applied, things are still not build

[Qemu-devel] [PATCH v5 12/12] rdma: send pc.ram

2013-04-21 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines --- arch_init.c | 35 +++

[Qemu-devel] [PATCH v5 01/12] rdma: add documentation

2013-04-21 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 404 + 1 file changed, 404 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PATCH v5 06/12] rdma: export qemu_fflush()

2013-04-21 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v5 07/12] rdma: introduce ram_handle_compressed()

2013-04-21 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Signed-off-by: Michael R. Hines --- arch_init.c | 24 include/migration/migration.h |2 ++ 2 files changed, 18

[Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-21 Thread mrhines
From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch - good progress. This file includes the entire protocol and interfaces required to perform RDMA migration. Also, the configure and Make

[Qemu-devel] [PATCH v5 08/12] rdma: introduce qemu_ram_foreach_block()

2013-04-21 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |5

[Qemu-devel] [PATCH v5 10/12] rdma: introduce capability x-rdma-pin-all

2013-04-21 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps infiniband link: 1.

[Qemu-devel] [PATCH v5 05/12] rdma: introduce qemu_file_mode_is_not_valid()

2013-04-21 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c | 20 +--- 2 files changed, 14 insertions(+),

[Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-21 Thread mrhines
From: "Michael R. Hines" Changes since v4: - Added new QEMUFileOps function: qemu_get_max_size() - Renamed capability to x-pin-all, disabled by default - Added numbers for x-pin-all to performance section in docs/rdma.txt - Included performance numbers in this cover letter - Converted throughput

[Qemu-devel] [PATCH v5 04/12] rdma: introduce qemu_get_max_size()

2013-04-21 Thread mrhines
From: "Michael R. Hines" This functions allows you to perform your own per-QEMUFileOps calculation for the value of 'max_size'. For RDMA, this calculation artificially limits migration throughput and needs to be done differently for high-throughput links. Signed-off-by: Michael R. Hines --- i

[Qemu-devel] [PATCH v5 03/12] rdma: export throughput w/ MigrationStats QMP

2013-04-21 Thread mrhines
From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. By itself, this patch only prints zero and the value is actually calculated in the next patch. Signed-off-by: Michael R. Hines --- hmp.c |2 ++ include/migration/qemu-file.h |2 ++

[Qemu-devel] [PATCH v5 09/12] rdma: new QEMUFileOps hooks

2013-04-21 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v3 10/24] instrument: [dynamic] Call dynamically linked user-provided routines

2013-04-21 Thread Lluís Vilanova
Provides a mechanism to dynamically change the routine invoked by 'trace_*'. Signed-off-by: Lluís Vilanova --- .gitignore |1 Makefile |4 + Makefile.objs |6 ++ configure

Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration

2013-04-21 Thread Michael R. Hines
On 04/21/2013 02:59 PM, Michael S. Tsirkin wrote: On Sun, Apr 21, 2013 at 12:05:08PM -0400, Michael R. Hines wrote: On 04/21/2013 09:19 AM, Paolo Bonzini wrote: Il 20/04/2013 19:02, Michael S. Tsirkin ha scritto: I guess the opposite sense could be named 'x-rdma-pin-all'; default false means t

[Qemu-devel] [PATCH v3 11/24] qapi: Add a primitive to include other files from a QAPI schema file

2013-04-21 Thread Lluís Vilanova
Adds the "include(...)" primitive to the syntax of QAPI schema files. Signed-off-by: Lluís Vilanova --- scripts/qapi-commands.py | 10 +++--- scripts/qapi-types.py| 10 +++--- scripts/qapi-visit.py| 10 +++--- scripts/qapi.py | 12 +++- 4 files change

[Qemu-devel] [PATCH v3 23/24] instrument: Install headers for dynamic instrumentation clients

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ccf6760..3fc5fb6 100644 --- a/Makefile +++ b/Makefile @@ -324,7 +324,29 @@ install-confdir: install-sysconfig: install-datadir insta

[Qemu-devel] [PATCH v3 20/24] instrument: Add client-side API to control tracing state of events

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs |1 instrument/api-trace.c | 14 + instrument/qemu-instr/trace-internal.h | 32 +++ instrument/qemu-instr/trace.h | 91 4 files changed, 138 in

[Qemu-devel] [PATCH v3 19/24] instrument: Add client-side API to enumerate events

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- .gitignore |1 Makefile|1 configure |1 instrument/Makefile.objs| 13 +++ instrument/api-control.c|

[Qemu-devel] [PATCH v3 16/24] instrument: [hmp] Add control interface

2013-04-21 Thread Lluís Vilanova
Add HMP commands to control (un)loading of dynamic instrumentation library. Signed-off-by: Lluís Vilanova --- Makefile.objs|1 + hmp-commands.hx | 42 instrument/Makefile.objs |1 + instrument/hmp.c | 79 ++

[Qemu-devel] [PATCH v3 14/24] instrument: Add internal control interface

2013-04-21 Thread Lluís Vilanova
This interface provides two sets of operations: * Loading/unloading a trace instrumentation library. * Controls the instrumentation callbacks of the tracing events. Note that in the case of static instrumentation, the library is not loaded/unloaded, but is still properly (de)initialized when QEM

Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration

2013-04-21 Thread Michael S. Tsirkin
On Sun, Apr 21, 2013 at 01:19:17PM -0400, Michael R. Hines wrote: > On 04/21/2013 10:17 AM, Michael S. Tsirkin wrote: > >On Sun, Apr 21, 2013 at 03:19:21PM +0200, Paolo Bonzini wrote: > >>Il 20/04/2013 19:02, Michael S. Tsirkin ha scritto: > >I guess the opposite sense could be named 'x-rdma-pi

[Qemu-devel] [PATCH v3 13/24] qapi: [trivial] Allow user to use 'args' as an argument name

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/qapi-commands.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index fa16651..236a6ae 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-commands.py @@ -207,7 +207,

[Qemu-devel] [PATCH v3 17/24] Let makefiles add entries to the set of target architecture objects

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.target |1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.target b/Makefile.target index 114fc39..fe48432 100644 --- a/Makefile.target +++ b/Makefile.target @@ -149,6 +149,7 @@ include $(SRC_PATH)/Makefile.objs all-obj-y = $(obj-y) all-obj

[Qemu-devel] [PATCH v3 09/24] build: Add variable 'tools-obj-y' for tool-only files

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile | 11 ++- libcacard/Makefile |2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 028ef83..2d3431a 100644 --- a/Makefile +++ b/Makefile @@ -171,18 +171,19 @@ Makefile: $(version-obj-y)

[Qemu-devel] [PATCH v3 15/24] instrument: [qmp, qapi] Add control interface

2013-04-21 Thread Lluís Vilanova
Add QMP commands to control (un)loading of dynamic instrumentation library. Signed-off-by: Lluís Vilanova --- instrument/Makefile.objs|2 + instrument/control.h|4 + instrument/qapi-schema.json | 124 +++ instrument/qmp.c|

[Qemu-devel] [PATCH v3 24/24] trace: Do not use the word 'new' in event arguments

2013-04-21 Thread Lluís Vilanova
This lets instrumentation clients in C++ use the auto-generated headers. Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 16 +++- trace-events |8 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/scripts/tracetool/__ini

[Qemu-devel] [PATCH v3 05/24] trace: Minimize inclusions of "qemu-common.h" to avoid inclusion loops

2013-04-21 Thread Lluís Vilanova
This problem arises in the following patches. Signed-off-by: Lluís Vilanova --- hw/virtio/virtio.c|1 + monitor.c |4 +++- scripts/tracetool/format/h.py |9 - trace/control-internal.h |4 +++- trace/control.c |4 +++-

[Qemu-devel] [PATCH v3 12/24] qapi: [trivial] Set the input root directory when parsing QAPI files

2013-04-21 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index cf938be..8280273 100644 --- a/Makefile +++ b/Makefile @@ -211,13 +211,19 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.p

[Qemu-devel] [PATCH v3 04/24] tracetool: Use method 'Event.api' to get the name of public routines

2013-04-21 Thread Lluís Vilanova
This ensures proper naming across tracing backends, even when someone overrides the value without backends knowing it. Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 10 +- scripts/tracetool/backend/dtrace.py |6 +++--- scripts/tracetool/backend/simple.py |

  1   2   >