Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: implement .bdrv_co_is_allocated

2013-04-22 Thread MORITA Kazutaka
At Thu, 18 Apr 2013 19:48:52 +0800, Liu Yuan wrote: +static coroutine_fn int +sd_co_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors, + int *pnum) +{ +BDRVSheepdogState *s = bs-opaque; +SheepdogInode *inode = s-inode; +unsigned long start

Re: [Qemu-devel] [PATCH v3 1/3] debugcon: fix always print addr=0x0, val=0x0 bug

2013-04-22 Thread li guang
ping ... 在 2013-04-16二的 11:53 +0800,liguang写道: when use DEBUG_DEBUGCON, screen spits: debugcon: write addr=0x val=0x00 Rdebugcon: write addr=0x val=0x00 udebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 idebugcon:

[Qemu-devel] ppc64-linux-user broken since PPC: Unify dcbzl code path ?

2013-04-22 Thread Riku Voipio
Hi, While testing my linux-user smoke-testing setup, I noticed that with current qemu head: ./ppc64-linux-user/qemu-ppc64 ../../qemu-smoke/ppc64/busybox ls busybox: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) ((av)-bins[((1) - 1) * 2])) - __builtin_offsetof (struct

Re: [Qemu-devel] [PATCH] linux-user: fix compile error due to stray colon at end of #ifdef line

2013-04-22 Thread Riku Voipio
On Sun, Apr 21, 2013 at 01:30:03PM +0100, Peter Maydell wrote: Remove a stray colon from the end of a #ifdef line. Some versions of gcc complain about this: linux-user/syscall.c: In function ‘do_syscall’: linux-user/syscall.c:7606:28: error: extra tokens at end of #ifdef directive

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify extent screendump monitor command

2013-04-22 Thread Gerd Hoffmann
On 04/19/13 10:37, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: Question for the libvirt guys: Is it ok for libvirt to just extend the existing screendump command? Can libvirt figure there is a new (optional) parameter? See patch #5. Nope, QMP can't do that. I

[Qemu-devel] [PATCH v2 0/2] implement .bdrv_co_is_allocated

2013-04-22 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com v2: - correct 'end' calculation - get the longest unallocated area - replace SECTOR_SIZE with BDRV_SECTOR_SIZE PATCH 1/2 is ia prepare patch PATCH 2/2 implement .bdrv_co_is_allocated Liu Yuan (2): sheepdog: use BDRV_SECTOR_SIZE sheepdog: implement

[Qemu-devel] [PATCH v2 1/2] sheepdog: use BDRV_SECTOR_SIZE

2013-04-22 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com --- block/sheepdog.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v2 2/2] sheepdog: implement .bdrv_co_is_allocated()

2013-04-22 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com --- block/sheepdog.c | 36 1 file changed, 36

Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: implement .bdrv_co_is_allocated

2013-04-22 Thread Liu Yuan
On 04/22/2013 02:01 PM, MORITA Kazutaka wrote: It looks better to use BDRV_SECTOR_SIZE . I'd suggest preparing another patch to replace all the SECTOR_SIZE with BDRV_SECTOR_SIZE. Okay + end = start + (nb_sectors * SECTOR_SIZE) / SD_DATA_OBJ_SIZE; Using 'start' to

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify extent screendump monitor command

2013-04-22 Thread Gerd Hoffmann
On 04/18/13 17:34, Eric Blake wrote: On 04/18/2013 09:21 AM, Luiz Capitulino wrote: Question for the libvirt guys: Is it ok for libvirt to just extend the existing screendump command? Can libvirt figure there is a new (optional) parameter? See patch #5. So yes, I think libvirt will be

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-04-22 Thread Amos Kong
On Sat, Apr 20, 2013 at 10:06:28AM -0600, Eric Blake wrote: On 04/18/2013 10:44 PM, Amos Kong wrote: (qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and delay sometime, then send one up event. In this case, only key can be identified by guest.

[Qemu-devel] [PATCH] translate-all: fix compiler warning and linked error

2013-04-22 Thread Alexey Kardashevskiy
The code did use profile_getclock() but did not include include/qemu/timer.h where this function is defined. The patch fixes this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- The exact warning and error messages are: /home/alexey/pcipassthru/qemu-impreza/translate-all.c:150:5:

Re: [Qemu-devel] [RFC PATCH v4 01/15] util: introduce gsource event abstration

2013-04-22 Thread liu ping fan
On Fri, Apr 19, 2013 at 7:59 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, Apr 19, 2013 at 02:52:08PM +0800, liu ping fan wrote: On Thu, Apr 18, 2013 at 10:01 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Apr 17, 2013 at 04:39:10PM +0800, Liu Ping Fan wrote: +static gboolean

Re: [Qemu-devel] [RFC PATCH v4 06/15] net: port socket to GSource

2013-04-22 Thread liu ping fan
On Fri, Apr 19, 2013 at 8:03 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, Apr 19, 2013 at 01:58:40PM +0800, liu ping fan wrote: On Thu, Apr 18, 2013 at 10:34 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Apr 17, 2013 at 04:39:15PM +0800, Liu Ping Fan wrote: I'm a little

[Qemu-devel] [PATCH 0/3 QEMU v4] vfio on ppc64

2013-04-22 Thread Alexey Kardashevskiy
Yes, we are still tuning this stuff for us :) Changes: * new spapr-pci-vfio-host-bridge device is introduced (inherits from spapr-pci-host-bridge); * device#1-group-container-device#2,.. creation scheme is changed to group-container-devices scheme (on ppc64); * removed

[Qemu-devel] [PATCH 1/3] vfio: make some of VFIO API public

2013-04-22 Thread Alexey Kardashevskiy
The patch makes vfio_dma_map/vfio_dma_unmap functions public for explicit use by VFIO clients rather that just being called from MemoryListener. The patch also adds a connect parameter to the vfio_get_group() function to allow control over group and container creation and connection before any

[Qemu-devel] [PATCH 3/3] spapr vfio: add spapr-pci-vfio-host-bridge to support vfio

2013-04-22 Thread Alexey Kardashevskiy
The patch adds a spapr-pci-vfio-host-bridge device type which is a PCI Host Bridge with VFIO support. The new device inherits from the spapr-pci-host-bridge device and adds the following properties: iommu - IOMMU group ID which represents a Partitionable Endpoint,

[Qemu-devel] [PATCH 2/3] vfio: add support for spapr platform (powerpc64 server)

2013-04-22 Thread Alexey Kardashevskiy
The existing code assumes that containers are capable of multiple groups support which is not the case for POWERPC64 where groups are defined by the hardware configuration and cannot share one container. The earlier proposal for PPC64 support was: - spapr_phb_vfio_init(): create a

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-04-22 Thread Amos Kong
On Mon, Apr 22, 2013 at 03:32:52PM +0800, Amos Kong wrote: On Sat, Apr 20, 2013 at 10:06:28AM -0600, Eric Blake wrote: On 04/18/2013 10:44 PM, Amos Kong wrote: (qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and delay sometime, then send one up

Re: [Qemu-devel] [PATCH] mainloop.c: Keep unlocking BQL during busy-wait spin-out

2013-04-22 Thread Peter Lieven
On 21.04.2013 16:21, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 5:01 PM, Peter Lieven lieven-li...@dlhnet.de wrote: On 18.04.2013 16:35, Peter Crosthwaite wrote: Hi Peter, On Fri, Apr 19, 2013 at 12:22 AM, Peter Lieven lieven-li...@dlhnet.de wrote: On 15.04.2013 15:08,

Re: [Qemu-devel] [PATCH V13 0/6] replace QEMUOptionParameter with QemuOpts parser

2013-04-22 Thread Markus Armbruster
Dong Xu Wang wdon...@linux.vnet.ibm.com writes: On 2013/4/10 14:25, Dong Xu Wang wrote: These patches will replace QEMUOptionParameter with QemuOpts. Change logs please go to each patch's commit message. Dong Xu Wang (6): add def_value_str in QemuOptDesc struct and rewrite

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-22 Thread Gerd Hoffmann
On 04/18/13 18:58, Sriram Murthy wrote: Some updates on this - I changed the PCI Device ID and Vendor ID in hw/vga.c, and was able to get the VirtualBox SVGA card driver installed in WinXP running on KVM. However, when I try to change the resolution, KVM crashes with a SIGFPE in

[Qemu-devel] [PATCH] ui/input.c: replace magic numbers by macros

2013-04-22 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com --- It's based on http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg03822.html --- ui/input.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ui/input.c b/ui/input.c index 143c421..fac5d6d 100644 ---

Re: [Qemu-devel] [PATCH V12 00/18] qmp/hmp interfaces for internal snapshot info

2013-04-22 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: Hi, Any other comments for it, especially HMP part? In my review queue.

Re: [Qemu-devel] [PATCH 1/2 v3] [S390-KVM] Regsync: Allow selective runtime register synchronization

2013-04-22 Thread Christian Borntraeger
On 11/03/13 18:58, Jason J. Herne wrote: We want to avoid expensive register synchronization IOCTL's on the hot path so a new kvm_s390_get_registers_partial() is introduced as a compliment to kvm_arch_get_registers(). The new function is called on the hot path, and kvm_arch_get_registers() is

Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 06:45, Peter Crosthwaite ha scritto: Hi Paolo, Blue, On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 20/04/2013 20:42, Blue Swirl ha scritto: This is not entirely correct, I get these errors: mingw32: CC libfdt/fdt.o cc1: warnings being

Re: [Qemu-devel] [PATCH] translate-all: fix compiler warning and linked error

2013-04-22 Thread Peter Maydell
On 22 April 2013 08:42, Alexey Kardashevskiy a...@ozlabs.ru wrote: The code did use profile_getclock() but did not include include/qemu/timer.h where this function is defined. The patch fixes this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 2/2 v3] [S390-KVM] Regsync: Utilize selective runtime reg sync for hot code paths

2013-04-22 Thread Christian Borntraeger
On 11/03/13 18:58, Jason J. Herne wrote: Make use of new kvm_s390_get_registers_partial() for kvm_handle_css_inst() and handle_hypercall() since they only need registers from the partial set and they are called quite frequently. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com ---

Re: [Qemu-devel] [PATCH v5 07/19] tcg-arm: Handle constant arguments to add2/sub2

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:53PM -0700, Richard Henderson wrote: We get to re-use the _rIN and _rIK subroutines to handle the various combinations of add vs sub. Fold the 21 into the opcode enum values so that we can explicitly add TO_CPSR as desired. Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v5 08/19] tcg-arm: Improve constant generation

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:54PM -0700, Richard Henderson wrote: Try fully rotated arguments to mov and mvn before trying movt or full decomposition. Begin decomposition with mvn when it looks like it'll help. Examples include -:mov r9, #0x0fa0 -:orr r9, r9,

Re: [Qemu-devel] [PATCH v5 13/19] tcg-arm: Cleanup multiply subroutines

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:59PM -0700, Richard Henderson wrote: Make the code more readable by only having one copy of the magic numbers, swapping registers as needed prior to that. Speed the compiler by not applying the rd == rn avoidance for v6 or later. Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v5 10/19] tcg-arm: Implement division instructions

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:56PM -0700, Richard Henderson wrote: An armv7 extension implements division, present on Cortex A15. Signed-off-by: Richard Henderson r...@twiddle.net --- disas/arm.c | 4 tcg/arm/tcg-target.c | 36

Re: [Qemu-devel] [PATCH v5 11/19] tcg-arm: Use TCG_REG_TMP name for the tcg temporary

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:57PM -0700, Richard Henderson wrote: Don't hard-code R8. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 122 ++- 1 file changed, 62 insertions(+), 60 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 12/19] tcg-arm: Use R12 for the tcg temporary

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:58PM -0700, Richard Henderson wrote: R12 is call clobbered, while R8 is call saved. This change gives tcg one more call saved register for real data. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v5 09/19] tcg-arm: Implement deposit for armv7

2013-04-22 Thread Aurelien Jarno
On Sun, Apr 21, 2013 at 05:58:33PM +0100, Richard Henderson wrote: On 2013-04-21 11:35, Aurelien Jarno wrote: Wouldn't it be better to only declare the zero constraint (using bfc in that case), and let the middle-end to load the constant in other cases? Possibly. I wondered if the work of

[Qemu-devel] [PATCH RFC 0/3] virtio-ccw: Add notifiers support.

2013-04-22 Thread Cornelia Huck
So here's my current patchset for adding guest/host notifiers in virtio-ccw. The ioeventfd support for s390 in the Linux kernel is not yet upstream (still queued), so the first patch just adds the relevant header changes. Patches can also be found at git://github.com/cohuck/qemu

[Qemu-devel] [PATCH RFC 1/3] linux-headers: Update with ioeventfd changes.

2013-04-22 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- linux-headers/linux/kvm.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index caca979..eb02d8a 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@

[Qemu-devel] [PATCH RFC 2/3] virtio-ccw: Wire up ioeventfd.

2013-04-22 Thread Cornelia Huck
On hosts that support ioeventfd, make use of it for host-to-guest notifications via diagnose 500. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/css.c|2 +- hw/s390x/css.h|1 + hw/s390x/virtio-ccw.c | 113

[Qemu-devel] [PATCH RFC 3/3] virtio-ccw: Wire up guest and host notifies.

2013-04-22 Thread Cornelia Huck
Guest and host notifiers are needed by vhost. We use ioeventfds for the guest notifiers, but need to fall back on qemu injecting interrupts for the host notifiers. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/virtio-ccw.c | 90

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 10:09, Amos Kong ha scritto: On Mon, Apr 22, 2013 at 03:32:52PM +0800, Amos Kong wrote: On Sat, Apr 20, 2013 at 10:06:28AM -0600, Eric Blake wrote: On 04/18/2013 10:44 PM, Amos Kong wrote: (qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify extent screendump monitor command

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 08:55, Gerd Hoffmann ha scritto: Question for the libvirt guys: Is it ok for libvirt to just extend the existing screendump command? Can libvirt figure there is a new (optional) parameter? See patch #5. Nope, QMP can't do that. I argued for such capabilities, but the

[Qemu-devel] [PATCH v2 14/15] block: Remove filename parameter from .bdrv_file_open()

2013-04-22 Thread Kevin Wolf
It is unused now in all block drivers. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- v2: - Added a hunk for the new ssh block driver --- block.c | 8 ++-- block/blkdebug.c | 3 +-- block/blkverify.c | 3 +--

Re: [Qemu-devel] [PATCH 07/16] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-22 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:12:47AM +0200, Igor Mammedov wrote: get_arch_id() adds possibility for generic code to get guest visible CPU ID without accessing CPUArchState. If target doesn't override it, it will return cpu_index. Override it on target-i386 to return APIC ID. Signed-off-by:

Re: [Qemu-devel] [Xen-devel] guest cannot boot up successfully using qemu.git in Xen

2013-04-22 Thread Stefano Stabellini
On Mon, 22 Apr 2013, Liu, SongtaoX wrote: I encountered a problem that the guest cannot boot up successfully using qemu.git in Xen. after creating the guest by xl cr xlexample.hvm, xl list shows the guest's vcpu has no status, and xl vnc $dom_id cannot connect to the guest. The qemu.git

Re: [Qemu-devel] [PATCH 10/16] target-i386: introduce apic-id property

2013-04-22 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:12:50AM +0200, Igor Mammedov wrote: ... and use it from board level to set APIC ID for CPUs it creates. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Michael S. Tsirkin m...@redhat.com --- Note:

Re: [Qemu-devel] [PATCH v5 14/19] tcg-arm: Cleanup most primitive load store subroutines

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:35:00PM -0700, Richard Henderson wrote: Use even more primitive helper functions to avoid lots of duplicated code. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 235 --- 1 file

Re: [Qemu-devel] [PATCH v5 15/19] tcg-arm: Split out tcg_out_tlb_read

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:35:01PM -0700, Richard Henderson wrote: Share code between qemu_ld and qemu_st to process the tlb. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/arm/tcg-target.c | 169 +-- 1 file changed, 70

Re: [Qemu-devel] [PATCH v5 16/19] tcg-arm: Improve scheduling of tcg_out_tlb_read

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:35:02PM -0700, Richard Henderson wrote: The schedule was fully serial, with no possibility for dual issue. The old schedule had a minimal issue of 7 cycles; the new schedule has a minimal issue of 5 cycles. Signed-off-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH v5 17/19] tcg-arm: Use movi32 + blx for calls on v7

2013-04-22 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:35:03PM -0700, Richard Henderson wrote: Work better with branch predition when we have movw+movt, as the size of the code is the same. Perhaps re-evaluate when we have a proper constant pool. Signed-off-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH 09/16] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-22 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:12:49AM +0200, Igor Mammedov wrote: * introduce processor status bitmask visible to guest at 0xaf00 addr, where ACPI asl code expects it * set bit corresponding to APIC ID in processor status bitmask on receiving CPU hot-plug notification * trigger CPU hot-plug

Re: [Qemu-devel] xen-unstable qemu-upstream: pci-passthrough timing issues due to commit 0f7b2864d0d0c3ef2801f9214d8c510c80a220d1 when vnc enabled

2013-04-22 Thread Stefano Stabellini
On Sat, 20 Apr 2013, Sander Eikelenboom wrote: Hi Gerd, Using qemu-upstream with pci-passthrough on xen-unstable previously worked fine. Since commit 0f7b2864d0d0c3ef2801f9214d8c510c80a220d1 (bisected) i see what i think are timing issues (video device is reporting buffer underruns).

Re: [Qemu-devel] [PATCH] translate-all: fix compiler warning and linked error

2013-04-22 Thread Alexey Kardashevskiy
On 04/22/2013 07:00 PM, Peter Maydell wrote: On 22 April 2013 08:42, Alexey Kardashevskiy a...@ozlabs.ru wrote: The code did use profile_getclock() but did not include include/qemu/timer.h where this function is defined. The patch fixes this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru

Re: [Qemu-devel] [PATCH] translate-all: fix compiler warning and linked error

2013-04-22 Thread Peter Maydell
On 22 April 2013 11:01, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/22/2013 07:00 PM, Peter Maydell wrote: NB that this compile failure only happens if you configure with --enable-profiler. I also thought I can enable/disable it via ./configure but in fact I cannot:

Re: [Qemu-devel] [PATCH] translate-all: fix compiler warning and linked error

2013-04-22 Thread Alexey Kardashevskiy
On 04/22/2013 08:03 PM, Peter Maydell wrote: On 22 April 2013 11:01, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/22/2013 07:00 PM, Peter Maydell wrote: NB that this compile failure only happens if you configure with --enable-profiler. I also thought I can enable/disable it via

Re: [Qemu-devel] xen-unstable qemu-upstream: pci-passthrough timing issues due to commit 0f7b2864d0d0c3ef2801f9214d8c510c80a220d1 when vnc enabled

2013-04-22 Thread Sander Eikelenboom
Monday, April 22, 2013, 12:01:02 PM, you wrote: On Sat, 20 Apr 2013, Sander Eikelenboom wrote: Hi Gerd, Using qemu-upstream with pci-passthrough on xen-unstable previously worked fine. Since commit 0f7b2864d0d0c3ef2801f9214d8c510c80a220d1 (bisected) i see what i think are timing issues

Re: [Qemu-devel] [PATCH 08/16] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-22 Thread Michael S. Tsirkin
On Tue, Apr 16, 2013 at 12:12:48AM +0200, Igor Mammedov wrote: ... it should be used only on slow path since it does recursive search on /machine QOM tree for objects of TYPE_CPU Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com I would

Re: [Qemu-devel] [PATCH 03/16] introduce resume_vcpu(), for single CPU

2013-04-22 Thread Gleb Natapov
On Tue, Apr 16, 2013 at 12:12:43AM +0200, Igor Mammedov wrote: ... also add stub for it, to make possible to use it in qom/cpu.c, which is shared with user emulators. Signed-off-by: Igor Mammedov imamm...@redhat.com --- Note: it will be re-used from qom/cpu.c by hotpluged CPU ---

Re: [Qemu-devel] [PATCH 08/16] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-22 Thread Igor Mammedov
On Mon, 22 Apr 2013 13:28:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:48AM +0200, Igor Mammedov wrote: ... it should be used only on slow path since it does recursive search on /machine QOM tree for objects of TYPE_CPU Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 03/16] introduce resume_vcpu(), for single CPU

2013-04-22 Thread Igor Mammedov
On Mon, 22 Apr 2013 13:40:02 +0300 Gleb Natapov g...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:43AM +0200, Igor Mammedov wrote: ... also add stub for it, to make possible to use it in qom/cpu.c, which is shared with user emulators. Signed-off-by: Igor Mammedov imamm...@redhat.com

Re: [Qemu-devel] [PATCH 05/16] introduce CPU hot-plug notifier

2013-04-22 Thread Gleb Natapov
On Tue, Apr 16, 2013 at 12:12:45AM +0200, Igor Mammedov wrote: hot-added CPU will be distributed to acpi_piix4 and rtc_cmos Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- v2: * move

Re: [Qemu-devel] xen-unstable qemu-upstream: pci-passthrough timing issues due to commit 0f7b2864d0d0c3ef2801f9214d8c510c80a220d1 when vnc enabled

2013-04-22 Thread Gerd Hoffmann
On 04/22/13 12:10, Sander Eikelenboom wrote: Monday, April 22, 2013, 12:01:02 PM, you wrote: Are you sure that the bug is related to Xen PCI passthrough (it doesn't happen if you don't assign any devices to the Xen guest)? I am asking because the Xen PCI passthrough code doesn't use any

Re: [Qemu-devel] [PATCH 05/16] introduce CPU hot-plug notifier

2013-04-22 Thread Igor Mammedov
On Mon, 22 Apr 2013 14:00:01 +0300 Gleb Natapov g...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:45AM +0200, Igor Mammedov wrote: hot-added CPU will be distributed to acpi_piix4 and rtc_cmos Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 08/16] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-22 Thread Andreas Färber
Am 22.04.2013 12:28, schrieb Michael S. Tsirkin: On Tue, Apr 16, 2013 at 12:12:48AM +0200, Igor Mammedov wrote: ... it should be used only on slow path since it does recursive search on /machine QOM tree for objects of TYPE_CPU Signed-off-by: Igor Mammedov imamm...@redhat.com

Re: [Qemu-devel] [PATCH 05/16] introduce CPU hot-plug notifier

2013-04-22 Thread Gleb Natapov
On Mon, Apr 22, 2013 at 01:09:19PM +0200, Igor Mammedov wrote: On Mon, 22 Apr 2013 14:00:01 +0300 Gleb Natapov g...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:45AM +0200, Igor Mammedov wrote: hot-added CPU will be distributed to acpi_piix4 and rtc_cmos Signed-off-by: Igor

[Qemu-devel] [PULL 00/20] Block patches

2013-04-22 Thread Kevin Wolf
The following changes since commit 68c0aa6e02f79f8825c0c5dc4c7ed25d524aaa8b: ui/cocoa.m: Fix recent compile breakage (2013-04-21 16:44:26 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to

[Qemu-devel] [PATCH 04/20] qemu-iotests: Fix _filter_qemu

2013-04-22 Thread Kevin Wolf
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and to when it's followed by a colon, i.e. the form used by error messages. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com

[Qemu-devel] [PATCH 02/20] qcow: allow sub-cluster compressed write to last cluster

2013-04-22 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Compression in qcow requires image length to be a multiple of the cluster size. Lift this requirement by zero-padding the final cluster when necessary. The virtual disk size is still not cluster-aligned, so the guest cannot access the zero sectors.

[Qemu-devel] [PATCH 09/20] raw-win32: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/raw-win32.c | 57 +-- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index ece2f1a..be33cc1

[Qemu-devel] [PATCH 03/20] qemu-img: do not zero-pad the compressed write buffer

2013-04-22 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com bdrv_write_compressed() does not allow requests that span the end of the device. Therefore it is useless to zero-pad the last cluster and thereby exceed the end of the device. Let image formats handle zero-padding the final compressed cluster, if

[Qemu-devel] [PATCH 16/20] sheepdog: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the filename to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH 01/20] qcow2: allow sub-cluster compressed write to last cluster

2013-04-22 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Compression in qcow2 requires image length to be a multiple of the cluster size. Lift this requirement by zero-padding the final cluster when necessary. The virtual disk size is still not cluster-aligned, so the guest cannot access the zero sectors.

[Qemu-devel] [PATCH 17/20] vvfat: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/vvfat.c | 228 ++ 1 file changed, 168 insertions(+), 60 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index ef74c30..f4c06b9 100644 ---

[Qemu-devel] [PATCH 05/20] block: Fail gracefully when using a format driver on protocol level

2013-04-22 Thread Kevin Wolf
Specifying the wrong driver could fail an assertion: $ qemu-system-x86_64 -drive file.driver=qcow2,file=x qemu-system-x86_64: block.c:721: bdrv_open_common: Assertion `file != ((void *)0)' failed. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c| 7 +++

[Qemu-devel] [PATCH 20/20] qemu-iotests: add 053 unaligned compressed image size test

2013-04-22 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Test that qemu-img convert -c works when input image length is not a multiple of the cluster size. Previously an error message would be produced: qemu-img: error while compressing sector 0: Input/output error Now that qcow2 and qcow handle this case

[Qemu-devel] [PATCH 06/20] block: Add driver-specific options for backing files

2013-04-22 Thread Kevin Wolf
Options starting in backing. are passed to the backing file now. If you don't need to specify the filename for the backing file, you can add it on the command line instead of in the image file: $ qemu-nbd -t /tmp/test.img $ qemu-img create -f qcow2 empty.qcow2 1G $ qemu-system-x86_64 -drive

[Qemu-devel] [PATCH 11/20] blkverify: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/blkverify.c | 114 -- 1 file changed, 85 insertions(+), 29 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 59e3b05..d63158f

[Qemu-devel] [PATCH 18/20] block: Remove filename parameter from .bdrv_file_open()

2013-04-22 Thread Kevin Wolf
It is unused now in all block drivers. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block.c | 8 ++-- block/blkdebug.c | 3 +-- block/blkverify.c | 3 +-- block/curl.c | 3 +-- block/gluster.c

[Qemu-devel] [PATCH 08/20] raw-posix: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/raw-posix.c | 57 +++ 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 99ac869..afd5385

[Qemu-devel] [PATCH 14/20] iscsi: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the filename to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH 10/20] blkdebug: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/blkdebug.c | 114 +++ 1 file changed, 82 insertions(+), 32 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 37cfbc7..3d03fcb

[Qemu-devel] [PATCH 13/20] gluster: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the filename to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

Re: [Qemu-devel] [PATCH 11/16] introduce ICC bus/device/bridge

2013-04-22 Thread Peter Maydell
On 15 April 2013 23:12, Igor Mammedov imamm...@redhat.com wrote: ... to provide hotplug-able bus. * icc-bridge will serve as a parent for icc-bus and provide mmio mapping services to child icc-devices. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices.

[Qemu-devel] [PATCH 15/20] rbd: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the filename to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com ---

[Qemu-devel] [PATCH 19/20] block: Allow overriding backing.file.filename

2013-04-22 Thread Kevin Wolf
If a filename is passed in the driver-specific options from the command line, the backing file path from the image is ignored now. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 12/20] curl: Use bdrv_open options instead of filename

2013-04-22 Thread Kevin Wolf
As a bonus, going through the QemuOpts QEMU_OPT_SIZE parser for the readahead option gives us proper error reporting that the previous use of atoi() lacked. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block/curl.c | 153

Re: [Qemu-devel] [PATCH 03/16] introduce resume_vcpu(), for single CPU

2013-04-22 Thread Gleb Natapov
On Mon, Apr 22, 2013 at 12:54:04PM +0200, Igor Mammedov wrote: On Mon, 22 Apr 2013 13:40:02 +0300 Gleb Natapov g...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:43AM +0200, Igor Mammedov wrote: ... also add stub for it, to make possible to use it in qom/cpu.c, which is shared with

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-22 Thread Stefan Hajnoczi
On Thu, Apr 18, 2013 at 03:31:55PM +0400, Sergey Fedorov wrote: Network hub should always receive incoming packets. Then forward them to the appropriate port queue and let the qemu_send_packet() do the right things. If the destination queue cannot receive the packet it will be appended to the

Re: [Qemu-devel] [PATCH 03/16] introduce resume_vcpu(), for single CPU

2013-04-22 Thread Igor Mammedov
On Mon, 22 Apr 2013 13:59:17 +0300 Gleb Natapov g...@redhat.com wrote: On Mon, Apr 22, 2013 at 12:54:04PM +0200, Igor Mammedov wrote: On Mon, 22 Apr 2013 13:40:02 +0300 Gleb Natapov g...@redhat.com wrote: On Tue, Apr 16, 2013 at 12:12:43AM +0200, Igor Mammedov wrote: ... also add

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-22 Thread Amos Kong
On Fri, Apr 19, 2013 at 05:21:37PM +0200, Paolo Bonzini wrote: Il 19/04/2013 11:52, Amos Kong ha scritto: Libvirt doesn't have a stable way to know option support detail. This patch introdued a new qmp command to query configuration schema information. hmp command isn't added. Can you

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-04-22 Thread Peter Maydell
On 22 April 2013 00:03, Andreas Färber andreas.faer...@web.de wrote: Even after this has been applied, things are still not building for me. I'm seeing CC trace/generated-events.o failing with error: parameter name omitted for trace_apic_local_deliver, trace_usb_xhci_queue_event,

Re: [Qemu-devel] [PATCH] qdev: Fix device_add bus assumptions

2013-04-22 Thread Libaiqing
Hi Igor, When I use the config below,an error occurs.Is there anything wrong? Qemu-kvm -enable-kvm -name win7 -M pc-0.15 -m 1024 -smp 2 -boot c -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x4 -chardev spicevmc,id=charchannel0,name=vdagent -device

Re: [Qemu-devel] [PATCH v2 2/2] sheepdog: implement .bdrv_co_is_allocated()

2013-04-22 Thread Stefan Hajnoczi
On Mon, Apr 22, 2013 at 02:59:10PM +0800, Liu Yuan wrote: +static coroutine_fn int +sd_co_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors, + int *pnum) +{ +BDRVSheepdogState *s = bs-opaque; +SheepdogInode *inode = s-inode; +unsigned long

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 13:48, Amos Kong ha scritto: Libvirt doesn't have a stable way to know option support detail. This patch introdued a new qmp command to query configuration schema information. hmp command isn't added. Can you introspect QemuOpts instead? All new options are added

Re: [Qemu-devel] [PATCH v2 2/2] sheepdog: implement .bdrv_co_is_allocated()

2013-04-22 Thread Liu Yuan
On 04/22/2013 08:00 PM, Stefan Hajnoczi wrote: On Mon, Apr 22, 2013 at 02:59:10PM +0800, Liu Yuan wrote: +static coroutine_fn int +sd_co_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors, + int *pnum) +{ +BDRVSheepdogState *s = bs-opaque; +

[Qemu-devel] [PATCH 07/20] block: Enable filename option

2013-04-22 Thread Kevin Wolf
This allows using the file.filename option instead of the string that comes from -drive file=... and is passed around as a separate parameter. The goal is to get rid of this parameter and use the options QDict more consistently. With this option you can access not only the top-level image, but

Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler

2013-04-22 Thread Fedorov Sergey
On 04/22/2013 03:47 PM, Stefan Hajnoczi wrote: On Thu, Apr 18, 2013 at 03:31:55PM +0400, Sergey Fedorov wrote: Network hub should always receive incoming packets. Then forward them to the appropriate port queue and let the qemu_send_packet() do the right things. If the destination queue cannot

[Qemu-devel] [PATCH v3 1/3] sheepdog: add discard/trim support for sheepdog

2013-04-22 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com The 'TRIM' command from VM that is to release underlying data storage for better thin-provision is already supported by the Sheepdog. This patch adds the TRIM support at QEMU part. For older Sheepdog that doesn't support it, we return 0(success) to upper

Re: [Qemu-devel] [PATCH 11/16] introduce ICC bus/device/bridge

2013-04-22 Thread Paolo Bonzini
Il 22/04/2013 13:39, Peter Maydell ha scritto: ... to provide hotplug-able bus. * icc-bridge will serve as a parent for icc-bus and provide mmio mapping services to child icc-devices. * icc-device will replace SysBusDevice as a parent of APIC and IOAPIC devices. Signed-off-by:

[Qemu-devel] [PATCH v3 3/3] sheepdog: implement .bdrv_co_is_allocated()

2013-04-22 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com --- block/sheepdog.c | 37 + 1 file changed, 37

[Qemu-devel] Qemu usermode fork problem !

2013-04-22 Thread Muhammad Nouman
Hi ! I am trying to emulate cavium octeon's mips64 linux kernel on Qemu.When the fork system call is generated from usermode (i.e from init code), after creating a new thread, the kernel gets a fatal signal from the new thread and then the new thread never runs. I have tried to debug this new

  1   2   3   4   >