[Qemu-devel] RFH: boot from virtio cdrom?

2013-06-07 Thread Philipp Hahn
Hello, I'm using libvirt to manage my VMs and configured one VM to boot from a CDROM connected via virtio. This does neither work with QEMU-1.1.2 nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2. /root/qemu-1.5.0+dfsg/qemu-build/x86_64-softmmu/qemu-system-x86_64 \ -M pc-1.1 \

Re: [Qemu-devel] RFH: boot from virtio cdrom?

2013-06-07 Thread Gerd Hoffmann
On 06/06/13 17:10, Philipp Hahn wrote: Hello, I'm using libvirt to manage my VMs and configured one VM to boot from a CDROM connected via virtio. This does neither work with QEMU-1.1.2 nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2. Doesn't work with virtio-blk, virtio-scsi can

Re: [Qemu-devel] RFH: boot from virtio cdrom?

2013-06-07 Thread Laszlo Ersek
On 06/07/13 08:12, Gerd Hoffmann wrote: On 06/06/13 17:10, Philipp Hahn wrote: Hello, I'm using libvirt to manage my VMs and configured one VM to boot from a CDROM connected via virtio. This does neither work with QEMU-1.1.2 nor with QEMU-1.5; neither with SeaBIOS is 1.7.0 nor 1.7.2.

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30 14:34, Stefan Hajnoczi wrote: + +static int coroutine_fn backup_before_write_notify( +

Re: [Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-07 Thread Richard W.M. Jones
On Fri, Jun 07, 2013 at 09:54:42AM +0800, Fam Zheng wrote: The weird thing is it doesn't work for me, I'm sure something is wrong with current upstream, although not totally broken. $./qemu-io http://localhost/vm/arch.raw -c 'read -v 0 512' (stuck here forever, no output) This doesn't

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Kevin Wolf
Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc:

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 09:32:42AM -0400, Corey Bryant wrote: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial user of this functionality

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Andreas Färber
Am 07.06.2013 03:03, schrieb Paolo Bonzini: Il 05/06/2013 05:50, Andreas Färber ha scritto: Also I notice some patches are accessing parent fields directly - please use BUS(), PCI_DEVICE() etc. to hide this. I'm always using them. For example: +static void

Re: [Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 12:01:57PM +0100, Richard W.M. Jones wrote: On Thu, Jun 06, 2013 at 02:25:46PM +0800, Fam Zheng wrote: v7: 13: Added: curl: change timeout to 30 seconds I tested this against: (1) HTTP to Apache server over slow but local wifi. (2) HTTP to a remote

Re: [Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-07 Thread Fam Zheng
On Fri, 06/07 08:27, Richard W.M. Jones wrote: On Fri, Jun 07, 2013 at 09:54:42AM +0800, Fam Zheng wrote: The weird thing is it doesn't work for me, I'm sure something is wrong with current upstream, although not totally broken. $./qemu-io http://localhost/vm/arch.raw -c 'read -v 0

Re: [Qemu-devel] [PATCH 01/39] scsi: keep device alive while it has requests

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 53ea906..e443193 100644 --- a/hw/scsi/scsi-bus.c +++

Re: [Qemu-devel] [PATCH 02/39] dma: keep a device alive while it has SGLists

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: A QEMUSGList has a reference to a device's address space. Keep the device alive while the QEMUSGList exists. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- dma-helpers.c | 6 +- hw/ide/ahci.c | 3 ++- hw/ide/macio.c

Re: [Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-07 Thread Fam Zheng
On Fri, 06/07 09:46, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 12:01:57PM +0100, Richard W.M. Jones wrote: On Thu, Jun 06, 2013 at 02:25:46PM +0800, Fam Zheng wrote: v7: 13: Added: curl: change timeout to 30 seconds I tested this against: (1) HTTP to Apache

Re: [Qemu-devel] [PATCH 39/39] tpm: move add/del_subregion to realize/unrealize

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:52, schrieb Paolo Bonzini: Only do init/destroy in instance_init/finalize. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/tpm/tpm_tis.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index

[Qemu-devel] [PULL 0/2] virtio-ccw/css: bugfixes

2013-06-07 Thread Cornelia Huck
Please pull to get these two bugfixes: The following changes since commit 8819c10b5d55d537d59a0ffd5d623f348fc36c47: Merge remote-tracking branch 'sstabellini/xen_fixes_20130603' into staging (2013-06-04 14:58:58 -0500) are available in the git repository at: git://github.com/cohuck/qemu

[Qemu-devel] [PULL 2/2] virtio-ccw: Fix unsetting of indicators.

2013-06-07 Thread Cornelia Huck
Interpretation of the ccws to register (configuration) indicators contained a thinko: We want to disallow reading from 0, but setting the indicator pointer to 0 is fine. Let's fix the handling for CCW_CMD_SET{,_CONF}_IND. Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 1/2] s390x/css: Fix concurrent sense.

2013-06-07 Thread Cornelia Huck
Fix an off-by-one error when indicating availablity of concurrent sense data. Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- hw/s390x/css.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/css.c b/hw/s390x/css.c index

Re: [Qemu-devel] [PATCH] arm/zynq: Add software reset

2013-06-07 Thread Sebastian Huber
On 06/07/2013 06:19 AM, Peter Crosthwaite wrote: Hi Sebastian, I'd like to get this merged with the fix I suggested. Are you able to remake or ok if I ammend and resend your patch? I am fine with your change. My version is to restrictive. -- Sebastian Huber, embedded brains GmbH Address :

Re: [Qemu-devel] SEV and WFE instructions on ARM

2013-06-07 Thread Sebastian Huber
Hello Peter, thanks for your suggestions. I will look at the WFI support and may send a patch for the SEV/WFE, but this will take some weeks. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-06-07 Thread Peter Maydell
On 7 June 2013 03:54, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Ping! We are stuck in limbo here and I would like to get either V1 or V2 (this patch) of this through. Paolo, If you are not happy with this patch, does V1 address your concerns (which was its original intention).

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Peter Crosthwaite
Hi, On Jun 7, 2013 11:04 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/06/2013 05:50, Andreas Färber ha scritto: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at

Re: [Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-07 Thread Richard W.M. Jones
On Fri, Jun 07, 2013 at 03:47:23PM +0800, Fam Zheng wrote: On Fri, 06/07 08:27, Richard W.M. Jones wrote: On Fri, Jun 07, 2013 at 09:54:42AM +0800, Fam Zheng wrote: The weird thing is it doesn't work for me, I'm sure something is wrong with current upstream, although not totally broken.

[Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Wenchao Xia
This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader. libcacard/vscclient.c |3 +-- util/iov.c|2 +- 2 files

Re: [Qemu-devel] RFC: Full introspection support for QMP (with draft patch)

2013-06-07 Thread Amos Kong
Sent out a draft patch in the end of this week. It doesn't support: * output all stuffs in one shot. * introspect event * provide metadata date How can we define a dynamic dict in qmp-schema.json ? Currently I just output the raw json dict by a string, Libvirt needs parse two times, convert the

Re: [Qemu-devel] RFC: Full introspection support for QMP (with draft patch)

2013-06-07 Thread Amos Kong
On Fri, Jun 07, 2013 at 06:12:30PM +0800, Amos Kong wrote: Sent out a draft patch in the end of this week. It doesn't support: * output all stuffs in one shot. * introspect event * provide metadata date How can we define a dynamic dict in qmp-schema.json ? Currently I just output the raw

[Qemu-devel] [PATCH RFC] virtio-ccw: Document adapter interrupts.

2013-06-07 Thread Cornelia Huck
Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- virtio-spec.lyx | 147 +-- 1 file changed, 144 insertions(+), 3 deletions(-) diff --git a/virtio-spec.lyx b/virtio-spec.lyx index 6e188d0..697351e 100644 --- a/virtio-spec.lyx +++

[Qemu-devel] [PATCH RFC 2/2] KVM: s390: virtio-ccw adapter interrupt support.

2013-06-07 Thread Cornelia Huck
Implement the new CCW_CMD_SET_IND_ADAPTER command and try to enable adapter interrupts for every device on the first startup. If the host does not support adapter interrupts, fall back to normal I/O interrupts. virtio-ccw adapter interrupts use the same isc as normal I/O subchannels and share a

[Qemu-devel] [PATCH RFC] s390/virtio-ccw: Adapter interrupt support.

2013-06-07 Thread Cornelia Huck
Handle the new CCW_CMD_SET_IND_ADAPTER command enabling adapter interrupts on guest request. When active, host-guest notifications will be handled via global_indicator - queue indicators instead of queue indicators + subchannel I/O interrupt. Indicators for virtqueues may be present at an offset.

[Qemu-devel] [PATCH RFC] Adapter interrupts for virtio-ccw.

2013-06-07 Thread Cornelia Huck
Hi, here's a proposal to support adapter (aka thin) interrupts for virtio-ccw. The basic idea is to make host-guest signalling on s390 more lightweight. Normal I/O interrupts have two parts: an interrupt that is made pending on any of the guest cpus, and status that is made pending on the

[Qemu-devel] [PATCH RFC] qemu: Adapter interrupts for virtio-ccw.

2013-06-07 Thread Cornelia Huck
Hi, here's the qemu patch that implements the new adapter indicators ccw in virtio-ccw and injects adapter interrupts for the devices enabled for it. Cornelia Huck (1): s390/virtio-ccw: Adapter interrupt support. hw/s390x/css.c| 10 hw/s390x/css.h|2 ++

[Qemu-devel] [PATCH RFC 0/2] KVM: s390: virtio-ccw adapter interrupts.

2013-06-07 Thread Cornelia Huck
Hi, here's the guest driver support for adapter interrupts in virtio-ccw. We use one summary indicator per page of indicators. For each device, we try to find a space in an indicator where all of its virtqueues fit. Locking probably needs some more love, but it seems to work fine so far.

[Qemu-devel] [PATCH RFC 1/2] KVM: s390: virtio-ccw: Handle command rejects.

2013-06-07 Thread Cornelia Huck
A command reject for a ccw may happen if we run on a host not supporting a certain feature. We want to be able to handle this as special case of command failure, so let's split this off from the generic -EIO error code. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

[Qemu-devel] [PATCH 2/5] slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints

2013-06-07 Thread Markus Armbruster
Broken since they got added in commit 97bf485. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/misc/slavio_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c index a7a9368..3571850 100644 --- a/hw/misc/slavio_misc.c

[Qemu-devel] [PATCH 0/5] Trace fixes

2013-06-07 Thread Markus Armbruster
Markus Armbruster (5): cleanup-trace-events.pl: New slavio_misc: Fix slavio_led_mem_readw/_writew tracepoints milkymist-minimac2: Fix minimac2_read/_write tracepoints trace-events: Drop unused events trace-events: Fix up source file comments hw/misc/slavio_misc.c | 2 +-

[Qemu-devel] [PATCH 4/5] trace-events: Drop unused events

2013-06-07 Thread Markus Armbruster
Dropped event Unused since mirror_cow 884fea4 paio_complete 47e6b25 paio_cancel 47e6b25 usb_ehci_data 0ce668b megasas_qf_dequeue never used

[Qemu-devel] [PATCH 3/5] milkymist-minimac2: Fix minimac2_read/_write tracepoints

2013-06-07 Thread Markus Armbruster
Broken in milkymist-minimac.c from the start (commit 0742454), faithfully moved to milkymist-minimac2.c (commit 57aa265). Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/net/milkymist-minimac2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments

2013-06-07 Thread Markus Armbruster
They're all wrong since (at least) Paolo's big source tree reorganization. Need to shuffle some event declarations around to keep them under the correct source file comment. Signed-off-by: Markus Armbruster arm...@redhat.com --- trace-events | 162

[Qemu-devel] [PATCH 1/5] cleanup-trace-events.pl: New

2013-06-07 Thread Markus Armbruster
Simple script to drop unused events and fix up source file comments. The next few commits put it to use. Signed-off-by: Markus Armbruster arm...@redhat.com --- Feel free to ignore this one, rewrite it in Python, frame it to hang in your bathroom, print it on tissue paper for that other bathroom

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Stefan Hajnoczi
On Fri, Jun 07, 2013 at 06:02:09PM +0800, Wenchao Xia wrote: This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader.

Re: [Qemu-devel] [PATCH V15 0/5] enhancement for qmp/hmp interfaces of block info

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 12:27:56PM +0800, Wenchao Xia wrote: This series lets qmp interface show delaied info, including internal snapshot /backing chain on all block device at runtime, which helps management stack and human user, by retrieving exactly the same info of what qemu sees.

[Qemu-devel] [PULL 02/26] qemu-io: Remove unused args_command

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com The original intention seems to be something with handling multiple images at once, but this has never been implemented and the only function ever registered is implemented to make everything behave like a global command. Just do that unconditionally now.

[Qemu-devel] [PULL 01/26] blockdev: reset werror/rerror on drive_del

2013-06-07 Thread Stefan Hajnoczi
Paolo Bonzini pbonz...@redhat.com suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop -device virtio-blk-pci,drive=foo,id=virtio0,addr=4 2.

[Qemu-devel] [PULL 00/26] Block patches

2013-06-07 Thread Stefan Hajnoczi
The following changes since commit 8819c10b5d55d537d59a0ffd5d623f348fc36c47: Merge remote-tracking branch 'sstabellini/xen_fixes_20130603' into staging (2013-06-04 14:58:58 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up

[Qemu-devel] [PULL 09/26] qemu-io: Move 'help' function

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com No reason to treat it different from other commands. Move it to qemu-io-cmds.c, adapt the coding style and register it like any other command. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 03/26] cutils: Support 'P' and 'E' suffixes in strtosz()

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- include/qemu-common.h | 2 ++ monitor.c | 8 qemu-img.c | 10 ++

[Qemu-devel] [PULL 05/26] qemu-io: Handle cvtnum() errors in 'alloc'

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-io.c b/qemu-io.c index

[Qemu-devel] [PULL 12/26] qemu-io: Move functions for registering and running commands

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- cmd.c | 113 - cmd.h | 11 +--- qemu-io-cmds.c | 192

[Qemu-devel] [PULL 08/26] qemu-io: Factor out qemuio_command

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com It's duplicated code. Move it to qemu-io-cmds.c because it's not dependent on any static data of the qemu-io tool. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- cmd.c

[Qemu-devel] [PULL 04/26] qemu-io: Make cvtnum() a wrapper around strtosz_suffix()

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com No reason to implement the same thing multiple times. A nice side effect is that fractional numbers like 0.5M can be used in qemu-io now. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 11/26] qemu-io: Move qemu_strsep() to cutils.c

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- cmd.c | 21 - include/qemu-common.h | 1 + util/cutils.c | 21

[Qemu-devel] [PULL 13/26] qemu-io: Move command_loop() and friends

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- cmd.c | 139 -- cmd.h | 9 qemu-io.c | 139

[Qemu-devel] [PULL 10/26] qemu-io: Move 'quit' function

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com This one only makes sense in the context of the qemu-io tool, so move it to qemu-io.c. Adapt coding style and register it like other commands. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 14/26] qemu-io: Move remaining helpers from cmd.c

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- Makefile | 2 +- cmd.c | 139 - cmd.h | 14 -- qemu-io-cmds.c | 104

[Qemu-devel] [PULL 19/26] ide-test: Add enum value for DEV

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Get rid of the magic number. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/ide-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index

[Qemu-devel] [PULL 17/26] Make qemu-io commands available in HMP

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com It was decided to not make this command available in QMP in order to make clear that this is not supposed to be a stable API and should be used only for testing and debugging purposes. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 22/26] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-06-07 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com This patch adds function bdrv_query_snapshot_info_list(), which will retrieve snapshot info of an image in qmp object format. The implementation is based on the code moved from qemu-img.c with modification to fit more for qmp based block layer API.

[Qemu-devel] [PULL 15/26] qemu-io: Interface cleanup

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- cmd.h | 48 include/qemu-io.h | 46 ++ qemu-io-cmds.c|

[Qemu-devel] [PULL 18/26] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 8 block/blkdebug.c | 3 +++ include/block/block.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 23/26] block: add image info query function bdrv_query_image_info()

2013-06-07 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com This patch adds function bdrv_query_image_info(), which will retrieve image info in qmp object format. The implementation is based on the code moved from qemu-img.c, but uses block layer function to get snapshot info. Signed-off-by: Wenchao Xia

[Qemu-devel] [PULL 25/26] hmp: show ImageInfo in 'info block'

2013-06-07 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com Now human monitor can show image details, include internal snapshot and backing chain info for every block device. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hmp.c | 14 ++

[Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH

2013-06-07 Thread Stefan Hajnoczi
From: Andreas Färber afaer...@suse.de The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and filesystems get

[Qemu-devel] [PULL 24/26] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-06-07 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com Now image info will be retrieved as an embbed json object inside BlockDeviceInfo, backing chain info and all related internal snapshot info can be got in the enhanced recursive structure of ImageInfo. New recursive member *backing-image is added to

Re: [Qemu-devel] [PULL 20/26] ide: Set BSY bit during FLUSH

2013-06-07 Thread Paolo Bonzini
Il 07/06/2013 07:58, Stefan Hajnoczi ha scritto: From: Andreas Färber afaer...@suse.de The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1

[Qemu-devel] [PULL 26/26] hmp: add parameters device and -v for info block

2013-06-07 Thread Stefan Hajnoczi
From: Wenchao Xia xiaw...@linux.vnet.ibm.com With these parameters, user can choose the information to be showed, to avoid message flood in the monitor. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hmp.c | 25

Re: [Qemu-devel] [Bug 1188018] [NEW] qemu monitor does not suppot rbd savevm command

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 06:08:16AM -, liu.changpeng wrote: Public bug reported: 1. I used ceph rbd as my block device, /usr/local/bin/qemu-system-x86_64 -drive format=rbd,file=rbd:rbd/sles.img:rbd_cache=true,cache=writeback -boot c -m 1024 -enable-kvm -vnc 0.0.0.0:0 -monitor stdio 2.

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-07 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: This patch simply remove variable may be used uninitialized warning. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- V2: Address Stefan and Peter's comments, use 0 in send_msg() instead of initialize mhHeader. libcacard/vscclient.c

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Paolo Bonzini
Il 07/06/2013 03:45, Andreas Färber ha scritto: Am 07.06.2013 03:03, schrieb Paolo Bonzini: Il 05/06/2013 05:50, Andreas Färber ha scritto: Also I notice some patches are accessing parent fields directly - please use BUS(), PCI_DEVICE() etc. to hide this. I'm always using them. For example:

Re: [Qemu-devel] difference between receive_raw() and receive() NetClientInfo methods ?

2013-06-07 Thread Stefan Hajnoczi
On Thu, Jun 06, 2013 at 11:40:37AM +0200, Luigi Rizzo wrote: Can someone clarify what is the difference between the two methods r eceive_raw() and receive() in NetClientInfo ? receive_raw() builds an empty vnet header, if necessary. It is used to send a gratuitous ARP reply from inside QEMU.

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-07 Thread Corey Bryant
On 06/07/2013 03:41 AM, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 09:32:42AM -0400, Corey Bryant wrote: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend

[Qemu-devel] [PATCH v2 07/12] i8259: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/i8259.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index fef00fc..1b513ff 100644 ---

[Qemu-devel] [PATCH v2 09/12] i8259: Convert PICCommonState to use QOM realizefn

2013-06-07 Thread Andreas Färber
Instead of having the parent provide PICCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility of saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8259.c |

[Qemu-devel] [PATCH v2 04/12] i8254: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and avoid DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/timer/i8254.c | 4 ++-- include/hw/timer/i8254.h | 18 +++--- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/timer/i8254.c

[Qemu-devel] [PATCH v2 11/12] isa: QOM'ify ISADevice

2013-06-07 Thread Andreas Färber
Rename its parent field and use DEVICE() where necessary. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/fdc.c | 16 +--- hw/char/serial-isa.c | 14 -- hw/i386/pc.c | 9 + hw/i386/pc_piix.c| 2 +-

[Qemu-devel] [PATCH v2 08/12] kvm/i8259: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8259.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index d961eca..0bfbe34 100644 ---

[Qemu-devel] [PATCH v2 01/12] gus: QOM'ify some more

2013-06-07 Thread Andreas Färber
Add type constant and cast macro. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/gus.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index a91921c..e0aea26 100644 --- a/hw/audio/gus.c +++ b/hw/audio/gus.c @@ -46,6 +46,9

[Qemu-devel] [PATCH v2 12/12] qdev: Drop FROM_QBUS() macro

2013-06-07 Thread Andreas Färber
Use QOM cast macros I2C_BUS(), SSI_BUS(), PCI_BUS() instead. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i2c/core.c | 4 ++-- hw/pci/pci.c | 2 +- hw/ssi/ssi.c | 2 +- include/hw/qdev-core.h | 2 -- 4 files changed, 4 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH v2 02/12] cs4231a: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and cast macro. Replace reset hook with DeviceClass::reset callback. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/cs4231a.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index

[Qemu-devel] [PATCH v2 10/12] isa: QOM'ify ISABus

2013-06-07 Thread Andreas Färber
Rename its parent field and use ISA_BUS() where necessary. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/isa/i82378.c | 2 +- hw/isa/isa-bus.c | 8 hw/isa/piix4.c | 2 +- hw/isa/vt82c686.c| 2 +- hw/ppc/prep.c| 2 +- hw/sparc64/sun4u.c | 3 +--

[Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8254.c | 19 +++ include/hw/timer/i8254.h | 13 - 2 files changed, 19 insertions(+), 13 deletions(-) diff

[Qemu-devel] [PATCH v2 03/12] isa: Use realizefn for ISADevice

2013-06-07 Thread Andreas Färber
Drop ISADeviceClass::init and the resulting no-op initfn and let children implement their own realizefn. Adapt error handling. Split off an instance_init where sensible. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/adlib.c | 23 +++ hw/audio/cs4231a.c

[Qemu-devel] [PATCH v2 2/6] log.h: Supply missing includes

2013-06-07 Thread Markus Armbruster
stdio.h has always been missing. Rest missed in commit eeacee4. Signed-off-by: Markus Armbruster arm...@redhat.com --- include/qemu/log.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/qemu/log.h b/include/qemu/log.h index 6b0db02..fd76f91 100644 --- a/include/qemu/log.h +++

[Qemu-devel] [PATCH v2 6/6] smbios: Check R in -smbios type=0, release=R parses okay

2013-06-07 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/i386/smbios.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 6431dd4..e708cb8 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -140,7 +140,10 @@ static void

[Qemu-devel] [PATCH v2 06/12] i8254: Convert PITCommonState to QOM realizefn

2013-06-07 Thread Andreas Färber
Instead of having the parent provide PITCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility for saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8254.c

[Qemu-devel] [PATCH v2 1/6] error-report.h: Supply missing include

2013-06-07 Thread Markus Armbruster
Missed in commit e5924d8. Signed-off-by: Markus Armbruster arm...@redhat.com --- include/qemu/error-report.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index c902cc1..14c1719 100644 --- a/include/qemu/error-report.h +++

[Qemu-devel] [PATCH v2 5/6] smbios: Fix -smbios type=0, release=... for big endian hosts

2013-06-07 Thread Markus Armbruster
Classic endianness bug due to careless dirty coding: assuming reading a byte from an int variable gets the least significant byte. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/i386/smbios.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/smbios.c

Re: [Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2

2013-06-07 Thread Andreas Färber
Am 07.06.2013 14:58, schrieb Andreas Färber: Cc: malc av1...@comtv.ru FWIW should be av1474, but either one bounces. ;) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2

2013-06-07 Thread Andreas Färber
Hello, Here is my next batch of QOM realize patches for ISA devices. For two new ISA devices QOM cast macros are introduced (gus, cs4231a); these two and the new pvpanic ISA device are now converted, too. Series is extended to clean up all ISABus and ISADevice uses; it then becomes easy to get

[Qemu-devel] [PULL 06/26] qemu-io: Don't use global bs in command implementations

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Pass in the BlockDriverState to the command handlers instead of using the global variable. This is an important step to make the commands usable outside of qemu-io. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com

[Qemu-devel] [PULL 16/26] qemu-io: Use the qemu version for -V

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Always printing 0.0.1 and never updating the version number wasn't very useful. qemu-io is released with qemu, so using the same version number makes most sense. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PATCH v2 0/6] Some -smbios work

2013-06-07 Thread Markus Armbruster
Better error messages, a bit of code cleanup, and a big endian fix. Not addressed: qemu_uuid_parse() sets an SMBIOS field by side effect. Gross! Testing: * Verify error messages improve for -smbios gaga -smbios file=gaga -smbios type=42 -smbios type=1,uuid=gaga -smbios

[Qemu-devel] [PATCH v2 4/6] smbios: Clean up smbios_add_field() parameters

2013-06-07 Thread Markus Armbruster
Having size precede the associated pointer is odd. Swap them, and fix up the types. Signed-off-by: Markus Armbruster arm...@redhat.com --- arch_init.c | 2 +- hw/i386/smbios.c | 26 ++ include/hw/i386/smbios.h | 2 +- 3 files changed, 16

[Qemu-devel] [PULL 21/26] ide-test: Add FLUSH CACHE test case

2013-06-07 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com This checks in particular that BSY is set while the flush request is in flight. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/ide-test.c | 40 1 file changed, 40

[Qemu-devel] [PATCH v2 3/6] smbios: Convert to error_report()

2013-06-07 Thread Markus Armbruster
Improves diagnistics from ad hoc messages like Invalid SMBIOS UUID string to qemu-system-x86_64: -smbios type=1,uuid=gaga: Invalid UUID Signed-off-by: Markus Armbruster arm...@redhat.com --- arch_init.c | 1 - hw/i386/smbios.c | 24 2 files changed, 12

Re: [Qemu-devel] 'qemu-nbd' explicit flush

2013-06-07 Thread Mark Trumpold
On 5/28/13 11:42 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 28, 2013 at 06:00:08PM +, Mark Trumpold wrote: -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Monday, May 27, 2013 05:36 AM To: 'Mark Trumpold' Cc: 'Paolo Bonzini',

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Andreas Färber
Hi Peter, Am 07.06.2013 10:41, schrieb Peter Crosthwaite: I have a series that fixes all qom cast macros for all PCI devices tree wide. Can post. Qom cast macros added as needed. Sounds promising! I just CC'ed you on my ISA series v2, which touches on PCI_BUS() in the final patch, dropping

Re: [Qemu-devel] [PATCH v2 0/6] Some -smbios work

2013-06-07 Thread Laszlo Ersek
On 06/07/13 15:00, Markus Armbruster wrote: v2: Address Hawkeye Laszlo's review You're too kind, but it did crack me up :) (Next time I'll miss something I'll have to hang my head in shame all the more!) * 1-3/7 unchanged * Drop 4/7 because it's buggy, and the fixed version isn't worthwhile

Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments

2013-06-07 Thread Andreas Färber
Am 07.06.2013 12:59, schrieb Markus Armbruster: They're all wrong since (at least) Paolo's big source tree reorganization. Need to shuffle some event declarations around to keep them under the correct source file comment. Signed-off-by: Markus Armbruster arm...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-07 Thread Julio Guerra
However I can't judge whether all that code is right for e600 and whether you may want to share some code with e500 / e5500 in some way? CC'ing some Freescale folks. e600 is a very different core from e500/e5500. It is a 74xx derivative. The only thing I can see that could be shared with

Re: [Qemu-devel] [PATCH v5] net: add support of mac-programming over macvtap in QEMU side

2013-06-07 Thread Luiz Capitulino
On Wed, 5 Jun 2013 18:42:13 +0800 Amos Kong ak...@redhat.com wrote: Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is

Re: [Qemu-devel] [PATCH 2/2] sheepdog: support 'qemu-img snapshot -a'

2013-06-07 Thread Liu Yuan
On 06/07/2013 03:31 PM, Kevin Wolf wrote: Am 06.06.2013 um 15:09 hat Liu Yuan geschrieben: On 06/06/2013 08:46 PM, Kevin Wolf wrote: Am 06.06.2013 um 13:57 hat Liu Yuan geschrieben: Just call sd_create_branch() to rollback the image is good enough Cc: qemu-devel@nongnu.org Cc: MORITA

  1   2   >