[Qemu-devel] [PATCH v2 2/2] libqtest: New qtest_end() to go with qtest_start()

2013-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/fdc-test.c| 2 +- tests/hd-geo-test.c | 8 tests/ide-test.c| 2 +- tests/libqtest.h| 12 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 4b0301d..fd198dc 1006

[Qemu-devel] [PATCH v2 1/2] libqtest: Plug fd and memory leaks in qtest_quit()

2013-06-19 Thread Markus Armbruster
Reviewed-by: Anthony Liguori Signed-off-by: Markus Armbruster --- tests/libqtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 879ffe9..bb82069 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -171,12 +171,16 @@ void qtest_quit(QTestSt

[Qemu-devel] [PATCH v2 0/2] libqtest leak fix & cleanup

2013-06-19 Thread Markus Armbruster
v2: qtest_start() function comment Markus Armbruster (2): libqtest: Plug fd and memory leaks in qtest_quit() libqtest: New qtest_end() to go with qtest_start() tests/fdc-test.c| 2 +- tests/hd-geo-test.c | 8 tests/ide-test.c| 2 +- tests/libqtest.c| 4 tests/li

Re: [Qemu-devel] [PATCH v2 5/6] net: defer nested call to BH

2013-06-19 Thread liu ping fan
On Tue, Jun 18, 2013 at 8:57 PM, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 05:03:05PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Nested call caused by ->receive() will raise issue like deadlock, >> so postphone it to BH. >> >> Signed-off-by: Liu Ping Fan >> --- >> net/queue.c

Re: [Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState

2013-06-19 Thread liu ping fan
On Tue, Jun 18, 2013 at 8:47 PM, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 05:03:04PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> qemu_net_client_setup() is the only user of qemu_new_net_queue(), which >> will pass in NetClientState. By forcing it be a NetClientState, we >> can

Re: [Qemu-devel] [PATCH v2 2/6] net: introduce lock to protect NetClientState's peer's access

2013-06-19 Thread liu ping fan
On Tue, Jun 18, 2013 at 8:25 PM, Stefan Hajnoczi wrote: > On Thu, Jun 13, 2013 at 05:03:02PM +0800, Liu Ping Fan wrote: >> @@ -67,6 +67,10 @@ struct NetClientState { >> NetClientInfo *info; >> int link_down; >> QTAILQ_ENTRY(NetClientState) next; >> +/* protect the race access of

[Qemu-devel] [Bug 1098729] Re: qemu-user-static for armhf: segfault in threaded code

2013-06-19 Thread thierry bultel
I also experimented the bug. It may SIGSEGV or hang. Or it may work, very rarely. But I cannot reproduce it at all if change my app to stay on a single CPU: int main(int argc, char * argv[] ) { #ifdef QEMU cpu_set_t cpuSet; CPU_ZERO(&cpuSet); CPU_SET(0,&cpuSet); if (sched_setaffi

[Qemu-devel] deadlock while running graphics application on QEMU

2013-06-19 Thread Mirza, Taimoor
Hi Guys, I am trying to run graphics demo application on QEMU system emulator using SDL on Windows XP. On running QEMU, its Window appears and then gets stuck. It seems some kind of deadlock to me. Same application runs fine on Windows 7 or if I use QEMU 0.15 on Windows XP. I found similar prob

Re: [Qemu-devel] [PATCH 06/12] spapr-vty: add copyright and license

2013-06-19 Thread David Gibson
On Wed, Jun 19, 2013 at 03:40:29PM -0500, Anthony Liguori wrote: > If you are on CC, then please Ack this patch as you touched this > file at some point in time. > > Cc: Alexey Kardashevskiy > Cc: Andreas Färber > Cc: David Gibson > Cc: Michael Ellerman > Cc: Paolo Bonzini > Signed-off-by: An

Re: [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)

2013-06-19 Thread Michael Tokarev
20.06.2013 01:40, Alexander Graf wrote: > > On 19.06.2013, at 23:08, Stefan Weil wrote: > >> This kind of type cast must use uintptr_t or target_ulong to be portable >> for hosts with sizeof(void *) != sizeof(long). >> >> Here the value is assigned to a variable of type target_ulong. >> >> Signed

[Qemu-devel] Virtio-Balloon : config_set_size

2013-06-19 Thread Saptarshi Sen
Hi all, I am experimenting with the Virtio- balloon driver in qemu. When I set the balloon size to a arbitrary low value. I see the actual value of the balloon set is not what I intended but to a level probably decided by the system. I am not able to explain this part who d

Re: [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)

2013-06-19 Thread Stefan Weil
Am 19.06.2013 23:40, schrieb Alexander Graf: > On 19.06.2013, at 23:08, Stefan Weil wrote: > >> This kind of type cast must use uintptr_t or target_ulong to be portable >> for hosts with sizeof(void *) != sizeof(long). >> >> Here the value is assigned to a variable of type target_ulong. >> >> Signe

[Qemu-devel] [Bug 1192780] [NEW] qemu-kvm with snapshot option always fails with Permission denied Could not open disk image

2013-06-19 Thread Sam Stoelinga
Public bug reported: I'm trying to use the option: -snapshot write to temporary files instead of disk image files How to reproduce? See following log: 2013-06-20 02:13:18.532+: starting up LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/sbin:/sbin:/bin QEMU_AUDIO_DRV=none /u

Re: [Qemu-devel] [PATCH 06/12] spapr-vty: add copyright and license

2013-06-19 Thread Alexey Kardashevskiy
Yes, touched and forgot :) Acked-by: Alexey Kardashevskiy On 06/20/2013 06:40 AM, Anthony Liguori wrote: > If you are on CC, then please Ack this patch as you touched this > file at some point in time. > > Cc: Alexey Kardashevskiy > Cc: Andreas Färber > Cc: David Gibson > Cc: Michael Ellerm

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-06-19 Thread Wenchao Xia
于 2013-6-20 9:33, Asias He 写道: On Wed, Jun 19, 2013 at 12:55:10PM +, Libaiqing wrote: Hi paolo, The vhost-scsi device can be used as boot device? I tested with your config + 3.10 rc6 + seabios 1.7.2.2,but failed. Could you give me some advise to debug this problem ? I can provide mo

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-19 Thread Wenchao Xia
于 2013-6-19 22:24, Stefan Hajnoczi 写道: On Wed, Jun 19, 2013 at 04:53:38PM +0800, Wenchao Xia wrote: 于 2013-6-19 15:46, Stefan Hajnoczi 写道: On Wed, Jun 19, 2013 at 02:18:48PM +0800, Wenchao Xia wrote: 于 2013-6-18 22:20, Stefan Hajnoczi 写道: On Mon, Jun 17, 2013 at 11:25:26AM +0800, Wenchao Xia

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
On 06/19/2013 09:49 PM, Stefan Hajnoczi wrote: Where does that code live that writes DISKDUMP files? I can see the diskdump.[ch] code. Sorry, I cannot catch what do you mean here. The file format is pretty bad: we need 4 temporary files and a lot of data copying to write it out. Why not ju

Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable

2013-06-19 Thread Zhi Yong Wu
On Wed, Jun 19, 2013 at 10:10 PM, Kevin Wolf wrote: > HMP is meant for humans and you should notice it. > > This changes the output format to use a bit more space to display the > information more readable and leaves out irrelevant information (e.g. > mention only that an image is encrypted, but n

Re: [Qemu-devel] [PATCH] hmp: Make "info block" output more readable

2013-06-19 Thread Fam Zheng
On Wed, 06/19 16:10, Kevin Wolf wrote: > HMP is meant for humans and you should notice it. > > This changes the output format to use a bit more space to display the > information more readable and leaves out irrelevant information (e.g. > mention only that an image is encrypted, but not when it's

Re: [Qemu-devel] [PATCH 06/12] spapr-vty: add copyright and license

2013-06-19 Thread Michael Ellerman
On Wed, 2013-06-19 at 15:40 -0500, Anthony Liguori wrote: > If you are on CC, then please Ack this patch as you touched this > file at some point in time. Barely, but yes. Acked-by: Michael Ellerman cheers > diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c > index 2993848..ecc2bb5 10064

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-06-19 Thread Asias He
On Wed, Jun 19, 2013 at 12:55:10PM +, Libaiqing wrote: > Hi paolo, > The vhost-scsi device can be used as boot device? > I tested with your config + 3.10 rc6 + seabios 1.7.2.2,but failed. > Could you give me some advise to debug this problem ? I can provide more > information if need. B

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket

2013-06-19 Thread li guang
在 2013-06-19三的 12:28 +0400,Michael Tokarev写道: > 18.06.2013 07:45, liguang wrote: > > local variables is_* should be bool by usage, > > and last parameter of qemu_opt_get_bool is bool, > > so pass true/false for it. > > > > Signed-off-by: liguang > > --- > > qemu-char.c | 20 ++-

Re: [Qemu-devel] [PATCH v2] cadence_uart: Handle backend tx errors

2013-06-19 Thread Peter Crosthwaite
On Thu, Jun 20, 2013 at 12:20 AM, wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite Thanks! Regards, Peter > --- > > v1 -> v2: > Remove loop around qemu_chr_fe_write_all, it does not return short writes. > > hw/char/cadence_uart.c |

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Wanlong Gao
On 06/20/2013 01:39 AM, Paolo Bonzini wrote: > Il 19/06/2013 10:01, Wanlong Gao ha scritto: >> On 06/19/2013 04:19 AM, Bandan Das wrote: >>> Eduardo Habkost writes: >>> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: [...] > Also, please use QemuOpts instead of yet ano

Re: [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Anthony Liguori
Alexander Graf writes: > On 19.06.2013, at 23:49, Anthony Liguori wrote: > >> Alexander Graf writes: >> >>> On 19.06.2013, at 22:40, Anthony Liguori wrote: >>> The creatively named reg field is a hypervisor assigned global identifier for a virtual device. Despite the fact that no de

Re: [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Benjamin Herrenschmidt
On Wed, 2013-06-19 at 23:28 +0200, Alexander Graf wrote: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > > > The creatively named reg field is a hypervisor assigned global > > identifier for a virtual device. Despite the fact that no device > > is assigned a reg of 0, guests still use it to r

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-19 Thread Scott Wood
On 06/16/2013 02:11:58 PM, Andreas Färber wrote: Am 15.06.2013 00:57, schrieb Scott Wood: > ...which of those would make me think "hmm, there's something in here > that I need to read before submitting patches for in-kernel mpic"? > > I'm not trying to be difficult -- I'm just trying to point

Re: [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg()

2013-06-19 Thread Anthony Liguori
Alexander Graf writes: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > >> Today if an invalid hcall is made to an otherwise valid device we >> abort due to QOM casting. This adds a parameter to find_by_reg() >> to indicate which type of device we're looking for. > > This should also adjust t

Re: [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 23:49, Anthony Liguori wrote: > Alexander Graf writes: > >> On 19.06.2013, at 22:40, Anthony Liguori wrote: >> >>> The creatively named reg field is a hypervisor assigned global >>> identifier for a virtual device. Despite the fact that no device >>> is assigned a reg of 0,

Re: [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Anthony Liguori
Alexander Graf writes: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > >> The creatively named reg field is a hypervisor assigned global >> identifier for a virtual device. Despite the fact that no device >> is assigned a reg of 0, guests still use it to refer to early >> console. >> >> Ins

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-19 Thread Scott Wood
On 06/16/2013 02:25:04 PM, Andreas Färber wrote: Subject is misleading: it's intc/openpic_kvm, not kvm/openpic. Alex, please fix when squashing. I meant it as a general description of the functional area, not as a literal pathname. It looks like that format is more of a Linux kernel thing

Re: [Qemu-devel] [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 23:45, Anthony Liguori wrote: > Alexander Graf writes: > >> On 19.06.2013, at 22:40, Anthony Liguori wrote: >> >>> Signed-off-by: Anthony Liguori >>> --- >>> hw/char/spapr_vty.c| 36 ++-- >>> hw/ppc/spapr_rtas.c| 18 ++--

Re: [Qemu-devel] [PATCH 05/12] spapr-vty: add qtest test case

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 23:43, Anthony Liguori wrote: > Alexander Graf writes: > >> On 19.06.2013, at 22:40, Anthony Liguori wrote: >> >>> Pretty basic for the moment but the interface is pretty simple. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> tests/Makefile | 3 ++ >>> tests/spa

Re: [Qemu-devel] [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces

2013-06-19 Thread Anthony Liguori
Alexander Graf writes: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > >> Signed-off-by: Anthony Liguori >> --- >> hw/char/spapr_vty.c| 36 ++-- >> hw/ppc/spapr_rtas.c| 18 ++ >> include/hw/ppc/spapr_vio.h | 2 -- >> 3 files chang

Re: [Qemu-devel] [PATCH 05/12] spapr-vty: add qtest test case

2013-06-19 Thread Anthony Liguori
Alexander Graf writes: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > >> Pretty basic for the moment but the interface is pretty simple. >> >> Signed-off-by: Anthony Liguori >> --- >> tests/Makefile | 3 ++ >> tests/spapr-vty-test.c | 89 >>

Re: [Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 23:08, Stefan Weil wrote: > This kind of type cast must use uintptr_t or target_ulong to be portable > for hosts with sizeof(void *) != sizeof(long). > > Here the value is assigned to a variable of type target_ulong. > > Signed-off-by: Stefan Weil Acked-by: Alexander Graf

Re: [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg()

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > Today if an invalid hcall is made to an otherwise valid device we > abort due to QOM casting. This adds a parameter to find_by_reg() > to indicate which type of device we're looking for. This should also adjust the hack to only match reg=0 for

Re: [Qemu-devel] [PATCH 10/12] spapr-vty: refactor the code to improve consistency

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > A few small changes folded into one cleanup: > - Fail gracefully when passed a reg of the wrong device type > - Don't cast uint8_t buf to uint64_t for argument marshalling > - Use spapr_vty prefix consistently. > > Signed-off-by: Anthony Liguori

Re: [Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > The creatively named reg field is a hypervisor assigned global > identifier for a virtual device. Despite the fact that no device > is assigned a reg of 0, guests still use it to refer to early > console. > > Instead of handling this in the VTY

Re: [Qemu-devel] Adding a persistent writeback cache to qemu

2013-06-19 Thread Alex Bligh
Stefan, --On 11 April 2013 11:25:48 +0200 Stefan Hajnoczi wrote: I'd like to experiment with adding persistent writeback cache to qemu. The use case here is where non-local storage is used (e.g. rbd, ceph) using the qemu drivers, together with a local cache as a file on a much faster locally

Re: [Qemu-devel] [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > hw/char/spapr_vty.c| 36 ++-- > hw/ppc/spapr_rtas.c| 18 ++ > include/hw/ppc/spapr_vio.h | 2 -- > 3 files changed, 28 insertions(+), 28 deletion

Re: [Qemu-devel] [PATCH 07/12] spapr-rtas: add CPU argument to RTAS calls

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > RTAS is a hypervisor provided binary blob that a guest loads and > calls into to execute certain functions. It's similar to the > vsyscall page in Linux or the short lived VMCI paravirt interface > from VMware. > > The QEMU implementation of the

Re: [Qemu-devel] [PATCH 05/12] spapr-vty: add qtest test case

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 22:40, Anthony Liguori wrote: > Pretty basic for the moment but the interface is pretty simple. > > Signed-off-by: Anthony Liguori > --- > tests/Makefile | 3 ++ > tests/spapr-vty-test.c | 89 ++ > 2 files changed, 92 inse

[Qemu-devel] [PATCH] pseries: Fix compiler warning (conversion of pointer to integral value)

2013-06-19 Thread Stefan Weil
This kind of type cast must use uintptr_t or target_ulong to be portable for hosts with sizeof(void *) != sizeof(long). Here the value is assigned to a variable of type target_ulong. Signed-off-by: Stefan Weil --- hw/ppc/spapr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Qemu-devel] [PATCH 04/12] qtest: add interface to save/restore

2013-06-19 Thread Anthony Liguori
The idea here is pretty simple. We have a synchronous interface that when called, does a migration to a file, kills the QEMU instance, and spawns a new one using the saved file state. We an then sprinkle calls to qtest_save_restore() thorough test cases to validate that we are properly saving and

[Qemu-devel] [PATCH 09/12] spapr-vio: move special case handling for reg=0 to vio

2013-06-19 Thread Anthony Liguori
The creatively named reg field is a hypervisor assigned global identifier for a virtual device. Despite the fact that no device is assigned a reg of 0, guests still use it to refer to early console. Instead of handling this in the VTY device, handle this in the VIO bus since this is ultimately ab

Re: [Qemu-devel] [PATCH v3 1/2] add a header file for atomic operations

2013-06-19 Thread Richard Henderson
On 06/19/2013 01:39 PM, Torvald Riegel wrote: > On Thu, 2013-06-20 at 04:59 +0800, Liu Ping Fan wrote: >> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c >> index fbabf99..28abe1e 100644 >> --- a/hw/virtio/vhost.c >> +++ b/hw/virtio/vhost.c >> @@ -16,6 +16,7 @@ >> #include >> #include "hw/vir

[Qemu-devel] [PATCH 02/12] qtest: add spapr hypercall support

2013-06-19 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- qtest.c | 29 + tests/libqtest.c | 18 ++ tests/libqtest.h | 46 ++ 3 files changed, 93 insertions(+) diff --git a/qtest.c b/qtest.c index 07a9612..f8c8f44 100644 -

[Qemu-devel] [PATCH 05/12] spapr-vty: add qtest test case

2013-06-19 Thread Anthony Liguori
Pretty basic for the moment but the interface is pretty simple. Signed-off-by: Anthony Liguori --- tests/Makefile | 3 ++ tests/spapr-vty-test.c | 89 ++ 2 files changed, 92 insertions(+) create mode 100644 tests/spapr-vty-test.c diff --

[Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg()

2013-06-19 Thread Anthony Liguori
Today if an invalid hcall is made to an otherwise valid device we abort due to QOM casting. This adds a parameter to find_by_reg() to indicate which type of device we're looking for. Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c| 14 -- hw/net/spapr_llan.c|

[Qemu-devel] [PATCH 10/12] spapr-vty: refactor the code to improve consistency

2013-06-19 Thread Anthony Liguori
A few small changes folded into one cleanup: - Fail gracefully when passed a reg of the wrong device type - Don't cast uint8_t buf to uint64_t for argument marshalling - Use spapr_vty prefix consistently. Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c | 57

[Qemu-devel] [PATCH 07/12] spapr-rtas: add CPU argument to RTAS calls

2013-06-19 Thread Anthony Liguori
RTAS is a hypervisor provided binary blob that a guest loads and calls into to execute certain functions. It's similar to the vsyscall page in Linux or the short lived VMCI paravirt interface from VMware. The QEMU implementation of the RTAS blob is simply a passthrough that proxies all RTAS calls

[Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME

2013-06-19 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c index aa56f10..6834fe2 100644 --- a/hw/char/spapr_vty.c +++ b/hw/char/spapr_vty.c @@ -65,7 +65,13 @@ static int spapr_vty_get

[Qemu-devel] [PATCH 06/12] spapr-vty: add copyright and license

2013-06-19 Thread Anthony Liguori
If you are on CC, then please Ack this patch as you touched this file at some point in time. Cc: Alexey Kardashevskiy Cc: Andreas Färber Cc: David Gibson Cc: Michael Ellerman Cc: Paolo Bonzini Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c | 13 + 1 file changed, 13 inse

[Qemu-devel] [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces

2013-06-19 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c| 36 ++-- hw/ppc/spapr_rtas.c| 18 ++ include/hw/ppc/spapr_vio.h | 2 -- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty

[Qemu-devel] [PATCH 01/12] chardev: ringbuf: add optional save parameter to save state

2013-06-19 Thread Anthony Liguori
It is very useful to use the ringbuf chardev for writing test cases and even more useful if the state of the ringbuf is migrated with the guest. Otherwise it's hard to detect data loss in a test case. Signed-off-by: Anthony Liguori --- qapi-schema.json | 3 ++- qemu-char.c | 45 ++

Re: [Qemu-devel] [PATCH v3 1/2] add a header file for atomic operations

2013-06-19 Thread Torvald Riegel
On Thu, 2013-06-20 at 04:59 +0800, Liu Ping Fan wrote: > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index fbabf99..28abe1e 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -16,6 +16,7 @@ > #include > #include "hw/virtio/vhost.h" > #include "hw/hw.h" > +#include "qemu/at

[Qemu-devel] [PATCH 03/12] qtest: return string from QMP commands

2013-06-19 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- tests/libqtest.c | 16 +--- tests/libqtest.h | 14 +++--- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 81107cf..235ec62 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -287,

[Qemu-devel] [PATCH 00/12] spapr: add qtest support and refactor vty

2013-06-19 Thread Anthony Liguori
Hi, This series introduces qtest support for spapr and adds a test case for spapr-vty. It then significantly refactors spapr-vty fixing among other things a number of guest driven aborts due to improper use of QOM cast macros. A neat trick included in this series is a save_restore() qtest functi

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Torvald Riegel
On Wed, 2013-06-19 at 17:14 +0200, Paolo Bonzini wrote: > Il 19/06/2013 15:15, Torvald Riegel ha scritto: > >> One reason is that implementing SC for POWER is quite expensive, > > > > Sure, but you don't have to use SC fences or atomics if you don't want > > them. Note that C11/C++11 as well as t

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Tim Deegan
At 11:21 -0700 on 19 Jun (1371640904), Matt Wilson wrote: > On Wed, Jun 19, 2013 at 11:42:06AM +0100, Alex Bligh wrote: > > > > --On 19 June 2013 10:13:17 + Paul Durrant > > wrote: > > > > >>We obviously can't say to users "Are you running Windows and are you > > >>running PV drivers >= X.Y,

Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

2013-06-19 Thread Richard Henderson
On 06/19/2013 12:57 PM, Ed Maste wrote: > Sounds good, although we need to pick up __executable_start too I > think; from my ld --verbose: > # PROVIDE (__executable_start = 0x40); . = 0x40 + SIZEOF_HEADERS; > > How about this? > > $ld --verbose | sed \ > -e '1,/

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Michael Tokarev
19.06.2013 22:52, Paolo Bonzini wrote: > Il 19/06/2013 20:18, Michael Tokarev ha scritto: >> Currently I expand it like this: >> >> $(foreach m, $(filter %.o,$1), $($(m:%.o=%.libs))) >> >> Probably I can change that to >> >> $(foreach m, $(filter %.o,$1), $($(m:%.o=./%.libs))) >> >> (here and i

Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

2013-06-19 Thread Ed Maste
On 19 June 2013 14:25, Richard Henderson wrote: > Given the large variance in the true default, I wonder if we shouldn't ignore > it entirely. I wonder if we can't edit more like this: > > s/[.] = .* [+] SIZEOF_HEADERS/. = $textseg_addr + SIZEOF_HEADERS/ Sounds good, although we need to pick u

Re: [Qemu-devel] [PATCH] vl: convert -smp to qemu_opts_parse()

2013-06-19 Thread Anthony Liguori
Michael Tokarev writes: > Signed-off-by: Michael Tokarev Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > vl.c | 122 > +- > 1 file changed, 69 insertions(+), 53 deletions(-) > > diff --git a/vl.c b/vl.c > index

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Richard Henderson
On 06/19/2013 11:52 AM, Paolo Bonzini wrote: >> > Do we really need it for modules? I'm not sure. Actually, in a modern >> > world, I'm not really sure libtool is needed if you only count "major" >> > operating systems. > Do you also count one major proprietary operating system? Unfortunately >

[Qemu-devel] [PATCH] vl: convert -smp to qemu_opts_parse()

2013-06-19 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- vl.c | 122 +- 1 file changed, 69 insertions(+), 53 deletions(-) diff --git a/vl.c b/vl.c index f94ec9c..530fa8f 100644 --- a/vl.c +++ b/vl.c @@ -1401,48 +1401,79 @@ static void numa_add(const cha

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Matt Wilson
On Wed, Jun 19, 2013 at 11:42:06AM +0100, Alex Bligh wrote: > > --On 19 June 2013 10:13:17 + Paul Durrant > wrote: > > >>We obviously can't say to users "Are you running Windows and are you > >>running PV drivers >= X.Y, if so set lever A to position B, otherwise if > >>you are running some o

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 20:18, Michael Tokarev ha scritto: > Currently I expand it like this: > > $(foreach m, $(filter %.o,$1), $($(m:%.o=%.libs))) > > Probably I can change that to > > $(foreach m, $(filter %.o,$1), $($(m:%.o=./%.libs))) > > (here and in other similar cases), and it will work witho

Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

2013-06-19 Thread Markus Armbruster
Markus Armbruster writes: > Anthony Liguori writes: > >> Markus Armbruster writes: >> >>> Next commit needs it. >>> >>> Cc: Blue Swirl >>> Signed-off-by: Markus Armbruster >>> --- >>> tests/boot-order-test.c | 24 >>> 1 file changed, 16 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [RFT PATCH] configure: Simplify alternate .text segment

2013-06-19 Thread Richard Henderson
On 06/18/2013 07:29 PM, Ed Maste wrote: > if test "$target_linux_user" = "yes" -o "$target_bsd_user" = "yes" ; then > + textseg_addr= >case "$ARCH" in > - alpha | s390x | aarch64) > -# The default placement of the application is fine. > + arm | hppa | i386 | ia64 | m68k | ppc | ppc64 |

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread James Harper
> > > -Original Message- > > From: Ian Campbell > > Sent: 19 June 2013 10:42 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > > Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. > > > > On Wed, 2013-06-19 at 10:32 +0100, Paul Durrant wrote

[Qemu-devel] [Bug 1192464] [NEW] udp checksum computed as 0 not converted to 0xffff, from guest os that share a common linux bridge among multiple guest os

2013-06-19 Thread bk.rakesh
Public bug reported: UDP checksum computed as '0' during transmission of packets that uses e1000 NIC in the Guest as well as emulated h/w in the qemu layer, That needs to be converted to 0x, This occurs only when Hardware checksum offload is been set in the guest OS NIC and made it as a transm

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Michael Tokarev
19.06.2013 20:58, Paolo Bonzini wrote: > Il 18/06/2013 19:34, Michael Tokarev ha scritto: >> The following working patchset demonstrates a one step to plugins system: >> it moves various dependent libraries and stuff out from libs_softmmu or >> libs_tools to object-specific variables. When that ob

Re: [Qemu-devel] [PATCH 2/2] remove unused check_params()

2013-06-19 Thread Markus Armbruster
Michael Tokarev writes: > last user was in -boot options processing Series conflicts with my "[PATCH v3 00/16] -boot and -no-fd-bootchk fixes". My series comes with fairly thorough tests.

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 10:01, Wanlong Gao ha scritto: > On 06/19/2013 04:19 AM, Bandan Das wrote: >> Eduardo Habkost writes: >> >>> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: >>> [...] Also, please use QemuOpts instead of yet another homegrown parser. Eduardo, I think you had

Re: [Qemu-devel] [PATCH qom-cpu v2 03/29] gdbstub: Simplify find_cpu()

2013-06-19 Thread Andreas Färber
Am 17.06.2013 21:54, schrieb Richard Henderson: > On 06/16/2013 08:57 AM, Andreas Färber wrote: >> Use qemu_get_cpu() and CPUState::env_ptr. >> >> Signed-off-by: Andreas Färber > > Reviewed-by: Richard Henderson Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu A

[Qemu-devel] [PATCH 1/2] vl: rewamp -boot options parsing

2013-06-19 Thread Michael Tokarev
This rewrites -boot option parsing to use qemu_opts_parse() with its current validation and abbreviation abilities. Signed-off-by: Michael Tokarev --- vl.c | 91 -- 1 file changed, 21 insertions(+), 70 deletions(-) diff --git a/v

[Qemu-devel] [PATCH 2/2] remove unused check_params()

2013-06-19 Thread Michael Tokarev
last user was in -boot options processing Signed-off-by: Michael Tokarev --- include/qemu/option.h |2 -- util/qemu-option.c| 30 -- 2 files changed, 32 deletions(-) diff --git a/include/qemu/option.h b/include/qemu/option.h index bdb6d21..a83c700 100644 --

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Paolo Bonzini
Il 18/06/2013 19:34, Michael Tokarev ha scritto: > The following working patchset demonstrates a one step to plugins system: > it moves various dependent libraries and stuff out from libs_softmmu or > libs_tools to object-specific variables. When that object is linked > into final executable, corr

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 16:16, Stefan Hajnoczi ha scritto: >> The foo.cflags isn't really necessary, but when you specify one >> > thing one way (target-specific variable), and another thing completely >> > different way, resulting code does not look nice. In particular, the >> > two curl definitions in blo

Re: [Qemu-devel] [PATCH v3 1/2] add a header file for atomic operations

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 18:37, Richard Henderson ha scritto: >> > +#ifndef atomic_read >> > +#define atomic_read(ptr) (*(__typeof__(*ptr) *volatile) (ptr)) >> > #endif >> > >> > +#ifndef atomic_set >> > +#define atomic_set(ptr, i) ((*(__typeof__(*ptr) *volatile) (ptr)) = >> > (i)) >> > +#endif

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 13:31, Paul Durrant ha scritto: > This is model we have followed in XenServer: the platform device > represents 'the set of PV drivers' and therefore to ship a new and > non-backwards-compatible set of PV drivers we incremented the > platform device id. But what is exactly the incomp

Re: [Qemu-devel] [PATCH v3 1/2] add a header file for atomic operations

2013-06-19 Thread Richard Henderson
On 06/19/2013 01:59 PM, Liu Ping Fan wrote: > +#ifndef atomic_read > +#define atomic_read(ptr) (*(__typeof__(*ptr) *volatile) (ptr)) > #endif > > +#ifndef atomic_set > +#define atomic_set(ptr, i) ((*(__typeof__(*ptr) *volatile) (ptr)) = (i)) > +#endif I still think these should be enh

[Qemu-devel] [PATCH 2/3] qapi.py: Allow top-level type reference for command definitions

2013-06-19 Thread Kevin Wolf
If 'data' for a command definition isn't a dict, but a string, it is taken as a (struct) type name and the fields of this struct are directly used as parameters. This is useful for transactionable commands that can use the same type definition for both the transaction action and the arguments of t

[Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

2013-06-19 Thread Kevin Wolf
We don't have to duplicate the definition any more now that we may refer to a type instead. Signed-off-by: Kevin Wolf --- qapi-schema.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index a80ee40..ee19d6a 100644 --- a/qapi-schema.jso

[Qemu-devel] [PATCH 1/3] qapi.py: Move common code to evaluate()

2013-06-19 Thread Kevin Wolf
Don't duplicate more code than is really necessary. Signed-off-by: Kevin Wolf --- scripts/qapi.py | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 02ad668..3a64769 100644 --- a/scripts/qapi.py +++ b/scripts/qap

[Qemu-devel] [PATCH 0/3] qapi: Top-level type reference for command definitions

2013-06-19 Thread Kevin Wolf
Kevin Wolf (3): qapi.py: Move common code to evaluate() qapi.py: Allow top-level type reference for command definitions qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync qapi-schema.json | 3 +-- scripts/qapi.py | 43 +-- 2 files cha

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Stefano Stabellini
On Wed, 19 Jun 2013, Paul Durrant wrote: > > -Original Message- > > From: qemu-devel-bounces+paul.durrant=citrix@nongnu.org > > [mailto:qemu-devel-bounces+paul.durrant=citrix@nongnu.org] On > > Behalf Of Stefano Stabellini > > Sent: 19 June 2013 14:53 > > To: Ian Campbell > > Cc: Pa

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
> -Original Message- > From: Tim Deegan [mailto:t...@xen.org] > Sent: 19 June 2013 16:46 > To: Paul Durrant > Cc: James Harper; Ian Campbell; qemu-devel@nongnu.org; xen- > de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. > > At 11:23 + on 19

Re: [Qemu-devel] [PULL 06/10] configure: dtc: Probe for libfdt_env.h

2013-06-19 Thread Peter Maydell
IIRC Paolo's ack on this patch came with a caveat of "if it is not for -stable" -- cc'ing him. thanks -- PMM On 19 June 2013 15:48, Cole Robinson wrote: > CCing qemu-stable. We want this for Fedora 19 at least where updated dtc broke > our build. > > - Cole > > On 06/14/2013 10:53 AM, Peter Mayd

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Tim Deegan
At 11:23 + on 19 Jun (1371641017), Paul Durrant wrote: > The problem is that the old Citrix PV drivers bind their version of > xenvbd directly to the platform device (id=1). The new PV drivers bind > their xenbus driver to their platform device, because to go onto > Windows Update you cannot ha

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Andrew Haley
On 06/19/2013 10:30 AM, Paolo Bonzini wrote: > Il 18/06/2013 19:38, Andrew Haley ha scritto: Or is Java volatile somewhere between acq_rel and seq_cst, as the last paragraph of http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html#volatile seems to suggest? >> As far as

Re: [Qemu-devel] backing file support for vpc/vhd ?

2013-06-19 Thread Kevin Wolf
Am 19.06.2013 um 16:02 hat Philipp Hahn geschrieben: > Hello, > > while working on a Xen-VM I noticed that qemu-img does not support the > backing file mechanism of vpc/vhd files, but Xens blktap2 does; it has a > libvhd and some tools to create and modify vpc/vhd files: > [...] > > Is the lack

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 15:15, Torvald Riegel ha scritto: >> One reason is that implementing SC for POWER is quite expensive, > > Sure, but you don't have to use SC fences or atomics if you don't want > them. Note that C11/C++11 as well as the __atomic* builtins allow you > to specify a memory order. It's

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Ian Campbell
On Wed, 2013-06-19 at 14:55 +0100, Stefano Stabellini wrote: > On Wed, 19 Jun 2013, Paul Durrant wrote: > > > -Original Message- > > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > > Sent: 18 June 2013 20:35 > > > To: Paolo Bonzini > > > Cc: Stefano Stabellini; Paul

[Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup

2013-06-19 Thread Michael S. Tsirkin
Avoid use of static variables: PC systems initialize pvpanic device through pvpanic_init, so we can simply create the fw_cfg file at that point. This also makes it possible to skip device creation completely if fw_cfg is not there, e.g. for xen - so the ports it reserves are not discoverable by gue

[Qemu-devel] [PATCH v3 2/2] pvpanic: fix fwcfg for big endian hosts

2013-06-19 Thread Michael S. Tsirkin
Convert port number to little endian when exposing it in fw cfg. Signed-off-by: Michael S. Tsirkin --- hw/misc/pvpanic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 83ed226..792d8e4 100644 --- a/hw/misc/pvpanic.c +++ b/hw

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-19 Thread Michael Tokarev
19.06.2013 18:16, Stefan Hajnoczi wrote: > On Tue, Jun 18, 2013 at 09:34:00PM +0400, Michael Tokarev wrote: >> The foo.cflags isn't really necessary, but when you specify one >> thing one way (target-specific variable), and another thing completely >> different way, resulting code does not look nic

Re: [Qemu-devel] [PULL 06/10] configure: dtc: Probe for libfdt_env.h

2013-06-19 Thread Cole Robinson
CCing qemu-stable. We want this for Fedora 19 at least where updated dtc broke our build. - Cole On 06/14/2013 10:53 AM, Peter Maydell wrote: > From: Peter Crosthwaite > > Currently QEMU provides a local clone of the file libfdt_env.h in > /include. This file is supposed to come with the libfdt

  1   2   3   >