Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-19 Thread Wenchao Xia
于 2013-6-18 22:20, Stefan Hajnoczi 写道: On Mon, Jun 17, 2013 at 11:25:26AM +0800, Wenchao Xia wrote: 于 2013-6-15 17:55, Eric Blake 写道: Should this command be made available via 'transaction'? That is, if I have a two-disk VM, and use 'transaction' to take a snapshot of both disks at once,

Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-19 Thread Wenchao Xia
于 2013-6-18 22:32, Stefan Hajnoczi 写道: On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/055 | 157 tests/qemu-iotests/055.out |5 ++ drive-backup

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-19 Thread Wenchao Xia
于 2013-6-18 18:13, Paolo Bonzini 写道: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt, {

Re: [Qemu-devel] [PATCH] block: add 'backing' option to drive_add

2013-06-19 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Tue, 06/18 16:18, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Tue, 06/18 08:32, Kevin Wolf wrote: Am 18.06.2013 um 05:58 hat Fam Zheng geschrieben: On Mon, 06/17 17:12, Kevin Wolf wrote: Am 17.06.2013 um 16:46 hat Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

2013-06-19 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Markus Armbruster arm...@redhat.com writes: Next commit needs it. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/boot-order-test.c | 24 1 file changed, 16

Re: [Qemu-devel] [PATCH] block: add 'backing' option to drive_add

2013-06-19 Thread Fam Zheng
On Wed, 06/19 08:27, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Tue, 06/18 16:18, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Tue, 06/18 08:32, Kevin Wolf wrote: Am 18.06.2013 um 05:58 hat Fam Zheng geschrieben: On Mon, 06/17 17:12, Kevin

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Torvald Riegel
On Tue, 2013-06-18 at 18:53 -0700, Paul E. McKenney wrote: On Tue, Jun 18, 2013 at 05:37:42PM +0200, Torvald Riegel wrote: On Tue, 2013-06-18 at 07:50 -0700, Paul E. McKenney wrote: First, I am not a fan of SC, mostly because there don't seem to be many (any?) production-quality

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-19 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 04:52:11PM +0200, Kevin Wolf wrote: Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: From: Dietmar Maurer diet...@proxmox.com backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call

Re: [Qemu-devel] [Qemu-trivial] [PATCH] acl: acl_add can't insert before last list element, fix

2013-06-19 Thread Michael Tokarev
18.06.2013 12:05, Markus Armbruster wrote: [] The second acl_add inserts at position 2 instead of 1. Root cause is an off-by-one in qemu_acl_insert(): when index == acl-nentries, it appends instead of inserting before the last list element. Thanks, applied to the trivial patches queue.

[Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest_quit()

2013-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/libqtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 879ffe9..bb82069 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s)

[Qemu-devel] [PATCH 2/2] libqtest: New qtest_end() to go with qtest_start()

2013-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- tests/fdc-test.c| 2 +- tests/hd-geo-test.c | 8 tests/ide-test.c| 2 +- tests/libqtest.h| 7 +++ 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index

[Qemu-devel] [PATCH 0/2] libqtest leak fix cleanup

2013-06-19 Thread Markus Armbruster
Markus Armbruster (2): libqtest: Plug fd and memory leaks in qtest_quit() libqtest: New qtest_end() to go with qtest_start() tests/fdc-test.c| 2 +- tests/hd-geo-test.c | 8 tests/ide-test.c| 2 +- tests/libqtest.c| 4 tests/libqtest.h| 7 +++ 5 files

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Fix QXLRam initialisation.

2013-06-19 Thread Michael Tokarev
17.06.2013 20:38, Anthony PERARD wrote: The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-19 Thread Stefan Hajnoczi
On Wed, Jun 19, 2013 at 02:18:48PM +0800, Wenchao Xia wrote: 于 2013-6-18 22:20, Stefan Hajnoczi 写道: On Mon, Jun 17, 2013 at 11:25:26AM +0800, Wenchao Xia wrote: 于 2013-6-15 17:55, Eric Blake 写道: Should this command be made available via 'transaction'? That is, if I have a two-disk VM, and

Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-19 Thread Stefan Hajnoczi
On Wed, Jun 19, 2013 at 02:21:31PM +0800, Wenchao Xia wrote: 于 2013-6-18 22:32, Stefan Hajnoczi 写道: On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: +def createSnapshotInTransaction(self, snapshot_num): +actions = [] +for i in range(0, len(self.expect)): +

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 2/5] block/nand: Formatting sweep

2013-06-19 Thread Michael Tokarev
18.06.2013 15:08, peter.crosthwa...@xilinx.com пишет: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Make this code closer to passing checkpatch. Mostly missing braces, but a few rogue tabs in there as well. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] block/nand: Factor out common code

2013-06-19 Thread Michael Tokarev
18.06.2013 15:08, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Most of this computation of s-iolen is the same for both the if and else paths here. Factor out the common parts outside the if. Cc: qemu-triv...@nongnu.org Signed-off-by: Peter

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Ian Campbell
On Tue, 2013-06-18 at 19:56 +0100, Stefano Stabellini wrote: On Fri, 14 Jun 2013, Paul Durrant wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: 14 June 2013 15:58 To: Paul Durrant Cc: Ian Campbell; Stefano

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-19 Thread Wanlong Gao
On 06/19/2013 04:19 AM, Bandan Das wrote: Eduardo Habkost ehabk...@redhat.com writes: On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: [...] Also, please use QemuOpts instead of yet another homegrown parser. Eduardo, I think you had the most recent attempt to convert -numa to

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] block/nand: Factor out common code

2013-06-19 Thread Peter Crosthwaite
Hi Michael, On Wed, Jun 19, 2013 at 6:09 PM, Michael Tokarev m...@tls.msk.ru wrote: 18.06.2013 15:08, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Most of this computation of s-iolen is the same for both the if and else paths here. Factor out the

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions

2013-06-19 Thread Michael Tokarev
18.06.2013 07:45, liguang wrote: last parameters of vnc_listen_read,vnc_connect are bool, so pass 'false/true' instead of '0/1' for them. Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: liguang lig.f...@cn.fujitsu.com I think I'll apply my version instead, -- which converts

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket

2013-06-19 Thread Michael Tokarev
18.06.2013 07:45, liguang wrote: local variables is_* should be bool by usage, and last parameter of qemu_opt_get_bool is bool, so pass true/false for it. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- qemu-char.c | 20 ++-- 1 files changed, 10 insertions(+), 10

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Paul Durrant
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 18 June 2013 20:35 To: Paolo Bonzini Cc: Stefano Stabellini; Paul Durrant; qemu-devel@nongnu.org; xen- de...@lists.xen.org; Ian Campbell Subject: Re: [Xen-devel] [PATCH] Remove hardcoded

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Ian Campbell
On Tue, 2013-06-18 at 23:38 +0200, Andreas Färber wrote: Am 18.06.2013 21:35, schrieb Stefano Stabellini: On Tue, 18 Jun 2013, Paolo Bonzini wrote: Il 18/06/2013 20:56, Stefano Stabellini ha scritto: xenfv-2.0 is a bad idea, like Paolo wrote, it should be possible to just use -M pc for

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 4/5] sd: pass bool parameter for sd_init

2013-06-19 Thread Michael Tokarev
Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen'

2013-06-19 Thread Michael Tokarev
18.06.2013 07:45, liguang wrote: [] -void sdl_display_init(DisplayState *ds, int full_screen, int no_frame); +void sdl_display_init(DisplayState *ds, bool full_screen, int no_frame); The same applies to no_frame, isn't it? These conversions to bool are like this -- thankless, because there are

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 19 June 2013 09:29 To: Andreas Färber Cc: Stefano Stabellini; Paolo Bonzini; Paul Durrant; xen-de...@lists.xen.org; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen- platform device initialization

[Qemu-devel] [PATCH trivial] vnc: use booleans for vnc_connect, vnc_listen_read and vnc_display_add_client

2013-06-19 Thread Michael Tokarev
Some arguments to these functions are booleans - either by declaration, or by actual usage, but sometimes value of 0 or 1 is passed for a bool, and sometimes it is declared as int but a bool value, or true/false, is passed to it instead. Clean it up a bit. Cc: liguang lig.f...@cn.fujitsu.com

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 10:29, Ian Campbell ha scritto: You could check for existence of the pc-i440fx-1.6 machine and infer that it is at least v1.6 (might break in some distant future of course and for current git commits until your changes get merged). Actually, this raises an interesting point.

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/5] block/nand: Factor out common code

2013-06-19 Thread Michael Tokarev
19.06.2013 12:13, Peter Crosthwaite wrote: [] All sounds fair. Ill have another look in the context of type changing, and factoring out some commonality. Your able to take P2 without conflict? :) Thanks! And sure, either with or without your next reformatting (block/nand: Formatting sweep)

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-19 Thread Wenchao Xia
于 2013-6-19 15:46, Stefan Hajnoczi 写道: On Wed, Jun 19, 2013 at 02:18:48PM +0800, Wenchao Xia wrote: 于 2013-6-18 22:20, Stefan Hajnoczi 写道: On Mon, Jun 17, 2013 at 11:25:26AM +0800, Wenchao Xia wrote: 于 2013-6-15 17:55, Eric Blake 写道: Should this command be made available via 'transaction'?

Re: [Qemu-devel] [PATCH v1 1/5] block/nand: Factor out common code

2013-06-19 Thread Peter Maydell
On 18 June 2013 12:08, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Most of this computation of s-iolen is the same for both the if and else paths here. Factor out the common parts outside the if. Cc: qemu-triv...@nongnu.org Please don't cc

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-19 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 09:34:39PM -0700, ronnie sahlberg wrote: I can reproduce with current QEMU. Ubuntu 13 crashes with if=virtio but if=ide is fine. But it seems dependent on the guest/kernel. For example Fedora-18-x86_64-Live-Desktop.iso installs and runs just fine, even with

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Ian Campbell
On Wed, 2013-06-19 at 10:41 +0200, Paolo Bonzini wrote: Il 19/06/2013 10:29, Ian Campbell ha scritto: You could check for existence of the pc-i440fx-1.6 machine and infer that it is at least v1.6 (might break in some distant future of course and for current git commits until your changes

Re: [Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice

2013-06-19 Thread Stefan Hajnoczi
On Wed, Jun 19, 2013 at 12:24:13AM +0400, Michael Tokarev wrote: $(block-obj-y) already includes block/, so there's no need to add it explicitly to $(common-obj-y). Signed-off-by: Michael Tokarev m...@tls.msk.ru --- Makefile.objs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [Bug 1192344] [NEW] qemu crashes on unaligned extended disk reads

2013-06-19 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 09:23:31PM -, Andrew McGowen wrote: When performing a BIOS extended disk read (INT 13H, AH=0x42), if the offset of the buffer destination in the DAP (disk address packet) is not dword-aligned (i.e. a multiple of 4), SeaBIOS attempts to execute code at non-mapped

Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-19 Thread Wenchao Xia
On Wed, Jun 19, 2013 at 02:21:31PM +0800, Wenchao Xia wrote: 于 2013-6-18 22:32, Stefan Hajnoczi 写道: On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: +def createSnapshotInTransaction(self, snapshot_num): +actions = [] +for i in range(0, len(self.expect)): +

Re: [Qemu-devel] [PATCH] eepro100: fix compile warning

2013-06-19 Thread Stefan Hajnoczi
On Wed, Jun 19, 2013 at 11:12:41AM +0800, Wanlong Gao wrote: hw/net/eepro100.c:108:0: error: BIT redefined [-Werror] In file included from /work/git/qemu/include/qemu/bitmap.h:16:0, from /work/git/qemu/include/sysemu/sysemu.h:12, from hw/net/eepro100.c:48:

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-19 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 19 June 2013 09:56 To: Paolo Bonzini Cc: Andreas Färber; Stefano Stabellini; Paul Durrant; xen- de...@lists.xen.org; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen- platform device initialization

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-19 Thread Laszlo Ersek
On 06/19/13 06:34, ronnie sahlberg wrote: I can reproduce with current QEMU. Ubuntu 13 crashes with if=virtio but if=ide is fine. But it seems dependent on the guest/kernel. For example Fedora-18-x86_64-Live-Desktop.iso installs and runs just fine, even with virtio But both

Re: [Qemu-devel] [PATCH] eepro100: fix compile warning

2013-06-19 Thread Wanlong Gao
On 06/19/2013 05:10 PM, Stefan Hajnoczi wrote: On Wed, Jun 19, 2013 at 11:12:41AM +0800, Wanlong Gao wrote: hw/net/eepro100.c:108:0: error: BIT redefined [-Werror] In file included from /work/git/qemu/include/qemu/bitmap.h:16:0, from /work/git/qemu/include/sysemu/sysemu.h:12,

[Qemu-devel] [PATCH] qapi: lack of two commas in dict

2013-06-19 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 128cc58..38acd25 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -388,7 +388,7 @@ # # Since: 1.4 ## -{

[Qemu-devel] [PATCH] qapi: lack of two commas in dict

2013-06-19 Thread Amos Kong
Signed-off-by: Amos Kong ak...@redhat.com --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 128cc58..38acd25 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -388,7 +388,7 @@ # # Since: 1.4 ## -{

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 00:26, mdroth ha scritto: On Tue, Jun 18, 2013 at 09:20:26PM +0200, Paolo Bonzini wrote: Il 18/06/2013 17:14, mdroth ha scritto: Could we possibly simplify this by introducing a recursive mutex that we could use to protect the whole list loop and hold even during the cb? If it

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Paolo Bonzini
Il 18/06/2013 19:38, Andrew Haley ha scritto: Or is Java volatile somewhere between acq_rel and seq_cst, as the last paragraph of http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html#volatile seems to suggest? As far as I know, the Java semantics are acq/rel. I can't see

[Qemu-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
The XenServer 6.1+ Citrix Windows PV bus driver binds to a new version of the Xen platform device (since the newer driver set cannot co-exist with previous drivers which bind to the existing xen-platform type of device). This patch introduces a new xen-platform-2 device type with the appropriate

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-19 Thread Paolo Bonzini
Il 18/06/2013 18:38, Torvald Riegel ha scritto: I don't think that this is the conclusion here. I strongly suggest to just go with the C11/C++11 model, instead of rolling your own or trying to replicate the Java model. That would also allow you to just point to the C11 model and any

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 08:27, Wenchao Xia ha scritto: gcc is too stupid to understand the control flow. The initialization shuts it up. Looks like most people's GCC is not that stupid, or I would have broken build for everyone, right? my gcc version: [xiawenc@RH63Wenchao ~]$ gcc -v Using

Re: [Qemu-devel] [0/3] Accumulated ppc patches

2013-06-19 Thread Alexander Graf
On 19.06.2013, at 01:20, Alexey Kardashevskiy wrote: On 06/19/2013 01:49 AM, Alexander Graf wrote: On 15.06.2013, at 03:51, David Gibson wrote: Hi Alex, I see that you're now back from your holiday. Here, rather belatedly, is my series of ppc related patches collected while acting

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 19 June 2013 10:42 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. On Wed, 2013-06-19 at 10:32 +0100, Paul Durrant wrote: The XenServer 6.1+

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Ian Campbell
On Wed, 2013-06-19 at 10:32 +0100, Paul Durrant wrote: The XenServer 6.1+ Citrix Windows PV bus driver binds to a new version of the Xen platform device (since the newer driver set cannot co-exist with previous drivers which bind to the existing xen-platform type of device). This patch

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Ian Campbell
On Wed, 2013-06-19 at 10:43 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 19 June 2013 10:42 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. On Wed,

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
On 06/14/2013 02:12 AM, Luiz Capitulino wrote: I've started reviewing this, but I'm out of cycles for this week. Hi Luiz, No comments yet? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 1/2] Revert migration: do not sent zero pages in bulk stage

2013-06-19 Thread Paolo Bonzini
Il 06/06/2013 10:36, Peter Lieven ha scritto: Not sending zero pages breaks migration if a page is zero at the source but not at the destination. This can e.g. happen if different BIOS versions are used at source and destination. It has also been reported that migration on pseries is

Re: [Qemu-devel] [PATCH 2/2] migration: do not overwrite zero pages

2013-06-19 Thread Paolo Bonzini
Il 06/06/2013 10:36, Peter Lieven ha scritto: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a MADV_DONTNEED later this will only deallocate the memory asynchronously.

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: Ian Campbell Sent: 19 June 2013 11:08 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. On Wed, 2013-06-19 at 10:43 +0100, Paul Durrant wrote: -Original

Re: [Qemu-devel] [PATCH v3 2/2] block: move the bdrv_dev_change_media_cb()

2013-06-19 Thread Stefan Hajnoczi
On Mon, Jun 17, 2013 at 03:21:41PM +0200, Pavel Hrdina wrote: The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls the change_media_cb() and also emit the

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Tim Deegan
At 11:07 +0100 on 19 Jun (1371640052), Ian Campbell wrote: On Wed, 2013-06-19 at 10:43 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 19 June 2013 10:42 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel]

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Alex Bligh
--On 19 June 2013 10:13:17 + Paul Durrant paul.durr...@citrix.com wrote: We obviously can't say to users Are you running Windows and are you running PV drivers = X.Y, if so set lever A to position B, otherwise if you are running some other OS or an earlier version of the Windows PV

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Ian Campbell
On Wed, 2013-06-19 at 11:13 +0100, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 19 June 2013 11:08 To: Paul Durrant Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: Re: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. On Wed,

Re: [Qemu-devel] -nographic and -daemonize wrt qemu-system-sparc

2013-06-19 Thread Michael Tokarev
01.06.2013 14:50, Michael Tokarev wrote: [Replying to a very old email which I missed initially] Todd, do you still have the issue you describe? I mean, not that we changed lots in that area (I guess we changed nothing there), but i'm not sure I understand what is going on there, and why

[Qemu-devel] [PATCH 1/2] fix -net user checks by reordering checks

2013-06-19 Thread Jan Kiszka
From: Bas van Sisseren b...@quarantainenet.nl reorder slirp config options. first check the dns-server-address, then check the first-dhcp-address. the original code was comparing the first-dhcp-address with the default dns-server-address, not the configured dns-server-address. Signed-off-by: Bas

[Qemu-devel] [PATCH 2/2] make user networking hostfwd work with restrict=y

2013-06-19 Thread Jan Kiszka
From: Gertjan Halkes q...@ghalkes.nl This patch allows the hostfwd option to override the restrict=y setting in the user network stack, as explicitly stated in the documentation on the restrict option: restrict=on|off If this option is enabled, the guest will be isolated, i.e. it

[Qemu-devel] [PATCH 0/2] [PULL] slirp: various fixes

2013-06-19 Thread Jan Kiszka
The following changes since commit c1990468d5a13c8f1d9111fcca0a78a6adad062b: wdt_i6300esb: fix vmstate versioning (2013-06-18 13:44:37 -0500) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Bas van Sisseren (1): fix -net user checks by reordering

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: From: Dietmar Maurer diet...@proxmox.com backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads

Re: [Qemu-devel] [PATCH v1 3/5] block/nand: QOM casting sweep

2013-06-19 Thread Andreas Färber
Am 18.06.2013 13:10, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct - style casting. Cc: afaer...@suse.de Signed-off-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: notifier_list_notify() has no return value. This is fine when we just want to invoke side-effects. Sometimes it's useful for notifiers to produce a return value. This allows notifiers to veto an operation and will be used by the block

Re: [Qemu-devel] [PATCH v5 02/11] block: add bdrv_add_before_write_notifier()

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: The bdrv_add_before_write_notifier() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before

Re: [Qemu-devel] [PATCH v1 4/5] block/nand: Convert Sysbus::init to Device::realize

2013-06-19 Thread Andreas Färber
Am 18.06.2013 13:11, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com The prescribed transition from Sysbus::init function to a Device::realize. Cc: afaer...@suse.de Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: It is not necessary to check that we can find a protocol block driver since we create or open the image file. This produces the error that we need anyway. Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the protocol is

Re: [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror()

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: Use bdrv_getlength() for its byte units and error return instead of bdrv_get_geometry(). Reported-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v1 5/5] nand: Don't inherit from Sysbus

2013-06-19 Thread Andreas Färber
Am 18.06.2013 13:12, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Nand chips are not sysbus devices - they do not have any sense of MMIO, nor interrupts. Re-parent to TYPE_DEVICE accordingly. Cc: afaer...@suse.de Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: @drive-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing drive-backup operations can be checked with query-block-jobs where the BlockJobInfo.type field has the value 'backup'. The

Re: [Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: The QMP 'transaction' command keeps a list of in-flight transactions. The transaction state structure is called BlkTransactionStates even though it only deals with a single transaction. The only plural thing is the linked list of

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 12:50, Kevin Wolf ha scritto: +/* Publish progress */ +job-sectors_read += n; +job-common.offset += n * BDRV_SECTOR_SIZE; This is interesting, because the function is not only called by the background job, but also by write notifiers. So 'offset' in a

Re: [Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps-commit() to be NULL

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The drive-backup action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job

[Qemu-devel] qemu-ga behavior on virtio-serial unplug

2013-06-19 Thread Laszlo Ersek
Hello Michael, this is with reference to https://bugzilla.redhat.com/show_bug.cgi?id=907733. Ever since the initial qemu-ga commit AFAICS an exception for virtio-serial has existed, when reading EOF from the channel. For isa-serial, EOF results in the client connection being closed. I assume

Re: [Qemu-devel] [PATCH v5 09/11] blockdev: add DriveBackup transaction

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: This patch adds a transactional version of the drive-backup QMP command. It allows atomic snapshots of multiple drives along with automatic cleanup if there is a failure to start one of the backup jobs. Note that QMP events are emitted

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-19 Thread Paolo Bonzini
Il 19/06/2013 12:50, Kevin Wolf ha scritto: + +DPRINTF(%s enter %s C% PRId64 % PRId64 %d\n, +__func__, bdrv_get_device_name(bs), start, sector_num, nb_sectors); Maybe put the first %s and __func__ directly into the DPRINTF macro? Or just use tracepoints.

Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction

2013-06-19 Thread Kevin Wolf
Am 03.06.2013 um 11:21 hat Stefan Hajnoczi geschrieben: On Thu, May 30, 2013 at 07:11:25AM -0600, Eric Blake wrote: On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and

Re: [Qemu-devel] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-19 Thread chandrashekar shastri
On 06/14/2013 03:15 AM, Paolo Bonzini wrote: Il 13/06/2013 13:26, chandrashekar shastri ha scritto: On 06/13/2013 02:14 PM, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 10:31:04AM +0530, chandrashekar shastri wrote: We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: James Harper [mailto:james.har...@bendigoit.com.au] Sent: 19 June 2013 11:55 To: Paul Durrant; Ian Campbell Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: RE: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. -Original

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: qemu-devel-bounces+paul.durrant=citrix@nongnu.org [mailto:qemu-devel-bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Tim Deegan Sent: 19 June 2013 11:36 To: Ian Campbell Cc: Paul Durrant; qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject:

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: Alex Bligh [mailto:a...@alex.org.uk] Sent: 19 June 2013 11:42 To: Paul Durrant; Ian Campbell Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Alex Bligh Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2. --On 19

Re: [Qemu-devel] [Xen-devel] [PATCH] Add Xen platform PCI device version 2.

2013-06-19 Thread Paul Durrant
-Original Message- From: James Harper [mailto:james.har...@bendigoit.com.au] Sent: 19 June 2013 11:55 To: Paul Durrant; Ian Campbell Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org Subject: RE: [Xen-devel] [PATCH] Add Xen platform PCI device version 2. -Original

Re: [Qemu-devel] [PATCH v4 1/9] dump: Add API to manipulate dump_bitmap

2013-06-19 Thread Andreas Färber
Am 28.05.2013 04:50, schrieb qiaonuo...@cn.fujitsu.com: From: Qiao Nuohan qiaonuo...@cn.fujitsu.com Struct dump_bitmap is associated with a tmp file which is used to store bitmap in kdump-compressed format temporarily. The following patch will use these functions to gather data of bitmap and

Re: [Qemu-devel] [PATCH v3] vl.c: Support multiple CPU ranges on -numa option

2013-06-19 Thread Igor Mammedov
On Tue, 18 Jun 2013 16:09:49 -0400 Bandan Das b...@redhat.com wrote: This allows us to use the cpu property multiple times to specify multiple cpu (ranges) to the -numa option : -numa node,cpu=1,cpu=2,cpu=4 or -numa node,cpu=1-3,cpu=5 Signed-off-by: Bandan Das b...@redhat.com ---

[Qemu-devel] [PATCH v2 1/5] Revert block: Disable driver-specific options for 1.5

2013-06-19 Thread Kevin Wolf
This reverts commit 8ec7d390b0d50b5e5b4b1d8dba7ba40d64a70875. Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 118 ++- tests/qemu-iotests/group | 2 +- 2 files changed, 5 insertions(+), 115 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/5] qcow2: Discard freed clusters

2013-06-19 Thread Kevin Wolf
This series adds options to make qcow2 discard freed clusters, in several categories. By default, only freed clusters related to snapshots (i.e. mainly snapshot deletion) are discarded. v2: - Removed leftover debug code - Don't discard after COW (overwriting compressed clusters) - Changed some

[Qemu-devel] [PATCH 2/8] exec: Clean up fall back when -mem-path allocation fails

2013-06-19 Thread Markus Armbruster
With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate accordingly, but when it fails, it falls back to normal allocation. The fall back allocation code used to be effectively identical to the -mem-path not given code, until it started to diverge in commit 432d268. I believe the code

[Qemu-devel] [PATCH 1/8] exec: Fix Xen RAM allocation with unusual options

2013-06-19 Thread Markus Armbruster
Issues: * We try to obey -mem-path even though it can't work with Xen. * To implement -machine mem-merge, we call memory_try_enable_merging(new_block-host, size). But with Xen, new_block-host remains null. Oops. Fix by separating Xen allocation from normal allocation. Acked-by: Stefano

[Qemu-devel] [PATCH 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-19 Thread Markus Armbruster
Another issue missed in commit fdec991 is -mem-path: it needs to be rejected only for old S390 KVM, not for any S390. Not that I personally care, but the ifdeffery in qemu_ram_alloc_from_ptr() annoys me. Note that this doesn't actually make -mem-path work, as the kernel doesn't (yet?) support

[Qemu-devel] [PATCH 4/8] exec: Simplify the guest physical memory allocation hook

2013-06-19 Thread Markus Armbruster
Make it a generic hook rather than a KVM hook. Less code and ifdeffery. Since the only user of the hook is old S390 KVM, there's hope we can get rid of it some day. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 20 ++-- include/exec/exec-all.h

[Qemu-devel] [PATCH 3/8] exec: Reduce ifdeffery around -mem-path

2013-06-19 Thread Markus Armbruster
Instead of spreading its ifdeffery everywhere, confine it to qemu_ram_alloc_from_ptr(). Everywhere else, simply test block-fd, which is non-negative exactly when block uses -mem-path. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 37

[Qemu-devel] [PATCH v2 2/5] qcow2: Add refcount update reason to all callers

2013-06-19 Thread Kevin Wolf
This adds a refcount update reason to all callers of update_refcounts(), so that a follow-up patch can use this information to decide whether clusters that reach a refcount of 0 should be discarded in the image file. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 19

[Qemu-devel] [PATCH v2 5/5] block: Always enable discard on the protocol level

2013-06-19 Thread Kevin Wolf
Turning on discard options in qcow2 doesn't help a lot when the discard requests that it issues are thrown away by the raw-posix layer. This patch always enables discard functionality on the protocol level so that it's the image format's responsibility to send (or not) discard requests. Requests

[Qemu-devel] [PATCH 5/8] exec: Drop incorrect dead S390 code in qemu_ram_remap()

2013-06-19 Thread Markus Armbruster
Old S390 KVM wants guest RAM mapped in a peculiar way. Commit 6b02494 implemented that. When qemu_ram_remap() got added in commit cd19cfa, its code carefully mimicked the allocation code: peculiar way if defined(TARGET_S390X) defined(CONFIG_KVM), else normal way. For new S390 KVM, we actually

[Qemu-devel] [PATCH v2 3/5] qcow2: Options to enable discard for freed clusters

2013-06-19 Thread Kevin Wolf
Deleted snapshots are discarded in the image file by default, discard requests take their default from the -drive discard=... option and other places that free clusters must always be enabled explicitly. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-refcount.c | 5 +

[Qemu-devel] [PATCH 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-19 Thread Markus Armbruster
We abort() on memory allocation failure. abort() is appropriate for programming errors. Maybe most memory allocation failures are programming errors, maybe not. But guest memory allocation failure isn't, and aborting when the user asks for more memory than we can provide is not nice. exit(1)

Re: [Qemu-devel] [PATCH 01/17] ide: Add handler to ide_cmd_table

2013-06-19 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 10:25:55AM +0200, Kevin Wolf wrote: As a preparation for moving all IDE commands into their own function like in the ATAPI code, introduce a 'handler' callback to ide_cmd_table. Commands using this new infrastructure get some things handled automatically: * The BSY

  1   2   3   >