25.07.2013 20:21, Stefan Weil wrote:
The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).
Thanks, applied to the trivial patches queue.
/mjt
26.07.2013 00:10, Stefan Weil wrote:
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Thanks, applied to
From: Petar Jovanovic petar.jovano...@imgtec.com
sys_mremap missed 5th argument (new_address), which caused examples that
remap to a specific address to fail.
sys_splice missed 5th and 6th argument which caused different examples to
fail.
This change has an effect on MIPS target only.
From: Stefan Weil s...@weilnetz.de
The current code includes assert.h very early (from qemu-common.h),
so the definition of NDEBUG was without any effect.
In the initial version from 2004, NDEBUG was used to disable the assertions.
Those assertions are not in time critical code, so it is no
From: Stefan Weil s...@weilnetz.de
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Signed-off-by: Stefan
From: Liu Ping Fan qemul...@gmail.com
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com
Reviewed-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
cpus.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.c
index
We collected a few more trivial patches this week, including a compile
failure fix for 32bit builds by Stefan Weil.
Please pull.
The following changes since commit 200a06397f5d3e982028fd78b25b420507ade021:
Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging
From: Stefan Weil s...@weilnetz.de
The global variable env was removed some time ago, so this name may be
used without any restriction now.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
include/exec/poison.h |1 -
1 file changed, 1
From: Stefan Weil s...@weilnetz.de
All these typos were found by codespell.
sould - should
emperical - empirical
intialization - initialization
successfuly - successfully
gaurantee - guarantee
Fix also another error (before before) in the same context.
Signed-off-by: Stefan Weil
From: Ramkumar Ramachandra artag...@gmail.com
Otherwise, a new user will be wondering how to switch between the
console and monitor.
Cc: Anthony Liguori aligu...@us.ibm.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: Markus Armbruster arm...@redhat.com
Cc: Marcelo Tosatti mtosa...@redhat.com
Cc:
From: Stefan Weil s...@weilnetz.de
Fix a number of warnings for 32 bit builds (tested on MingW and Linux):
CChw/ide/macio.o
qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb':
qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long
unsigned int', but
From: Stefan Weil s...@weilnetz.de
The leak was reported by cppcheck.
Function proxy_init also calls g_free for ctx-fs_root.
Avoid reuse of this memory by setting ctx-fs_root to NULL.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Michael
From: Stefan Weil s...@weilnetz.de
The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
blockdev.c |2 +-
From: Stefan Weil s...@weilnetz.de
This was dead code.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/watchdog/watchdog.c |1 -
1 file changed, 1 deletion(-)
diff --git a/hw/watchdog/watchdog.c
hi all,
I met similar problem to these, while performing live migration or
save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2,
guest:suse11sp2), running tele-communication software suite in guest,
https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00098.html
Il 27/07/2013 00:21, Mark Cave-Ayland ha scritto:
I suspect that there may be multiple breakages here (as HEAD blows up
differently with a trap failure), but this is definitely the start of
the chain.
Yes, the fixes so far are the following:
commit 2b8fbcd87007a170a9778ec6645c06f543977067
It is not a device, and the field is not used from code either.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/nvram/ds1225y.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c
index fa218ce..cca6f43 100644
--- a/hw/nvram/ds1225y.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/nvram/ds1225y.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c
index cca6f43..f9a700b 100644
--- a/hw/nvram/ds1225y.c
+++ b/hw/nvram/ds1225y.c
@@ -104,14 +104,19 @@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/milkymist-minimac2.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c
index becd26c..1e92379 100644
---
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/xilinx_ethlite.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
index 2afc91a..3a2a6c2 100644
--- a/hw/net/xilinx_ethlite.c
+++
Hello,
This series eliminates FROM_SYSBUS() in hw/ppc/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (1):
ppce500_spin: QOM cast cleanup
hw/ppc/ppce500_spin.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
--
1.8.1.4
Introduce type constant and use QOM cast.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ppc/ppce500_spin.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/ppc/ppce500_spin.c b/hw/ppc/ppce500_spin.c
index 11b7de2..78b23fa 100644
---
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/lan9118.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/hw/net/lan9118.c b/hw/net/lan9118.c
index 3323f48..2c838f6 100644
--- a/hw/net/lan9118.c
+++ b/hw/net/lan9118.c
@@ -170,8 +170,12 @@
On Fri, Jul 26, 2013 at 12:19:16PM +0200, Gerd Hoffmann wrote:
Maybe the xen guys did some optimizations in qemu-dm which where not
merged upstream. Try asking @ xen-devel.
Yeah, xen qemu-dm must have some optimization for cirrus that isn't in upstream
qemu.
Beside that the standard
Introduce type constant and use QOM casts and typedef consistently.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/xgmac.c | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/hw/net/xgmac.c b/hw/net/xgmac.c
index
Drop freeing stellaris_enet_state - that is done by QOM later on unref.
Both MemoryRegion init and savevm registration happen in SysBusDevice
initfn currently, so move them into an unrealizefn for now.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/stellaris_enet.c | 16
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc/sun4m.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index eb3b11b..e5c6881 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -612,8 +612,12 @@ static const
Hello,
This series eliminates FROM_SYSBUS() in hw/sparc/ and hw/sparc64/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (6):
sun4m: QOM cast cleanup for IDRegState
sun4m: QOM cast cleanup for AFXState
sun4m: QOM cast cleanup for PROMState
sun4m: QOM cast cleanup for
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc/sun4m.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index b943a07..942ca37 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -739,9 +739,12 @@ static const
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc/sun4m.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 5c7bd31..eb3b11b 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -559,6 +559,9 @@ static void
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc64/sun4u.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 9568028..a7214a3 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -714,9 +714,12 @@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc64/sun4u.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 34a5e73..9568028 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -632,8 +632,12 @@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sd/milkymist-memcard.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
index f69775c..42613b3 100644
--- a/hw/sd/milkymist-memcard.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc/sun4m.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index e5c6881..b943a07 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -658,8 +658,12 @@ static const
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sd/pl181.c | 56
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c
index f5eb1e4..dc08595 100644
--- a/hw/sd/pl181.c
+++ b/hw/sd/pl181.c
@@
Hello,
This series eliminates FROM_SYSBUS() in hw/sd/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (3):
milkymist-memcard: QOM cast cleanup
pl181: Rename pl181_state to PL181State
pl181: QOM cast cleanup
hw/sd/milkymist-memcard.c | 14 +
hw/sd/pl181.c
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sd/pl181.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c
index dc08595..03875bf 100644
--- a/hw/sd/pl181.c
+++ b/hw/sd/pl181.c
@@ -22,8 +22,12 @@ do { printf(pl181:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ssi/pl022.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c
index d33534e..fd479ef 100644
--- a/hw/ssi/pl022.c
+++ b/hw/ssi/pl022.c
@@ -39,8 +39,12 @@ do {
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ssi/pl022.c | 72 +-
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c
index 711a0c1..d33534e 100644
--- a/hw/ssi/pl022.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/cadence_gem.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index ac929cb..4a355bb 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
Hello,
This series eliminates FROM_SYSBUS() in hw/nvram/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (2):
ds1225y: Drop bogus qdev field from NvRamState
ds1225y: QOM cast cleanup
hw/nvram/ds1225y.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ssi/xilinx_spi.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
index 7a9fd81..d44caae 100644
--- a/hw/ssi/xilinx_spi.c
+++ b/hw/ssi/xilinx_spi.c
@@
-Original Message-
From: Andreas Färber [mailto:afaer...@suse.de]
Sent: Friday, July 26, 2013 6:28 PM
To: Gerd Hoffmann; Gonglei (Arei)
Cc: Anthony Liguori; Hanweidong; Luonengjun; qemu-devel@nongnu.org;
Huangweidong (Hardware); xen-de...@lists.xen.org
Subject: Re: [Qemu-devel]
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/stellaris_enet.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c
index aac7c76..6194e33 100644
--- a/hw/net/stellaris_enet.c
+++
Hello,
This series eliminates FROM_SYSBUS() in hw/ssi/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (3):
pl022: Rename pl022_state to PL022State
pl022: QOM cast cleanup
xilinx_spi: QOM cast cleanup
hw/ssi/pl022.c | 91
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/lance.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/hw/net/lance.c b/hw/net/lance.c
index 98bcdfc..cf86ba1 100644
--- a/hw/net/lance.c
+++ b/hw/net/lance.c
@@ -43,8 +43,13 @@
#include
Hello,
This series eliminates FROM_SYSBUS() in hw/net/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (11):
cadence_gem: QOM cast cleanup
etraxfs_eth: QOM cast cleanup
etraxfs_eth: Rename fs_eth to ETRAXFSEthState
lan9118: QOM cast cleanup
lance: QOM cast cleanup
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/etraxfs_eth.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c
index ab9a215..71b4fb8 100644
--- a/hw/net/etraxfs_eth.c
+++ b/hw/net/etraxfs_eth.c
@@ -322,9 +322,14
Also add a typedef.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/etraxfs_eth.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c
index 71b4fb8..b1febec 100644
---
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/smc91c111.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
index c49e37a..f5963e2 100644
--- a/hw/net/smc91c111.c
+++ b/hw/net/smc91c111.c
@@
On 27/07/13 09:55, Paolo Bonzini wrote:
Il 27/07/2013 00:21, Mark Cave-Ayland ha scritto:
I suspect that there may be multiple breakages here (as HEAD blows up
differently with a trap failure), but this is definitely the start of
the chain.
Yes, the fixes so far are the following:
commit
Hello,
This series eliminates FROM_SYSBUS() in hw/timer/.
Regards,
Andreas
Cc: Hu Tao hu...@cn.fujitsu.com
Andreas Färber (20):
arm_timer: Rename sp804_state to SP804State
arm_timer: QOM cast cleanup for SP804State
arm_timer: QOM cast cleanup for icp_pit_state
cadence_ttc: QOM cast
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/arm_timer.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c
index 8d95743..acfea59 100644
--- a/hw/timer/arm_timer.c
+++ b/hw/timer/arm_timer.c
@@ -298,8 +298,13
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/exynos4210_mct.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
index 28ebe5d..a8009a4 100644
--- a/hw/timer/exynos4210_mct.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/exynos4210_rtc.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/timer/exynos4210_rtc.c b/hw/timer/exynos4210_rtc.c
index 7fca071..3f2c8c5 100644
--- a/hw/timer/exynos4210_rtc.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/arm_timer.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c
index 25e8890..8d95743 100644
--- a/hw/timer/arm_timer.c
+++ b/hw/timer/arm_timer.c
@@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/cadence_ttc.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/timer/cadence_ttc.c b/hw/timer/cadence_ttc.c
index a861049..888f9ce 100644
--- a/hw/timer/cadence_ttc.c
+++ b/hw/timer/cadence_ttc.c
@@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/exynos4210_pwm.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/timer/exynos4210_pwm.c b/hw/timer/exynos4210_pwm.c
index 8fa0bb2..a52f0f6 100644
--- a/hw/timer/exynos4210_pwm.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/pl031.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/timer/pl031.c b/hw/timer/pl031.c
index e705a69..d5e2f3e 100644
--- a/hw/timer/pl031.c
+++ b/hw/timer/pl031.c
@@ -33,8 +33,12 @@ do { printf(pl031:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/arm_timer.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/timer/arm_timer.c b/hw/timer/arm_timer.c
index 798a8da..25e8890 100644
--- a/hw/timer/arm_timer.c
+++ b/hw/timer/arm_timer.c
@@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/tusb6010.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c
index 47b6809..c48ecf8 100644
--- a/hw/timer/tusb6010.c
+++ b/hw/timer/tusb6010.c
@@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/grlib_gptimer.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/timer/grlib_gptimer.c b/hw/timer/grlib_gptimer.c
index 37ba47d..7c1055a 100644
--- a/hw/timer/grlib_gptimer.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/lm32_timer.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/timer/lm32_timer.c b/hw/timer/lm32_timer.c
index 016dade..986e6a1 100644
--- a/hw/timer/lm32_timer.c
+++ b/hw/timer/lm32_timer.c
@@ -50,8
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/milkymist-sysctl.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/timer/milkymist-sysctl.c b/hw/timer/milkymist-sysctl.c
index 5009394..94246e5 100644
--- a/hw/timer/milkymist-sysctl.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/slavio_timer.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c
index 7f844d7..33e8f6c 100644
--- a/hw/timer/slavio_timer.c
+++ b/hw/timer/slavio_timer.c
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/etraxfs_timer.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/hw/timer/etraxfs_timer.c b/hw/timer/etraxfs_timer.c
index 6dd1072..7e9807d 100644
--- a/hw/timer/etraxfs_timer.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/m48t59.c | 16 ++--
include/hw/timer/m48t59.h | 3 +++
2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/timer/m48t59.c b/hw/timer/m48t59.c
index be3490b..0cc9e5b 100644
--- a/hw/timer/m48t59.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/etraxfs_timer.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/timer/etraxfs_timer.c b/hw/timer/etraxfs_timer.c
index 7e9807d..a38d9e4 100644
--- a/hw/timer/etraxfs_timer.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/xilinx_timer.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/timer/xilinx_timer.c b/hw/timer/xilinx_timer.c
index ee53834..5f2c902 100644
--- a/hw/timer/xilinx_timer.c
+++ b/hw/timer/xilinx_timer.c
@@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/pxa2xx_timer.c | 38 +++---
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/hw/timer/pxa2xx_timer.c b/hw/timer/pxa2xx_timer.c
index 4d28719..ff63fa6 100644
--- a/hw/timer/pxa2xx_timer.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/puv3_ost.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/timer/puv3_ost.c b/hw/timer/puv3_ost.c
index 63f2c9f..4bd2b76 100644
--- a/hw/timer/puv3_ost.c
+++ b/hw/timer/puv3_ost.c
@@ -14,9 +14,13 @@
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/timer/pl031.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/hw/timer/pl031.c b/hw/timer/pl031.c
index 3ce6ed8..e705a69 100644
--- a/hw/timer/pl031.c
+++ b/hw/timer/pl031.c
@@ -33,7
Am 24.07.2013 09:48, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/pxa2xx.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c
index 6548338..ab145ee 100644
---
Am 24.07.2013 09:48, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/stellaris.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index a2b6b17..1c69bcf 100644
---
Am 27.07.2013 12:44, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/net/etraxfs_eth.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/net/etraxfs_eth.c b/hw/net/etraxfs_eth.c
index ab9a215..71b4fb8 100644
---
On 2013-07-27 16:10, Andreas Färber wrote:
Am 24.07.2013 09:48, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/musicpal.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index
Am 24.07.2013 09:47, schrieb Andreas Färber:
diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c
index 58f4ed7..af31007 100644
--- a/hw/arm/integratorcp.c
+++ b/hw/arm/integratorcp.c
[...]
@@ -376,7 +382,7 @@ static const MemoryRegionOps icp_pic_ops = {
static int
Am 24.07.2013 09:48, schrieb Andreas Färber:
Introduce type constant and use QOM casts.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/musicpal.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index
Am 24.07.2013 09:48, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/spitz.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
index 0bf5c5c..70f23b3 100644
--- a/hw/arm/spitz.c
+++
Eric Blake ebl...@redhat.com writes:
On 07/26/2013 06:39 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qapi-schema-test.json | 53 -
tests/Makefile | 8 ++---
c658b94f6e8c206c59d02aa6fbac285b86b53d2c (cpu: Turn cpu_unassigned_access()
into a CPUState hook) made MIPS raise exceptions when accessing
invalid memory for data, by unconditionally calling CPUState unassigned hook.
While this seems to be the right behaviour, this breaks a lot of guests
(Linux
Am 27.07.2013 18:18, schrieb Hervé Poussineau:
c658b94f6e8c206c59d02aa6fbac285b86b53d2c (cpu: Turn cpu_unassigned_access()
into a CPUState hook) made MIPS raise exceptions when accessing
invalid memory for data, by unconditionally calling CPUState unassigned hook.
While this seems to be the
Report syntax error instead of crashing.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
scripts/qapi.py | 10 ++
tests/qapi-schema/non-objects.err | 2 +-
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
scripts/qapi.py | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 75fc282..f64b7b2 100644
--- a/scripts/qapi.py
+++
The parser has a rather unorthodox structure:
Until EOF:
Read a section:
Generator function get_expr() yields one section after the
other, as a string. An unindented, non-empty line that
isn't a comment starts a new section.
Lexing:
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
scripts/qapi.py | 3 +--
tests/qapi-schema/comments.err | 1 -
tests/qapi-schema/comments.exit | 2 +-
tests/qapi-schema/comments.out | 3 +++
4 files changed, 5 insertions(+), 4
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
tests/Makefile| 8
tests/qapi-schema/qapi-schema-test.exit | 1 +
.../qapi-schema/qapi-schema-test.json | 0
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
scripts/qapi.py | 2 ++
tests/qapi-schema/comments.err| 1 +
tests/qapi-schema/comments.exit | 2 +-
tests/qapi-schema/comments.out| 3 ---
tests/qapi-schema/funny-char.err
On 27 July 2013 17:18, Hervé Poussineau hpous...@reactos.org wrote:
Another solution would be to add a big dummy memory regions on all MIPS boards
to catch memory accesses and not raise an exception. However, this means that
each MIPS board will have its own unassigned memory handler, different
Am 26.07.2013 10:52, schrieb Hu Tao:
On Wed, Jul 24, 2013 at 10:35:54AM +0200, Andreas Färber wrote:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/audio/pl041.c | 45 +
1 file changed, 25 insertions(+), 20 deletions(-)
Reviewed-by: Hu
If you think I'm exaggerating, check out the list of issues in PATCH
3/9.
v2:
* Straightforward rebase
* A few more tests in 1/9, in part suggested by Eric
Markus Armbruster (9):
tests: QAPI schema parser tests
tests: Use qapi-schema-test.json as schema parser test
qapi.py: Restructure
The parser handles erroneous input badly. To be improved shortly.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
configure | 2 +-
tests/Makefile | 24 ++--
tests/qapi-schema/comments.exit
Am 26.07.2013 14:40, schrieb Andreas Färber:
Am 26.07.2013 04:58, schrieb Hu Tao:
Would it be better to explicitly set PL110 version? I know PL110 is 0,
but it's not like a normal variable which is always good to be
initialized to 0, assuming a version number is bad. (This is not a problem
of
Fixes at least the following parser bugs:
* accepts any token in place of a colon
* treats comma as optional
* crashes when closing braces or brackets are missing
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
scripts/qapi.py
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 27.07.2013 16:33, schrieb Jan Kiszka:
On 2013-07-27 16:10, Andreas Färber wrote:
Needs the following addition:
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index
6065051..9174b87 100644 --- a/hw/arm/musicpal.c +++
b/hw/arm/musicpal.c
Am 24.07.2013 09:48, schrieb Andreas Färber:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/musicpal.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index 293ab26..e7efed9 100644
---
As a replacement, use your own macro based on OBJECT_CHECK().
Signed-off-by: Andreas Färber afaer...@suse.de
---
include/hw/sysbus.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h
index 8c17165..fbfc066 100644
--- a/include/hw/sysbus.h
+++
Am 27.07.2013 21:37, schrieb Stefan Weil:
Am 27.07.2013 19:43, schrieb Peter Maydell:
On 27 July 2013 17:18, Hervé Poussineau hpous...@reactos.org wrote:
Another solution would be to add a big dummy memory regions on all MIPS
boards
to catch memory accesses and not raise an exception.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/mips/mips_malta.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index dad58c0..e932fdc 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -79,8 +79,12
Hello,
This series finally eliminates the FROM_SYSBUS() macro.
It goes on to fix remaining -qdev field accesses (less work than I thought).
I've been pushing out device patches ASAP to give them maximum review hours,
now here follows the rationale why I made this effort:
i) Murphy's Law
When
1 - 100 of 130 matches
Mail list logo
