Am 07.08.2013 05:36, schrieb Alexey Kardashevskiy:
This what I would suggest:
#define OBJECT_GET_PARENT_CLASS(obj, name) \
object_class_get_parent(OBJECT_GET_CLASS(ObjectClass, (obj), (name)))
@name here is just to make sure we are at the right level of the class
hierarchy.
And use
On 08/06/2013 07:53 PM, Andreas Färber wrote:
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy:
The upcoming XICS-KVM support will use bits of emulated XICS code.
So this introduces new level of hierarchy - xics-common class. Both
emulated XICS and XICS-KVM will inherit from it and override
On Wed, Aug 7, 2013 at 3:53 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 08/07/2013 03:45 PM, Andreas Färber wrote:
Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy:
On 08/07/2013 02:20 PM, Peter Crosthwaite wrote:
Hi,
On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy a...@ozlabs.ru
Am 07.08.2013 07:53, schrieb Alexey Kardashevskiy:
On 08/07/2013 03:45 PM, Andreas Färber wrote:
Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy:
On 08/07/2013 02:20 PM, Peter Crosthwaite wrote:
Hi,
On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy a...@ozlabs.ru
wrote:
On 08/06/2013
On 08/07/13 01:29, Amos Kong wrote:
We register exit clean function by atexit(),
but alarm_timer is NULL here. If exit is caused
between atexit() and alarm_timer assignment,
real timer can't be cleaned.
That's correct in general, but I don't see how it could happen in the
code being patched.
On 08/07/2013 04:10 PM, Peter Crosthwaite wrote:
On Wed, Aug 7, 2013 at 3:53 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 08/07/2013 03:45 PM, Andreas Färber wrote:
Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy:
On 08/07/2013 02:20 PM, Peter Crosthwaite wrote:
Hi,
On Wed, Aug 7,
On 08/06/2013 08:12 PM, Andreas Färber wrote:
+/* Call emulated XICS implementation for consistency */
+assert(xics_info xics_info-cpu_setup);
+xics_info-cpu_setup(icp, cpu);
+}
+
+void xics_kvm_set_nr_irqs(XICSState *icp, uint32_t nr_irqs)
+{
+icp-ics =
Am 07.08.2013 08:06, schrieb Alexey Kardashevskiy:
On 08/06/2013 07:53 PM, Andreas Färber wrote:
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy:
+}
+}
+
+void xics_prop_set_nr_irqs(Object *obj, struct Visitor *v,
+ void *opaque, const char *name, struct
Am 07.08.2013 09:03, schrieb Alexey Kardashevskiy:
On 08/06/2013 08:12 PM, Andreas Färber wrote:
+/* Call emulated XICS implementation for consistency */
+assert(xics_info xics_info-cpu_setup);
+xics_info-cpu_setup(icp, cpu);
+}
+
+void xics_kvm_set_nr_irqs(XICSState *icp,
On Wed, Aug 07, 2013 at 12:52:57AM +0100, Alex Bligh wrote:
--On 6 August 2013 12:10:17 +0200 Stefan Hajnoczi
stefa...@gmail.com wrote:
Fails to build ui/vnc-auth-sasl.c
Please make sure that your ./configure output shows most optional
dependencies are available (you need to install
On Tue, Aug 06, 2013 at 03:18:13PM +0100, Alex Bligh wrote:
Stefan,
--On 6 August 2013 15:59:11 +0200 Stefan Hajnoczi
stefa...@gmail.com wrote:
--On 6 August 2013 14:02:18 +0200 Stefan Hajnoczi
stefa...@redhat.com wrote:
My preference would be to move these to qemu_clock_deadline_ns
On Tue, Aug 06, 2013 at 03:52:37PM +0100, Alex Bligh wrote:
Stefan,
I think I disagree here.
At the very least we should put the conversion to use the new API
into a separate patch (possibly a separate patch set). It's fantastically
intrusive.
Yes, it should be a separate patch.
...
On 08/07/2013 05:03 PM, Andreas Färber wrote:
Am 07.08.2013 08:06, schrieb Alexey Kardashevskiy:
On 08/06/2013 07:53 PM, Andreas Färber wrote:
Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy:
+}
+}
+
+void xics_prop_set_nr_irqs(Object *obj, struct Visitor *v,
+
On Tue, Aug 06, 2013 at 03:58:40PM +0100, Alex Bligh wrote:
--On 6 August 2013 16:45:12 +0200 Stefan Hajnoczi
stefa...@gmail.com wrote:
Because otherwise make check SEGVs after the patch.
It wasn't clear from the patch why there would be a crash. I looked
deeper and timerlistgroup_init()
On 08/07/2013 05:08 PM, Andreas Färber wrote:
+icp-nr_irqs = icp-ics-nr_irqs = nr_irqs;
+}
+
+void xics_kvm_set_nr_servers(XICSState *icp, uint32_t nr_servers)
+{
+int i;
+
+icp-nr_servers = nr_servers;
+
+icp-ss = g_malloc0(icp-nr_servers*sizeof(ICPState));
+for (i
On Wed, Aug 07, 2013 at 10:42:26AM +0800, Wenchao Xia wrote:
On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote:
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
One question: old code missed itself in bdrv_drain_all(), is that a bug?
Sorry, I don't understand the question.
RDMAControlHeader::len is remote-provided. So validate the value before use.
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len match transferred byte
migration-rdma.c |
On Thu, Jul 25, 2013 at 05:18:08PM +0200, Stefan Hajnoczi wrote:
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
so that the device is still seen by bdrv_drain_all() when iterating
bdrv_states.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Hajnoczi
- Original Message -
From: Martijn van den Broek martijn.vd...@gmail.com
To: qemu-devel@nongnu.org
Cc: chout...@adacore.com, pbonz...@redhat.com, ag...@suse.de
Sent: Tuesday, August 6, 2013 8:45:39 PM
Subject: [PATCH] Bugfix for loading multiboot kernels
This patch fixes a bug in
On Tue, Aug 06, 2013 at 08:26:16PM -0400, Brad Smith wrote:
On 06/08/13 7:48 AM, Stefan Hajnoczi wrote:
If CLOCK_MONOTONIC is not defined by system headers we use
gettimeofday(2). Apparently this is not used very often since no one
noticed the #ifdef was actually broken and left the function
On Wed, Aug 07, 2013 at 08:39:19AM +0200, Laszlo Ersek wrote:
On 08/07/13 01:29, Amos Kong wrote:
We register exit clean function by atexit(),
but alarm_timer is NULL here. If exit is caused
between atexit() and alarm_timer assignment,
real timer can't be cleaned.
That's correct in
On Tue, Aug 06, 2013 at 10:38:32AM +0800, Asias He wrote:
On Tue, Aug 06, 2013 at 10:02:22AM +0800, Fam Zheng wrote:
On Tue, 08/06 09:53, Asias He wrote:
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
While Asias is debugging an issue creating qcow2 images on top of
non-file
Currently only single TCE entry per requiest is supported (H_PUT_TCE).
However PAPR+ specification allows multiple entry requests such as
H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having less transitions to the host
kernel via ioctls, support of these calls can accelerate IOMMU operations.
This also
On Wed, Aug 07, 2013 at 09:57:19AM +0200, Stefan Hajnoczi wrote:
On Wed, Aug 07, 2013 at 08:39:19AM +0200, Laszlo Ersek wrote:
On 08/07/13 01:29, Amos Kong wrote:
We register exit clean function by atexit(),
but alarm_timer is NULL here. If exit is caused
between atexit() and
On Tue, Aug 06, 2013 at 02:45:48PM +0200, Andreas Färber wrote:
Am 06.08.2013 14:09, schrieb Michael S. Tsirkin:
On Tue, Aug 06, 2013 at 01:03:34PM +0200, Andreas Färber wrote:
FWIW -M q35 does not create all Q35 devices, there's -readconfig
docs/q35-chipset.cfg for the rest. The criteria
From: David Gibson da...@gibson.dropbear.id.au
At the moment, most AddressSpace objects last as long as the guest system
in practice, but that could well change in future. In addition, for VFIO
we will be introducing some private per-AdressSpace information, which must
be disposed of before the
This patch series represents a third attempt at better integration of
the vfio code with qemu's handling of guest IOMMUs. David posted two previous
series, I am posting now his rework after last posting.
This also contains a working VFIO driver for QEMU which depends on
MSIX rework and IRQFD
From: David Gibson da...@gibson.dropbear.id.au
A PCI device's DMA address space (possibly an IOMMU) is returned by a
method on the PCIBus. At the moment that only has one caller, so the
method is simply open coded. We'll need another caller for VFIO, so
this patch introduces a helper/wrapper
As sPAPR platform supports DMA windows on a PCI bus, the information
about their location and size should be passed into the guest via
the device tree.
The patch adds a helper to read this info from the container fd.
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
hw/misc/vfio.c
From: David Gibson da...@gibson.dropbear.id.au
So far, VFIO has a notion of different logical DMA address spaces, but
only ever uses one (system memory). This patch extends this, creating
new VFIOAddressSpace objects as necessary, according to the AddressSpace
reported by the PCI subsystem for
From: David Gibson da...@gibson.dropbear.id.au
The only model so far supported for VFIO passthrough devices is the model
usually used on x86, where all of the guest's RAM is mapped into the
(host) IOMMU and there is no IOMMU visible in the guest.
This patch begins to relax this model,
This patch uses the new IOMMU notifiers to allow VFIO pass through devices
to work with guest side IOMMUs, as long as the host-side VFIO iommu has
sufficient capability and granularity to match the guest side. This works
by tracking all map and unmap operations on the guest IOMMU using the
The patch adds a spapr-pci-vfio-host-bridge device type
which is a PCI Host Bridge with VFIO support. The new device
inherits from the spapr-pci-host-bridge device and adds
the following properties:
iommu - IOMMU group ID which represents a Partitionable
Endpoint,
This turns the sPAPR support on and enables VFIO container use
in the kernel.
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
hw/misc/vfio.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 4571f64..4484826 100644
On Fri, Aug 02, 2013 at 05:53:00PM +0200, Benoît Canet wrote:
This patchset implement continous leaky bucket throttling.
It works mostly on the general case.
The exception is where the load is composed of both reads and writes and two
limits iops_rd and iops_wr are set.
The resulting iops
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
RDMA does not use sockets, so we cannot use many of the socket
helper functions, but we *do* use inet_parse() which gives
RDMA all the necessary details of the connection parameters.
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
Ooops. We forgot to turn off the flag.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
migration-rdma.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
Don't print newlines on the error_setg() function,
but still allow newlines on fprintf().
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
migration-rdma.c | 68
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
hw/intc/xics_kvm.c | 5 +
hw/ppc/spapr_pci.c | 6 ++
2 files changed, 11 insertions(+)
diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c
index 1f078f3..9978a47 100644
--- a/hw/intc/xics_kvm.c
+++ b/hw/intc/xics_kvm.c
@@ -448,6
Yet another try to push IRQFD support for sPAPR.
This includes rework for QEMU and enablement for sPAPR PCI.
Alexey Kardashevskiy (2):
kvm irqfd: support msimessage to irq translation in PHB
pseries: enable irqfd for pci
hw/i386/kvm/pci-assign.c | 4 ++--
hw/intc/xics_kvm.c | 5 +
On PPC64 systems MSI Messages are translated to system IRQ in a PCI
host bridge. This is already supported for emulated MSI/MSIX but
not for irqfd where the current QEMU allocates IRQ numbers from
irqchip and maps MSIMessages to those IRQ in the host kernel.
The patch extends irqfd support in
On 08/07/2013 05:26 AM, Isaku Yamahata wrote:
RDMAControlHeader::len is remote-provided. So validate the value before use.
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len
With this patch, qemu-img info sheepdog:image will show disk size for sheepdog
images.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Liu Yuan namei.u...@gmail.com
---
block/sheepdog.c | 19
On Mon, Aug 05, 2013 at 03:27:07PM +0200, Andreas Färber wrote:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/mips/mips_mipssim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
index fea1a15..d8c4347 100644
On Mon, Aug 05, 2013 at 03:27:24PM +0200, Andreas Färber wrote:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sh4/shix.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index 84dd666..66cbea4 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
On Mon, Aug 05, 2013 at 03:27:25PM +0200, Andreas Färber wrote:
Adopt error_report() while at it.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/block/tc58128.c | 10 ++
hw/sh4/shix.c | 9 +
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git
Stefan,
Some tips on which packages to install:
host big endian no
gprof enabled no
sparse enabledno
strip binariesno
profiler no
static build no
All the ones above are okay, fine to ignore.
SDL support no
Do you have libsdl1.2-dev installed?
ii
--On 7 August 2013 09:21:17 +0200 Stefan Hajnoczi stefa...@gmail.com
wrote:
How do I actually run the code (i.e. how do I test whether I've broken
it)? I take it that's something different from just 'make check'?
make check includes qtest test cases like rtc-test, i440fx-test,
fdc-test,
--On 7 August 2013 09:27:36 +0200 Stefan Hajnoczi stefa...@gmail.com
wrote:
Do you think we need to wrap timer_mod, timer_del, timer_free
etc. to make aio_timer_mod and so forth, even though they are
a straight pass through?
Those wrappers are not necessary. Once the caller has their
On Wed, Aug 07, 2013 at 06:21:25PM +1000, Alexey Kardashevskiy wrote:
From: David Gibson da...@gibson.dropbear.id.au
A PCI device's DMA address space (possibly an IOMMU) is returned by a
method on the PCIBus. At the moment that only has one caller, so the
method is simply open coded. We'll
On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
I forgot to mention that there's no need to change the doc comments
you've already written. I just wanted to share that to save you work in
the future.
On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new.
Expose clock types.
Signed-off-by: Alex Bligh a...@alex.org.uk
---
include/qemu/timer.h | 22 ++
qemu-timer.c | 11 ++-
2
--On 7 August 2013 13:31:07 +0200 Stefan Hajnoczi stefa...@gmail.com
wrote:
Regarding doc comments: if the function is self-documenting then the doc
comment might not add much. I think in those cases it's okay to omit
details about arguments or return values if they are clear from the
Andreas Färber afaer...@suse.de writes:
Am 07.08.2013 02:47, schrieb Anton Blanchard:
On POWER7, LPCR_ILE is used to control what endian guests take
their exceptions in so use it instead of MSR_ILE.
Signed-off-by: Anton Blanchard an...@samba.org
---
target-ppc/cpu.h | 2 ++
On Sat, Aug 3, 2013 at 7:03 AM, Peter Maydell peter.mayd...@linaro.orgwrote:
On 2 August 2013 18:48, Erlon Cruz sombra...@gmail.com wrote:
kernel: Linux 3.10-rc6 - vexpress_defconfig
The kernel boots, but it cant mount the SD:
mmc0: host doesn't support card's voltages
mmc0: error
On Fri, Aug 2, 2013 at 9:35 AM, Anthony Liguori aligu...@us.ibm.com wrote:
Applied. Thanks.
Where can I find this branch?
Regards,
Anthony Liguori
Public bug reported:
After the patch at http://lists.nongnu.org/archive/html/qemu-
devel/2013-05/msg01567.html, I cannot get my Logitech Unifying USB
receiver passed to the guest anymore.
Minimal reproduction command:
qemu-system-x86_64 -usbdevice host:046d:c52b
Debug patch:
diff --git
Am 07.08.2013 09:26, schrieb Alexey Kardashevskiy:
On 08/07/2013 05:03 PM, Andreas Färber wrote:
Am 07.08.2013 08:06, schrieb Alexey Kardashevskiy:
[...] How do I test it?
./QMP/qom-list to find the path, if not fixed in code yet, and
Something is wrong. XICS does not have an id but it
Your observation is correct, but this is already fixed upstream:
commit 628e54857a82a3cb65ef96c12640c30d6307a064
Author: Gerd Hoffmann kra...@redhat.com
Date: Wed Jun 12 13:17:02 2013 +0200
usb-host-libusb: set USB_DEV_FLAG_IS_HOST
** Changed in: qemu
Status: New = Fix Committed
On Thu, Aug 01, 2013 at 03:44:41PM +0200, Stefan Hajnoczi wrote:
On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote:
@@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size,
int crc_offset)
/*
+ * This generates a UUID that is compliant with the MS
On 08/07/2013 04:39 AM, Orit Wasserman wrote:
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
RDMA does not use sockets, so we cannot use many of the socket
helper functions, but we *do* use inet_parse() which gives
RDMA all the necessary
On 08/06/2013 10:26 PM, Isaku Yamahata wrote:
RDMAControlHeader::len is remote-provided. So validate the value before use.
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
This adds some magic number defines, and internal structure
definitions for VHDX log replay support.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.h | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by:
Add configuration for C++ compiler in configure and Makefiles.
The C++ compiler is choosed as following:
- ${CXX}, if it is specified.
- ${cross_prefix}g++, if ${cross_prefix} is specified.
- Otherwise, c++ is used.
Currently, usage of C++ language is only for access to Windows VSS
using COM+
Enable checkpatch.pl to apply the same checks as C source files for
C++ files with .cpp extensions. It also adds some exceptions for C++
sources to suppress errors for:
- used in C++ template arguments (e.g. template class T)
- :: used to represent namespaces (e.g. SomeClass::method())
-
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows
guests. When fsfreeze command is issued, it calls the VSS requester to
freeze filesystems and applications. On thaw command, it again tells the VSS
requester to thaw them.
This also adds calling of initialize functions for
To enable VSS support in qemu-ga for Windows, header files included in
VSS SDK are required.
The VSS support is enabled by the configure option like below:
./configure --with-vss-sdk=/path/to/VSS SDK
If the path is omitted, it tries to search the headers from default paths
and VSS support is
Add c++ keywords to avoid errors in compiling with c++ compiler.
This also renames class member of PciDeviceInfo to q_class.
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
Reviewed-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
hmp.c
Hi,
I rebased the patch series to add fsfreeze for Windows qemu-ga.
changes from v9:
- Fix conflict with commit e8ef31a3518c qemu-ga: build it even if !system
changes from v8:
- Add hEventTimeout to improve timeout error message (patch 07, see below)
- Build qga-vss.tlb if configure'd
These functions help maintaining homogeneous formatting of error messages
with Windows error code and description (generated by
g_win32_error_message()).
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
---
include/qapi/error.h | 13
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script
to extract VSS SDK headers on POSIX-systems using msitools.
* http://www.microsoft.com/en-us/download/details.aspx?id=23490
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
disk I/O is running. To avoid unexpected timeout, this changes the timeout
to 60 seconds (timeout of pre-commit phase of VSS).
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
Reviewed-by: Paolo Bonzini
Register QGA VSS provider library into Windows when qemu-ga is installed as
Windows service ('-s install' option). It is deregistered when the service
is uninstalled ('-s uninstall' option).
Signed-off-by: Tomoki Sekiyama tomoki.sekiy...@hds.com
Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com
For anyone wishing to review this series, here's a diagram showing the
new relationships and a summary of this series:
http://vmsplice.net/~stefan/timerlist.jpg
TimerList is the list of QEMUTimers which are pending on a QEMUClock
clock source.
I just started reviewing this and the
On Aug 07 2013, Alex Bligh wrote:
--On 7 August 2013 13:31:07 +0200 Stefan Hajnoczi
stefa...@gmail.com wrote:
Regarding doc comments: if the function is self-documenting then the doc
comment might not add much. I think in those cases it's okay to omit
details about arguments or return
From: Isaku Yamahata yamah...@private.email.ne.jp
RDMAControlHeader::len is provided from remote, so check if the value
match the actual transferred byte_len.
Reviewed-by: Orit Wasserman owass...@redhat.com
Reviewed-by: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata
From: Isaku Yamahata yamah...@private.email.ne.jp
RMDAControlHeader::len is provided from remote, so validate it.
Reviewed-by: Orit Wasserman owass...@redhat.com
Reviewed-by: Michael R. Hines mrhi...@us.ibm.com
Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp
Signed-off-by: Michael R.
From: Michael R. Hines mrhi...@us.ibm.com
Some nice buffer-overrun checks and fixing incorrect usage of getaddrinfo()
Isaku Yamahata (3):
rdma: use resp.len after validation in qemu_rdma_registration_stop
rdma: validate RDMAControlHeader::len
rdma: check if RDMAControlHeader::len match
From: Isaku Yamahata yamah...@private.email.ne.jp
resp.len is given from remote host. So should be validated before use.
Otherwise memcpy can access beyond the buffer.
Cc: Michael R. Hines mrhi...@us.ibm.com
Reviewed-by: Orit Wasserman owass...@redhat.com
Reviewed-by: Michael R. Hines
From: Michael R. Hines mrhi...@us.ibm.com
getaddrinfo() already knows what it's doing,
wqand can potentially return multiple addresses.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
migration-rdma.c | 56 --
1 file changed, 29
On Wed, Aug 07, 2013 at 05:22:45PM +0200, Kevin Wolf wrote:
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
This adds some magic number defines, and internal structure
definitions for VHDX log replay support.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vhdx.h | 21
Paolo,
--On 7 August 2013 11:43:58 -0400 Paolo Bonzini pbonz...@redhat.com wrote:
For anyone wishing to review this series, here's a diagram showing the
new relationships and a summary of this series:
http://vmsplice.net/~stefan/timerlist.jpg
TimerList is the list of QEMUTimers which are
On Wed, Aug 07, 2013 at 05:29:04PM +0200, Kevin Wolf wrote:
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation
On 08/05/13 21:40, Seiji Aguchi wrote:
Convert stderr messages calling error_get_pretty()
to error_report().
Timestamp is prepended by -msg timstamp option with it.
Per Markus's comment below, A conversion from fprintf() to
error_report() is always an improvement, regardless of
On Mon, Aug 05, 2013 at 08:44:04PM +0200, Charlie Shepherd wrote:
From: Charlie Shepherd cs...@cam.ac.uk
While it only really makes sense to call qemu_coroutine_self() in a coroutine
context, it cannot actually yield execution itself, so remove the coroutine_fn
annotation.
---
On Mon, Aug 05, 2013 at 08:33:10PM +0100, Charlie Shepherd wrote:
On 05/08/2013 20:23, Gabriel Kerneis wrote:
On Mon, Aug 05, 2013 at 08:44:05PM +0200, Charlie Shepherd wrote:
diff --git a/include/block/coroutine_int.h b/include/block/coroutine_int.h
index f133d65..d0ab27d 100644
---
Hi,
On behalf of the QEMU Team, I'd like to announce the availability of the
third release candidate for the QEMU 1.6 release. This release is meant
for testing purposes and should not be used in a production environment.
http://wiki.qemu.org/download/qemu-1.6.0-rc2.tar.bz2
You can help
Don't we really want this too?
commit 2a9aeabdfb34374ecac25e7a8d21c9e368618cd4
Author: Kevin O'Connor ke...@koconnor.net
Date: Sun Jul 14 13:55:52 2013 -0400
Fix USB EHCI detection that was broken in hlist conversion of
PCIDevices.
QEMU executables for w32, w64 had included meta information built from
version.rc. These rules were changed several times some months ago.
The latest version added version.o to the tools, but not to the system
emulations.
This patch adds the meta information to all system emulations again.
It
I saw more discussion on IRC. Does this mean you will send another
revision to address outstanding issues?
Just wanted to check if you are waiting for code review or if you are
still developing the next patch revision.
I am currently finishing to write unit tests for the next patch
On Wed, Aug 07, 2013 at 09:18:05PM +0200, Stefan Hajnoczi wrote:
I guess the practical problem is that CPC will get
upset that it's being called by the coroutine implementation from
non-coroutine contexts.
But is it really the case? If Charlie added an annotation, it probably means
that in
On Sun, Mar 31, 2013 at 01:02:22PM +0200, Aurelien Jarno wrote:
The PCLMULQDQ instruction has been introduced on the Westmere CPU.
Reviewed-by: Richard Henderson r...@twiddle.net
Reviewed-by: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
At Wed, 7 Aug 2013 16:59:53 +0800,
Liu Yuan wrote:
With this patch, qemu-img info sheepdog:image will show disk size for sheepdog
images.
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
Signed-off-by: Liu Yuan
On 06/08/2013 10:24, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch converts the .bdrv_open, .bdrv_file_open and .bdrv_create members of
struct BlockDriver
to be explicitly annotated as coroutine_fn, rather than yielding dynamically
depending on whether
On 06/08/2013 10:36, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch follows on from the previous one and converts some block layer
functions to be
explicitly annotated with coroutine_fn instead of yielding depending upon
calling context.
---
block.c
On 05/08/2013 21:15, Gabriel Kerneis wrote:
On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote:
This patch updates the callers of block layer functions converted to explicit
coroutine_fn annotation in the previous patch.
It looks like this patch is made of three parts:
- updating
On 06/08/2013 09:39, Stefan Hajnoczi wrote:
On Mon, Aug 05, 2013 at 08:44:03PM +0200, Charlie Shepherd wrote:
From: Charlie Shepherd cs...@cam.ac.uk
Coroutine functions that can yield directly or indirectly should be annotated
with a coroutine_fn annotation. Add an explanation to that effect
On 06/08/2013 10:37, Kevin Wolf wrote:
Am 05.08.2013 um 20:44 hat Charlie Shepherd geschrieben:
This patch series is a follow up to a previous RFC about converting functions
that dynamically yield execution depending on whether they are in executing in
a coroutine context or not to be
On 07/08/2013 20:18, Stefan Hajnoczi wrote:
On Mon, Aug 05, 2013 at 08:44:04PM +0200, Charlie Shepherd wrote:
From: Charlie Shepherd cs...@cam.ac.uk
While it only really makes sense to call qemu_coroutine_self() in a coroutine
context, it cannot actually yield execution itself, so remove the
1 - 100 of 123 matches
Mail list logo
