Re: [Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7

2013-08-26 Thread Jia Liu
Hi Peter, On Fri, Aug 23, 2013 at 10:09 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 21 August 2013 03:06, Jia Liu pro...@gmail.com wrote: This is my OpenRISC patch queue for 1.7, it have been well tested, please pull.

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Benjamin Herrenschmidt
On Mon, 2013-08-26 at 10:02 +0530, Nikunj A Dadhania wrote: From: Nikunj A Dadhania nik...@linux.vnet.ibm.com This implements capabilities exchange between host and client. As at the moment no capability is supported, put zero flags everywhere and return. Signed-off-by: Nikunj A

Re: [Qemu-devel] [Bug 1212402] [NEW] Enabling KVM with recent QEMU builds from GIT hang at boot on Ubuntu Precise AMD64 kernel 3.8.0

2013-08-26 Thread Dunrong Huang
We have discussed this issue in this mail: http://www.mail-archive.com/qemu-devel@nongnu.org/msg174932.html (VM can not boot after commit 235e898) You can upgrade your kernel to 3.9.x to work around. On Thu, Aug 15, 2013 at 3:23 AM, Julius Schwartzenberg julius.schwartzenb...@gmail.com wrote:

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Benjamin Herrenschmidt
On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote: +cap.flags = 0; +cap.migration.ecl = 0; +cap.reserve.type = 0; +cap.migration.common.server_support = 0; +cap.reserve.common.server_support = 0; My question stands unanswered. Is this just memset(0)? If it

Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values.

2013-08-26 Thread Aneesh Kumar K.V
Alexander Graf ag...@suse.de writes: On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed when using gdb remote debugging support. (gdb)

Re: [Qemu-devel] [PATCH v3 6/6] hw: Clean up bogus default boot order

2013-08-26 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Thu, Aug 22, 2013 at 01:24:50PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Aug 22, 2013 at 10:39:34AM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Aug 21, 2013

Re: [Qemu-devel] [PATCH V9 07/12] NUMA: parse guest numa nodes memory policy

2013-08-26 Thread Andrew Jones
- Original Message - On 08/23/2013 10:11 PM, Andrew Jones wrote: - Original Message - The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of

[Qemu-devel] [Bug 1191326] Re: QNX 4 doesn't boot on qemu = 1.3

2013-08-26 Thread JQu
problem appeared in this commit: commit b90600eed3c0efe5f3260853c873caf51c0677b1 Author: Avi Kivity a...@redhat.com Date: Wed Oct 3 16:42:37 2012 +0200 dma: make dma access its own address space Instead of accessing the cpu address space, use an address space configured by the

Re: [Qemu-devel] [PATCH 03/16] ipack: Pass size to ipack_bus_new_inplace()

2013-08-26 Thread Wenchao Xia
To be passed to qbus_create_inplace(). Simplify DEVICE() cast to avoid parent field access. s-dev will always point to pci_dev, so this change is safe. Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/char/ipack.c | 3 ++-

Re: [Qemu-devel] [RFC PATCH 00/47] Describing patchset

2013-08-26 Thread Peter Maydell
On 25 August 2013 23:58, Ákos Kovács akoskov...@gmx.com wrote: This is a request-for-comments patchset on the kconfig integration. The patchset contains a 'scripts/kconfig' git submodule (PATCH 5, kconfig-frontends v3.10) with the necessary modifications in the Makefile.objs (PATCHES 6-16).

Re: [Qemu-devel] [PATCH v5 0/8] Implement reference count for BlockDriverState [resend]

2013-08-26 Thread Stefan Hajnoczi
On Fri, Aug 23, 2013 at 10:17:37AM +0800, Wenchao Xia wrote: What is the correct steps to run full qemu-iotests? I modified qemu-iotests-quick.sh as: #!/bin/sh # We don't know which of the system emulator binaries there is (or if there is # any at all), so the 'quick' group doesn't

Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-26 Thread Paolo Bonzini
Il 23/08/2013 13:33, Andrew Jones ha scritto: Does smp_cpus map to the current number of cpus, or to the number of possible cpus? If it maps to the number of possible cpus, then this is the right place. If the former, then I guess it'll take more thought. I'ved added Igor (still on vacation)

Re: [Qemu-devel] [PATCH 12/16] qdev: Pass size to qbus_create_inplace()

2013-08-26 Thread Wenchao Xia
于 2013-8-24 8:00, Andreas Färber 写道: To be passed to object_initialize(). Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is void*, so drop some superfluous (BusState *) casts or direct parent field usages. Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH V9 06/12] NUMA: Add Linux libnuma detection

2013-08-26 Thread Andrew Jones
- Original Message - On 08/23/2013 04:40 PM, Andrew Jones wrote: - Original Message - Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available.

Re: [Qemu-devel] [PATCH] scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial

2013-08-26 Thread Paolo Bonzini
Il 23/08/2013 18:01, arm...@redhat.com ha scritto: From: Markus Armbruster arm...@redhat.com scsi_bus_legacy_add_drive() creates either a scsi-disk or a scsi-generic device. It sets property serial to argument serial unless null. Crashes with scsi-generic, because it doesn't have such the

Re: [Qemu-devel] [PATCH 0/2] lsi53c895a: avoid integer undefined behaviours

2013-08-26 Thread Paolo Bonzini
Il 23/08/2013 18:16, Peter Maydell ha scritto: More patches to fix clang sanitizer warnings; in this case we can fix them and clean up the code a bit by replacing hand-coded operations with functions from the bitops header. Peter Maydell (2): hw/scsi/lsi53c895a: Use sextract32 for

Re: [Qemu-devel] [PATCH 15/16] qdev-monitor: Clean up qdev_device_add() variable naming

2013-08-26 Thread Wenchao Xia
于 2013-8-24 8:00, Andreas Färber 写道: Avoid confusion between object and object class. between object class and device class? Tidy DeviceClass variable while at it. Signed-off-by: Andreas Färber afaer...@suse.de --- qdev-monitor.c | 22 +++--- 1 file changed, 11

Re: [Qemu-devel] [PATCH 10/16] virtio-ccw: Pass size to virtio_ccw_bus_new()

2013-08-26 Thread Cornelia Huck
On Sat, 24 Aug 2013 02:00:30 +0200 Andreas Färber afaer...@suse.de wrote: To be passed to qbus_create_inplace(). Signed-off-by: Andreas Färber afaer...@suse.de --- hw/s390x/virtio-ccw.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Acked-by: Cornelia Huck

Re: [Qemu-devel] [PATCH 1/2] hpet: entitle more irq pins for hpet

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 04:53, liu ping fan ha scritto: On Sun, Aug 25, 2013 at 2:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 25/08/2013 04:16, Liu Ping Fan ha scritto: On PC, IRQ2/8 can be reserved for hpet timer 0/1. And pin 16~23 of ioapic can be dynamically assigned to hpet as guest chooses.

Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended

2013-08-26 Thread Andrew Jones
- Original Message - Il 23/08/2013 13:33, Andrew Jones ha scritto: Does smp_cpus map to the current number of cpus, or to the number of possible cpus? If it maps to the number of possible cpus, then this is the right place. If the former, then I guess it'll take more thought.

Re: [Qemu-devel] [PATCH 06/16] scsi: Pass size to scsi_bus_new()

2013-08-26 Thread Paolo Bonzini
Il 24/08/2013 02:00, Andreas Färber ha scritto: To be passed to qbus_create_inplace(). Use DEVICE() casts instead of direct parent field access. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp-pci.c | 2 +- hw/scsi/esp.c | 2 +- hw/scsi/lsi53c895a.c | 2

Re: [Qemu-devel] [PATCH 12/16] qdev: Pass size to qbus_create_inplace()

2013-08-26 Thread Cornelia Huck
On Sat, 24 Aug 2013 02:00:32 +0200 Andreas Färber afaer...@suse.de wrote: To be passed to object_initialize(). Since commit 39355c3826f5d9a2eb1ce3dc9b4cdd68893769d6 the argument is void*, so drop some superfluous (BusState *) casts or direct parent field usages. Signed-off-by: Andreas

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-26 Thread Stefan Hajnoczi
On Thu, Aug 22, 2013 at 08:27:12PM +0100, Alex Bligh wrote: On 22 Aug 2013, at 12:45, Stefan Hajnoczi wrote: The behaviour of the current code appears to be as follows (Alexandre's code not mine): a) if the target volume size the converted volume size, convert leaving the remaining

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-26 Thread Stefan Hajnoczi
On Thu, Aug 22, 2013 at 07:03:41PM +0100, Alex Bligh wrote: On 22 Aug 2013, at 13:35, Paolo Bonzini wrote: Also, this is the same as some HMP commands' -n option (live snapshots, mirroring, backup) so I suggest to use that name. You mean -n instead of -C? Sure I can do that, but is that

Re: [Qemu-devel] [RFC PATCH 3/4] qmp: Add snapshot= option to nbd-server-add

2013-08-26 Thread Fam Zheng
On Thu, 08/22 11:22, Paolo Bonzini wrote: Il 22/08/2013 10:53, Fam Zheng ha scritto: This is handy but only works if the QEMU process has permission to create temporary files. Yes, this is a shortcut, it has this limitation, but the good side is it's easy to get and no other

Re: [Qemu-devel] [PATCH 13/16] qom: Pass available size to object_initialize()

2013-08-26 Thread Cornelia Huck
On Sat, 24 Aug 2013 02:00:33 +0200 Andreas Färber afaer...@suse.de wrote: This is to avoid objects initializing beyond allocated memory. Inspired-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber afaer...@suse.de --- hw/core/qdev.c | 2 +-

Re: [Qemu-devel] [PATCH 13/16] qom: Pass available size to object_initialize()

2013-08-26 Thread Wenchao Xia
于 2013-8-24 8:00, Andreas Färber 写道: This is to avoid objects initializing beyond allocated memory. Inspired-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber afaer...@suse.de --- hw/core/qdev.c | 2 +- hw/dma/xilinx_axidma.c | 6 --

Re: [Qemu-devel] [PATCH 00/16] qom: Assert sufficient object instance size

2013-08-26 Thread Wenchao Xia
I have not looked deep into QOM, so only reviewed the code in this series, and have some minor comments for patch 12, 13, and 15. For other part, Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Hello, Peter remarked that object_initialize() on a GICState struct field would not check

Re: [Qemu-devel] [PATCH V9 06/12] NUMA: Add Linux libnuma detection

2013-08-26 Thread Wanlong Gao
On 08/26/2013 03:46 PM, Andrew Jones wrote: Is this patch still necessary? I thought that dropping the numa_num_configured_nodes() calls from patch 8/12 got rid of the need for this library. Maybe I missed other uses? Yes, in 08/12 we also use mbind(), You don't need a whole library

Re: [Qemu-devel] [PATCH] vmxnet3: Eliminate __packed redefined warning

2013-08-26 Thread Stefan Hajnoczi
On Fri, Aug 23, 2013 at 12:28:25PM -0400, Brad Smith wrote: This eliminates a warning about __packed being redefined as exposed by the vmxnet3 code. __packed is not used anywhere in the vmxnet3 code. CChw/net/vmxnet3.o In file included from hw/net/vmxnet3.c:29: hw/net/vmxnet3.h:37:1:

Re: [Qemu-devel] [PATCH resend 3/3] arch_init: right return for ram_save_iterate

2013-08-26 Thread Paolo Bonzini
Il 23/08/2013 15:30, Lei Li ha scritto: -if (ret 0) { -bytes_transferred += total_sent; -return ret; -} - qemu_put_be64(f, RAM_SAVE_FLAG_EOS); total_sent += 8; bytes_transferred += total_sent; -return total_sent; +return

Re: [Qemu-devel] [PATCH 1/2] hpet: entitle more irq pins for hpet

2013-08-26 Thread liu ping fan
On Mon, Aug 26, 2013 at 3:59 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 26/08/2013 04:53, liu ping fan ha scritto: On Sun, Aug 25, 2013 at 2:45 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 25/08/2013 04:16, Liu Ping Fan ha scritto: On PC, IRQ2/8 can be reserved for hpet timer 0/1. And

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Alexander Graf
Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote: +cap.flags = 0; +cap.migration.ecl = 0; +cap.reserve.type = 0; +cap.migration.common.server_support = 0; +

[Qemu-devel] [Bug 1213797] Re: Guest hang after live migration

2013-08-26 Thread chao zhou
The bug has been fixed by the following commit: commit df67696e97d3edd0cb1683bf2eb3b3236bd9a5ed Author: Liu Jinsong jinsong@intel.com Date: Mon Aug 19 09:33:30 2013 +0800 kvm: x86: fix setting IA32_FEATURE_CONTROL with nested VMX disabled This patch is to fix the bug

Re: [Qemu-devel] [PATCH V9 06/12] NUMA: Add Linux libnuma detection

2013-08-26 Thread Andrew Jones
- Original Message - On 08/26/2013 03:46 PM, Andrew Jones wrote: Is this patch still necessary? I thought that dropping the numa_num_configured_nodes() calls from patch 8/12 got rid of the need for this library. Maybe I missed other uses? Yes, in 08/12 we also use

Re: [Qemu-devel] [PATCH 2/9] bswap.h: Remove cpu_to_le32wu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:30PM +0100, Peter Maydell wrote: Replace the legacy cpu_to_le32wu() with stl_le_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed,

Re: [Qemu-devel] [PATCH 4/9] bswap.h: Remove le32_to_cpupu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:32PM +0100, Peter Maydell wrote: Replace the legacy le32_to_cpupu() with ldl_le_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed,

Re: [Qemu-devel] [PATCH 5/9] bswap.h: Remove be32_to_cpupu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:33PM +0100, Peter Maydell wrote: Replace the legacy be32_to_cpupu() with ldl_be_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/net/e1000.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Nikunj A Dadhania
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Mon, 2013-08-26 at 10:02 +0530, Nikunj A Dadhania wrote: From: Nikunj A Dadhania nik...@linux.vnet.ibm.com This implements capabilities exchange between host and client. As at the moment no capability is supported, put zero flags

Re: [Qemu-devel] [PATCH 6/9] bswap.h: Remove cpu_to_be16wu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:34PM +0100, Peter Maydell wrote: Replace the legacy cpu_to_be16wu() with stw_be_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/block/cdrom.c |4 ++-- hw/ide/atapi.c | 16 hw/net/e1000.c | 19

Re: [Qemu-devel] [PATCH 7/9] bswap.h: Remove cpu_to_be32wu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:35PM +0100, Peter Maydell wrote: Replace the legacy cpu_to_be32wu() with stl_be_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- hw/block/cdrom.c |6 +++--- hw/net/e1000.c |3 +-- hw/pci/pcie_aer.c|4 ++--

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Nikunj A Dadhania
Alexander Graf ag...@suse.de writes: Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote: +cap.flags = 0; +cap.migration.ecl = 0; +cap.reserve.type = 0; +

Re: [Qemu-devel] [PATCH 8/9] bswap.h: Remove cpu_to_be64wu()

2013-08-26 Thread Stefan Hajnoczi
On Sun, Aug 25, 2013 at 03:59:36PM +0100, Peter Maydell wrote: Replace the legacy cpu_to_be64wu() with stq_be_p(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- block/qcow2-cluster.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-)

[Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-26 Thread Alex Bligh
From: Alexandre Derumier aderum...@odiso.com Add a -n option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format,

[Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation)

2013-08-26 Thread Alex Bligh
Add a qemu-img convert -n option to skip target volume creation Changes since v5: * Fail conversion if the existing output image is smaller than the input image and the -n option is specified * Use -n not -C * Add a test routine Alexandre Derumier (1): add qemu-img convert -n option (skip

Re: [Qemu-devel] [PATCHv4] add qemu-img convert -C option (skip target volume creation)

2013-08-26 Thread Alex Bligh
On 26 Aug 2013, at 09:03, Stefan Hajnoczi wrote: Silently truncating can be a problem, e.g. the user deletes the original file after conversion completes and later discovers not all data was copied. I think we should fail here. Fixed in v5 (just sent), together with using -n not -C

Re: [Qemu-devel] [PATCH resend 3/3] arch_init: right return for ram_save_iterate

2013-08-26 Thread Lei Li
On 08/26/2013 04:27 PM, Paolo Bonzini wrote: Il 23/08/2013 15:30, Lei Li ha scritto: -if (ret 0) { -bytes_transferred += total_sent; -return ret; -} - qemu_put_be64(f, RAM_SAVE_FLAG_EOS); total_sent += 8; bytes_transferred += total_sent; -return

[Qemu-devel] [PATCH 1/3 v2] savevm: add comments for qemu_file_get_error()

2013-08-26 Thread Lei Li
Add comments for qemu_file_get_error(), as its return value is not very clear. Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 03fc4d9..95a11f9 100644 --- a/savevm.c +++

[Qemu-devel] [PATCH 3/3 v2] arch_init: right return for ram_save_iterate

2013-08-26 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Change since v1: Return fixes and improvement from Paolo Bonzini. arch_init.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCH 2/3 v2] savevm: fix wrong error set by ram_control_load_hook()

2013-08-26 Thread Lei Li
It should set negative error value if there has been an error. Reviewed-by: Michael R. Hines mrhi...@us.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- savevm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 95a11f9..a0be109 100644

[Qemu-devel] [PATCH v2 07/47] hw/arm/Makefile.objs: CONFIG_* created for each board

2013-08-26 Thread Ákos Kovács
The new CONFIG_* definitions added to the default-configs/arm-softmmu.mak Signed-off-by: Ákos Kovács akoskov...@gmx.com --- default-configs/arm-softmmu.mak | 13 + hw/arm/Makefile.objs| 35 --- 2 files changed, 41 insertions(+), 7

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 11:08, Nikunj A Dadhania wrote: Alexander Graf ag...@suse.de writes: Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote: +cap.flags = 0; +cap.migration.ecl = 0; +

[Qemu-devel] Boot Problems Windows XP guest

2013-08-26 Thread Erik Rull
Hi all, is it possible to get back to the legacy BIOS instead of the (u)efi based BIOS? I have problems booting the guest on a SSD HDD, there it reboots infinitely, when running the guest on a rotating HDD, it works. On qemu 1.2.0 both disks work properly. I didn't find a way to select the BIOS

[Qemu-devel] [Bug 1213797] Re: Guest hang after live migration

2013-08-26 Thread Paolo Bonzini
The fix is in no released version, so the bug is stomped. ** Changed in: qemu Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1213797 Title: Guest hang after live

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Benjamin Herrenschmidt
On Mon, 2013-08-26 at 10:43 +0200, Alexander Graf wrote: Do we ever need to preserve random fields in that struct? Or would it be clearer to just set the whole thing to 0 and then go from there? Yeah sort of, we set/clear bits more/less based on what the guest put in the first place, it's a bit

Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values.

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 08:46, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed

Re: [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig

2013-08-26 Thread Peter Maydell
On 25 August 2013 23:58, Ákos Kovács akoskov...@gmx.com wrote: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/arm/Kconfig | 235 1 file changed, 235 insertions(+) create mode 100644 hw/arm/Kconfig diff --git

Re: [Qemu-devel] [PATCH 17/47] hw/9pfs/Kconfig: Add 9pfs Kconfig

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/9pfs/Kconfig |2 ++ 1 file changed, 2 insertions(+) create mode 100644 hw/9pfs/Kconfig diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig new file mode 100644 index 000..f16ffed ---

Re: [Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/audio/Kconfig | 41 + 1 file changed, 41 insertions(+) create mode 100644 hw/audio/Kconfig diff --git a/hw/audio/Kconfig b/hw/audio/Kconfig new

Re: [Qemu-devel] [PATCH 07/47] hw/arm/Makefile.objs: CONFIG_* created for each board

2013-08-26 Thread Peter Maydell
On 25 August 2013 23:58, Ákos Kovács akoskov...@gmx.com wrote: The new CONFIG_* definitions added to the default-configs/arm-softmmu.mak Signed-off-by: Ákos Kovács akoskov...@gmx.com --- default-configs/arm-softmmu.mak | 13 + hw/arm/Makefile.objs| 35

Re: [Qemu-devel] [PATCH 20/47] hw/block/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/block/Kconfig | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 hw/block/Kconfig diff --git a/hw/block/Kconfig b/hw/block/Kconfig new file mode

Re: [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/char/Kconfig | 24 1 file changed, 24 insertions(+) create mode 100644 hw/char/Kconfig diff --git a/hw/char/Kconfig b/hw/char/Kconfig new file mode 100644 index

Re: [Qemu-devel] [PATCH 22/47] hw/core/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/core/Kconfig | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 hw/core/Kconfig diff --git a/hw/core/Kconfig b/hw/core/Kconfig new file mode 100644 index

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Nikunj A Dadhania
Alexander Graf ag...@suse.de writes: Am 26.08.2013 um 05:32 schrieb Nikunj A Dadhania nik...@linux.vnet.ibm.com: Benjamin Herrenschmidt b...@kernel.crashing.org writes: From: Nikunj A Dadhania nik...@linux.vnet.ibm.com This implements capabilities exchange between host and client. Client?

Re: [Qemu-devel] [PATCH 24/47] hw/display/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/display/Kconfig | 84 1 file changed, 84 insertions(+) create mode 100644 hw/display/Kconfig diff --git a/hw/display/Kconfig

Re: [Qemu-devel] [PATCH 25/47] hw/dma/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/dma/Kconfig | 25 + 1 file changed, 25 insertions(+) create mode 100644 hw/dma/Kconfig diff --git a/hw/dma/Kconfig b/hw/dma/Kconfig new file mode 100644 index

Re: [Qemu-devel] [PATCH 27/47] hw/i2c/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/i2c/Kconfig | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 hw/i2c/Kconfig diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig new file mode 100644 index 000..eaf17cc

Re: [Qemu-devel] [PATCH 30/47] hw/intc/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/intc/Kconfig | 28 1 file changed, 28 insertions(+) create mode 100644 hw/intc/Kconfig diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig new file mode 100644

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Nikunj A Dadhania
Alexander Graf ag...@suse.de writes: Am 26.08.2013 um 05:32 schrieb Nikunj A Dadhania nik...@linux.vnet.ibm.com: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Sun, 2013-08-25 at 17:41 +0100, Alexander Graf wrote: +vcap = req-iu.mad.capabilities; +rc =

Re: [Qemu-devel] [PATCH 32/47] hw/misc/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/misc/Kconfig | 67 +++ 1 file changed, 67 insertions(+) create mode 100644 hw/misc/Kconfig diff --git a/hw/misc/Kconfig

Re: [Qemu-devel] [PATCH 35/47] hw/pci/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: + +menu PCI +config PCI_HOTPLUG +bool Enable hotplugging for PCI devices +depends on PCI +endmenu This has now been renamed to CONFIG_PCI_HOTPLUG_OLD. It's a legacy interface, so perhaps you can leave the prompt out. Paolo

Re: [Qemu-devel] [PATCH 37/47] hw/pci-host/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/pci-host/Kconfig | 36 1 file changed, 36 insertions(+) create mode 100644 hw/pci-host/Kconfig diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig

Re: [Qemu-devel] [PATCH 31/47] hw/isa/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/isa/Kconfig | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 hw/isa/Kconfig diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig new file mode

Re: [Qemu-devel] [PATCH 39/47] hw/sd/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/sd/Kconfig | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 hw/sd/Kconfig diff --git a/hw/sd/Kconfig b/hw/sd/Kconfig new file mode 100644 index

Re: [Qemu-devel] [PATCH 43/47] hw/usb/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/usb/Kconfig | 60 1 file changed, 60 insertions(+) create mode 100644 hw/usb/Kconfig diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig

Re: [Qemu-devel] [PATCH 44/47] hw/watchdog/Kconfig: Add Kconfig file

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/watchdog/Kconfig |7 +++ 1 file changed, 7 insertions(+) create mode 100644 hw/watchdog/Kconfig diff --git a/hw/watchdog/Kconfig b/hw/watchdog/Kconfig new file mode 100644 index

Re: [Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- hw/arm/Kconfig | 235 1 file changed, 235 insertions(+) create mode 100644 hw/arm/Kconfig diff --git a/hw/arm/Kconfig

Re: [Qemu-devel] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 07:46, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to

Re: [Qemu-devel] [PATCH 46/47] configure: Generate Kconfig.targets with --target-list

2013-08-26 Thread Paolo Bonzini
Il 26/08/2013 00:58, Ákos Kovács ha scritto: Signed-off-by: Ákos Kovács akoskov...@gmx.com --- configure | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure b/configure index 18fa608..353c0cb 100755 --- a/configure +++ b/configure @@ -4288,6 +4288,7 @@ case

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 12:58, Nikunj A Dadhania wrote: Alexander Graf ag...@suse.de writes: Am 26.08.2013 um 05:32 schrieb Nikunj A Dadhania nik...@linux.vnet.ibm.com: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Sun, 2013-08-25 at 17:41 +0100, Alexander Graf wrote: +vcap =

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-26 Thread Gleb Natapov
On Sun, Aug 25, 2013 at 04:11:51PM +0100, Peter Maydell wrote: On 25 August 2013 15:42, Gleb Natapov g...@redhat.com wrote: Are ARM cpu features not enumerable and the only way to know what is supported by a core is by its id? I do see feature registers in the spec, so why wouldn't we want

[Qemu-devel] [PATCH] curl: qemu_bh_new() can never return NULL

2013-08-26 Thread Stefan Hajnoczi
Drop error code path which cannot be taken since qemu_bh_new() does not return NULL. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/curl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/block/curl.c b/block/curl.c index e566855..ca2cedc 100644 --- a/block/curl.c +++

Re: [Qemu-devel] [RFC PATCH] Introduce RCU-enabled DQs (v2)

2013-08-26 Thread Paolo Bonzini
Il 25/08/2013 15:06, Mike Day ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Just a couple of questions, one of them on the new macro... +/* prior to publication of the elm-prev-next value, some list + * readers may still see the removed element when following + * the

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Nikunj A Dadhania
Alexander Graf ag...@suse.de writes: On 26.08.2013, at 12:58, Nikunj A Dadhania wrote: This implements capabilities exchange between host and client. As at the moment no capability is supported, put zero flags everywhere and return. Signed-off-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-26 Thread Alexander Graf
On 26.08.2013, at 13:46, Nikunj A Dadhania wrote: Alexander Graf ag...@suse.de writes: On 26.08.2013, at 12:58, Nikunj A Dadhania wrote: This implements capabilities exchange between host and client. As at the moment no capability is supported, put zero flags everywhere and return.

Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values.

2013-08-26 Thread Aneesh Kumar K.V
Alexander Graf ag...@suse.de writes: On 26.08.2013, at 08:46, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: + */ +memset(env-slb, 0, 64 * sizeof(ppc_slb_t)); Can't we use ARRAY_SIZE here and below? I was thinking we want to be explicit there

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-26 Thread Peter Maydell
On 26 August 2013 12:18, Gleb Natapov g...@redhat.com wrote: On Sun, Aug 25, 2013 at 04:11:51PM +0100, Peter Maydell wrote: A lot are feature bits that are simply mandatory for any ARMv7 or later processor (which is what you need for KVM to work at all). What if you want to emulate older arm

Re: [Qemu-devel] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-26 Thread Aneesh Kumar K.V
Alexander Graf ag...@suse.de writes: On 26.08.2013, at 07:46, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: ... This breaks PR KVM which doesn't have an HTAB fd. I think what you want is code in kvmppc_set_papr() that tries to fetch an HTAB fd. You can then modify the

Re: [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command

2013-08-26 Thread Aneesh Kumar K.V
Andreas Färber afaer...@suse.de writes: Am 25.08.2013 20:32, schrieb Alexander Graf: On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com When we translate the virtual address to physical check for error. Signed-off-by: Aneesh Kumar

Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic

2013-08-26 Thread Paolo Bonzini
Il 13/08/2013 00:02, Paolo Bonzini ha scritto: vapic requires the VAPIC ROM to be mapped into RAM. This is not possible without PAM hardware. This fixes a segmentation fault running with -M isapc. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- diff

Re: [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command

2013-08-26 Thread Andreas Färber
Am 26.08.2013 14:20, schrieb Aneesh Kumar K.V: Andreas Färber afaer...@suse.de writes: Am 25.08.2013 20:32, schrieb Alexander Graf: On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com When we translate the virtual address to physical

Re: [Qemu-devel] [PATCH] spapr: support CPU hotplug

2013-08-26 Thread Alexander Graf
On 23.08.2013, at 13:30, Alexey Kardashevskiy wrote: PAPR+ requires two RTAS calls to be supported by the hypervisor in order to allow hotplugging VCPUs from the guest. The start-cpu RTAS call was already there but stop-self was not. This adds the stop-self RTAS call. Signed-off-by:

Re: [Qemu-devel] KVM guest cpu L3 cache and cpufreq

2013-08-26 Thread Gleb Natapov
On Tue, Aug 13, 2013 at 08:17:13PM +0200, Benoît Canet wrote: Hi, I noticed that the l3 cache size of a guest /proc/cpuinfo is not the same as the l3 cache size of the host. I did not found any references to this in the qemu and KVM code. Is the size of the guest L3 cache fixed in

Re: [Qemu-devel] KVM guest cpu L3 cache and cpufreq

2013-08-26 Thread Benoît Canet
Hi, Thanks for the answer. On Tue, Aug 13, 2013 at 08:17:13PM +0200, Benoît Canet wrote: Hi, I noticed that the l3 cache size of a guest /proc/cpuinfo is not the same as the l3 cache size of the host. I did not found any references to this in the qemu and KVM code. Is the

[Qemu-devel] [PATCH 5/5] qemu-iotests: Overlapping cluster allocations

2013-08-26 Thread Max Reitz
A new test on corrupted images with overlapping cluster allocations. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/060 | 107 + tests/qemu-iotests/060.out | 43 ++ tests/qemu-iotests/group | 1 + 3 files

Re: [Qemu-devel] [RFC PATCH v4] powerpc: add PVR mask support

2013-08-26 Thread Alexander Graf
On 19.08.2013, at 06:06, Alexey Kardashevskiy wrote: IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there is no point to add every single CPU version in QEMU's CPU

[Qemu-devel] [PATCH 4/5] qcow2: Check allocations in qcow2_check

2013-08-26 Thread Max Reitz
Adds a new function checking for overlapping cluster allocations. Furthermore, qcow2_check now marks the image as consistent if no corruptions have been found. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-cluster.c | 414 ++

[Qemu-devel] [PATCH 2/5] qcow2: Metadata overlap checks

2013-08-26 Thread Max Reitz
Two new functions are added; the first one checks a given range in the image file for overlaps with metadata (main header, L1 tables, L2 tables, refcount table and blocks). The second one should be used immediately before writing to the image file as it calls the first function and, upon

[Qemu-devel] [PATCH 1/5] qcow2: Add corrupt bit

2013-08-26 Thread Max Reitz
This adds an incompatible bit indicating corruption to qcow2. Any image with this bit set may not be written to unless for repairing (and subsequently clearing the bit if the repair has been successful). Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2.c | 44

[Qemu-devel] [PATCH 3/5] qcow2: Employ metadata overlap checks

2013-08-26 Thread Max Reitz
The pre-write overlap check function is now called before most of the qcow2 writes (aborting it on collision or other error). Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-cache.c| 17 + block/qcow2-cluster.c | 23 +++ block/qcow2-snapshot.c

  1   2   3   >