[Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs-file. Signed-off-by: Peter Lieven p...@kamp.de --- v5: add a generic get_lba_status function in the raw driver which adds the BDRV_BLOCK_RAW flag.

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Peter Lieven
On 06.10.2013 15:57, Zhang Haoyu wrote: From my testing this has been fixed in the saucy version (1.5.0) of qemu. It is fixed by this patch: f1c72795af573b24a7da5eb52375c9aba8a37972 However later in the history this commit was reverted, and again broke this. The other commit that fixes this

Re: [Qemu-devel] [PATCH RFC v2 7/9] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Gerd Hoffmann
On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote: --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s) } else { level = 0; } -qemu_set_irq(s-dev.irq[s-irq_pin], level); +pci_set_irq(s-dev, level);

Re: [Qemu-devel] [PATCH RFC v2 7/9] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
On Mon, 2013-10-07 at 09:02 +0200, Gerd Hoffmann wrote: On Mi, 2013-10-02 at 15:41 +0300, Marcel Apfelbaum wrote: --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -381,7 +381,7 @@ static void uhci_update_irq(UHCIState *s) } else { level = 0; } -

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-10-07 Thread Gerd Hoffmann
On Mi, 2013-10-02 at 15:14 +0200, Jan Kiszka wrote: On 2013-09-19 11:34, Gerd Hoffmann wrote: The usb-host code has been rewritten for qemu 1.5 to use libusb, the old code has been left in as temporary fallback. Now we are two releases further out, targeting the 1.7 release. No major

Re: [Qemu-devel] [PATCH V9 11/11] quorum: Add quorum_open() and quorum_close().

2013-10-07 Thread Max Reitz
On 2013-10-04 17:31, Eric Blake wrote: On 10/04/2013 09:14 AM, Max Reitz wrote: On 2013-10-02 14:39, Benoît Canet wrote: Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.qcow2,\ file.children.1.file.filename=2.qcow2,\

Re: [Qemu-devel] [PATCH] cpu-exec(): also reload CPUClass *cc after longjmp return

2013-10-07 Thread Andreas Färber
Am 05.10.2013 23:45, schrieb Juergen Lock: On Sat, Oct 05, 2013 at 08:06:22PM +0200, Stefan Weil wrote: Am 05.10.2013 19:54, schrieb Juergen Lock: On Fri, Oct 04, 2013 at 09:15:37AM +0200, Jan Kiszka wrote: On 2013-10-03 18:05, Peter Maydell wrote: On 3 October 2013 23:09, Juergen Lock

[Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin

2013-10-07 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise, qemu_irq_lower and qemu_irq_pulse, setting the irq based on

[Qemu-devel] [PATCH v3 1/8] hw/core: Add interface to allocate and free a single IRQ

2013-10-07 Thread Marcel Apfelbaum
qemu_allocate_irq returns a single qemu_irq. The interface allows to specify an interrupt number. qemu_free_irq frees it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/core/irq.c| 16 include/hw/irq.h | 7 +++ 2 files changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH v3 2/8] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-07 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin on each call. Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise, qemu_irq_lower and qemu_irq_pulse, setting the irq

[Qemu-devel] [PATCH v3 4/8] hw/vmxnet3: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
pci_set_irq uses PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An assert is used to ensure that intx received from the quest OS corresponds to PCI_INTERRUPT_PIN. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Changes from v2: - Addressed Alex

[Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices. Removed irq related fields from state if not used anymore. Signed-off-by:

[Qemu-devel] [PATCH v3 8/8] hw/pci: removed irq field from PCIDevice

2013-10-07 Thread Marcel Apfelbaum
Instead of exposing the the irq field, pci wrappers to qemu_set_irq or qemu_irq_* can be used. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci/pci.c | 2 -- include/hw/pci/pci.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index

[Qemu-devel] [PATCH v3 3/8] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init

2013-10-07 Thread Marcel Apfelbaum
The PCI_INTERRUPT_PIN will be used by shpc init, so was moved before the call to shpc_init. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c

[Qemu-devel] [PATCH v3 7/8] hw/pcie: AER and hot-plug events must use device's interrupt

2013-10-07 Thread Marcel Apfelbaum
The fields hpev_intx and aer_intx were removed because both AER and hot-plug events must use device's interrupt. Assert/deassert interrupts using pci irq wrappers instead. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Changes from v2: - Addressed Alex Williamson's comments -

[Qemu-devel] [PATCH v3 5/8] hw/vfio: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. save INTX pin into the config register before calling pci_set_irq Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Changes from v2: - Addressed Alex

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 15:20 +0200, Igor Mammedov wrote: On Wed, 21 Aug 2013 13:01:32 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, +#define ICH9_PROC_BASE 0xaf00 +#define ICH9_PROC_LEN 32 No, please don't. It makes it impossible to assign the 0xa000 - 0xafff I/O port

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices.

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 11:03:47AM +0300, Michael S. Tsirkin wrote: On Mon, Oct 07, 2013 at 10:36:39AM +0300, Marcel Apfelbaum wrote: pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated

Re: [Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState

2013-10-07 Thread Stefan Hajnoczi
On Wed, Oct 02, 2013 at 09:53:01AM -0600, Eric Blake wrote: On 09/24/2013 07:35 AM, Peter Lieven wrote: this patch adds BlockLimits which introduces discard and write_zeroes limits and alignment information to the BlockDriverState. Signed-off-by: Peter Lieven p...@kamp.de ---

Re: [Qemu-devel] [PATCH v3 6/8] hw: set interrupts using pci irq wrappers

2013-10-07 Thread Marcel Apfelbaum
static void uhci_reset(void *opaque) @@ -1240,8 +1239,7 @@ static int usb_uhci_common_initfn(PCIDevice *dev) /* TODO: reset value should be 0. */ pci_conf[USB_SBRN] = USB_RELEASE_1; // release number -s-irq_pin = u-info.irq_pin; -

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 07:59, Peter Lieven ha scritto: if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs-file. Signed-off-by: Peter Lieven p...@kamp.de --- v5: add a generic get_lba_status function in the raw

Re: [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard

2013-10-07 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:35:02PM +0200, Peter Lieven wrote: @@ -4245,7 +4250,37 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, } if (bs-drv-bdrv_co_discard) { -return bs-drv-bdrv_co_discard(bs, sector_num, nb_sectors); +int

Re: [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize

2013-10-07 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:35:07PM +0200, Peter Lieven wrote: this patch adds a call to completely zero out a block device. the operation is sped up by checking the block status and only writing zeroes to the device if they currently do not return zeroes. optionally the zero writing can be

Re: [Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard

2013-10-07 Thread Peter Lieven
Am 07.10.2013 um 10:29 schrieb Stefan Hajnoczi stefa...@gmail.com: On Tue, Sep 24, 2013 at 03:35:02PM +0200, Peter Lieven wrote: @@ -4245,7 +4250,37 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, } if (bs-drv-bdrv_co_discard) { -return

Re: [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open

2013-10-07 Thread Stefan Hajnoczi
On Wed, Oct 02, 2013 at 11:11:05AM -0600, Eric Blake wrote: On 09/24/2013 07:35 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/raw_bsd.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 8dc7bba..7af26ad

Re: [Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize

2013-10-07 Thread Peter Lieven
Am 07.10.2013 um 10:34 schrieb Stefan Hajnoczi stefa...@gmail.com: On Tue, Sep 24, 2013 at 03:35:07PM +0200, Peter Lieven wrote: this patch adds a call to completely zero out a block device. the operation is sped up by checking the block status and only writing zeroes to the device if they

Re: [Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open

2013-10-07 Thread Peter Lieven
Am 07.10.2013 um 10:38 schrieb Stefan Hajnoczi stefa...@gmail.com: On Wed, Oct 02, 2013 at 11:11:05AM -0600, Eric Blake wrote: On 09/24/2013 07:35 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/raw_bsd.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements

2013-10-07 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 03:34:54PM +0200, Peter Lieven wrote: this patch adds the ability for targets to stay sparse during block migration (if the zero_blocks capability is set) and qemu-img convert even if the target does not have has_zero_init = 1. the series was especially developed for

Re: [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements

2013-10-07 Thread Peter Lieven
Am 07.10.2013 um 10:42 schrieb Stefan Hajnoczi stefa...@gmail.com: On Tue, Sep 24, 2013 at 03:34:54PM +0200, Peter Lieven wrote: this patch adds the ability for targets to stay sparse during block migration (if the zero_blocks capability is set) and qemu-img convert even if the target does

Re: [Qemu-devel] [PATCH] block: use correct filename

2013-10-07 Thread Stefan Hajnoczi
On Thu, Oct 03, 2013 at 01:31:27AM +0800, Dunrong Huang wrote: The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use bs-filename. Signed-off-by: Dunrong Huang riegama...@gmail.com --- block.c | 4 ++--

[Qemu-devel] [PATCH V14 07/11] NUMA: expand MAX_NODES from 64 to 128

2013-10-07 Thread Wanlong Gao
libnuma choosed 128 for MAX_NODES, so we follow libnuma here. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- include/sysemu/sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 861cd77..995cf3b 100644 ---

[Qemu-devel] [PATCH V14 05/11] NUMA: introduce NumaMemOptions

2013-10-07 Thread Wanlong Gao
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- qapi-schema.json | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8cf0179..d291f28 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3912,7 +3912,8 @@

[Qemu-devel] [PATCH V14 06/11] NUMA: add -numa mem, options

2013-10-07 Thread Wanlong Gao
Add -numa mem, option like following as Paolo suggested: -numa mem,nodeid=0,size=1G This new option will make later coming memory hotplug better. We will use the new options to specify nodes memory info, and just remain -numa node,mem=xx as legacy. Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH V14 09/11] NUMA: set guest numa nodes memory policy

2013-10-07 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is

[Qemu-devel] [PATCH V14 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

2013-10-07 Thread Wanlong Gao
Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- hmp.c | 57 + hmp.h | 1 + monitor.c | 21 + 3 files changed, 59 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH V14 02/11] NUMA: check if the total numa memory size is equal to ram_size

2013-10-07 Thread Wanlong Gao
If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI talb, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it to ensure that we write the right data to

[Qemu-devel] [PATCH V14 10/11] NUMA: add qmp command query-numa

2013-10-07 Thread Wanlong Gao
Add qmp command query-numa to show guest NUMA information. Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- numa.c | 66 qapi-schema.json | 36

Re: [Qemu-devel] [PATCH 8/9] arch_init: make is_zero_page accept size

2013-10-07 Thread Peter Lieven
On 24.09.2013 14:03, Juan Quintela wrote: From: Isaku Yamahata yamah...@private.email.ne.jp Later is_zero_page will be used for non TARGET_PAGE_SIZE range. And rename it to is_zero_range as it isn't page size any more. Signed-off-by: Isaku Yamahata yamah...@private.email.ne.jp Signed-off-by:

[Qemu-devel] [PATCH v3 1/4] pci: add pci_for_each_bus_depth_first

2013-10-07 Thread Michael S. Tsirkin
Add a method to scan pci buses in a predictable order. Useful for ACPI hotplug. Document that order is not guaranteed for pci_for_each_device, and re-implement using that. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 14 ++ hw/pci/pci.c | 28

[Qemu-devel] [PATCH v3 0/4] acpi hotplug of devices behind a pci bridge

2013-10-07 Thread Michael S. Tsirkin
This is on top of patchset generating ACPI tables in qemu. Please review and consider for 1.7. Changes from v2: - split new code out to a separate file: acpi/pcihp.c this way we can reuse it for q35 later - rebased on top of the latest acpi-build patchset Changes from v1: -

[Qemu-devel] [PATCH v3 3/4] piix4: add acpi pci hotplug support

2013-10-07 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75

[Qemu-devel] [PATCH v3 2/4] pcihp: generalization of piix4 acpi

2013-10-07 Thread Michael S. Tsirkin
Add ACPI based PCI hotplug library with bridge hotplug support. Design - each bus gets assigned bsel property. - ACPI code writes this number to a new BNUM register, then uses existing UP/DOWN registers to probe slot status; to eject, write number to BNUM register, then

[Qemu-devel] [PATCH V14 01/11] NUMA: move numa related code to new file numa.c

2013-10-07 Thread Wanlong Gao
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- Makefile.target | 2 +- cpus.c | 14 include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 3 + numa.c | 182 vl.c

[Qemu-devel] [PATCH v3 4/4] acpi-build: enable hotplug for PCI bridges

2013-10-07 Thread Michael S. Tsirkin
This enables support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - at machine init time, assign bsel property to bridges with hotplug support - dynamically (At ACPI table read) generate ACPI code to handle

Re: [Qemu-devel] [PATCH 1/5] tcg-aarch64: Update to helper_ret_*_mmu routines

2013-10-07 Thread Claudio Fontana
On 10/05/13 09:37, Richard Henderson wrote: On 10/04/2013 02:15 PM, Claudio Fontana wrote: At first glance I think we should add X4 to the list of restrictions in function `target_parse_constraint': No, we've consumed all of the inputs at this point. We only need list those registers

[Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Peter Lieven
The madvise for zeroed out pages was introduced when every transferred zero page was memset to zero and thus allocated. Since commit 211ea740 we check for zeroness of a target page before we memset it to zero. Additionally we memmap target memory so it is essentially zero initalized (except for

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Peter Lieven
On 07.10.2013 10:25, Paolo Bonzini wrote: Il 07/10/2013 07:59, Peter Lieven ha scritto: if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs-file. Signed-off-by: Peter Lieven p...@kamp.de --- v5: add a

Re: [Qemu-devel] [PATCH] spice: replace use of deprecated API

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 13:10 +0200, Marc-André Lureau wrote: hose API are deprecated since 0.11, and qemu depends on 0.12 already. Added to spice patch queue. thanks, Gerd

[Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects

[Qemu-devel] [PATCH v9 02/27] qom: cleanup struct Error references

2013-10-07 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH v9 03/27] qom: add pointer to int property helpers

2013-10-07 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 21

[Qemu-devel] [PATCH v9 06/27] loader: support for unmapped ROM blobs

2013-10-07 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support invoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann

[Qemu-devel] [PATCH v9 04/27] pci: fix up w64 size calculation helper

2013-10-07 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v9 10/27] q35: expose mmcfg size as a property

2013-10-07 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed,

[Qemu-devel] [PATCH v9 07/27] pcie_host: expose UNMAPPED macro

2013-10-07 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3

[Qemu-devel] [PATCH v9 05/27] fw_cfg: interface to trigger callback on read

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v9 12/27] acpi: add rules to compile ASL source

2013-10-07 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure

[Qemu-devel] [PATCH v9 08/27] pcie_host: expose address format

2013-10-07 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c

[Qemu-devel] [PATCH v9 15/27] loader: use file path size from fw_cfg.h

2013-10-07 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 +++-

[Qemu-devel] [PATCH v9 09/27] q35: use macro for MCFG property name

2013-10-07 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v9 23/27] hpet: add API to find it

2013-10-07 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git

[Qemu-devel] [PATCH v9 25/27] ssdt: fix PBLK length

2013-10-07 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 08:38, Peter Lieven ha scritto: On 06.10.2013 15:57, Zhang Haoyu wrote: From my testing this has been fixed in the saucy version (1.5.0) of qemu. It is fixed by this patch: f1c72795af573b24a7da5eb52375c9aba8a37972 However later in the history this commit was reverted, and again

[Qemu-devel] [PATCH v9 14/27] acpi: ssdt pcihp: updat generated file

2013-10-07 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v9 16/27] i386: add bios linker/loader

2013-10-07 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann

[Qemu-devel] [PATCH v9 17/27] loader: allow adding ROMs in done callbacks

2013-10-07 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9

[Qemu-devel] [PATCH v9 18/27] i386: define pc guest info

2013-10-07 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PATCH v9 19/27] acpi/piix: add macros for acpi property names

2013-10-07 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v9 20/27] piix: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S.

[Qemu-devel] [PATCH v9 21/27] ich9: APIs for pc guest info

2013-10-07 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH v9 22/27] pvpanic: add API to access io port

2013-10-07 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13

Re: [Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 11:22, Peter Lieven ha scritto: The madvise for zeroed out pages was introduced when every transferred zero page was memset to zero and thus allocated. Since commit 211ea740 we check for zeroness of a target page before we memset it to zero. Additionally we memmap target memory

[Qemu-devel] [Bug 1235306] Re: Wrong memory viewer in 16 bit mode (Debugging BIOS OptionROM)

2013-10-07 Thread Leonid Myravjev
I apologize for the stupid ticket. Problem with a bad GDB configuration. ** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1235306 Title: Wrong

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Peter Lieven
On 07.10.2013 11:37, Paolo Bonzini wrote: Il 07/10/2013 08:38, Peter Lieven ha scritto: On 06.10.2013 15:57, Zhang Haoyu wrote: From my testing this has been fixed in the saucy version (1.5.0) of qemu. It is fixed by this patch: f1c72795af573b24a7da5eb52375c9aba8a37972 However later in the

[Qemu-devel] [PATCH v9 26/27] ssdt-proc: update generated file

2013-10-07 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file

Re: [Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 11:49, Peter Lieven ha scritto: It's in general not easy to do this if you take non-x86 targets into account. What about the dirty way to zero out all non zero pages at the beginning of ram_load? I'm not sure I follow? Paolo

Re: [Qemu-devel] [PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-10-07 Thread Andreas Färber
Am 07.10.2013 11:22, schrieb Peter Lieven: The madvise for zeroed out pages was introduced when every transferred zero page was memset to zero and thus allocated. Since commit 211ea740 we check for zeroness of a target page before we memset it to zero. Additionally we memmap target memory so

Re: [Qemu-devel] [PATCH v3 0/8] hw/pci: set irq without selecting INTx pin

2013-10-07 Thread Michael S. Tsirkin
On Mon, Oct 07, 2013 at 10:36:33AM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Added pci_* wrappers to replace qemu_set_irq,

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Fabien Chouteau
On 10/04/2013 07:49 PM, Peter Maydell wrote: On 5 October 2013 01:57, Fabien Chouteau chout...@adacore.com wrote: @@ -47,7 +48,9 @@ #include hw/xen/xen.h #include hw/i386/apic_internal.h #endif +#include monitor/monitor_def.h +extern const MonitorDef i386_monitor_defs[]; Declare

Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-10-07 Thread Fabien Chouteau
On 10/04/2013 07:52 PM, Peter Maydell wrote: +#include monitor/monitor_def.h + +const MonitorDef arm_monitor_defs[] = { +{ r0, offsetof(CPUARMState, regs[0]) }, +{ r1, offsetof(CPUARMState, regs[1]) }, These fields are all 32 bits, not target_long, so they need to be

[Qemu-devel] [PATCH v9 01/27] cleanup object.h: include error.h directly

2013-10-07 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 2 +- 1 file

Re: [Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 10:42, Stefan Hajnoczi ha scritto: Could you make bdrv_co_write_zeroes() always use UNMAP, if possible, and avoid adding the new BDRV_REQ_MAY_UNMAP flag? While reading the first few patches in this series I wondered why there is a need to expose flags at all... Sometimes it

Re: [Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-07 Thread Michael Mueller
On Thu, 03 Oct 2013 07:53:02 -0700 Richard Henderson r...@twiddle.net wrote: On 10/02/2013 04:33 AM, Michael Mueller wrote: +/* set a specific bit in facility set */ +static void set_facility(unsigned int nr, void *facilities) +{ +unsigned char *ptr; + +if (nr =

[Qemu-devel] [PULL 0/8] Block patches

2013-10-07 Thread Stefan Hajnoczi
The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch changes up to

[Qemu-devel] [PULL 1/8] qcow2: Correct endianness in overlap check

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 2/8] qcow2: CHECK_OFLAG_COPIED is obsolete

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency check is actually no longer performed by these functions (but by check_oflag_copied). Signed-off-by: Max Reitz mre...@redhat.com

[Qemu-devel] [PULL 7/8] qemu-iotests: Correct 026 output

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com Because l2_allocate now frees the unused L2 cluster on error, the according test cases in 026 don't result in one leaked cluster anymore. Signed-off-by: Max Reitz mre...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PULL 4/8] block: vhdx - add migration blocker

2013-10-07 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com This blocks migration for VHDX image files, until the functionality can be supported. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/vhdx.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[Qemu-devel] [PULL 5/8] qcow2: Switch L1 table in a single sequence

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com Switching the L1 table in memory should be an atomic operation, as far as possible. Calling qcow2_free_clusters on the old L1 table on disk is not a good idea when the old L1 table is no longer valid and the address to the new one hasn't yet been written into the

[Qemu-devel] [PULL 6/8] qcow2: Free allocated L2 cluster on error

2013-10-07 Thread Stefan Hajnoczi
From: Max Reitz mre...@redhat.com If an error occurs in l2_allocate, the allocated (but unused) L2 cluster should be freed. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block/qcow2-cluster.c | 4

[Qemu-devel] [PULL 3/8] block: use correct filename for error report

2013-10-07 Thread Stefan Hajnoczi
From: Dunrong Huang riegama...@gmail.com The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use bs-filename. Signed-off-by: Dunrong Huang riegama...@gmail.com Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Peter Maydell
On 7 October 2013 19:11, Fabien Chouteau chout...@adacore.com wrote: On 10/04/2013 07:49 PM, Peter Maydell wrote: On 5 October 2013 01:57, Fabien Chouteau chout...@adacore.com wrote: @@ -47,7 +48,9 @@ #include hw/xen/xen.h #include hw/i386/apic_internal.h #endif +#include

[Qemu-devel] [PULL 8/8] block: use correct filename

2013-10-07 Thread Stefan Hajnoczi
From: Dunrong Huang riegama...@gmail.com The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use bs-filename. Signed-off-by: Dunrong Huang riegama...@gmail.com Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-10-07 Thread Paolo Bonzini
Il 30/09/2013 15:34, Alex Bligh ha scritto: I think the most likely change here is that the walkers might move outside the BQL. Given modification of this list is so rare, the lock would be very very read heavy, so RCU is probably a sensible option. I agree. Keeping the write side on the

Re: [Qemu-devel] [PATCH v5 0/4] timers thread-safe stuff

2013-10-07 Thread Paolo Bonzini
Stefan, will you pick this up next week or shall I? I have patches for thread-safe icount almost ready to post, and I am not sure through whom they are going to go. Paolo Il 25/09/2013 08:20, Liu Ping Fan ha scritto: v5: fine rename some variable in patch24. fix commit log for patch12

Re: [Qemu-devel] [RFC PATCH v2 0/3] Fix UST backend for LTTng 2.x

2013-10-07 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Version 2 * Fix tracepoint generation error in first version. * Avoid warnings and errors specific to LTTng ust 2.0. * If using LTTng ust 2.0, we can't avoid getting warnings because of the --warn-common option given to the linker. This is fixed in more

[Qemu-devel] [Bug 1234179] Re: QEMU segfaults during Windows 7 unattended install

2013-10-07 Thread Lucas Meneghel Rodrigues
The problem showed up this morning again, same top commit: 10/07 01:34:42 INFO | git:0150| git commit ID is a684f3cf9b9b9c3cb82be87aafc463de8974610c (tag v1.4.0-4237-ga684f3c) This time around, debug symbols were enabled on the configure line: 10/07 01:35:31 DEBUG|build_help:0588|

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-07 Thread Fabien Chouteau
On 10/07/2013 01:45 PM, Peter Maydell wrote: On 7 October 2013 19:11, Fabien Chouteau chout...@adacore.com wrote: On 10/04/2013 07:49 PM, Peter Maydell wrote: On 5 October 2013 01:57, Fabien Chouteau chout...@adacore.com wrote: @@ -47,7 +48,9 @@ #include hw/xen/xen.h #include

Re: [Qemu-devel] [PATCH v9 00/27] qemu: generate acpi tables for the guest

2013-10-07 Thread Igor Mammedov
On Mon, 7 Oct 2013 12:34:46 +0300 Michael S. Tsirkin m...@redhat.com wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM

  1   2   >