On Mon, Oct 07, 2013 at 10:36:33AM +0300, Marcel Apfelbaum wrote:
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN
register during device initialization. Devices should not call
directly qemu_set_irq and specify the INTx pin.
Added pci_* wrappers to replace qemu_set_irq,
On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote:
Hi All,
I'm having this weird problem with qemu master + spice/qxl using
guests. As soon as the guest starts Xorg, I get the following message
from qemu:
main-loop: WARNING: I/O thread spun for 1000 iterations
And from then
On 07/22/2013 08:01 AM, mrhi...@linux.vnet.ibm.com wrote:
From: Michael R. Hines mrhi...@us.ibm.com
As described in the previous patch, until now, the MIG_STATE_SETUP
state was not really a 'formal' state. It has been used as a 'zero' state
(what we're calling 'NONE' here) and QEMU has been
Hey Hans,
On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote:
I'm having this weird problem with qemu master + spice/qxl using
guests. As soon as the guest starts Xorg, I get the following message
from qemu:
main-loop: WARNING: I/O thread spun for 1000 iterations
I've also seen
Il 22/09/2013 10:08, Paolo Bonzini ha scritto:
Il 21/09/2013 21:17, Michael S. Tsirkin ha scritto:
On Fri, Sep 20, 2013 at 04:57:49PM +0200, Paolo Bonzini wrote:
This series fixes hot-unplug of virtio devices, which can crash due to
dangling pointer accesses.
Could you please describe the
Hi,
Am 08.10.2013 11:07, schrieb Matej Mailing:
the strange thing is that all other keys and combinations work except
those ccaron, Ccaron, scaron and Scaron, zcaron and ZCaron don't.
As mentioned on IRC, my colleague had sent a patch to add ccaron, scaron
and zcaron support for VNC:
On 10/08/2013 05:51 PM, Andreas Färber wrote:
Hi,
Am 08.10.2013 11:07, schrieb Matej Mailing:
the strange thing is that all other keys and combinations work except
those ccaron, Ccaron, scaron and Scaron, zcaron and ZCaron don't.
As mentioned on IRC, my colleague had sent a patch to add
Il 08/10/2013 16:49, Eric Blake ha scritto:
You are now returning a state that older libvirt versions are not
expecting. Obviously, we can patch newer libvirt to make migration work
again, but should we be thinking about damage control by stating that an
older management app should still be
On Fri, Sep 27, 2013 at 12:50 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
If you want to continue with the original SIGSEGV handler approach,
check signals masks for the vcpu threads. Make sure the signal actually
gets delivered to a thread that has the signal unblocked and a signal
handler
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
This will help later when we will have to place these calls in
a critical section, and thus call a version of cpu_get_icount()
that does not take the lock.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-By: Alex Bligh
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
Computing the deadline of all vm_clocks is somewhat expensive and calls
out to qemu-timer.c; two reasons not to do it in the seqlock's write-side
critical section. This however opens the door for races in setting and
reading vm_clock_warp_start.
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
This fixes a deadlock in cpu_disable_ticks.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Alex Bligh a...@alex.org.uk
---
Should be squashed in Ping Fan's patches.
cpus.c | 21 +++--
1 file changed, 15
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Alex Bligh a...@alex.org.uk
---
cpus.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/cpus.c b/cpus.c
index 01acce2..bc675a4 100644
---
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
This lets threads other than the I/O thread use vm_clock even in -icount mode.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Looks good to me
Alex
---
cpus.c | 42 ++
1 file changed, 34
Il 08/10/2013 18:54, Alex Bligh ha scritto:
-
-/* Maintain prior (possibly buggy) behaviour where if no deadline
- * was set (as there is no QEMU_CLOCK_VIRTUAL timer) or it is more
than
- * INT32_MAX nanoseconds ahead, we still use INT32_MAX
- * nanoseconds.
- */
On 8 Oct 2013, at 09:47, Paolo Bonzini wrote:
To prepare for future code changes, move the increment of qemu_icount_bias
outside the if statement.
Also, hoist outside the if the check for timers that expired due to the
warping. The check is redundant when !runstate_is_running(), but
On 8 Oct 2013, at 10:25, Paolo Bonzini wrote:
Il 08/10/2013 11:15, Alex Bligh ha scritto:
So if we want to alter it ...
+if (ts-expire_time != -1) {
+timer_del_locked(timer_list, ts);
+}
What's this bit for? Surely you've calculated whether you are
shortening
Il 20/09/2013 16:57, Paolo Bonzini ha scritto:
This series fixes hot-unplug of virtio devices, which can crash due to
dangling pointer accesses.
The current implementation supports guest-initiated hot-unplug via the
virtio_bus_destroy_device function, but not hot-unplugging the virtio
On 8 Oct 2013, at 17:56, Paolo Bonzini wrote:
Arguably the patch could document why removing the check for deadline
INT32_MAX
(the bug for bug compatibility) is safe, as I couldn't entirely convince
myself it
was, mostly because I couldn't see why it was doing it in the first place.
I
Il 08/10/2013 19:08, Alex Bligh ha scritto:
On 8 Oct 2013, at 17:56, Paolo Bonzini wrote:
Arguably the patch could document why removing the check for deadline
INT32_MAX
(the bug for bug compatibility) is safe, as I couldn't entirely convince
myself it
was, mostly because I couldn't
From: Petar Jovanovic petar.jovano...@imgtec.com
Creating target_structs header in linux-user/$arch/ and making
target_ipc_perm and target_shmid_ds its first inhabitants.
The struct defintions may/should be further fine-tuned by arch maintainers.
Signed-off-by: Petar Jovanovic
On 10/08/2013 12:05 PM, Paolo Bonzini wrote:
Il 08/10/2013 16:49, Eric Blake ha scritto:
You are now returning a state that older libvirt versions are not
expecting. Obviously, we can patch newer libvirt to make migration work
again, but should we be thinking about damage control by stating
On 10/08/2013 11:32 AM, Michael R. Hines wrote:
In this case, in particular, I think a capability is a bit overkill.
Libvirt needs to be somewhat liberal in what it accepts; in this case it
can treat any unknown state as active.
Paolo
That makes sense to me too - the setup state is
From: Stefan Hajnoczi stefa...@redhat.com
qdev_device_add() leaks the created device upon failure. I suspect this
problem crept in because qdev_free() unparents the device but does not
drop a reference - confusing name.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Hajnoczi
From: Antony Pavlov antonynpav...@gmail.com
Use of SysBusDevice::init is deprecated. Use Device::realize instead.
Also introduce TypeInfo::instance_init milkymist_uart_init().
Reported-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
Signed-off-by: Antony Pavlov antonynpav...@gmail.com
From: Andreas Färber andreas.faer...@web.de
Prepares for QOM realize.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a9mpcore.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/cpu/a9mpcore.c
From: Andreas Färber andreas.faer...@web.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a9mpcore.c | 24 +---
include/hw/cpu/a9mpcore.h | 37 +
2 files changed,
Rename NCPU to GIC_NCPU and move GICState away from gic_internal.h.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/intc/arm_gic_common.c | 18
hw/intc/gic_internal.h | 80 +-
From: Andreas Färber andreas.faer...@web.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a9mpcore.c | 36 ++--
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/hw/cpu/a9mpcore.c
Public bug reported:
I have rhel6 inside qemu VM. qemu process starts to take CPU cycles and
OS inside VM is very slow and sluggish.
the qemu version is the latest upstream git.
the kernel version is 3.12.0.
linux-0rsg:/home/chenlidong # uname -a
Linux linux-0rsg 3.12.0-rc1-1.16-desktop+ #5
Reviewed-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/mips/mips_mipssim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c
index 242bab9..239aa6a 100644
---
From: Andreas Färber andreas.faer...@web.de
Prepares for QOM realize.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a15mpcore.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git
From: Andreas Färber andreas.faer...@web.de
Rename A9SCUState::busdev field to parent_obj and turn realizefn into an
instance_init function to allow early MMIO mapping.
Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by:
Inspired by a9scu.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
default-configs/arm-softmmu.mak | 1 +
hw/cpu/arm11mpcore.c| 65 ++
hw/misc/Makefile.objs | 1 +
hw/misc/arm11scu.c
From: Igor Mammedov imamm...@redhat.com
User is able to crash running QEMU when following monitor
command is called:
device_add intel-hda-generic
Crash is caused by assertion in object_initialize_with_type()
when type is abstract.
Checking if type is abstract before instance is created in
Reviewed-by: Edgar E. Iglesias edgar.igles...@gmail.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cris/axis_dev88.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c
index 03058d3..5524088 100644
---
Simply skip flash setup for now.
Also drop useless debug output.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/mainstone.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c
index b244f7e..9402c84 100644
---
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/misc/pxa2xx_pcmcia.c | 2 +-
include/hw/arm/pxa.h| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/pxa2xx_pcmcia.c b/hw/misc/pxa2xx_pcmcia.c
index ef71a2a..76724a6 100644
--- a/hw/misc/pxa2xx_pcmcia.c
+++
Replacing the assert() with more user-friendly error handling is left
for a follow-up.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/unicore32/puv3.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c
index a900061..e05cbc1 100644
---
Embed GICState and replace SysBus initfn with realizefn.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/intc/realview_gic.c | 51 ++
1 file changed, 35 insertions(+), 16 deletions(-)
diff
Adopt error_report() while at it.
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/block/tc58128.c | 10 ++
hw/sh4/shix.c | 9 +
2 files changed, 11 insertions(+), 8
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/gumstix.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
index e97fbbd..aeea172 100644
--- a/hw/arm/gumstix.c
+++ b/hw/arm/gumstix.c
@@ -42,6 +42,7 @@
#include
From: Andreas Färber andreas.faer...@web.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a15mpcore.c | 21 +
include/hw/cpu/a15mpcore.h | 44
2 files
From: Andreas Färber andreas.faer...@web.de
Turn SysBusDevice initfn into a QOM realizefn.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a15mpcore.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
For historic reasons, qdev_init() unparents the device on failure.
Inline this to make the error paths clearer and consistent.
Reviewed-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
qdev-monitor.c | 7 ++-
1 file changed, 6 insertions(+), 1
From: Andreas Färber andreas.faer...@web.de
Split the SysBusDevice initfn into instance_init and realizefn.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/timer/arm_mptimer.c | 25 +++--
1 file changed, 15
This allows to map the region directly after object initialization.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/arm11mpcore.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/cpu/arm11mpcore.c
Turn it into a SysBusDevice and use a container MemoryRegion.
Add a linkpcmcia-card property to the PCMCIACardState.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/pcmcia/pxa2xx.c | 78 +-
1 file changed, 66 insertions(+), 12
Move state struct, type constant and cast macro to a new header.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/arm11mpcore.c | 27 +--
include/hw/cpu/arm11mpcore.h | 35
mpcode - mpcore
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/arm11mpcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c
index a786c62..27cd32b 100644
---
Instantiate all [*] machines per target, so that they get a bit of test
coverage at all. This has proven helpful during QOM refactorings.
[*] ppcemb target contains some non-working non-embedded machines, and
ppc405 CPUs are not available there either.
i386 and x86_64 do not cover pc*-x.y or
Embed ARM11MPCorePriveState and RealViewGICState and replace SysBus
initfn with realizefn.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/arm11mpcore.c | 58 +++-
1 file changed, 44
Prepares for bringing error cleanup code into canonical QOM form.
Includes a whitespace removal after curly brace by Stefan.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
qdev-monitor.c | 32
From: Stefan Hajnoczi stefa...@redhat.com
The qdev_free() function name is misleading since all the function does
is unlink the device from its parent. The device is not necessarily
freed.
The device will be freed when its QObject refcount reaches zero. It is
usual for the parent (bus) to hold
Add missing braces.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ide/microdrive.c | 62 -
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c
index cdf0eb9..21d6495 100644
---
Adopt error_report().
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/armv7m.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 89a9015..397e8df 100644
--- a/hw/arm/armv7m.c
+++ b/hw/arm/armv7m.c
@@
Avoid confusion between object (obj) and object class (oc).
Tidy DeviceClass variable while at it (k - dc).
Signed-off-by: Andreas Färber afaer...@suse.de
---
qdev-monitor.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/qdev-monitor.c
From: Andreas Färber andreas.faer...@web.de
Prepares for QOM realize.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a9mpcore.c | 29 ++-
hw/timer/arm_mptimer.c | 35
On 10/08/2013 06:43 AM, Peter Lieven wrote:
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs-file.
Signed-off-by: Peter Lieven p...@kamp.de
---
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric
From: Andreas Färber andreas.faer...@web.de
Prepares for QOM realize.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a9mpcore.c | 16 ++--
hw/misc/a9scu.c | 18 +-
Hi,
On 10/08/2013 04:30 PM, Daniel P. Berrange wrote:
On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote:
Hi All,
I'm having this weird problem with qemu master + spice/qxl using
guests. As soon as the guest starts Xorg, I get the following message
from qemu:
main-loop: WARNING:
It does not have a target or ARMCPU dependency.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/misc/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
index
Il 08/10/2013 21:10, Hans de Goede ha scritto:
@@ -480,6 +480,11 @@ int main_loop_wait(int nonblocking)
timerlistgroup_deadline_ns(
main_loop_tlg));
+/* When not non-blocking always allow io-threads to
I noticed today that current qemu master would hang as soon as Xorg starts in
the guest when using qxl + a Linux guest. This message would be printed:
main-loop: WARNING: I/O thread spun for 1000 iterations
And from then on the guest hangs and qemu consumes 100% cpu, bisecting pointed
out commit
Hi,
On 10/08/2013 09:13 PM, Paolo Bonzini wrote:
Il 08/10/2013 21:10, Hans de Goede ha scritto:
@@ -480,6 +480,11 @@ int main_loop_wait(int nonblocking)
timerlistgroup_deadline_ns(
main_loop_tlg));
+/*
Move state struct, type constant and cast macro to a new header.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/intc/realview_gic.c | 15 +--
include/hw/intc/realview_gic.h | 28
2 files
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/z2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index a00fcc0..d52c501 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -24,6 +24,7 @@
#include ui/console.h
#include audio/audio.h
On 8 Oct 2013, at 20:21, Hans de Goede wrote:
Wasn't it 1 ms until the offending commit (note 250 us does
sound better to me).
I believe you've made it 1 nanosecond not 1 millisecond;
can that be right?
--
Alex Bligh
The following commit introduced a migration incompatibility:
commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe
Author: David Gibson da...@gibson.dropbear.id.au
Date: Thu Jun 6 18:48:49 2013 +1000
pci: Replace pci_find_domain() with more general pci_root_bus_path()
The issue is that i440fx
Hi,
On 09/24/2013 11:37 AM, Gerd Hoffmann wrote:
On Mo, 2013-09-23 at 20:54 +0200, Hans de Goede wrote:
Signed-off-by: Hans de Goede hdego...@redhat.com
Patch doesn't apply.
Sorry, my bad, I had some other changes in my local tree
which I was not yet ready to send and this depended on
From: Peter Maydell peter.mayd...@linaro.org
Now that arm_load_kernel() doesn't insist on a kernel filename
being present, we can remove some unnecessary conditionals
in board models.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
From: Andreas Färber andreas.faer...@web.de
This covers both emulated and KVM GIC.
Prepares for QOM realize.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
hw/cpu/a15mpcore.c | 39 ---
1 file
Hi,
On 10/08/2013 09:33 PM, Alex Bligh wrote:
On 8 Oct 2013, at 20:21, Hans de Goede wrote:
Wasn't it 1 ms until the offending commit (note 250 us does
sound better to me).
I believe you've made it 1 nanosecond not 1 millisecond;
Correct, the 1 ms I referred to was before your commit
All its users have finally been converted.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/ide/core.c | 49 -
hw/ide/internal.h | 2 --
2 files changed, 51 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 399b1ba..e1f4c33
On 8 Oct 2013, at 20:10, Hans de Goede wrote:
I noticed today that current qemu master would hang as soon as Xorg starts in
the guest when using qxl + a Linux guest. This message would be printed:
main-loop: WARNING: I/O thread spun for 1000 iterations
And from then on the guest hangs and
Embed child devices and replace SysBus initfn with realizefn.
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/arm11mpcore.c | 84 ++--
1 file changed, 56 insertions(+), 28 deletions(-)
Reviewed-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sh4/shix.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c
index 1ff37f5..f008b98 100644
--- a/hw/sh4/shix.c
+++ b/hw/sh4/shix.c
@@ -50,7 +50,6 @@ static
Acked-by: Michael Walle mich...@walle.cc
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/lm32/milkymist.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index f1744ec..15053c4 100644
--- a/hw/lm32/milkymist.c
+++
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/arm/omap_sx1.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c
index 03b3816..3ba263a 100644
--- a/hw/arm/omap_sx1.c
+++ b/hw/arm/omap_sx1.c
@@ -32,6 +32,7 @@
#include hw/arm/arm.h
From: Michael S. Tsirkin m...@redhat.com
Now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Tested-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by:
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/m68k/an5206.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c
index a8eee44..24f2068 100644
--- a/hw/m68k/an5206.c
+++ b/hw/m68k/an5206.c
@@ -12,6 +12,7 @@
#include hw/loader.h
#include elf.h
Since qemu's USB model is geared towards emulated devices cancellation
is instanteneous, so no need to wait for cancellation to complete, as
such there is no wait for cancellation code, and the cancelled bool
as well as the bogus comment about it can be removed.
Signed-off-by: Hans de Goede
Quoting from: linux/Documentation/ABI/stable/sysfs-bus-usb:
Note that some devices, in violation of the USB spec, have a
configuration with a value equal to 0. Writing 0 to
bConfigurationValue for these devices will install that
configuration, rather then
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/hcd-xhci.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 469c24d..e078c50 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -374,7 +374,6 @@ struct XHCIStreamContext {
As we should per the XHCI spec 4.6.9 Stop Endpoint.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/hcd-xhci.c | 26 ++
1 file changed, 18 insertions(+), 8 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 7cf89ce..0131151 100644
---
If we detach the kernel drivers on the first set_config, then they will
be still attached when the device gets its initial reset. Causing the drivers
to re-initialize the device after the reset, dirtying the device state.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/host-libusb.c
On 8 Oct 2013, at 20:41, Hans de Goede wrote:
Wasn't it 1 ms until the offending commit (note 250 us does
sound better to me).
I believe you've made it 1 nanosecond not 1 millisecond;
Correct, the 1 ms I referred to was before your commit which changed
things from ms to ns.
OK I was
Note this code is not as KISS as I would like, the reason for this is that
the Linux kernel interface wants streams on eps belonging to one interface
to be allocated in one call. Things will also work if we do this one ep at a
time (as long as all eps support the same amount of streams), but lets
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/host-libusb.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index 0dd60b2..894875b 100644
--- a/hw/usb/host-libusb.c
+++
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/host-libusb.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index 894875b..3376b96 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@
Quoting Mark Wu (2013-10-08 01:23:09)
In the original code, qmp_get_command_list is used to construct
a list of all commands' name. To get the information of all qga
commands, it traverses the name list and search the command info
with its name. So it can cause O(n^2) in the number of
On 8 Oct 2013, at 21:01, Alex Bligh wrote:
Somewhere within that patch series (7b595f35 I think) I fixed up
the spin counter bit, which made it slightly less yucky and work
with milliseconds.
with nanoseconds rather than microseconds - oops
--
Alex Bligh
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/sparc/leon3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 390f3e4..c583c3d 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -26,6 +26,7 @@
#include hw/ptimer.h
The guest will issue an initial device reset when the device is attached, but
since the current usb-host-libusb code only actually does the reset when
udev-configuration != 0, and on attach the device is not yet configured,
the reset gets ignored. This means that the device gets passed to the
Hi,
On 10/08/2013 10:01 PM, Alex Bligh wrote:
snip
The purpose of the 1 ns timeout is to cause os_host_main_loop_wait
to unlock the iothread, as $subject says the problem I'm seeing seems
to be lock starvation not cpu starvation.
Note as I already indicated I'm in no way an expert in this,
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/usb/bus.c | 18 ++
include/hw/usb.h | 12
2 files changed, 30 insertions(+)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 72d5b92..bba554c 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -203,6 +203,24 @@
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/cpu/Makefile.objs | 1 +
hw/cpu/arm11mpcore.c | 121 -
hw/cpu/realview_mpcore.c | 139 +++
3
Signed-off-by: Andreas Färber afaer...@suse.de
---
hw/m68k/mcf5208.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c
index fb96fe8..6e30c0b 100644
--- a/hw/m68k/mcf5208.c
+++ b/hw/m68k/mcf5208.c
@@ -10,6 +10,7 @@
#include qemu/timer.h
#include
From: Igor Mammedov imamm...@redhat.com
qapi/error.h is simple enough to be included in qom/object.h
directly and prepares qom/object.h to use Error typedef.
Signed-off-by: Igor Mammedov imamm...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Andreas Färber
Hi Gerd et al,
After quite a bit of work I'm very happy to present this patch set which adds
full support for using USB-3 devices which use bulkstreams with qemu's usb
host redirection.
This has been tested under a Linux guest, with an uas usb-3 device, and
works well and stable.
There is a
101 - 200 of 248 matches
Mail list logo
