[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-27 Thread Kirill A. Shutemov
From: Kirill A. Shutemov kir...@shutemov.name Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed

[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-27 Thread Kirill A. Shutemov
Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid st_gen with ENOTTY, we ignore

Re: [Qemu-devel] qemu 1.6.1

2013-10-27 Thread Paolo Bonzini
Il 26/10/2013 11:51, Stefan Weil ha scritto: Am 24.10.2013 23:47, schrieb Paolo Bonzini: Il 24/10/2013 17:37, Stefan Weil ha scritto: Yes, that works, too. It also fixes the problem with the assertion (tested with Wine). No, we cannot remove from_, because the same interface is also used

Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error

2013-10-27 Thread Amos Kong
On Sat, Oct 26, 2013 at 9:44 PM, Max Reitz mre...@redhat.com wrote: bdrv_open_backing_file() tries to copy the backing file name using pstrcpy directly after calling bdrv_open() to open the backing file without checking whether that was actually successful. If it was not, ps-backing_hd-file

Re: [Qemu-devel] qemu 1.6.1

2013-10-27 Thread Stefan Weil
Am 27.10.2013 07:54, schrieb Paolo Bonzini: Here is the code with annotations broken works - push %ebx sub$0x18,%espsub$0x1c,%esp

Re: [Qemu-devel] Fix SMB security configuration on newer samba versions

2013-10-27 Thread Amos Kong
On Mon, Oct 21, 2013 at 7:50 PM, Michael Büsch m...@bues.ch wrote: The following changes fix the samba security configuration on newer samba versions. samba version 4.0.10-Debian throws this warning: WARNING: Ignoring invalid value 'share' for parameter 'security' Which makes it fall

Re: [Qemu-devel] [PATCH v2] net: disallow to specify multicast MAC address

2013-10-27 Thread Amos Kong
On Mon, Oct 21, 2013 at 4:08 PM, Dmitry Krivenok krivenok.dmi...@gmail.com wrote: Changes to v1: 1) Resolved names clash in include/net/eth.h 2) Reused is_multicast_ether_addr() from that header for MAC check. Signed-off-by: Dmitry V. Krivenok krivenok.dmi...@gmail.com Reviewed-by: Amos Kong

Re: [Qemu-devel] Fix SMB security configuration on newer samba versions

2013-10-27 Thread Michael Büsch
On Sun, 27 Oct 2013 18:50:18 +0800 Amos Kong kongjian...@gmail.com wrote: Index: qemu-1.6.1/net/slirp.c === --- qemu-1.6.1.orig/net/slirp.c 2013-10-09 21:20:32.0 +0200 +++ qemu-1.6.1/net/slirp.c 2013-10-21

Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa-hpa on 1GB boundary

2013-10-27 Thread igor Mammedov
On Fri, 25 Oct 2013 11:34:22 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Oct 25, 2013 at 11:57:18AM +0200, igor Mammedov wrote: On Fri, 25 Oct 2013 02:58:05 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: On Fri, Oct 25, 2013 at 12:55:36AM +0100, Paolo Bonzini wrote:

[Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations

2013-10-27 Thread Charlie Shepherd
These patches were the first two from my GSoC series and were reasonably straight-forward and well accepted. Gabriel and I are hoping the patches from GSoC can be merged before I start my job in December, so I'm starting by sending the simple parts of the overall patchset, when they are merged

[Qemu-devel] [PATCH v3 1/2] Add an explanation of when a function should be marked coroutine_fn

2013-10-27 Thread Charlie Shepherd
Coroutine functions that can yield directly or indirectly should be annotated with a coroutine_fn annotation. Add an explanation to that effect in include/block/coroutine.h. --- include/block/coroutine.h | 8 1 file changed, 8 insertions(+) diff --git a/include/block/coroutine.h

[Qemu-devel] [PATCH v3 2/2] Rename qemu_coroutine_self to qemu_coroutine_self_int and add an annotated wrapper

2013-10-27 Thread Charlie Shepherd
While it only really makes sense to call qemu_coroutine_self() in a coroutine context, some coroutine internals need to call it from functions not annotated as coroutine_fn, so add an annotated wrapper and rename the implementation versions to qemu_coroutine_self_int. --- coroutine-gthread.c

Re: [Qemu-devel] qemu 1.6.1

2013-10-27 Thread Stefan Weil
Am 27.10.2013 07:54, schrieb Paolo Bonzini: I think the problem is that 0x20(%esp) gets somehow corrupted at the instruction I highlighted with **. The simplest fix then would be to add a barrier() before and after SwitchToFiber. Paolo I added some debugging output (see code at

Re: [Qemu-devel] [PATCH v7] powerpc: add PVR mask support

2013-10-27 Thread Alexander Graf
On 23.10.2013, at 07:57, Andreas Färber afaer...@suse.de wrote: Am 27.09.2013 09:05, schrieb Alexey Kardashevskiy: IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there

Re: [Qemu-devel] [PATCH] spapr: add vio-bus devices to categories

2013-10-27 Thread Alexander Graf
On 10.10.2013, at 20:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: In order to get devices appear in output of ./qemu-system-ppc64 -device ?, they must be assigned to one of DEVICE_CATEGORY_. This puts VIO devices classes to corresponding categories. Signed-off-by: Alexey

Re: [Qemu-devel] [RFC PATCH] spapr: add ibmveth to the supported network adapters list

2013-10-27 Thread Alexander Graf
On 10.10.2013, at 20:09, Alexey Kardashevskiy a...@ozlabs.ru wrote: The problem is that -net nic,model=? does not print ibmveth in the list while it is actually supported. Most of the QEMU emulated network devices are PCI but ibmveth (a.k.a. spapr-vlan) is not. However with -net

Re: [Qemu-devel] [PATCH -V6 2/3] target-ppc: Fix page table lookup with kvm enabled

2013-10-27 Thread Alexander Graf
On 15.10.2013, at 01:58, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error

Re: [Qemu-devel] [PATCH -V6 3/3] target-ppc: Fix htab_mask calculation

2013-10-27 Thread Alexander Graf
On 15.10.2013, at 01:58, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Correctly update the htab_mask using the return value of KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 on GET_SREGS for HV. So don't update

Re: [Qemu-devel] [PATCH -V5] target-ppc: Fix page table lookup with kvm enabled

2013-10-27 Thread Alexander Graf
On 11.10.2013, at 09:58, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Alexander Graf ag...@suse.de writes: On 11.10.2013, at 13:13, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store

Re: [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations

2013-10-27 Thread Gabriel Kerneis
On Sun, Oct 27, 2013 at 04:23:54PM +0100, Charlie Shepherd wrote: These patches were the first two from my GSoC series and were reasonably straight-forward and well accepted. Gabriel and I are hoping the patches from GSoC can be merged before I start my job in December, so I'm starting by

Re: [Qemu-devel] [PATCH v3 0/2] Documentation for coroutine annotations

2013-10-27 Thread Charlie Shepherd
On 27/10/2013 20:37, Gabriel Kerneis wrote: On Sun, Oct 27, 2013 at 04:23:54PM +0100, Charlie Shepherd wrote: These patches were the first two from my GSoC series and were reasonably straight-forward and well accepted. Gabriel and I are hoping the patches from GSoC can be merged before I start

[Qemu-devel] [PATCH v4 1/4] Add an explanation of when a function should be marked coroutine_fn

2013-10-27 Thread Charlie Shepherd
Coroutine functions that can yield directly or indirectly should be annotated with a coroutine_fn annotation. Add an explanation to that effect in include/block/coroutine.h. Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- include/block/coroutine.h | 8 1 file changed, 8

[Qemu-devel] [PATCH v4 2/4] Rename qemu_coroutine_self to qemu_coroutine_self_int and add an annotated wrapper

2013-10-27 Thread Charlie Shepherd
While it only really makes sense to call qemu_coroutine_self() in a coroutine context, some coroutine internals need to call it from functions not annotated as coroutine_fn, so add an annotated wrapper and rename the implementation versions to qemu_coroutine_self_int. Signed-off-by: Charlie

[Qemu-devel] [PATCH v4 3/4] Introduce blocking_fn annotation

2013-10-27 Thread Charlie Shepherd
From: Gabriel Kerneis gabr...@kerneis.info A blocking function is a function that must not be called in coroutine context, for example because it might block for a long amount of time. This annotation should be used to mark normal functions that have a coroutine_fn counterpart, to make sure that

[Qemu-devel] [PATCH v4 0/4] Documentation for coroutine annotations

2013-10-27 Thread Charlie Shepherd
These patches were the first two from my GSoC series and were reasonably straight-forward and well accepted. Gabriel and I are hoping the patches from GSoC can be merged before I start my job in December, so I'm starting by sending the simple parts of the overall patchset, when they are merged

[Qemu-devel] [PATCH v4 4/4] Protect coroutine_fn and blocking_fn with #ifndef

2013-10-27 Thread Charlie Shepherd
From: Gabriel Kerneis gabr...@kerneis.info This patch allows defining coroutine and blocking annotations with ./configure --extra-cflags instead of modifying coroutine.h. Signed-off-by: Gabriel Kerneis gabr...@kerneis.info --- include/block/coroutine.h | 4 1 file changed, 4 insertions(+)

[Qemu-devel] [PATCH for 1.7] exec: fix breakpoint_invalidate when pc may not be translated

2013-10-27 Thread Max Filippov
This fixes qemu abort with the following message: include/qemu/int128.h:22: int128_get64: Assertion `!a.hi' failed. which happens due to attempt to invalidate breakpoint by virtual address for which get_phys_page_debug couldn't find mapping. For more details see

[Qemu-devel] [PATCH 0/2] make slirp drivern by glib directly

2013-10-27 Thread Liu Ping Fan
This series make slirp drivern directly by glib, so we can clean up the hooks for slrip in mainloop and stub Liu Ping Fan (2): slirp: introduce gsource event abstraction slirp: make slirp event dispatch based on slirp instance main-loop.c | 6 --- net/slirp.c | 3

[Qemu-devel] [PATCH 1/2] slirp: introduce gsource event abstraction

2013-10-27 Thread Liu Ping Fan
Introduce struct SlirpGSource. It will ease the usage of GSource associated with a group of files, which are dynamically allocated and release for slirp. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- slirp/Makefile.objs | 2 +- slirp/slirp_gsource.c | 94

[Qemu-devel] [PATCH 2/2] slirp: make slirp event dispatch based on slirp instance

2013-10-27 Thread Liu Ping Fan
Each slirp instance has its own GFuncs, so we can driver slirp by glib main loop. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- For easing the review, This patch does not obey coding guide. Will fix it later --- main-loop.c | 6 --- net/slirp.c | 3 ++

Re: [Qemu-devel] [PATCH_v2 0/9] target-openrisc: Corrections and speed improvements

2013-10-27 Thread Sebastian Macke
On 25/10/2013 5:21 PM, Jia Liu wrote: On Fri, Oct 25, 2013 at 7:23 AM, Sebastian Macke sebast...@macke.de wrote: On 22/10/2013 8:47 PM, Jia Liu wrote: Hi Sebastian, On Tue, Oct 22, 2013 at 8:12 AM, Sebastian Macke sebast...@macke.de wrote: This series is the first part to make the OpenRISC

[Qemu-devel] About the migration_set_speed in the qemu monitor

2013-10-27 Thread Yaodong Yang
Hi all, When we migrate a vm from one host to another, we set the migrate_set_speed 200 inside the qemu monitor. What does the 200 means? Is it the maximum migration speed is 200MB/s or something else? Thanks!