Set NOCOW flag to newly created images to solve performance issues on btrfs.
Btrfs has terrible performance when hosting VM images, even more when the guest
in those VM are also using btrfs as file system. One way to mitigate this bad
performance is to turn off COW attributes on VM files (since
Public bug reported:
Environment:
Host OS (ia32/ia32e/IA64):ia32e
Guest OS (ia32/ia32e/IA64):ia32e
Guest OS Type (Linux/Windows):Linux
kvm.git Commit:81e87e26796782e014fd1f2bb9cd8fb6ce4021a8
qemu.git Commit:a126050a103c924b03388a9a64ce9af8c96b0969
Host Kernel Version:3.12.0-rc5
the first bad commit is:
commit 72c194f7e75cb64b2558111cb111adb49fbf4097
Author: Michael S. Tsirkin m...@redhat.com
Date: Wed Jul 24 18:56:14 2013 +0300
i386: ACPI table generation code from seabios
This adds C code for generating ACPI tables at runtime,
imported from seabios git
Avoid a bogus COMPLETED-CANCELLED transition.
There is a period of time from the timing of setting COMPLETED state to that of
migration thread exits, so during which it's problematic in
COMPLETED-CANCELLED transition.
Signed-off-by: Zeng Junliang zengjunli...@huawei.com
Signed-off-by: Zhang
On Thu, 7 Nov 2013 14:50:00 +1100
Alexey Kardashevskiy a...@ozlabs.ru wrote:
The SPAPR specification says that the RMA starts at the LPAR's logical
address 0 and is the first logical memory block reported in
the LPAR’s device tree.
So SLOF only maps the first block and that block needs to
Hi,
if boot an Ubuntu 12.04.3 live CD I get graphic errors once the GUI has started.
I do not know if this is an Ubuntu problem or a general emulation problem. With
12.04.2 live CD it
works. Main difference is the kernel change from 3.5 to 3.8.
Is this anything that has been seen before?
05.11.2013 19:26, Jan Krupa wrote:
On 11/01/2013 11:00 AM, Michael Tokarev wrote:
[]
Except of one question. Where we add these entries? Should we maybe
sort the table somehow, or introduce some more groups of chars?
(I'm fine with applying this to qemu-trivial as-is).
I agree with
On 07.11.2013 03:25, Wenchao Xia wrote:
于 2013/11/7 2:50, Max Reitz 写道:
It should be possible to execute the QMP drive-mirror command in
none sync mode and absolute-paths mode even for block devices
lacking a backing file.
absolute-paths does in fact not require a backing file to be present,
On 11/06/2013 12:53 AM, Andreas Färber wrote: Am 05.11.2013 10:52, schrieb
Paolo Bonzini:
Il 05/11/2013 10:16, Alexander Graf ha scritto:
On 05.11.2013, at 10:06, Paolo Bonzini pbonz...@redhat.com wrote:
Il 30/09/2013 14:57, Alexey Kardashevskiy ha scritto:
Why is the option under -machine
On Tue, Oct 29, 2013 at 8:51 AM, Anand Avati av...@gluster.org wrote:
Looks like what is happening is that qemu performs ioctls() on the backend
to query logical_block_size (for direct IO alignment). That works on XFS,
but fails on FUSE (hence qemu ends up performing IO with default 512
On 11/06/2013 03:04 PM, Juan Quintela wrote:
As the comment says, it should only be used on core memory files.
Signed-off-by: Juan Quintela quint...@redhat.com
---
include/exec/cpu-common.h | 4
include/exec/memory.h | 4 +++-
2 files changed, 3 insertions(+), 5 deletions(-)
diff
On 11/06/2013 03:04 PM, Juan Quintela wrote:
So return void.
Signed-off-by: Juan Quintela quint...@redhat.com
---
include/exec/memory-internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index
On 11/06/2013 03:04 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/memory.c b/memory.c
index 28f6449..9722f23 100644
--- a/memory.c
+++ b/memory.c
@@ -1182,7 +1182,7 @@ void
Il 06/11/2013 19:50, Max Reitz ha scritto:
Add a new test case in file 041 for mirroring unbacked images in
absolute-paths mode. This should work, if possible, but most
importantly, qemu should never crash.
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/041 | 25
Il 06/11/2013 19:23, Max Filippov ha scritto:
On Mon, Oct 28, 2013 at 4:43 AM, Max Filippov jcmvb...@gmail.com wrote:
This fixes qemu abort with the following message:
include/qemu/int128.h:22: int128_get64: Assertion `!a.hi' failed.
which happens due to attempt to invalidate breakpoint
Il 07/11/2013 09:21, Zhanghaoyu (A) ha scritto:
Avoid a bogus COMPLETED-CANCELLED transition.
There is a period of time from the timing of setting COMPLETED state to that
of migration thread exits, so during which it's problematic in
COMPLETED-CANCELLED transition.
Signed-off-by: Zeng
On 11/06/2013 03:04 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 79610ce..7cf5634 100644
--- a/exec.c
+++ b/exec.c
@@ -1397,7 +1397,7 @@ static void
On 07.11.2013, at 09:33, Thomas Huth th...@linux.vnet.ibm.com wrote:
On Thu, 7 Nov 2013 14:50:00 +1100
Alexey Kardashevskiy a...@ozlabs.ru wrote:
The SPAPR specification says that the RMA starts at the LPAR's logical
address 0 and is the first logical memory block reported in
the LPAR’s
On Thu, Nov 07, 2013 at 03:32:29PM +0800, Amos Kong wrote:
On Thu, Nov 07, 2013 at 08:59:22AM +0200, Michael S. Tsirkin wrote:
On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote:
We currently just update the HMP NIC info when the last bit of macaddr
is written. This assumes that
A bug reported by Luiz Capitulino let us to find
several bugs in memory address space setup.
One issue is that gdb stub can give us arbitrary addresses
and we'll try to access them.
Since our lookup ignored high bits in the address,
we hit a wrong section and got a crash.
In fact, PCI devices can
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Use TARGET_PHYS_ADDR_SPACE_MAX as max size for memory regions
rendered by exec.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
include/exec/address-spaces.h | 4
1 file changed, 4
From: Michael S. Tsirkin m...@redhat.com
Lookup of address target address space should
return an unassigned section, instead of silently
ignoring high bits.
Reported-by: Luiz Capitulino lcapitul...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Marcel Apfelbaum
From: Michael S. Tsirkin m...@redhat.com
It doesn't make sense for a region to be INT64_MAX in size:
memory core uses UINT64_MAX as a special value meaning
all 64 bit this is what was meant here.
While this should never affect the spapr system which at the moment always
has 63 bit size, this
From: Paolo Bonzini pbonz...@redhat.com
It doesn't make sense for a region to be INT64_MAX in size:
memory core uses UINT64_MAX as a special value meaning
all 64 bit this is what was meant here.
While this should never affect the PC system which at the moment always
has 63 bit size, this makes
From: Michael S. Tsirkin m...@redhat.com
Address space size for bridge should be full 64 bit,
so we should use UINT64_MAX not INT64_MAX as it's size.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/pci/pci_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Michael S. Tsirkin m...@redhat.com
We should never add pages outside target address space,
we had such bugs in the past so add debug message to catch
that quickly if we do, otherwise at least don't corrupt
the page tables.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by:
On 7 November 2013 10:41, Marcel Apfelbaum marce...@redhat.com wrote:
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Use TARGET_PHYS_ADDR_SPACE_MAX as max size for memory regions
rendered by exec.
Signed-off-by: Marcel Apfelbaum
On 11/06/2013 08:10 PM, Paolo Bonzini wrote:
Il 31/10/2013 03:18, Fam Zheng ha scritto:
This patch suspends the test image IO before starting block stream job
so that it doesn't complete before we could check the status.
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/030
On Wed, Nov 06, 2013 at 11:52:12PM +0800, Zhi Yong Wu wrote:
Since i did a lot of work to make this feature get merged,
and hope to gain some excercises about how to become a good
maintainer, i'm applying for this role now and hope to get
this chance, thanks.
Sorry, I don't feel that it makes
r...@twiddle.net writes:
All references to cpu_T are done with a constant index. It aids
readability to decompose the array into two scalar variables.
snip
I'm not necessarily disagreeing with the readability argument but does
this make any difference to the eventual code generated?
--
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Limit iommu-typhoon accordingly.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
hw/alpha/typhoon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/alpha/typhoon.c
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Limit iommu-spapr accordingly.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
hw/ppc/spapr_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Introduce MIG_STATE_CANCELLING state to avoid starting a new migration task
while the previous one still exist.
Signed-off-by: Zeng Junliang zengjunli...@huawei.com
Signed-off-by: Zhang Haoyu haoyu.zh...@huawei.com
---
migration.c | 26 --
1 files changed, 16
On 07.11.2013, at 11:41, Marcel Apfelbaum marce...@redhat.com wrote:
A bug reported by Luiz Capitulino let us to find
several bugs in memory address space setup.
One issue is that gdb stub can give us arbitrary addresses
and we'll try to access them.
Since our lookup ignored high bits in
On Mon, Nov 04, 2013 at 02:42:55PM +0100, Jan Kiszka wrote:
This feature was already deprecated back then in qemu-kvm, ie. before
pci-assign went upstream. assigned_dev_ioport_rw will never be invoked
with resource_fd 0.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Applied, thanks.
On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote:
This error was reported by valgrind when running qemu-system-x86_64
with kvm:
==975== Conditional jump or move depends on uninitialised value(s)
==975==at 0x521C38: cpuid_find_entry (kvm.c:176)
==975==by 0x5235BA:
Il 07/11/2013 12:01, Zhanghaoyu (A) ha scritto:
Introduce MIG_STATE_CANCELLING state to avoid starting a new migration task
while the previous one still exist.
Signed-off-by: Zeng Junliang zengjunli...@huawei.com
Signed-off-by: Zhang Haoyu haoyu.zh...@huawei.com
---
migration.c | 26
Hi,
Yep, needed to figure updated screen areas. It never stops completely,
but the refresh rate should be alot lower with no vnc client connected,
something like once every few seconds without client vs. 30x per second
with client.
When the guest is stopped you really need to ask
On 11/06/2013 08:10 PM, Paolo Bonzini wrote:
Il 31/10/2013 03:18, Fam Zheng ha scritto:
This patch suspends the test image IO before starting block stream job
so that it doesn't complete before we could check the status.
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/030
Hi,
Revert broken ossaudio patch, fix oss init for real.
please pull,
Gerd
The following changes since commit c2d30667760e3d7b81290d801e567d4f758825ca:
rtc: remove dead SQW IRQ code (2013-11-05 20:04:03 -0800)
are available in the git repository at:
git://git.kraxel.org/qemu audio.3
Il 07/11/2013 12:25, Fam Zheng ha scritto:
Mirror doesn't complete automatically, so we don't need the sequence:
1) Pause IO on device.
2) Start job.
3) Send block job cancel/complete command to wire.
4) Resume IO.
Block stream/commit/backup need because without step 1) the job could
Check whenever the device path (/dev/dsp by default) exists and qemu is
allowed to access it. Return NULL if it isn't, so ossaudio will not
be used on systems wihtout oss support (increasinly common on modern
linux systems).
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
audio/ossaudio.c |
This reverts commit c905c5012ac0c6fde3b8094d2206a3139deddba2.
There is a better fix for the issue at hand.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
audio/ossaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index
Hi,
And that is actually simple enough that we can consider it for 1.7:
static void *oss_audio_init (void)
{
+if (access(conf.devpath_in, R_OK | W_OK) 0 ||
+access(conf.devpath_out, R_OK | W_OK) 0) {
+return NULL;
That would be reasonable. Can you add a
On Thu, 2013-11-07 at 10:49 +, Peter Maydell wrote:
On 7 November 2013 10:41, Marcel Apfelbaum marce...@redhat.com wrote:
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Use TARGET_PHYS_ADDR_SPACE_MAX as max size for memory regions
On 11/06/2013 03:04 PM, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
cputlb.c | 2 +-
include/exec/memory-internal.h | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/cputlb.c b/cputlb.c
index fff0afb..72452e5 100644
On Thu, Nov 07, 2013 at 10:49:50AM +, Peter Maydell wrote:
On 7 November 2013 10:41, Marcel Apfelbaum marce...@redhat.com wrote:
The page table logic in exec.c assumes
that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS.
Use TARGET_PHYS_ADDR_SPACE_MAX as max size for memory
On Thu, Nov 07, 2013 at 08:14:28AM -, chao zhou wrote:
the first bad commit is:
commit 72c194f7e75cb64b2558111cb111adb49fbf4097
Author: Michael S. Tsirkin m...@redhat.com
Date: Wed Jul 24 18:56:14 2013 +0300
i386: ACPI table generation code from seabios
This adds C code for
Le Thursday 07 Nov 2013 à 15:34:52 (+0800), Fam Zheng a écrit :
If backing file doesn't exist, the error message is confusing and
misleading:
$ qemu /tmp/a.qcow2
qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
such file or directory
But...
$ ls
QEMU will currently crash if started with -no-acpi flag
since acpi build code probes the PM device which isn't present
in this configuration.
To fix, don't expose ACPI tables to guest when acpi has been
disabled from command line.
Fixes LP# 1248854
https://bugs.launchpad.net/qemu/+bug/1248854
This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM
value is derived from the passed in guest info, same way as CPU SRAT entries.
The motivation for this patch is a CPU hot-unplug/hot-plug bug observed when
using a 3.11 linux guest kernel on a multi-NUMA node qemu/kvm
On Thu, Nov 07, 2013 at 01:41:59PM +0100, Vasilis Liaskovitis wrote:
This patch adds a _PXM method to ACPI CPU objects for the pc machine. The _PXM
value is derived from the passed in guest info, same way as CPU SRAT entries.
The motivation for this patch is a CPU hot-unplug/hot-plug bug
On Do, 2013-11-07 at 09:44 +1000, Dave Airlie wrote:
On Wed, Nov 6, 2013 at 8:57 PM, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
It currently just adds multiple DisplaySurfaces to the QemuConsole,
now Gerd said he thought I should be using multiple QemuConsoles but I
really didn't
On Do, 2013-11-07 at 14:18 +0200, Michael S. Tsirkin wrote:
+if (!acpi_enabled) {
+ACPI_BUILD_DPRINTF(3, ACPI disabled. Bailing out.\n);
+return;
+}
Reviewed-by: Gerd Hoffmann kra...@redhat.com
cheers,
Gerd
From: Jeff Cody jc...@redhat.com
Regions in the image file cannot overlap - the log, region tables,
and metdata must all be unique and non-overlapping.
This adds region checking by means of a QLIST; there can be a variable
number of regions and metadata (there may be metadata or region tables
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
qapi-schema.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index
From: Jeff Cody jc...@redhat.com
This adds support for VHDX image creation, for images of type Fixed
and Dynamic. Differencing types (i.e., VHDX images with backing
files) are currently not supported.
Options for image creation include:
* log size:
The size of the journaling log for
From: Jeff Cody jc...@redhat.com
This adds support for VHDX v0 logs, as specified in Microsoft's
VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
The following support is added:
* Log parsing, and validation - validate that an existing log
is
From: Jeff Cody jc...@redhat.com
Bit shifting can be fun, but in this case it was unnecessary. The
upper 44 bits of the 64-bit BAT entry is specifies the File Offset,
so we shifted the bits to get access to the value.
However, per the spec the value is in MB. So we dutifully shifted back
to
On Thu, Nov 07, 2013 at 02:03:00PM +0100, Gerd Hoffmann wrote:
On Do, 2013-11-07 at 14:18 +0200, Michael S. Tsirkin wrote:
+if (!acpi_enabled) {
+ACPI_BUILD_DPRINTF(3, ACPI disabled. Bailing out.\n);
+return;
+}
Reviewed-by: Gerd Hoffmann kra...@redhat.com
From: Jeff Cody jc...@redhat.com
_make_test_img() currently works with spaced pathnames only when not
specifying a backing file. This fixes it so that the backing file
argument is properly quoted.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by:
From: Jeff Cody jc...@redhat.com
This adds support for writing to the VHDX log.
For spec details, see VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
There are a few limitations to this log support:
1.) There is no caching yet
2.) The log is
All bug fixes with one exception: Jeff Cody's VHDX write support. The patches
have been on the list and reviewed for a long time. They are self-contained
and do not touch anything outside VHDX. They missed the soft freeze only
because KVM Forum, so I feel they can be added at no risk.
The
From: Jeff Cody jc...@redhat.com
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
From: Jeff Cody jc...@redhat.com
This tests the replay of a data sector in a VHDX image file.
The image file is a 10G dynamic image, with 4MB block size. The
image was created with qemu-img, and the log left unplayed by
modification of the vhdx image format driver.
It was verified under both
From: Jeff Cody jc...@redhat.com
This adds the ability to update the headers in a VHDX image, including
generating a new MS-compatible GUID.
As VHDX depends on uuid.h, VHDX is now a configurable build option. If
VHDX support is enabled, that will also enable uuid as well. The
default is to
From: Jeff Cody jc...@redhat.com
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by:
From: Max Reitz mre...@redhat.com
The actual size of the image file may differ depending on the Linux
kernel currently running on the host. Filtering out this value makes
this test pass in such cases.
Signed-off-by: Max Reitz mre...@redhat.com
Reviewed-by: Benoit Canet ben...@irqsave.net
From: Jeff Cody jc...@redhat.com
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their
MSGUID fields set as arrays of 16. This is incorrect (it stems from
an early version where those fields were uint_8 arrays). Those fields
were, up to this patch, unused.
Also, there were a
From: Jeff Cody jc...@redhat.com
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
tests/qemu-iotests/common.pattern | 12
From: Jeff Cody jc...@redhat.com
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7
On Thu, 7 Nov 2013 20:11:51 +1100
Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 11/06/2013 12:53 AM, Andreas Färber wrote: Am 05.11.2013 10:52, schrieb
Paolo Bonzini:
Il 05/11/2013 10:16, Alexander Graf ha scritto:
On 05.11.2013, at 10:06, Paolo Bonzini pbonz...@redhat.com wrote:
Il
From: Jeff Cody jc...@redhat.com
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with
spaces are supported.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
tests/qemu-iotests/017 | 2 +-
1
From: Peter Lieven p...@kamp.de
Signed-off-by: Peter Lieven p...@kamp.de
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vpc.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index 627d11c..577cc45 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@
From: Jeff Cody jc...@redhat.com
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vhdx.c
From: Jeff Cody jc...@redhat.com
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody
From: Jeff Cody jc...@redhat.com
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail
on pathnames with spaces in them.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by:
These memory leaks also make drive_add if=none,id=drive0 without a file=
option leak the options list. This keeps ID drive0 around forever.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
blockdev.c | 27 +++
1 file
Hi,
As far as the EDID is concerned, there can only be one EDID for a
display+hw pair, or the guest won't know what to do. In my use-case, I
simply pass real EDIDs through, and create a full-screen window for each
real monitor.
Ok, makes sense.
If you wanted to have two UIs displaying
Il 07/11/2013 13:04, Michael S. Tsirkin ha scritto:
(it follows from this that using the #define anywhere
except in a memory_region_init() call is probably a bug)
-- PMM
BTW how about we change the API to pass in int128?
The vast majority of memory regions have small sizes, it would
From: Jeff Cody jc...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
Am 07.11.2013 10:11, schrieb Alexey Kardashevskiy:
On 11/06/2013 12:53 AM, Andreas Färber wrote: Am 05.11.2013 10:52, schrieb
Paolo Bonzini:
Il 05/11/2013 10:16, Alexander Graf ha scritto:
On 05.11.2013, at 10:06, Paolo Bonzini pbonz...@redhat.com wrote:
Il 30/09/2013 14:57, Alexey
From: Max Reitz mre...@redhat.com
error_setg_errno() may overwrite errno; therefore, its value should be
read before calling that function and not afterwards.
Signed-off-by: Max Reitz mre...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Reviewed-by: Benoit Canet ben...@irqsave.net
Ensure that the device_add error code path deletes device objects.
Failure to do so not only leaks the objects but can also keep other
objects (like drive or netdev) alive due to qdev properties holding
references.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake
From: Andreas Tobler andre...@freebsd.org
The below patch is needed to compile qemu trunk on FreeBSD with gcc48,
clang will fail ;). Host x84_64-freebsd.
Signed-off-by: Andreas Tobler andre...@freebsd.org
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/raw-posix.c | 3 ++-
1
Il 07/11/2013 11:41, Marcel Apfelbaum ha scritto:
A bug reported by Luiz Capitulino let us to find
several bugs in memory address space setup.
One issue is that gdb stub can give us arbitrary addresses
and we'll try to access them.
Since our lookup ignored high bits in the address,
we hit
Alexander Graf ag...@suse.de writes:
On 15.10.2013, at 01:58, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
wrote:
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Correctly update the htab_mask using the return value of
KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1
on
From: Jeff Cody jc...@redhat.com
There were still instances of $TEST_IMG not being properly quoted.
This was in the usage of a string built up for a 'for' loop; modify
the loop so we can quote $TEST_IMG properly.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
From: Jeff Cody jc...@redhat.com
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vhdx-endian.c | 75
From: Jeff Cody jc...@redhat.com
When creating images with backing files in the test, the backing
file argument was not quoted properly. This caused the test to fail
when run from a pathname with a space. Pass the backing argument in
with the -b option to _make_test_img, so it can be properly
From: Jeff Cody jc...@redhat.com
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
Signed-off-by: Jeff Cody jc...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1
Existing qmp() callers do not expect a response object. In order to
implement real QMP test cases it will be necessary to inspect the
response object.
Rename qmp() to qmp_discard_response(). Later patches will introduce a
qmp() function that returns the response object and tests that use it.
From: Jeff Cody jc...@redhat.com
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody
On 11/07/2013 12:34 AM, Fam Zheng wrote:
If backing file doesn't exist, the error message is confusing and
misleading:
This is not intuitive. It's better to have the missing file's name in
the error message. With this patch:
$ qemu-io -c 'read 0 512' /tmp/a.qcow2
qemu-io:
From: Jeff Cody jc...@redhat.com
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/vhdx.c | 52
block/vhdx.h | 48
Add a qtest qmp() function that returns the response object. This
allows test cases to verify the result or to check for error responses.
It also allows waiting for QMP events.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Reviewed-by: Andreas
From: Jeff Cody jc...@redhat.com
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody jc...@redhat.com
The following should work:
(qemu) drive_add if=none,id=drive0
(qemu) drive_del drive0
(qemu) drive_add if=none,id=drive0
Previous versions of QEMU produced a duplicate ID error because
drive_add leaked the options.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Eric Blake
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Targets like ppc64 support different typed of KVM, one which use
hypervisor mode and the other which doesn't. Add a new machine
property kvm_type that helps in selecting the respective ones
We also add a new QEMUMachine callback get_vm_type
From: Jeff Cody jc...@redhat.com
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write
1 - 100 of 193 matches
Mail list logo
