[Qemu-devel] [PATCH v3 3/4] hw/arm: add sunxi machine type

2013-11-25 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |1 + hw/arm/sunxi-soc.c | 113 ++ 2 files changed, 114 insertions(+), 0 deletions(-) create mode 100644 hw/arm/sunxi-soc.c diff --git a/hw/arm/Makefile.objs

[Qemu-devel] [PATCH v3 4/4] MAINTAINERS: add myself to maintain sunxi machine

2013-11-25 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77edacf..232e1a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -284,6 +284,15 @@ M: Peter Maydell

[Qemu-devel] [PATCH v3 0/4] add sunxi machine type

2013-11-25 Thread liguang
this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... now, It can support sunxi-4i with a cortex-a8 processor. and will support more later, like sunxi-7i with cortex-a7, and will add more devices. v2: split timer and interrupt

[Qemu-devel] [PATCH v3 1/4] hw/timer: add sunxi timer device

2013-11-25 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 260 +++ include/hw/timer/sunxi-pit.h| 26 4 files changed, 289 insertions(+), 0

[Qemu-devel] [PATCH v3 2/4] hw/intc: add sunxi interrupt controller device

2013-11-25 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 301 +++ include/hw/intc/sunxi-pic.h | 27 4 files changed, 330 insertions(+), 0

[Qemu-devel] [PATCH] char: restore read callback on a reattached (hotplug) chardev

2013-11-25 Thread Gal Hammer
Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transfter from the host to the guest via the virtio-serial port.

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-25 Thread Chunyan Liu
ping 2013/11/21 Stefan Hajnoczi stefa...@gmail.com On Thu, Nov 21, 2013 at 11:33:56AM +0800, Chunyan Liu wrote: 2013/11/20 Stefan Hajnoczi stefa...@gmail.com On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: block/cow.c | 22 ++

[Qemu-devel] [RFC][PATCH 1.8] block/iscsi: set bdi-cluster_size

2013-11-25 Thread Peter Lieven
this patch aims to set bdi-cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index

Re: [Qemu-devel] [RFC][PATCH 1.8] block/iscsi: set bdi-cluster_size

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 09:29, Peter Lieven ha scritto: this patch aims to set bdi-cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6 ++ 1 file changed, 6

Re: [Qemu-devel] [RFC][PATCH 1.8] block/iscsi: set bdi-cluster_size

2013-11-25 Thread Peter Lieven
On 25.11.2013 09:54, Paolo Bonzini wrote: Il 25/11/2013 09:29, Peter Lieven ha scritto: this patch aims to set bdi-cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |6

Re: [Qemu-devel] [PATCH v3 01/19] block: generalize BlockLimits handling to cover bdrv_aio_discard too

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: bdrv_co_discard is only covering drivers which have a .bdrv_co_discard() implementation, but not those with .bdrv_aio_discard(). Not very nice, and easy to avoid. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PATCH v3 02/19] block: add flags to BlockRequest

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: This lets bdrv_co_do_rw receive flags, so that it can be used for zero writes. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 17 +++-- include/block/block.h | 1 + 2 files changed, 12 insertions(+), 6

Re: [Qemu-devel] [PATCH v3 03/19] block: add flags argument to bdrv_co_write_zeroes tracepoint

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 2 +- trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 0665f35..cb07e57 100644 --- a/block.c +++ b/block.c @@ -2887,7

Re: [Qemu-devel] [PATCH v3 04/19] block: add bdrv_aio_write_zeroes

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: This will be used by the SCSI layer. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 11 +++ include/block/block.h | 3 +++ trace-events | 1 + 3 files changed, 15 insertions(+) diff --git a/block.c

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-25 Thread Kevin Wolf
Am 21.11.2013 um 09:51 hat Stefan Hajnoczi geschrieben: On Thu, Nov 21, 2013 at 11:33:56AM +0800, Chunyan Liu wrote: 2013/11/20 Stefan Hajnoczi stefa...@gmail.com On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: block/cow.c | 22 ++

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

2013-11-25 Thread Jason Wang
On 11/22/2013 10:37 PM, Vlad Yasevich wrote: On 11/22/2013 04:47 AM, Jason Wang wrote: On 11/22/2013 04:04 AM, Vlad Yasevich wrote: e1000 provides a E1000_RAH_AV bit on every complete write to the Receive Address Register. We can use this bit 2 ways: 1) To trigger HMP notifications.

Re: [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 17:58 hat Stefan Hajnoczi geschrieben: On Fri, Nov 22, 2013 at 01:24:47PM +0800, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time

Re: [Qemu-devel] [PATCH v2 00/39] bitmap handling optimization

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 07:39, Michael R. Hines ha scritto: Because some random option ROM is loaded before the RAM region is created, and thus the ram_addr_t's become misaligned. Keeping the ram_addr_t's aligned in find_ram_offset is easy: diff --git a/exec.c b/exec.c index 79610ce..1b82e81 100644

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 08:29, Lei Li ha scritto: In this case, if the migration would fail just because the misconfiguration of device state on destination, in the meantime the outgoing migration has no aware of this failure, I think it should add such handling (like synchronize of the device

Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak

2013-11-25 Thread Paolo Bonzini
Il 24/11/2013 12:04, Stefan Weil ha scritto: Do we really need this? It only makes git bisect iterations from versions after 2013-11-19 to versions before that date easier. If a typical git bisect needs 10 steps, then in the worst cast 5 of them won't automatically run configure. This is

[Qemu-devel] [RFC] Incremental live backup with in memory dirty bitmap

2013-11-25 Thread Fam Zheng
Hi all, This is an idea about allowing online incremental backup of block device, with drive-backup and (proposed here) in-memory block dirty bitmap: 1. We enable a dirty bitmap on a block device, at the start point of write tracking: (QMP) dirty-bitmap-add device=foo name=bitmap0

Re: [Qemu-devel] [PATCH v3 05/19] block: handle ENOTSUP from discard in generic code

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: Similar to write_zeroes, let the generic code receive a ENOTSUP for discard operations. Since bdrv_discard has advisory semantics, we can just swallow the error. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 2 +-

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: BlockDriverState.op_blockers is an array of list with BLOCK_OP_TYPE_MAX s/list/lists/ elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS is currently blocked for certain type s/is/as/ s/for/for

Re: [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug

2013-11-25 Thread Igor Mammedov
On Thu, 21 Nov 2013 16:45:20 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 03:37:55PM +0100, Igor Mammedov wrote: On Thu, 21 Nov 2013 15:43:27 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 02:39:10PM +0100, Igor Mammedov wrote: On

Re: [Qemu-devel] [PATCH 25/27] pc: ACPI BIOS: use enum for defining memory affinity flags

2013-11-25 Thread Igor Mammedov
On Thu, 21 Nov 2013 09:20:18 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 03:38:46AM +0100, Igor Mammedov wrote: replace magic numbers with enum describing Flags field of memory affinity in SRAT table. MemoryAffinityFlags enum will define flags decribed by:

Re: [Qemu-devel] [PATCH 26/27] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2013-11-25 Thread Igor Mammedov
On Thu, 21 Nov 2013 09:18:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 03:38:47AM +0100, Igor Mammedov wrote: Needed for Windows to use hotplugged memory device, otherwise it complains that server is not configured for memory hotplug. Tests shows that

Re: [Qemu-devel] [PATCH v3 1/4] hw/timer: add sunxi timer device

2013-11-25 Thread Peter Crosthwaite
Hi, On Mon, Nov 25, 2013 at 5:41 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |1 + hw/timer/sunxi-pit.c| 260 +++

Re: [Qemu-devel] [PATCH v3 05/19] block: handle ENOTSUP from discard in generic code

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:06, Peter Lieven ha scritto: wouldn't it make sense to return -ENOTSUP in other drivers a well if the operation is not supported and not return 0? Yes; patches are welcome. :) (I have a patch for block/iscsi.c that handles LBPU=1/LBPWS=0, and one of the things it does is

Re: [Qemu-devel] [PATCH] kvm: Query KVM for available memory slots

2013-11-25 Thread Thomas Huth
On Fri, 22 Nov 2013 12:12:44 -0700 Alex Williamson alex.william...@redhat.com wrote: KVM reports the number of available memory slots (KVM_CAP_NR_MEMSLOTS) using the extension interface. Both x86 and s390 implement this, ARM and powerpc do not yet enable it. Convert the static slots array to

Re: [Qemu-devel] [PATCH v3 06/19] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: Right now, bdrv_co_do_write_zeroes will only try to align the beginning of the request. However, it is simpler for many formats to expect the block layer to separate both the head *and* the tail. This makes sure that the format's bdrv_co_write_zeroes

Re: [Qemu-devel] [PATCH v3 07/19] vpc, vhdx: add get_info

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/vhdx.c | 10 ++ block/vpc.c | 14 ++ 2 files changed, 24 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 7d1af96..ed6fa53 100644 --- a/block/vhdx.c +++

Re: [Qemu-devel] [PATCH v5 4/6] commit: support commit active layer

2013-11-25 Thread Stefan Hajnoczi
On Wed, Oct 09, 2013 at 01:19:41PM +0800, Fam Zheng wrote: diff --git a/qapi-schema.json b/qapi-schema.json index 381ffbf..eb13707 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1910,9 +1910,11 @@ # # @top: The file name of the backing image within the image

Re: [Qemu-devel] [PATCH v3 08/19] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 1 + block/vhdx.c | 3 +++ block/vpc.c | 1 + 5 files changed, 9 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: BlockDriverState.op_blockers is an array of list with BLOCK_OP_TYPE_MAX elements. Each list is a list of blockers of an operation type (BlockOpType), that marks this BDS is currently blocked for certain type of operation with reason errors

Re: [Qemu-devel] [PATCH v3 09/19] block drivers: expose requirement for write same alignment from formats

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: This will let misaligned but large requests use zero clusters. This is important because the cluster size is not guest visible. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow2.c | 1 + block/qed.c | 1 + block/vmdk.c | 4

Re: [Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-25 Thread Peter Lieven
On 22.11.2013 13:39, Paolo Bonzini wrote: The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/iscsi.c | 19 +-- 1 file changed,

Re: [Qemu-devel] [PATCH v5 5/6] qemu-iotests: update test cases for commit active

2013-11-25 Thread Stefan Hajnoczi
On Wed, Oct 09, 2013 at 01:19:42PM +0800, Fam Zheng wrote: diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index aad535a..902df0d 100755 --- a/tests/qemu-iotests/040 +++ b/tests/qemu-iotests/040 @@ -63,6 +63,28 @@ class ImageCommitTestCase(iotests.QMPTestCase): i =

Re: [Qemu-devel] [PATCH] kvm: Query KVM for available memory slots

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:16, Thomas Huth ha scritto: On Fri, 22 Nov 2013 12:12:44 -0700 Alex Williamson alex.william...@redhat.com wrote: KVM reports the number of available memory slots (KVM_CAP_NR_MEMSLOTS) using the extension interface. Both x86 and s390 implement this, ARM and powerpc do not

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Thu, 21 Nov 2013 17:09:27 +0100 Andreas Färber afaer...@suse.de wrote: Am 21.11.2013 15:34, schrieb Igor Mammedov: On Thu, 21 Nov 2013 15:13:12 +0100 Andreas Färber afaer...@suse.de wrote: Am 21.11.2013 06:48, schrieb Li Guang: Why not give the memory that not be hot-added a chance to

Re: [Qemu-devel] [PATCH v3 2/4] hw/intc: add sunxi interrupt controller device

2013-11-25 Thread Peter Crosthwaite
On Mon, Nov 25, 2013 at 5:41 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- default-configs/arm-softmmu.mak |1 + hw/intc/Makefile.objs |1 + hw/intc/sunxi-pic.c | 301 +++

Re: [Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:34, Peter Lieven ha scritto: @@ -1012,6 +1018,14 @@ retry: } if (iTask.status != SCSI_STATUS_GOOD) { +if (iTask.status == SCSI_STATUS_CHECK_CONDITION +iTask.task-sense.key == SCSI_SENSE_ILLEGAL_REQUEST +iTask.task-sense.ascq

Re: [Qemu-devel] [PATCH v3 3/4] hw/arm: add sunxi machine type

2013-11-25 Thread Peter Crosthwaite
On Mon, Nov 25, 2013 at 5:41 PM, liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/arm/Makefile.objs |1 + hw/arm/sunxi-soc.c | 113 ++ 2 files changed, 114 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-11-25 Thread Peter Lieven
On 08.10.2013 14:39, Kevin Wolf wrote: Am 08.10.2013 um 14:35 hat Paolo Bonzini geschrieben: Il 08/10/2013 14:33, Kevin Wolf ha scritto: this converts read, write and flush functions from aio to coroutines. I'm not sure it's already the time for this... Cancellation sucks in QEMU, and this

Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak

2013-11-25 Thread Peter Maydell
On 25 November 2013 09:53, Paolo Bonzini pbonz...@redhat.com wrote: I think anything that makes it easier for users to do bisections instead of us, and anything that makes it easier to script bisections (git bisect run), is valuable. Personally I've taken to doing bisections with a complete

Re: [Qemu-devel] [PATCH v3 1/4] hw/timer: add sunxi timer device

2013-11-25 Thread Peter Maydell
On 25 November 2013 10:15, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi, On Mon, Nov 25, 2013 at 5:41 PM, liguang lig.f...@cn.fujitsu.com wrote: +#define SUNXI_TIMER_IRQ_EN 0 +#define SUNXI_TIMER_IRQ_ST 0x4 +#define SUNXI_TIMER_CONTROL 0x0 +#define SUNXI_TIMER_INTERVAL 0x4

Re: [Qemu-devel] [PULL for-1.7 00/11] Miscellaneous -rc patches

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 17:49, Paolo Bonzini ha scritto: The following changes since commit 394cfa39ba24dd838ace1308ae24961243947fb8: Merge remote-tracking branch 'quintela/migration.next' into staging (2013-11-19 13:03:06 -0800) are available in the git repository at:

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:47, Peter Lieven ha scritto: On 08.10.2013 14:39, Kevin Wolf wrote: Am 08.10.2013 um 14:35 hat Paolo Bonzini geschrieben: Il 08/10/2013 14:33, Kevin Wolf ha scritto: this converts read, write and flush functions from aio to coroutines. I'm not sure it's already the time for

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-11-25 Thread Peter Lieven
On 25.11.2013 11:54, Paolo Bonzini wrote: Il 25/11/2013 11:47, Peter Lieven ha scritto: On 08.10.2013 14:39, Kevin Wolf wrote: Am 08.10.2013 um 14:35 hat Paolo Bonzini geschrieben: Il 08/10/2013 14:33, Kevin Wolf ha scritto: this converts read, write and flush functions from aio to

Re: [Qemu-devel] [PATCH] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 11:56, Peter Lieven ha scritto: Can we proceed with the above patch for 1.8? Yes, thanks. Will you pull it or shall I rebase and sent it again after 1.7.0 release? Please do the latter. Paolo

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Fri, 22 Nov 2013 15:23:56 +0100 Gerd Hoffmann kra...@redhat.com wrote: On Do, 2013-11-21 at 03:38 +0100, Igor Mammedov wrote: Add DimmBus for memory hotplug below 4Gb or above 4Gb depending on initial memory size and hotplug memory size. * if ram_size is less than 32-bit PCI hole

Re: [Qemu-devel] [PATCH 1.7 0/2] PPC: Fix BookE timer performance regression

2013-11-25 Thread Alexander Graf
On 23.11.2013, at 05:08, Stefan Weil s...@weilnetz.de wrote: Am 23.11.2013 04:53, schrieb Alexander Graf: Thanks to the new timer infrastructure we are now able to trigger timer events and ridiculous granularities in sub-microsecond orders. However, the BookE targets were quite unhappy

Re: [Qemu-devel] [PATCH v4 5/7] block: Parse backing option to reference existing BDS

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 37 - include/block/block_int.h | 3 +++ 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-25 Thread Igor Mammedov
On Fri, 22 Nov 2013 08:57:40 +0800 Li Guang lig.f...@cn.fujitsu.com wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote: Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao wrote:

Re: [Qemu-devel] [PATCH v4 6/7] qmp: add command 'blockdev-backup'

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Signed-off-by: Fam Zheng f...@redhat.com diff

Re: [Qemu-devel] [PATCH] configure: make it possible to disable IASL

2013-11-25 Thread Michael S. Tsirkin
On Sun, Nov 24, 2013 at 09:58:34PM +0100, Stefan Weil wrote: Am 24.11.2013 17:48, schrieb Michael S. Tsirkin: On Sun, Nov 24, 2013 at 05:39:58PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 24, 2013 at 02:54:51PM +0100, Stefan Weil wrote: Am 24.11.2013 14:42, schrieb Michael S. Tsirkin:

Re: [Qemu-devel] [PATCH v4 7/7] block: Allow backup on referenced named BlockDriverState

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: Drive backup is a read only operation on source bs. We want to allow this specific case to enable image-fleecing. Note that when image-fleecing job starts, the job still add its blocker to source bs, and any other operation on it will be

Re: [Qemu-devel] [PATCH v4 1/7] qapi: Add BlockOperationType enum

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 06:24 hat Fam Zheng geschrieben: This adds the enum of all the operations that can be taken on a block device. Signed-off-by: Fam Zheng f...@redhat.com Okay, so now I've read the whole series and I still couldn't solve this mystery: Why is this a QAPI type and not some

Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak

2013-11-25 Thread Michael S. Tsirkin
On Mon, Nov 25, 2013 at 10:53:44AM +0100, Paolo Bonzini wrote: Il 24/11/2013 12:04, Stefan Weil ha scritto: Do we really need this? It only makes git bisect iterations from versions after 2013-11-19 to versions before that date easier. If a typical git bisect needs 10 steps, then in the

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Gerd Hoffmann
Does it make sense to hotplug memory above 4g unconditionally to simplify things? It does and it was so in v6 RFC, But it would rule out hotplug for 32-bit guests that doesn't support more then 4Gb. Indeed. As use case 32-bit guest could start whit small initial memory and hotplug

[Qemu-devel] [PULL for-1.7 v2 0/5] pc very last minute fixes for 1.7

2013-11-25 Thread Michael S. Tsirkin
Changes from v1: added --iasl configure fix. Note: I didn't rebase so if you pulled already, just redoing the pull will do the right thing adding the single new patch. The following changes since commit 394cfa39ba24dd838ace1308ae24961243947fb8: Merge remote-tracking branch

[Qemu-devel] [PULL for-1.7 v2 2/6] pci: unregister vmstate_pcibus on unplug

2013-11-25 Thread Michael S. Tsirkin
From: Bandan Das b...@redhat.com PCIBus registers a vmstate during init. Unregister it upon removal/unplug. Signed-off-by: Bandan Das b...@redhat.com Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c | 8

[Qemu-devel] [PULL for-1.7 v2 1/6] s390x: fix flat file load on 32 bit systems

2013-11-25 Thread Michael S. Tsirkin
pc-bios/s390-zipl.rom is a flat image so it's expected that loading it as elf will fail. It should fall back on loading a flat file, but doesn't on 32 bit systems, instead it fails printing: qemu: hardware error: could not load bootloader 's390-zipl.rom' The result is boot failure. The

[Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib 2.22

2013-11-25 Thread Michael S. Tsirkin
g_string_vprintf was only introduced in 2.24 so switch to vsnprintf instead. A bit uglier but name size is fixed at 4 bytes here so it's easy. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reported-by: Richard Henderson r...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL for-1.7 v2 5/6] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-25 Thread Michael S. Tsirkin
This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make QEMU behave more like hardware: There are valid arguments backed by the spec to indicate why the version of e1000 prior to cd5be582 was more correct: the high byte actually

[Qemu-devel] [PULL for-1.7 v2 6/6] configure: make --iasl option actually work

2013-11-25 Thread Michael S. Tsirkin
--iasl option was added to CC option parsing section by mistake, it's not effective there and attempts to use cause an 'unknown option' error. Fix this up. Tested-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- configure | 4 ++-- 1 file changed, 2

[Qemu-devel] [PULL for-1.7 v2 4/6] acpi-build: fix build on glib 2.14

2013-11-25 Thread Michael S. Tsirkin
g_array_get_element_size was only added in glib 2.14, there's no way to find element size in with an older glib. Fortunately we only use a single table (linker) where element size 1. Switch element size to 1 everywhere, then we can just look at len field to get table size in bytes. Add an

[Qemu-devel] [PATCH] trace-events: Clean up after removal of old usb-host code

2013-11-25 Thread armbru
From: Markus Armbruster arm...@redhat.com Commit b5613fd neglected to drop the trace events along with the code. Signed-off-by: Markus Armbruster arm...@redhat.com --- trace-events | 13 - 1 file changed, 13 deletions(-) diff --git a/trace-events b/trace-events index

Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak

2013-11-25 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 25 November 2013 09:53, Paolo Bonzini pbonz...@redhat.com wrote: I think anything that makes it easier for users to do bisections instead of us, and anything that makes it easier to script bisections (git bisect run), is valuable. Personally

Re: [Qemu-devel] [PATCH 02/27] rename pci_hotplug_fn to hotplug_fn and make it available for other devices

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: +typedef enum { +HOTPLUG_DISABLED, +HOTPLUG_ENABLED, +COLDPLUG_ENABLED, +} HotplugState; + +typedef int (*hotplug_fn)(DeviceState *hotplug_dev, DeviceState *dev, + HotplugState state); I don't think this

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: Along with conversion extend -m option to support following parameters: mem - startup memory amount slots - total number of hotplug memory slots maxmem - maximum possible memory slots and maxmem should go in pair and maxmem should be

Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: + +/* verify properties correctnes and initialize backend */ +bc = MEMORY_BACKEND_GET_CLASS(obj); +if (bc-get_memory) { +HostMemoryBackend *backend = MEMORY_BACKEND(obj); +if (!bc-get_memory(backend, local_err)) { +

Re: [Qemu-devel] [PATCH 08/27] dimm: implement dimm device abstraction

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: +static void dimm_initfn(Object *obj) +{ +object_property_add(obj, memdev, string, dimm_get_memdev, +dimm_set_memdev, NULL, NULL, NULL); Perhaps, instead of relying on memory_region_owner, you could have separate

Re: [Qemu-devel] [PATCH 12/27] dimm: add hotplug callback to DimmBus

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: diff --git a/include/hw/mem/dimm.h b/include/hw/mem/dimm.h index abedae2..b655006 100644 --- a/include/hw/mem/dimm.h +++ b/include/hw/mem/dimm.h @@ -65,11 +65,15 @@ typedef struct DimmDeviceClass { * @parent_obj: opaque parent object container

Re: [Qemu-devel] [PATCH 02/27] rename pci_hotplug_fn to hotplug_fn and make it available for other devices

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 13:49, Paolo Bonzini ha scritto: Il 21/11/2013 03:38, Igor Mammedov ha scritto: +typedef enum { +HOTPLUG_DISABLED, +HOTPLUG_ENABLED, +COLDPLUG_ENABLED, +} HotplugState; + +typedef int (*hotplug_fn)(DeviceState *hotplug_dev, DeviceState *dev, +

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 12:39:05 +0100 Gerd Hoffmann kra...@redhat.com wrote: Does it make sense to hotplug memory above 4g unconditionally to simplify things? It does and it was so in v6 RFC, But it would rule out hotplug for 32-bit guests that doesn't support more then 4Gb. Indeed.

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 12:39, Gerd Hoffmann ha scritto: As use case 32-bit guest could start whit small initial memory and hotplug additional memory if needed up to point where 32-bit PCI hole starts. That would allow guests to launch with small amount but baloon up upto 2-3.5 Gb depending on

Re: [Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config()

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 17:10 hat Max Reitz geschrieben: Use an Error variable in the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c

Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface

2013-11-25 Thread Paolo Bonzini
Il 21/11/2013 03:38, Igor Mammedov ha scritto: +// 64-bit math: MAX = MIN + LEN - 1 +Add(MINL, LENL, MAXL) +Add(MINH, LENH, MAXH) +If (Or(LLess(MAXL, MINL), LLess(MAXL, LENL))) { The Or is not necessary, LLess(MAXL, MINL) is

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 08:27, Markus Armbruster ha scritto: Michael S. Tsirkin m...@redhat.com writes: [...] Here this made me think of the following question: should not memory available on boot be listed in CMOS? Let's assume new BIOS gets interrupt telling it there's new memory. It clears the

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-25 Thread Corey Bryant
On 11/24/2013 10:36 PM, Xu, Quan wrote: Bryant, I found that there is some conflict in qemu-options.hx between your patch andqemu-1.7.0-rc1.tar.bz2 http://wiki.qemu-project.org/download/qemu-1.7.0-rc1.tar.bz2. What QEMU version does this patch base on? Thanks. Quan Xu Intel

[Qemu-devel] [PATCH 1.8 4/6] block/iscsi: set bdi-cluster_size

2013-11-25 Thread Peter Lieven
this patch aims to set bdi-cluster_size to the internal page size of the iscsi target so that enabled callers can align requests properly. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index

[Qemu-devel] [PATCH 1.8 2/6] qemu-img: fix usage instruction for qemu-img convert

2013-11-25 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- qemu-img.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index efb744c..e2d1a0a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -105,7 +105,6 @@ static void help(void) conversion. If the number of bytes is

[Qemu-devel] [PATCH 1.8 3/6] qemu-img: add option to specify alternate iobuffer size

2013-11-25 Thread Peter Lieven
since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer size to an alternate (greater) value. Signed-off-by: Peter Lieven p...@kamp.de --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 25 -

[Qemu-devel] [PATCH 1.8 1/6] qemu-img: add support for skipping zeroes in input during convert

2013-11-25 Thread Peter Lieven
we currently do not check if a sector is allocated during convert. This means if a sector is unallocated that we allocate a bounce buffer of zeroes, find out its zero later and do not write it in the best case. In the worst case this can lead to reading blocks from a raw device (like iSCSI)

[Qemu-devel] [PATCH 1.8 6/6] qemu-img: add option to show progress in sectors

2013-11-25 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 23 --- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 266cdf3..4190ec1 100644 --- a/qemu-img-cmds.hx +++

[Qemu-devel] [PATCH 1.8 0/6] qemu-img convert optimizations

2013-11-25 Thread Peter Lieven
this series adds some optimizations for qemu-img during convert which have been developed recently: - skipping input based on get_block_status - variable I/O buffer size - align write requests to cluster_size - show progress in sectors or percent Peter Lieven (6): qemu-img: add support for

[Qemu-devel] [PATCH 1.8 5/6] qemu-img: add option to align writes to cluster_sectors during convert

2013-11-25 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- qemu-img-cmds.hx |4 ++-- qemu-img.c | 37 + qemu-img.texi|5 - 3 files changed, 31 insertions(+), 15 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index e0b8ab4..266cdf3

Re: [Qemu-devel] [PATCH] configure: make it possible to disable IASL

2013-11-25 Thread Marcel Apfelbaum
On Mon, 2013-11-25 at 13:26 +0200, Michael S. Tsirkin wrote: On Sun, Nov 24, 2013 at 09:58:34PM +0100, Stefan Weil wrote: Am 24.11.2013 17:48, schrieb Michael S. Tsirkin: On Sun, Nov 24, 2013 at 05:39:58PM +0200, Michael S. Tsirkin wrote: On Sun, Nov 24, 2013 at 02:54:51PM +0100, Stefan

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-25 Thread Igor Mammedov
On Sun, 24 Nov 2013 12:58:57 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Nov 22, 2013 at 06:14:46PM +0100, Igor Mammedov wrote: On Thu, 21 Nov 2013 16:38:47 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 03:21:37PM +0100, Igor Mammedov wrote: On

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 14:45:15 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/11/2013 08:27, Markus Armbruster ha scritto: Michael S. Tsirkin m...@redhat.com writes: [...] Here this made me think of the following question: should not memory available on boot be listed in CMOS?

[Qemu-devel] [PATCH] SPARC: Fix LEON3 power down instruction

2013-11-25 Thread Sebastian Huber
The env-pc is not necessarily up-to-date in the helper function. Use the program counter of the disassembly context instead. Signed-off-by: Sebastian Huber sebastian.hu...@embedded-brains.de --- target-sparc/helper.c|6 +++--- target-sparc/helper.h|2 +- target-sparc/translate.c

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 14:35:18 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/11/2013 12:39, Gerd Hoffmann ha scritto: As use case 32-bit guest could start whit small initial memory and hotplug additional memory if needed up to point where 32-bit PCI hole starts. That would allow

Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 14:42:44 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 21/11/2013 03:38, Igor Mammedov ha scritto: +// 64-bit math: MAX = MIN + LEN - 1 +Add(MINL, LENL, MAXL) +Add(MINH, LENH, MAXH) +If

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 15:18, Igor Mammedov ha scritto: For example on reset all slots could be disabled by the ACPIHotpluggableDimmBus (even coldplugged ones), and scanned + enabled by ASL. memory devices are scanned by OSPM during ACPI tables parsing and guest (can) use present devices right

Re: [Qemu-devel] [PATCH v2 7/7] blkverify: Don't require protocol filename

2013-11-25 Thread Kevin Wolf
Am 22.11.2013 um 17:10 hat Max Reitz geschrieben: If the filename is not prefixed by blkverify: in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line option (like file.driver=blkverify). Contrary to the current

Re: [Qemu-devel] [PATCH 12/27] dimm: add hotplug callback to DimmBus

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 14:01:51 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 21/11/2013 03:38, Igor Mammedov ha scritto: diff --git a/include/hw/mem/dimm.h b/include/hw/mem/dimm.h index abedae2..b655006 100644 --- a/include/hw/mem/dimm.h +++ b/include/hw/mem/dimm.h @@ -65,11 +65,15

Re: [Qemu-devel] [PATCH 1.8 4/6] block/iscsi: set bdi-cluster_size

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 14:57, Peter Lieven ha scritto: +/* Guess the internal cluster (page) size of the iscsi target by the means + * of opt_unmap_gran. Transfer the unmap granularity only if it has a + * reasonable size for bdi-cluster_size */ +if (iscsilun-bl.opt_unmap_gran *

Re: [Qemu-devel] [PATCH 1.8 3/6] qemu-img: add option to specify alternate iobuffer size

2013-11-25 Thread Paolo Bonzini
Il 25/11/2013 14:57, Peter Lieven ha scritto: since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer size to an alternate (greater) value. Do you really need the extra knob? You can just add to BlockLimits the optimal

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-25 Thread Igor Mammedov
On Mon, 25 Nov 2013 15:31:22 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/11/2013 15:18, Igor Mammedov ha scritto: For example on reset all slots could be disabled by the ACPIHotpluggableDimmBus (even coldplugged ones), and scanned + enabled by ASL. memory devices are scanned

Re: [Qemu-devel] [PATCH 1.8 3/6] qemu-img: add option to specify alternate iobuffer size

2013-11-25 Thread Peter Lieven
On 25.11.2013 15:54, Paolo Bonzini wrote: Il 25/11/2013 14:57, Peter Lieven ha scritto: since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer size to an alternate (greater) value. Do you really need the extra knob? You

  1   2   3   >