Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-05 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 12/05/2013 12:12 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 12/04/2013 08:33 PM, Markus Armbruster wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto:

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-05 Thread Peter Maydell
On 5 December 2013 00:20, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Is hivecs-on-reset ideally a new ARM_FEATURE or is there a simpler conditional we can use as post_init time? I think we want the property if (!arm_feature(ARM_FEATURE_M)). -- PMM

Re: [Qemu-devel] [RFC v5 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-12-05 Thread Peter Maydell
On 5 December 2013 00:25, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: But the bootloader does this already. We have support for board configurable secondary bootloops. Is this as simple as supporting board configurable primary boot fragments? arm_boot needs to be patched to do its

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-12-05 Thread Matthias Brugger
2013/11/11 Stefan Hajnoczi stefa...@redhat.com: On Mon, Nov 11, 2013 at 11:00:45AM +0100, Matthias Brugger wrote: 2013/11/5 Stefan Hajnoczi stefa...@gmail.com: I'd also like to see the thread pool implementation you wish to add before we add a layer of indirection which has no users yet.

Re: [Qemu-devel] [PATCH v9 0/5] add allwinner A10 SoC support

2013-12-05 Thread Peter Maydell
On 5 December 2013 02:33, Li Guang lig.f...@cn.fujitsu.com wrote: Peter Crosthwaite wrote: Hi Liguang, V9 has some checkpatch errors: [pcrost@xsjandreislx qemu]$ git format-patch HEAD~5 0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch 0002-hw-timer-add-allwinner-a10-timer.patch

Re: [Qemu-devel] gpu and console chicken and egg

2013-12-05 Thread Gerd Hoffmann
Hi, Hmm, why does it depend on the UI? Wasn't the plan to render into a dma-buf no matter what? Then either read the rendered result from the dmabuf (non-gl UI like vnc) or let the (gl-capable) UI pass the dma-buf to the compositor? That would be the hopeful plan, however so far my

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 04/12/2013 21:24, Alexander Graf ha scritto: When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id bus: ide.0

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-05 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 06:40:30PM +0100, Paolo Bonzini wrote: Il 04/12/2013 15:06, Stefan Hajnoczi ha scritto: On Thu, Oct 10, 2013 at 05:07:18PM +0200, Paolo Bonzini wrote: @@ -298,30 +278,31 @@ static void handle_notify(EventNotifier *e) vring_disable_notification(s-vdev,

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 07:15, Fernando Luis Vázquez Cao ha scritto: VCPU TSC is not cleared by a warm reset (*), which leaves many Linux guests vulnerable to the overflow in cyc2ns_offset fixed by upstream commit 9993bc635d01a6ee7f6b833b4ee65ce7c06350b1 (sched/x86: Fix overflow in cyc2ns_offset). To

Re: [Qemu-devel] [PATCH 0/4] spapr-pci: prepare for vfio

2013-12-05 Thread Alexey Kardashevskiy
On 11/21/2013 03:08 PM, Alexey Kardashevskiy wrote: Here are few reworks for spapr-pci PHB which I'd like to have to support VFIO. QOM, errors printing, traces, nothing really serious. Thanks! Alexey Kardashevskiy (4): spapr-pci: convert init() callback to realize() spapr-pci: introduce

Re: [Qemu-devel] [PATCH] spapr-iommu: extend SPAPR_TCE_TABLE class

2013-12-05 Thread Alexey Kardashevskiy
On 11/20/2013 04:39 PM, Alexey Kardashevskiy wrote: This adds a put_tce() callback to the SPAPR TCE TABLE device class. The new callback allows to have different IOMMU types such as upcoming VFIO IOMMU and it will be used more by the upcoming Multi-TCE support. This reworks the H_PUT_TCE

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 09:40, Matthias Brugger ha scritto: CFQ the state of the art I/O scheduler The deadline scheduler typically provides much better performance for server usage (including hosting VMs). It doesn't support some features such as I/O throttling via cgroups, but QEMU now has a very good

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id bus: ide.0 type IDE

Re: [Qemu-devel] [PATCH v2 5/6] qemu-option: Remove qemu_opts_create_nofail

2013-12-05 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: This is a boiler-plate _nofail variant of qemu_opts_create. Remove and use error_abort in call sites. null/0 arguments needs to be added for the id and fail_if_exists fields in affected callsites due to argument inconsistency between the

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Add a special Error * that can be passed to error handling APIs to signal that any errors are fatal and should abort QEMU. There are two advantages to this: - allows for brevity when wishing to assert success of Error ** accepting

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-12-05 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 09:40:56AM +0100, Matthias Brugger wrote: 2013/11/11 Stefan Hajnoczi stefa...@redhat.com: On Mon, Nov 11, 2013 at 11:00:45AM +0100, Matthias Brugger wrote: 2013/11/5 Stefan Hajnoczi stefa...@gmail.com: I'd also like to see the thread pool implementation you wish to

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id bus: ide.0 type IDE

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 10:44, Markus Armbruster ha scritto: Incompatible change: device ide-cd moved to a different controller. Yes, it should be stated in the commit message but it's expected as discussed yesterday on IRC. The solution is not to use -device (which was broken) if you care about

Re: [Qemu-devel] [PATCHv3 1.8 7/9] qemu-img: round down request length to an aligned sector

2013-12-05 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 04:56:19PM +0100, Peter Lieven wrote: Am 04.12.2013 16:49, schrieb Stefan Hajnoczi: On Wed, Nov 27, 2013 at 11:07:07AM +0100, Peter Lieven wrote: @@ -1397,19 +1396,21 @@ static int img_convert(int argc, char **argv) } } +cluster_sectors = 0;

Re: [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 10:24, Stefan Hajnoczi ha scritto: That's what already happens actually. vring_push has +g_slice_free(VirtQueueElement, elem); + /* Don't touch vring if a fatal error occurred */ if (vring-broken) { return; in this patch and +

Re: [Qemu-devel] [PATCHv3 1.8 8/9] qemu-img: increase min_sparse to 128 sectors (64kb)

2013-12-05 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 05:55:22AM +0100, Peter Lieven wrote: Am 05.12.2013 um 03:12 schrieb Eric Blake ebl...@redhat.com: On 12/04/2013 09:46 AM, Peter Lieven wrote: I guess a sane size would be cluster size. For a raw file 4 KB is reasonable since that's the file system block

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-05 Thread Paolo Bonzini
Il 03/12/2013 21:33, Igor Mammedov ha scritto: I'm sorry for hijacking thread, but that actually an issue that started an original discussion. Where void returning QOM API functions are used with NULL, without any chance to detect that error happened. So abusing NULL errp in this functions

Re: [Qemu-devel] [PATCHv3 1.8 1/9] qemu-img: add support for skipping zeroes in input during convert

2013-12-05 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 05:51:20PM +0100, Peter Lieven wrote: Am 04.12.2013 17:46, schrieb Stefan Hajnoczi: On Wed, Nov 27, 2013 at 11:07:01AM +0100, Peter Lieven wrote: +/* If the output image is being created as a copy on write + * image, assume that

[Qemu-devel] propose gsoc project

2013-12-05 Thread Xin Tong
I am wondering whether it is possible to propose project in QEMU google summer of code as a student ? I have some ideas regarding TLB emulation in system mode and would like to find a mentor to do a gsoc for it. Thank you, Xin

Re: [Qemu-devel] propose gsoc project

2013-12-05 Thread Fam Zheng
On 2013年12月05日 18:48, Xin Tong wrote: I am wondering whether it is possible to propose project in QEMU google summer of code as a student ? I have some ideas regarding TLB emulation in system mode and would like to find a mentor to do a gsoc for it. Sure, it's definitely welcome. You can post

Re: [Qemu-devel] [RFC PATCH v0 2/3] gluster: Implement .bdrv_co_write_zeroes for gluster

2013-12-05 Thread Bharata B Rao
On Wed, Dec 04, 2013 at 02:16:28PM -0500, Jeff Cody wrote: On Fri, Nov 22, 2013 at 12:46:17PM +0530, Bharata B Rao wrote: + +ret = glfs_zerofill_async(s-fd, offset, size, gluster_finish_aiocb, acb); +if (ret 0) { I believe glfs_zerofill_async returns -1 on failure, and sets

[Qemu-devel] [RFC PATCH v1 3/3] gluster: Add support for creating zero-filled image

2013-12-05 Thread Bharata B Rao
GlusterFS supports creation of zero-filled file on GlusterFS volume by means of an API called glfs_zerofill(). Use this API from QEMU to create an image that is filled with zeroes by using the preallocation option of qemu-img. qemu-img create gluster://server/volume/image -o preallocation=full

[Qemu-devel] [RFC PATCH v1 2/3] gluster: Implement .bdrv_co_write_zeroes for gluster

2013-12-05 Thread Bharata B Rao
Support .bdrv_co_write_zeroes() from gluster driver by using GlusterFS API glfs_zerofill() that off-loads the writing of zeroes to GlusterFS server. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- block/gluster.c | 77 +

[Qemu-devel] [RFC PATCH v1 1/3] gluster: Convert aio routines into coroutines

2013-12-05 Thread Bharata B Rao
Convert the read, write, flush and discard implementations from aio-based ones to coroutine based ones. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- block/gluster.c | 184 +++- 1 file changed, 63 insertions(+), 121 deletions(-)

[Qemu-devel] [RFC PATCH v1 0/3] gluster: conversion to coroutines and supporting write_zeroes

2013-12-05 Thread Bharata B Rao
Hi, This series is about converting all the bdrv_aio* implementations in gluster driver to coroutine based implementations. Read, write, flush and discard routines are converted. This also adds support for .bdrv_co_write_zeroes() in gluster and provides a new preallocation option with qemu-img

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 05/12/2013 10:44, Markus Armbruster ha scritto: Incompatible change: device ide-cd moved to a different controller. Yes, it should be stated in the commit message but it's expected as discussed yesterday on IRC. The solution is not to use -device

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 12:20, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 05/12/2013 10:44, Markus Armbruster ha scritto: Incompatible change: device ide-cd moved to a different controller. Yes, it should be stated in the commit message but it's expected as discussed

[Qemu-devel] [PATCH V7 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-12-05 Thread Wenchao Xia
The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6

[Qemu-devel] [PATCH V7 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-12-05 Thread Wenchao Xia
V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn-l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug,

[Qemu-devel] [PATCH V7 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-12-05 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 55746c4..5f787bc 100644

[Qemu-devel] [PATCH V7 1/6] snapshot: add parameter *errp in snapshot create

2013-12-05 Thread Wenchao Xia
The return value is only used for error report before this patch, so change the function protype to return void. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c| 30 +- block/qcow2.h

[Qemu-devel] [PATCH V7 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots

2013-12-05 Thread Wenchao Xia
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index d7ab4ae..55746c4 100644 ---

[Qemu-devel] [PATCH V7 5/6] blkdebug: add debug events for snapshot

2013-12-05 Thread Wenchao Xia
Some code in qcow2-snapshot.c directly accesses bs-file, so in those places errors can't be injected by other events. Since the code in qcow2-snapshot.c is similar to the other qcow2 internal code (in regards to e.g. the L1 table), add some debug events. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [RFC PATCH v0 1/3] gluster: Convert aio routines into coroutines

2013-12-05 Thread Bharata B Rao
On Tue, Dec 03, 2013 at 03:04:01PM +0100, Stefan Hajnoczi wrote: On Fri, Nov 22, 2013 at 12:46:16PM +0530, Bharata B Rao wrote: +qemu_bh_delete(acb-bh); +acb-bh = NULL; +qemu_coroutine_enter(acb-coroutine, NULL); +if (acb-finished) { +*acb-finished = true; +

[Qemu-devel] [PATCH V7 6/6] qemu-iotests: add test for qcow2 snapshot

2013-12-05 Thread Wenchao Xia
This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- tests/qemu-iotests/075 | 218

Re: [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations

2013-12-05 Thread Stefan Hajnoczi
On Wed, Nov 27, 2013 at 11:07:00AM +0100, Peter Lieven wrote: this series adds some optimizations for qemu-img during convert which have been developed recently: - skipping input based on get_block_status - variable I/O buffer size - align write requests to cluster_size v2-v3: - added

Re: [Qemu-devel] [PATCH 1/4] memory: cache min/max_access_size

2013-12-05 Thread Uri Lublin
On 12/02/2013 04:40 PM, Paolo Bonzini wrote: This will simplify the code in the next patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 2 ++ memory.c | 27 +++ 2 files changed, 13 insertions(+), 16 deletions(-)

Re: [Qemu-devel] [PATCH 1/4] memory: cache min/max_access_size

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 13:19, Uri Lublin ha scritto: /* FIXME: support unaligned access? */ -access_size = MAX(MIN(size, access_size_max), access_size_min); +access_size = MAX(MIN(size, mr-min_access_size), mr-min_access_size); Hi Paolo, Here it should be

Re: [Qemu-devel] [PATCH] qcow2: use start_of_cluster() and offset_into_cluster() everywhere

2013-12-05 Thread Stefan Hajnoczi
On Thu, Dec 05, 2013 at 02:32:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 22 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) Thanks, applied to my block tree:

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-05 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: Normally the user is expected to eject DVD if it is not locked by the guest. eject_device() makes few checks and calls bdrv_close() if DVD is not in

Re: [Qemu-devel] [PATCH 01/27] acpi: factor out common pm_update_sci() into acpi core

2013-12-05 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:22AM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Sorry doesn't apply. Can you rebase on top of latest tree please? --- perhaps this patch sholud go before piix4: add acpi pci hotplug support so that there were no need in this

[Qemu-devel] [PATCH v3 02/12] target-arm: A64: add set_pc cpu method

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de When executing translation blocks we need to be able to recover our program counter. Add a method to set it for AArch64 CPUs. This covers user-mode, but for system mode emulation we will need to check if the CPU is in an AArch32 execution state. Signed-off-by:

[Qemu-devel] [PATCH v3 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal()

2013-12-05 Thread Peter Maydell
The A32/T32 gen_intermediate_code_internal() is complicated because it has to deal with: * conditionally executed instructions * Thumb IT blocks * kernel helper page * M profile exception-exit special casing None of these apply to A64, so putting the this is A64 so call the A64 decoder check

[Qemu-devel] [PATCH v3 12/12] target-arm: A64: add support for compare and branch imm

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds emulation for the compare and branch insns, CBZ and CBNZ. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder, compare with immediate 0, introduce read_cpu_reg to get the 0 extension on (!sf)]

[Qemu-devel] [PATCH v3 09/12] target-arm: A64: add support for BR, BLR and RET insns

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Implement BR, BLR and RET. This is all of the 'unconditional branch (register)' instruction category except for ERET and DPRS (which are system mode only). Signed-off-by: Alexander Graf ag...@suse.de [claudio: reimplemented on top of new decoder structure]

[Qemu-devel] [PATCH v3 10/12] target-arm: A64: add support for conditional branches

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds emulation for the conditional branch (b.cond) instruction. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder structure, reused arm infrastructure for checking the flags] Signed-off-by: Claudio Fontana

[Qemu-devel] [PATCH v3 04/12] target-arm: Support fp registers in gdb stub

2013-12-05 Thread Peter Maydell
Register the aarch64-fpu XML and implement the necessary read/write handlers so we can support reading and writing of FP registers in the gdb stub. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- configure |2 +-

[Qemu-devel] [PATCH v3 00/12] target-arm: A64 decoder, foundation plus branches

2013-12-05 Thread Peter Maydell
Round three of the first-chunk of A64 decoder work, updated following code review. Only patches 8 and 12 have changed (and RTH, those are the only two still waiting for your review :-)) Contents: * the new decoder skeleton, * gdbstub support for FP insns * a patch from me which gives the A64

[Qemu-devel] [PATCH v3 07/12] target-arm: A64: expand decoding skeleton for system instructions

2013-12-05 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org Decode the various kinds of system instructions: hints (HINT), which include NOP, YIELD, WFE, WFI, SEV, SEL sync instructions, which include CLREX, DSB, DMB, ISB msr_i, which move immediate to processor state field sys, which include all SYS

[Qemu-devel] [PATCH v3 06/12] target-arm: A64: provide skeleton for a64 insn decoding

2013-12-05 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org Provide a skeleton for a64 instruction decoding in translate-a64.c, by dividing instructions into the classes defined by the ARM Architecture Reference Manual(DDI0487A_a) section C3. Signed-off-by: Claudio Fontana claudio.font...@linaro.org

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-05 Thread Alexey Kardashevskiy
On 12/05/2013 11:29 PM, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 04/12/2013 05:55, Alexey Kardashevskiy ha scritto: Normally the user is expected to eject DVD if it is not locked by the guest. eject_device() makes few

[Qemu-devel] [PATCH v3 05/12] target-arm: A64: add stubs for a64 specific helpers

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de We will need helpers that only make sense with AArch64. Add helper-a64.{c,h} files as stubs that we can fill with these helpers in the following patches. Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PATCH v3 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR

2013-12-05 Thread Peter Maydell
The information which AArch32 holds in the FPSCR is split for AArch64 into two logically distinct registers, FPSR and FPCR. Since they are carefully arranged to use non-overlapping bits, we leave the underlying state in the same place, and provide accessor functions which just update the

[Qemu-devel] [PATCH v3 11/12] target-arm: A64: add support for 'test and branch' imm

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds emulation for the test and branch insns, TBZ and TBNZ. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted for new decoder always compare with 0 remove a TCG temporary ] Signed-off-by: Claudio Fontana claudio.font...@linaro.org

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: close drive on START_STOP

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 13:42, Alexey Kardashevskiy ha scritto: Thanks! Just out of curiosity. A lot (in fact, all around me) dvd drives do not support trayclose as they are in laptops or servers (which use the same laptop models). I cannot even verify how this eject -t exactly works - no hardware

[Qemu-devel] [PATCH v3 08/12] target-arm: A64: add support for B and BL insns

2013-12-05 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Implement the B and BL instructions (PC relative branches and calls). For convenience in managing TCG temporaries which might be generated if a source register is the zero-register XZR, we provide a simple mechanism for creating a new temp which is

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting -sandbox on by default

2013-12-05 Thread Stefan Hajnoczi
On Wed, Dec 04, 2013 at 11:21:12AM -0200, Eduardo Otubo wrote: On 12/04/2013 07:39 AM, Stefan Hajnoczi wrote: On Fri, Nov 22, 2013 at 11:00:24AM -0500, Paul Moore wrote: Developers will only be happy with seccomp if it's easy and rewarding to support/debug. Agreed. As a developer, how do

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-05 Thread Fernando Luis Vazquez Cao
(2013/12/05 18:28), Paolo Bonzini wrote: Il 05/12/2013 07:15, Fernando Luis Vázquez Cao ha scritto: VCPU TSC is not cleared by a warm reset (*), which leaves many Linux guests vulnerable to the overflow in cyc2ns_offset fixed by upstream commit 9993bc635d01a6ee7f6b833b4ee65ce7c06350b1

Re: [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests

2013-12-05 Thread Orit Wasserman
On 11/28/2013 04:01 PM, Eduardo Habkost wrote: This series separates the QEMUFile and VMState code from savevm.c, and adds a few unit tests to the VMState code. Eduardo Habkost (9): qemu-file: Make a few functions non-static migration: Move QEMU_VM_* defines to migration/migration.h

Re: [Qemu-devel] [PATCH v2 1/6] error: Add error_abort

2013-12-05 Thread Eric Blake
On 12/05/2013 03:13 AM, Markus Armbruster wrote: For error_propagate, if the destination error is error_abort, then the abort happens at propagation time. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- changed since v1: Delayed assertions that *errp == NULL. Care to

Re: [Qemu-devel] [PATCHv3 1.8 6/9] qemu-img: dynamically adjust iobuffer size during convert

2013-12-05 Thread Eric Blake
On 11/27/2013 03:07 AM, Peter Lieven wrote: since the convert process is basically a sync operation it might be benificial in some case to change the hardcoded I/O buffer s/benificial/beneficial/ size to a greater value. This patch increases the I/O buffer size if the output driver

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 14:15, Fernando Luis Vazquez Cao ha scritto: /* * KVM is yet unable to synchronize TSC values of multiple VCPUs on * writeback. Until this is fixed, we only write the offset to SMP * guests after migration, desynchronizing the VCPUs, but

Re: [Qemu-devel] [RFC V3 4/7] qmp: Allow block_passwd to manipulate bs graph nodes.

2013-12-05 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 16:56:05 (-0700), Eric Blake a écrit : On 12/03/2013 06:26 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- +BlockDriverState * bdrv_lookup_bs(bool has_device, const char * device, + bool

Re: [Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-05 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 17:11:26 (-0700), Eric Blake a écrit : On 12/03/2013 06:26 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- blockdev.c | 49 + hmp.c| 4 +++- qapi-schema.json | 13

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-05 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 16:46:34 (-0700), Eric Blake a écrit : On 12/03/2013 06:26 AM, Benoît Canet wrote: In addition to Fam's review, s/skeletton/skeleton/ in subject --- blockdev.c | 8 qapi-schema.json | 32 2 files changed,

[Qemu-devel] [Bug 1258168] [NEW] QEMU fails to build on CentOS 5.10 with --disable-pie reporting /usr/bin/ld: -f may not be used without -shared

2013-12-05 Thread Don Slutz
Public bug reported: fails for (7dc65c0 (HEAD, origin/master, origin/HEAD, master) Open 2.0 development tree): ... libtool --mode=link --tag=CC cc -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-05 Thread Eric Blake
On 12/05/2013 07:24 AM, Benoît Canet wrote: Am I correct that it will be possible to have named nodes that are not currently associated with any device? If so, how do we learn about those nodes? Would it be better to have a command that returns an array of structs for all known node roots,

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-05 Thread Benoît Canet
Le Thursday 05 Dec 2013 à 07:38:37 (-0700), Eric Blake a écrit : On 12/05/2013 07:24 AM, Benoît Canet wrote: Am I correct that it will be possible to have named nodes that are not currently associated with any device? If so, how do we learn about those nodes? Would it be better to

Re: [Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-05 Thread Benoît Canet
Le Wednesday 04 Dec 2013 à 15:03:42 (+0800), Fam Zheng a écrit : On 2013年12月04日 14:34, Benoît Canet wrote: Le Wednesday 04 Dec 2013 à 14:12:19 (+0800), Fam Zheng a écrit : On 2013年12月04日 13:20, Benoît Canet wrote: Le Wednesday 04 Dec 2013 à 11:47:22 (+0800), Fam Zheng a écrit : On 2013年12月03日

[Qemu-devel] [PATCH] qemu-img: make progress output more accurate during convert

2013-12-05 Thread Peter Lieven
the progress output is very bumpy if the input images contains a significant portion of unallocated sectors. This patch checks how much sectors are allocated a priori if progress output is selected. Signed-off-by: Peter Lieven p...@kamp.de --- qemu-img.c | 26 +- 1 file

Re: [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations

2013-12-05 Thread Peter Lieven
Am 05.12.2013 13:15, schrieb Stefan Hajnoczi: On Wed, Nov 27, 2013 at 11:07:00AM +0100, Peter Lieven wrote: this series adds some optimizations for qemu-img during convert which have been developed recently: - skipping input based on get_block_status - variable I/O buffer size - align write

Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-05 Thread Eric Blake
On 12/05/2013 07:43 AM, Benoît Canet wrote: There's one case where management might not know - if libvirtd gets restarted while in the middle of an operation that was attempting to create a named node, then on restart and reconnection to the monitor, libvirt would want to query to see if the

[Qemu-devel] [Bug 1258168] Re: QEMU fails to build on CentOS 5.10 with --disable-pie reporting /usr/bin/ld: -f may not be used without -shared

2013-12-05 Thread Don Slutz
Using the hack: git diff diff --git a/configure b/configure index 0666228..cf8123b 100755 --- a/configure +++ b/configure @@ -1292,7 +1292,9 @@ done if compile_prog -Werror -fstack-protector-all ; then QEMU_CFLAGS=$QEMU_CFLAGS -fstack-protector-all -LIBTOOLFLAGS=$LIBTOOLFLAGS

Re: [Qemu-devel] [PATCH 01/27] acpi: factor out common pm_update_sci() into acpi core

2013-12-05 Thread Igor Mammedov
On Thu, 5 Dec 2013 14:37:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Nov 21, 2013 at 03:38:22AM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Sorry doesn't apply. Can you rebase on top of latest tree please? I just tried to rebase on top of

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-05 Thread Paolo Bonzini
Il 04/12/2013 02:32, Don Slutz ha scritto: Any hints or pointers about the bug in RHEL5 binutils? I can try and make a patch to auto detect this. Actually it's RHEL5 GCC: $ cat f.c void * f(unsigned char *buf, int len) { return (void*)0L; } void * g(unsigned char *buf, int len) {

[Qemu-devel] PING Re: [patch] introduce MIG_STATE_CANCELLING state

2013-12-05 Thread Paolo Bonzini
Il 07/11/2013 12:21, Paolo Bonzini ha scritto: Il 07/11/2013 12:01, Zhanghaoyu (A) ha scritto: Introduce MIG_STATE_CANCELLING state to avoid starting a new migration task while the previous one still exist. Signed-off-by: Zeng Junliang zengjunli...@huawei.com Signed-off-by: Zhang Haoyu

Re: [Qemu-devel] Patch Round-up for stable 1.6.2, freeze on 2013-12-06

2013-12-05 Thread Paolo Bonzini
Il 04/12/2013 15:34, Michael Roth ha scritto: Hi everyone, The following new patches are queued for QEMU stable v1.6.2: https://github.com/mdroth/qemu/commits/stable-1.6-staging The release is planned for 2013-12-09: http://wiki.qemu.org/Planning/1.6 Please respond here or CC

Re: [Qemu-devel] [PATCH 0/7] target-arm: Support AArch64 KVM

2013-12-05 Thread Peter Maydell
Slightly over-eager ping for code review and/or testing, since the A64 patches are going to sit on top of this and they're starting to pile up :-) (Also noticed I forgot to cc Mian; apologies.) thanks -- PMM On 28 November 2013 13:33, Peter Maydell peter.mayd...@linaro.org wrote: This patchset

Re: [Qemu-devel] [PATCH v2 2/2] target-i386: Intel MPX

2013-12-05 Thread Liu, Jinsong
Paolo Bonzini wrote: Il 04/12/2013 12:30, Liu, Jinsong ha scritto: Almost there. Migration (vmstate) is still missing. Like this: == From faead85c0dbe62da896e0ed9e165d98e10216968 Mon Sep 17 00:00:00 2001 From: Liu Jinsong jinsong@intel.com Date: Wed, 4 Dec 2013

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-05 Thread Igor Mammedov
On Thu, 05 Dec 2013 11:37:27 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 03/12/2013 21:33, Igor Mammedov ha scritto: I'm sorry for hijacking thread, but that actually an issue that started an original discussion. Where void returning QOM API functions are used with NULL, without any

[Qemu-devel] [PATCH] rbd: switch from pipe to QEMUBH completion notification

2013-12-05 Thread Stefan Hajnoczi
rbd callbacks are called from non-QEMU threads. Up until now a pipe was used to signal completion back to the QEMU iothread. The pipe writer code handles EAGAIN using select(2). The select(2) API is not scalable since fd_set size is static. FD_SET() can write beyond the end of fd_set if the

[Qemu-devel] [V4 PATCH 10/14] target-ppc: VSX Stage 4: Add xssqrtsp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Square Root Single Precision (xssqrtsp) instruction. The existing VSX_SQRT() macro is modified to support rounding of the intermediate double-precision result to single-precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

[Qemu-devel] [V4 PATCH 02/14] target-ppc: VSX Stage 4: Refactor lxsdx

2013-12-05 Thread Tom Musta
This patch refactors the lxsdx generator. Resuable code is isolated into a macro. The macro will be used in subsequent patches in this series to implement other scalar load instructions. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Richard Henderson r...@twiddle.net ---

[Qemu-devel] [V4 PATCH 00/14] target-ppc: VSX Stage 4

2013-12-05 Thread Tom Musta
This is the fourth and final series of patches that add emulation support to QEMU for the PowerPC Vector Scalar Extension (VSX). This series adds the instructions that were newly introduced with Power ISA V2.07. This includes 3 scalar load instructions, 2 scalar store instructions, 7 standard

[Qemu-devel] [V4 PATCH 01/14] target-ppc: VSX Stage 4: Add VSX 2.07 Flag

2013-12-05 Thread Tom Musta
This patch adds a flag to identify those VSX instructions that are new to Power ISA V2.07. The flag is added to the Power 8 processor initialization so that the P8 models understand how to decode and emulate instructions in this category. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by:

[Qemu-devel] [V4 PATCH 04/14] target-ppc: VSX Stage 4: Refactor stxsdx

2013-12-05 Thread Tom Musta
This patch refactors the stxsdx instruction. Reusable code is extracted into a macro which will be used in subsequent patches in this series. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Richard Henderson r...@twiddle.net --- target-ppc/translate.c | 27 +++

[Qemu-devel] [V4 PATCH 08/14] target-ppc: VSX Stage 4: Add xsdivsp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Divide Single Precision (xsdivsp) instruction. The existing VSX_DIV macro is modified to support rounding of the intermediate double precision result to single precision. V2: Updated conversion to single precision. Signed-off-by: Tom Musta tommu...@gmail.com

[Qemu-devel] [V4 PATCH 05/14] target-ppc: VSX Stage 4: Add stxsiwx and stxsspx

2013-12-05 Thread Tom Musta
This patch adds two store scalar instructions: - Store VSX Scalar as Integer Word Indexed (stxsiwx) - Store VSX Scalar Single-Precision Indexed (stxsspx) Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Richard Henderson r...@twiddle.net --- target-ppc/translate.c |4 1

[Qemu-devel] [V4 PATCH 12/14] target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-12-05 Thread Tom Musta
This patch adds the Single Precision VSX Scalar Fused Multiply-Add instructions: xsmaddasp, xsmaddmsp, xssubasp, xssubmsp, xsnmaddasp, xsnmaddmsp, xsnmsubasp, xsnmsubmsp. The existing VSX_MADD() macro is modified to support rounding of the intermediate double precision result to single precision.

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-05 Thread Fernando Luis Vazquez Cao
(2013/12/05 22:53), Paolo Bonzini wrote: Il 05/12/2013 14:15, Fernando Luis Vazquez Cao ha scritto: /* * KVM is yet unable to synchronize TSC values of multiple VCPUs on * writeback. Until this is fixed, we only write the offset to SMP * guests after

[Qemu-devel] [V4 PATCH 09/14] target-ppc: VSX Stage 4: Add xsresp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Estimate Single Precision (xsresp) instruction. The existing VSX_RE macro is modified to support rounding of the intermediate double precision result to single precision. V2: Updated conversion to single precision range. Signed-off-by: Tom Musta

[Qemu-devel] [V4 PATCH 03/14] target-ppc: VSX Stage 4: Add lxsiwax, lxsiwzx and lxsspx

2013-12-05 Thread Tom Musta
This patch adds the scalar load instructions introduced in ISA V2.07: - Load VSX Scalar as Integer Word Algebraic Indexd (lxsiwax) - Load VSX Scalar as Integer Word and Zero Indexed (lxsiwzx) - Load VSX Scalar Single-Precision Indexed (lxsspx) Signed-off-by: Tom Musta tommu...@gmail.com

[Qemu-devel] [V4 PATCH 06/14] target-ppc: VSX Stage 4: Add xsaddsp and xssubsp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Add Single-Precision (xsaddsp) and VSX Scalar Subtract Single-Precision (xssubsp) instructions. The existing VSX_ADD_SUB macro is modified to support the rounding of the (intermediate) result to single-precision. V2: updated conversion of result to single

[Qemu-devel] [V4 PATCH 07/14] target-ppc: VSX Stage 4: Add xsmulsp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Multiply Single-Precision (xsmulsp) instruction. The existing VSX_MUL macro is modified to support rounding of the intermediate result to single precision. V2: Updated conversion to single precision. Signed-off-by: Tom Musta tommu...@gmail.com Reviewed-by: Richard

[Qemu-devel] [V4 PATCH 11/14] target-ppc: VSX Stage 4: add xsrsqrtesp

2013-12-05 Thread Tom Musta
This patch adds the VSX Scalar Reciprocal Square Root Estimate Single Precision (xsrsqrtesp) instruction. The existing VSX_RSQRTE() macro is modified to support rounding of the intermediate double-precision result to single precision. V2: Updated conversion to single precision range.

  1   2   3   >