Re: [Qemu-devel] [PATCH 2/2] add parsing of strict boot parameter

2013-12-09 Thread Michael Tokarev
09.12.2013 11:51, Amos Kong пишет: Commit 6ef4716cecdfa1b3794c1a33edba9840e1aa6b5f cleaned up the parse code of boot parameter, parse code of strict wasn't re-implemented, it caused that strict boot feature is always disabled. Signed-off-by: Amos Kong ak...@redhat.com ---

[Qemu-devel] [PATCH v2 2/2] add parsing of strict boot parameter

2013-12-09 Thread Amos Kong
Commit 6ef4716cecdfa1b3794c1a33edba9840e1aa6b5f cleaned up the parse code of boot parameter, parse code of strict wasn't re-implemented, it caused that strict boot feature is always disabled. Signed-off-by: Amos Kong ak...@redhat.com --- vl.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [PATCH v2 1/2] fix a typo of strict option

2013-12-09 Thread Amos Kong
The type of strict should be bool. Signed-off-by: Amos Kong ak...@redhat.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index b0399de..12fe1f7 100644 --- a/vl.c +++ b/vl.c @@ -461,7 +461,7 @@ static QemuOptsList qemu_boot_opts = {

[Qemu-devel] [PATCH v2 0/2] fix strict boot regression

2013-12-09 Thread Amos Kong
parsing of strict is wrongly removed, we need it. The first patch fixes a typo. V2: remove bios.bin change, I just used it for testing (mjt) Amos Kong (2): fix a typo of strict option add parsing of strict boot parameter vl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH v2 0/2] fix strict boot regression

2013-12-09 Thread Michael Tokarev
09.12.2013 12:05, Amos Kong wrote: parsing of strict is wrongly removed, we need it. The first patch fixes a typo. V2: remove bios.bin change, I just used it for testing (mjt) Amos Kong (2): fix a typo of strict option add parsing of strict boot parameter vl.c |3 ++- 1

[Qemu-devel] [PATCH] vl: make boot_strict variable static (not used outside vl.c)

2013-12-09 Thread Michael Tokarev
--- vl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index ae6d0c6..e47fea1 100644 --- a/vl.c +++ b/vl.c @@ -230,7 +230,7 @@ int ctrl_grab = 0; unsigned int nb_prom_envs = 0; const char *prom_envs[MAX_PROM_ENVS]; int boot_menu; -bool boot_strict; +static

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-12-09 Thread Paolo Bonzini
Il 08/12/2013 12:21, Michael S. Tsirkin ha scritto: On Thu, Dec 05, 2013 at 06:53:50PM +0100, Paolo Bonzini wrote: Il 14/11/2013 11:37, Michael S. Tsirkin ha scritto: Several changes that affect compatibility between 1.8 and 1.7 are already planned, so we need pc compat structures in place.

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset

2013-12-09 Thread Fernando Luis Vázquez Cao
On 12/06/2013 11:22 PM, Marcelo Tosatti wrote: On Fri, Dec 06, 2013 at 05:24:18PM +0900, Fernando Luis Vázquez Cao wrote: I also wanted to make sure that the initialization that we do in kvm_arch_vcpu_postcreate on power up and the subsequent TSC writeback work well together, but I didn't have

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Marcel Apfelbaum
On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code. Signed-off-by: Igor Mammedov imamm...@redhat.com --- it's scsi-bus like interface, but abstracted from bus altogether

Re: [Qemu-devel] [PATCH 4/7] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-device interface

2013-12-09 Thread Marcel Apfelbaum
On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Split piix4_device_hotplug() into hotplug/unplug callbacks and register them as hotplug-device interface implementation of PIIX4_PM device. Replace pci_bus_hotplug() wiring with setting link on PCI BUS hotplug-device property to

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use hotplug-device interface.

2013-12-09 Thread Marcel Apfelbaum
On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci/pci.c | 70 + include/hw/pci/pci.h | 10 -- include/hw/pci/pci_bus.h |2 - 3 files changed, 51

Re: [Qemu-devel] [PATCH v2 1/2] fix a typo of strict option

2013-12-09 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: The type of strict should be bool. Signed-off-by: Amos Kong ak...@redhat.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index b0399de..12fe1f7 100644 --- a/vl.c +++ b/vl.c @@ -461,7 +461,7 @@ static

Re: [Qemu-devel] [PATCH] pci: fix pci bridge fw path

2013-12-09 Thread Marcel Apfelbaum
On Mon, 2013-12-09 at 08:14 +0100, Gerd Hoffmann wrote: On So, 2013-12-08 at 13:31 +0200, Michael S. Tsirkin wrote: On Fri, Dec 06, 2013 at 12:24:40PM +0100, Gerd Hoffmann wrote: qemu uses pci as name for pci bridges in the firmware device path. seabios expects pci-bridge. Result is that

Re: [Qemu-devel] [PATCH v2 2/2] add parsing of strict boot parameter

2013-12-09 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: Commit 6ef4716cecdfa1b3794c1a33edba9840e1aa6b5f cleaned up the parse code of boot parameter, parse code of strict wasn't re-implemented, it caused that strict boot feature is always disabled. Signed-off-by: Amos Kong ak...@redhat.com --- vl.c |1 +

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Marcel Apfelbaum
On Mon, 2013-12-09 at 13:40 +0800, Li Guang wrote: Hi, Igor Igor Mammedov wrote: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code. Signed-off-by: Igor Mammedovimamm...@redhat.com --- it's scsi-bus like interface,

Re: [Qemu-devel] [PULL 4/5] vfio-pci: Add debug config options to disable MSI/X KVM support

2013-12-09 Thread Paolo Bonzini
Il 06/12/2013 23:36, Alex Williamson ha scritto: #define VFIO_ALLOW_MMAP 1 #define VFIO_ALLOW_KVM_INTX 1 +#define VFIO_ALLOW_KVM_MSI 1 +#define VFIO_ALLOW_KVM_MSIX 1 Why not make these device properties instead? Honestly, I don't think they're that useful to the average or even

Re: [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions

2013-12-09 Thread Paolo Bonzini
Il 07/12/2013 00:27, Bandan Das ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Resetting should be done in post-order, not pre-order. However, qdev_walk_children and qbus_walk_children do not allow this. Fix it by adding two extra arguments to the functions. Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] pci: fix pci bridge fw path

2013-12-09 Thread Gerd Hoffmann
On Mo, 2013-12-09 at 11:24 +0200, Marcel Apfelbaum wrote: On Mon, 2013-12-09 at 08:14 +0100, Gerd Hoffmann wrote: On So, 2013-12-08 at 13:31 +0200, Michael S. Tsirkin wrote: On Fri, Dec 06, 2013 at 12:24:40PM +0100, Gerd Hoffmann wrote: qemu uses pci as name for pci bridges in the

Re: [Qemu-devel] [PATCH] pci: fix pci bridge fw path

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 08:14:30AM +0100, Gerd Hoffmann wrote: On So, 2013-12-08 at 13:31 +0200, Michael S. Tsirkin wrote: On Fri, Dec 06, 2013 at 12:24:40PM +0100, Gerd Hoffmann wrote: qemu uses pci as name for pci bridges in the firmware device path. seabios expects pci-bridge. Result

Re: [Qemu-devel] [PATCH] pci: fix pci bridge fw path

2013-12-09 Thread Michael S. Tsirkin
On Fri, Dec 06, 2013 at 12:24:40PM +0100, Gerd Hoffmann wrote: qemu uses pci as name for pci bridges in the firmware device path. seabios expects pci-bridge. Result is that bootorder is broken for devices behind pci bridges. Some googling suggests that pci-bridge is the correct one. At

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 09:38:47AM +0100, Paolo Bonzini wrote: Il 08/12/2013 12:21, Michael S. Tsirkin ha scritto: On Thu, Dec 05, 2013 at 06:53:50PM +0100, Paolo Bonzini wrote: Il 14/11/2013 11:37, Michael S. Tsirkin ha scritto: Several changes that affect compatibility between 1.8 and 1.7

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-09 Thread Kirill A. Shutemov
Kirill A. Shutemov wrote: Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 11:20:29AM +0100, Vincenzo Maffione wrote: Hello,    I've done some netperf TCP_STREAM and TCP_RR virtio-net tests, using the same configuration. Here are the results ## netperf TCP_STREAM ###     NO BATCHING BATCHING 1  5.5 Gbps 

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 11:24, Michael S. Tsirkin ha scritto: Both are in my PCI tree. git://github.com/mstsirkin/qemu.git doesn't have it, are you missing a push? My tree is here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci Thanks. Can you please add it to MAINTAINERS? You still

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Vincenzo Maffione
I totally agree with you, and we will propose a patch to make this possible. However, none of the offloadings you mentioned helps with packet rate throughput (checksum offload doesn't really help with short packets), which is the main purpose of this patch. High packet rates (say 1-5 Mpps) are

[Qemu-devel] [PATCH 2/2] usb-hid: add microsoft os descriptor support

2013-12-09 Thread Gerd Hoffmann
Set SelectiveSuspendEnabled registy entry to one. This makes Windows use remote suspend by default, without manual registry fiddeling. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-hid.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/usb/dev-hid.c

[Qemu-devel] [PATCH 1/2] usb: add support for microsoft os descriptors

2013-12-09 Thread Gerd Hoffmann
This patch adds support for special usb descriptors used by microsoft windows. They allow more fine-grained control over driver binding and adding entries to the registry for configuration. As this is a guest-visible change the msos-desc compat property has been added to turn this off for 1.7 +

Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 11:49:42AM +0100, Paolo Bonzini wrote: Il 09/12/2013 11:24, Michael S. Tsirkin ha scritto: Both are in my PCI tree. git://github.com/mstsirkin/qemu.git doesn't have it, are you missing a push? My tree is here:

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: I totally agree with you, and we will propose a patch to make this possible. However, none of the offloadings you mentioned helps with packet rate throughput (checksum offload doesn't really help with short packets), which is

Re: [Qemu-devel] [RFC PATCH 00/19] block: Support for 512b-on-4k emulation

2013-12-09 Thread Kevin Wolf
Am 06.12.2013 um 18:55 hat Paolo Bonzini geschrieben: Il 06/12/2013 18:22, Kevin Wolf ha scritto: This patch series adds code to the block layer that allows performing I/O requests in smaller granularities than required by the host backend (most importantly, O_DIRECT restrictions). It

Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-12-09 Thread Aneesh Kumar K.V
Kirill A. Shutemov kirill.shute...@linux.intel.com writes: Kirill A. Shutemov wrote: Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we

[Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716

2013-12-09 Thread Amos Kong
Commit 6ef4716 cleaned up parsing of -boot option argument, but accidentally dropped parameter strict. It should have been updated exactly like parameter menu. Do that. Signed-off-by: Amos Kong ak...@redhat.com --- v2: remove bios.bin change, I just used it for testing (mjt) v3: merge two

Re: [Qemu-devel] [PATCH v2 1/2] fix a typo of strict option

2013-12-09 Thread Amos Kong
On Mon, Dec 09, 2013 at 10:16:38AM +0100, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: The type of strict should be bool. Signed-off-by: Amos Kong ak...@redhat.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c

Re: [Qemu-devel] Keyboard interrupt routing from QEMU to guest OS

2013-12-09 Thread Samuel Thibault
Maryyam Muhammad Din, le Mon 09 Dec 2013 12:44:20 +0500, a écrit : I have gone through the source code of QEMU but could not figure out how external interrupts are handled by QEMU for guest. They aren't. It's the UI that manages keyboard etc. So it depends on the UI you are using. Unless you

Re: [Qemu-devel] [PATCH] vl: make boot_strict variable static (not used outside vl.c)

2013-12-09 Thread Amos Kong
On Mon, Dec 09, 2013 at 12:19:30PM +0400, Michael Tokarev wrote: --- vl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index ae6d0c6..e47fea1 100644 --- a/vl.c +++ b/vl.c @@ -230,7 +230,7 @@ int ctrl_grab = 0; unsigned int nb_prom_envs = 0; const

Re: [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716

2013-12-09 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: Commit 6ef4716 cleaned up parsing of -boot option argument, but accidentally dropped parameter strict. It should have been updated exactly like parameter menu. Do that. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Markus Armbruster

[Qemu-devel] [BUG] Windows 7 fails to start with new vgabios binaries

2013-12-09 Thread Gal Hammer
A Windows 7 (32-bit) VM running with QXL device fails to start with the new updated vgabios binaries (commit 6eefccc0bb9c34051b1e21880fc3a1c1c8686edd). qemu's command line: /usr/bin/qemu-kvm -m 1G -smp 1 -enable-kvm -usb -device usb-tablet \ -device

Re: [Qemu-devel] [PATCH v3] fix -boot strict regressed in commit 6ef4716

2013-12-09 Thread Michael Tokarev
09.12.2013 15:53, Amos Kong wrote: Commit 6ef4716 cleaned up parsing of -boot option argument, but accidentally dropped parameter strict. It should have been updated exactly like parameter menu. Do that. Signed-off-by: Amos Kong ak...@redhat.com --- v2: remove bios.bin change, I just used

Re: [Qemu-devel] outlined TLB lookup on x86

2013-12-09 Thread Xin Tong
On Thu, Nov 28, 2013 at 8:12 AM, Lluís Vilanova vilan...@ac.upc.edu wrote: Xin Tong writes: Hi LIuis we can probably generate vector intrinsics using the tcg, e.g. add support to tcg to emit vector instructions directly in code cache There was some discussion long ago about adding

Re: [Qemu-devel] [PATCH] HMP: snapshot_blkdev can not consider //root/sn1 and /root/sn1 as the same file

2013-12-09 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 02:06:21PM +0800, jun muzi wrote: If mount a local file(disk) in two different dirctories, it is similar to the network storage. Detecting identical files is still a problem. Such as: dd if=/dev/zero of=aa bs=1M count=10 mkfs.ext4 aa Then mount aa to two directories.

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Stefan Hajnoczi
On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: - This patch is against the net-next tree (https://github.com/stefanha/qemu.git) because the first netmap patch is not in the qemu master (AFAIK). You are right. I am sending a pull request now to get those patches

[Qemu-devel] [PATCH v3 04/13] target-arm: A64: add support for EXTR

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds emulation support for the EXTR instruction. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted for new decoder, removed a few temporaries, fixed the 32bit bug, added checks for more unallocated cases]

[Qemu-devel] [PATCH v3 10/13] target-arm: A64: add support for bitfield insns

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org This patch implements the C3.4.2 Bitfield instructions: SBFM, BFM, UBFM. Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Igor Mammedov
On Fri, 06 Dec 2013 18:26:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/12/2013 18:03, Igor Mammedov ha scritto: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Stefan Hajnoczi
On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: If you don't think adding the new flag support for virtio-net is a good idea (though TAP performance is not affected in every case) we could also make it

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Igor Mammedov
On Mon, 09 Dec 2013 13:40:04 +0800 Li Guang lig.f...@cn.fujitsu.com wrote: Hi, Igor Igor Mammedov wrote: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code. Signed-off-by: Igor Mammedovimamm...@redhat.com --- it's

[Qemu-devel] [PATCH] scsi-disk: fix WRITE SAME with large non-zero payload

2013-12-09 Thread Paolo Bonzini
Due to a thinko in the patch that implemented WRITE SAME. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 6904ac2..7653411 100644 --- a/hw/scsi/scsi-disk.c

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-09 Thread Don Slutz
On 12/05/13 22:20, Don Slutz wrote: On 12/05/13 16:24, Richard Henderson wrote: On 12/06/2013 04:18 AM, Paolo Bonzini wrote: $ gcc -shared -o f.so f.c -fPIE -fPIC /usr/bin/ld: /tmp/ccQc9els.o: relocation R_X86_64_PC32 against `f' can not be used when making a shared object; recompile with

Re: [Qemu-devel] [RFC PATCH 00/19] block: Support for 512b-on-4k emulation

2013-12-09 Thread Stefan Hajnoczi
On Fri, Dec 06, 2013 at 06:22:41PM +0100, Kevin Wolf wrote: This series does not cover 4k guests on a 512 byte host, and I'm not sure yet what to do with this case. Paolos series contained a patch to protect against torn reads (i.e. reads running in parallel with writes, which return old data

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Igor Mammedov
On Mon, 09 Dec 2013 10:58:04 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v3 08/13] target-arm: A64: add support for 1-src RBIT insn

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This adds support for the C5.6.147 RBIT instruction. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder, use bswap64, make RBIT part standalone from the rest of the patch, splitting REV into a separate patch]

[Qemu-devel] [PATCH v3 00/13] target-arm: A64 decoder set 2: misc logic and bit ops

2013-12-09 Thread Peter Maydell
Third revision of the second chunk of A64 decoder patches: a grabbag of miscellaneous logic and bit-twiddling operations, plus some other minor stuff like ADR and conditional-select. Changes v2-v3: * patch 1/13: added the special case of rd==31 to avoid the dead temporary across basic blocks

[Qemu-devel] [PATCH v3 01/13] target-arm: A64: add support for conditional select

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org This patch adds support for the instruction group C3.5.6 Conditional select: CSEL, CSINC, CSINV, CSNEG. Signed-off-by: Claudio Fontana claudio.font...@linaro.org [PMM: Improved code generated in the nomatch case as per RTH suggestions]

[Qemu-devel] [PATCH v3 11/13] host-utils: add clrsb32/64 - count leading redundant sign bits

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org this patch introduces wrappers for the clrsb builtins, which count the leading redundant sign bits. Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson

[Qemu-devel] [PATCH v3 05/13] target-arm: A64: add support for 2-src data processing and DIV

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds support for decoding 2-src data processing insns, and the first users, UDIV and SDIV. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder adding the 2-src decoding level, always zero-extend result in 32bit

[Qemu-devel] [PATCH v3 13/13] target-arm: A64: add support for logical (immediate) insns

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds support for C3.4.4 Logical (immediate), which include AND, ANDS, ORR, EOR. Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder, function renaming, removed a TCG temp variable] Signed-off-by: Claudio Fontana

[Qemu-devel] [PATCH v3 06/13] target-arm: A64: add support for 2-src shift reg insns

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This adds 2-src variable shift register instructions: C5.6.115 LSLV, C5.6.118 LSRV, C5.6.17 ASRV, C5.6.154 RORV Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder, use enums for shift types] Signed-off-by: Claudio Fontana

[Qemu-devel] [PATCH v3 07/13] target-arm: A64: add support for 1-src data processing and CLZ

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org This patch adds support for decoding 1-src data processing insns, and the first user, C5.6.40 CLZ (count leading zeroes). Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by:

[Qemu-devel] [PATCH v3 09/13] target-arm: A64: add support for 1-src REV insns

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org This adds support for C5.6.149 REV, C5.6.151 REV32, C5.6.150 REV16. Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net ---

[Qemu-devel] [PATCH v3 03/13] target-arm: A64: add support for ADR and ADRP

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Add support for the instructions described in C3.4.6 PC-rel. addressing (ADR and ADRP). Signed-off-by: Alexander Graf ag...@suse.de [claudio: adapted to new decoder structure] Signed-off-by: Claudio Fontana claudio.font...@linaro.org Reviewed-by: Richard

[Qemu-devel] [PULL 3/5] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}

2013-12-09 Thread Paolo Bonzini
From: Peter Lieven p...@kamp.de this converts read, write and flush functions from aio to coroutines eliminating almost 200 lines of code. The requirement for libiscsi is bumped to version 1.4.0 which was released in may 2012. Signed-off-by: Peter Lieven p...@kamp.de Signed-off-by: Paolo

[Qemu-devel] [PULL 1/5] scsi-bus: fix transfer length and direction for VERIFY command

2013-12-09 Thread Paolo Bonzini
The amount of bytes to transfer depends on the BYTCHK field. If any data is transferred, it is sent to the device. Cc: qemu-sta...@nongnu.org Tested-by: Hervé Poussineau hpous...@reactos.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 14 +- 1 file

Re: [Qemu-devel] [RFC PATCH 05/19] raw: Probe required direct I/O alignment

2013-12-09 Thread Kevin Wolf
Am 06.12.2013 um 18:53 hat Paolo Bonzini geschrieben: Il 06/12/2013 18:22, Kevin Wolf ha scritto: @@ -1227,6 +1288,7 @@ static BlockDriver bdrv_file = { .bdrv_aio_writev = raw_aio_writev, .bdrv_aio_flush = raw_aio_flush, .bdrv_aio_discard = raw_aio_discard, +

Re: [Qemu-devel] [RFC PATCH 00/19] block: Support for 512b-on-4k emulation

2013-12-09 Thread Kevin Wolf
Am 09.12.2013 um 13:51 hat Stefan Hajnoczi geschrieben: On Fri, Dec 06, 2013 at 06:22:41PM +0100, Kevin Wolf wrote: This series does not cover 4k guests on a 512 byte host, and I'm not sure yet what to do with this case. Paolos series contained a patch to protect against torn reads (i.e.

[Qemu-devel] [PULL 0/5] SCSI patches for 2013-12-09

2013-12-09 Thread Paolo Bonzini
Anthony, The following changes since commit ac9524dc55dc32e492ac3e6fbc9785be7168f8a2: qemu-iotests: filter QEMU monitor \r\n (2013-12-06 16:53:51 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to

[Qemu-devel] [PULL 2/5] scsi-disk: fix VERIFY emulation

2013-12-09 Thread Paolo Bonzini
VERIFY emulation was completely botched (and remained botched through all the refactorings). The command must be emulated both in check-medium mode (BYTCHK=00, which we implement by doing nothing) and in check-bytes mode (which we do not implement yet). Unlike WRITE AND VERIFY (which we treat

[Qemu-devel] [PULL 4/5] scsi-disk: fix WRITE SAME with large non-zero payload

2013-12-09 Thread Paolo Bonzini
Due to a thinko in the patch that implemented WRITE SAME. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 6904ac2..7653411 100644 --- a/hw/scsi/scsi-disk.c

[Qemu-devel] [PULL 5/5] help: add id suboption to -iscsi

2013-12-09 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8b94264..7f12f02 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2089,7 +2089,7 @@ ETEXI DEF(iscsi, HAS_ARG,

Re: [Qemu-devel] [PATCH] sheepdog: check if '-o redundancy' is passed from user

2013-12-09 Thread Kevin Wolf
Am 08.12.2013 um 17:11 hat Liu Yuan geschrieben: This fix a segfault (that is caused by b3af018f3) of following command: $ qemu-img convert some_img sheepdog:some_img Cc: qemu-devel@nongnu.org Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan

[Qemu-devel] [PULL 1/4] net: Adding netmap network backend

2013-12-09 Thread Stefan Hajnoczi
From: Vincenzo Maffione v.maffi...@gmail.com This patch adds support for a network backend based on netmap. netmap is a framework for high speed packet I/O. You can use it to build extremely fast traffic generators, monitors, software switches or network middleboxes. Its companion software switch

[Qemu-devel] [PULL 4/4] net: Update netdev peer on link change

2013-12-09 Thread Stefan Hajnoczi
From: Vlad Yasevich vyase...@redhat.com When a link change occurs on a backend (like tap), we currently do not propage such change to the nic. As a result, when someone turns off a link on a tap device, for instance, then a guest doesn't see that change and continues to try to send traffic or

[Qemu-devel] [PULL 0/4] Net patches

2013-12-09 Thread Stefan Hajnoczi
The following changes since commit a1d22a367d5780c9553b2cd5a24f665534ce6ed6: target-cris: Use new qemu_ld/st opcodes (2013-12-08 09:36:02 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git net-next for you to fetch changes up to

[Qemu-devel] [PULL 3/4] virtio-net: don't update mac_table in error state

2013-12-09 Thread Stefan Hajnoczi
From: Amos Kong ak...@redhat.com mac_table was always cleaned up first in handling VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover mac_table content in error state, it's not correct. This patch makes all the changes in temporal variables, only update the real mac_table if everything

[Qemu-devel] [PULL 2/4] MAINTAINERS: Add netmap maintainers

2013-12-09 Thread Stefan Hajnoczi
From: Vincenzo Maffione v.maffi...@gmail.com Signed-off-by: Vincenzo Maffione v.maffi...@gmail.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e61ac8..7eed206 100644 ---

Re: [Qemu-devel] [PATCH 1/7] define hotplug interface

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 13:42, Igor Mammedov ha scritto: On Fri, 06 Dec 2013 18:26:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/12/2013 18:03, Igor Mammedov ha scritto: Provide generic hotplug interface for devices. Intended for replacing hotplug mechanism used by PCI/PCIE/SHPC code.

Re: [Qemu-devel] [BUG] Windows 7 fails to start with new vgabios binaries

2013-12-09 Thread Gerd Hoffmann
On Mo, 2013-12-09 at 14:18 +0200, Gal Hammer wrote: A Windows 7 (32-bit) VM running with QXL device fails to start with the new updated vgabios binaries (commit 6eefccc0bb9c34051b1e21880fc3a1c1c8686edd). qemu's command line: /usr/bin/qemu-kvm -m 1G -smp 1 -enable-kvm -usb -device

[Qemu-devel] [PATCH v3 02/13] target-arm: A64: add support for logical (shifted register)

2013-12-09 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Add support for the instructions described in C3.5.10 Logical (shifted register). We store the flags in the same locations as the 32 bit decoder. This is slightly awkward when calculating 64 bit results, but seems a better tradeoff than having to rework the

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 13:47, Don Slutz ha scritto: On 12/05/13 22:20, Don Slutz wrote: On 12/05/13 16:24, Richard Henderson wrote: On 12/06/2013 04:18 AM, Paolo Bonzini wrote: $ gcc -shared -o f.so f.c -fPIE -fPIC /usr/bin/ld: /tmp/ccQc9els.o: relocation R_X86_64_PC32 against `f' can not be used

Re: [Qemu-devel] [PATCH 4/7] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-device interface

2013-12-09 Thread Igor Mammedov
On Mon, 09 Dec 2013 11:02:29 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Split piix4_device_hotplug() into hotplug/unplug callbacks and register them as hotplug-device interface implementation of PIIX4_PM device. Replace

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Vincenzo Maffione
2013/12/9 Stefan Hajnoczi stefa...@gmail.com On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: If you don't think adding the new flag support for virtio-net is a good idea (though TAP performance is not

[Qemu-devel] [PATCH v3 12/13] target-arm: A64: add support for 1-src CLS insn

2013-12-09 Thread Peter Maydell
From: Claudio Fontana claudio.font...@linaro.org this patch adds support for the CLS instruction. Signed-off-by: Claudio Fontana claudio.font...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net --- target-arm/helper-a64.c| 10

[Qemu-devel] [PATCH] seavgabios: turn off stack switching

2013-12-09 Thread Gerd Hoffmann
seavgabios stack switching broke windows guests. Turn it off (CONFIG_VGA_ALLOCATE_EXTRA_STACK=n), update binaries, to unbreak things. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- pc-bios/vgabios-cirrus.bin | Bin 36864 - 36352 bytes pc-bios/vgabios-qxl.bin| Bin 37376 - 36864 bytes

Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.

2013-12-09 Thread Benoît Canet
Le Friday 06 Dec 2013 à 11:52:15 (-0500), Luiz Capitulino a écrit : On Fri, 06 Dec 2013 08:24:33 -0700 Eric Blake ebl...@redhat.com wrote: On 12/06/2013 07:27 AM, Luiz Capitulino wrote: On Thu, 5 Dec 2013 18:15:00 +0100 Benoît Canet ben...@irqsave.net wrote: -{ 'command':

[Qemu-devel] [PULL] libcacard fixes

2013-12-09 Thread Alon Levy
Anthony, The following changes since commit a1d22a367d5780c9553b2cd5a24f665534ce6ed6: target-cris: Use new qemu_ld/st opcodes (2013-12-08 09:36:02 +0100) are available in the git repository at: git://people.freedesktop.org/~alon/qemu libcacard_ccid.4 for you to fetch changes up to

[Qemu-devel] [PULL] libcacard: Fix compilation for older versions of glib (bug #1258168)

2013-12-09 Thread Alon Levy
From: Stefan Weil s...@weilnetz.de See https://bugs.launchpad.net/bugs/1258168 libcacard/vscclient.c: In function 'do_socket_read': libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached' libcacard/vscclient.c:410: warning: nested extern declaration of

Re: [Qemu-devel] [RFC PATCH 05/19] raw: Probe required direct I/O alignment

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 13:58, Kevin Wolf ha scritto: How is BlockLimits supposed with respect to inheritance of values through the BDS tree? I think right now the accessor wrappers for the various BlockLimits field sort that out. Of course this could be slow if the accessors end up in the fast path

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use hotplug-device interface.

2013-12-09 Thread Igor Mammedov
On Fri, 06 Dec 2013 18:29:58 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/12/2013 18:03, Igor Mammedov ha scritto: +hotplug_dev = DEVICE(object_property_get_link(OBJECT(bus), hotplug-device, + local_err)); +if

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use hotplug-device interface.

2013-12-09 Thread Paolo Bonzini
Il 09/12/2013 14:41, Igor Mammedov ha scritto: Please move the parts under the if to hotplug.c (something like hotplug_handler_plug and hotplug_handler_unplug). Also, should this be sure. moved up to generic code (e.g. bus_add_child/bus_remove_child)? Current usage hints that it's more

Re: [Qemu-devel] [PATCH v3 08/12] target-arm: A64: add support for B and BL insns

2013-12-09 Thread Peter Maydell
On 5 December 2013 12:39, Peter Maydell peter.mayd...@linaro.org wrote: From: Alexander Graf ag...@suse.de Implement the B and BL instructions (PC relative branches and calls). For convenience in managing TCG temporaries which might be generated if a source register is the zero-register XZR,

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 01:42:30PM +0100, Stefan Hajnoczi wrote: On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: If you don't think adding the new flag support for virtio-net is a good idea (though

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use hotplug-device interface.

2013-12-09 Thread Igor Mammedov
On Mon, 09 Dec 2013 11:09:02 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci/pci.c | 70 +

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 02:25:46PM +0100, Vincenzo Maffione wrote: 2013/12/9 Stefan Hajnoczi stefa...@gmail.com On Mon, Dec 09, 2013 at 01:14:31PM +0200, Michael S. Tsirkin wrote: On Mon, Dec 09, 2013 at 11:55:57AM +0100, Vincenzo Maffione wrote: If you don't think

Re: [Qemu-devel] [PATCH] net: QEMU_NET_PACKET_FLAG_MORE introduced

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 01:36:54PM +0100, Stefan Hajnoczi wrote: On Fri, Dec 06, 2013 at 03:44:33PM +0100, Vincenzo Maffione wrote: - This patch is against the net-next tree (https://github.com/stefanha/qemu.git) because the first netmap patch is not in the qemu master (AFAIK).

Re: [Qemu-devel] [PATCH 7/7] hw/pci: convert PCI bus to use hotplug-device interface.

2013-12-09 Thread Marcel Apfelbaum
On Mon, 2013-12-09 at 14:55 +0100, Igor Mammedov wrote: On Mon, 09 Dec 2013 11:09:02 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Fri, 2013-12-06 at 18:03 +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/pci/pci.c | 70

[Qemu-devel] [PATCH 1/4] audio: Lower default wakeup rate to 100 times / second

2013-12-09 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com This is more then plenty to keep audio card fifos filles / emptied. This drops host cpu-load for audio playback inside a linux vm from 13% to 9%. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PULL 0/4] audio patch queue

2013-12-09 Thread Gerd Hoffmann
Hi, Here comes the audio patch queue. please pull, Gerd The following changes since commit a1d22a367d5780c9553b2cd5a24f665534ce6ed6: target-cris: Use new qemu_ld/st opcodes (2013-12-08 09:36:02 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-audio-1

[Qemu-devel] [PATCH 2/4] audio: adjust pulse to 100Hz wakeup rate

2013-12-09 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- audio/paaudio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 8b69778..90ff245 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -547,11 +547,11 @@ static int qpa_init_out

[Qemu-devel] [PATCH 4/4] intel-hda: fix position buffer

2013-12-09 Thread Gerd Hoffmann
Fix position buffer updates to use the correct stream offset. Without this patch both IN (record) and OUT (playback) streams will update the IN buffer positions. The linux kernel notices and complains: hda-intel: Invalid position buffer, using LPIB read method instead. The bug may also lead

[Qemu-devel] [PATCH 3/4] adlib: fix patching of port I/O addresses

2013-12-09 Thread Gerd Hoffmann
From: Paolo Bonzini pbonz...@redhat.com Commit 2b21fb5 (adlib: sort offsets in portio registration, 2013-08-14) fixed the offsets in adlib_portio_list, but forgot the matching indices in adlib_realizefn. Reported at http://virtuallyfun.superglobalmegacorp.com/?p=3616 by neozeed. Signed-off-by:

[Qemu-devel] [PATCH RFC 0/2] improve rng-egd perf

2013-12-09 Thread Amos Kong
This patchset try to improve rng-egd backends performance by pre-reading data to buffer from egd socket. We can't improve the performance by too large buffer, so I set the patchset as RFC. We might have better solution for this. Amos Kong (2): rng-egd: improve egd backend performance

  1   2   3   >