Re: [Qemu-devel] detecting -enable-fips

2013-12-13 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/12/2013 22:04, Eric Blake ha scritto: Commit 0f66998 added the command line option -enable-fips for qemu 1.2; but as of at least qemu 1.6, the 'query-command-line-options' QMP monitor command does not report it. This is particularly

Re: [Qemu-devel] [libvirt] [PATCH] qemu: always ask for -enable-fips

2013-12-13 Thread Eric Blake
On 12/13/2013 08:15 AM, Daniel P. Berrange wrote: QEMU already detects current FIPs enablement via the file /proc/sys/crypto/fips_enabled, but only if you use --enable-fips. This is really stupid given that all the crypto libraries that QEMU uses unconditonally look at the proc file. So by

[Qemu-devel] [PATCH 01/11] acpi: piix4: remove not needed GPE0 mask

2013-12-13 Thread Igor Mammedov
Hardcoded GPE0 mask isn't really needed. Since GPE0_STS initialized with all bits cleared and only QEMU itself can set bits there (i.e. guest can only clear bits in it). So guest can't triger SCI by setting _STS _EN bits and there is not reason to mask out not supported _STS bits since they

Re: [Qemu-devel] [Spice-devel] Vdagent not working on xen linux hvm DomUs

2013-12-13 Thread Wei Liu
On Fri, Dec 13, 2013 at 10:51:01AM +0100, Fabio Fantoni wrote: Il 12/12/2013 17:05, Fabio Fantoni ha scritto: Il 12/12/2013 16:23, Wei Liu ha scritto: On Thu, Dec 12, 2013 at 02:10:23PM +0100, Fabio Fantoni wrote: [...] I did some other tests, I narrowed down the commit range to the one

[Qemu-devel] [PATCH 06/11] acpi/ich9: add CPU hotplug handling to Q35 machine

2013-12-13 Thread Igor Mammedov
.. including readonly 'cpu-hotplug-io-base' property Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/ich9.c | 27 +++ include/hw/acpi/ich9.h | 4 2 files changed, 31 insertions(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index

[Qemu-devel] [PATCH 04/11] acpi/piix4: add readonly cpu-hotplug-io-base property

2013-12-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/piix4.c | 11 +++ include/hw/acpi/hotplug.h | 1 + 2 files changed, 12 insertions(+) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 8ab85b2..8db0920 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -31,6

[Qemu-devel] [PATCH 09/11] ACPI: move PRST OperationRegion into SSDT

2013-12-13 Thread Igor Mammedov
.. and report range used by it to OSPM via _CRS. PRST is needed in SSDT since its base will depend on chipset and will be dynamically set by QEMU. Also move PRSC() method along with PRST since cross table reference to PRST doesn't work. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

[Qemu-devel] [PATCH 08/11] ACPI/DSDT-CPU: cleanup bogus comment

2013-12-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl index c96ac42..995b415 100644 --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl +++

[Qemu-devel] [PATCH 07/11] ACPI: Q35 DSDT: fix CPU hotplug GPE0.2 handler

2013-12-13 Thread Igor Mammedov
Fix bogus CPU hotplug GPE handler. Make Q35 CPU hotplug GPE handler match PIIX4 one, since CPU hotplug event is triggered by GPE0.2 register. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/q35-acpi-dsdt.dsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 03/11] acpi: factor out common cpu hotplug code for PIIX4/Q35

2013-12-13 Thread Igor Mammedov
.. so it could be used for adding CPU hotplug to Q35 machine Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/Makefile.objs | 2 +- hw/acpi/hotplug.c | 65 +++ hw/acpi/piix4.c | 78

[Qemu-devel] [PATCH 11/11] ACPI: update ssdt-misc.hex.generated acpi-dsdt.hex.generated q35-acpi-dsdt.hex.generated

2013-12-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-dsdt.hex.generated | 152 ++--- hw/i386/q35-acpi-dsdt.hex.generated | 168 +++ hw/i386/ssdt-misc.hex.generated | 262 +++- 3 files changed, 290

Re: [Qemu-devel] [PULL 00/30] virtio conversion to realize and hotplug/unplug fixes

2013-12-13 Thread Anthony Liguori
On Dec 13, 2013 7:50 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/12/2013 08:45, Paolo Bonzini ha scritto: Anthony, the following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) This also conflicts

[Qemu-devel] [PATCH v5 01/22] blkdebug: Use errp for read_config()

2013-12-13 Thread Max Reitz
Use an Error variable in the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 957be2c..627e29d 100644 --- a/block/blkdebug.c +++

[Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration

2013-12-13 Thread Max Reitz
Currently, the configuration of blkdebug and blkverify is done through the filename alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts with the protocol prefix, follows up with the name of

[Qemu-devel] [PATCH v5 02/22] blkdebug: Don't require sophisticated filename

2013-12-13 Thread Max Reitz
If the filename is not prefixed by blkdebug: in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a problem at all; we just

[Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists

2013-12-13 Thread Max Reitz
Reversing qdict_array_split(), qdict_flatten() should flatten QLists as well by interpreting them as QDicts where every entry's key is its index. This allows bringing QDicts with QLists from QMP commands to the same form as they would be given as command-line options, thereby allowing them to be

[Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051

2013-12-13 Thread Max Reitz
Allowing nested file formats now results in e.g. qcow2 BlockDriverStates never being directly passed to bdrv_open_common() from bdrv_file_open(), but instead being handed through bdrv_open(). This changes the error message when trying to give a filename to qcow2, i.e. trying to use it as a driver

[Qemu-devel] [PATCH v5 03/22] qdict: Add qdict_array_split()

2013-12-13 Thread Max Reitz
This function splits a QDict consisting of entries prefixed by incrementally enumerated indices into a QList of QDicts. Signed-off-by: Max Reitz mre...@redhat.com --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c | 36 2 files changed, 37

[Qemu-devel] [PATCH v5 06/22] qemu-option: Add qemu_config_parse_qdict()

2013-12-13 Thread Max Reitz
This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {section.opt1: 42, section.opt2: 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also multiple sections of the

[Qemu-devel] [PATCH v5 10/22] block: Pass reference to bdrv_file_open()

2013-12-13 Thread Max Reitz
With that now being possible, bdrv_open() should try to extract a block device reference from the options and pass it to bdrv_file_open(). Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration

2013-12-13 Thread Max Reitz
Introduce the image option as an alternative to specifying the image through the filename. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c

[Qemu-devel] [PATCH] roms: remove explicit MAKEFLAGS from recursive make invocations

2013-12-13 Thread Bruce Rogers
When using $(MAKE) within a makefile, we shouldn't be explicitly including $(MAKEFLAGS) on the command-line. It causes problems when that makefile is recursively invoked. When the roms/Makefile is invoked as in make -C roms bios a spurious 'w' appears on the sub-make invocation, due to the

[Qemu-devel] [PATCH v5 14/22] blockdev: Move file to legacy_opts

2013-12-13 Thread Max Reitz
Specifying the image filename through the file option is a legacy option and should not be supported by blockdev-add (in that case, giving a string for file references an existing block device). Signed-off-by: Max Reitz mre...@redhat.com --- blockdev.c | 19 ++- 1 file changed,

[Qemu-devel] [PATCH v5 16/22] blkdebug: Make filename optional

2013-12-13 Thread Max Reitz
There is no problem in giving no filename; in this case, it has to be specified through the image option. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index

[Qemu-devel] [PATCH v5 18/22] blkverify: Don't require protocol filename

2013-12-13 Thread Max Reitz
If the filename is not prefixed by blkverify: in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line (or QMP) option (like driver=blkverify). Contrary to the current reaction, this is no longer a problem; both images may

[Qemu-devel] [PATCH v5 17/22] blkverify: Allow command-line configuration

2013-12-13 Thread Max Reitz
Introduce the test and raw options for specifying images. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkverify.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index

[Qemu-devel] [PATCH v5 21/22] qemu-io: Make filename optional

2013-12-13 Thread Max Reitz
Giving a filename is actually not essential, since it can be specified through the options as well - on the contrary: Sometimes a filename must not be given. Signed-off-by: Max Reitz mre...@redhat.com --- qemu-io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

2013-12-13 Thread Max Reitz
delete is always set to true, therefore it can be removed. Signed-off-by: Max Reitz mre...@redhat.com --- qobject/qdict.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 1d0e66c..ec42b1c 100644 --- a/qobject/qdict.c

[Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Max Reitz
Add structures to support blkdebug and blkverify in blockdev-add. Signed-off-by: Max Reitz mre...@redhat.com --- qapi-schema.json | 94 +--- 1 file changed, 90 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json

[Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface

2013-12-13 Thread Max Reitz
Add a test for the new blkdebug/blkverify interface. This test is not written in Python, although it uses QMP. This is because it invokes the qemu-io HMP command, which outputs errors to stderr instead of returning them through QMP. Filtering and testing that output is easier in a shell script

[Qemu-devel] [PATCH 00/11] pc: CPU hotplug support for Q35

2013-12-13 Thread Igor Mammedov
Tested with RHEL6 WS2012R2 git tree for testing: https://github.com/imammedo/qemu/commits/q35_cpu_hp_v1 Igor Mammedov (11): acpi: piix4: remove not needed GPE0 mask acpi: factor out common pm_update_sci() into acpi core acpi: factor out common cpu hotplug code for PIIX4/Q35

Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration

2013-12-13 Thread Max Reitz
Sorry, the subject should say v5, obviously (but since the patches itself are fine, I hope it is okay not to resend the series). Max

[Qemu-devel] [PATCH v5 07/22] blkdebug: Always call read_config()

2013-12-13 Thread Max Reitz
Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c

[Qemu-devel] [PATCH] sheepdog: fix dynamic grow for running qcow2 format

2013-12-13 Thread Liu Yuan
When running qcow2 over sheepdog, we might meet following problem qemu-system-x86_64: shrinking is not supported And cause IO errors to Guest. This is because we abuse bs-total_sectors, which is manipulated by generic block layer and race with sheepdog code. We should directly check if offset

[Qemu-devel] [PATCH v5 12/22] block: Allow recursive files

2013-12-13 Thread Max Reitz
It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PULL 3/6] block/vvfat: Fix compiler warnings for OpenBSD

2013-12-13 Thread Kevin Wolf
From: Stefan Weil s...@weilnetz.de The buildbot shows these compiler warnings: block/vvfat.c: In function 'create_short_and_long_name': block/vvfat.c:620: warning: array size (8) smaller than bound length (11) block/vvfat.c:620: warning: array size (8) smaller than bound length (11)

[Qemu-devel] [PULL 1/6] sheepdog: check if '-o redundancy' is passed from user

2013-12-13 Thread Kevin Wolf
From: Liu Yuan namei.u...@gmail.com This fix a segfault (that is caused by b3af018f3) of following command: $ qemu-img convert some_img sheepdog:some_img Cc: qemu-devel@nongnu.org Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan

[Qemu-devel] [PULL 0/6] Block patches

2013-12-13 Thread Kevin Wolf
The following changes since commit 47acdd63a33a5966bf4fc94a6ac835d72a70c555: target-microblaze: Use the new qemu_ld/st opcodes (2013-12-13 10:00:42 +1000) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-anthony for you to fetch changes up to

[Qemu-devel] [PATCH v5 08/22] blkdebug: Use command-line in read_config()

2013-12-13 Thread Max Reitz
Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index

[Qemu-devel] [PULL 5/6] qemu-img: make progress output more accurate during convert

2013-12-13 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de the progress output is very bumpy if the input images contains a significant portion of unallocated sectors. This patch checks how much sectors are allocated a priori if progress output is selected. Signed-off-by: Peter Lieven p...@kamp.de Signed-off-by: Kevin

[Qemu-devel] [Bug 1259499] Re: QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64

2013-12-13 Thread Dr. David Alan Gilbert
Hi Francois, I've done some more digging. It looks like the problem you've hit is related to the same one that's fixed by: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg00513.html however that only fixes older restores ; there is a work around which is to pass to QEMU: -global

[Qemu-devel] [PULL 2/6] qapi-schema.json: Change 1.8 reference to 2.0

2013-12-13 Thread Kevin Wolf
Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index d6f8615..c3c939c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -949,7

[Qemu-devel] [PULL 4/6] block: expect get_block_status errors in bdrv_make_zero

2013-12-13 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an infinite loop. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 6/6] blkdebug: Use QLIST_FOREACH_SAFE to resume IO

2013-12-13 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Qemu-iotest 030 was broken. When the coroutine runs and finishes, it will remove itself from the req list, so let's use safe version of foreach to avoid use after free. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH v5 09/22] block: Allow reference for bdrv_file_open()

2013-12-13 Thread Max Reitz
Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 25 ++--- block/blkdebug.c | 2 +- block/blkverify.c | 2 +-

[Qemu-devel] [PATCH v5 11/22] block: Allow block devices without files

2013-12-13 Thread Max Reitz
blkdebug and blkverify will, in order to retain compatibility, not support the field file implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is necessary to be able to have block devices without files implicitly opened by bdrv_open(). This

[Qemu-devel] [PATCH 02/11] acpi: factor out common pm_update_sci() into acpi core

2013-12-13 Thread Igor Mammedov
... and rename it into acpi_update_sci() since it changes SCI on only on PM registers status. Signed-off-by: Igor Mammedov imamm...@redhat.com --- --- hw/acpi/core.c | 18 ++ hw/acpi/ich9.c | 23 ++- hw/acpi/piix4.c| 26

[Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI rised by GPE

2013-12-13 Thread Igor Mammedov
it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/acpi/ich9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index dcdef7c..30f0df8 100644 ---

[Qemu-devel] [PATCH v5 19/22] blkdebug: Alias errno as error

2013-12-13 Thread Max Reitz
Introduce an alias error for errno, since using the latter for QMP is sure to result in various syntax errors due to the name being used directly as an identifier. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer

2013-12-13 Thread Kevin Wolf
Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben: If active is top, it will be mirrored to base, (with block/mirror.c code), then the image is switched when user completes the block job. QMP documentation is updated. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 11

Re: [Qemu-devel] [PATCH v6 0/6] block: allow commit active as top

2013-12-13 Thread Kevin Wolf
Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben: Previously live commit of active block device is not supported, this series implements it and updates corresponding qemu-iotests cases. This series is based on BlockJobType enum QAPI series. v6: Address comments from Stefan: [04/06]

[Qemu-devel] [PATCH 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

2013-12-13 Thread Mark Cave-Ayland
This patchset provides QEMU with an implementation of the Sun CG3 8-bit framebuffer. It is based upon Bob Breuer's original work which has been rebased onto git master, and is now capable of running with an OpenBIOS CG3 FCode ROM instead of requiring copies of proprietary Sun ROMs. The

[Qemu-devel] [PATCH 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2013-12-13 Thread Mark Cave-Ayland
In order to allow the user to choose the framebuffer for sparc-softmmu, add -vga tcx and -vga cg3 options to the QEMU command line. If no option is specified, the default TCX framebuffer is used. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk CC: Blue Swirl blauwir...@gmail.com CC:

[Qemu-devel] [PATCH 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2013-12-13 Thread Mark Cave-Ayland
The CG3 framebuffer is a simple 8-bit framebuffer for use with operating systems such as early Solaris that do not have drivers for TCX. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk CC: Blue Swirl blauwir...@gmail.com CC: Anthony Liguori aligu...@amazon.com CC: Bob Breuer

Re: [Qemu-devel] [PATCH] [PATCH RFC v4] qemu-monitor: HMP cpu-add wrapper

2013-12-13 Thread Igor Mammedov
On Wed, 11 Dec 2013 13:24:14 -0500 Jason J. Herne jjhe...@us.ibm.com wrote: From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hmp-commands.hx | 13 + hmp.c |

Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: delete is always set to true, therefore it can be removed. Signed-off-by: Max Reitz mre...@redhat.com Nope, this can't be right. delete is always set, except for simple types in the top-level QDict. They get deleted now instead of being left

Re: [Qemu-devel] [PATCH v5 01/22] blkdebug: Use errp for read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Use an Error variable in the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v5 02/22] blkdebug: Don't require sophisticated filename

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: If the filename is not prefixed by blkdebug: in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the

Re: [Qemu-devel] [PATCH v5 03/22] qdict: Add qdict_array_split()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: This function splits a QDict consisting of entries prefixed by incrementally enumerated indices into a QList of QDicts. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Reversing qdict_array_split(), qdict_flatten() should flatten QLists as well by interpreting them as QDicts where every entry's key is its index. This allows bringing QDicts with QLists from QMP commands to the same form as they would be

Re: [Qemu-devel] [PATCH v5 07/22] blkdebug: Always call read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH 10/11] ACPI: set CPU hotplug io base dynamically

2013-12-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/acpi-build.c | 6 ++ hw/i386/ssdt-misc.dsl | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index befc39f..bfd34d7 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@

[Qemu-devel] [PATCH v3 8/8] target-arm: A64: implement SVC, BRK

2013-12-13 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Add decoding for the exception generating instructions, and implement SVC (syscalls) and BRK (software breakpoint). Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v3 7/8] target-arm: A64: add support for 3 src data proc insns

2013-12-13 Thread Peter Maydell
From: Alexander Graf ag...@suse.de This patch adds emulation for the Data-processing (3 source) family of instructions, namely MADD, MSUB, SMADDL, SMSUBL, SMULH, UMADDL, UMSUBL, UMULH. Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by:

[Qemu-devel] [PATCH v3 2/8] target-arm: A64: add support for ld/st unsigned imm

2013-12-13 Thread Peter Maydell
From: Alex Bennée a...@bennee.com This adds support for the forms of ld/st with a 12 bit unsigned immediate offset. Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 89

[Qemu-devel] [PATCH v3 1/8] target-arm: A64: add support for ld/st pair

2013-12-13 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org This patch support the basic load and store pair instructions and includes the generic helper functions: * do_gpr_st() * do_fp_st() * do_gpr_ld() * do_fp_ld() * read_cpu_reg_sp() * gen_check_sp_alignment() The last function

[Qemu-devel] [PATCH v3 6/8] target-arm: A64: add support for move wide instructions

2013-12-13 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org This patch adds emulation for the mov wide instructions (MOVN, MOVZ, MOVK). Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Richard Henderson r...@twiddle.net ---

[Qemu-devel] [PATCH v3 4/8] target-arm: A64: add support for ld/st with index

2013-12-13 Thread Peter Maydell
From: Alex Bennée a...@bennee.com This adds support for the pre/post-index ld/st forms with immediate offsets as well as the un-scaled immediate form (which are all variations on the same 9-bit immediate instruction form). Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter

[Qemu-devel] [PATCH v3 0/8] target-arm: A64 decoder set 3: loads, stores, misc integer

2013-12-13 Thread Peter Maydell
Version 3 of the third set of A64 decoder patches (loads, stores, misc integer). (Fourth set is very nearly ready to roll, I just need to review the load/store exclusive patch.) Changes v2-v3: * added the non-temporal forms of LDP/STP (fixing a miscoded unallocated_encoding() codepath) *

[Qemu-devel] [PATCH v3 3/8] target-arm: A64: add support for ld/st with reg offset

2013-12-13 Thread Peter Maydell
From: Alex Bennée a...@bennee.com This adds support for the load/store forms using a register offset. Signed-off-by: Alex Bennée alex.ben...@linaro.org Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c | 144 - 1

[Qemu-devel] [PATCH v3 5/8] target-arm: A64: add support for add, addi, sub, subi

2013-12-13 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org Implement the non-carry forms of addition and subtraction (immediate, extended register and shifted register). This includes the code to calculate NZCV if the instruction calls for setting the flags. Signed-off-by: Alex Bennée alex.ben...@linaro.org

Re: [Qemu-devel] [PATCH v5 08/22] blkdebug: Use command-line in read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH] cocoa: Fix typo (aditional - additional)

2013-12-13 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- ui/cocoa.m |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..6569326 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -204,7 +204,7 @@ int keymap[] = 200,// 126 0x7E0xc8E0,48

Re: [Qemu-devel] [PATCH] roms: Flush icache when writing roms to guest memory

2013-12-13 Thread Scott Wood
On Wed, 2013-12-11 at 13:56 +, Peter Maydell wrote: On 11 December 2013 13:23, Alexander Graf ag...@suse.de wrote: The guest expects that its data and instruction cache view of the world is 100% consistent when it initially boots. This works just fine on initial rom population for the

Re: [Qemu-devel] [PATCH v5 09/22] block: Allow reference for bdrv_file_open()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz mre...@redhat.com @@ -872,6 +873,24 @@ int bdrv_file_open(BlockDriverState **pbs, const

Re: [Qemu-devel] [PATCH v5 10/22] block: Pass reference to bdrv_file_open()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: With that now being possible, bdrv_open() should try to extract a block device reference from the options and pass it to bdrv_file_open(). Signed-off-by: Max Reitz mre...@redhat.com Ah well, I see. Users do have a way to specify both options

Re: [Qemu-devel] [PATCH] cocoa: Fix typo (aditional - additional)

2013-12-13 Thread Peter Maydell
On 13 December 2013 19:49, Stefan Weil s...@weilnetz.de wrote: Signed-off-by: Stefan Weil s...@weilnetz.de --- ui/cocoa.m |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..6569326 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@

Re: [Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists

2013-12-13 Thread Eric Blake
On 12/13/2013 10:10 AM, Max Reitz wrote: Reversing qdict_array_split(), qdict_flatten() should flatten QLists as well by interpreting them as QDicts where every entry's key is its index. This allows bringing QDicts with QLists from QMP commands to the same form as they would be given as

Re: [Qemu-devel] [PATCH v5 11/22] block: Allow block devices without files

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: blkdebug and blkverify will, in order to retain compatibility, not support the field file implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is necessary to be able to have block

Re: [Qemu-devel] [PATCH v12 2/5] hw/timer: add allwinner a10 timer

2013-12-13 Thread Antony Pavlov
On Fri, 13 Dec 2013 09:19:08 +0800 liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 +

Re: [Qemu-devel] [PATCH 2/5] ui/cocoa: Correct typos in comments and variable names

2013-12-13 Thread Stefan Weil
Am 08.12.2013 23:59, schrieb Peter Maydell: Fix various non-user-visible typos in comments and variable names. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- ui/cocoa.m | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/ui/cocoa.m

[Qemu-devel] a QOM Coding Conventions question

2013-12-13 Thread Antony Pavlov
Hi, Andreas! Here is a quote from http://wiki.qemu.org/QOMConventions a FooClass structure definition containing at least the parent class field: typedef struct { /* private */ MyParentClass parent_class; /* public */ [any fields you need]

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive files

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max Reitz mre...@redhat.com Hm, does this do what I think it does? $ ./qemu-img convert -O qcow2

Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051

2013-12-13 Thread Eric Blake
On 12/13/2013 10:10 AM, Max Reitz wrote: Allowing nested file formats now results in e.g. qcow2 BlockDriverStates never being directly passed to bdrv_open_common() from bdrv_file_open(), but instead being handed through bdrv_open(). This changes the error message when trying to give a filename

Re: [Qemu-devel] [PATCH v5 14/22] blockdev: Move file to legacy_opts

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Specifying the image filename through the file option is a legacy option and should not be supported by blockdev-add (in that case, giving a string for file references an existing block device). Signed-off-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive files

2013-12-13 Thread Eric Blake
On 12/13/2013 01:19 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max Reitz mre...@redhat.com Hm, does this do what I think

Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce the image option as an alternative to specifying the image through the filename. Signed-off-by: Max Reitz mre...@redhat.com One thing I'd like to see, either in the next version or in a follow-up series, is to generalise

Re: [Qemu-devel] [PATCH v5 16/22] blkdebug: Make filename optional

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: There is no problem in giving no filename; in this case, it has to be specified through the image option. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkdebug.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v5 17/22] blkverify: Allow command-line configuration

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce the test and raw options for specifying images. Signed-off-by: Max Reitz mre...@redhat.com --- block/blkverify.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-)

Re: [Qemu-devel] [PATCH v5 18/22] blkverify: Don't require protocol filename

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: If the filename is not prefixed by blkverify: in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line (or QMP) option (like driver=blkverify). Contrary to the current

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias errno as error

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce an alias error for errno, since using the latter for QMP is sure to result in various syntax errors due to the name being used directly as an identifier. Signed-off-by: Max Reitz mre...@redhat.com I can't say I like this, but it

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Add structures to support blkdebug and blkverify in blockdev-add. Signed-off-by: Max Reitz mre...@redhat.com --- qapi-schema.json | 94 +--- 1 file changed, 90 insertions(+), 4

Re: [Qemu-devel] [PATCH v5 21/22] qemu-io: Make filename optional

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Giving a filename is actually not essential, since it can be specified through the options as well - on the contrary: Sometimes a filename must not be given. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias errno as error

2013-12-13 Thread Eric Blake
On 12/13/2013 01:49 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce an alias error for errno, since using the latter for QMP is sure to result in various syntax errors due to the name being used directly as an identifier. Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Eric Blake
On 12/13/2013 01:54 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: +# @BlkdebugInjectErrorOptions +# +# Describes a single error injection for blkdebug. +# +# @event: trigger event name +# +## +{ 'type': 'BlkdebugInjectErrorOptions', + 'data': { 'event':

Re: [Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Add a test for the new blkdebug/blkverify interface. This test is not written in Python, although it uses QMP. This is because it invokes the qemu-io HMP command, which outputs errors to stderr instead of returning them through QMP. Filtering

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive files

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 21:36 hat Eric Blake geschrieben: On 12/13/2013 01:19 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias errno as error

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 22:00 hat Eric Blake geschrieben: On 12/13/2013 01:49 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce an alias error for errno, since using the latter for QMP is sure to result in various syntax errors due to the name being used directly

[Qemu-devel] [PATCH v8 6/6] MAINTAINERS: Document 'Canon DIGIC' machine

2013-12-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7f45d1d..1fce9a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,6 +233,12 @@ S: Supported F: hw/arm/highbank.c F: hw/net/xgmac.c

[Qemu-devel] [PATCH v8 2/6] hw/arm/digic: prepare DIGIC-based boards support

2013-12-13 Thread Antony Pavlov
Also this patch adds initial support for Canon PowerShot A1100 IS compact camera. Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/Makefile.objs | 1 + hw/arm/digic_boards.c | 84 +++ 2 files changed, 85 insertions(+) create mode

<    1   2   3   >