Re: [Qemu-devel] [PATCH resend 0/7] acpi unit-test: new features

2013-12-29 Thread Marcel Apfelbaum
On Fri, 2013-12-27 at 10:11 +, Alex Bennée wrote: marce...@redhat.com writes: This resend includes the following: Compare resulting aml vs expected aml: - runs only if iasl is installed on the host machine. snip configure| 4 +

Re: [Qemu-devel] [PATCH] vl.c: move if (fd 0) into if (fd = STDERR_FILENO)

2013-12-29 Thread Chen Gang
Firstly, thank you very much for your reply, this is my first patch for qemu. Next year (2014), as a volunteer, I will try to make a patch for qemu in each month. :-) On 12/29/2013 07:43 AM, Peter Maydell wrote: On 28 December 2013 08:52, Chen Gang gang.chen.5...@gmail.com wrote: For valid

[Qemu-devel] [PATCH] acpi unit-test: resolved iasl crash

2013-12-29 Thread Marcel Apfelbaum
It seems that iasl has an issue when disassembles some ACPI tables using the command line: iasl -e DSDT -e SSDT -d HPET I opened a bug on iasl project: https://github.com/acpica/acpica/issues/20 Modified the iasl command line to iasl -d HPET until the problem is solved. The command line remained

Re: [Qemu-devel] [PATCH v2 0/2] acpi unit-test: rebuild aml files functionality

2013-12-29 Thread Marcel Apfelbaum
On Fri, 2013-12-27 at 00:01 +0200, Marcel Apfelbaum wrote: On Thu, 2013-12-26 at 20:19 +0200, Michael S. Tsirkin wrote: On Thu, Dec 26, 2013 at 07:15:00PM +0200, Marcel Apfelbaum wrote: On Thu, 2013-12-26 at 18:51 +0200, Michael S. Tsirkin wrote: On Thu, Dec 26, 2013 at 06:12:25PM +0200,

[Qemu-devel] [PATCH] hw/arm/boot: Don't set up ATAGS for autogenerated dtb booting

2013-12-29 Thread Peter Maydell
The code which decides whether to set up the ATAGS data structure on reset was using the wrong conditional, which meant we were creating an ATAGS structure when doing a device-tree boot if the dtb was autogenerated by the board. This is harmless, but unnecessary, so bring it in to line with

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 03/10] raven: move BIOS loading from board code to PCI host

2013-12-29 Thread Alexander Graf
On 24.12.2013, at 03:02, Andreas Färber andreas.faer...@web.de wrote: Am 24.12.2013 01:32, schrieb Alexander Graf: On 23.12.2013, at 22:54, Hervé Poussineau hpous...@reactos.org wrote: Andreas Färber a écrit : Am 23.12.2013 19:13, schrieb Hervé Poussineau: Alexander Graf a écrit : On

Re: [Qemu-devel] [PATCH] target-ppc: dump DAR and DSISR

2013-12-29 Thread Alexander Graf
On 24.12.2013, at 02:17, Anton Blanchard an...@samba.org wrote: The DAR and DSISR can be very useful when debugging issues, so add them to ppc_cpu_dump_state. We had another bug in this area: all of the v2.06 MMU types were missing. Signed-off-by: Anton Blanchard an...@samba.org Thanks,

Re: [Qemu-devel] [PATCH -V5] kvm: Add a new machine property kvm-type

2013-12-29 Thread Alexander Graf
On 23.12.2013, at 19:03, Andreas Färber afaer...@suse.de wrote: Am 23.12.2013 16:40, schrieb Aneesh Kumar K.V: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Targets like ppc64 support different typed of KVM, one which use types - Alex, please fix. :) hypervisor mode and the

[Qemu-devel] Request for volunteer to commit bsd-user patch set

2013-12-29 Thread Ed Maste
On 13 December 2013 07:44, Paolo Bonzini pbonz...@redhat.com wrote: Post the patches. I'll review the non-bsd-user parts again. And then the next step is to find someone who commits them... shouldn't be hard since you probably know much more about this code than anyone else. Is someone

[Qemu-devel] [PATCH] softfloat: Fix exception flag handling for float32_to_float16()

2013-12-29 Thread Peter Maydell
Our float32 to float16 conversion routine was generating the correct numerical answers, but not always setting the right set of exception flags. Fix this, mostly by rearranging the code to more closely resemble RoundAndPackFloat*, and in particular: * non-IEEE halfprec always raises Invalid for

[Qemu-devel] [PATCH] sparc: Set HostID in NVRAM

2013-12-29 Thread Olivier Danet
On SparcStations, the HostID field in the NVRAM is equal to the last three bytes of the MAC address (which is also stored in the NVRAM). This constant is used as an identification/serial number on Solaris. signed-off-by : Olivier Danet oda...@caramail.com ---

[Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Loic Dachary
Stash the rbd stderr and stdout because it also contains human readable progress messages : Removing image: 3% complete... in addition to potential error messages. Display the stashed output if rbd exits on error. Signed-off-by: Loic Dachary l...@dachary.org --- tests/qemu-iotests/common.rc | 6

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Benoît Canet
Le Monday 30 Dec 2013 à 01:33:34 (+0100), Loic Dachary a écrit : Stash the rbd stderr and stdout because it also contains human readable progress messages : Removing image: 3% complete... in addition to potential error messages. Display the stashed output if rbd exits on error.

Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

2013-12-29 Thread Loic Dachary
Hi Benoît, If I understand correctly common.filter is designed to transform the output and remove variance. In the case of rbd displaying the progress of removal, it is something we probably want to get rid of entirely. Please let me know if I'm missing something and I'll update the patch

[Qemu-devel] [PATCH v1 3/3] qcow2: check for NULL l2meta

2013-12-29 Thread Hu Tao
In case of do preallocating metadata with a large cluster size, qcow2_alloc_cluster_offset() can allocate nothing and returns a NULL l2meta. This patch checks for it and link2 l2 with only valid l2meta. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 14 -- 1 file

[Qemu-devel] [PATCH v1 1/3] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2013-12-29 Thread Hu Tao
n_start can be actually calculated from offset. The number of sectors to be allocated(n_end - n_start) can be passed in in num. By removing n_start and n_end, we can save two parameters. The side effect is there is a bug in qcow2.c:preallocate() that passes incorrect n_start to

[Qemu-devel] [PATCH v1 0/3] qcow2: fix bugs when cluster size is larger than the default value

2013-12-29 Thread Hu Tao
See each patches for details. Hu Tao (3): qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset() qcow2: fix offset overflow qcow2: check for NULL l2meta block/qcow2-cluster.c | 14 ++ block/qcow2-refcount.c | 7 ++- block/qcow2.c | 20

[Qemu-devel] [PATCH v1 2/3] qcow2: fix offset overflow

2013-12-29 Thread Hu Tao
When cluster size is big enough it can lead offset overflow in qcow2_alloc_clusters_at(). This patch fixes it. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2-refcount.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c

[Qemu-devel] [PATCH] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2013-12-29 Thread Hu Tao
Fix incorrect bits of offsets in refcount table entry, l1 table entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK and L2E_OFFSET_MASK. Fix a typo while at the file. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/specs/qcow2.txt | 14 +++--- 1 file changed, 7

Re: [Qemu-devel] [PATCH] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2013-12-29 Thread Stefan Weil
Am 30.12.2013 06:49, schrieb Hu Tao: Fix incorrect bits of offsets in refcount table entry, l1 table entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK and L2E_OFFSET_MASK. Fix a typo while at the file. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/specs/qcow2.txt |

Re: [Qemu-devel] [PATCH] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2013-12-29 Thread Hu Tao
On Mon, Dec 30, 2013 at 08:49:58AM +0100, Stefan Weil wrote: Am 30.12.2013 06:49, schrieb Hu Tao: Fix incorrect bits of offsets in refcount table entry, l1 table entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK and L2E_OFFSET_MASK. Fix a typo while at the file.