Re: [Qemu-devel] [RFC/RFT v1 4/8] xilinx: Inline usages of xilinx_intc_create()

2014-01-12 Thread Edgar E. Iglesias
On Wed, Jan 01, 2014 at 04:03:06PM -0800, Peter Crosthwaite wrote: Inline these usages. Converts these init to at least a semi-recent QOM styling. Thanks Peter, I dont mind the patches but can you clarify the win with this? Looks like we are mostly reducing code reusage? A similar patch was

Re: [Qemu-devel] [PATCH microblaze v1 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-12 Thread Edgar E. Iglesias
On Fri, Jan 10, 2014 at 04:41:06PM +1000, Alistair Francis wrote: This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and updates the

[Qemu-devel] AmigaOS 4.x on QEMU

2014-01-12 Thread Alpha Mule
Hi. AmigaOS 4.x runs natively on some niche PowerPC boards. I was wondering about the viability of running AmigaOS 4.x on QEMU. Specifically, I was wondering if there has been any development on that and/or what needs to be done to get it fully working. Any information would be appreciated.

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-12 Thread Edgar E. Iglesias
On Sat, Jan 11, 2014 at 08:48:12AM +1000, Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 4:12 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Mon, Jan 06, 2014 at 01:46:54PM +1000, Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 1:27 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On

[Qemu-devel] [Bug 1268279] [NEW] Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
Public bug reported: I have Debian 7.2 x64. Install last QEMU from git: aptitude install git gcc make autoconf libglib2.0-dev libcurl4-gnutls- dev libpixman-1-dev libcap-dev libaio-dev libcap-ng-dev libjpeg8-dev libpng12-dev libssh2-1-dev uuid-dev #cd /usr/src #git clone

[Qemu-devel] [Bug 1268279] Re: Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
** Description changed: I have Debian 7.2 x64. Install last QEMU from git: aptitude install git gcc make autoconf libglib2.0-dev libcurl4-gnutls- dev libpixman-1-dev libcap-dev libaio-dev libcap-ng-dev libjpeg8-dev libpng12-dev libssh2-1-dev uuid-dev #cd /usr/src #git

[Qemu-devel] X86_64 ucomisd memory access

2014-01-12 Thread Alexander Bluhm
I am running a software emulated OpenBSD/amd64 on an OpenBSD/amd64 host with qemu-system-x86_64 version 1.7.0. A perl process within the emulated machine gets a segmentation fault at this instruction: 0x0cbf3e13f53c S_sv_2iuv_common+108: ucomisd 0x28(%rax),%xmm0 The accessed address at

[Qemu-devel] [Bug 1268279] Re: Windows 7 x86 does not start on 1.7.50 from git

2014-01-12 Thread Dmitry
** Tags added: windows -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1268279 Title: Windows 7 x86 does not start on 1.7.50 from git Status in QEMU: New Bug description: I have Debian 7.2

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-12 Thread Alexander Graf
On 12.01.2014, at 08:54, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: On Fri, 2014-01-10 at 14:55 +0200, Michael S. Tsirkin wrote: On Thu, Jan 09, 2014 at 03:42:22PM -0700, Alex Williamson wrote: On Thu, 2014-01-09 at 23:56 +0200,

[Qemu-devel] [PULL] Update OpenBIOS images to r1246

2014-01-12 Thread Mark Cave-Ayland
Hi Anthony, Please pull the latest OpenBIOS binary images. In particular, these images fix the following two bugs in SPARC32: - Booting with OBP instead of OpenBIOS - Booting from hard disk instead of CDROM (https://bugs.launchpad.net/qemu/+bug/1262081) CC to -stable because these

Re: [Qemu-devel] [PATCH microblaze v1 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-12 Thread Andreas Färber
Am 10.01.2014 07:41, schrieb Alistair Francis: This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and updates the Microblaze boards to use

[Qemu-devel] [PATCH] tests: Correct comment for qdict_array_split test

2014-01-12 Thread Max Reitz
The comment explaining the expected behavior was actually mistaken (the test code, however, was not). Fix this. Signed-off-by: Max Reitz mre...@redhat.com --- tests/check-qdict.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/check-qdict.c b/tests/check-qdict.c

Re: [Qemu-devel] [PATCH 1/3] linux-user: fixed s390x clone() argument order

2014-01-12 Thread Peter Maydell
On 11 January 2014 09:34, pavel.zbits...@gmail.com wrote: From: Pavel Zbitskiy pavel.zbits...@gmail.com It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db, where TARGET_CLONE_BACKWARDS was specified instead of TARGET_CLONE_BACKWARDS2. Signed-off-by: Pavel Zbitskiy

Re: [Qemu-devel] [PATCH 2/3] linux-user: fixed getsockopt() optlen

2014-01-12 Thread Peter Maydell
On 11 January 2014 09:34, pavel.zbits...@gmail.com wrote: From: Pavel Zbitskiy pavel.zbits...@gmail.com optlen parameter of getsockopt() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm KVM

2014-01-12 Thread Peter Maydell
On 9 January 2014 12:25, Barak Wasserstrom wba...@gmail.com wrote: Hi, I would like to utilize virtio-net and vhost_net on an ARM Cortex A15 machine using qemu-system-arm KVM. I have few questions: 1. Do i need to build qemu-system-arm myself, or apt-get install it? When i apt-get install

[Qemu-devel] [PULL 1/1] arm: fix compile on bigendian host

2014-01-12 Thread Peter Maydell
From: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index f1307eb..198b6b8

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm KVM

2014-01-12 Thread Barak Wasserstrom
Peter, Thanks - I got virtio-net-device running now, but performance is terrible. When i look at the guest's ethernet interface features (ethtool -k eth0) i see all offload features are disabled. I'm using a virtual tap on the host (tap0 bridged to eth3). On the tap i also see all offload features

Re: [Qemu-devel] [PATCH microblaze v1 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-12 Thread Peter Crosthwaite
On Fri, Jan 10, 2014 at 4:41 PM, Alistair Francis alistair.fran...@xilinx.com wrote: This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and

[Qemu-devel] [PULL 0/1] target-arm queue: build breakage fix

2014-01-12 Thread Peter Maydell
eedc1a5db5e4d941e39e54344322c0b1e89dfdcd: Merge remote-tracking branch 'bonzini/scsi-next' into staging (2014-01-10 11:05:17 -0800) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20140112 for you to fetch changes up

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm KVM

2014-01-12 Thread Peter Maydell
On 12 January 2014 21:49, Barak Wasserstrom wba...@gmail.com wrote: Thanks - I got virtio-net-device running now, but performance is terrible. When i look at the guest's ethernet interface features (ethtool -k eth0) i see all offload features are disabled. I'm using a virtual tap on the host

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-12 Thread Peter Crosthwaite
On Sun, Jan 12, 2014 at 11:59 PM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Sat, Jan 11, 2014 at 08:48:12AM +1000, Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 4:12 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Mon, Jan 06, 2014 at 01:46:54PM +1000, Peter Crosthwaite wrote:

Re: [Qemu-devel] [RFC/RFT v1 4/8] xilinx: Inline usages of xilinx_intc_create()

2014-01-12 Thread Peter Crosthwaite
Hi Edgar, On Sun, Jan 12, 2014 at 11:32 PM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Wed, Jan 01, 2014 at 04:03:06PM -0800, Peter Crosthwaite wrote: Inline these usages. Converts these init to at least a semi-recent QOM styling. Thanks Peter, I dont mind the patches but can you

[Qemu-devel] [PATCH v2] spapr_vscsi: Fix REPORT_LUNS handling

2014-01-12 Thread Nathan Whitehorn
Intercept REPORT_LUNS commands addressed either to SRP LUN 0 or the well-known LUN for REPORT_LUNS commands. This is required to implement the SAM and SPC specifications. Since SRP implements only a single SCSI target port per connection, the SRP target is required to report all available LUNs in

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_vscsi: Fix REPORT_LUNS handling

2014-01-12 Thread Nathan Whitehorn
On 01/03/14 08:27, Paolo Bonzini wrote: Il 02/01/2014 19:23, Nathan Whitehorn ha scritto: Let me try to grasp what you're doing here. You're trying to figure out how many devices there are attached to the bus. For every device you reserve a buffer block. Lun0 is mandatory, all others are

[Qemu-devel] [PULL 5/9] ui/cocoa: Fix code for starting QEMU via image file load dialog

2014-01-12 Thread Peter Maydell
Fix a number of bugs in the code for starting QEMU via the image file load dialog: * use the actual argv[0] rather than qemu: this avoids failures to find BIOS image files caused by not looking in the correct directory relative to the executable path * allocate a large enough argv array to

[Qemu-devel] [PULL 3/9] ui/cocoa: Send warning message to stderr, not stdout

2014-01-12 Thread Peter Maydell
Bring a warning message into line with the others in this file by sending it to stderr, not stdout. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1386543546-31919-4-git-send-email-peter.mayd...@linaro.org --- ui/cocoa.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Qemu-devel] [PULL 0/9] cocoa queue

2014-01-12 Thread Peter Maydell
branch 'bonzini/scsi-next' into staging (2014-01-10 11:05:17 -0800) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20140112 for you to fetch changes up to 30ef3c742526baa7910ab5023f0b85062bd85579: MAINTAINERS: add myself as cocoa UI

[Qemu-devel] [PULL 4/9] ui/cocoa: Add .qcow2 to extension list for image load dialog

2014-01-12 Thread Peter Maydell
Add .qcow2 to the list of file extensions which are accepted by the initial disk image load dialog which is displayed if the user runs QEMU without any command line arguments. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 6/9] ui/cocoa: Redraw at correct size when switching surface

2014-01-12 Thread Peter Maydell
If the surface switch involved a resize, we were doing the redraw at the old size rather than the new, because the update of screen.width and screen.height was being done after the setFrame method calls which triggered a redraw. Normally this isn't very noticeable because typically after the guest

[Qemu-devel] [PULL 1/9] ui/cocoa: Pass command key through to guest when VM has mousegrab

2014-01-12 Thread Peter Maydell
The guest might want to be able to use the command key for its won purposes (as command if it is MacOS X, or for the Windows key if it is a PC guest, for instance). In line with other UI frontends, pass it through if the guest has mousegrab, and only use it for UI menu accelerators if not grabbed.

[Qemu-devel] [PULL 2/9] ui/cocoa: Correct typos in comments and variable names

2014-01-12 Thread Peter Maydell
Fix various non-user-visible typos in comments and variable names. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Stefan Weil s...@weilnetz.de Message-id: 1386543546-31919-3-git-send-email-peter.mayd...@linaro.org --- ui/cocoa.m | 28 ++-- 1 file

[Qemu-devel] [PULL 9/9] MAINTAINERS: add myself as cocoa UI co-maintainer

2014-01-12 Thread Peter Maydell
Add myself to the maintainers list for the cocoa UI; status remains Odd Fixes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Andreas Färber andreas.faer...@web.de Message-id: 1387207075-10280-1-git-send-email-peter.mayd...@linaro.org --- MAINTAINERS | 1 + 1 file changed, 1

[Qemu-devel] [PULL 7/9] ui/cocoa: Draw black rectangle if we have no data yet

2014-01-12 Thread Peter Maydell
If our redraw method is called before we have any data from the guest, then draw a black rectangle rather than leaving the window empty. This mostly only matters when the guest machine has no framebuffer device, but it is more in line with the behaviour of other QEMU UIs. Signed-off-by: Peter

[Qemu-devel] [PULL 8/9] ui/cocoa: Remove stray tabs

2014-01-12 Thread Peter Maydell
The ui/cocoa.m file has just three lines with hardcoded tabs; fix them. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Stefan Weil s...@weilnetz.de Message-id: 1387886052-27067-1-git-send-email-peter.mayd...@linaro.org --- ui/cocoa.m | 6 +++--- 1 file changed, 3

[Qemu-devel] [PATCH arm-midr v1 1/2] ARM: Convert MIDR to a property

2014-01-12 Thread Alistair Francis
Convert the MIDR register to a property. This allows boards to later set a custom MIDR value. This has been done in such a way to maintain compatibility with all existing CPUs and boards Signed-off-by: Alistair Francis alistair.fran...@xilinx.com --- I added the properties to the cpu-midr

[Qemu-devel] [PATCH arm-midr v1 0/2] ARM-MIDR Make ARM-MIDR a property and use in Zynq

2014-01-12 Thread Alistair Francis
This series converts cpu-midr (the MIDR register) to a property. This allows it to be set after init which is useful for specific boards (such as Zynq). The change has been done in such a way that it doesn't break compatibility with boards that don't need a custom MIDR. Alistair Francis (2):

[Qemu-devel] [PATCH arm-midr v1 2/2] ZYNQ: Implement board MIDR control for Zynq

2014-01-12 Thread Alistair Francis
This patch uses the fact that the midr variable is now a property This patch sets the midr variable to the boards custom midr Signed-off-by: Alistair Francis alistair.fran...@xilinx.com --- hw/arm/xilinx_zynq.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH arm-midr v1 1/2] ARM: Convert MIDR to a property

2014-01-12 Thread Andreas Färber
Am 13.01.2014 00:33, schrieb Alistair Francis: Convert the MIDR register to a property. This allows boards to later set a custom MIDR value. This has been done in such a way to maintain compatibility with all existing CPUs and boards Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH arm-midr v1 1/2] ARM: Convert MIDR to a property

2014-01-12 Thread Peter Crosthwaite
On Mon, Jan 13, 2014 at 9:54 AM, Andreas Färber afaer...@suse.de wrote: Am 13.01.2014 00:33, schrieb Alistair Francis: Convert the MIDR register to a property. This allows boards to later set a custom MIDR value. This has been done in such a way to maintain compatibility with all existing CPUs

[Qemu-devel] chroot jailing...

2014-01-12 Thread immersive.ex...@gmail.com
Would there be any security benefits, without suffering any considerable relative loss in performance, to (chroot) jailing qemu? Can it, practically speaking, be done?? Would that be a partial safeguard against virtual machine escapes? Or is it the case that if a virtual machine escape takes

Re: [Qemu-devel] [PULL 0/1] target-arm queue: build breakage fix

2014-01-12 Thread Andreas Färber
Am 12.01.2014 22:42, schrieb Peter Maydell: (Is there some way I should be flagging up build fixes in a subject line?) It had once been suggested to use [PATCH buildfix ...] and [PULL buildfix 0/...] for that purpose IIRC. CC'ing Edgar as additional committer. Andreas -- SUSE LINUX Products

Re: [Qemu-devel] [PATCH V9 4/8] qcow2: return int for qcow2_free_clusters()

2014-01-12 Thread Wenchao Xia
于 2014/1/12 7:59, Max Reitz 写道: On 05.01.2014 20:43, Wenchao Xia wrote: The return value can help caller check whether error happens, and it does not need to have *errp since the return value already tips what happend. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH V9 6/8] qcow2: rollback on fail in qcow2_snapshot_create()

2014-01-12 Thread Wenchao Xia
于 2014/1/12 7:50, Max Reitz 写道: On 05.01.2014 20:43, Wenchao Xia wrote: A new variable *err_rollback is added to detect sub function's rollback failure. If one step in rollback procedure fails, following steps will be skipped, and the error message will be appended to errp. Signed-off-by:

[Qemu-devel] for test

2014-01-12 Thread Qin Chuanyu
RT

Re: [Qemu-devel] QEMU detachable overlays and Union Mounts

2014-01-12 Thread Stefan Hajnoczi
On Sat, Jan 11, 2014 at 2:42 AM, kausik pal kausikpa...@gmail.com wrote: Off course we can develop this feature as open source software. Not sure whether GSoC would be a good route, because as far as I know GSoC projects will be completed by coming October. Please let me know of any other

Re: [Qemu-devel] [PATCHv4 6/6] ui/vnc: disable adaptive update calculations if not needed

2014-01-12 Thread Wenchao Xia
于 2014/1/11 6:28, Peter Lieven 写道: Am 10.01.2014 04:09, schrieb Wenchao Xia: 于 2014/1/10 0:25, Peter Lieven 写道: Am 09.01.2014 09:29, schrieb Wenchao Xia: 于 2014/1/8 17:08, Peter Lieven 写道: Signed-off-by: Peter Lieven p...@kamp.de --- ui/vnc.c |9 + 1 file changed, 9

[Qemu-devel] for test, ignore plz

2014-01-12 Thread Qin Chuanyu
RT~

[Qemu-devel] ARM build error/warning

2014-01-12 Thread Edgar E. Iglesias
Hi, Just a heads up. I'm seeing a build warning/error on 32bit hosts. I'm on: commit dd089c0a1e928fb80ba8a37983c1b0e9232d1c8b Merge: 42bf25a 30ef3c7 Author: Anthony Liguori aligu...@amazon.com Date: Sun Jan 12 17:50:52 2014 -0800 gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) Best regards,

[Qemu-devel] [PATCH arm-midr v2 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-12 Thread Alistair Francis
This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and updates the Microblaze boards to use this new method. Signed-off-by: Alistair Francis

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm KVM

2014-01-12 Thread Ying-Shiuan Pan
Hi, Barak, We've tried vhost-net in kvm-arm on arndale Exynos-5250 board (it requires some patches in qemu and kvm, of course). It works (without irqfd support), however, the performance does not increase much. The throughput (iperf) of virtio-net and vhost-net are 93.5Mbps and 93.6Mbps

Re: [Qemu-devel] [PATCH 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-12 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 08:00:37AM +1000, Peter Crosthwaite wrote: On Sun, Jan 12, 2014 at 11:59 PM, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Sat, Jan 11, 2014 at 08:48:12AM +1000, Peter Crosthwaite wrote: On Mon, Jan 6, 2014 at 4:12 PM, Stefan Hajnoczi stefa...@redhat.com

Re: [Qemu-devel] chroot jailing...

2014-01-12 Thread Stefan Hajnoczi
On Sun, Jan 12, 2014 at 02:17:43PM -0500, immersive.ex...@gmail.com wrote: Would there be any security benefits, without suffering any considerable relative loss in performance, to (chroot) jailing qemu? Can it, practically speaking, be done?? Would that be a partial safeguard against virtual

Re: [Qemu-devel] chroot jailing...

2014-01-12 Thread immersive.ex...@gmail.com
Thanks! So it sounds like you're saying selinux is the only meaningful thing to try? Or do people ever bother to place qemu in chroot jails?? I seem to have gotten the impression that people use qemu-static to do this, but it appears to be more for offering secured access of a guest folder to

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-12 Thread Stefan Hajnoczi
On Sat, Jan 11, 2014 at 11:13:32AM +0100, Beniamino Galvani wrote: This patch adds support for the Fast Ethernet MAC found on Allwinner SoCs, together with a basic emulation of Realtek RTL8201CP PHY. Since there is no public documentation of the Allwinner controller, the implementation is

Re: [Qemu-devel] [PATCH] net: Use g_strdup_printf instead of snprintf.

2014-01-12 Thread Stefan Hajnoczi
On Thu, Jan 09, 2014 at 07:34:27PM +0100, Hani Benhabiles wrote: assign_name() in net/net.c is using snprintf + g_strdup to get the same result as g_strdup_printf. Signed-off-by: Hani Benhabiles kroo...@gmail.com --- net/net.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH V2 0/2] net: Fix lan9118 multi-buffer transmit

2014-01-12 Thread Stefan Hajnoczi
On Tue, Jan 07, 2014 at 08:19:50PM -0800, Roy Franz wrote: This patchset fixes some bugs in the lan9118 emulation that were found while debugging UEFI network support on the emulated VExpress platform. The 9118 ethernet controller supports transmission of multi-buffer packets with arbitrary

Re: [Qemu-devel] [PULL 00/50] migration queue

2014-01-12 Thread Michael R. Hines
On 12/25/2013 12:06 AM, Juan Quintela wrote: Hi Anthony This is the patches in the migration queue. Please pull. This includes: - Eduardo refactorings tests - Matthew rate limit fix - Zhanghaoyu CANCELLING fixes - My bitmap changes Integration work was done by Orit. Happy Christmas, Juan.

[Qemu-devel] [PATCH V10 1/8] snapshot: add parameter *errp in snapshot create

2014-01-12 Thread Wenchao Xia
The return value is only used for error report before this patch, so change the function protype to return void. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c| 30 +- block/qcow2.h

[Qemu-devel] [PATCH V10 0/8] qcow2: rollback the modification on fail in snapshot creation

2014-01-12 Thread Wenchao Xia
V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn-l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug,

[Qemu-devel] [PATCH V10 2/8] qcow2: add error message in qcow2_write_snapshots()

2014-01-12 Thread Wenchao Xia
The function still returns int since qcow2_snapshot_delete() will return the number. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-snapshot.c | 43 +-- 1 files changed, 37 insertions(+), 6

[Qemu-devel] [PATCH V10 3/8] util: add error_append()

2014-01-12 Thread Wenchao Xia
Some old code in error_set() is factored out, so this function can call it. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- include/qapi/error.h |6 ++ util/error.c | 44 +++- 2 files

[Qemu-devel] [PATCH V10 4/8] qcow2: return int for qcow2_free_clusters()

2014-01-12 Thread Wenchao Xia
The return value can help caller check whether error happens, and it does not need to have *errp since the return value already tips what happend. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c |8 +---

[Qemu-devel] [PATCH V10 5/8] qcow2: full rollback on fail in qcow2_write_snapshots()

2014-01-12 Thread Wenchao Xia
A header restore step is added and the old label fail is renamed to the more verbose dealloc_sn_table, whereas the new fail section does not rollback anything on disk. If any step during the rollback fails, all remaining will be skipped to prevent dangling pointers. A new parameter *errp_rollback

[Qemu-devel] [PATCH V10 8/8] qemu-iotests: add test for qcow2 snapshot

2014-01-12 Thread Wenchao Xia
This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com ---

[Qemu-devel] [PATCH V10 7/8] blkdebug: add debug events for snapshot

2014-01-12 Thread Wenchao Xia
Some code in qcow2-snapshot.c directly accesses bs-file, so in those places errors can't be injected by other events. Since the code in qcow2-snapshot.c is similar to the other qcow2 internal code (in regards to e.g. the L1 table), add some debug events. Signed-off-by: Wenchao Xia

[Qemu-devel] [PATCH V10 6/8] qcow2: rollback on fail in qcow2_snapshot_create()

2014-01-12 Thread Wenchao Xia
A new variable *err_rollback is added to detect sub function's rollback failure. If one step in rollback procedure fails, following steps will be skipped, and the error message will be appended to errp. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH 1/5] net: extend NetClientInfo for offloading manipulations

2014-01-12 Thread Stefan Hajnoczi
On Fri, Dec 13, 2013 at 01:04:59PM +0100, Vincenzo Maffione wrote: diff --git a/include/net/net.h b/include/net/net.h index 11e1468..f5b5bae 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -50,6 +50,12 @@ typedef void (NetCleanup) (NetClientState *); typedef void

Re: [Qemu-devel] [PATCH 4/5] net: add offloadings support to netmap backend

2014-01-12 Thread Stefan Hajnoczi
On Fri, Dec 13, 2013 at 01:05:02PM +0100, Vincenzo Maffione wrote: +static void netmap_using_vnet_hdr(NetClientState *nc, bool enable) +{ +} I was trying to figure out whether it's okay for this function to be a nop. I've come to the conclusion that it's okay: If the netdev supports vnet_hdr

Re: [Qemu-devel] [PATCH 0/5] Add netmap backend offloadings support

2014-01-12 Thread Stefan Hajnoczi
On Fri, Dec 13, 2013 at 01:04:58PM +0100, Vincenzo Maffione wrote: The purpose of this patch series is to add offloadings support (TSO/UFO/CSUM) to the netmap network backend, and make it possible for the paravirtual network frontends (virtio-net and vmxnet3) to use it. In order to achieve

[Qemu-devel] [PATCH] tests: fix acpi to work on bigendian host

2014-01-12 Thread Alexey Kardashevskiy
Double endianness convertion make this test failing on POWERPC machine running in big-endian. This fixes the test to success on big-endian host. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- tests/acpi-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v3 00/22] Steps towards per CPU address-spaces

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Hi, I'm looking at modeling systems where multiple CPUs co-exist with different views of their attached buses/devs. With this series I'm trying to take some steps towards having an address-space per CPU. It's not complete but good enough for

[Qemu-devel] [PATCH v3 01/22] exec: Make tb_invalidate_phys_addr input an AS

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com No functional change. Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c|3 ++- include/exec/exec-all.h |2 +- target-xtensa/op_helper.c |3 ++- translate-all.c |4 ++-- 4 files

[Qemu-devel] [PATCH v3 02/22] exec: Make iotlb_to_region input an AS

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cputlb.c|2 +- exec.c |5 ++--- include/exec/exec-all.h |2 +- include/exec/softmmu_template.h |5 +++-- 4

[Qemu-devel] [PATCH v3 03/22] exec: Always initialize MemorySection address spaces

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/exec.c b/exec.c index abc4f2f..c9724c0 100644 --- a/exec.c +++ b/exec.c @@ -879,6 +879,7 @@ static void

[Qemu-devel] [PATCH v3 04/22] exec: Make memory_region_section_get_iotlb use section AS

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index c9724c0..6def6b5 100644 --- a/exec.c +++ b/exec.c @@ -783,7 +783,7 @@ hwaddr

[Qemu-devel] [PULL 3/3] Fix lan9118 buffer length handling

2014-01-12 Thread Stefan Hajnoczi
From: Roy Franz roy.fr...@linaro.org The 9118 ethernet controller supports transmission of multi-buffer packets with arbitrary byte alignment of the start and end bytes. All writes to the packet fifo are 32 bits, so the controller discards bytes at the beginning and end of each buffer based on

[Qemu-devel] [PULL 0/3] Net patches

2014-01-12 Thread Stefan Hajnoczi
Note this is my first signed pull request, using the PGP key that I provided at KVM Forum 2013. The following changes since commit dd089c0a1e928fb80ba8a37983c1b0e9232d1c8b: Merge remote-tracking branch 'pmaydell/tags/pull-cocoa-20140112' into staging (2014-01-12 17:50:52 -0800) are available

[Qemu-devel] [PATCH v3 05/22] memory: Add MemoryListener to typedefs.h

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- include/exec/memory.h |2 -- include/qemu/typedefs.h |1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

[Qemu-devel] [PULL 2/3] Fix lan9118 TX CMD A handling

2014-01-12 Thread Stefan Hajnoczi
From: Roy Franz roy.fr...@linaro.org The 9118 ethernet controller supports transmission of multi-buffer packets with arbitrary byte alignment of the start and end bytes. All writes to the packet fifo are 32 bits, so the controller discards bytes at the beginning and end of each buffer based on

[Qemu-devel] [PATCH v3 07/22] exec: On AS changes, only flush affected CPU TLBs

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c |5 + 1 file changed, 5 insertions(+) diff --git a/exec.c b/exec.c index dfad286..54aa790 100644 --- a/exec.c +++ b/exec.c @@ -1809,6 +1809,11 @@ static void

[Qemu-devel] [PATCH v3 09/22] exec: Make ldq/ldub_*_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 22 +++ hw/alpha/typhoon.c|2 +- hw/display/sm501.c|1 + hw/display/sm501_template.h |2 +-

[Qemu-devel] [PATCH v3 10/22] exec: Make lduw_*_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 18 +- hw/net/vmware_utils.h |2 +- hw/ppc/spapr_hcall.c |6 +++--- hw/s390x/css.c |3 ++-

[Qemu-devel] [PATCH v3 06/22] cpu: Add per-cpu address space

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cpus.c |2 ++ cputlb.c|7 --- exec.c | 27 +++ include/exec/exec-all.h

[Qemu-devel] [PATCH v3 08/22] exec: Make ldl_*_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cpu-exec.c|5 +- exec.c| 19 --- hw/dma/pl080.c|9 ++-- hw/dma/sun4m_iommu.c |3

[Qemu-devel] [PATCH v3 11/22] exec: Make stq_*_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 12 +++--- hw/alpha/dp264.c |5 ++- hw/net/vmware_utils.h |2 +- hw/ppc/spapr_hcall.c |6 ++-

[Qemu-devel] [PATCH v3 12/22] exec: Make stl_*_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 19 + hw/net/vmware_utils.h |2 +- hw/pci/msi.c |2 +- hw/pci/msix.c |2 +- hw/ppc/ppc405_uc.c

[Qemu-devel] [PATCH v3 15/22] exec: Make stb_phys input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c |6 +++--- hw/net/vmware_utils.h |2 +- hw/ppc/ppc405_uc.c | 10 +- hw/ppc/spapr_hcall.c |6 +++---

[Qemu-devel] [PATCH v3 13/22] exec: Make stl_phys_notdirty input an AddressSpace

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c|4 ++-- hw/arm/boot.c |9 + hw/arm/highbank.c |6 +++--- include/exec/cpu-common.h |2 +- target-i386/helper.c

[Qemu-devel] [PATCH v3 17/22] exec: Make cpu_memory_rw_debug use the CPUs AS

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exec.c b/exec.c index 758f458..ee3c3c8 100644 --- a/exec.c +++ b/exec.c @@ -2711,11 +2711,11 @@

[Qemu-devel] [PATCH v3 20/22] cpu: Add address-space property

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- qom/cpu.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/qom/cpu.c b/qom/cpu.c index 9d62479..fc6dbff 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -24,6 +24,7 @@ #include

[Qemu-devel] [PATCH v3 16/22] exec: Make cpu_physical_memory_write_rom input an AS

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- exec.c| 15 --- hw/core/loader.c |3 ++- hw/intc/apic.c|3 ++- hw/sparc/sun4m.c |3 ++-

[Qemu-devel] [PATCH v3 18/22] memory: Add address_space_find_by_name()

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- include/exec/memory.h |9 + memory.c | 12 translate-all.c | 10 -- 3 files changed, 29 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v3 19/22] qdev: Add qdev property type for AddressSpaces

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/core/qdev-properties-system.c | 10 +++ hw/core/qdev-properties.c| 54 ++ include/hw/qdev-properties.h |5

[Qemu-devel] [PATCH v3 21/22] petalogix-ml605: Create the CPU with object_new()

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com This is to allow future patches to set properties before cpu::realize(). Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/microblaze/petalogix_ml605_mmu.c | 11 +++ 1 file

[Qemu-devel] [PATCH v3 22/22] petalogix-ml605: Make the LMB visible only to the CPU

2014-01-12 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- hw/microblaze/petalogix_ml605_mmu.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/microblaze/petalogix_ml605_mmu.c