[Qemu-devel] [PATCH 05/49] migration: Move QEMU_VM_* defines to migration/migration.h

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com The VMState code will be moved to vmstate.c and it uses some of the QEMU_VM_* constants, so move it to a header. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 02/49] introduce MIG_STATE_CANCELLING state

2014-01-13 Thread Juan Quintela
From: Zhanghaoyu (A) haoyu.zh...@huawei.com Introduce MIG_STATE_CANCELLING state to avoid starting a new migration task while the previous one still exist. Signed-off-by: Zeng Junliang zengjunli...@huawei.com Signed-off-by: Zhang Haoyu haoyu.zh...@huawei.com Reviewed-by: Paolo Bonzini

[Qemu-devel] [PATCH 06/49] savevm: Convert all tabs to spaces

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 04/49] qemu-file: Make a few functions non-static

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com The QEMUFile code will be moved to qemu-file.c. This will require making the following functions non-static because they are used by the savevm.c code: * qemu_peek_byte() * qemu_peek_buffer() * qemu_file_skip() * qemu_file_set_error() Signed-off-by:

[Qemu-devel] [PATCH 07/49] savevm.c: Coding style fixes

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 75 +--- 1 file changed, 44

[Qemu-devel] [PATCH 18/49] exec: create function to get a single dirty bit

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 2 +- include/exec/memory-internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/exec.c

[Qemu-devel] [PATCH 08/49] savevm.c: Coding style fix

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c

[Qemu-devel] [PATCH 11/49] savevm: Small comment about why timer QEMUFile/VMState code is in savevm.c

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/savevm.c

[Qemu-devel] [PATCH 12/49] tests: Some unit tests for vmstate.c

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com * Basic load/save tests * Tests for loading older versions * Tests for .field_exists() handling Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- tests/.gitignore | 1 + tests/Makefile

[Qemu-devel] [PATCH 19/49] memory: make cpu_physical_memory_is_dirty return bool

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 7 ++- include/exec/memory-internal.h | 8 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 15/49] memory: cpu_physical_memory_set_dirty_range() return void

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 7764314..e497f99 100644 --- a/memory.c +++

[Qemu-devel] [PATCH 10/49] qemu-file: Move QEMUFile code to qemu-file.c

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- Makefile.objs | 1 + qemu-file.c | 826 ++

[Qemu-devel] [PATCH 09/49] vmstate: Move VMState code to vmstate.c

2014-01-13 Thread Juan Quintela
From: Eduardo Habkost ehabk...@redhat.com This will allow unit tests to be written for VMState code without pulling dependencies from the savevm code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 14/49] memory: cpu_physical_memory_set_dirty_flags() result is never used

2014-01-13 Thread Juan Quintela
So return void. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 17/49] memory: create function to set a single dirty bit

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- cputlb.c | 2 +- include/exec/memory-internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cputlb.c

[Qemu-devel] [PATCH 13/49] bitmap: use long as index

2014-01-13 Thread Juan Quintela
Move index and size fields from int to long. We need that for migration. long is 64 bits on sane architectures, and 32bits should be enough on all the 32bits architectures. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman

[Qemu-devel] [PATCH 28/49] bitmap: Add bitmap_zero_extend operation

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/qemu/bitmap.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index afdd257..1babd5d

[Qemu-devel] [PATCH 20/49] memory: all users of cpu_physical_memory_get_dirty used only one flag

2014-01-13 Thread Juan Quintela
So cpu_physical_memory_get_dirty_flags is not needed anymore Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 2 insertions(+), 7

[Qemu-devel] [PATCH 24/49] memory: use bit 2 for migration

2014-01-13 Thread Juan Quintela
For historical reasons it was bit 3. Once there, create a constant to know the number of clients. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory.h | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH 21/49] memory: set single dirty flags when possible

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 7 --- include/exec/memory-internal.h | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/exec.c

[Qemu-devel] [PATCH 23/49] memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

2014-01-13 Thread Juan Quintela
Document it Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- cputlb.c | 4 ++-- exec.c | 19 ++- include/exec/memory-internal.h | 40

[Qemu-devel] [PATCH 22/49] memory: cpu_physical_memory_set_dirty_range() always dirty all flags

2014-01-13 Thread Juan Quintela
So remove the flag argument and do it directly. After this change, there is nothing else using cpu_physical_memory_set_dirty_flags() so remove it. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com ---

[Qemu-devel] [PATCH 26/49] memory: only resize dirty bitmap when memory size increases

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 82aca4a..db369dc 100644 --- a/exec.c +++

[Qemu-devel] [PATCH 25/49] memory: make sure that client is always inside range

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 4 1 file changed, 4 insertions(+) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h

[Qemu-devel] [PATCH 27/49] memory: cpu_physical_memory_clear_dirty_flag() result is never used

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 31/49] memory: unfold cpu_physical_memory_set_dirty() in its only user

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 39/49] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

2014-01-13 Thread Juan Quintela
All uses except one really want the other meaning. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- cputlb.c | 3 ++- exec.c | 6 +++---

[Qemu-devel] [PATCH 29/49] memory: split dirty bitmap into three

2014-01-13 Thread Juan Quintela
After all the previous patches, spliting the bitmap gets direct. Note: For some reason, I have to move DIRTY_MEMORY_* definitions to the beginning of memory.h to make compilation work. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit

[Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

2014-01-13 Thread Juan Quintela
We were setting a range of bits, so use bitmap_set(). Note: xen has always been wrong, and should have used start instead of addr from the beginning. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com ---

[Qemu-devel] [PATCH 30/49] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 45/49] kvm: refactor start address calculation

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- kvm-all.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 308dfba..cb62ba4 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -382,7 +382,8 @@ static

[Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void

2014-01-13 Thread Juan Quintela
Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 10 -- 1 file changed, 4 insertions(+), 6

[Qemu-devel] [PATCH 32/49] memory: unfold cpu_physical_memory_set_dirty_flag()

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 46/49] memory: move bitmap synchronization to its own function

2014-01-13 Thread Juan Quintela
We want to have all the functions that handle directly the dirty bitmap near. We will change it later. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/ram_addr.h | 31 +++ kvm-all.c | 27

[Qemu-devel] [PATCH 35/49] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

2014-01-13 Thread Juan Quintela
Now all functions use the same wording that bitops/bitmap operations Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- exec.c | 2 +- include/exec/memory-internal.h | 6 +++--- 2

[Qemu-devel] [PATCH 42/49] memory: split cpu_physical_memory_* functions to its own include

2014-01-13 Thread Juan Quintela
All the functions that use ram_addr_t should be here. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- cputlb.c | 1 + exec.c | 1 + include/exec/memory-internal.h | 76

[Qemu-devel] [PATCH 48/49] ram: split function that synchronizes a range

2014-01-13 Thread Juan Quintela
This function is the only bit where we care about speed. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch_init.c

[Qemu-devel] [PATCH 40/49] memory: make cpu_physical_memory_reset_dirty() take a length parameter

2014-01-13 Thread Juan Quintela
We have an end parameter in all the callers, and this make it coherent with the rest of cpu_physical_memory_* functions, that also take a length parameter. Once here, move the start/end calculation to tlb_reset_dirty_range_all() as we don't need it here anymore. Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 36/49] memory: use find_next_bit() to find dirty bits

2014-01-13 Thread Juan Quintela
This operation is way faster than doing it bit by bit. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 16 ++-- 1 file changed, 6 insertions(+), 10

[Qemu-devel] [PATCH v4] Add DSDT node for AppleSMC

2014-01-13 Thread Gabriel L. Somlo
AppleSMC (-device isa-applesmc) is required to boot OS X guests. OS X expects a SMC node to be present in the ACPI DSDT. This patch adds a SMC node to the DSDT, and dynamically patches the return value of SMC._STA to either 0x0B if the chip is present, or otherwise to 0x00, before booting the

[Qemu-devel] [PATCH 44/49] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2014-01-13 Thread Juan Quintela
Performance is important in this function, and we want to optimize even further. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- kvm-all.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index

[Qemu-devel] [PATCH 43/49] memory: unfold memory_region_test_and_clear()

2014-01-13 Thread Juan Quintela
We are going to update the bitmap directly Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index e0acbc5..0e8c8b5 100644 ---

[Qemu-devel] [PATCH 49/49] migration: synchronize memory bitmap 64bits at a time

2014-01-13 Thread Juan Quintela
We use the old code if the bitmaps are not aligned Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/arch_init.c

[Qemu-devel] [PATCH 33/49] memory: make cpu_physical_memory_get_dirty() the main function

2014-01-13 Thread Juan Quintela
And make cpu_physical_memory_get_dirty_flag() to use it. It used to be the other way around. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 36

[Qemu-devel] [PATCH 47/49] memory: syncronize kvm bitmap using bitmaps operations

2014-01-13 Thread Juan Quintela
If bitmaps are aligned properly, use bitmap operations. If they are not, just use old bit at a time code. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/ram_addr.h | 54 - 1 file

[Qemu-devel] [PATCH 16/49] exec: use accessor function to know if memory is dirty

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 7e49e8e..c42a2f9 100644 --- a/exec.c +++ b/exec.c @@

[Qemu-devel] [PATCH 38/49] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

2014-01-13 Thread Juan Quintela
We were clearing a range of bits, so use bitmap_clear(). Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 34/49] memory: cpu_physical_memory_get_dirty() is used as returning a bool

2014-01-13 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman owass...@redhat.com --- include/exec/memory-internal.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h

[Qemu-devel] [PATCH] ACPI: AppleSMC _STA method should return 32bit value

2014-01-13 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo so...@cmu.edu --- This applies incrementally on top of Add DSDT node for AppleSMC v.3 (accepted Dec. 25, 2013), and obsoletes v.4 of same with cleaner code in acpi-build.c. Thanks, Gabriel hw/i386/acpi-dsdt-isa.dsl | 4 ++-- hw/i386/acpi-build.c | 11

[Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags

2014-01-13 Thread Steven Noonan
The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here are some boot time comparisons of the various versions of -fstack-protector using qemu-system-arm on an x86_64 host: # -fstack-protector-all Startup finished in 1.810s

[Qemu-devel] [PATCH RESEND 1/2] include/qemu: introduce sizes.h

2014-01-13 Thread Antony Pavlov
The header file sizes.h is used in linux kernel, barebox bootloader and u-boot bootloader. It provides short and easy-to-read names for power-of-two numbers. The numbers like this are othen used for memory range sizes. Signed-off-by: Antony Pavlov antonynpav...@gmail.com Reviewed-by: Richard

[Qemu-devel] [PATCH RESEND 0/2] use sizes.h macros for power-of-two sizes

2014-01-13 Thread Antony Pavlov
The sizes.h macros is an easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in the linux kernel and other projects, so let's use them in QEMU too. Antony Pavlov (2): include/qemu: introduce sizes.h hw/mips: use sizes.h macros

[Qemu-devel] [PATCH RESEND 2/2] hw/mips: use sizes.h macros

2014-01-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Andreas Färber afaer...@suse.de --- hw/mips/mips_malta.c | 25 + include/hw/mips/bios.h | 3 ++- 2 files changed, 15 insertions(+), 13 deletions(-) diff

[Qemu-devel] [PATCH 2/2] block: resize backing image during active layer commit, if needed

2014-01-13 Thread Jeff Cody
If the top image to commit is the active layer, and also larger than the base image, then an I/O error will likely be returned during block-commit. For instance, if we have a base image with a virtual size 10G, and a active layer image of size 20G, then committing the snapshot via 'block-commit'

[Qemu-devel] [PATCH 0/2] block: commits of snapshots larger than backing files

2014-01-13 Thread Jeff Cody
If a snapshot is larger than a backing file, then the offline bdrv_commit and the live active layer commit will fail with an i/o error (usually). A live commit of a non-active layer will complete successfully, as it runs bdrv_truncate() on the backing image to resize it to the larger size. For

[Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary

2014-01-13 Thread Jeff Cody
Currently, if an image file is logically larger than its backing file, commiting it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail. This

Re: [Qemu-devel] [PATCH RESEND 2/2] hw/mips: use sizes.h macros

2014-01-13 Thread Stefan Weil
Am 13.01.2014 21:23, schrieb Antony Pavlov: Signed-off-by: Antony Pavlov antonynpav...@gmail.com Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Andreas Färber afaer...@suse.de --- hw/mips/mips_malta.c | 25 + include/hw/mips/bios.h | 3 ++- 2 files

[Qemu-devel] [PATCH v2] ACPI: Fix AppleSMC _STA size

2014-01-13 Thread Gabriel L. Somlo
Minimize the storage used for AppleSMC's _STA (8bit), relying on ASL to implicitly convert it to the officially specified 32bit value. Signed-off-by: Gabriel Somlo so...@cmu.edu --- This applies incrementally on top of Add DSDT node for AppleSMC v.3 (accepted Dec. 25, 2013), and obsoletes

Re: [Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags

2014-01-13 Thread Stefan Weil
Hi, please see comments below. Am 13.01.2014 21:00, schrieb Steven Noonan: The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here are some boot time comparisons of the various versions of -fstack-protector using qemu-system-arm

Re: [Qemu-devel] [PATCH v3 00/22] Steps towards per CPU address-spaces

2014-01-13 Thread Artyom Tarasenko
Hi Edgar, On Mon, Jan 13, 2014 at 8:39 AM, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com Hi, I'm looking at modeling systems where multiple CPUs co-exist with different views of their attached buses/devs. With this series I'm trying to take some steps

[Qemu-devel] [PATCH v3] configure: add option to disable -fstack-protector flags

2014-01-13 Thread Steven Noonan
The -fstack-protector flag family is useful for ensuring safety and for debugging, but has a performance impact. Here are some boot time comparisons of the various versions of -fstack-protector using qemu-system-arm on an x86_64 host: # -fstack-protector-all Startup finished in 1.810s

[Qemu-devel] [PATCH] vfio: Destroy memory regions

2014-01-13 Thread Alex Williamson
Somehow this has been lurking for a while; we remove our subregions from the base BAR and VGA region mappings, but we don't destroy them, creating a leak and more serious problems when we try to migrate after removing these devices. Add the trivial bit of final cleanup to remove these entirely.

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-13 Thread Alex Williamson
On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: On 12.01.2014, at 08:54, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: On Fri, 2014-01-10 at 14:55 +0200, Michael S. Tsirkin wrote: On Thu, Jan 09, 2014 at 03:42:22PM

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-13 Thread Alexander Graf
Am 13.01.2014 um 22:39 schrieb Alex Williamson alex.william...@redhat.com: On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: On 12.01.2014, at 08:54, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jan 10, 2014 at 08:31:36AM -0700, Alex Williamson wrote: On Fri, 2014-01-10 at

Re: [Qemu-devel] [PATCH microblaze v1 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-13 Thread Edgar E. Iglesias
On Fri, Jan 10, 2014 at 04:41:06PM +1000, Alistair Francis wrote: This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and updates the

[Qemu-devel] [Bug 1268596] Re: Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function

2014-01-13 Thread DEnis
** Description changed: Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50 - #git clone git://git.qemu-project.org/qemu.git # cd qemu; git submodule update --init dtc #./configure --disable-xen --enable-kvm ...No Errors... #CC=ccache gcc make -j8 - GEN

[Qemu-devel] [Bug 1268596] [NEW] Compilation Error: hw/virtio/dataplane/vring.c:400:5: error: ‘ret’ may be used uninitialised in this function

2014-01-13 Thread DEnis
Public bug reported: Qemu git-cloned from mo. 13.01.14 (ca. 13:00 GMT), Version 1.7.50 #git clone git://git.qemu-project.org/qemu.git # cd qemu; git submodule update --init dtc #./configure --disable-xen --enable-kvm ...No Errors... #CC=ccache gcc make -j8 GEN qemu.1 Signing

[Qemu-devel] 回复: Re: [PATCH] linux-user: sync syscall numbers upto 3.13

2014-01-13 Thread 管雪涛
The syscall numbers in unicore32 are correct because we have two ABIs for 32 bits. In qemu, it's old ABI, while in kernel, it's new ABI. However, for now, old ABI is widely used for unicore32's applications. Thanks and Regards, Xuetao Guan - Peter Maydell peter.mayd...@linaro.org 写道: On

[Qemu-devel] [Bug 1268671] Re: CentOS guest crashing due to assertion failure in qemu-char.c

2014-01-13 Thread Wesley Holevinski
** Description changed: Here is the log in /var/log/libvirt/qemu/centos_heavy.log qemu-kvm: /builddir/build/BUILD/qemu-kvm-0.12.1.2/qemu-char.c:630: io_watch_poll_finalize: Assertion `iwp-src == ((void *)0)' failed. 2014-01-13 16:50:31.576+: shutting down The code it's failing

[Qemu-devel] [Bug 1268671] [NEW] CentOS guest crashing due to assertion failure in qemu-char.c

2014-01-13 Thread Wesley Holevinski
Public bug reported: Here is the log in /var/log/libvirt/qemu/centos_heavy.log qemu-kvm: /builddir/build/BUILD/qemu-kvm-0.12.1.2/qemu-char.c:630: io_watch_poll_finalize: Assertion `iwp-src == ((void *)0)' failed. 2014-01-13 16:50:31.576+: shutting down The code it's failing the assertion

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Peter Maydell
On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: From: Fam Zheng f...@redhat.com This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version,

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-01-13 Thread Don Slutz
On 01/02/14 21:12, Don Slutz wrote: Ping. Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names to be fixed (TMPB). Add new functions do_libtool and libtool_prog. Add check for broken gcc and libtool. Signed-off-by: Don Slutz dsl...@verizon.com --- Was posted as an

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Peter Maydell
On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: From: Fam Zheng f...@redhat.com This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version,

Re: [Qemu-devel] [PATCH v15 4/9] darwin: do not use -mdynamic-no-pic

2014-01-13 Thread Peter Maydell
On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do

Re: [Qemu-devel] [PATCH v15 0/9] Shared library module support

2014-01-13 Thread Peter Maydell
On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: This is based on Fam's patches from October. Very few changes apart from rebasing: * I split his patch 8 in two parts. There is benefit in using per-object cflags and libs even before the module-loading machinery gets in.

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Richard Henderson
On 01/13/2014 08:59 AM, Paolo Bonzini wrote: +echo CONFIG_STAMP=`date +%s`_$$_$RANDOM $config_host_mak I really really don't like random numbers that make for non-repeatable builds. It's a quality-assurance nightmare. If you want a non-random number unique to the build, try git log -n1

[Qemu-devel] [PATCH 0/1] Genius serial mouse emulation.

2014-01-13 Thread Romain Naour
This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes) [1]. This protocol is compatible with most 3-buttons serial mouse. This work was developed for qemu-1.1.0 and rebased on master. To test this patch you need to start qemu with -serial gnmouse. Then you

[Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

2014-01-13 Thread Romain Naour
This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes). This protocol is compatible with most 3-button serial mouse. Signed-off-by: Romain Naour romain.na...@openwide.fr --- backends/Makefile.objs | 2 +- backends/gnmouse.c | 339

Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

2014-01-13 Thread Eric Blake
On 01/13/2014 03:33 PM, Romain Naour wrote: This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes). This protocol is compatible with most 3-button serial mouse. Signed-off-by: Romain Naour romain.na...@openwide.fr --- backends/Makefile.objs | 2 +-

Re: [Qemu-devel] [PULL 14/28] exec: make address spaces 64-bit wide

2014-01-13 Thread Alex Williamson
On Mon, 2014-01-13 at 22:48 +0100, Alexander Graf wrote: Am 13.01.2014 um 22:39 schrieb Alex Williamson alex.william...@redhat.com: On Sun, 2014-01-12 at 16:03 +0100, Alexander Graf wrote: On 12.01.2014, at 08:54, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jan 10, 2014 at

Re: [Qemu-devel] [PULL 00/14] QMP queue

2014-01-13 Thread Peter Crosthwaite
Ping, Has this one been forgotten or are there issues? PMM had a small comment, but he waived it AFAICT. Regards, Peter On Tue, Jan 7, 2014 at 8:03 AM, Luiz Capitulino lcapitul...@redhat.com wrote: The following changes since commit f976b09ea2493fd41c98aaf6512908db0bae: PPC: Fix

Re: [Qemu-devel] [PATCH v3 00/22] Steps towards per CPU address-spaces

2014-01-13 Thread Edgar E. Iglesias
On Mon, Jan 13, 2014 at 09:37:23PM +0100, Artyom Tarasenko wrote: Hi Edgar, Hi Artyom, On Mon, Jan 13, 2014 at 8:39 AM, edgar.igles...@gmail.com wrote: From: Edgar E. Iglesias edgar.igles...@xilinx.com Hi, I'm looking at modeling systems where multiple CPUs co-exist with

[Qemu-devel] [PATCH arm-midr v2 1/2] ARM: Convert MIDR to a property

2014-01-13 Thread Alistair Francis
Convert the MIDR register to a property. This allows boards to later set a custom MIDR value. This has been done in such a way to maintain compatibility with all existing CPUs and boards Signed-off-by: Alistair Francis alistair.fran...@xilinx.com --- I originally added the properties to the

[Qemu-devel] [PATCH arm-midr v2 0/2] Make ARM-MIDR a property and use in Zynq

2014-01-13 Thread Alistair Francis
This series converts cpu-midr (the MIDR register) to a property. This allows it to be set after init which is useful for specific boards (such as Zynq). The change has been done in such a way that it doesn't break compatibility with boards that don't need a custom MIDR. V2: Use dc-props to avoid

[Qemu-devel] [PATCH arm-midr v2 2/2] ZYNQ: Implement board MIDR control for Zynq

2014-01-13 Thread Alistair Francis
This patch uses the fact that the midr variable is now a property This patch sets the midr variable to the boards custom midr Signed-off-by: Alistair Francis alistair.fran...@xilinx.com --- hw/arm/xilinx_zynq.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/1] genius: add genius serial mouse emulation

2014-01-13 Thread Romain Naour
Hi, Thanks for review. Le 13/01/2014 23:45, Eric Blake a écrit : On 01/13/2014 03:33 PM, Romain Naour wrote: This patch adds the emulation for a serial Genius mouse using Mouse Systems protocol (5bytes). This protocol is compatible with most 3-button serial mouse. Signed-off-by: Romain Naour

Re: [Qemu-devel] [PATCH] target-arm: Switch ARMCPUInfo arrays to use terminator entries

2014-01-13 Thread Edgar E. Iglesias
On Mon, Jan 13, 2014 at 10:26:16AM +, Peter Maydell wrote: Switch the ARMCPUInfo arrays in cpu.c and cpu64.c to use a terminator entry rather than looping based on ARRAY_SIZE. The latter causes compile warnings on some versions of gcc if the configure options happen to result in an empty

[Qemu-devel] 回复: Re: 回复: Re: [PATCH] linux-user: sync syscall numbers upto 3.13

2014-01-13 Thread 管雪涛
I'm sorry, but what's exactly your meaning? Change linux-user/unicore32/syscall_nr.h to be the same as linux kernel. Or, we will use include/*/unistd.h in linux kernel directly, by copying or referencing. Thanks, Guan Xuetao - Peter Maydell peter.mayd...@linaro.org 写道: On 13 January 2014

Re: [Qemu-devel] Question about drive mirror

2014-01-13 Thread Fam Zheng
On Mon, 01/13 23:44, rudy...@163.com wrote: Hi,everyone. I tested the capability of drive mirror, I found the IO is low. Then I read the code, The code mirror_run() will call mirror_iteration() to read the size of buffer data from source storage, when the read callback ,and then in

Re: [Qemu-devel] [PATCH arm-midr v2 1/1] Microblaze: Convert Microblaze-pic handling to GPIOs

2014-01-13 Thread Edgar E. Iglesias
On Mon, Jan 13, 2014 at 01:35:26PM +1000, Alistair Francis wrote: This patch uses inbound GPIO lines (IRQ and FIR) for interrupts instead of using the old pic_cpu method, which doesn't correspond to real hardware. This creates the CPU's inbound IRQ and FIR GPIO lines and updates the

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Qiao Nuohan
On 01/13/2014 06:39 PM, Laszlo Ersek wrote: - When this write_buffer() is directed to a regular file in non-flat mode, then the file might become sparse (you jump over a range of offsets with lseek() in write_buffer()). If the output has been opened by qemu itself (ie.file:, in

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Laszlo Ersek
On 01/14/14 03:07, Qiao Nuohan wrote: On 01/13/2014 06:39 PM, Laszlo Ersek wrote: - When this write_buffer() is directed to a regular file in non-flat mode, then the file might become sparse (you jump over a range of offsets with lseek() in write_buffer()). If the output has been

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Qiao Nuohan
On 01/14/2014 10:29 AM, Laszlo Ersek wrote: I can't really provide any input to that decision -- I have no clue which tools support which format. The non-flat (ie. random-access, regular file) format appears more space- and computation-efficient, and I thought that would be the natural choice.

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Fam Zheng
On Mon, 01/13 14:15, Richard Henderson wrote: On 01/13/2014 08:59 AM, Paolo Bonzini wrote: +echo CONFIG_STAMP=`date +%s`_$$_$RANDOM $config_host_mak I really really don't like random numbers that make for non-repeatable builds. It's a quality-assurance nightmare. Can you elaborate this,

Re: [Qemu-devel] [PATCH v2 19/24] block: Allow wait_serialising_requests() at any point

2014-01-13 Thread Wenchao Xia
于 2014/1/13 19:29, Kevin Wolf 写道: Am 27.12.2013 um 05:17 hat Wenchao Xia geschrieben: 于 2013/12/13 21:22, Kevin Wolf 写道: We can only have a single wait_serialising_requests() call per request because otherwise we can run into deadlocks where requests are waiting for each other. do you

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Fam Zheng
On Mon, 01/13 22:09, Peter Maydell wrote: On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: From: Fam Zheng f...@redhat.com This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-13 Thread Fam Zheng
On Mon, 01/13 22:05, Peter Maydell wrote: On 13 January 2014 16:59, Paolo Bonzini pbonz...@redhat.com wrote: From: Fam Zheng f...@redhat.com This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as

[Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-13 Thread Stefan Hajnoczi
Propagate the error return value from get_indirect(). Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/virtio/dataplane/vring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index 250d45e..665a1ff 100644 ---

Re: [Qemu-devel] Using virtio-net and vhost_net on an ARM machine using qemu-system-arm KVM

2014-01-13 Thread Ying-Shiuan Pan
Hi, Barak, Hope the following info can help you 1. HOST: http://git.linaro.org/people/christoffer.dall/linux-kvm-arm.git http://git.linaro.org/people/christoffer.dall/linux-kvm-arm.git branch: v3.10-arndale config: arch/arm/configs/exynos5_arndale_defconfig dtb:

Re: [Qemu-devel] [PULL 00/14] QMP queue

2014-01-13 Thread Edgar E. Iglesias
On Tue, Jan 14, 2014 at 09:27:10AM +1000, Peter Crosthwaite wrote: Ping, Has this one been forgotten or are there issues? PMM had a small comment, but he waived it AFAICT. Pong, I've merged it now, thanks! Cheers, Edgar Regards, Peter On Tue, Jan 7, 2014 at 8:03 AM, Luiz Capitulino

<    1   2   3   >