[Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Dave Airlie
So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors from the renderer backend, (b) I can easily report in an event

Re: [Qemu-devel] [PATCH v2] Makefile: Fix make clean

2014-03-17 Thread Stefan Weil
Am 17.03.2014 02:35, schrieb Fam Zheng: This fixes a dangerous bug: make clean after make distclean will delete every single file including those under .git, if you do in-tree build! Rationale: A first make distclean will unset $(DSOSUF), a following make distclean or make clean will find

[Qemu-devel] [PATCH v7 for 2.0 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-03-17 Thread Hu Tao
This patch prepares for the subsequent patches. Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 14 ++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c

[Qemu-devel] [PATCH v7 for 2.0 0/4] qemu-img: add preallocation=full

2014-03-17 Thread Hu Tao
This series implements full image preallocation to create a non-sparse image file at creation time, both for raw and qcow2 format. The purpose is to avoid performance deterioration of the guest cause by sparse image. v7: - fix qemu-iotests fail case 082. Hu Tao (4): qapi: introduce

[Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option

2014-03-17 Thread Hu Tao
This adds a preallocation=full mode to qcow2 image creation, which creates a non-sparse image file. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 75 -- tests/qemu-iotests/082.out | 54 - 2

[Qemu-devel] [PATCH v7 for 2.0 2/4] raw, qcow2: don't convert file size to sector size

2014-03-17 Thread Hu Tao
and avoid converting it back later. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 8 block/raw-posix.c | 4 ++-- block/raw-win32.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 154c40c..33ecb8a 100644

[Qemu-devel] [PATCH v7 for 2.0 3/4] raw-posix: Add full image preallocation option

2014-03-17 Thread Hu Tao
This patch adds a new option preallocation for raw format, and implements full preallocation. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/raw-posix.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/block/raw-posix.c

Re: [Qemu-devel] [PATCH v4 16/21] target-arm: Implement SP_EL0, SP_EL1

2014-03-17 Thread Peter Crosthwaite
On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell peter.mayd...@linaro.org wrote: Implement handling for the AArch64 SP_EL0 system register. This holds the EL0 stack pointer, and is only accessible when it's not being used as the stack pointer, ie when we're in EL1 and EL1 is using its own stack

Re: [Qemu-devel] [PATCH v4 18/21] target-arm: Move arm_log_exception() into internals.h

2014-03-17 Thread Peter Crosthwaite
On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell peter.mayd...@linaro.org wrote: Move arm_log_exception() into internals.h so we can use it from helper-a64.c for the AArch64 exception entry code. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH v4 21/21] hw/arm/virt: Add support for Cortex-A57

2014-03-17 Thread Peter Crosthwaite
On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell peter.mayd...@linaro.org wrote: Support the Cortex-A57 in the virt machine model. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- This should perhaps not be just stealing the a15mpcore_priv on the basis that it's a GICv2... Wont this

Re: [Qemu-devel] [PATCH v4 01/21] target-arm: Split out private-to-target functions into internals.h

2014-03-17 Thread Peter Crosthwaite
On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: Currently cpu.h defines a mixture of functions and types needed by the rest of QEMU and those needed only by files within target-arm/. Split the latter out into a new header so they aren't needlessly exposed further

Re: [Qemu-devel] [PATCH v4 16/21] target-arm: Implement SP_EL0, SP_EL1

2014-03-17 Thread Peter Crosthwaite
On Mon, Mar 17, 2014 at 5:02 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:33 AM, Peter Maydell peter.mayd...@linaro.org wrote: Implement handling for the AArch64 SP_EL0 system register. This holds the EL0 stack pointer, and is only accessible when it's

[Qemu-devel] [PATCH v3 0/9] QMP: Introduce incremental drive-backup with in-memory dirty bitmap

2014-03-17 Thread Fam Zheng
Introduction This implements incremental backup. A convenient option bitmap-use-mode for drive-backup is introduced since v1. Commands A new sync mode for drive-backup is introduced: drive-backup device=.. mode=.. sync=dirty-bitmap bitmap=bitmap0

[Qemu-devel] [PATCH v3 1/9] qapi: Add optional field name to block dirty bitmap

2014-03-17 Thread Fam Zheng
This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [PATCH v3 5/9] hbitmap: Add hbitmap_copy

2014-03-17 Thread Fam Zheng
This makes a deep copy of an HBitmap. Signed-off-by: Fam Zheng f...@redhat.com --- include/qemu/hbitmap.h | 8 util/hbitmap.c | 16 2 files changed, 24 insertions(+) diff --git a/include/qemu/hbitmap.h b/include/qemu/hbitmap.h index 550d7ce..b645cfc 100644 ---

[Qemu-devel] [PATCH v3 7/9] qmp: Add dirty-bitmap-enable and dirty-bitmap-disable

2014-03-17 Thread Fam Zheng
This allows to put the dirty bitmap into a disabled state where no more writes will be tracked. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 15 +++ blockdev.c| 44

[Qemu-devel] [PATCH v3 9/9] qapi: Add transaction support to dirty-bitmap-{add, disable}

2014-03-17 Thread Fam Zheng
This adds dirty-bitmap-add and dirty-bitmap-disable to transactions. With this, user can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. Signed-off-by: Fam Zheng f...@redhat.com ---

[Qemu-devel] [PATCH v3 3/9] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-03-17 Thread Fam Zheng
bdrv_getlength could fail, check the return value before using it. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d240f1e..e32da75 100644 ---

[Qemu-devel] [PATCH v3 4/9] block: Introduce bdrv_dirty_bitmap_granularity()

2014-03-17 Thread Fam Zheng
This returns the granularity (in sectors) of dirty bitmap. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block.c | 6 ++ include/block/block.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v3 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-17 Thread Fam Zheng
The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 60

[Qemu-devel] [PATCH v3 6/9] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap

2014-03-17 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 30 -- include/block/block.h | 4 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index ecc0dad..8a8526d 100644 --- a/block.c +++ b/block.c @@ -52,6 +52,8 @@

Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type

2014-03-17 Thread Markus Armbruster
mreza...@redhat.com writes: From: Miroslav Rezanina mreza...@redhat.com Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to

[Qemu-devel] [PATCH v3 8/9] qmp: Add support of dirty-bitmap sync mode for drive-backup

2014-03-17 Thread Fam Zheng
For dirty-bitmap sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of top sync mode. There are two bitmap use modes for sync=dirty-bitmap: - reset: backup job

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in make clean

2014-03-17 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 14.03.2014 09:38, schrieb Fam Zheng: DANGEROUS: don't try it before you read to the end. A first make distclean will unset $(DSOSUF), a following make distclean or make clean will find all the files and delete it. Including all the files in the .git

Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling

2014-03-17 Thread Markus Armbruster
[cc: Eric] Amos Kong ak...@redhat.com writes: This patch makes all names in option table to match with actual command-line spelling, it will be helpful when we search in option tables. As discussed in [*], the QemuOptsList member name values are ABI: changing them can break existing

Re: [Qemu-devel] [PATCH] qemu-nbd: Fix coverity issues

2014-03-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: There are two issues in qemu-nbd: a missing return value check after calling accept(), and file descriptor leaks in nbd_client_thread. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-nbd.c | 17 + 1 file changed, 13

Re: [Qemu-devel] 9pfs troubles (was Re: [PATCH 1/4] hw/9pfs: fix error handing in local_ioc_getversion())

2014-03-17 Thread Greg Kurz
On Wed, 12 Mar 2014 13:34:44 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 07, 2014 at 10:02:52AM +0100, Greg Kurz wrote: On Wed, 5 Feb 2014 23:31:11 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Feb 04, 2014 at 12:51:25PM +0530, Aneesh Kumar K.V wrote: Michael

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 05:36, Dave Airlie ha scritto: I steered away from using config space for anything for the normal operation of the GPU after looking at overheads and hearing from S390 people that config space has some special properties on their hw, Right, but this is only for the old

Re: [Qemu-devel] Coverity scan successes

2014-03-17 Thread Kevin Wolf
Hi Paolo, Am 14.03.2014 um 13:20 hat Paolo Bonzini geschrieben: Of course, the defect density varies across subsystems: ratio # defects SLIRP 2.8620 9pfs/virtio-9p 1.69

Re: [Qemu-devel] Coverity scan successes

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 10:31, Kevin Wolf ha scritto: Am 14.03.2014 um 13:20 hat Paolo Bonzini geschrieben: Of course, the defect density varies across subsystems: ratio # defects SLIRP 2.8620 9pfs/virtio-9p

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 06:21, Dave Airlie ha scritto: Oh I was also going to use this queue to report HW error events from the guest to the host, like if the guest tries an illegal operation, What fields would be present for such an error? Paolo

Re: [Qemu-devel] [PATCH] target-i386: Add missing 'static' and 'const' attributes

2014-03-17 Thread Paolo Bonzini
Il 16/03/2014 15:03, Stefan Weil ha scritto: This fixes warnings from the static code analysis (smatch). Signed-off-by: Stefan Weil s...@weilnetz.de --- Why is array para_features in kvm.c terminated by a dummy entry? It is only used in a for loop with upper limit ARRAY_SIZE(para_features) -

Re: [Qemu-devel] [PATCH for-2.0] rules.mak: Fix per object libs extraction

2014-03-17 Thread Paolo Bonzini
Il 14/03/2014 03:21, Fam Zheng ha scritto: Don't sort the extracted options, sort the objects. Reported-by: Christian Mahnke cmah...@googlemail.com Signed-off-by: Fam Zheng f...@redhat.com --- rules.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules.mak

Re: [Qemu-devel] [PATCH for-2.1 2/2] i386/acpi-build: support hotplug of VCPU with APIC ID 0xFF

2014-03-17 Thread Laszlo Ersek
On 03/16/14 13:31, Michael S. Tsirkin wrote: On Fri, Mar 14, 2014 at 11:22:52PM +0100, Laszlo Ersek wrote: Building on the previous patch, raise the maximal count of processor objects / NTFY branches / CPON elements from 255 to 256. This allows the VCPU with APIC ID 0xFF to be hotplugged.

Re: [Qemu-devel] [RFC PATCH 6/7] hw/arm/virt: Use PSCI v0.2 function IDs when kernel supports its

2014-03-17 Thread Mark Rutland
On Fri, Mar 14, 2014 at 05:10:34PM +, Rob Herring wrote: On Fri, Mar 14, 2014 at 5:23 AM, Mark Rutland mark.rutl...@arm.com wrote: On Fri, Mar 14, 2014 at 06:53:53AM +, Pranavkumar Sawargaonkar wrote: Hi Christoffer, On 14 March 2014 09:19, Christoffer Dall

Re: [Qemu-devel] [PATCH] qcow2: Fix fail path in realloc_refcount_block()

2014-03-17 Thread Laszlo Ersek
On 03/16/14 00:26, Benoît Canet wrote: The Saturday 15 Mar 2014 à 21:55:54 (+0100), Max Reitz wrote : If qcow2_alloc_clusters() fails, new_offset and ret will both be negative after the fail label, thus passing the first if condition and subsequently resulting in a call of

Re: [Qemu-devel] [PATCH v7] vl.c: Output error on invalid machine type

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 09:04, Markus Armbruster ha scritto: mreza...@redhat.com writes: From: Miroslav Rezanina mreza...@redhat.com Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when

Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 09:23, Markus Armbruster ha scritto: This patch makes all names in option table to match with actual command-line spelling, it will be helpful when we search in option tables. As discussed in [*], the QemuOptsList member name values are ABI: changing them can break existing

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-17 Thread Michael S. Tsirkin
On Mon, Mar 17, 2014 at 02:36:37PM +1000, Dave Airlie wrote: On Thu, Mar 13, 2014 at 8:40 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: +Event queue: +The only current event passed is a message to denote the host +wants to update the

[Qemu-devel] [PATCH] target-alpha: fix the braces

2014-03-17 Thread Paolo Bonzini
Conform to coding style, and avoid further occurrences of bugs due to misplaced braces. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-alpha/translate.c | 313 +++ 1 file changed, 180 insertions(+), 133 deletions(-) diff --git

Re: [Qemu-devel] [PATCH for-2.1 2/2] i386/acpi-build: support hotplug of VCPU with APIC ID 0xFF

2014-03-17 Thread Michael S. Tsirkin
On Mon, Mar 17, 2014 at 11:08:46AM +0100, Laszlo Ersek wrote: On 03/16/14 13:31, Michael S. Tsirkin wrote: On Fri, Mar 14, 2014 at 11:22:52PM +0100, Laszlo Ersek wrote: Building on the previous patch, raise the maximal count of processor objects / NTFY branches / CPON elements from 255 to

Re: [Qemu-devel] [PATCH] linux-user: Implement capget, capset

2014-03-17 Thread Riku Voipio
On Fri, Mar 14, 2014 at 06:10:50PM +, Peter Maydell wrote: Implement the capget and capset syscalls. This is useful because simple programs like 'ls' try to use it in AArch64 I'm not seing this with ubuntu trusty, wookeys debian or my static busybox. Where is your ls from? Also, runnning

[Qemu-devel] [PATCH] linux-user: don't warn on missing capget/capset

2014-03-17 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org some people get numerous unimplemented capget/capset warnings. Since qemu linux-user is not secure to begin with, just skip the system call warning for now. Proper capset/capget to be added in Qemu 2.1 Signed-off-by: Riku Voipio riku.voi...@linaro.org ---

Re: [Qemu-devel] different IDTs of the same VCPU

2014-03-17 Thread Alexander Binun
Dear friends, great thanks! To summarize: we are trying to monitor VCPU IDT changes that are done by external parties (e.g. rootkits) and not by intra-KVM machinery. Are there parameters that witness such changes ? Best Regards, The KVM Israeli team On Thu 13 Mar 17:15 2014 Paolo Bonzini

Re: [Qemu-devel] [PATCH v2] Makefile: Fix make clean

2014-03-17 Thread Peter Maydell
On 17 March 2014 06:15, Stefan Weil s...@weilnetz.de wrote: Am 17.03.2014 02:35, schrieb Fam Zheng: This fixes a dangerous bug: make clean after make distclean will delete every single file including those under .git, if you do in-tree build! Rationale: A first make distclean will unset

Re: [Qemu-devel] [PATCH] linux-user: Implement capget, capset

2014-03-17 Thread Peter Maydell
On 17 March 2014 11:51, Riku Voipio riku.voi...@iki.fi wrote: On Fri, Mar 14, 2014 at 06:10:50PM +, Peter Maydell wrote: Implement the capget and capset syscalls. This is useful because simple programs like 'ls' try to use it in AArch64 I'm not seing this with ubuntu trusty, wookeys

[Qemu-devel] [PATCH v2] linux-user: Implement capget, capset

2014-03-17 Thread Peter Maydell
Implement the capget and capset syscalls. This is useful because simple programs like 'ls' try to use it in AArch64, and otherwise we emit a lot of noise about it being unimplemented. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Changes v1-v2: initialize target_data to NULL to

Re: [Qemu-devel] different IDTs of the same VCPU

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 12:54, Alexander Binun ha scritto: Dear friends, great thanks! To summarize: we are trying to monitor VCPU IDT changes that are done by external parties (e.g. rootkits) and not by intra-KVM machinery. Are there parameters that witness such changes ? There is no way to intercept

[Qemu-devel] [PULL 4/4] vl.c: Output error on invalid machine type

2014-03-17 Thread Paolo Bonzini
From: Miroslav Rezanina mreza...@redhat.com Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required

[Qemu-devel] [PULL 0/4] Misc fixes for 2.0-rc1

2014-03-17 Thread Paolo Bonzini
Anthony, Peter, The following changes since commit f4b11eee2f562c23b3efc33b96ba4542c9ca81aa: Makefile: Fix make clean (2014-03-17 11:50:19 +) are available in the git repository at: git://github.com/bonzini/qemu.git fixes-for-2.0 for you to fetch changes up to

[Qemu-devel] [PULL 1/4] rules.mak: Fix per object libs extraction

2014-03-17 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com Don't sort the extracted options, sort the objects. Reported-by: Christian Mahnke cmah...@googlemail.com Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- rules.mak | 4 ++-- 1 file changed, 2 insertions(+), 2

[Qemu-devel] [PULL 3/4] target-alpha: fix subl and s8subl indentation

2014-03-17 Thread Paolo Bonzini
Two missing braces, one close and one open, fabulously let the code compile. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-alpha/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 2/4] qemu-nbd: Fix coverity issues

2014-03-17 Thread Paolo Bonzini
There are two issues in qemu-nbd: a missing return value check after calling accept(), and file descriptor leaks in nbd_client_thread. Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-nbd.c | 17 + 1 file changed, 13

Re: [Qemu-devel] Windows XP Setup hangs on Fedora FC20 install

2014-03-17 Thread Cole Robinson
On 03/16/2014 08:40 AM, Gerhard Wiesinger wrote: Hello, I tried to install XP SP3 (also tried XP SP2) on a new VM (IDE, 1GB RAM, VMVGA, more details can be provided if necessary) on Fedora 20 (Packages below), but it hangs on Installing Windows/Installing Devices. Was reproduceable 2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-17 Thread Gerd Hoffmann
C 07 Communication controller 00 Serial controller 00 8250 01 16450 02 16550 What about multi_serial_pci_init() -- should it too set prog-if like this? I'm not completely sure what the correct value should be for

Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling

2014-03-17 Thread Markus Armbruster
[cc: Eric yet again :)] Paolo Bonzini pbonz...@redhat.com writes: Il 17/03/2014 09:23, Markus Armbruster ha scritto: This patch makes all names in option table to match with actual command-line spelling, it will be helpful when we search in option tables. As discussed in [*], the

Re: [Qemu-devel] [PATCH v4 04/21] target-arm: Provide correct syndrome information for cpreg access traps

2014-03-17 Thread Peter Maydell
On 17 March 2014 03:05, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: For exceptions taken to AArch64, if a coprocessor/system register access fails due to a trap or enable bit then the syndrome information

Re: [Qemu-devel] [PATCH v4 05/21] target-arm: Add support for generating exceptions with syndrome information

2014-03-17 Thread Peter Maydell
On 17 March 2014 03:19, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: -static void gen_exception(int excp) +static void gen_exception_internal(int excp) { -TCGv_i32 tmp = tcg_temp_new_i32(); -

Re: [Qemu-devel] [PATCH v4 06/21] target-arm: Provide syndrome information for MMU faults

2014-03-17 Thread Peter Maydell
On 17 March 2014 03:28, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org +/* Set bit 26 for exceptions with no change in EL */ +if (arm_current_pl(env)) { +

Re: [Qemu-devel] [PATCH v4 06/21] target-arm: Provide syndrome information for MMU faults

2014-03-17 Thread Peter Maydell
On 17 March 2014 12:41, Peter Maydell peter.mayd...@linaro.org wrote: On 17 March 2014 03:28, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org +/* Set bit 26 for

Re: [Qemu-devel] [PATCH v4 11/21] target-arm: Don't mention PMU in debug feature register

2014-03-17 Thread Peter Maydell
On 17 March 2014 05:13, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: Suppress the ID_AA64DFR0_EL1 PMUVer field, even if the CPU specific value claims that it exists. QEMU doesn't currently implement it,

Re: [Qemu-devel] [PATCH v4 13/21] target-arm: Use dedicated CPU state fields for ARM946 access bit registers

2014-03-17 Thread Peter Maydell
On 17 March 2014 05:20, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: static const ARMCPRegInfo pmsav5_cp_reginfo[] = { { .name = DATA_AP, .cp = 15, .crn = 5, .crm = 0, .opc1 = 0, .opc2 = 0,

[Qemu-devel] [PATCH 3/3] qemu-io: Extended --cmd description in usage text

2014-03-17 Thread Maria Kustova
It's not clear from the usage description that --cmd option accepts its argument as a string, so any special symbols have to be quoted from the shell. Updates in usage text: - Specified parameter format for --cmd option. - Added an instruction how to get help for --cmd option. Signed-off-by:

[Qemu-devel] [PATCH 2/3] block: Replaced old error handling with error reporting API.

2014-03-17 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 3494c6d..359637e 100644 --- a/block/curl.c +++ b/block/curl.c @@ -538,7 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict

[Qemu-devel] [PATCH 0/3] Trivial patches

2014-03-17 Thread Maria Kustova
These patches are the part of OPW application. Two of them update help messages of qemu-io utility. And last one replaces fprintf() with error_setg() in curl.c Maria Kustova (3): qemu-io-cmds: Fixed typo in example for writev. block: Replaced old error handling with error reporting API.

[Qemu-devel] [PATCH 1/3] qemu-io-cmds: Fixed typo in example for writev.

2014-03-17 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- qemu-io-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index f1de24c..5707bda 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -1087,7 +1087,7 @@ writev_help(void) writes a range of

Re: [Qemu-devel] [PATCH v4 14/21] target-arm: Implement AArch64 views of fault status and data registers

2014-03-17 Thread Peter Maydell
On 17 March 2014 05:30, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: @@ -2979,20 +2988,23 @@ void arm_cpu_do_interrupt(CPUState *cs) env-exception.fsr = 2; /* Fall through to prefetch

Re: [Qemu-devel] [PATCH v4 11/21] target-arm: Don't mention PMU in debug feature register

2014-03-17 Thread Peter Crosthwaite
On Mon, Mar 17, 2014 at 10:58 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 17 March 2014 05:13, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: Suppress the ID_AA64DFR0_EL1 PMUVer field, even if the

Re: [Qemu-devel] [PATCH v4 14/21] target-arm: Implement AArch64 views of fault status and data registers

2014-03-17 Thread Peter Crosthwaite
On Mon, Mar 17, 2014 at 11:06 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 17 March 2014 05:30, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 7, 2014 at 5:32 AM, Peter Maydell peter.mayd...@linaro.org wrote: @@ -2979,20 +2988,23 @@ void

Re: [Qemu-devel] [PATCH 2/3] block: Replaced old error handling with error reporting API.

2014-03-17 Thread Peter Crosthwaite
On Mon, Mar 17, 2014 at 7:10 AM, Maria Kustova m...@catit.be wrote: Signed-off-by: Maria Kustova mari...@catit.be --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 3494c6d..359637e 100644 --- a/block/curl.c +++

Re: [Qemu-devel] [PATCH 0/3] Trivial patches

2014-03-17 Thread Peter Crosthwaite
Hi Maria, Thanks for the patches. We have a trivial patches lists mailing lists (that you cc in addition to qemu-devel) that is intended for this kind of stuff. CCd. Regards, Peter On Mon, Mar 17, 2014 at 7:10 AM, Maria Kustova m...@catit.be wrote: These patches are the part of OPW

Re: [Qemu-devel] [PULL 0/3] gtk fixes.

2014-03-17 Thread Gerd Hoffmann
Hi, Doesn't build if CONFIG_GTK isn't defined: /root/qemu/vl.c:146:14: error: 'grab_on_hover' defined but not used [-Werror=unused-variable] Oops. /me wonders how that escaped my attention, my mingw test build should have hit this. Updated pull on the way. sorry for the trouble,

[Qemu-devel] [PULL 3/3] gtk: Don't warp absolute pointer

2014-03-17 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com This matches the behavior of SDL, and makes the mouse usable when using -display gtk -vga qxl https://bugzilla.redhat.com/show_bug.cgi?id=1051724 Signed-off-by: Cole Robinson crobi...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c

[Qemu-devel] [PULL 1/3] gtk: Allow to activate grab-on-hover from the command line

2014-03-17 Thread Gerd Hoffmann
From: Jan Kiszka jan.kis...@siemens.com As long as we have no persistent GTK configuration, this allows to enable the useful grab-on-hover feature already when starting the VM. Signed-off-by: Jan Kiszka jan.kis...@siemens.com [ kraxel: fix warning with CONFIG_GTK=n ] Signed-off-by: Gerd

[Qemu-devel] [PULL 0/3] gtk fixes.

2014-03-17 Thread Gerd Hoffmann
Hi, gtk pull third round, with buildfix applied to patch #1. please pull, Gerd The following changes since commit f4b11eee2f562c23b3efc33b96ba4542c9ca81aa: Makefile: Fix make clean (2014-03-17 11:50:19 +) are available in the git repository at: git://git.kraxel.org/qemu

[Qemu-devel] [PULL 2/3] gtk: Fix mouse warping with gtk3

2014-03-17 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com We were using the wrong coordinates, this fixes things to match the original gtk2 implementation. You can see this error in action by using -vga qxl, however even after this patch the mouse warps in small increments up and to the left, -7x and -3y pixels

Re: [Qemu-devel] vnc regression with -vga vmware

2014-03-17 Thread Gerd Hoffmann
On Fr, 2014-03-14 at 11:06 -0500, Serge Hallyn wrote: Hi, upstream git HEAD appears to have regressed with -vga vmware -vnc. If I run ./qemu-system-x86_64 -enable-kvm -vnc :1 -m 1024 -cdrom ~/trusty-desktop-amd64.iso -vga vmware then tightvncviewer gives me: Connected to

Re: [Qemu-devel] vnc regression with -vga vmware

2014-03-17 Thread Peter Lieven
On 17.03.2014 14:44, Gerd Hoffmann wrote: On Fr, 2014-03-14 at 11:06 -0500, Serge Hallyn wrote: Hi, upstream git HEAD appears to have regressed with -vga vmware -vnc. If I run ./qemu-system-x86_64 -enable-kvm -vnc :1 -m 1024 -cdrom ~/trusty-desktop-amd64.iso -vga vmware then

Re: [Qemu-devel] n ways block filters

2014-03-17 Thread Benoît Canet
The Monday 17 Mar 2014 à 11:12:31 (+0800), Fam Zheng wrote : On Fri, 03/14 16:57, Benoît Canet wrote: Hello list, I plan to convert throttling to a block filter and write n way throttling support. I discussed a bit with Stefan on the list and we came to the conclusion that the

Re: [Qemu-devel] vnc regression with -vga vmware

2014-03-17 Thread Peter Lieven
Serge, can you confirm this happens at a resolution change? Peter On 17.03.2014 14:44, Gerd Hoffmann wrote: On Fr, 2014-03-14 at 11:06 -0500, Serge Hallyn wrote: Hi, upstream git HEAD appears to have regressed with -vga vmware -vnc. If I run ./qemu-system-x86_64 -enable-kvm -vnc

Re: [Qemu-devel] [PULL 0/4] Misc fixes for 2.0-rc1

2014-03-17 Thread Peter Maydell
On 17 March 2014 12:23, Paolo Bonzini pbonz...@redhat.com wrote: Anthony, Peter, The following changes since commit f4b11eee2f562c23b3efc33b96ba4542c9ca81aa: Makefile: Fix make clean (2014-03-17 11:50:19 +) are available in the git repository at: git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PATCH v2] update names in option tables to match with actual command-line spelling

2014-03-17 Thread Paolo Bonzini
Il 17/03/2014 13:33, Markus Armbruster ha scritto: This patch changes: fromto introduced in acpiacpitable 0c764a9 v1.5.0 boot-opts boot3d3b830 v1.0 smp-optssmp 12b7f57 v1.6.0 All three have calcified into ABI already. What has

Re: [Qemu-devel] vnc regression with -vga vmware

2014-03-17 Thread Serge Hallyn
It does happen then as well (I suppose), but after X is done setting up, it happens every time I try to connect. Quoting Peter Lieven (p...@kamp.de): Serge, can you confirm this happens at a resolution change? Peter On 17.03.2014 14:44, Gerd Hoffmann wrote: On Fr, 2014-03-14 at 11:06

Re: [Qemu-devel] [PATCH v4 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-03-17 Thread Benoît Canet
The Thursday 13 Mar 2014 à 09:54:15 (-0600), Eric Blake wrote : On 03/13/2014 09:33 AM, Benoît Canet wrote: We certainly can't do without comments. JSON is designed for easy data exchange, but we use it as programming language syntax. Its restrictions make sense for easy data exchange,

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Laszlo Ersek
On 03/17/14 07:02, Dave Airlie wrote: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors from the renderer

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Peter Maydell
On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what should the expected behaviour of the host be? (at least secure I

Re: [Qemu-devel] [PATCH v2] linux-user: Implement capget, capset

2014-03-17 Thread Riku Voipio
On Mon, Mar 17, 2014 at 12:15:35PM +, Peter Maydell wrote: Implement the capget and capset syscalls. This is useful because simple programs like 'ls' try to use it in AArch64, and otherwise we emit a lot of noise about it being unimplemented. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-s390x: Add missing 'static' and 'const' attributes

2014-03-17 Thread Michael Tokarev
16.03.2014 17:49, Stefan Weil wrote: This fixes warnings from the static code analysis (smatch). Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-arm: Add missing 'static' attribute

2014-03-17 Thread Michael Tokarev
16.03.2014 22:07, Stefan Weil wrote: This fixes a warning from the static code analysis (smatch). Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/ide: Add missing 'static' attributes

2014-03-17 Thread Michael Tokarev
16.03.2014 22:13, Stefan Weil wrote: This fixes a warning from the static code analysis (smatch). Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] util: Add 'static' attribute to function implementation

2014-03-17 Thread Michael Tokarev
16.03.2014 22:02, Stefan Weil wrote: The static code analyzer smatch complains because of a missing 'static' attribute: Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Laszlo Ersek
On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what should the expected

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 16:02 +1000, Dave Airlie wrote: So I'm looking at how best to do virtio gpu device error reporting, and how to deal with illegal stuff, I've two levels of errors I want to support, a) unrecoverable or bad guest kernel programming errors, b) per 3D context errors

Re: [Qemu-devel] [PATCH v2 4/4] xen-all: Pass max_ram_below_4g to xen_hvm_init.

2014-03-17 Thread Don Slutz
On 03/16/14 12:10, Stefano Stabellini wrote: On Tue, 11 Mar 2014, Don Slutz wrote: This is the xen part of pc q35: Add new object pc-memory-layout. Signed-off-by: Don Slutzdsl...@verizon.com --- hw/i386/pc_piix.c| 4 ++-- hw/i386/pc_q35.c | 4 ++-- include/hw/xen/xen.h | 4 ++--

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Peter Maydell
On 17 March 2014 14:49, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] [PATCH 0/2] dataplane: fix bogus coverity warnings

2014-03-17 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 06:25:34PM +0100, Paolo Bonzini wrote: Il 14/03/2014 16:14, Stefan Hajnoczi ha scritto: Coverity detects when variable are accessed under a mutex most of the time. It warns when they are not accessed under the mutex. I initialized variables before the mutex and

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 15:49 +0100, Laszlo Ersek wrote: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-17 Thread Richard W.M. Jones
On Mon, Mar 17, 2014 at 02:40:09PM +, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for something really illegal or crazy what

Re: [Qemu-devel] [PATCH v7 for 2.0 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-03-17 Thread Eric Blake
On 03/17/2014 12:53 AM, Hu Tao wrote: This patch prepares for the subsequent patches. Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 14 ++ 2 files changed, 18 insertions(+), 4

Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

2014-03-17 Thread Stefan Hajnoczi
On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote: This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() (error_setg() is part of error reporting API in include/qapi/error.h) Signed-off-by: Aakriti Gupta aakri...@gmail.com --- block/qed.c |8

  1   2   3   4   >