So we can easily use them in tests.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-ehci.c | 79 +---
include/hw/usb/ehci-regs.h | 82 ++
2 files changed, 83 insertions(+), 78 deletions(-)
Found by Paolo.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
tests/libqos/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c
index 7e0907b..c9a0b91 100644
--- a/tests/libqos/pci.c
+++ b/tests/libqos/pci.c
@@ -103,7 +103,7 @@
We can pick the usb port speed in generic code, by looking at the port
and device speed masks and looking for the fastest match. So add a
function to do exactly that, and drop the speed setting code from
usb_desc_attach as it isn't needed any more.
This way we can set the device speed before
Hi,
Started hacking on the ehci test case.
please review,
Gerd
Gerd Hoffmann (5):
qtest: fix qpci_config_writel
usb: move uhci register defines to header file
usb: add uhci port status reserved bit
usb: move ehci register defines to header file
usb: improve ehci/uhci test
Extend compatibility test function to also figure whenever usb3
devices can be supported on ehci. Tweak ep0 maxpacketsize field
due to usb2 - usb3 difference.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/host-libusb.c | 62 +---
1
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/hw/usb/uhci-regs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/usb/uhci-regs.h b/include/hw/usb/uhci-regs.h
index 63c8223..c7315c5 100644
--- a/include/hw/usb/uhci-regs.h
+++ b/include/hw/usb/uhci-regs.h
@@ -27,6 +27,7
Kevin Wolf kw...@redhat.com writes:
Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben:
On Wed, 05/14 15:12, Markus Armbruster wrote:
The shell script attempts to suppress core dumps like this:
old_ulimit=$(ulimit -c)
ulimit -c 0
$QEMU_IO arg...
ulimit -c $old_ulimit
So you can send keysyms to a specific (text terminal) console.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/console.h | 1 +
ui/console.c | 9 ++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index
From: Markus Armbruster arm...@redhat.com
Bailing out when PK11_FindGenericObjects() returns null ensures the
loop that follows it executes at least once. The loop did not
execute test right after it is useless. Drop it.
Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
View-Detach tab will move to tab to a new window.
Simply closing the window will move it back into a notebook tab.
The label will be permamently stored in VirtualConsole-label,
so it can easily be reused to (re-)label tabs and windows.
Works for vte tabs only for now. pointer/kbd grab code needs
Hi,
I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke
KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls
cpu_reset() before qemu_init_vcpu(), which causes kvm_arm_reset_cpu() to
segfault because it dereferences cpu-cpreg_reset_values, which is not
allocated
From: Bruce Rogers brog...@suse.com
Currently only evdev keycodes are handled by the gtk-ui. SDL has
code to handle both. This patch adds similar processing so that
both keycode types will be handled via the gtk-ui.
Signed-off-by: Bruce Rogers brog...@suse.com
Signed-off-by: Gerd Hoffmann
On Sun, May 25, 2014 at 05:12:55PM +0100, Hani Benhabiles wrote:
On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote:
On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 919af6e..6aaec1b 100644
---
On Mon, May 26, 2014 at 09:07:43AM +0400, M.Kustova wrote:
Hello,
My name is Maria and I'm a participant of the Outreach Program for Women.
My project is fuzz testing of support of qcow2 image format.
The project git:
https://github.com/maxalab/qemu_fuzzer.git
It's pubic, so welcome,
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 2 +-
trace-events | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 54dea16..72308e0 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2856,7
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
ui/console.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 75ec3af..3bc18cf 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -30,7 +30,6 @@
#include trace.h
#define
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c| 44
include/hw/i386/pc.h | 4
2 files changed, 40 insertions(+), 8 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 72308e0..3f1b7ce 100644
---
v3:
* In this case, as we discussed we will give priority to devices to
reserve a specific devfn by passing
device_model_args_hvm = ['-device', 'xen-platform,addr=0x3'] and
vga=none, so withdraw patch #1, #2 and #4.
* Fix some typos.
* Add more comments to make that readable.
* To unmap
ISA bridge is needed since Intel gfx drive will probe it instead
of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that
only need to expose ISA bridge to let driver know the real hardware underneath.
The original patch is from Allen Kay [allen.m@intel.com]
Signed-off-by:
Implement that pci host bridge to specific to passthrough. Actually
thsi just inherit the standard one.
Signed-off-by: Tiejun Chen tiejun.c...@intel.com
---
v3:
* Just fix this patch head description typo.
v2:
* New patch.
hw/pci-host/piix.c | 56
basic gfx passthrough support:
- add a vga type for gfx passthrough
- retrieve VGA bios from sysfs, then load it to guest 0xC
- register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx
The original patch is from Weidong Han weidong@intel.com
Signed-off-by: Yang Zhang
The OpRegion shouldn't be mapped 1:1 because the address in the host
can't be used in the guest directly.
This patch traps read and write access to the opregion of the Intel
GPU config space (offset 0xfc).
The original patch is from Jean Guyader jean.guya...@eu.citrix.com
Signed-off-by: Yang
Some registers of Intel IGD are mapped in host bridge, so it needs to
passthrough these registers of physical host bridge to guest because
emulated host bridge in guest doesn't have these mappings.
The original patch is from Weidong Han weidong.han @ intel.com
Signed-off-by: Yang Zhang
Please ignore this series since I have some typos to some email address :(
Sorry for any inconveniences.
Thanks
Tiejun
-Original Message-
From: qemu-devel-bounces+tiejun.chen=intel@nongnu.org
[mailto:qemu-devel-bounces+tiejun.chen=intel@nongnu.org] On Behalf Of
Tiejun Chen
v3:
* In this case, as we discussed we will give priority to devices to
reserve a specific devfn by passing
device_model_args_hvm = ['-device', 'xen-platform,addr=0x3'] and
vga=none, so withdraw patch #1, #2 and #4.
* Fix some typos.
* Add more comments to make that readable.
* To unmap
basic gfx passthrough support:
- add a vga type for gfx passthrough
- retrieve VGA bios from sysfs, then load it to guest 0xC
- register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx
The original patch is from Weidong Han weidong@intel.com
Signed-off-by: Yang Zhang
ISA bridge is needed since Intel gfx drive will probe it instead
of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that
only need to expose ISA bridge to let driver know the real hardware underneath.
The original patch is from Allen Kay [allen.m@intel.com]
Signed-off-by:
The OpRegion shouldn't be mapped 1:1 because the address in the host
can't be used in the guest directly.
This patch traps read and write access to the opregion of the Intel
GPU config space (offset 0xfc).
The original patch is from Jean Guyader jean.guya...@eu.citrix.com
Signed-off-by: Yang
Some registers of Intel IGD are mapped in host bridge, so it needs to
passthrough these registers of physical host bridge to guest because
emulated host bridge in guest doesn't have these mappings.
The original patch is from Weidong Han weidong.han @ intel.com
Signed-off-by: Yang Zhang
Implement that pci host bridge to specific to passthrough. Actually
thsi just inherit the standard one.
Signed-off-by: Tiejun Chen tiejun.c...@intel.com
---
v3:
* Just fix this patch head description typo.
v2:
* New patch.
hw/pci-host/piix.c | 56
Hello Kevin,
Thanks a lot for your feedback.
Your first guess is absolutely correct. For now, 'action' can be
freely interpret as an image block will be corrupted. It's possible,
that in the future this term will be extended to a set of fuzzing
rules necessary to corrupt some image block, e.g.
Il 26/05/2014 11:18, Christoffer Dall ha scritto:
Hi,
I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke
KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls
cpu_reset() before qemu_init_vcpu(), which causes kvm_arm_reset_cpu() to
segfault because it
On 26.05.14 11:55, Paolo Bonzini wrote:
Il 26/05/2014 11:18, Christoffer Dall ha scritto:
Hi,
I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke
KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls
cpu_reset() before qemu_init_vcpu(), which causes
It indicates the number of elements in ncs field and makes sense to have
int inside NICPeers. Also in parse_netdev we do not need to access
container and work with NICPeers only.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
hw/core/qdev-properties-system.c | 3 +--
hw/net/virtio-net.c
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we're doing the same thing
on all targets.
Alex
$ grep -R -A 3 -B 3 qemu_init_vcpu target-*
target-alpha/cpu.c-
Am 26.05.2014 12:04, schrieb Jiri Pirko:
It indicates the number of elements in ncs field and makes sense to have
int inside NICPeers. Also in parse_netdev we do not need to access
container and work with NICPeers only.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
On 26.05.14 12:20, Andreas Färber wrote:
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we're doing the same thing
on all targets.
Alex
$ grep -R -A 3 -B 3 qemu_init_vcpu
On Mon, May 26, 2014 at 11:25:56AM +0200, Gerd Hoffmann wrote:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c| 44
include/hw/i386/pc.h | 4
2 files changed, 40 insertions(+), 8 deletions(-)
diff --git
On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote:
On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote:
On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote:
If you implement this in the net layer then that problem is easy to
resolve since
we
On Mon, May 26, 2014 at 01:48:13PM +0200, Stefan Hajnoczi wrote:
On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote:
On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote:
On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote:
If you implement this in
On Wed, May 07, 2014 at 07:24:09PM +0200, Stefan Hajnoczi wrote:
This series adds a pid field to the simpletrace record. This allows
aggregation of simpletrace files as well as host-wide tracing since records
can
now be associated with a particular QEMU process.
Stefan Hajnoczi (2):
On Fri, May 23, 2014 at 01:18:50PM +0200, Kevin Wolf wrote:
Am 22.05.2014 um 11:42 hat Stefan Hajnoczi geschrieben:
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index f19536a..a46ee57 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -4,6 +4,10 @@ A qcow2 image
On Fri, May 23, 2014 at 05:15:41PM +0100, Peter Maydell wrote:
In the MacOSX specific code in raw-posix.c we use the define
LONG_LONG_MAX. This is actually a non-standard pre-C99 define;
switch to using the standard LLONG_MAX instead.
This apparently fixes a compilation failure with certain
On Mon, May 26, 2014 at 12:04:08PM +0200, Jiri Pirko wrote:
It indicates the number of elements in ncs field and makes sense to have
int inside NICPeers. Also in parse_netdev we do not need to access
container and work with NICPeers only.
Signed-off-by: Jiri Pirko j...@resnulli.us
On 21/05/14 23:43, Juan Quintela wrote:
Hi
Please, send any topic that you are interested in covering.
(mostly) Michael Mueller
-
CPU models on s390 and other platforms. Interfaces/requirements/Contraints etc.
Thanks, Juan.
Call details:
15:00 CEST
Bring the memory map closer to a PowerMac3,1 model by removing unused
areas and adding the VGA and network cards after the macio to let the
latter be mapped from 0x8000 like on real hardware. (On real
hardware the graphics and network cards are on separate buses but we
don't model that yet.)
On Fri, May 23, 2014 at 06:25:31PM +0200, Marcin Gibuła wrote:
If you see a pending request on a RADOS block device (rbd) then it would
be good to dig deeper into QEMU's block/rbd.c driver to see why it's not
completing that request.
Are you using qcow2 on top of rbd?
Hi,
I've already
Am 26.05.2014 12:31, schrieb Alexander Graf:
On 26.05.14 12:20, Andreas Färber wrote:
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we're doing the same thing
on all targets.
- Andreas Färber afaer...@suse.de 写道：
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we're doing the same thing
on all targets.
Alex
$ grep -R -A 3 -B 3
On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
block-migration.c and blockdev.c. The trailing \ns of the @fmt argument
have been removed because @fmt of error_report() should not contain newline.
Checks the output visitor behaviour for NULL values.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
tests/test-qmp-output-visitor.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/test-qmp-output-visitor.c b/tests/test-qmp-output-visitor.c
index 9c15458..74020de
V1 - V2:
- Rebased on qom-next queue.
- Patch 1/4:
- Since there are a lot of discussions on the correct
way to do the fix, added a FIXME comment to find a better way.
- Patch 2/4:
- Addressed Michael Roth's comments:
- Added output visitor test
- Tweaked it as advised
-
Filter out also 'type' property when setting
object's properties
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
vl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 2de90fb..2153b9e 100644
--- a/vl.c
Make machine's QemuOpts QOM properties of machine. The properties
are automatically filled in. This opens the possiblity to create
opts per machine rather than global.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
hw/core/machine.c | 256
A NULL value is not added to visitor's stack, but there
is no check for that when the visitor tries to return
that value, leading to Qemu crash.
Reviewed-by: Eric Blake ebl...@redhat.com
Acked-by: Luiz Capitulino lcapitul...@redhat.com
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
V1 - V2:
- Rebased on qom-next queue.
- Patch 1/4:
- Since there are a lot of discussions on the correct
way to do the fix, added a FIXME comment to find a better way.
- Patch 2/4:
- Addressed Michael Roth's
The Thursday 22 May 2014 à 11:42:50 (+0200), Stefan Hajnoczi wrote :
Normally one would expect that qcow2 image file lengths are multiples of
the cluster size. This is not true in all cases and the spec should
document this so implementers remember to accept such files.
$ qemu-img create -f
Two options for making progress on this bug:
1. Debug bdrv_drain_all() and find out whether there are any I/O
requests remaining.
Yes, there is one request pending on active layer of disk that is being
commited (on bs-tracked_requests list). IO threads die off because they
have nothing
[quoted lines by Peter Maydell on 2014/05/25 at 10:11 +0100]
Ah, I see. Still, I think it makes more sense for the queue and delay
to be in the common key handling code, not in the curses frontend
specifically.
This patch, attached as qemu-kbddelay-1.patch, is a rework of the former curses
UI
On 23/05/2014 10:40, Eric Auger wrote:
On 05/11/2014 07:13 PM, Alvise Rigo wrote:
The flag is mandatory for the ARM SMMU so we always add it if the MMIO
handles it.
Hi Alvise,
Refering to the root problem explanation found in
https://lkml.org/lkml/2014/2/8/176, I understand the problem
On Sa, 2014-05-24 at 21:21 -0400, Dave Mielke wrote:
[quoted lines by Peter Maydell on 2014/05/25 at 01:04 +0100]
Why is this a problem only for the curses UI frontend, and not for
any of the other UIs which might send key events?
One reason is that most UIs send key events as they receive
On Tue, May 13, 2014 at 08:04:13PM +0200, Lluís Vilanova wrote:
Adds support to compile QEMU with multiple tracing backends at the same time.
For example, you can compile QEMU with:
$ ./configure --enable-trace-backends=ftrace,dtrace
Where 'ftrace' can be handy for having an in-flight
On 26/05/14 09:32, Alexander Graf wrote:
The macio IDE controller has some pretty nasty magic in its implementation to
allow for unaligned sector accesses. We used to handle these accesses
synchronously inside the IO callback handler.
However, the block infrastructure changed below our feet
Hallo to all, this is my first post here.
I have exactly the same problem occurred after Distribution Update
Ubuntu Server x64 from 12.04.4 to 14.04.
1. I have Windows 7 32/64-Bit and Windows 2008 Server 64-Bit VMs, all
show the same error with two dedicated cores (no pinning). In
combination
Stefan Hajnoczi stefa...@gmail.com writes:
On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
block-migration.c and blockdev.c. The trailing \ns of the @fmt argument
have been removed because @fmt of
Am 26.05.2014 um 17:02 hat Markus Armbruster geschrieben:
Stefan Hajnoczi stefa...@gmail.com writes:
On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
block-migration.c and blockdev.c. The trailing \ns of the
[quoted lines by Gerd Hoffmann on 2014/05/26 at 15:38 +0200]
Tried to make the curses ui a bit more clever? You could try caching
the modifier state, then send only the changes. That gets the number of
events down to 6 max (4 to update modifier state, 2 for the actual key).
Yes, except that,
From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
[r...@twiddle.net]
Sent: Saturday, May 17, 2014 8:11 PM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2]
From: James Hogan [ja...@albanarts.com]
Sent: Thursday, May 22, 2014 2:03 AM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register
I think you
From: James Hogan [ja...@albanarts.com] on behalf of James Hogan
Sent: Thursday, May 22, 2014 2:19 AM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: implement
On 05/22/2014 04:08 AM, Tom Musta wrote:
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
On 05/21/2014 08:47 PM, Alexander Graf wrote:
On 21.05.14 08:20, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
Signed-off-by: Alexey Kardashevskiy
Hi,
When using virtio disk plug/unplug with Q35 machine I see two problems.
Note that when using the same sequence with default 440FX I see no issues.
A) 'pcie.0' does not support hotplugging'
I can workaround this problem if I manually specify -readconfig
Kevin Wolf kw...@redhat.com writes:
Am 26.05.2014 um 17:02 hat Markus Armbruster geschrieben:
Stefan Hajnoczi stefa...@gmail.com writes:
On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
block-migration.c
Am 26.05.2014 14:40, schrieb Marcel Apfelbaum:
Make machine's QemuOpts QOM properties of machine. The properties
are automatically filled in. This opens the possiblity to create
opts per machine rather than global.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
hw/core/machine.c
Am 26.05.2014 14:48, schrieb Michael S. Tsirkin:
On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
V1 - V2:
- Rebased on qom-next queue.
- Patch 1/4:
- Since there are a lot of discussions on the correct
way to do the fix, added a FIXME comment to find a better
Hi list,
Many services timeout in OpenIndiana (151a8 Server Build 32 bit x86) during
boot when i use the tcg accelerator. This is pushing the boot time of the
OS to more than 45 mins depending on the number of CPUs activated.
I did the tests with qemu-system-i386 -smp sockets=4,cores=1,threads=1
On 05/26/2014 03:20 AM, Andreas Färber wrote:
Alpha is the main blocker for unifying CPU reset iirc. It does not
implement reset at all and thus is not calling it. The struct was not
designed for zero'ing things, so there's a mix of data fields and
pointers without clear separation to allow
From: Petar Jovanovic petar.jovano...@imgtec.com
From MIPS documentation (Volume III):
UserLocal Register (CP0 Register 4, Select 2)
Compliance Level: Recommended.
The UserLocal register is a read-write register that is not interpreted by
the hardware and conditionally readable via the RDHWR
Most of them are probably harmless. Copying qemu-stable anyway, just
in case. Also fix two qemu-io bugs I found while investigating its
leaks.
Markus Armbruster (14):
qemu-img: Plug memory leak on block option help error path
block/vvfat: Plug memory leak in enable_write_target()
qcow2:
blockdev_init() leaks bs_opts when qemu_opts_create() fails, i.e. when
the ID is bad. Missed in commit ec9c10d.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index
Instead of ignoring all option values but the last one, multiple -o
options now have the same meaning as having a single option with all
settings in the order of their respective -o options.
Same as commit 2dc8328 for qemu-img convert, except here we do it with
QemuOpts rather than
Reproducer: open -o a=b. Broken in commit fd0fee3.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-io.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index ffbad25..0daf413 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -61,7 +61,8 @@
On error path. Introduced in commit a046433a. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 6a0d246..2c82a5c 100644
--- a/block/vvfat.c
+++
Has always been leaky. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/vvfat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 2c82a5c..389704a 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -787,7
Introduced in commit f298d07. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
blockdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 6460c70..7ec7d79 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -941,6 +941,7 @@ DriveInfo
Has always been leaky. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/sheepdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2c3fb01..9a9a307 100644
--- a/block/sheepdog.c
+++
Introduced in commit 661a0f7. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 62ea27e..d118da5 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1455,7 +1455,7 @@
Introduced in commit a283cb6; mostly harmless. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 1ad899e..62ea27e 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -287,6 +287,7 @@
Introduced in commit a8d8ecb. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 75f44f1..97e1641 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -475,6 +475,7 @@ static
Quoting Andreas Färber (2014-05-26 11:42:45)
Am 26.05.2014 14:48, schrieb Michael S. Tsirkin:
On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
V1 - V2:
- Rebased on qom-next queue.
- Patch 1/4:
- Since there are a lot of discussions on the correct
way to do
Introduced in commit da557a. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 40c5e1a..1996f84 100644
--- a/block.c
+++ b/block.c
@@ -1196,6 +1196,7 @@ int
Introduced in commit 5a8a30d. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/qcow2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index a4b97e8..a54d2ba 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@
Introduced in commit b543c5c. Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
qemu-io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-io.c b/qemu-io.c
index ef3fef6..ffbad25 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -175,6 +175,7 @@ static int
I figure the leak originated in bdrv_create2(), and was duplicated
into callers when commit 91a073ak dropped that function. Looks like
the other places have since been fixed.
Spotted by Coverity.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block/vvfat.c | 1 +
1 file changed, 1
On 26.05.14 17:45, Alexey Kardashevskiy wrote:
On 05/22/2014 04:08 AM, Tom Musta wrote:
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
On 26.05.14 17:50, Alexey Kardashevskiy wrote:
On 05/21/2014 08:47 PM, Alexander Graf wrote:
On 21.05.14 08:20, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
On 26.05.14 15:56, Mark Cave-Ayland wrote:
On 26/05/14 09:32, Alexander Graf wrote:
The macio IDE controller has some pretty nasty magic in its
implementation to
allow for unaligned sector accesses. We used to handle these accesses
synchronously inside the IO callback handler.
However, the
On 26.05.14 14:36, Andreas Färber wrote:
Am 26.05.2014 12:31, schrieb Alexander Graf:
On 26.05.14 12:20, Andreas Färber wrote:
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure
Am 26.05.2014 19:28, schrieb Petar Jovanovic:
From: Petar Jovanovic petar.jovano...@imgtec.com
From MIPS documentation (Volume III):
UserLocal Register (CP0 Register 4, Select 2)
Compliance Level: Recommended.
The UserLocal register is a read-write register that is not interpreted by
101 - 200 of 244 matches
Mail list logo
