Re: [Qemu-devel] [PATCH v3 00/24] book3s powerpc classes rework

2014-05-28 Thread Alexey Kardashevskiy
On 05/27/2014 08:37 PM, Alexey Kardashevskiy wrote: Started as POWER7/8 SPRs patchset, this became a rework of book3s/970 CPU classes initialization. The aim is to boot little endian guests in TCG mode with -cpu POWER8 (ironically, POWER8 emulation still fails, debugging it now but most of

[Qemu-devel] [Bug Report] snapshot under a background migration

2014-05-28 Thread Chai Wen
Hi, There is a issue that doing snapshot under a background migration could cause a segfault. Steps to reproduce this issue are: 1. dirty plenty of pages in the 1st guest 2. run command 'migrate -d tcp:***:***' in 1st monitor to migrate the 1st guest to 2nd guest in background 3.

Re: [Qemu-devel] [PATCH] vmdk: Fix local_err in vmdk_create

2014-05-28 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: In vmdk_create and vmdk_create_extent, initialize local_err before using it, and don't leak it on error. Reported-by: Markus Armbruster arm...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 8 1 file changed, 4

[Qemu-devel] [PATCH 2/4] apb: fix IOMMU register sizes

2014-05-28 Thread Mark Cave-Ayland
According to the referenced documentation, the IOMMU has 3 64-bit registers consisting of a control register, base register and flush register. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk --- hw/pci-host/apb.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH 0/4] apb: implement IOMMU for PCI host bridge (sun4u)

2014-05-28 Thread Mark Cave-Ayland
This patchset implements IOMMU translation for the APB PCI host bridge as used by sun4u. With this patchset applied, my Debian squeeze/wheezy test images can now boot and start executing the installer (including CDROM and network access) in -nographic mode without requiring virtio.

[Qemu-devel] [PATCH 1/4] apb: Move IOMMU registers into a separate IOMMUState struct

2014-05-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk --- hw/pci-host/apb.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 252caef..bea7092 100644 --- a/hw/pci-host/apb.c +++ b/hw/pci-host/apb.c @@ -70,6

[Qemu-devel] [PATCH 4/4] apb: implement IOMMU translation for PCI host bridge

2014-05-28 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk --- hw/pci-host/apb.c | 165 + 1 file changed, 165 insertions(+) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index b57b034..1497008 100644 --- a/hw/pci-host/apb.c +++

[Qemu-devel] [PATCH 3/4] apb: handle reading/writing of IOMMU control registers

2014-05-28 Thread Mark Cave-Ayland
While the registers are documented as being 64-bit, Linux seems to access them in two halves as 2 x 32-bit accesses. Make sure that we can correctly handle this case. Signed-off-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk --- hw/pci-host/apb.c | 103

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-28 Thread Igor Mammedov
On Tue, 27 May 2014 18:12:09 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 27/05/2014 17:57, Anshul Makkar ha scritto: object_add memory-ram,id=ram0,size=1G, device_add dimm,id=dimm1,memdev=ram0 object_add memory-ram,id=ram1,size=1G, device_add dimm,id=dimm2,memdev=ram1

Re: [Qemu-devel] [PATCH 6/8] smbus: Fix unreachable code in smb_transaction()

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 02:59, Gonglei (Arei) ha scritto: -abort(); This is intentional defensive programming. A break from the switch would be wrong, hence the abort here. But the break is unreachable at all case conditions. All those cases will goto data8/data16/done/error. Of course,

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] ohw: correctly program BAR addresses of PCI devices

2014-05-28 Thread Mark Cave-Ayland
On 28/05/14 00:28, Andreas Färber wrote: Am 28.05.2014 01:22, schrieb Alexander Graf: On 23.04.14 23:19, Hervé Poussineau wrote: Note that offsets are PReP ones, so this breaks compatibility with hardware which has different values. So that means that this patch breaks non-PReP? I don't

Re: [Qemu-devel] [Qemu-stable] [PATCH 09/14] blockdev: Plug memory leak in drive_init()

2014-05-28 Thread Markus Armbruster
Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 21:44:15 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 21:11:45 (+0200), Markus Armbruster wrote : Benoît Canet benoit.ca...@irqsave.net writes: The

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-28 Thread Igor Mammedov
On Tue, 27 May 2014 17:57:31 +0200 Anshul Makkar anshul.mak...@profitbricks.com wrote: Hi, I tested the hot unplug patch and doesn't seem to work properly with Debian 6 and Ubuntu host. Scenario: I added 3 dimm devices of 1G each: object_add memory-ram,id=ram0,size=1G, device_add

Re: [Qemu-devel] [PATCH v10 00/18] Vhost and vhost-net support for userspace based backends

2014-05-28 Thread Anshul Makkar
Hi, We are also trying to develop a solution where we can implement the switch in the user mode (thinking of using VDE) and then rdma packet directly to other end without involving the kernel layers. Is the above solution/patch series implements that using Snabbswitch ethernet switch . Confused

Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial v2 0/4] Cadence GEM patches

2014-05-28 Thread Michael Tokarev
26.05.2014 12:37, Peter Crosthwaite wrote: Hi Michael, Found a bug in the Cadence GEM. Fixed in P1. Have some follow up trivials as well (P2-4). Applied to -trivial, with some very minor comment grammar tweak in 2/4. Thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qtest: fix hex2nib for capital characters

2014-05-28 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [PATCH 0/1] configure: avoid problems with grep customization

2014-05-28 Thread Cornelia Huck
Hi, we recently noticed that the endianness check in configure may fail for users that customize grep via GREP_OPTIONS. Fortunately, this check seems to be the only one that is sensitive to default grep options (none of the other invocations act on binaries), so let's just fix that one instance.

[Qemu-devel] [PATCH 1/1] configure: robustify big/little check

2014-05-28 Thread Cornelia Huck
The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS, this will fail. Let's just explicitly specify --binary-files=binary, which will override any user settings and do what

Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check

2014-05-28 Thread Peter Maydell
On 28 May 2014 09:46, Cornelia Huck cornelia.h...@de.ibm.com wrote: The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS, this will fail. Let's just explicitly specify

Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails

2014-05-28 Thread Kevin Wolf
Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben: Reproducer: open -o a=b. Broken in commit fd0fee3. Signed-off-by: Markus Armbruster arm...@redhat.com Missing empty line in the commit message. Another one that I can fix up while applying if there is no respin. Kevin

Re: [Qemu-devel] [PATCH v3 22/34] trace: add acpi memory hotplug IO region events

2014-05-28 Thread Anshul Makkar
Hi, Sorry, for this basic question. Do the above trace function lead to some printfs which will be helpful for debugging. If yes, where I can see the trace logs. I have not been able to find the definition of these trace functions. Thanks Anshul Makkar www.justkernel.com On Tue, May 27, 2014

Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check

2014-05-28 Thread Cornelia Huck
On Wed, 28 May 2014 09:52:38 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 28 May 2014 09:46, Cornelia Huck cornelia.h...@de.ibm.com wrote: The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified

Re: [Qemu-devel] [PATCH v10 00/18] Vhost and vhost-net support for userspace based backends

2014-05-28 Thread Nikolay Nikolaev
Hello, On Wed, May 28, 2014 at 11:43 AM, Anshul Makkar anshul.mak...@profitbricks.com wrote: Hi, We are also trying to develop a solution where we can implement the switch in the user mode (thinking of using VDE) and then rdma packet directly to other end without involving the kernel

Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency()

2014-05-28 Thread Kevin Wolf
Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben: On error path. Introduced in commit a046433a. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Heh, that fail: label you're jumping to is well hidden in some random error check in the middle of the function.

Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails

2014-05-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben: Reproducer: open -o a=b. Broken in commit fd0fee3. Signed-off-by: Markus Armbruster arm...@redhat.com Missing empty line in the commit message. Another one that I can fix up while applying if

Re: [Qemu-devel] [PATCH] q35: Fix memory_region_del_eventfd: Assertion `i != mr-ioeventfd_nb' failed.

2014-05-28 Thread Marcel Apfelbaum
On Tue, 2014-05-27 at 12:28 -0400, Etienne Martineau wrote: Hi, When using virtio disk plug/unplug with q35 machine I see two problems. Note that when using the same sequence with default 440FX I see no issues. Hi Etienne, thank you for reporting the problem. A) 'pcie.0' does not support

Re: [Qemu-devel] [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere

2014-05-28 Thread Juan Quintela
Sebastian Tanase sebastian.tan...@openwide.fr wrote: icount_time_shift is used for calculting the delay qemu has to sleep in order to synchronise the host and guest clocks. Therefore, we need it in cpu-exec.c. Signed-off-by: Sebastian Tanase sebastian.tan...@openwide.fr Tested-by: Camille

Re: [Qemu-devel] [RFC PATCH 3/4] cpu_exec: Add sleeping algorithm

2014-05-28 Thread Sebastian Tanase
- Mail original - De: Paolo Bonzini pbonz...@redhat.com À: Sebastian Tanase sebastian.tan...@openwide.fr Cc: aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, peter maydell peter.mayd...@linaro.org, mich...@walle.cc, a...@alex.org.uk, stefa...@redhat.com, kw...@redhat.com,

Re: [Qemu-devel] [qom/qom-cpu PATCH] i386: invtsc migration blocker is redudant

2014-05-28 Thread Juan Quintela
Eduardo Habkost ehabk...@redhat.com wrote: On Tue, May 27, 2014 at 11:39:20AM -0300, Marcelo Tosatti wrote: Migration blocker is redudant: blocking savevm is sufficient. Removing the redundancy looks welcome, but at the same time the migrate_add_blocker() call ensured we had a clearer

Re: [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model

2014-05-28 Thread Stefan Hajnoczi
On Wed, May 21, 2014 at 02:27:43PM -0400, Gabriel L. Somlo wrote: -#define TYPE_E1000 e1000 +#define TYPE_E1000 e1000-base Please rename to TYPE_E1000_BASE. It's confusing to call it TYPE_E1000 but then actually have a different type use the e1000 string. Besides that, I'm happy. Stefan

Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check

2014-05-28 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 28 May 2014 09:46, Cornelia Huck cornelia.h...@de.ibm.com wrote: The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS,

[Qemu-devel] [PATCH v2 05/14] qemu-io: Support multiple -o in open command

2014-05-28 Thread Markus Armbruster
Instead of ignoring all option values but the last one, multiple -o options now have the same meaning as having a single option with all settings in the order of their respective -o options. Same as commit 2dc8328 for qemu-img convert, except here we do it with QemuOpts rather than

[Qemu-devel] [PATCH v2 08/14] blockdev: Plug memory leak in blockdev_init()

2014-05-28 Thread Markus Armbruster
blockdev_init() leaks bs_opts when qemu_opts_create() fails, i.e. when the ID is bad. Missed in commit ec9c10d. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- blockdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 02/14] block/vvfat: Plug memory leak in enable_write_target()

2014-05-28 Thread Markus Armbruster
I figure the leak originated in bdrv_create2(), and was duplicated into callers when commit 91a073a dropped that function. Looks like the other places have since been fixed. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net ---

[Qemu-devel] [PATCH v2 14/14] qemu-img: Plug memory leak in convert command

2014-05-28 Thread Markus Armbruster
Introduced in commit 661a0f7. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 62ea27e..d118da5 100644 ---

Re: [Qemu-devel] [PATCH] docs: clarify that qcow2 file size is not always a cluster multiple

2014-05-28 Thread Stefan Hajnoczi
On Tue, May 27, 2014 at 05:56:35PM +0200, Markus Armbruster wrote: Benoît Canet benoit.ca...@irqsave.net writes: The Tuesday 27 May 2014 à 15:24:00 (+0200), Stefan Hajnoczi wrote : On Mon, May 26, 2014 at 04:36:15PM +0200, Benoît Canet wrote: The Thursday 22 May 2014 à 11:42:50 (+0200),

[Qemu-devel] [PATCH v2 11/14] block/vvfat: Plug memory leak in check_directory_consistency()

2014-05-28 Thread Markus Armbruster
On error path. Introduced in commit a046433a. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-devel] [PATCH v2 06/14] qemu-io: Plug memory leak in open command

2014-05-28 Thread Markus Armbruster
Introduced in commit b543c5c. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-io.c b/qemu-io.c index ef3fef6..f63e771 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -54,6 +54,7 @@ static int

[Qemu-devel] [PATCH v2 12/14] block/vvfat: Plug memory leak in read_directory()

2014-05-28 Thread Markus Armbruster
Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block/vvfat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index 2c82a5c..e26a179 100644 ---

Re: [Qemu-devel] [PATCH v2 00/14] block: Plug assorted memory leaks

2014-05-28 Thread Kevin Wolf
Am 28.05.2014 um 11:16 hat Markus Armbruster geschrieben: Most of them are probably harmless. Copying qemu-stable anyway, just in case. Also fix two qemu-io bugs I found while investigating its leaks. v2: * Fix commit hash in PATCH 02 [Kevin] * Plug another leak in PATCH 06 [Benoît] *

[Qemu-devel] [PATCH v2 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR

2014-05-28 Thread Markus Armbruster
Introduced in commit a8d8ecb. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block/qapi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qapi.c b/block/qapi.c index 75f44f1..97e1641 100644 --- a/block/qapi.c

[Qemu-devel] [PATCH v2 07/14] qemu-io: Don't print NULL when open without non-option arg fails

2014-05-28 Thread Markus Armbruster
Reproducer: open -o a=b. Broken in commit fd0fee3. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-io.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index f63e771..795cf46 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -62,7 +62,8 @@

[Qemu-devel] [PATCH v2 00/14] block: Plug assorted memory leaks

2014-05-28 Thread Markus Armbruster
Most of them are probably harmless. Copying qemu-stable anyway, just in case. Also fix two qemu-io bugs I found while investigating its leaks. v2: * Fix commit hash in PATCH 02 [Kevin] * Plug another leak in PATCH 06 [Benoît] * Improve commit message in PATCH 09 [Benoît] * Expand a tab in PATCH

Re: [Qemu-devel] [RFC PATCH 2/4] icount: Make icount_time_shift available everywhere

2014-05-28 Thread Sebastian Tanase
- Mail original - De: Juan Quintela quint...@redhat.com À: Sebastian Tanase sebastian.tan...@openwide.fr Cc: qemu-devel@nongnu.org, aligu...@amazon.com, afaer...@suse.de, r...@twiddle.net, peter maydell peter.mayd...@linaro.org, mich...@walle.cc, pbonz...@redhat.com,

[Qemu-devel] [PATCH v2 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths

2014-05-28 Thread Markus Armbruster
Introduced in commit 5a8a30d. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block/qcow2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index a4b97e8..a54d2ba 100644

[Qemu-devel] [PATCH v2 04/14] block: Plug memory leak on brv_open_image() error path

2014-05-28 Thread Markus Armbruster
Introduced in commit da557a. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index 40c5e1a..1996f84 100644 --- a/block.c +++ b/block.c @@

Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency()

2014-05-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben: On error path. Introduced in commit a046433a. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Heh, that fail: label you're jumping to is well hidden in some random error

[Qemu-devel] [PATCH v2 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create()

2014-05-28 Thread Markus Armbruster
Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block/sheepdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 2c3fb01..9a9a307

Re: [Qemu-devel] [PULL 00/33] Block patches

2014-05-28 Thread Stefan Hajnoczi
On Tue, May 27, 2014 at 06:15:29PM +0100, Peter Maydell wrote: On 23 May 2014 16:41, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging

Re: [Qemu-devel] [RFC PATCH 3/4] cpu_exec: Add sleeping algorithm

2014-05-28 Thread Juan Quintela
Sebastian Tanase sebastian.tan...@openwide.fr wrote: The goal is to sleep qemu whenever the guest clock is in advance compared to the host clock (we use the monotonic clocks). The amount of time to sleep is calculated in the execution loop in cpu_exec. Basically, using QEMU_CLOCK_REALTIME,

[Qemu-devel] [PATCH v2 09/14] blockdev: Plug memory leak in drive_init()

2014-05-28 Thread Markus Armbruster
bs_opts is leaked on all paths from its qdev_new() that don't got through blockdev_init(). Add the missing QDECREF(), and zap bs_opts after blockdev_init(), so the new QDECREF() does nothing when we go through blockdev_init(). Leak introduced in commit f298d07. Spotted by Coverity.

[Qemu-devel] [PATCH v2 01/14] qemu-img: Plug memory leak on block option help error path

2014-05-28 Thread Markus Armbruster
Introduced in commit a283cb6; mostly harmless. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- qemu-img.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-img.c b/qemu-img.c index 1ad899e..62ea27e 100644 ---

Re: [Qemu-devel] [PULL 00/33] Block patches

2014-05-28 Thread Stefan Hajnoczi
On Tue, May 27, 2014 at 06:15:29PM +0100, Peter Maydell wrote: On 23 May 2014 16:41, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging

Re: [Qemu-devel] [PULL 00/33] Block patches

2014-05-28 Thread Peter Maydell
On 28 May 2014 10:52, Stefan Hajnoczi stefa...@redhat.com wrote: On Tue, May 27, 2014 at 06:15:29PM +0100, Peter Maydell wrote: On 23 May 2014 16:41, Stefan Hajnoczi stefa...@redhat.com wrote: The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge

Re: [Qemu-devel] [PATCH 3/5] block: Use bdrv_nb_sectors() when sectors, not bytes are wanted

2014-05-28 Thread Kevin Wolf
Am 09.05.2014 um 18:27 hat Markus Armbruster geschrieben: Markus Armbruster arm...@redhat.com writes: Instead of bdrv_nb_sectors(). Aside: a few of these callers don't handle errors. I didn't investigate whether they should. Signed-off-by: Markus Armbruster arm...@redhat.com ---

Re: [Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_getlength()'s value

2014-05-28 Thread Kevin Wolf
Am 09.05.2014 um 11:48 hat Markus Armbruster geschrieben: It returns a multiple of the sector size. Signed-off-by: Markus Armbruster arm...@redhat.com Sooner or later this will change. If we do want to remove the rounding, how about adding an assertion instead so that we find those places at

Re: [Qemu-devel] [PATCH v3 06/24] target-ppc: Enable writes to user-privileged PMU registers

2014-05-28 Thread Alexey Kardashevskiy
On 05/27/2014 08:37 PM, Alexey Kardashevskiy wrote: This adds spr_write_ureg() helper and uses it for UPMCx and MMCR0 SPRs. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/translate_init.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-)

Re: [Qemu-devel] [PULL 00/10] input: add event routing and multiseat support.

2014-05-28 Thread Peter Maydell
On 26 May 2014 08:51, Gerd Hoffmann kra...@redhat.com wrote: Hi, Input layer continued: Adding input routing for multiseat. Also has some bugfixes. please pull, Gerd The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch

Re: [Qemu-devel] [PATCH 1/1] configure: robustify big/little check

2014-05-28 Thread Cornelia Huck
On Wed, 28 May 2014 11:16:09 +0200 Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 28 May 2014 09:46, Cornelia Huck cornelia.h...@de.ibm.com wrote: The check for big or little endianness relies on grep reporting match/non-match on the

[Qemu-devel] [Bug 1311614] Re: qemu-arm segfaults with gcc 4.9.0

2014-05-28 Thread Alexander
Fixed, thanks -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1311614 Title: qemu-arm segfaults with gcc 4.9.0 Status in QEMU: New Bug description: I have an ARM chroot that working with

[Qemu-devel] [PATCH v2 0/1] configure: avoid problems with grep customization

2014-05-28 Thread Cornelia Huck
Here's the next attempt to make configure a bit more robust, now copying what autoconf does as by Markus' suggestion. Cornelia Huck (1): configure: unset interfering variables configure | 5 + 1 file changed, 5 insertions(+) -- 1.8.5.5

[Qemu-devel] [PATCH v2 1/1] configure: unset interfering variables

2014-05-28 Thread Cornelia Huck
The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS, this will fail. Let's follow what autoconf does and unset GREP_OPTIONS and CLICOLOR_FORCE at the beginning of the

Re: [Qemu-devel] [PATCH v3 06/24] target-ppc: Enable writes to user-privileged PMU registers

2014-05-28 Thread Alexey Kardashevskiy
On 05/28/2014 08:07 PM, Alexey Kardashevskiy wrote: On 05/27/2014 08:37 PM, Alexey Kardashevskiy wrote: This adds spr_write_ureg() helper and uses it for UPMCx and MMCR0 SPRs. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/translate_init.c | 25 +++--

Re: [Qemu-devel] [PATCH v3 10/24] target-ppc: Introduce and reuse generalized init_proc_POWER()

2014-05-28 Thread Alexander Graf
On 28.05.14 03:20, Alexey Kardashevskiy wrote: On 05/28/2014 10:36 AM, Alexander Graf wrote: On 28.05.14 02:20, Alexey Kardashevskiy wrote: On 05/28/2014 10:07 AM, Alexander Graf wrote: On 27.05.14 12:37, Alexey Kardashevskiy wrote: At the moment every POWER CPU family has its own

Re: [Qemu-devel] [PATCH v3 06/24] target-ppc: Enable writes to user-privileged PMU registers

2014-05-28 Thread Alexander Graf
On 28.05.14 04:28, Alexey Kardashevskiy wrote: On 05/28/2014 10:03 AM, Alexander Graf wrote: On 27.05.14 12:37, Alexey Kardashevskiy wrote: This adds spr_write_ureg() helper and uses it for UPMCx and MMCR0 SPRs. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] [PATCH] linux-user: Don't overrun guest buffer in sched_getaffinity

2014-05-28 Thread Peter Maydell
On 15 May 2014 14:40, Peter Maydell peter.mayd...@linaro.org wrote: If the guest's long type is smaller than the host's, then our sched_getaffinity wrapper needs to round the buffer size up to a multiple of the host sizeof(long). This means that when we copy the data back from the host buffer

Re: [Qemu-devel] [PULL 00/24] gtk: ui overhaul, multiwindow support.

2014-05-28 Thread Peter Maydell
On 26 May 2014 09:13, Gerd Hoffmann kra...@redhat.com wrote: Hi, This series adds multiwindow support to the gtk ui. Also brings some cleanups and bugfixes. cheers, Gerd The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch

Re: [Qemu-devel] [PATCH v3 22/34] trace: add acpi memory hotplug IO region events

2014-05-28 Thread Igor Mammedov
On Wed, 28 May 2014 11:00:25 +0200 Anshul Makkar anshul.mak...@profitbricks.com wrote: Hi, Sorry, for this basic question. Do the above trace function lead to some printfs which will be helpful for debugging. If yes, where I can see the trace logs. I have not been able to find the

Re: [Qemu-devel] [PATCH 3/5] block: Use bdrv_nb_sectors() when sectors, not bytes are wanted

2014-05-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.05.2014 um 18:27 hat Markus Armbruster geschrieben: Markus Armbruster arm...@redhat.com writes: Instead of bdrv_nb_sectors(). Aside: a few of these callers don't handle errors. I didn't investigate whether they should. Signed-off-by:

Re: [Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_getlength()'s value

2014-05-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.05.2014 um 11:48 hat Markus Armbruster geschrieben: It returns a multiple of the sector size. Signed-off-by: Markus Armbruster arm...@redhat.com Sooner or later this will change. If we do want to remove the rounding, how about adding an assertion

Re: [Qemu-devel] [v2 PATCH] target-mips: implement UserLocal Register

2014-05-28 Thread James Hogan
On 27/05/14 17:01, James Hogan wrote: On 26/05/14 22:18, Andreas Färber wrote: Am 26.05.2014 19:28, schrieb Petar Jovanovic: RDHWR instruction. To do so, bit 29 of the HWREna register must be set to a 1 to enable unprivileged access to the register. Signed-off-by: Petar Jovanovic

[Qemu-devel] [PATCH 2/3] Pass optional destination version hint to migrate

2014-05-28 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Allow a VersionInfo to be passed as an option to migrate to indicate the destination QEMU version. It's intended to help those having to provide compatibility between minor versions (irrespective of what might have happened in a previous minor)

[Qemu-devel] [PATCH 1/3] hmp: Allow options with parameters

2014-05-28 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com HMP currently allows optional string parameters, however where there are multiple optional string parameters the order and interdependence of them becomes complex. Allow optional parameters of the form: -x string Also, add a hint to

[Qemu-devel] [PATCH 3/3] Add optional migrate version to hmp migrate command

2014-05-28 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Uses the new 'optional parameter with string' parameter type e.g. migrate -v 2.0.0 (foo) exec: whatever Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- hmp-commands.hx | 7 ++-- hmp.c | 106

Re: [Qemu-devel] [PATCH 5/5] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-28 Thread Kevin Wolf
Am 09.05.2014 um 11:48 hat Markus Armbruster geschrieben: bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster arm...@redhat.com @@ -1167,7 +1174,7 @@ static int img_convert(int argc, char

[Qemu-devel] [PATCH 0/3] Migrate with destination version

2014-05-28 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com This patch set provides an optional parameter to 'migrate' giving the destination QEMU version, it's intended for those having to maintain compatibility between minor versions (including downstream versions) and also for those who need to think

Re: [Qemu-devel] [PATCH v7 3/3] sPAPR: EEH support for VFIO PCI device

2014-05-28 Thread Alexander Graf
On 28.05.14 06:12, Gavin Shan wrote: On Wed, May 28, 2014 at 12:41:37AM +0200, Alexander Graf wrote: On 28.05.14 00:27, Benjamin Herrenschmidt wrote: On Wed, 2014-05-28 at 00:22 +0200, Alexander Graf wrote: .../... In any case, the above isn't the problem, we register rtas functions called

Re: [Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

2014-05-28 Thread Paolo Bonzini
Il 27/05/2014 22:30, Bandan Das ha scritto: @@ -996,15 +995,14 @@ static inline void cpu_x86_load_seg_cache(CPUX86State *env, #endif { /* legacy / compatibility case */ -if (!(env-cr[0] CR0_PE_MASK)) -cpl = 0; -

Re: [Qemu-devel] [PATCH] docs: clarify that qcow2 file size is not always a cluster multiple

2014-05-28 Thread Kevin Wolf
Am 27.05.2014 um 19:45 hat Benoît Canet geschrieben: The Tuesday 27 May 2014 à 17:29:16 (+0200), Paolo Bonzini wrote : Il 27/05/2014 18:00, Benoît Canet ha scritto: Are you worried that the host file system will lay out data poorly because the file looks like this? | header (1C) |

Re: [Qemu-devel] master: intermittent acpi-test failures

2014-05-28 Thread Peter Maydell
On 27 May 2014 22:38, Peter Maydell peter.mayd...@linaro.org wrote: I'm seeing this test failure intermittently on 'make check': ERROR:/root/qemu/tests/acpi-test.c:618:test_acpi_one: assertion failed (signature == SIGNATURE): (0x == 0xdead) GTester: last random seed:

Re: [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM, user-mode emulation and VM86 mode

2014-05-28 Thread Paolo Bonzini
Il 27/05/2014 22:33, Bandan Das ha scritto: With the next patch, these need to be correct or VM86 tasks have the wrong CPL. The flags are basically what the Intel VMX documentation say is mandatory for entry into a VM86 guest. Are you referring to 26.3.1.2 ? Yes: CS, SS, DS, ES, FS, GS.

Re: [Qemu-devel] [PATCH v2 8/8] spapr_pci: Use XICS interrupt allocator and do not cache interrupts in PHB

2014-05-28 Thread Alexander Graf
On 28.05.14 03:18, Alexey Kardashevskiy wrote: On 05/28/2014 10:41 AM, Alexander Graf wrote: On 28.05.14 02:34, Alexey Kardashevskiy wrote: On 05/28/2014 09:55 AM, Alexander Graf wrote: ... How do I migrate GHashTable? If I am allowed to use custom and bit more polished get/put from

Re: [Qemu-devel] [PATCH 3/3] Add optional migrate version to hmp migrate command

2014-05-28 Thread Juan Quintela
Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Uses the new 'optional parameter with string' parameter type e.g. migrate -v 2.0.0 (foo) exec: whatever Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com diff --git a/hmp.c

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA

2014-05-28 Thread Stefano Stabellini
On Tue, 27 May 2014, Roger Pau Monné wrote: On 27/05/14 18:18, Stefano Stabellini wrote: On Fri, 23 May 2014, Roger Pau Monne wrote: ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the hypervisor are translated to ENOENT. Also, the error code is returned in errno if the

Re: [Qemu-devel] [PATCH 0/3] Migrate with destination version

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 13:20, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com This patch set provides an optional parameter to 'migrate' giving the destination QEMU version, it's intended for those having to maintain compatibility between minor versions

Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations

2014-05-28 Thread Kevin Wolf
Am 22.05.2014 um 17:50 hat Stefan Hajnoczi geschrieben: On Wed, May 21, 2014 at 06:28:00PM +0200, Kevin Wolf wrote: @@ -2270,7 +2270,10 @@ int bdrv_commit(BlockDriverState *bs) } total_sectors = length BDRV_SECTOR_BITS; -buf = g_malloc(COMMIT_BUF_SECTORS *

Re: [Qemu-devel] [PATCH 5/5] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 09.05.2014 um 11:48 hat Markus Armbruster geschrieben: bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster arm...@redhat.com @@ -1167,7 +1174,7 @@

[Qemu-devel] [PATCH 1/1] bsd-user: add HOST_VARIANT_DIR for various *BSD dependent code

2014-05-28 Thread Sean Bruno
From: Stacey Son s...@freebsd.org This change adds HOST_VARIANT_DIR so the various BSD OS dependent code can be seperated into its own directories rather than using #ifdef's. This may also allow an BSD variant OS to host another BSD variant's executible as a target. --- Makefile.target | 3

Re: [Qemu-devel] master: intermittent acpi-test failures

2014-05-28 Thread Michael S. Tsirkin
On Wed, May 28, 2014 at 12:29:43PM +0100, Peter Maydell wrote: On 27 May 2014 22:38, Peter Maydell peter.mayd...@linaro.org wrote: I'm seeing this test failure intermittently on 'make check': ERROR:/root/qemu/tests/acpi-test.c:618:test_acpi_one: assertion failed (signature == SIGNATURE):

Re: [Qemu-devel] [PATCH 0/3] Migrate with destination version

2014-05-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: Il 28/05/2014 13:20, Dr. David Alan Gilbert (git) ha scritto: From: Dr. David Alan Gilbert dgilb...@redhat.com This patch set provides an optional parameter to 'migrate' giving the destination QEMU version, it's intended for those having to

Re: [Qemu-devel] [PATCH v3 0/9] spapr_pci: Prepare for VFIO

2014-05-28 Thread Alexander Graf
On 27.05.14 07:36, Alexey Kardashevskiy wrote: This patchset prepares QEMU for VFIO support on SPAPR. It also does preparations for Dynamic DMA window feature which allows to create DMA windows with 16MB IOMMU pages which will allow to map the entire guest RAM for DMA at almost no cost. The

Re: [Qemu-devel] [PATCH 5/8] qemu-bridge-helper: Fix fd leak in main()

2014-05-28 Thread Gonglei (Arei)
-Original Message- From: Stefan Hajnoczi [mailto:stefa...@redhat.com] Sent: Tuesday, May 27, 2014 7:32 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; av1...@comtv.ru; kra...@redhat.com; lcapitul...@redhat.com; ler...@redhat.com; qiaonuo...@cn.fujitsu.com; afaer...@suse.de;

Re: [Qemu-devel] [PATCH 7/8] dump: Fix use-after-free in create_kdump_vmcore()

2014-05-28 Thread Gonglei (Arei)
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, May 27, 2014 6:07 PM To: Gonglei (Arei); lcapitul...@redhat.com Cc: qemu-devel@nongnu.org; av1...@comtv.ru; kra...@redhat.com; qiaonuo...@cn.fujitsu.com; afaer...@suse.de; ebl...@redhat.com;

Re: [Qemu-devel] [PATCH 3/8] json-parser: fix two coverity defects

2014-05-28 Thread Gonglei (Arei)
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Tuesday, May 27, 2014 9:35 PM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: kw...@redhat.com; chenliang (T); peter.crosthwa...@xilinx.com; Huangweidong (C); aligu...@amazon.com;

Re: [Qemu-devel] [PATCH 6/8] smbus: Fix unreachable code in smb_transaction()

2014-05-28 Thread Gonglei (Arei)
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Wednesday, May 28, 2014 4:01 PM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: kw...@redhat.com; peter.crosthwa...@xilinx.com; Huangweidong (C); stefa...@redhat.com;

Re: [Qemu-devel] [PATCH 3/3] Add optional migrate version to hmp migrate command

2014-05-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Dr. David Alan Gilbert (git) dgilb...@redhat.com wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Uses the new 'optional parameter with string' parameter type e.g. migrate -v 2.0.0 (foo) exec: whatever Signed-off-by: Dr. David

Re: [Qemu-devel] [RFC PATCH] trace: Replace error with warning if event is not defined

2014-05-28 Thread Stefan Hajnoczi
On Wed, May 21, 2014 at 06:16:01PM +1000, Alexey Kardashevskiy wrote: At the moment QEMU exits if trace point is not defined which makes a developer life harder if he has to switch between branches with different traces implemented. This replaces error+exit wit WARNING if the tracepoint does

Re: [Qemu-devel] [PATCH v2 1/1] configure: unset interfering variables

2014-05-28 Thread Eric Blake
On 05/28/2014 04:39 AM, Cornelia Huck wrote: The check for big or little endianness relies on grep reporting match/non-match on the generated binary. If the user specified --binary-files=without-match in their GREP_OPTIONS, this will fail. Let's follow what autoconf does and unset

Re: [Qemu-devel] qemu 2.0, deadlock in block-commit

2014-05-28 Thread Stefan Hajnoczi
On Mon, May 26, 2014 at 02:58:35PM +0200, Marcin Gibuła wrote: Two options for making progress on this bug: 1. Debug bdrv_drain_all() and find out whether there are any I/O requests remaining. Yes, there is one request pending on active layer of disk that is being commited (on

Re: [Qemu-devel] [PATCH 1/8] vnc-enc-tight: Fix divide-by-zero in tight_detect_smooth_image{16, 24, 32}

2014-05-28 Thread Gonglei (Arei)
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Tuesday, May 27, 2014 9:34 PM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: kw...@redhat.com; peter.crosthwa...@xilinx.com; Huangweidong (C); aligu...@amazon.com;

  1   2   3   4   >