Re: [Qemu-devel] [PATCH] scsi: Report error when lun number is in use

2014-06-11 Thread Fam Zheng
On Tue, 06/10 10:18, Paolo Bonzini wrote: Il 10/06/2014 08:55, Fam Zheng ha scritto: In the case that the lun number is taken by another scsi device, don't release the existing device siliently, but report an error to user. Signed-off-by: Fam Zheng f...@redhat.com --- hw/scsi/scsi-bus.c |

Re: [Qemu-devel] [PATCH 1/6] qemu-char: introduce qemu_chr_alloc

2014-06-11 Thread Fam Zheng
On Tue, 06/03 18:39, Paolo Bonzini wrote: The next patch will modify this function to initialize state that is common to all backends. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com --- backends/baum.c | 2 +- backends/msmouse.c| 2 +-

Re: [Qemu-devel] [PATCH 2/6] qemu-char: do not call chr_write directly

2014-06-11 Thread Fam Zheng
On Tue, 06/03 18:39, Paolo Bonzini wrote: Make the mux always go through qemu_chr_fe_write, so that we'll get the mutex for the underlying chardev. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com --- qemu-char.c | 14 +++--- 1 file

Re: [Qemu-devel] [PATCH 3/6] qemu-char: move pty_chr_update_read_handler around

2014-06-11 Thread Fam Zheng
On Tue, 06/03 18:39, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com --- qemu-char.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexey Kardashevskiy
On 06/11/2014 12:41 AM, Cornelia Huck wrote: On Tue, 10 Jun 2014 09:39:51 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Wed, 4 Jun 2014 18:08:47 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This introduces an NMI (non maskable interrupt) callback per CPU class which QMP's

Re: [Qemu-devel] [PATCH 4/6] qemu-char: make writes thread-safe

2014-06-11 Thread Fam Zheng
On Tue, 06/03 18:39, Paolo Bonzini wrote: diff --git a/qemu-char.c b/qemu-char.c index b478a3d..dcd0765 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -121,7 +121,12 @@ void qemu_chr_be_generic_open(CharDriverState *s) int qemu_chr_fe_write(CharDriverState *s, const uint8_t *buf, int len)

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-11 Thread Santosh Shukla
Hi Igor, I tried building your repository and got build break on ssdt-mem.hex, have you face this problem or Its just me (:- No rule to make target `hw/i386/ssdt-mem.hex', needed by `hw/i386/acpi-build.o'. Stop using this rule to qemu config: ../configure --enable-kvm --enable-debug

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 08:50, Alexey Kardashevskiy ha scritto: And I changed x86 to inject NMI on the default CPU only (used to be on all CPUs), and I wonder again if it is actually ok and won't break things. For x86 it is better to send it to one CPU only. Paolo

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 06:59, Paolo Bonzini wrote: Il 11/06/2014 02:28, Alexander Graf ha scritto: Am 11.06.2014 um 02:23 schrieb Peter Maydell peter.mayd...@linaro.org: On 10 June 2014 19:09, Alexander Graf ag...@suse.de wrote: I agree. I see two different paths forward: 1) Use the patches as

Re: [Qemu-devel] [PATCH v5 08/16] hostmem: add file-based HostMemoryBackend

2014-06-11 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 07:15:21PM +0800, Hu Tao wrote: From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- backends/Makefile.objs | 1 + backends/hostmem-file.c | 107

[Qemu-devel] [PATCH] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexey Kardashevskiy
From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7 and SLES11 guests fallback to INTX. One way to workaround the issue is to increase total MSIs,

Re: [Qemu-devel] [PATCH] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexander Graf
On 11.06.14 10:05, Alexey Kardashevskiy wrote: From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7 and SLES11 guests fallback to INTX. One way

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-11 Thread Michael S. Tsirkin
On Wed, Jun 11, 2014 at 12:43:03PM +0530, Santosh Shukla wrote: Hi Igor, I tried building your repository and got build break on ssdt-mem.hex, have you face this problem or Its just me (:-  No rule to make target `hw/i386/ssdt-mem.hex', needed by `hw/i386/ acpi-build.o'.  Stop using

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexander Graf
On 11.06.14 10:06, Alexander Graf wrote: On 11.06.14 10:05, Alexey Kardashevskiy wrote: From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Andreas Färber
Am 27.05.2014 02:39, schrieb Peter Crosthwaite: Certain parts of the QOM framework test this pointer to determine if an object is parented. Nuke it when the object is unparented to allow for reuse of an object after unparenting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

Re: [Qemu-devel] [PATCH 4/6] qemu-char: make writes thread-safe

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 08:59, Fam Zheng ha scritto: On Tue, 06/03 18:39, Paolo Bonzini wrote: diff --git a/qemu-char.c b/qemu-char.c index b478a3d..dcd0765 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -121,7 +121,12 @@ void qemu_chr_be_generic_open(CharDriverState *s) int

Re: [Qemu-devel] [PATCH] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexey Kardashevskiy
On 06/11/2014 06:06 PM, Alexander Graf wrote: On 11.06.14 10:05, Alexey Kardashevskiy wrote: From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest.

Re: [Qemu-devel] [PATCH] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexander Graf
On 11.06.14 10:18, Alexey Kardashevskiy wrote: On 06/11/2014 06:06 PM, Alexander Graf wrote: On 11.06.14 10:05, Alexey Kardashevskiy wrote: From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr: add uuid/host details to device tree

2014-06-11 Thread Alexey Kardashevskiy
On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] ppc: spapr-rtas - implement os-term rtas call

2014-06-11 Thread Alexey Kardashevskiy
On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: PAPR compliant guest calls this in absence of kdump. After receiving this call qemu could trigger a guest dump. This guest dump can be used to analyse using crash tool. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:01, Alexander Graf ha scritto: Personally, I don't see anything wrong in these patches, apart from the typo that Cornelia pointed out. If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99 or -M g3beige you would have to trigger an interrupt with the MPIC, not

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 10:27, Paolo Bonzini wrote: Il 11/06/2014 10:01, Alexander Graf ha scritto: Personally, I don't see anything wrong in these patches, apart from the typo that Cornelia pointed out. If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99 or -M g3beige you would have

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need something different thanks to his need to inject the NMI on all CPUs. What about an

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 16:50:35 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/11/2014 12:41 AM, Cornelia Huck wrote: On Tue, 10 Jun 2014 09:39:51 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Wed, 4 Jun 2014 18:08:47 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote:

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need something different thanks to his need to inject

[Qemu-devel] [PATCH v2] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexey Kardashevskiy
From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7 and SLES11 guests fallback to INTX. One way to workaround the issue is to increase total MSIs,

[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. This patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexey Kardashevskiy
On 06/11/2014 10:28 AM, Alexander Graf wrote: Am 11.06.2014 um 02:23 schrieb Peter Maydell peter.mayd...@linaro.org: On 10 June 2014 19:09, Alexander Graf ag...@suse.de wrote: I agree. I see two different paths forward: 1) Use the patches as they are - they seem pretty sound and take

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 10:38:14 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Wed, 11 Jun 2014 16:50:35 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/11/2014 12:41 AM, Cornelia Huck wrote: On Tue, 10 Jun 2014 09:39:51 -0400 Luiz Capitulino lcapitul...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 11:04, Alexey Kardashevskiy wrote: On 06/11/2014 10:28 AM, Alexander Graf wrote: Am 11.06.2014 um 02:23 schrieb Peter Maydell peter.mayd...@linaro.org: On 10 June 2014 19:09, Alexander Graf ag...@suse.de wrote: I agree. I see two different paths forward: 1) Use the patches

Re: [Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-11 Thread Gonglei (Arei)
Hi, Gerd, do you plan to apply and pull the patch serials? Thanks! I have finished some qtest cases for usb host adapters hotpug/unplug. Best regards, -Gonglei -Original Message- From: Gonglei (Arei) Sent: Wednesday, June 04, 2014 4:32 PM To: qemu-devel@nongnu.org Cc:

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-11 Thread Santosh Shukla
On Wed, Jun 11, 2014 at 1:38 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 11, 2014 at 12:43:03PM +0530, Santosh Shukla wrote: Hi Igor, I tried building your repository and got build break on ssdt-mem.hex, have you face this problem or Its just me (:- No rule to make

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-11 Thread Michael S. Tsirkin
On Wed, Jun 11, 2014 at 03:05:07PM +0530, Santosh Shukla wrote: On Wed, Jun 11, 2014 at 1:38 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 11, 2014 at 12:43:03PM +0530, Santosh Shukla wrote: Hi Igor, I tried building your repository and got build break

Re: [Qemu-devel] [PATCH] block: Drop superfluous conditionals around g_free()

2014-06-11 Thread Stefan Hajnoczi
On Fri, Jun 06, 2014 at 06:25:12PM +0200, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- block/curl.c | 9 +++-- block/iscsi.c | 4 +--- hw/block/onenand.c | 4 +--- 3 files changed, 5 insertions(+), 12 deletions(-) Thanks, applied to my

Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

2014-06-11 Thread Ian Campbell
On Tue, 2014-06-10 at 09:44 +0200, Gerd Hoffmann wrote: On So, 2014-06-08 at 11:30 +0100, Ian Campbell wrote: On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote: Have a global timer. Update all visible terminal windows syncronously. Right now this can be the active_console only, but

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 6:13 PM, Andreas Färber afaer...@suse.de wrote: Am 27.05.2014 02:39, schrieb Peter Crosthwaite: Certain parts of the QOM framework test this pointer to determine if an object is parented. Nuke it when the object is unparented to allow for reuse of an object after

Re: [Qemu-devel] [PULL 0/4] migration queue

2014-06-11 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Il 10/06/2014 18:31, Juan Quintela ha scritto: Hi This includes: - last two patches that remove version_minimum_id_old. - refactor of opening of files was already tested (this is test-vmstate only) - v4 of flags in ram_load from Peter. Please,

Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug

2014-06-11 Thread Santosh Shukla
On Wed, Jun 11, 2014 at 3:24 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 11, 2014 at 03:05:07PM +0530, Santosh Shukla wrote: On Wed, Jun 11, 2014 at 1:38 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 11, 2014 at 12:43:03PM +0530, Santosh Shukla wrote:

[Qemu-devel] [PATCH] PPC: KVM: Make pv hcall endian agnostic

2014-06-11 Thread Alexander Graf
There were a few revisions of the Linux kernel that incorrectly swapped the hcall instructions when they saw ePAPR compliant hypercalls. We already have fixups for those in place when running with PR KVM, but HV KVM and systems that don't implement hypercalls at all are still broken because they

Re: [Qemu-devel] [PATCH] blockdev: Move 'serial' option to drive_init()

2014-06-11 Thread Stefan Hajnoczi
On Fri, Jun 06, 2014 at 03:21:48PM +0200, Kevin Wolf wrote: It is not available with blockdev-add. Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Thanks, applied to my block tree:

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2014-06-11 Thread Michal Suchanek
I can connect to network with qemu 2.0 with and win 7 pro 64bit guest. qemu-system-x86_64 -machine accel=kvm -smp 2 -m 1024 -net none -device usb-ehci,id=usb,bus=pci.0,addr=0x4 -device usb- host,vendorid=0x0b95,productid=0x772b,id=hostdev0,bus=usb.0 -usb -usbdevice tablet -hda

Re: [Qemu-devel] [PATCH v4 00/21] block: Handle failure for potentially large allocations

2014-06-11 Thread Stefan Hajnoczi
On Thu, Jun 05, 2014 at 03:36:12PM +0200, Kevin Wolf wrote: A not too small part of the recent CVEs were DoS scenarios by letting qemu abort with too large memory allocations. We generally fixed these cases by setting some limits on values read from image files that influence the size of

Re: [Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-06-11 Thread Stefano Stabellini
On Tue, 10 Jun 2014, Ian Campbell wrote: On Fri, 2014-05-23 at 17:07 +0100, Stefano Stabellini wrote: Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for sure what is the machine that we are emulating. Does 1.6 here refer to the qemu version? Yes, every new QEMU version

Re: [Qemu-devel] [PATCH 0/3] block: Minor cleanups

2014-06-11 Thread Stefan Hajnoczi
On Fri, Jun 06, 2014 at 02:50:57PM +0200, Markus Armbruster wrote: Markus Armbruster (3): blockdev: Rename drive_init(), drive_uninit() to drive_new(), drive_del() blockdev: Remove unused DriveInfo reference count block/qapi: Give some functions internal linkage block/qapi.c

Re: [Qemu-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-06-11 Thread Ian Campbell
On Wed, 2014-06-11 at 11:35 +0100, Stefano Stabellini wrote: On Tue, 10 Jun 2014, Ian Campbell wrote: On Fri, 2014-05-23 at 17:07 +0100, Stefano Stabellini wrote: I think that the dependency on QEMU = 1.6 is OK. The Xen PV Device went in v1.6.0 and we certainy cannot go back to versions older

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/virt: Provide flash devices for boot ROMs

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 3:06 AM, Peter Maydell peter.mayd...@linaro.org wrote: Add two flash devices to the virt board, so that it can be used for running guests which want a bootrom image such as UEFI. We provide two flash devices to make it more convenient to provide both a read-only UEFI

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:42, Alexander Graf ha scritto: On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Benjamin Herrenschmidt
On Wed, 2014-06-11 at 12:47 +0200, Paolo Bonzini wrote: Ok, I can buy removing the support for CPU != 0. But still, the overengineering remains. If Alexey needs to trigger the NMI on all CPUs, simply moving the new method from CPU to Machine, and blindly using first_cpu in s390 and x86

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Andreas Färber
Am 11.06.2014 12:19, schrieb Peter Crosthwaite: On Wed, Jun 11, 2014 at 6:13 PM, Andreas Färber afaer...@suse.de wrote: Am 27.05.2014 02:39, schrieb Peter Crosthwaite: Certain parts of the QOM framework test this pointer to determine if an object is parented. Nuke it when the object is

Re: [Qemu-devel] [PATCH v3 2/4] qemu-bridge-helper: Fix fd leak in main()

2014-06-11 Thread Stefan Hajnoczi
On Tue, Jun 10, 2014 at 05:20:25PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com initialize fd and ctlfd, and close them at the end Signed-off-by: Gonglei arei.gong...@huawei.com --- qemu-bridge-helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 13:28, Andreas Färber ha scritto: Am 11.06.2014 12:19, schrieb Peter Crosthwaite: On Wed, Jun 11, 2014 at 6:13 PM, Andreas Färber afaer...@suse.de wrote: Am 27.05.2014 02:39, schrieb Peter Crosthwaite: Certain parts of the QOM framework test this pointer to determine if an

Re: [Qemu-devel] [PATCH] virtio.c: fix error message

2014-06-11 Thread Benoît Canet
The Tuesday 10 Jun 2014 à 19:58:44 (+0400), Michael Tokarev wrote : Suggested-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/virtio/virtio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c

Re: [Qemu-devel] [PATCH] block/nfs: fix potential segfault on early callback

2014-06-11 Thread Stefan Hajnoczi
On Tue, Jun 10, 2014 at 09:42:47AM +0200, Peter Lieven wrote: it will happen in the future that the callback of a libnfs call directly invokes the callback. In this case we end up in a segfault because the NFSRPC is gone when we the BH is scheduled. Signed-off-by: Peter Lieven p...@kamp.de

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 9:28 PM, Andreas Färber afaer...@suse.de wrote: Am 11.06.2014 12:19, schrieb Peter Crosthwaite: On Wed, Jun 11, 2014 at 6:13 PM, Andreas Färber afaer...@suse.de wrote: Am 27.05.2014 02:39, schrieb Peter Crosthwaite: Certain parts of the QOM framework test this pointer

Re: [Qemu-devel] [Qemu-ppc] Fwd: Patch: fix to gen_mcrxr() in target-ppc/translate.c

2014-06-11 Thread Tom Musta
On 6/11/2014 3:01 AM, Sorav Bansal wrote: [I had posted to qemu-ppc list earlier, reposting to qemu-devel also on being suggested to do so. Also adding some description about the patch] Hi, I saw a minor bug in the gen_mcrxr() function in target-ppc/translate.c. Here is the patch for

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-11 Thread Andreas Färber
Am 09.06.2014 19:02, schrieb Bandan Das: Paolo Bonzini pbonz...@redhat.com writes: Il 08/06/2014 12:46, Michael S. Tsirkin ha scritto: Tested-by: Michael S. Tsirkin m...@redhat.com You probably tested the reversal, actually. :) Actually, there is a reason for it. Unassembling the device

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 06/11/2014 12:47 PM, Paolo Bonzini wrote: Il 11/06/2014 10:42, Alexander Graf ha scritto: On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find

Re: [Qemu-devel] [PATCH v3 04/32] target-arm: add arm_is_secure() function

2014-06-11 Thread Sergey Fedorov
On 11.06.2014 03:54, Fabian Aggeler wrote: arm_is_secure() function allows to determine CPU security state if the CPU implements Security Extensions/EL3. arm_is_secure_below_el3() returns true if CPU is in secure state below EL3. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com

Re: [Qemu-devel] [PATCH v2] spapr_pci: Advertise MSI quota

2014-06-11 Thread Alexander Graf
On 06/11/2014 10:49 AM, Alexey Kardashevskiy wrote: From: Badari Pulavarty pbad...@us.ibm.com Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7 and SLES11 guests fallback to INTX. One

[Qemu-devel] [RFC PATCH 02/13] qom: object: remove parent pointer when unparenting

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Certain parts of the QOM framework test this pointer to determine if an object is parented. Nuke it when the object is unparented to allow for reuse of an object after unparenting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

[Qemu-devel] [RFC PATCH 00/13] Light memory region QOMification

2014-06-11 Thread Paolo Bonzini
This series is an approach to MemoryRegion QOMification that is complementary to Peter's posted patches. Instead of focusing on properties, it places attention on modeling the lifetime of memory regions correctly. MemoryRegions are added to the QOM tree as children of their owner device, and

[Qemu-devel] [RFC PATCH 05/13] memory: MemoryRegion: factor out subregion add functionality

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Split off the core looping code that actually adds subregions into it's own fn. This prepares support for Memory Region qomification where setting the MR address or parent via QOM will back onto this more minimal function. Signed-off-by: Peter

[Qemu-devel] [RFC PATCH 01/13] qom: object: Ignore refs/unrefs of NULL

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Just do nothing if passed NULL for a ref or unref. This avoids call sites that manage a combination of NULL or non-NULL pointers having to add iffery around every ref and unref. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com

[Qemu-devel] [RFC PATCH 11/13] memory: MemoryRegion: Add container and addr props

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Expose the already existing .parent and .addr fields as QOM properties. .parent (i.e. the field describing the memory region that contains this one in Memory hierachy) is renamed container. This is to avoid confusion with the QOM parent.

[Qemu-devel] [RFC PATCH 06/13] memory: MemoryRegion: factor out memory region re-adder

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com memory_region_set_address is mostly just a function that deletes and re-adds a memory region. Factor this generic functionality out into a re-usable function. This prepares support for further QOMification of MemoryRegion. Signed-off-by: Peter

[Qemu-devel] [RFC PATCH 09/13] memory: MemoryRegion: QOMify

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com QOMify memory regions as an Object. The former init() and destroy() routines become instance_init() and instance_finalize() resp. memory_region_init() is re-implemented to be: object_initialize() + set fields memory_region_destroy() is

[Qemu-devel] [RFC PATCH 08/13] memory: MemoryRegion: rename parent to container

2014-06-11 Thread Paolo Bonzini
Avoid confusion with the QOM parent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 20 ++-- memory.c | 38 +++--- 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/include/exec/memory.h

[Qemu-devel] [RFC PATCH 12/13] memory: MemoryRegion: Add may-overlap and priority props

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com QOM propertyify the .may-overlap and .priority fields. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [Remove setters. - Paolo] Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 2 +- memory.c

[Qemu-devel] [RFC PATCH 04/13] qom: delete properties before calling instance_finalize

2014-06-11 Thread Paolo Bonzini
This ensures that the children's unparent callback will still have a usable parent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 69a95d6..780aaa8 100644 --- a/qom/object.c

[Qemu-devel] [RFC PATCH 07/13] memory: MemoryRegion: use /machine as default owner

2014-06-11 Thread Paolo Bonzini
This will be used (after QOMification) as the QOM parent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 06a4af7..b40055c 100644 --- a/memory.c +++ b/memory.c @@ -848,7 +848,7 @@ void

[Qemu-devel] [RFC PATCH 13/13] memory: MemoryRegion: Add size property

2014-06-11 Thread Paolo Bonzini
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [Remove setter. - Paolo] Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- memory.c | 13 + 1 file changed, 13 insertions(+) diff --git a/memory.c b/memory.c index

[Qemu-devel] [RFC PATCH 10/13] memory: MemoryRegion: replace owner field with QOM parent

2014-06-11 Thread Paolo Bonzini
The two are now the same. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/exec/memory.h | 1 - memory.c | 35 +-- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

Re: [Qemu-devel] Use-after-free during unrealize in system_reset

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 14:03, Andreas Färber ha scritto: Still, isn't this an indication that devices relied on the PCI bus bug of not unrealizing its state all the time and we may need to go back as far as ~1.7 (the initial finalize based fix) for resolving it? No, I don't think so. The devices rely

[Qemu-devel] [RFC PATCH 03/13] qom: move unparenting to the child property's release callback

2014-06-11 Thread Paolo Bonzini
This ensures that the unparent callback is called automatically when the parent object is finalized. Note that there's no need to keep a reference neither in object_unparent nor in object_finalize_child_property. The reference held by the child property itself will do. Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH 1/3] ppc debug stub: Get trap instruction opcode from KVM

2014-06-11 Thread Alexander Graf
On 06/10/2014 05:06 PM, Bharat Bhushan wrote: Get trap instruction opcode from KVM and this opcode will be used for setting software breakpoint in following patch Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- target-ppc/kvm.c | 11 +++ 1 file changed, 11

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Wed, 11 Jun 2014 01:40:14 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/10/2014 11:39 PM, Luiz Capitulino wrote: On Wed, 4 Jun 2014 18:08:47 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: This introduces an NMI (non maskable interrupt) callback per CPU class which QMP's

[Qemu-devel] [PATCH 0/2] qdev: fix pci use-after-free

2014-06-11 Thread Paolo Bonzini
See Use-after-free during unrealize in system_reset thread and individual patches. Paolo Paolo Bonzini (2): qdev: reorganize error reporting in bus_set_realized qdev: recursively unrealize devices when unrealizing bus hw/core/qdev.c | 27 +++ 1 file changed, 15

[Qemu-devel] [PATCH 1/2] qdev: reorganize error reporting in bus_set_realized

2014-06-11 Thread Paolo Bonzini
No semantic change. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index e65a5aa..5efa251 100644 --- a/hw/core/qdev.c +++

[Qemu-devel] [PATCH 2/2] qdev: recursively unrealize devices when unrealizing bus

2014-06-11 Thread Paolo Bonzini
When the patch was posted that became 5c21ce7 (qdev: Realize buses on device realization, 2014-03-12), it included recursive realization and unrealization of devices when the bus's realized property was toggled. However, due to the same old worries about recursive realization and prerequisites

Re: [Qemu-devel] [PATCH v8 3/4] block: Add replaces argument to drive-mirror

2014-06-11 Thread Stefan Hajnoczi
On Tue, Jun 10, 2014 at 09:21:45AM +0200, Benoît Canet wrote: +BlockDriverState *check_to_replace_node(const char *node_name, Error **errp) +{ +BlockDriverState *to_replace_bs = bdrv_find_node(node_name); +if (!to_replace_bs) { +error_setg(errp, node_name=%s not found, +

Re: [Qemu-devel] [PATCH 3/3] ppc debug: Add debug stub support

2014-06-11 Thread Alexander Graf
On 06/10/2014 05:06 PM, Bharat Bhushan wrote: This patch adds software breakpoint, hardware breakpoint and hardware watchpoint support for ppc. If the debug interrupt is not handled then this is injected to guest. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- hw/ppc/e500.c

Re: [Qemu-devel] Using virtio for inter-VM communication

2014-06-11 Thread Vincent JARDIN
On 10/06/2014 18:48, Henning Schild wrote: Hi, In a first prototype i implemented a ivshmem[2] device for the hypervisor. That way we can share memory between virtual machines. Ivshmem is nice and simple but does not seem to be used anymore. And it does not define higher level devices, like

[Qemu-devel] Fwd: Patch: fix to gen_mcrxr() in target-ppc/translate.c

2014-06-11 Thread Sorav Bansal
[I had posted to qemu-ppc list earlier, reposting to qemu-devel also on being suggested to do so. Also adding some description about the patch] Hi, I saw a minor bug in the gen_mcrxr() function in target-ppc/translate.c. Here is the patch for your consideration. I have verified the patch by

Re: [Qemu-devel] [RFC PATCH 09/13] memory: MemoryRegion: QOMify

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com QOMify memory regions as an Object. The former init() and destroy() routines become instance_init() and instance_finalize() resp. memory_region_init() is

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Tue, 10 Jun 2014 18:29:43 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 10/06/2014 16:48, Luiz Capitulino ha scritto: The s390 restart interrupt is a per-vcpu interrupt, which we really don't want to inject on _all_ vcpus. OTOH, we want to inject that interrupt on any vcpu - we

[Qemu-devel] [PATCH v9 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

2014-06-11 Thread Benoît Canet
The to-replace-node-name is designed to allow repairing of broken Quorum file. This patch introduce a new class TestRepairQuorum testing that the feature works. Some further work will be done on QEMU to improve the robutness of the tests. Signed-off-by: Benoit Canet ben...@irqsave.net ---

[Qemu-devel] [PATCH v9 1/4] quorum: Add the rewrite-corrupted parameter to quorum

2014-06-11 Thread Benoît Canet
On read operations when this parameter is set and some replicas are corrupted while quorum can be reached quorum will proceed to rewrite the correct version of the data to fix the corrupted replicas. This will shine with SSD where the FTL will remap the same block at another place on rewrite.

[Qemu-devel] [PATCH v9 0/4] Quorum maintainance operations

2014-06-11 Thread Benoît Canet
in V9: fix leak [Stefan] fix error message [Stefan] relax constraint [Stefan] Benoît Canet (4): quorum: Add the rewrite-corrupted parameter to quorum block: Add node-name argument to drive-mirror block: Add replaces argument to drive-mirror qemu-iotests: Add

[Qemu-devel] [PATCH v9 3/4] block: Add replaces argument to drive-mirror

2014-06-11 Thread Benoît Canet
drive-mirror will bdrv_swap the new BDS named node-name with the one pointed by replaces when the mirroring is finished. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 17 ++ block/mirror.c| 60

Re: [Qemu-devel] [RFC PATCH 03/13] qom: move unparenting to the child property's release callback

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: This ensures that the unparent callback is called automatically when the parent object is finalized. Note that there's no need to keep a reference neither in object_unparent nor in object_finalize_child_property. The

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 09:10:36 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 10 Jun 2014 18:29:43 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 10/06/2014 16:48, Luiz Capitulino ha scritto: The s390 restart interrupt is a per-vcpu interrupt, which we really don't

[Qemu-devel] [PATCH] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-06-11 Thread David Marchand
When trying to use a ivshmem server with qemu, ivshmem init code tries to create a CharDriverState object for each eventfd retrieved from the server. To create this object, a call to qemu_chr_open_eventfd() is done. Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is called.

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Wed, 11 Jun 2014 15:36:57 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Wed, 11 Jun 2014 09:10:36 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 10 Jun 2014 18:29:43 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 10/06/2014 16:48, Luiz Capitulino ha

Re: [Qemu-devel] [RFC PATCH 08/13] memory: MemoryRegion: rename parent to container

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: Avoid confusion with the QOM parent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- include/exec/memory.h | 20 ++-- memory.c

Re: [Qemu-devel] [RFC PATCH 04/13] qom: delete properties before calling instance_finalize

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: This ensures that the children's unparent callback will still have a usable parent. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [RFC PATCH 03/13] qom: move unparenting to the child property's release callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 15:35, Peter Crosthwaite ha scritto: On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: This ensures that the unparent callback is called automatically when the parent object is finalized. Note that there's no need to keep a reference neither in

Re: [Qemu-devel] [RFC PATCH 10/13] memory: MemoryRegion: replace owner field with QOM parent

2014-06-11 Thread Peter Crosthwaite
On Wed, Jun 11, 2014 at 10:19 PM, Paolo Bonzini pbonz...@redhat.com wrote: The two are now the same. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- include/exec/memory.h | 1 - memory.c | 35

Re: [Qemu-devel] [RFC PATCH 04/13] qom: delete properties before calling instance_finalize

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 15:42, Peter Crosthwaite ha scritto: -object_deinit(obj, ti); object_property_del_all(obj); +object_deinit(obj, ti); Does this means you lose access to your own properties before calling your own finalisation? I guess its a non-issue if all clients just use

Re: [Qemu-devel] [PATCH 2/2] qdev: recursively unrealize devices when unrealizing bus

2014-06-11 Thread Michael S. Tsirkin
On Wed, Jun 11, 2014 at 02:52:09PM +0200, Paolo Bonzini wrote: When the patch was posted that became 5c21ce7 (qdev: Realize buses on device realization, 2014-03-12), it included recursive realization and unrealization of devices when the bus's realized property was toggled. However, due to

[Qemu-devel] [PATCH 5/9] block: Use common driver selection code for bdrv_open_file()

2014-06-11 Thread Kevin Wolf
This moves the bdrv_open_file() call a bit down so that it can use the bdrv_open() code that selects the right block driver. The code between the old and the new call site is either common code (the error message for an unknown driver has been unified now) or doesn't run with cleared

  1   2   3   >