Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-28 Thread Alexey Kardashevskiy
On 07/24/2014 11:15 PM, Alexander Graf wrote: On 18.07.14 06:31, cyril...@gmail.com wrote: It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a user cannot access the host. Signed-off-by: Cyril Bur

[Qemu-devel] [PATCH] target-i386/cpu.c: Fix two error output indentation

2014-07-28 Thread Chen Fan
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- target-i386/cpu.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6d008ab..217500c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1716,9 +1716,9 @@

Re: [Qemu-devel] [PATCH for-2.1 1/2] migration: load smaller RAMBlock to a bigger one if permitted

2014-07-28 Thread Igor Mammedov
On Fri, 25 Jul 2014 19:56:40 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/25/14 17:48, Igor Mammedov wrote: Add API to mark memory region as extend-able on migration, to allow migration code to load smaller RAMBlock into a bigger one on destination QEMU instance. This will allow

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-28 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 17/07/2014 13:01, Pavel Dovgalyuk ha scritto: This set of patches is related to the reverse execution and deterministic replay of qemu execution Our implementation of deterministic replay can be used for

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-28 Thread Alexander Graf
Am 28.07.2014 um 08:47 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On 07/24/2014 11:15 PM, Alexander Graf wrote: On 18.07.14 06:31, cyril...@gmail.com wrote: It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a

Re: [Qemu-devel] [PATCH for-2.1 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-07-28 Thread Igor Mammedov
On Fri, 25 Jul 2014 19:37:41 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 25/07/2014 17:48, Igor Mammedov ha scritto: It fixes migration failure for machine type pc-i440fx-1.7 from QEMU 1.7/2.0 to QEMU 2.1 Migration fails due to ACPI tables size grows across 1.7-2.1 versions.

[Qemu-devel] [PATCH for-2.1 v2 0/2] Fix migration failure due to ACPI tables size changes

2014-07-28 Thread Igor Mammedov
Changes since v2: - addressed Laszlo's comments * fixing typos, rewording comments * dropping enum-ification of RAMBlock flags * adding zeroing out destination ramblock * replacing 'if' with assert() Changing the ACPI table size causes migration to break, and the

[Qemu-devel] [PATCH for-2.1 v2 1/2] migration: load smaller RAMBlock to a bigger one if permitted

2014-07-28 Thread Igor Mammedov
Add API to mark memory region as extend-able on migration, to allow migration code to load smaller RAMBlock into a bigger one on destination QEMU instance. This will allow to fix broken migration from QEMU 1.7/2.0 to QEMU 2.1 due to ACPI tables size changes across 1.7/2.0/2.1 versions by marking

[Qemu-devel] [PATCH for-2.1 v2 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-07-28 Thread Igor Mammedov
It fixes migration failure for machine type pc-i440fx-1.7 from QEMU 1.7/2.0 to QEMU 2.1 Migration fails due to ACPI tables size grows across 1.7-2.1 versions. That causes ACPI tables ROM blob to change its size differently for the same configurations on different QEMU versions. As result

Re: [Qemu-devel] [PATCH for-2.1 1/2] migration: load smaller RAMBlock to a bigger one if permitted

2014-07-28 Thread Laszlo Ersek
On 07/28/14 09:40, Igor Mammedov wrote: On Fri, 25 Jul 2014 19:56:40 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/25/14 17:48, Igor Mammedov wrote: Add API to mark memory region as extend-able on migration, to allow migration code to load smaller RAMBlock into a bigger one on

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

2014-07-28 Thread Paolo Bonzini
Il 27/07/2014 08:57, Jan Kiszka ha scritto: From: Jan Kiszka jan.kis...@siemens.com According to ICH9 spec, the MSI capability is located at 0x60. This is important for guest drivers that do not parse the capability chain and use absolute addresses instead. Signed-off-by: Jan Kiszka

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Fix MSI capability address

2014-07-28 Thread Jan Kiszka
On 2014-07-28 10:11, Paolo Bonzini wrote: Il 27/07/2014 08:57, Jan Kiszka ha scritto: From: Jan Kiszka jan.kis...@siemens.com According to ICH9 spec, the MSI capability is located at 0x60. This is important for guest drivers that do not parse the capability chain and use absolute addresses

Re: [Qemu-devel] [PATCH for-2.1 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 09:56, Igor Mammedov ha scritto: It doesn't handle the case of ACPI tables that shrink, which can happen as well. I guess if this ever happens we can just hard-code the table size of the old versions to something big enough (64K?) and keep using fine-grained sizing. That

Re: [Qemu-devel] [PATCH for-2.1 v2 1/2] migration: load smaller RAMBlock to a bigger one if permitted

2014-07-28 Thread Laszlo Ersek
On 07/28/14 10:03, Igor Mammedov wrote: Add API to mark memory region as extend-able on migration, to allow migration code to load smaller RAMBlock into a bigger one on destination QEMU instance. This will allow to fix broken migration from QEMU 1.7/2.0 to QEMU 2.1 due to ACPI tables size

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread mateusz.krzywicki
Hey, Yup, thanks, task closed ;-) Best regards, Mateusz Krzywicki From: arei.gong...@huawei.com To: mateusz.krzywi...@windowslive.com; qemu-devel@nongnu.org CC: stefa...@redhat.com; kw...@redhat.com Subject: RE: [Qemu-devel] Possible null-ptr dereference Date: Mon, 28 Jul 2014 06:03:45 +

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gerd Hoffmann
Hi, ... because you can just copy the suffix from the old entry here, instead of expecting the caller pass it in. Okay, agreed. But we should also think about the situation which a device don't have old entry in global fw_boot_order list. Throw an error? I think it is ok to allow

Re: [Qemu-devel] [RFC PATCH v2 08/49] hpet: fixing saving and loading process

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: VM clock does not run while saving, so there is no need for saving the ticks in HPET. Also added saving of hpet_offset field. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/hpet.c | 13 + 1 files changed,

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Monday, July 28, 2014 4:31 PM Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function Hi, ... because you can just copy the suffix from the old entry here, instead of expecting the

Re: [Qemu-devel] [PATCH for-2.1 v2 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-07-28 Thread Igor Mammedov
On Mon, 28 Jul 2014 08:03:25 + Igor Mammedov imamm...@redhat.com wrote: It fixes migration failure for machine type pc-i440fx-1.7 from QEMU 1.7/2.0 to QEMU 2.1 Migration fails due to ACPI tables size grows across 1.7-2.1 versions. That causes ACPI tables ROM blob to change its size

Re: [Qemu-devel] [RFC PATCH v2 07/49] kvmapic: fixing loading vmstate

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: vapic state should not be synchronized with APIC while loading, because APIC state could be not loaded yet at that moment. We just save vapic_paddr in APIC VMState instead of synchronization. This comment is now obsolete:

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-07-28 Thread Hu Tao
ping... All the 6 patches have reviewed-by now. On Fri, Jul 11, 2014 at 02:09:57PM +0800, Hu Tao wrote: This series adds two preallocation mode to qcow2 and raw: Option preallocation=full preallocates disk space for image by writing zeros to disk, this ensures disk space in any cases.

[Qemu-devel] [PATCH for-2.1 v3 2/2] acpi: mark ACPI tables ROM blob as extend-able on migration

2014-07-28 Thread Igor Mammedov
It fixes migration failure for machine type pc-i440fx-1.7 from QEMU 1.7/2.0 to QEMU 2.1 Migration fails due to ACPI tables size grows across 1.7-2.1 versions. That causes ACPI tables ROM blob to change its size differently for the same configurations on different QEMU versions. As result

Re: [Qemu-devel] [PATCH 2/7] tests: Add virtio device initialization

2014-07-28 Thread Stefan Hajnoczi
On Fri, Jul 25, 2014 at 07:01:47PM +0200, Marc Marí wrote: @@ -73,3 +97,11 @@ QVirtioPCIDevice *qvirtio_pci_device_find(QPCIBus *bus, uint16_t device_type) return dev; } + +void qvirtio_pci_enable_device(QVirtioPCIDevice *d) +{ +qpci_device_enable(d-pdev); +

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gerd Hoffmann
I think it is ok to allow only *changing* the bootindex. Yes, that's no problem. But then yoy always will have a old entry where you can take the suffix from, and you don't need the suffix as parameter for the monitor command. cheers, Gerd

Re: [Qemu-devel] [RFC PATCH v2 09/49] pckbd: adding new fields to vmstate

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/input/pckbd.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
Hi, -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Monday, July 28, 2014 5:28 PM Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function I think it is ok to allow only *changing* the bootindex. Yes, that's no problem. But then

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/net/rtl8139.c |5 - 1 files

Re: [Qemu-devel] [RFC PATCH v2 12/49] mc146818rtc: add missed field to vmstate

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:03, Pavel Dovgalyuk ha scritto: This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/mc146818rtc.c |3 ++- 1 files changed, 2

Re: [Qemu-devel] [RFC PATCH v2 04/49] fdc: adding vmstate for save/restore

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: VMState added by this patch preserves correct loading of the FDC device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/block/fdc.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Stefan Hajnoczi
On Mon, Jul 28, 2014 at 06:03:45AM +, Gonglei (Arei) wrote: Hi, Should be easy to fix though. Does the following help? (Cc'ing Stefan Kevin) -- xen_disk: fix possible null-ptr dereference Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/block/xen_disk.c | 1 + 1 file

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Gonglei (Arei)
-Original Message- From: Stefan Hajnoczi [mailto:stefa...@redhat.com] Sent: Monday, July 28, 2014 5:49 PM To: Gonglei (Arei) Cc: mateusz.krzywi...@windowslive.com; qemu-devel@nongnu.org; kw...@redhat.com Subject: Re: [Qemu-devel] Possible null-ptr dereference On Mon, Jul 28, 2014

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel

Re: [Qemu-devel] [RFC PATCH v2 06/49] serial: fixing vmstate for save/restore

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: -.version_id = 3, +.version_id = 4, .minimum_version_id = 2, .pre_save = serial_pre_save, .post_load = serial_post_load, .fields = (VMStateField[]) { VMSTATE_UINT16_V(divider, SerialState, 2),

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Peter Maydell
On 28 July 2014 10:49, Stefan Hajnoczi stefa...@redhat.com wrote: On Mon, Jul 28, 2014 at 06:03:45AM +, Gonglei (Arei) wrote: Hi, Should be easy to fix though. Does the following help? (Cc'ing Stefan Kevin) -- xen_disk: fix possible null-ptr dereference Signed-off-by: Gonglei

Re: [Qemu-devel] [RFC PATCH v2 05/49] parallel: adding vmstate for save/restore

2014-07-28 Thread Paolo Bonzini
Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: +.fields = (VMStateField []) { +VMSTATE_UINT8(state.dataw, ISAParallelState), +VMSTATE_UINT8(state.datar, ISAParallelState), +VMSTATE_UINT8(state.status, ISAParallelState), +VMSTATE_UINT8(state.control,

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gerd Hoffmann
Hi, I think it is ok to allow only *changing* the bootindex. Yes, that's no problem. But then yoy always will have a old entry where you can take the suffix from, and you don't need the suffix as parameter for the monitor command. No, optional. Because the bootindex

Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 11:54, Pavel Dovgaluk ha scritto: +VMSTATE_TIMER_V(timer, RTL8139State, 5), timer need not be migrated, because it is reinstated by rtl8139_post_load. That's true for normal execution. In replay execution mode post_load can be called before cached virtual

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 09:50, Pavel Dovgaluk ha scritto: - patches 2 to 13 probably should try to use subsections, so that VMs that do not use the devices try not to save the extra data and keep backwards migration compatibility (at least try to) Could you give me and example? As I know,

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Monday, July 28, 2014 6:02 PM Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function Hi, I think it is ok to allow only *changing* the bootindex. Yes, that's no problem.

Re: [Qemu-devel] [PATCH v2 7/7] libqos: Added basic virtqueue support to virtio implementation

2014-07-28 Thread Marc Marí
El Fri, 25 Jul 2014 23:37:43 +0200 Marc Marí marc.mari.barc...@gmail.com escribió: + +data = g_malloc0(512); +memread(r_req+16, data, 512); +g_assert_cmpstr(data, ==, TEST); +g_free(data); + guest_free() for both requests should be added here. Will be added for v3 +/*

Re: [Qemu-devel] [PULL for-2.1] Trivial patch for 2014-07-26

2014-07-28 Thread Peter Maydell
On 26 July 2014 08:18, Michael Tokarev m...@tls.msk.ru wrote: There's just one trivial patch this time, fixing another occurence of allows to in help text. Please consider applying for 2.1. Thanks, /mjt The following changes since commit c60a57ff497667780132a3fcdc1500c83af5d5c0:

Re: [Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak

2014-07-28 Thread Alexander Graf
On 25.07.14 08:52, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com get_boot_devices_list() will malloc memory, spapr_finalize_fdt doesn't free it. Signed-off-by: Chenliang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Thanks, applied to

[Qemu-devel] [PATCH] target-mips: Ignore unassigned accesses with KVM

2014-07-28 Thread James Hogan
MIPS registers an unassigned access handler which raises a guest bus error exception. However this causes QEMU to crash when KVM is enabled as it isn't called from the main execution loop so longjmp() gets called without a corresponding setjmp(). Until the KVM API can be updated to trigger a

Re: [Qemu-devel] [PATCH v2 for-2.1 2/2] pc: hack for migration compatibility from QEMU 2.0

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 13:45, Michael S. Tsirkin ha scritto: +/* These are used to size the ACPI tables for -M pc-i440fx-1.7 and + * -M pc-i440fx-2.0. Let's just say 2.0 and earlier? This would give the idea that 1.6 is broken, but it isn't. Even if the actual amount of AML generated grows + * a

Re: [Qemu-devel] [PATCH v12 1/4] spapr_pci: Make find_phb()/find_dev() public

2014-07-28 Thread Alexander Graf
On 16.07.14 02:20, Gavin Shan wrote: From: Alexey Kardashevskiy a...@ozlabs.ru This makes find_phb()/find_dev() public and changed its names to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) or VFIO PCI

Re: [Qemu-devel] [PATCH v12 3/4] headers: Update kernel header

2014-07-28 Thread Alexander Graf
On 16.07.14 03:40, Gavin Shan wrote: On Wed, Jul 16, 2014 at 11:32:13AM +1000, Alexey Kardashevskiy wrote: On 07/16/2014 11:16 AM, Gavin Shan wrote: On Wed, Jul 16, 2014 at 11:09:44AM +1000, Alexey Kardashevskiy wrote: On 07/16/2014 10:20 AM, Gavin Shan wrote: This updates kernel header

Re: [Qemu-devel] [PATCH] pty: Fix byte loss bug when connecting to pty

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 13:39, Sebastian Tanase ha scritto: When trying to print data to the pty, we first check if it is connected. If not, we try to reconnect, but we drop the pending data even if we have successfully reconnected; this makes us lose the first byte of the very first transmission. This

Re: [Qemu-devel] [PULL for-2.1 0/3] Last minute patches

2014-07-28 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 25 July 2014 15:22, Paolo Bonzini pbonz...@redhat.com wrote: Since Igor hasn't sent his patches, and I'm leaving the office, I pushed this to git://github.com/bonzini/qemu.git tags/for-upstream-full I don't know about

Re: [Qemu-devel] [Bug 1343827] [NEW] block.c: multiwrite_merge() truncates overlapping requests

2014-07-28 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 10:15 AM, Slava Pestov sviatoslav.pes...@gmail.com wrote: Public bug reported: If the list of requests passed to multiwrite_merge() contains two requests where the first is for a range of sectors that is a strict subset of the second's, the second request is truncated

Re: [Qemu-devel] [PULL for-2.1 0/3] Last minute patches

2014-07-28 Thread Igor Mammedov
On Mon, 28 Jul 2014 14:59:26 +0200 Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: On 25 July 2014 15:22, Paolo Bonzini pbonz...@redhat.com wrote: Since Igor hasn't sent his patches, and I'm leaving the office, I pushed this to

Re: [Qemu-devel] [PATCH 0/4 v8] ppc: Add debug stub support

2014-07-28 Thread Alexander Graf
On 14.07.14 11:15, Bharat Bhushan wrote: This patchset add support for - software breakpoint - h/w breakpoint - h/w watchpoint Please find description in individual patch. Thanks, applied (with minor edits in comments) to ppc-next-2.2. Alex

Re: [Qemu-devel] [PATCH 3/3] ppc/spapr: Fix MAX_CPUS to 255

2014-07-28 Thread Alexander Graf
On 27.06.14 08:47, Nikunj A Dadhania wrote: MAX_CPUS 256 is inconsistent with qemu supporting upto 255 cpus. This MAX_CPUS number was percolated back to virsh capabilities with wrong max_cpus. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com Nice one :). Thanks, applied to

Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm

2014-07-28 Thread Alexander Graf
On 10.07.14 15:27, David Hildenbrand wrote: This is the qemu part of kernel series Let user space control the cpu states Christian Borntraeger (1): update linux headers with with cpustate changes David Hildenbrand (4): s390x/kvm: introduce proper states for s390 cpus s390x/kvm:

Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm

2014-07-28 Thread Alexander Graf
On 28.07.2014, at 15:43, Alexander Graf ag...@suse.de wrote: On 10.07.14 15:27, David Hildenbrand wrote: This is the qemu part of kernel series Let user space control the cpu states Christian Borntraeger (1): update linux headers with with cpustate changes David Hildenbrand (4):

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking has_work

2014-07-28 Thread Alexander Graf
On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand d...@linux.vnet.ibm.com If a cpu is stopped, it must never be allowed to run and no interrupt may wake it up. A cpu also has to be unhalted if it is halted and has work to do - this scenario wasn't hit in kvm case yet, as

Re: [Qemu-devel] [PATCH v12 1/4] spapr_pci: Make find_phb()/find_dev() public

2014-07-28 Thread Alexey Kardashevskiy
On 07/28/2014 10:49 PM, Alexander Graf wrote: On 16.07.14 02:20, Gavin Shan wrote: From: Alexey Kardashevskiy a...@ozlabs.ru This makes find_phb()/find_dev() public and changed its names to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to be used from other parts of QEMU such

[Qemu-devel] [PATCH v3 0/5] ACPI fixes for QEMU 2.1

2014-07-28 Thread Paolo Bonzini
v2-v3: fix tests/acpi-test-data/pc/DSDT [Peter] track down make check failure, fix it [patch 4, me] split patch 2 in two parts [mst] do not make bsel_alloc global [mst] include Igor's bridge patch [mst, as discussed on IRC] Igor Mammedov (1): pc: acpi:

[Qemu-devel] [PATCH 1/5] acpi-dsdt: procedurally generate _PRT

2014-07-28 Thread Paolo Bonzini
This replaces the _PRT constant with a method that computes it. The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, enough to cross the 8k barrier (we align the ACPI tables to 4k before putting them in fw_cfg). This causes problems with migration and the pc-i440fx-2.0 machine type.

[Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0

2014-07-28 Thread Paolo Bonzini
Changing the ACPI table size causes migration to break, and the memory hotplug work opened our eyes on how horribly we were breaking things in 2.0 already. The ACPI table size is rounded to the next 4k, which one would think gives some headroom. In practice this is not the case, because the user

[Qemu-devel] [PATCH 3/5] pc: future-proof migration-compatibility of ACPI tables

2014-07-28 Thread Paolo Bonzini
This patch avoids that similar changes break QEMU again in the future. QEMU will now hard-code 64k as the maximum ACPI table size, which (despite being an order of magnitude smaller than 640k) should be enough for everyone. Reviewed-by: Laszlo Ersek ler...@redhat.com Tested-by: Igor Mammedov

[Qemu-devel] [PATCH 4/5] bios-tables-test: fix ASL normalization false positive

2014-07-28 Thread Paolo Bonzini
My version of IASL (from RHEL7) puts two newlines between the head comment and the DefinitionBlock property. One was already removed because the test uses sizeof instead of strlen, but the extra one breaks the detection of DefinitionBlock. Killing all newlines after the comment drops the

[Qemu-devel] [PATCH 5/5] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled

2014-07-28 Thread Paolo Bonzini
From: Igor Mammedov imamm...@redhat.com Fixes migration regression from QEMU-1.7 to a newer QEMUs. SSDT table size in QEMU-1.7 doesn't change regardless of a number of PCI bridge devices present at startup. However in QEMU-2.0 since addition of hotplug on PCI bridges, each PCI bridge adds ~1875

Re: [Qemu-devel] [PATCH] e1000: Delay LSC until mask is active

2014-07-28 Thread Alexander Graf
On 03.07.14 22:18, Michael S. Tsirkin wrote: On Thu, Jul 03, 2014 at 08:00:04PM +0200, Alexander Graf wrote: On 03.07.14 19:57, Peter Maydell wrote: On 3 July 2014 18:39, Alexander Graf ag...@suse.de wrote: Mac OS X reads ICR on every interrupt. When the IRQ line is shared, this may result

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking has_work

2014-07-28 Thread David Hildenbrand
On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand d...@linux.vnet.ibm.com If a cpu is stopped, it must never be allowed to run and no interrupt may wake it up. A cpu also has to be unhalted if it is halted and has work to do - this scenario wasn't hit in kvm

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking has_work

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 16:16, David Hildenbrand ha scritto: Later, another vcpu might decide to turn that vcpu back on (by e.g. sending a SIGP START to that vcpu). I am not sure if such a mechanism/scenario is applicable to any other arch. They all seem to reset the cs-halted flag if they know they

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking has_work

2014-07-28 Thread Alexander Graf
On 28.07.2014, at 16:16, David Hildenbrand d...@linux.vnet.ibm.com wrote: On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand d...@linux.vnet.ibm.com If a cpu is stopped, it must never be allowed to run and no interrupt may wake it up. A cpu also has to be unhalted

Re: [Qemu-devel] [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking has_work

2014-07-28 Thread David Hildenbrand
On 28.07.2014, at 16:16, David Hildenbrand d...@linux.vnet.ibm.com wrote: On 10.07.14 15:10, Christian Borntraeger wrote: From: David Hildenbrand d...@linux.vnet.ibm.com If a cpu is stopped, it must never be allowed to run and no interrupt may wake it up. A cpu also has to be

Re: [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0

2014-07-28 Thread Michael S. Tsirkin
On Mon, Jul 28, 2014 at 04:02:12PM +0200, Paolo Bonzini wrote: Changing the ACPI table size causes migration to break, and the memory hotplug work opened our eyes on how horribly we were breaking things in 2.0 already. The ACPI table size is rounded to the next 4k, which one would think

Re: [Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 17:05, Michael S. Tsirkin ha scritto: +/* These are used to size the ACPI tables for -M pc-i440fx-1.7 and + * -M pc-i440fx-2.0. Even if the actual amount of AML generated grows + * a little bit, there should be plenty of free space since the DSDT + * shrunk by ~1.5k between

[Qemu-devel] [PATCH 1/5] scsi-bus: prepare scsi_req_new for introduction of parse_cdb

2014-07-28 Thread Paolo Bonzini
The per-SCSIDevice parse_cdb callback must not be called if the request will go through special SCSIReqOps, so detect the special cases early enough. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 51 ++- 1 file changed,

[Qemu-devel] [PATCH for-2.2 v2 0/5] scsi: enable passthrough of vendor-specific commands

2014-07-28 Thread Paolo Bonzini
Right now scsi-generic is parsing the CDB, in order to compute the expected number of bytes to be transferred. This is necessary if DMA is done by the HBA via scsi_req_data, but it prevents executing vendor-specific commands via scsi-generic because we don't know how to parse them. If DMA is

[Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-28 Thread Paolo Bonzini
This will be used for both scsi_block_new_request and the scsi-block implementation of parse_cdb. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-disk.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git

[Qemu-devel] [PATCH 4/5] scsi-block, scsi-generic: implement parse_cdb

2014-07-28 Thread Paolo Bonzini
The callback lets the bus provide the direction and transfer count for passthrough commands, enabling passthrough of vendor-specific commands. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 3 +-- hw/scsi/scsi-disk.c| 14 ++ hw/scsi/scsi-generic.c

[Qemu-devel] [PATCH 2/5] scsi-bus: introduce parse_cdb in SCSIDeviceClass and SCSIBusInfo

2014-07-28 Thread Paolo Bonzini
These callbacks will let devices do their own request parsing, or defer it to the bus. If the bus does not provide an implementation, in turn, fall back to the default parsing routine. Swap the first two arguments to scsi_req_parse, and rename it to scsi_req_parse_cdb, for consistency.

[Qemu-devel] [PATCH 5/5] virtio-scsi: implement parse_cdb

2014-07-28 Thread Paolo Bonzini
Enable passthrough of vendor-specific commands. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/virtio-scsi.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 0eb069a..2dd9255 100644 ---

Re: [Qemu-devel] [PATCH v5 2/2] vmdk: Optimize cluster allocation

2014-07-28 Thread Stefan Hajnoczi
On Tue, May 27, 2014 at 04:49:22PM +0800, Fam Zheng wrote: +if (!bs-backing_hd) { +memset(whole_grain, 0, skip_start_sector BDRV_SECTOR_BITS); +memset(whole_grain + (skip_end_sector BDRV_SECTOR_BITS), 0, + cluster_bytes - (skip_end_sector

Re: [Qemu-devel] [PATCH for 2.1 V3] qemu-img info: show nocow info

2014-07-28 Thread Stefan Hajnoczi
On Wed, Jul 09, 2014 at 10:43:13AM +0800, Chunyan Liu wrote: Add nocow info in 'qemu-img info' output to show whether the file currently has NOCOW flag set or not. Signed-off-by: Chunyan Liu cy...@suse.com --- Changes: - update output info to NOCOW flag: set block/qapi.c | 25

[Qemu-devel] [PATCH v4 0/5] ACPI fixes for QEMU 2.1

2014-07-28 Thread Paolo Bonzini
v3-v4: drop all pretense of supporting bridges [me] v2-v3: fix tests/acpi-test-data/pc/DSDT [Peter] track down make check failure, fix it [patch 4, me] split patch 2 in two parts [mst] do not make bsel_alloc global [mst] include Igor's bridge patch

[Qemu-devel] [PATCH 4/5] bios-tables-test: fix ASL normalization false positive

2014-07-28 Thread Paolo Bonzini
My version of IASL (from RHEL7) puts two newlines between the head comment and the DefinitionBlock property. Kill all newlines after the comment, so that normalize_asl works properly. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/bios-tables-test.c | 6 +- 1 file changed, 5

[Qemu-devel] [PATCH 1/5] acpi-dsdt: procedurally generate _PRT

2014-07-28 Thread Paolo Bonzini
This replaces the _PRT constant with a method that computes it. The problem is that the DSDT+SSDT have grown from 2.0 to 2.1, enough to cross the 8k barrier (we align the ACPI tables to 4k before putting them in fw_cfg). This causes problems with migration and the pc-i440fx-2.0 machine type.

[Qemu-devel] [PATCH 3/5] pc: future-proof migration-compatibility of ACPI tables

2014-07-28 Thread Paolo Bonzini
This patch avoids that similar changes break QEMU again in the future. QEMU will now hard-code 64k as the maximum ACPI table size, which (despite being an order of magnitude smaller than 640k) should be enough for everyone. Reviewed-by: Laszlo Ersek ler...@redhat.com Tested-by: Igor Mammedov

[Qemu-devel] [PATCH 5/5] pc: acpi: generate AML only for PCI0 devices if PCI bridge hotplug is disabled

2014-07-28 Thread Paolo Bonzini
From: Igor Mammedov imamm...@redhat.com Fixes migration regression from QEMU-1.7 to a newer QEMUs. SSDT table size in QEMU-1.7 doesn't change regardless of a number of PCI bridge devices present at startup. However in QEMU-2.0 since addition of hotplug on PCI bridges, each PCI bridge adds ~1875

[Qemu-devel] [PATCH 2/5] pc: hack for migration compatibility from QEMU 2.0

2014-07-28 Thread Paolo Bonzini
Changing the ACPI table size causes migration to break, and the memory hotplug work opened our eyes on how horribly we were breaking things in 2.0 already. The ACPI table size is rounded to the next 4k, which one would think gives some headroom. In practice this is not the case, because the user

[Qemu-devel] [PATCH 1/3] loader: add support for resizeable blobs

2014-07-28 Thread Michael S. Tsirkin
Support resizeable blobs: we allocate more memory than currently available in the blob, which can later be filled in. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 14 +++-- include/hw/nvram/fw_cfg.h | 2 +- hw/core/loader.c | 15 +

[Qemu-devel] [PATCH 2/3] migration: load smaller RAMBlock to a bigger one if permitted

2014-07-28 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com Add API to mark memory region as extend-able on migration, to allow migration code to load smaller RAMBlock into a bigger one on destination QEMU instance. This will allow to fix broken migration from QEMU 1.7/2.0 to QEMU 2.1 due to ACPI tables size

[Qemu-devel] [PATCH 3/3] loader: mark MR for resizeable blobs as extendable

2014-07-28 Thread Michael S. Tsirkin
This makes migration from older QEMU versions more robust. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/core/loader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index ad6ec67..fc00a87 100644 --- a/hw/core/loader.c +++

Re: [Qemu-devel] [PATCH 3/5] pc: future-proof migration-compatibility of ACPI tables

2014-07-28 Thread Michael S. Tsirkin
On Mon, Jul 28, 2014 at 05:34:16PM +0200, Paolo Bonzini wrote: This patch avoids that similar changes break QEMU again in the future. QEMU will now hard-code 64k as the maximum ACPI table size, which (despite being an order of magnitude smaller than 640k) should be enough for everyone. Famous

Re: [Qemu-devel] nic is lost, in the virtual machine running

2014-07-28 Thread Stefan Hajnoczi
On Sat, Jul 19, 2014 at 03:31:00PM +0800, melolinux wrote: 1. /usr/bin/qemu-system-x86_64 -machine accel=kvm -name a58970a2-10aa-4973-9261-7384b2f53221 -S -machine pc-0.14,accel=kvm,usb=off -m 4096 -smp 4,sockets=1,cores=4,threads=1 -uuid f3a2217f-ae5c-461b-a922-d37a3a98edc6 -no-user-config

Re: [Qemu-devel] [PATCH 3/5] pc: future-proof migration-compatibility of ACPI tables

2014-07-28 Thread Paolo Bonzini
Il 28/07/2014 17:59, Michael S. Tsirkin ha scritto: On Mon, Jul 28, 2014 at 05:34:16PM +0200, Paolo Bonzini wrote: This patch avoids that similar changes break QEMU again in the future. QEMU will now hard-code 64k as the maximum ACPI table size, which (despite being an order of magnitude

Re: [Qemu-devel] [Bug 1347387] [NEW] while i was created the new virtual machine using qemu the following error was shown in fedora version 20

2014-07-28 Thread Stefan Hajnoczi
On Wed, Jul 23, 2014 at 04:43:27AM -, selvakumar wrote: Public bug reported: [root@localhost pkgs]# qemu-img create virtualdisk.img 100M qemu-img: symbol lookup error: qemu-img: undefined symbol: glfs_discard_async CCing Fedora qemu-kvm package maintainer. Stefan [root@localhost

[Qemu-devel] Dynamic QEMU platform device instantiation in machine files: phone call on Wed July 30

2014-07-28 Thread Eric Auger
Dear all, For your information, a phone call will be held this week on Wed July 30, 17h-18h CET to address the topic of dynamic instantiation of QEMU platform devices in machine files (using the -device qemu option). Related threads are:

Re: [Qemu-devel] [PATCH v3] docs/multiple-iothreads.txt: add documentation on IOThread programming

2014-07-28 Thread Stefan Hajnoczi
On Wed, Jul 23, 2014 at 12:55:32PM +0100, Stefan Hajnoczi wrote: This document explains how IOThreads and the main loop are related, especially how to write code that can run in an IOThread. Currently only virtio-blk-data-plane uses these techniques. The next obvious target is virtio-scsi;

Re: [Qemu-devel] [PATCH for-2.1] qemu-options: fix another allows-to for -net l2tpv3

2014-07-28 Thread Stefan Hajnoczi
On Thu, Jul 24, 2014 at 08:11:26PM +0400, Michael Tokarev wrote: Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qemu-options.hx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 9e54686..1549625 100644 --- a/qemu-options.hx

[Qemu-devel] [PATCH v2 1/4] parallels: extend parallels format header with actual data values

2014-07-28 Thread Denis V. Lunev
Parallels image format has several additional fields inside: - nb_sectors is actually 64 bit wide. Upper 32bits are not used for images with signature WithoutFreeSpace and must be explicitly zeroed according to Parallels. They will be used for images with signature WithouFreSpacExt - inuse

[Qemu-devel] [PATCH v2 2/4] parallels: replace tabs with spaces in block/parallels.c

2014-07-28 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev d...@openvz.org Reviewed-by: Jeff Cody jc...@redhat.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi stefa...@redhat.com --- block/parallels.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block/parallels.c b/block/parallels.c

[Qemu-devel] [PATCH v2 3/4] parallels: split check for parallels format in parallels_open

2014-07-28 Thread Denis V. Lunev
and rework error path a bit. There is no difference at the moment, but the code will be definitely shorter when additional processing will be required for WithouFreSpacExt Signed-off-by: Denis V. Lunev d...@openvz.org CC: Jeff Cody jc...@redhat.com CC: Kevin Wolf kw...@redhat.com CC: Stefan

[Qemu-devel] [PATCH v2 0/4] block/parallels: 2TB+ parallels images support

2014-07-28 Thread Denis V. Lunev
Parallels has released in the recent updates of Parallels Server 5/6 new addition to his image format. Images with signature WithouFreSpacExt have offsets in the catalog coded not as offsets in sectors (multiple of 512 bytes) but offsets coded in blocks (i.e. header-tracks * 512) In this case to

[Qemu-devel] [PATCH v2 4/4] parallels: 2TB+ parallels images support

2014-07-28 Thread Denis V. Lunev
Parallels has released in the recent updates of Parallels Server 5/6 new addition to his image format. Images with signature WithouFreSpacExt have offsets in the catalog coded not as offsets in sectors (multiple of 512 bytes) but offsets coded in blocks (i.e. header-tracks * 512) In this case all

Re: [Qemu-devel] [Bug 1347387] [NEW] while i was created the new virtual machine using qemu the following error was shown in fedora version 20

2014-07-28 Thread Cole Robinson
On 07/28/2014 12:09 PM, Stefan Hajnoczi wrote: On Wed, Jul 23, 2014 at 04:43:27AM -, selvakumar wrote: Public bug reported: [root@localhost pkgs]# qemu-img create virtualdisk.img 100M qemu-img: symbol lookup error: qemu-img: undefined symbol: glfs_discard_async You need to update

[Qemu-devel] [Bug 1347387] Re: while i was created the new virtual machine using qemu the following error was shown in fedora version 20

2014-07-28 Thread Cole Robinson
** Changed in: qemu Status: New = Invalid ** Bug watch added: Red Hat Bugzilla #1096654 https://bugzilla.redhat.com/show_bug.cgi?id=1096654 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

  1   2   >